mlrun 1.7.0rc14__py3-none-any.whl → 1.7.0rc16__py3-none-any.whl

mlrun/model_monitoring/db/tsdb/v3io/stream_graph_steps.py

@@ -0,0 +1,117 @@
+# Copyright 2024 Iguazio
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+import mlrun.feature_store.steps
+from mlrun.common.schemas.model_monitoring import (
+    EventFieldType,
+    EventKeyMetrics,
+    EventLiveStats,
+)
+
+
+class ProcessBeforeTSDB(mlrun.feature_store.steps.MapClass):
+    def __init__(self, **kwargs):
+        """
+        Process the data before writing to TSDB. This step creates a dictionary that includes 3 different dictionaries
+        that each one of them contains important details and stats about the events:
+        1. base_metrics: stats about the average latency and the amount of predictions over time. It is based on
+           storey.AggregateByKey which was executed in step 5.
+        2. endpoint_features: feature names and values along with the prediction names and value.
+        3. custom_metric (opt): optional metrics provided by the user.
+        :returns: Dictionary of 2-3 dictionaries that contains stats and details about the events.
+        """
+        super().__init__(**kwargs)
+
+    def do(self, event):
+        # Compute prediction per second
+        event[EventLiveStats.PREDICTIONS_PER_SECOND] = (
+            float(event[EventLiveStats.PREDICTIONS_COUNT_5M]) / 300
+        )
+        base_fields = [
+            EventFieldType.TIMESTAMP,
+            EventFieldType.ENDPOINT_ID,
+            EventFieldType.ENDPOINT_TYPE,
+        ]
+
+        # Getting event timestamp and endpoint_id
+        base_event = {k: event[k] for k in base_fields}
+
+        # base_metrics includes the stats about the average latency and the amount of predictions over time
+        base_metrics = {
+            EventFieldType.RECORD_TYPE: EventKeyMetrics.BASE_METRICS,
+            EventLiveStats.PREDICTIONS_PER_SECOND: event[
+                EventLiveStats.PREDICTIONS_PER_SECOND
+            ],
+            EventLiveStats.PREDICTIONS_COUNT_5M: event[
+                EventLiveStats.PREDICTIONS_COUNT_5M
+            ],
+            EventLiveStats.PREDICTIONS_COUNT_1H: event[
+                EventLiveStats.PREDICTIONS_COUNT_1H
+            ],
+            EventLiveStats.LATENCY_AVG_5M: event[EventLiveStats.LATENCY_AVG_5M],
+            EventLiveStats.LATENCY_AVG_1H: event[EventLiveStats.LATENCY_AVG_1H],
+            **base_event,
+        }
+
+        # endpoint_features includes the event values of each feature and prediction
+        endpoint_features = {
+            EventFieldType.RECORD_TYPE: EventKeyMetrics.ENDPOINT_FEATURES,
+            **event[EventFieldType.NAMED_PREDICTIONS],
+            **event[EventFieldType.NAMED_FEATURES],
+            **base_event,
+        }
+        # Create a dictionary that includes both base_metrics and endpoint_features
+        processed = {
+            EventKeyMetrics.BASE_METRICS: base_metrics,
+            EventKeyMetrics.ENDPOINT_FEATURES: endpoint_features,
+        }
+
+        # If metrics provided, add another dictionary if custom_metrics values
+        if event[EventFieldType.METRICS]:
+            processed[EventKeyMetrics.CUSTOM_METRICS] = {
+                EventFieldType.RECORD_TYPE: EventKeyMetrics.CUSTOM_METRICS,
+                **event[EventFieldType.METRICS],
+                **base_event,
+            }
+
+        return processed
+
+
+class FilterAndUnpackKeys(mlrun.feature_store.steps.MapClass):
+    def __init__(self, keys, **kwargs):
+        """
+        Create unpacked event dictionary based on provided key metrics (base_metrics, endpoint_features,
+        or custom_metric). Please note that the next step of the TSDB target requires an unpacked dictionary.
+        :param keys: list of key metrics.
+        :returns: An unpacked dictionary of event filtered by the provided key metrics.
+        """
+        super().__init__(**kwargs)
+        self.keys = keys
+
+    def do(self, event):
+        # Keep only the relevant dictionary based on the provided keys
+        new_event = {}
+        for key in self.keys:
+            if key in event:
+                new_event[key] = event[key]
+
+        # Create unpacked dictionary
+        unpacked = {}
+        for key in new_event.keys():
+            if key in self.keys:
+                unpacked = {**unpacked, **new_event[key]}
+            else:
+                unpacked[key] = new_event[key]
+        return unpacked if unpacked else None

mlrun/model_monitoring/db/tsdb/v3io/v3io_connector.py

@@ -0,0 +1,404 @@
+# Copyright 2024 Iguazio
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import datetime
+
+import pandas as pd
+import v3io_frames.client
+import v3io_frames.errors
+from v3io.dataplane import Client as V3IOClient
+from v3io_frames.frames_pb2 import IGNORE
+
+import mlrun.common.model_monitoring
+import mlrun.common.schemas.model_monitoring as mm_constants
+import mlrun.feature_store.steps
+import mlrun.utils.v3io_clients
+from mlrun.model_monitoring.db import TSDBConnector
+from mlrun.utils import logger
+
+_TSDB_BE = "tsdb"
+_TSDB_RATE = "1/s"
+
+
+class V3IOTSDBConnector(TSDBConnector):
+    """
+    Handles the TSDB operations when the TSDB connector is of type V3IO. To manage these operations we use V3IO Frames
+    Client that provides API for executing commands on the V3IO TSDB table.
+    """
+
+    def __init__(
+        self,
+        project: str,
+        access_key: str = None,
+        container: str = "users",
+        v3io_framesd: str = None,
+        create_table: bool = False,
+    ):
+        super().__init__(project=project)
+        self.access_key = access_key or mlrun.mlconf.get_v3io_access_key()
+
+        self.container = container
+
+        self.v3io_framesd = v3io_framesd or mlrun.mlconf.v3io_framesd
+        self._frames_client: v3io_frames.client.ClientBase = (
+            self._get_v3io_frames_client(self.container)
+        )
+        self._v3io_client: V3IOClient = mlrun.utils.v3io_clients.get_v3io_client(
+            endpoint=mlrun.mlconf.v3io_api,
+        )
+
+        self._init_tables_path()
+
+        if create_table:
+            self.create_tsdb_application_tables()
+
+    def _init_tables_path(self):
+        self.tables = {}
+
+        events_table_full_path = mlrun.mlconf.get_model_monitoring_file_target_path(
+            project=self.project,
+            kind=mm_constants.FileTargetKind.EVENTS,
+        )
+        (
+            _,
+            _,
+            events_path,
+        ) = mlrun.common.model_monitoring.helpers.parse_model_endpoint_store_prefix(
+            events_table_full_path
+        )
+        self.tables[mm_constants.MonitoringTSDBTables.EVENTS] = events_path
+
+        monitoring_application_full_path = (
+            mlrun.mlconf.get_model_monitoring_file_target_path(
+                project=self.project,
+                kind=mm_constants.FileTargetKind.MONITORING_APPLICATION,
+            )
+        )
+        (
+            _,
+            _,
+            monitoring_application_path,
+        ) = mlrun.common.model_monitoring.helpers.parse_model_endpoint_store_prefix(
+            monitoring_application_full_path
+        )
+        self.tables[mm_constants.MonitoringTSDBTables.APP_RESULTS] = (
+            monitoring_application_path + mm_constants.MonitoringTSDBTables.APP_RESULTS
+        )
+        self.tables[mm_constants.MonitoringTSDBTables.METRICS] = (
+            monitoring_application_path + mm_constants.MonitoringTSDBTables.METRICS
+        )
+
+    def create_tsdb_application_tables(self):
+        """
+        Create the application tables using the TSDB connector. At the moment we support 2 types of application tables:
+        - app_results: a detailed result that includes status, kind, extra data, etc.
+        - metrics: a basic key value that represents a single numeric metric.
+        """
+        application_tables = [
+            mm_constants.MonitoringTSDBTables.APP_RESULTS,
+            mm_constants.MonitoringTSDBTables.METRICS,
+        ]
+        for table in application_tables:
+            logger.info("Creating table in V3IO TSDB", table=table)
+            self._frames_client.create(
+                backend=_TSDB_BE,
+                table=self.tables[table],
+                if_exists=IGNORE,
+                rate=_TSDB_RATE,
+            )
+
+    def apply_monitoring_stream_steps(
+        self,
+        graph,
+        tsdb_batching_max_events: int = 10,
+        tsdb_batching_timeout_secs: int = 300,
+    ):
+        """
+        Apply TSDB steps on the provided monitoring graph. Throughout these steps, the graph stores live data of
+        different key metric dictionaries.This data is being used by the monitoring dashboards in
+        grafana. Results can be found under  v3io:///users/pipelines/project-name/model-endpoints/events/.
+        In that case, we generate 3 different key  metric dictionaries:
+        - base_metrics (average latency and predictions over time)
+        - endpoint_features (Prediction and feature names and values)
+        - custom_metrics (user-defined metrics)
+        """
+
+        # Before writing data to TSDB, create dictionary of 2-3 dictionaries that contains
+        # stats and details about the events
+
+        def apply_process_before_tsdb():
+            graph.add_step(
+                "mlrun.model_monitoring.db.tsdb.v3io.stream_graph_steps.ProcessBeforeTSDB",
+                name="ProcessBeforeTSDB",
+                after="sample",
+            )
+
+        apply_process_before_tsdb()
+
+        # Unpacked keys from each dictionary and write to TSDB target
+        def apply_filter_and_unpacked_keys(name, keys):
+            graph.add_step(
+                "mlrun.model_monitoring.db.tsdb.v3io.stream_graph_steps.FilterAndUnpackKeys",
+                name=name,
+                after="ProcessBeforeTSDB",
+                keys=[keys],
+            )
+
+        def apply_tsdb_target(name, after):
+            graph.add_step(
+                "storey.TSDBTarget",
+                name=name,
+                after=after,
+                path=f"{self.container}/{self.tables[mm_constants.MonitoringTSDBTables.EVENTS]}",
+                rate="10/m",
+                time_col=mm_constants.EventFieldType.TIMESTAMP,
+                container=self.container,
+                v3io_frames=self.v3io_framesd,
+                infer_columns_from_data=True,
+                index_cols=[
+                    mm_constants.EventFieldType.ENDPOINT_ID,
+                    mm_constants.EventFieldType.RECORD_TYPE,
+                    mm_constants.EventFieldType.ENDPOINT_TYPE,
+                ],
+                max_events=tsdb_batching_max_events,
+                flush_after_seconds=tsdb_batching_timeout_secs,
+                key=mm_constants.EventFieldType.ENDPOINT_ID,
+            )
+
+        # unpacked base_metrics dictionary
+        apply_filter_and_unpacked_keys(
+            name="FilterAndUnpackKeys1",
+            keys=mm_constants.EventKeyMetrics.BASE_METRICS,
+        )
+        apply_tsdb_target(name="tsdb1", after="FilterAndUnpackKeys1")
+
+        # unpacked endpoint_features dictionary
+        apply_filter_and_unpacked_keys(
+            name="FilterAndUnpackKeys2",
+            keys=mm_constants.EventKeyMetrics.ENDPOINT_FEATURES,
+        )
+        apply_tsdb_target(name="tsdb2", after="FilterAndUnpackKeys2")
+
+        # unpacked custom_metrics dictionary. In addition, use storey.Filter remove none values
+        apply_filter_and_unpacked_keys(
+            name="FilterAndUnpackKeys3",
+            keys=mm_constants.EventKeyMetrics.CUSTOM_METRICS,
+        )
+
+        def apply_storey_filter():
+            graph.add_step(
+                "storey.Filter",
+                "FilterNotNone",
+                after="FilterAndUnpackKeys3",
+                _fn="(event is not None)",
+            )
+
+        apply_storey_filter()
+        apply_tsdb_target(name="tsdb3", after="FilterNotNone")
+
+    def write_application_event(
+        self,
+        event: dict,
+        kind: mm_constants.WriterEventKind = mm_constants.WriterEventKind.RESULT,
+    ):
+        """Write a single result or metric to TSDB"""
+
+        event[mm_constants.WriterEvent.END_INFER_TIME] = (
+            datetime.datetime.fromisoformat(
+                event[mm_constants.WriterEvent.END_INFER_TIME]
+            )
+        )
+
+        if kind == mm_constants.WriterEventKind.METRIC:
+            # TODO : Implement the logic for writing metrics to V3IO TSDB
+            return
+
+        del event[mm_constants.ResultData.RESULT_EXTRA_DATA]
+        try:
+            self._frames_client.write(
+                backend=_TSDB_BE,
+                table=self.tables[mm_constants.MonitoringTSDBTables.APP_RESULTS],
+                dfs=pd.DataFrame.from_records([event]),
+                index_cols=[
+                    mm_constants.WriterEvent.END_INFER_TIME,
+                    mm_constants.WriterEvent.ENDPOINT_ID,
+                    mm_constants.WriterEvent.APPLICATION_NAME,
+                    mm_constants.ResultData.RESULT_NAME,
+                ],
+            )
+            logger.info(
+                "Updated V3IO TSDB successfully",
+                table=self.tables[mm_constants.MonitoringTSDBTables.APP_RESULTS],
+            )
+        except v3io_frames.errors.Error as err:
+            logger.warn(
+                "Could not write drift measures to TSDB",
+                err=err,
+                table=self.tables[mm_constants.MonitoringTSDBTables.APP_RESULTS],
+                event=event,
+            )
+
+            raise mlrun.errors.MLRunRuntimeError(
+                f"Failed to write application result to TSDB: {err}"
+            )
+
+    def delete_tsdb_resources(self, table: str = None):
+        if table:
+            # Delete a specific table
+            tables = [table]
+        else:
+            # Delete all tables
+            tables = mm_constants.MonitoringTSDBTables.list()
+        for table in tables:
+            try:
+                self._frames_client.delete(
+                    backend=mlrun.common.schemas.model_monitoring.TimeSeriesConnector.TSDB,
+                    table=table,
+                )
+            except v3io_frames.errors.DeleteError as e:
+                logger.warning(
+                    f"Failed to delete TSDB table '{table}'",
+                    err=mlrun.errors.err_to_str(e),
+                )
+
+        # Final cleanup of tsdb path
+        tsdb_path = self._get_v3io_source_directory()
+        tsdb_path.replace("://u", ":///u")
+        store, _, _ = mlrun.store_manager.get_or_create_store(tsdb_path)
+        store.rm(tsdb_path, recursive=True)
+
+    def get_model_endpoint_real_time_metrics(
+        self,
+        endpoint_id: str,
+        metrics: list[str],
+        start: str = "now-1h",
+        end: str = "now",
+    ) -> dict[str, list[tuple[str, float]]]:
+        """
+        Getting real time metrics from the TSDB. There are pre-defined metrics for model endpoints such as
+        `predictions_per_second` and `latency_avg_5m` but also custom metrics defined by the user. Note that these
+        metrics are being calculated by the model monitoring stream pod.
+        :param endpoint_id:      The unique id of the model endpoint.
+        :param metrics:          A list of real-time metrics to return for the model endpoint.
+        :param start:            The start time of the metrics. Can be represented by a string containing an RFC 3339
+                                 time, a Unix timestamp in milliseconds, a relative time (`'now'` or
+                                 `'now-[0-9]+[mhd]'`, where `m` = minutes, `h` = hours, `'d'` = days, and
+                                 `'s'` = seconds), or 0 for the earliest time.
+        :param end:              The end time of the metrics. Can be represented by a string containing an RFC 3339
+                                 time, a Unix timestamp in milliseconds, a relative time (`'now'` or
+                                 `'now-[0-9]+[mhd]'`, where `m` = minutes, `h` = hours, and `'d'` = days, and
+                                 `'s'` = seconds), or 0 for the earliest time.
+        :return: A dictionary of metrics in which the key is a metric name and the value is a list of tuples that
+                 includes timestamps and the values.
+        """
+
+        if not metrics:
+            raise mlrun.errors.MLRunInvalidArgumentError(
+                "Metric names must be provided"
+            )
+
+        metrics_mapping = {}
+
+        try:
+            data = self.get_records(
+                table=mm_constants.MonitoringTSDBTables.EVENTS,
+                columns=["endpoint_id", *metrics],
+                filter_query=f"endpoint_id=='{endpoint_id}'",
+                start=start,
+                end=end,
+            )
+
+            # Fill the metrics mapping dictionary with the metric name and values
+            data_dict = data.to_dict()
+            for metric in metrics:
+                metric_data = data_dict.get(metric)
+                if metric_data is None:
+                    continue
+
+                values = [
+                    (str(timestamp), value) for timestamp, value in metric_data.items()
+                ]
+                metrics_mapping[metric] = values
+
+        except v3io_frames.errors.Error as err:
+            logger.warn("Failed to read tsdb", err=err, endpoint=endpoint_id)
+
+        return metrics_mapping
+
+    def get_records(
+        self,
+        table: str,
+        columns: list[str] = None,
+        filter_query: str = "",
+        start: str = "now-1h",
+        end: str = "now",
+    ) -> pd.DataFrame:
+        """
+         Getting records from V3IO TSDB data collection.
+        :param table:            Path to the collection to query.
+        :param columns:          Columns to include in the result.
+        :param filter_query:     V3IO filter expression. The expected filter expression includes different conditions,
+                                 divided by ' AND '.
+        :param start:            The start time of the metrics. Can be represented by a string containing an RFC 3339
+                                 time, a Unix timestamp in milliseconds, a relative time (`'now'` or
+                                 `'now-[0-9]+[mhd]'`, where `m` = minutes, `h` = hours, `'d'` = days, and
+                                 `'s'` = seconds), or 0 for the earliest time.
+        :param end:              The end time of the metrics. Can be represented by a string containing an RFC 3339
+                                 time, a Unix timestamp in milliseconds, a relative time (`'now'` or
+                                 `'now-[0-9]+[mhd]'`, where `m` = minutes, `h` = hours, `'d'` = days, and
+                                 `'s'` = seconds), or 0 for the earliest time.
+        :return: DataFrame with the provided attributes from the data collection.
+        :raise:  MLRunNotFoundError if the provided table wasn't found.
+        """
+        if table not in self.tables:
+            raise mlrun.errors.MLRunNotFoundError(
+                f"Table '{table}' does not exist in the tables list of the TSDB connector."
+                f"Available tables: {list(self.tables.keys())}"
+            )
+        return self._frames_client.read(
+            backend=mlrun.common.schemas.model_monitoring.TimeSeriesConnector.TSDB,
+            table=self.tables[table],
+            columns=columns,
+            filter=filter_query,
+            start=start,
+            end=end,
+        )
+
+    def _get_v3io_source_directory(self) -> str:
+        """
+        Get the V3IO source directory for the current project. Usually the source directory will
+        be under 'v3io:///users/pipelines/<project>'
+
+        :return: The V3IO source directory for the current project.
+        """
+        events_table_full_path = mlrun.mlconf.get_model_monitoring_file_target_path(
+            project=self.project,
+            kind=mm_constants.FileTargetKind.EVENTS,
+        )
+
+        # Generate the main directory with the V3IO resources
+        source_directory = (
+            mlrun.common.model_monitoring.helpers.parse_model_endpoint_project_prefix(
+                events_table_full_path, self.project
+            )
+        )
+
+        return source_directory
+
+    @staticmethod
+    def _get_v3io_frames_client(v3io_container: str) -> v3io_frames.client.ClientBase:
+        return mlrun.utils.v3io_clients.get_frames_client(
+            address=mlrun.mlconf.v3io_framesd,
+            container=v3io_container,
+        )

mlrun/model_monitoring/db/v3io_tsdb_reader.py

@@ -0,0 +1,134 @@
+# Copyright 2024 Iguazio
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# TODO: Move this module into the TSDB abstraction once it is in.
+
+from datetime import datetime
+from io import StringIO
+
+import pandas as pd
+
+import mlrun
+import mlrun.common.schemas.model_monitoring.constants as mm_constants
+import mlrun.model_monitoring.writer as mm_writer
+import mlrun.utils.v3io_clients
+from mlrun.common.schemas.model_monitoring.model_endpoints import (
+    ModelEndpointMonitoringMetric,
+    ModelEndpointMonitoringMetricType,
+    ModelEndpointMonitoringResultNoData,
+    ModelEndpointMonitoringResultValues,
+    _compose_full_name,
+    _ModelEndpointMonitoringResultValuesBase,
+)
+from mlrun.model_monitoring.db.stores.v3io_kv.kv_store import KVStoreBase
+from mlrun.model_monitoring.db.tsdb.v3io.v3io_connector import _TSDB_BE
+from mlrun.utils import logger
+
+
+def _get_sql_query(endpoint_id: str, names: list[tuple[str, str]]) -> str:
+    with StringIO() as query:
+        query.write(
+            f"SELECT * FROM '{mm_constants.MonitoringTSDBTables.APP_RESULTS}' "
+            f"WHERE {mm_writer.WriterEvent.ENDPOINT_ID}='{endpoint_id}'"
+        )
+        if names:
+            query.write(" AND (")
+
+            for i, (app_name, result_name) in enumerate(names):
+                sub_cond = (
+                    f"({mm_writer.WriterEvent.APPLICATION_NAME}='{app_name}' "
+                    f"AND {mm_writer.ResultData.RESULT_NAME}='{result_name}')"
+                )
+                if i != 0:  # not first sub condition
+                    query.write(" OR ")
+                query.write(sub_cond)
+
+            query.write(")")
+
+        query.write(";")
+        return query.getvalue()
+
+
+def _get_result_kind(result_df: pd.DataFrame) -> mm_constants.ResultKindApp:
+    kind_series = result_df[mm_writer.ResultData.RESULT_KIND]
+    unique_kinds = kind_series.unique()
+    if len(unique_kinds) > 1:
+        logger.warning(
+            "The result has more than one kind",
+            kinds=list(unique_kinds),
+            application_name=result_df[mm_writer.WriterEvent.APPLICATION_NAME],
+            result_name=result_df[mm_writer.ResultData.RESULT_NAME],
+        )
+    return unique_kinds[0]
+
+
+def read_data(
+    *,
+    project: str,
+    endpoint_id: str,
+    start: datetime,
+    end: datetime,
+    metrics: list[ModelEndpointMonitoringMetric],
+) -> list[_ModelEndpointMonitoringResultValuesBase]:
+    client = mlrun.utils.v3io_clients.get_frames_client(
+        address=mlrun.mlconf.v3io_framesd,
+        container=KVStoreBase.get_v3io_monitoring_apps_container(project),
+    )
+    df: pd.DataFrame = client.read(
+        backend=_TSDB_BE,
+        query=_get_sql_query(
+            endpoint_id, [(metric.app, metric.name) for metric in metrics]
+        ),
+        start=start,
+        end=end,
+    )
+
+    metrics_without_data = {metric.full_name: metric for metric in metrics}
+
+    metrics_values: list[_ModelEndpointMonitoringResultValuesBase] = []
+    if not df.empty:
+        grouped = df.groupby(
+            [mm_writer.WriterEvent.APPLICATION_NAME, mm_writer.ResultData.RESULT_NAME],
+            observed=False,
+        )
+    else:
+        grouped = []
+    for (app_name, result_name), sub_df in grouped:
+        result_kind = _get_result_kind(sub_df)
+        full_name = _compose_full_name(project=project, app=app_name, name=result_name)
+        metrics_values.append(
+            ModelEndpointMonitoringResultValues(
+                full_name=full_name,
+                type=ModelEndpointMonitoringMetricType.RESULT,
+                result_kind=result_kind,
+                values=list(
+                    zip(
+                        sub_df.index,
+                        sub_df[mm_writer.ResultData.RESULT_VALUE],
+                        sub_df[mm_writer.ResultData.RESULT_STATUS],
+                    )
+                ),  # pyright: ignore[reportArgumentType]
+            )
+        )
+        del metrics_without_data[full_name]
+
+    for metric in metrics_without_data.values():
+        metrics_values.append(
+            ModelEndpointMonitoringResultNoData(
+                full_name=metric.full_name,
+                type=ModelEndpointMonitoringMetricType.RESULT,
+            )
+        )
+
+    return metrics_values