memwal 0.2.2.dev0__py3-none-any.whl → 0.2.2.dev2__py3-none-any.whl

memwal/__init__.py

@@ -128,4 +128,4 @@ __all__ = [
     "RecallManualResult",
 ]
 
-__version__ = "0.2.2.dev0"
+__version__ = "0.2.2.dev2"

memwal/client.py

@@ -86,6 +86,7 @@ from .utils import (
     sha256_hex,
     sign_message,
     sign_sui_personal_message,
+    validate_max_distance,
 )
 
 T = TypeVar("T")
@@ -142,6 +143,36 @@ def _reject_blank_text(text: object, message: str = "Text cannot be empty") -> N
         raise ValueError(message)
 
 
+def _require(data: object, field: str, endpoint: str) -> Any:
+    """``data[field]`` from a parsed 2xx body, or a ``MemWalError`` naming both.
+
+    A bare ``KeyError`` is not a ``MemWalError``, carries only the field name,
+    and is raised far from the response that caused it (#1250). Optional
+    fields keep using ``.get()`` with a documented default.
+    """
+
+    if not isinstance(data, dict):
+        raise MemWalError(
+            f"{endpoint} response was {type(data).__name__}, expected an object "
+            f"with {field!r}"
+        )
+    if field not in data:
+        raise MemWalError(f"{endpoint} response missing {field!r}")
+    return data[field]
+
+
+def _require_positive_int(value: object, name: str) -> None:
+    """Reject anything but a positive ``int`` before it is signed (#1249).
+
+    ``json.dumps`` writes ``float("nan")`` as a bare ``NaN`` token, which is
+    not valid JSON, and negative or fractional values were forwarded as-is.
+    ``bool`` is an ``int`` subclass and is rejected explicitly.
+    """
+
+    if isinstance(value, bool) or not isinstance(value, int) or value <= 0:
+        raise ValueError(f"{name} must be a positive integer, got {value!r}")
+
+
 IDEMPOTENCY_BUCKET_MS = 30 * 60 * 1000
 
 
@@ -1176,7 +1207,9 @@ class MemWal:
             sort = params.sort
         else:
             query_text = query
+        _reject_blank_text(query_text, "query cannot be empty")
         _check_limit(limit)
+        validate_max_distance(max_distance)
         body = {
             "query": query_text,
             "limit": limit,
@@ -1189,9 +1222,9 @@ class MemWal:
         data = await self._signed_request("POST", "/api/recall", body)
         memories = [
             RecallMemory(
-                blob_id=m["blob_id"],
-                text=m["text"],
-                distance=m["distance"],
+                blob_id=_require(m, "blob_id", "POST /api/recall"),
+                text=_require(m, "text", "POST /api/recall"),
+                distance=_require(m, "distance", "POST /api/recall"),
                 score=m.get("score"),
                 created_at=m.get("created_at"),
             )
@@ -1353,18 +1386,24 @@ class MemWal:
         Returns:
             :class:`AskResult` with answer, memories_used count, and memories list.
         """
+        _reject_blank_text(question, "question cannot be empty")
+        _require_positive_int(limit, "limit")
         data = await self._signed_request("POST", "/api/ask", {
             "question": question,
             "limit": limit,
             "namespace": self._resolve_namespace(namespace),
         })
         memories = [
-            AskMemory(blob_id=m["blob_id"], text=m["text"], distance=m["distance"])
+            AskMemory(
+                blob_id=_require(m, "blob_id", "POST /api/ask"),
+                text=_require(m, "text", "POST /api/ask"),
+                distance=_require(m, "distance", "POST /api/ask"),
+            )
             for m in data.get("memories", [])
         ]
         return AskResult(
-            answer=data["answer"],
-            memories_used=data["memories_used"],
+            answer=_require(data, "answer", "POST /api/ask"),
+            memories_used=_require(data, "memories_used", "POST /api/ask"),
             memories=memories,
         )
 
@@ -1424,12 +1463,13 @@ class MemWal:
             "namespace": namespace,
             "limit": limit,
         })
+        endpoint = "POST /api/restore"
         return RestoreResult(
-            restored=data["restored"],
-            skipped=data["skipped"],
-            total=data["total"],
-            namespace=data["namespace"],
-            owner=data["owner"],
+            restored=_require(data, "restored", endpoint),
+            skipped=_require(data, "skipped", endpoint),
+            total=_require(data, "total", endpoint),
+            namespace=_require(data, "namespace", endpoint),
+            owner=_require(data, "owner", endpoint),
             # Relayers older than WALM-319 omit `truncated` entirely --
             # treat "not present" as "not known to be truncated" rather
             # than require every relayer version to send it.
@@ -1492,20 +1532,21 @@ class MemWal:
         # against `path_and_query`, not `path`.
         path = f"/v1/owners/{owner}/namespaces" + (f"?{query}" if query else "")
         data = await self._signed_request("GET", path, {}, include_seal_session=False)
+        endpoint = "GET /v1/owners/{owner}/namespaces"
         return NamespacesResult(
             namespaces=[
                 NamespaceSummary(
-                    id=ns["id"],
-                    name=ns["name"],
-                    memory_count=ns["memory_count"],
-                    storage_used=ns["storage_used"],
-                    updated_at=ns["updated_at"],
+                    id=_require(ns, "id", endpoint),
+                    name=_require(ns, "name", endpoint),
+                    memory_count=_require(ns, "memory_count", endpoint),
+                    storage_used=_require(ns, "storage_used", endpoint),
+                    updated_at=_require(ns, "updated_at", endpoint),
                 )
-                for ns in data["namespaces"]
+                for ns in _require(data, "namespaces", endpoint)
             ],
             next_cursor=data.get("next_cursor"),
-            has_more=data["has_more"],
-            snapshot_version=data["snapshot_version"],
+            has_more=_require(data, "has_more", endpoint),
+            snapshot_version=_require(data, "snapshot_version", endpoint),
         )
 
     async def health(self) -> HealthResult:
@@ -1523,8 +1564,8 @@ class MemWal:
             raise MemWalError(f"Health check failed: {response.status_code}")
         data = response.json()
         return HealthResult(
-            status=data["status"],
-            version=data["version"],
+            status=_require(data, "status", "GET /health"),
+            version=_require(data, "version", "GET /health"),
             relayer_version=data.get("relayerVersion"),
             api_version=data.get("apiVersion"),
             min_supported_sdk=data.get("minSupportedSdk"),
@@ -1569,11 +1610,12 @@ class MemWal:
             },
             include_seal_session=False,
         )
+        endpoint = "POST /api/remember/manual"
         return RememberManualResult(
-            id=data["id"],
-            blob_id=data["blob_id"],
-            owner=data["owner"],
-            namespace=data["namespace"],
+            id=_require(data, "id", endpoint),
+            blob_id=_require(data, "blob_id", endpoint),
+            owner=_require(data, "owner", endpoint),
+            namespace=_require(data, "namespace", endpoint),
         )
 
     async def recall_manual(self, opts: RecallManualOptions) -> RecallManualResult:

memwal/mock.py

@@ -38,6 +38,7 @@ from .types import (
     RememberResult,
     RestoreResult,
 )
+from .utils import validate_max_distance
 
 _MOCK_NAMESPACE_EPOCH = datetime(2026, 1, 1, tzinfo=timezone.utc)
 
@@ -285,6 +286,7 @@ class MemWalMock:
             query_text = query
         _validate_text(query_text, "query")
         _check_limit(limit)
+        validate_max_distance(max_distance)
         if sort not in (None, "relevance", "recent"):
             raise ValueError("sort must be 'relevance' or 'recent'")
         resolved_namespace = self._namespace if namespace is None else namespace

memwal/utils.py

@@ -9,8 +9,9 @@ from __future__ import annotations
 
 import base64
 import hashlib
+import math
 from datetime import datetime, timezone
-from typing import Tuple, Union
+from typing import Optional, Tuple, Union
 
 import nacl.signing
 
@@ -373,3 +374,23 @@ def sign_sui_personal_message(
     public_key_bytes = bytes(signing_key.verify_key)
     serialized = bytes([_SUI_ED25519_SCHEME_FLAG]) + signature_bytes + public_key_bytes
     return base64.b64encode(serialized).decode("ascii")
+
+
+def validate_max_distance(max_distance: Optional[float]) -> None:
+    """Reject a ``max_distance`` that would silently drop every hit (#1248).
+
+    The recall filter keeps ``distance < max_distance``. Every comparison with
+    NaN is False and real distances are never negative, so NaN or a negative
+    threshold returns an empty page that looks like an empty namespace.
+    Mirrors the TypeScript ``maxDistance`` guard (#1227).
+    """
+
+    if max_distance is None:
+        return
+    if (
+        isinstance(max_distance, bool)
+        or not isinstance(max_distance, (int, float))
+        or not math.isfinite(max_distance)
+        or max_distance < 0
+    ):
+        raise ValueError("max_distance must be a non-negative finite number")

{memwal-0.2.2.dev0.dist-info → memwal-0.2.2.dev2.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.5
 Name: memwal
-Version: 0.2.2.dev0
+Version: 0.2.2.dev2
 Summary: Python SDK for Walrus Memory — Privacy-first AI memory with Ed25519 signing
 Project-URL: Homepage, https://memory.walrus.xyz
 Project-URL: Documentation, https://memory.walrus.xyz

memwal-0.2.2.dev2.dist-info/RECORD

@@ -0,0 +1,10 @@
+memwal/__init__.py,sha256=Q3MYcoT6ucCc4CtfrjKywu5hPlrHxbLJCMHsbE4VImQ,3142
+memwal/client.py,sha256=3FBM1AP-YYoYPOzZFAeUA_nAYZtHWnTEuJWIdYThVas,97328
+memwal/compatibility.py,sha256=FsKApCcHOFZeIeNOph3YydWVnZtMJdT0KCt0e6jylho,2799
+memwal/middleware.py,sha256=z2xdbvaobBg4byJXnrX7amWdVYE4jfeO4t31DoDBv_o,38413
+memwal/mock.py,sha256=JrYAkvEk_vkDDHd5RMWdyAqdE72GEgqFPlPbAFzZvkA,24347
+memwal/types.py,sha256=fPvxU4k14qmj577sMtGZyVaGhwXxORtyXL-TxD0P6LI,14002
+memwal/utils.py,sha256=RYlELBpKUHN9RuvWQu0cSGMoyXpAdTWlNKawfDpDbQ0,13361
+memwal-0.2.2.dev2.dist-info/METADATA,sha256=CLWf7FcTs6hsaOq7PvPDWaZ2pAuQyVFLsIZ5DuWLpsw,11923
+memwal-0.2.2.dev2.dist-info/WHEEL,sha256=W3fkpkm7-wf9vBI5Z-7s0eWkeM-spu78I8Neb98DeEg,87
+memwal-0.2.2.dev2.dist-info/RECORD,,

memwal-0.2.2.dev0.dist-info/RECORD

@@ -1,10 +0,0 @@
-memwal/__init__.py,sha256=G_2AYOMiAWMZ_G89OKlHPYV63KXxp--oMGC0cYV9r1c,3142
-memwal/client.py,sha256=l_V6fcUyXq9r1qV8sHw8xlSc8-Q50ebTtDuP4rscq8c,95076
-memwal/compatibility.py,sha256=FsKApCcHOFZeIeNOph3YydWVnZtMJdT0KCt0e6jylho,2799
-memwal/middleware.py,sha256=z2xdbvaobBg4byJXnrX7amWdVYE4jfeO4t31DoDBv_o,38413
-memwal/mock.py,sha256=cB-mu2yqycvMCVMmgqTTsIj_pGSkHufCyLNbfkPdHEE,24262
-memwal/types.py,sha256=fPvxU4k14qmj577sMtGZyVaGhwXxORtyXL-TxD0P6LI,14002
-memwal/utils.py,sha256=YyLuxPjKB0RksL1ZGPORpW7QrSID0vQQABq3L_64zKw,12596
-memwal-0.2.2.dev0.dist-info/METADATA,sha256=11TlxEsj6VTIT3FxMNJBr9UqstdqvYlIp8jduI83LV4,11923
-memwal-0.2.2.dev0.dist-info/WHEEL,sha256=W3fkpkm7-wf9vBI5Z-7s0eWkeM-spu78I8Neb98DeEg,87
-memwal-0.2.2.dev0.dist-info/RECORD,,