matlab-proxy 0.18.0__py3-none-any.whl → 0.18.2__py3-none-any.whl

matlab_proxy/app.py

@@ -624,10 +624,12 @@ async def matlab_view(req):
 
     # Standard HTTP Request
     else:
-        # Proxy, injecting request header
+        # Proxy, injecting request header, disabling request timeouts
+        timeout = aiohttp.ClientTimeout(total=None)
         async with aiohttp.ClientSession(
             trust_env=True,
             connector=aiohttp.TCPConnector(verify_ssl=False),
+            timeout=timeout,
         ) as client_session:
             try:
                 req_body = await transform_body(req)

matlab_proxy/settings.py

@@ -395,8 +395,10 @@ def get_matlab_settings():
     has_custom_code_to_execute = (
         len(os.getenv(mwi_env.get_env_name_custom_matlab_code(), "").strip()) > 0
     )
-    mp_code_to_execute = f"try; run('{matlab_startup_file}'); catch MATLABProxyInitializationError; disp(MATLABProxyInitializationError.message); end;"
-    custom_code_to_execute = f"try; run('{matlab_code_file}'); catch MATLABCustomStartupCodeError; disp(MATLABCustomStartupCodeError.message); end;"
+
+    # Sanitize file paths to avoid MATLAB not running the script due to early breakup of character array.
+    mp_code_to_execute = f"try; run('{_sanitize_file_path_for_matlab(matlab_startup_file)}'); catch MATLABProxyInitializationError; disp(MATLABProxyInitializationError.message); end;"
+    custom_code_to_execute = f"try; run('{_sanitize_file_path_for_matlab(matlab_code_file)}'); catch MATLABCustomStartupCodeError; disp(MATLABCustomStartupCodeError.message); end;"
     code_to_execute = (
         mp_code_to_execute + custom_code_to_execute
         if has_custom_code_to_execute
@@ -621,3 +623,11 @@ def generate_new_self_signed_certs(mwi_certs_dir):
         cert_file = priv_key_file = None
 
     return cert_file, priv_key_file
+
+
+def _sanitize_file_path_for_matlab(filepath: str) -> str:
+    """
+    Replace single quotes in the filepath with double single quotes to preserve the quote when used in MATLAB code.
+    """
+    filepath_with_single_quotes_escaped = filepath.replace("'", "''")
+    return filepath_with_single_quotes_escaped

matlab_proxy/util/mwi/environment_variables.py

@@ -187,7 +187,7 @@ class Experimental:
     @staticmethod
     def should_use_mos_html():
         """Returns true if matlab-proxy should use MOS htmls to load MATLAB"""
-        return _is_env_set_to_true("MWI_USE_MOS") or Experimental.is_simulink_enabled()
+        return _is_env_set_to_true("MWI_USE_MOS")
 
     @staticmethod
     def should_use_mre_html():

{matlab_proxy-0.18.0.dist-info → matlab_proxy-0.18.2.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: matlab-proxy
-Version: 0.18.0
+Version: 0.18.2
 Summary: Python® package enables you to launch MATLAB® and access it from a web browser.
 Home-page: https://github.com/mathworks/matlab-proxy/
 Author: The MathWorks, Inc.

{matlab_proxy-0.18.0.dist-info → matlab_proxy-0.18.2.dist-info}/RECORD

@@ -1,10 +1,10 @@
 matlab_proxy/__init__.py,sha256=6cwi8buKCMtw9OeWaOYUHEoqwl5MyJ_s6GxgNuqPuNg,1673
-matlab_proxy/app.py,sha256=fcZGlpW8Ox1ahHIhDBnL_iBkF-tFejTRr61L8WgGFgM,34429
+matlab_proxy/app.py,sha256=ri2Dm3G3uVmIhoEV01awazsO4t3Z92LEwin657bq8bw,34538
 matlab_proxy/app_state.py,sha256=i5AVaNroFSld4Y36BNil5lwS0PNrHnceYq7swXY5AI4,60502
 matlab_proxy/constants.py,sha256=CrbIA098b5LMsqxY7nbap0_tqA2tIrIckGAffTgIkrA,1039
 matlab_proxy/default_configuration.py,sha256=DxQaHzAivzstiPl_nDfxs8SOyP9oaK9v3RP4LtroJl4,843
 matlab_proxy/devel.py,sha256=nR6XPVBUEdQ-RZGtYvX1YHTp8gj9cuw5Hp8ahasMBc8,14310
-matlab_proxy/settings.py,sha256=I4nvFZzACKx-JBlAFCFWHA60gg66bR4hrXj1f5awfbA,25616
+matlab_proxy/settings.py,sha256=6KHKg96WjTz5xboBQllB6nDDTHhT9NBkWNGcWjwkJ6s,26096
 matlab_proxy/gui/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 matlab_proxy/gui/asset-manifest.json,sha256=XqmLvi3DDOGSbBxNZwjuaNJXoYjZiG2HasxvZnEzPEo,3516
 matlab_proxy/gui/favicon.ico,sha256=7w7Ki1uQP2Rgwc64dOV4-NrTu97I3WsZw8OvRSoY1A0,130876
@@ -63,7 +63,7 @@ matlab_proxy/util/windows.py,sha256=J5O-wihOxEex43_AzwvFylNlN4hcZdO6KD5cpLv1FX8,
 matlab_proxy/util/mwi/__init__.py,sha256=zI-X1lafr8H3j17PyA0oSZ0q5nINfK-WDA7VmJKmSAQ,158
 matlab_proxy/util/mwi/custom_http_headers.py,sha256=kfDjSnEXEVzoF2pZuEn76LKayeD2WKoQEDu2Y9EMOAo,7154
 matlab_proxy/util/mwi/download.py,sha256=-GJj3yOsL4vF_9baqRXkgBI-vu_OwjZMQVkJXFS8GMc,4965
-matlab_proxy/util/mwi/environment_variables.py,sha256=SC5pMCs2EVWd9NrvA8yYbCOm998SXDhQCIG1h8Ilysc,7309
+matlab_proxy/util/mwi/environment_variables.py,sha256=0B6rW1sMXGHmSTw6oPgOKz-QM40URIleO6d_zCTkkK8,7271
 matlab_proxy/util/mwi/exceptions.py,sha256=93HrHbOq24KI4Md2el23XN01wIqVShEK29Pbt2V0Jr8,4628
 matlab_proxy/util/mwi/logger.py,sha256=e7wTPclrtJ-aX5mPk_pUJMX7-1QD_snGBW1P2ks-ETE,3311
 matlab_proxy/util/mwi/token_auth.py,sha256=UbIWqo7qADaZdijFvorLYsZbxzaB8TycGP8nk305ru0,9997
@@ -74,7 +74,7 @@ matlab_proxy/util/mwi/embedded_connector/request.py,sha256=-6DL9K8JWjX5u5XVOEGaq
 tests/integration/__init__.py,sha256=ttzJ8xKWGxOJZz56qOiWOn6sp5LGomkZMn_w4KJLRMU,42
 tests/integration/integration_tests_with_license/__init__.py,sha256=vVYZCur-QhmIGCxUmn-WZjIywtDQidaLDmlmrRHRlgY,37
 tests/integration/integration_tests_with_license/conftest.py,sha256=sCaIXB8d4vf05C7JWSVA7g5gnPjbpRq3dftuBpWyp1s,1599
-tests/integration/integration_tests_with_license/test_http_end_points.py,sha256=SDJIoyo-hh2Ns9uWaDeO87N0jY3svhKOn29HFFyx_jM,7485
+tests/integration/integration_tests_with_license/test_http_end_points.py,sha256=51r3foIshg80NLgvsxaQUxlnnZiKs0O6gLvdF3Y7sWk,14448
 tests/integration/integration_tests_without_license/__init__.py,sha256=vVYZCur-QhmIGCxUmn-WZjIywtDQidaLDmlmrRHRlgY,37
 tests/integration/integration_tests_without_license/conftest.py,sha256=n-oppKWxavyy1O0J6DywO3DnOHuYc7yUZRXm3Bt4szU,3526
 tests/integration/integration_tests_without_license/test_matlab_is_down_if_unlicensed.py,sha256=tkdyhfZBpfJpbnEzjURyV-GE0p43YxOa9xooJf-JoM4,1653
@@ -95,6 +95,7 @@ tests/unit/util/test_mw.py,sha256=YC4mjn6G6_XuHELt8uW9F6g2K0_fWtQl1R0kWFvWbAo,18
 tests/unit/util/test_util.py,sha256=vqTPgmaKDWhVBRnCKtCNg-OtyR5bP8jeH9DnpcbfVTk,5141
 tests/unit/util/mwi/__init__.py,sha256=pl5jqyCHEwZEviiL8OC-SHulb1rBecstQCFF6qVjL9Y,37
 tests/unit/util/mwi/test_custom_http_headers.py,sha256=UfrhclS0j6WhShtg1ki2oF1kK8JqRC29uevH4tuDqF4,11182
+tests/unit/util/mwi/test_download.py,sha256=jYwPJFYGrPKqnkIJW42XYSe1fowmzChAkOx0k0xVldo,4779
 tests/unit/util/mwi/test_logger.py,sha256=zWImNitMYKPJunXWJjEDEtCEKwBz615PC844ZLwoxIg,1845
 tests/unit/util/mwi/test_token_auth.py,sha256=-eBsaQ5JC7pyd9PXt48Rqs4cWjg6I-eOkp_gFVEwYhk,10538
 tests/unit/util/mwi/test_validators.py,sha256=YeOP0-T7SFNeiC7JIQj7cV4ja3d6PhswsTz27IEgJHQ,10852
@@ -103,9 +104,9 @@ tests/unit/util/mwi/embedded_connector/test_helpers.py,sha256=vYTWNUTuDeaygo16JG
 tests/unit/util/mwi/embedded_connector/test_request.py,sha256=PR-jddnXDEiip-lD7A_QSvRwEkwo3eQ8owZlk-r9vnk,1867
 tests/utils/__init__.py,sha256=ttzJ8xKWGxOJZz56qOiWOn6sp5LGomkZMn_w4KJLRMU,42
 tests/utils/logging_util.py,sha256=VBy_NRvwau3C_CVTBjK5RMROrQimnJYHO2U0aKSZiRw,2234
-matlab_proxy-0.18.0.dist-info/LICENSE.md,sha256=oF0h3UdSF-rlUiMGYwi086ZHqelzz7yOOk9HFDv9ELo,2344
-matlab_proxy-0.18.0.dist-info/METADATA,sha256=9FmzMjPlFh73Jyg-jwhxTDMu_HIfVJJgfAeaMt02lH4,10177
-matlab_proxy-0.18.0.dist-info/WHEEL,sha256=GJ7t_kWBFywbagK5eo9IoUwLW6oyOeTKmQ-9iHFVNxQ,92
-matlab_proxy-0.18.0.dist-info/entry_points.txt,sha256=DbBLYgnRt8UGiOpd0zHigRTyyMdZYhMdvCvSYP7wPN0,244
-matlab_proxy-0.18.0.dist-info/top_level.txt,sha256=9uVTjsUCAS4TwsxueTBxrBg3PdBiTSsYowAkHPv9VY0,19
-matlab_proxy-0.18.0.dist-info/RECORD,,
+matlab_proxy-0.18.2.dist-info/LICENSE.md,sha256=oF0h3UdSF-rlUiMGYwi086ZHqelzz7yOOk9HFDv9ELo,2344
+matlab_proxy-0.18.2.dist-info/METADATA,sha256=Jnbri3j-_H13v1Ly8LTT2vqwrm8SXPDpPkoQ9lZUvkE,10177
+matlab_proxy-0.18.2.dist-info/WHEEL,sha256=GJ7t_kWBFywbagK5eo9IoUwLW6oyOeTKmQ-9iHFVNxQ,92
+matlab_proxy-0.18.2.dist-info/entry_points.txt,sha256=DbBLYgnRt8UGiOpd0zHigRTyyMdZYhMdvCvSYP7wPN0,244
+matlab_proxy-0.18.2.dist-info/top_level.txt,sha256=9uVTjsUCAS4TwsxueTBxrBg3PdBiTSsYowAkHPv9VY0,19
+matlab_proxy-0.18.2.dist-info/RECORD,,

tests/integration/integration_tests_with_license/test_http_end_points.py

@@ -1,27 +1,167 @@
 # Copyright 2023-2024 The MathWorks, Inc.
 
+"""
+Contains integration tests which exercise HTTP endpoints of interest exposed by matlab-proxy-app
+"""
+
+# Imports
+from enum import Enum
 import json
 import os
-import time
-import matlab_proxy.settings as settings
-from tests.integration.utils import integration_tests_utils as utils
 import pytest
-from matlab_proxy.util import system
-import requests
 import re
+import requests
+import time
 from requests.adapters import HTTPAdapter, Retry
 from urllib.parse import urlparse, parse_qs
-from tests.utils.logging_util import create_integ_test_logger
+
+# Local module imports
+import matlab_proxy.settings as settings
 from matlab_proxy.constants import MWI_AUTH_TOKEN_NAME_FOR_HTTP
+from matlab_proxy.util import system
+from tests.integration.utils import integration_tests_utils as utils
+from tests.utils.logging_util import create_integ_test_logger
 
+# Logger Setup
 _logger = create_integ_test_logger(__name__)
 
+# Constants
+
 # Timeout for polling the matlab-proxy http endpoints
 # matlab proxy in Mac machines takes more time to be 'up'
-
 MAX_TIMEOUT = settings.get_process_startup_timeout()
 
 
+class Format(Enum):
+    """
+    An enumeration to specify different format types.
+
+    Attributes:
+        JSON (int): Represents the JSON format type.
+        TEXT (int): Represents the plain text format type.
+    """
+
+    JSON = 1
+    TEXT = 2
+
+
+# Utility Functions
+def _http_get_request(
+    uri, connection_scheme, headers, http_endpoint="", outputFormat=Format.TEXT
+):
+    """
+    Sends an HTTP GET request to a specified URI, optionally appending an endpoint to the URI.
+
+    This function uses a session with retries configured for transient network errors. It can return
+    the response in either text or JSON format, based on the outputFormat parameter.
+
+    Parameters:
+    - uri (str): The base URI for the HTTP request.
+    - connection_scheme (str): The scheme to use for the connection (e.g., 'http' or 'https').
+    - headers (dict): A dictionary of HTTP headers to include in the request.
+    - http_endpoint (str, optional): An additional endpoint to append to the base URI. Defaults to an empty string.
+    - outputFormat (format, optional): The desired format for the response content. This should be an attribute
+      of a format enumeration, supporting at least 'TEXT' and 'JSON' options. Defaults to Format.TEXT.
+
+    Returns:
+    - str or dict: The response content as a string if outputFormat is Format.TEXT, or as a dictionary
+      if outputFormat is Format.JSON.
+
+    Raises:
+    - Exception: If an invalid output format is specified.
+
+    Note:
+    - The function disables SSL certificate verification (`verify=False`). This may introduce security risks,
+      such as vulnerability to man-in-the-middle attacks. Use with caution in a production environment.
+    """
+    request_uri = uri + http_endpoint
+    with requests.Session() as s:
+        retries = Retry(total=10, backoff_factor=0.1)
+        s.mount(f"{connection_scheme}://", HTTPAdapter(max_retries=retries))
+        response = s.get(request_uri, headers=headers, verify=False)
+
+        if outputFormat == Format.TEXT:
+            return response.text
+        elif outputFormat == Format.JSON:
+            return json.loads(response.text)
+
+    raise Exception("Invalid output format specified.")
+
+
+def _check_matlab_status(matlab_proxy_app_fixture, status):
+    """
+    Check the status of a MATLAB session until a specified status is reached or a timeout occurs.
+
+    This function repeatedly sends HTTP GET requests to a MATLAB proxy application to check the current
+    status of MATLAB. It continues checking until MATLAB's status matches the specified target status or
+    until a maximum timeout is reached.
+
+    Parameters:
+    - matlab_proxy_app_fixture: An object containing configuration for connecting to the MATLAB proxy application.
+      This object must have the following attributes:
+        - url (str): The base URL of the MATLAB proxy application.
+        - connection_scheme (str): The scheme used for the connection (e.g., 'http' or 'https').
+        - headers (dict): A dictionary of HTTP headers to be sent with each request.
+    - status (str): The target status to wait for MATLAB to reach.
+
+    Returns:
+    - str: The status of MATLAB at the end of the function execution. This could be the target status if
+      it was reached within the timeout period, or the last known status of MATLAB if the timeout was reached
+      first.
+
+    Notes:
+    - The function waits for a maximum of MAX_TIMEOUT seconds, defined elsewhere, before exiting.
+    - It checks the MATLAB status every 1 second.
+    - The MATLAB status is obtained by sending a GET request to the '/get_status' endpoint of the proxy application.
+    - The response from the proxy application is expected to be in JSON format, with MATLAB's status accessible
+      via `res["matlab"]["status"]`.
+
+    Exceptions:
+    - This function may raise exceptions related to network issues or JSON parsing errors, which are not
+      explicitly handled within the function.
+    """
+    uri = matlab_proxy_app_fixture.url
+    connection_scheme = matlab_proxy_app_fixture.connection_scheme
+    headers = matlab_proxy_app_fixture.headers
+
+    matlab_status = None
+
+    start_time = time.time()
+    while matlab_status != status and (time.time() - start_time < MAX_TIMEOUT):
+        time.sleep(1)
+        res = _http_get_request(
+            uri,
+            connection_scheme,
+            headers,
+            http_endpoint="/get_status",
+            outputFormat=Format.JSON,
+        )
+        matlab_status = res["matlab"]["status"]
+
+    return matlab_status
+
+
+def _download_test_file(matlab_proxy_app_fixture, test_file):
+    """Returns result of hitting the /download endpoint for test_file.
+
+    Returns:
+        str: The contents of the test_file being downloaded through matlab-proxy.
+    """
+    uri = matlab_proxy_app_fixture.url
+    connection_scheme = matlab_proxy_app_fixture.connection_scheme
+    headers = matlab_proxy_app_fixture.headers
+
+    res = _http_get_request(
+        uri,
+        connection_scheme,
+        headers,
+        http_endpoint="/download/" + test_file,
+        outputFormat=Format.TEXT,
+    )
+    return res
+
+
+# Main Classes
 class RealMATLABServer:
     """
     Context Manager class which returns matlab proxy web server serving real MATLAB
@@ -103,40 +243,7 @@ class RealMATLABServer:
         _logger.debug("Terminated the MATLAB process.")
 
 
-def _send_http_get_request(uri, connection_scheme, headers, http_endpoint=""):
-    """Send HTTP request to matlab-proxy server.
-    Returns HTTP response JSON"""
-
-    request_uri = uri + http_endpoint
-
-    json_response = None
-    with requests.Session() as s:
-        retries = Retry(total=10, backoff_factor=0.1)
-        s.mount(f"{connection_scheme}://", HTTPAdapter(max_retries=retries))
-        response = s.get(request_uri, headers=headers, verify=False)
-        json_response = json.loads(response.text)
-
-    return json_response
-
-
-def _check_matlab_status(matlab_proxy_app_fixture, status):
-    uri = matlab_proxy_app_fixture.url
-    connection_scheme = matlab_proxy_app_fixture.connection_scheme
-    headers = matlab_proxy_app_fixture.headers
-
-    matlab_status = None
-
-    start_time = time.time()
-    while matlab_status != status and (time.time() - start_time < MAX_TIMEOUT):
-        time.sleep(1)
-        res = _send_http_get_request(
-            uri, connection_scheme, headers, http_endpoint="/get_status"
-        )
-        matlab_status = res["matlab"]["status"]
-
-    return matlab_status
-
-
+# Fixtures
 @pytest.fixture
 def matlab_proxy_app_fixture(
     loop,
@@ -159,6 +266,44 @@ def matlab_proxy_app_fixture(
         pass
 
 
+@pytest.fixture
+def test_file_contents():
+    """
+    A pytest fixture that provides a string for testing purposes.
+
+    This fixture returns a predefined string that can be used in tests to simulate
+    the contents of a file or any scenario where a constant string value is needed.
+
+    Returns:
+        str: A string containing the text "I LOVE MATLAB."
+    """
+    return "I LOVE MATLAB."
+
+
+@pytest.fixture
+def test_file(tmp_path, test_file_contents):
+    """
+    A pytest fixture that creates a temporary test file with given contents.
+
+    This fixture utilizes pytest's `tmp_path` fixture to generate a temporary directory,
+    then creates a file named "temporary_test_file.txt" within this directory,
+    and writes the provided contents to this file. It is useful for tests that require
+    reading from or writing to files without affecting the actual file system.
+
+    Parameters:
+    - tmp_path (Path): A pytest fixture that provides a temporary directory unique to the test function.
+    - test_file_contents (str): The content to be written into the temporary test file.
+
+    Returns:
+    - str: The path to the created temporary test file as a string.
+    """
+    test_file = os.path.join(tmp_path, "temporary_test_file.txt")
+    with open(test_file, "w+") as f:
+        f.write(test_file_contents)
+    return test_file
+
+
+# Test Functions
 def test_matlab_is_up(matlab_proxy_app_fixture):
     """Test that the status switches from 'starting' to 'up' within a timeout.
 
@@ -195,13 +340,13 @@ def test_stop_matlab(matlab_proxy_app_fixture):
     assert status == "down"
 
 
-# FIXME: If output has logging or extra debug info, 600 bytes might not be enough.
 async def test_print_message(matlab_proxy_app_fixture):
     """Test if the right logs are printed
 
     Args:
         matlab_proxy_app_fixture: A pytest fixture which yields a real matlab server to be used by tests.
 
+    FIXME: If output has logging or extra debug info, 600 bytes might not be enough.
     """
     # Checks if matlab proxy is in "up" state or not
     status = _check_matlab_status(matlab_proxy_app_fixture, "up")
@@ -221,3 +366,33 @@ async def test_print_message(matlab_proxy_app_fixture):
     # Close the read and write descriptors.
     os.close(read_descriptor)
     os.close(write_descriptor)
+
+
+def test_download_file_from_matlab(
+    matlab_proxy_app_fixture, test_file, test_file_contents
+):
+    """
+    Test the downloading of a file from a MATLAB proxy application.
+
+    This test function checks if the MATLAB proxy application is up and running, and then attempts to download
+    a specific test file from it. It validates both the status of the MATLAB proxy and the contents of the downloaded file.
+
+    Parameters:
+    - matlab_proxy_app_fixture (fixture): A test fixture representing the MATLAB proxy application environment.
+    - test_file (str): The name or path of the test file to be downloaded from the MATLAB proxy application.
+    - test_file_contents (str): The expected contents of the test file to validate the download operation.
+
+    Assertions:
+    - Asserts that the MATLAB proxy application is "up".
+    - Asserts that the content of the downloaded file matches the expected `test_file_contents`.
+
+    Raises:
+    - AssertionError: If any of the assertions fail, indicating either the MATLAB proxy application is not running
+      as expected or there is a mismatch in the file content.
+    """
+    status = _check_matlab_status(matlab_proxy_app_fixture, "up")
+    assert status == "up"
+
+    # Once MATLAB is up, we can then attempt to download
+    result = _download_test_file(matlab_proxy_app_fixture, test_file)
+    assert result == test_file_contents

tests/unit/util/mwi/test_download.py

@@ -0,0 +1,152 @@
+# Copyright 2024 The MathWorks, Inc.
+import pytest
+
+from matlab_proxy.util.mwi.download import (
+    _get_download_payload_path,
+    get_download_url,
+    is_download_request,
+)
+
+
+# Mock the request object
+@pytest.fixture
+def mock_request_fixture(mocker):
+    mock_req = mocker.MagicMock()
+    mock_req.app = {
+        "settings": {"base_url": ""},
+        "state": mocker.MagicMock(),
+    }
+    mock_req.rel_url = mocker.MagicMock()
+    return mock_req
+
+
+def _get_expected_output_based_on_os_type(paths: list) -> str:
+    import matlab_proxy.util.system as system
+
+    return "\\".join(paths) if system.is_windows() else "/".join(paths)
+
+
+# Test for is_download_request function
+@pytest.mark.parametrize(
+    "test_base_url, path, expected",
+    [
+        ("/", "/download/something", True),
+        ("", "/download/something", True),
+        ("/base", "/base/download/something", True),
+        ("/base", "/download/something", False),
+    ],
+    ids=[
+        "/ base url and path starting with /download",
+        "empty base url and path starting with /download",
+        "non-empty base url and path starting with that base url",
+        "non-empty base url and path not starting with that base url",
+    ],
+)
+def test_is_download_request(mock_request_fixture, test_base_url, path, expected):
+    mock_request_fixture.app["settings"]["base_url"] = test_base_url
+    mock_request_fixture.rel_url.path = path
+    assert is_download_request(mock_request_fixture) == expected
+
+
+# Test for _get_download_payload_path function
+# This test is a bit tricky since it involves file system operations and OS checks.
+# We will mock system.is_windows() and test for both Windows and Posix systems.
+@pytest.mark.parametrize(
+    "is_windows, test_base_url, path, expected",
+    [
+        (
+            True,
+            "",
+            "/downloadC:\\some\\path\\to\\file.txt",
+            "C:\\some\\path\\to\\file.txt",
+        ),
+        (
+            True,
+            "/base",
+            "/base/downloadC:\\some\\path\\to\\file.txt",
+            "C:\\some\\path\\to\\file.txt",
+        ),
+        (
+            False,
+            "",
+            "/download/some/path/to/file.txt",
+            _get_expected_output_based_on_os_type(["/some", "path", "to", "file.txt"]),
+        ),
+        (
+            False,
+            "/base",
+            "/base/download/some/path/to/file.txt",
+            _get_expected_output_based_on_os_type(["/some", "path", "to", "file.txt"]),
+        ),
+    ],
+    ids=[
+        "Windows with null base url",
+        "Windows with non-null base url",
+        "Linux with null base url",
+        "Linux with non-null base url",
+    ],
+)
+def test_get_download_payload_path(
+    mock_request_fixture, mocker, is_windows, test_base_url, path, expected
+):
+    mocker.patch("matlab_proxy.util.system.is_windows", return_value=is_windows)
+    mock_request_fixture.app["settings"]["base_url"] = test_base_url
+    mock_request_fixture.rel_url.path = path
+    assert _get_download_payload_path(mock_request_fixture) == expected
+
+
+def test_get_download_payload_path_invalid_request(mock_request_fixture):
+    test_base_url = "/base"
+    path = "/download/something"
+
+    mock_request_fixture.app["settings"]["base_url"] = test_base_url
+    mock_request_fixture.rel_url.path = path
+
+    assert _get_download_payload_path(mock_request_fixture) is None
+
+
+@pytest.mark.parametrize(
+    "response_json, expected_url",
+    [
+        (
+            {
+                "messages": {
+                    "FEvalResponse": [
+                        {"isError": False, "results": ["http://download-url.com"]}
+                    ]
+                }
+            },
+            "http://download-url.com",
+        ),
+        ({"messages": {"FEvalResponse": [{"isError": True}]}}, None),
+    ],
+    ids=["connector returning correct download url", "connector returning an error"],
+)
+async def test_get_download_url(
+    mock_request_fixture, mocker, response_json, expected_url
+):
+    test_base_url = "/"
+    path = "/download/some/path/to/file.txt"
+
+    mock_request_fixture.app["state"].settings = {
+        "mwi_server_url": "http://mwi-server.com"
+    }
+    mock_request_fixture.app["settings"]["base_url"] = test_base_url
+    mock_request_fixture.rel_url.path = path
+
+    mocker.patch(
+        "matlab_proxy.util.mwi.embedded_connector.helpers.get_data_to_feval_mcode",
+        return_value={},
+    )
+    mocker.patch(
+        "matlab_proxy.util.mwi.embedded_connector.helpers.get_mvm_endpoint",
+        return_value="http://mwi-server.com",
+    )
+    mocker.patch(
+        "matlab_proxy.util.mwi.embedded_connector.send_request",
+        return_value=response_json,
+    )
+
+    download_url = await get_download_url(mock_request_fixture)
+
+    assert download_url == expected_url