matlab-proxy 0.17.0__py3-none-any.whl → 0.18.1__py3-none-any.whl

matlab_proxy/app.py

@@ -16,12 +16,11 @@ from cryptography import fernet
 import matlab_proxy
 from matlab_proxy import constants, settings, util
 from matlab_proxy.app_state import AppState
+from matlab_proxy.constants import IS_CONCURRENCY_CHECK_ENABLED
 from matlab_proxy.util import mwi
+from matlab_proxy.util.mwi import download, token_auth
 from matlab_proxy.util.mwi import environment_variables as mwi_env
-from matlab_proxy.util.mwi import token_auth, download
 from matlab_proxy.util.mwi.exceptions import AppError, InvalidTokenError, LicensingError
-from matlab_proxy.constants import IS_CONCURRENCY_CHECK_ENABLED
-
 
 mimetypes.add_type("font/woff", ".woff")
 mimetypes.add_type("font/woff2", ".woff2")
@@ -422,7 +421,7 @@ async def termination_integration_delete(req):
     await req.app.cleanup()
     """When testing with pytest, its not possible to catch sys.exit(0) using the construct
     'with pytest.raises()', there by causing the test : test_termination_integration_delete()
-    to fail. Inorder to avoid this, adding the below if condition to check to skip sys.exit(0) when testing
+    to fail. In order to avoid this, adding the below if condition to check to skip sys.exit(0) when testing
     """
     logger.debug("Exiting with return code 0")
     if not mwi_env.is_testing_mode_enabled():
@@ -475,7 +474,7 @@ def make_static_route_table(app):
     Returns:
         Dict: Containing information about the static files and header information.
     """
-    from pkg_resources import resource_isdir, resource_listdir
+    import importlib_resources
 
     from matlab_proxy import gui
     from matlab_proxy.gui import static
@@ -492,8 +491,9 @@ def make_static_route_table(app):
         (gui.static.js.__name__, "/static/js"),
         (gui.static.media.__name__, "/static/media"),
     ]:
-        for name in resource_listdir(mod, ""):
-            if not resource_isdir(mod, name):
+        for entry in importlib_resources.files(mod).iterdir():
+            name = entry.name
+            if not importlib_resources.files(mod).joinpath(name).is_dir():
                 if name != "__init__.py":
                     # Special case for manifest.json
                     if "manifest.json" in name:
@@ -624,10 +624,12 @@ async def matlab_view(req):
 
     # Standard HTTP Request
     else:
-        # Proxy, injecting request header
+        # Proxy, injecting request header, disabling request timeouts
+        timeout = aiohttp.ClientTimeout(total=None)
         async with aiohttp.ClientSession(
             trust_env=True,
             connector=aiohttp.TCPConnector(verify_ssl=False),
+            timeout=timeout,
         ) as client_session:
             try:
                 req_body = await transform_body(req)

matlab_proxy/app_state.py

@@ -16,10 +16,11 @@ from matlab_proxy.constants import (
     CONNECTOR_SECUREPORT_FILENAME,
     MATLAB_LOGS_FILE_NAME,
     IS_CONCURRENCY_CHECK_ENABLED,
+    USER_CODE_OUTPUT_FILE_NAME,
 )
-from matlab_proxy.settings import (
-    get_process_startup_timeout,
-)
+
+from matlab_proxy.settings import get_process_startup_timeout
+
 from matlab_proxy.util import mw, mwi, system, windows
 from matlab_proxy.util.mwi import environment_variables as mwi_env
 from matlab_proxy.util.mwi import token_auth
@@ -594,6 +595,24 @@ class AppState:
             self.matlab_session_files["matlab_ready_file"] = matlab_ready_file
 
             logger.debug(f"matlab_session_files:{self.matlab_session_files}")
+
+            # check if the user has provided any code or not
+            if self.settings.get("has_custom_code_to_execute"):
+                # Keep a reference to the user code output file in the matlab_session_files for cleanup
+                user_code_output_file = mwi_logs_dir / USER_CODE_OUTPUT_FILE_NAME
+                self.matlab_session_files["startup_code_output_file"] = (
+                    user_code_output_file
+                )
+                logger.info(
+                    util.prettify(
+                        boundary_filler="*",
+                        text_arr=[
+                            f"When MATLAB starts, you can see the output for your startup code at:",
+                            f"{self.matlab_session_files.get('startup_code_output_file', ' ')}",
+                        ],
+                    )
+                )
+
             return
 
     def create_server_info_file(self):
@@ -846,6 +865,10 @@ class AppState:
 
                 return matlab
 
+            except UIVisibleFatalError as e:
+                self.error = e
+                log_error(logger, e)
+
             except Exception as err:
                 self.error = err
                 log_error(logger, err)
@@ -972,7 +995,7 @@ class AppState:
             )
             await self.stop_matlab(force_quit=True)
             self.error = MatlabError(
-                "Unable to start MATLAB because of a timeout. Try again by clicking Start MATLAB."
+                "MATLAB startup has timed out. Click Start MATLAB to try again."
             )
 
     async def __read_matlab_ready_file(self, delay):

matlab_proxy/constants.py

@@ -7,6 +7,7 @@ CONNECTOR_SECUREPORT_FILENAME: Final[str] = "connector.securePort"
 VERSION_INFO_FILE_NAME: Final[str] = "VersionInfo.xml"
 MAX_HTTP_REQUEST_SIZE: Final[int] = 500_000_000  # 500MB
 MATLAB_LOGS_FILE_NAME: Final[str] = "matlab_logs.txt"
+USER_CODE_OUTPUT_FILE_NAME: Final[str] = "startup_code_output.txt"
 
 # Max startup duration in seconds for processes launched by matlab-proxy
 # This constant is meant for internal use within matlab-proxy

matlab_proxy/matlab/evaluateUserMatlabCode.m

@@ -0,0 +1,51 @@
+% Copyright 2024 The MathWorks, Inc.
+
+% Note:
+% Any extra variable we are creating begins with `mwiInternal` to prevent
+% potential conflicts with variables created by user code evaluated using evalc.
+% Since evalc("user code") is executed in the base workspace, it might create
+% variables that could overwrite our internal variables. To avoid polluting the
+% user's workspace when MATLAB starts, we ensure to clear any internal variable
+% that we create in the base workspace. We do not need to be concerned about
+% variables in the function's workspace.
+
+if ~isempty(getenv('MWI_MATLAB_STARTUP_SCRIPT')) && ~all(isspace(getenv('MWI_MATLAB_STARTUP_SCRIPT')))
+    try
+        % Evaluate the code from the environment variable and capture the output
+        mwiInternalResults = evalc(getenv('MWI_MATLAB_STARTUP_SCRIPT'));
+        % Write the results to the file
+        logOutputOrError(mwiInternalResults);
+        clear mwiInternalResults;
+    catch mwiInternalException
+        % Log the error message to the file
+        logOutputOrError(" ", mwiInternalException);
+        clear mwiInternalResults mwiInternalException;
+        error("Unable to run the startup code you specified. For details of the error, see the output file at " + fullfile(getenv('MATLAB_LOG_DIR'), "startup_code_output.txt"));
+    end
+
+end
+
+function logOutputOrError(userCodeResults, mwiInternalException)
+    %   Logs the results of the user code execution if successful, otherwise logs the
+    %   error information. It then closes the file handle.
+    %
+    %   Inputs:
+    %       userCodeResults       - String containing the output from the user code.
+    %       mwiInternalException  - (Optional) MException object containing error details.
+    filePath = fullfile(getenv('MATLAB_LOG_DIR'), "startup_code_output.txt");
+    [fileHandle, ~] = fopen(filePath, 'w');
+    if nargin < 2
+        % Log the successful output of the user code
+        fprintf(fileHandle, " ");
+        fprintf(fileHandle, userCodeResults);
+    else
+        % Log the error information
+        fprintf(fileHandle, 'An error occurred in the following code:\n');
+        fprintf(fileHandle, getenv('MWI_MATLAB_STARTUP_SCRIPT'));
+        fprintf(fileHandle, '\n\nMessage: %s\n', mwiInternalException.message);
+        fprintf(fileHandle, '\nError Identifier: %s\n', mwiInternalException.identifier);
+    end
+    % Close the file handle
+    fclose(fileHandle);
+end
+

matlab_proxy/matlab/startup.m

@@ -1,4 +1,4 @@
-% Copyright (c) 2020-2023 The MathWorks, Inc.
+% Copyright 2020-2024 The MathWorks, Inc.
 
 % Configure logged in user if possible
 if ~isempty(getenv('MW_LOGIN_USER_ID'))
@@ -34,4 +34,4 @@ end
 matlab_settings.matlab.addons.explorer.isExplorerSupported.TemporaryValue = false;
 
 clear
-clc
+clc

matlab_proxy/settings.py

@@ -366,7 +366,10 @@ def get_matlab_settings():
     flag_to_hide_desktop = ["-nodesktop"]
     if system.is_windows():
         flag_to_hide_desktop.extend(["-noDisplayDesktop", "-wait", "-log"])
-    matlab_startup_file = str(Path(__file__).resolve().parent / "matlab" / "startup.m")
+
+    matlab_code_dir = Path(__file__).resolve().parent / "matlab"
+    matlab_startup_file = str(matlab_code_dir / "startup.m")
+    matlab_code_file = str(matlab_code_dir / "evaluateUserMatlabCode.m")
 
     matlab_version = get_matlab_version(matlab_root_path)
 
@@ -388,6 +391,18 @@ def get_matlab_settings():
     profile_matlab_startup = (
         "-timing" if mwi_env.Experimental.is_matlab_startup_profiling_enabled() else ""
     )
+
+    has_custom_code_to_execute = (
+        len(os.getenv(mwi_env.get_env_name_custom_matlab_code(), "").strip()) > 0
+    )
+    mp_code_to_execute = f"try; run('{matlab_startup_file}'); catch MATLABProxyInitializationError; disp(MATLABProxyInitializationError.message); end;"
+    custom_code_to_execute = f"try; run('{matlab_code_file}'); catch MATLABCustomStartupCodeError; disp(MATLABCustomStartupCodeError.message); end;"
+    code_to_execute = (
+        mp_code_to_execute + custom_code_to_execute
+        if has_custom_code_to_execute
+        else mp_code_to_execute
+    )
+
     return {
         "matlab_path": matlab_root_path,
         "matlab_version": matlab_version,
@@ -402,13 +417,14 @@ def get_matlab_settings():
             *mpa_flags,
             profile_matlab_startup,
             "-r",
-            f"try; run('{matlab_startup_file}'); catch ME; disp(ME.message); end;",
+            code_to_execute,
         ],
         "ws_env": ws_env,
         "mwa_api_endpoint": f"https://login{ws_env_suffix}.mathworks.com/authenticationws/service/v4",
         "mhlm_api_endpoint": f"https://licensing{ws_env_suffix}.mathworks.com/mls/service/v1/entitlement/list",
         "mwa_login": f"https://login{ws_env_suffix}.mathworks.com",
         "nlm_conn_str": nlm_conn_str,
+        "has_custom_code_to_execute": has_custom_code_to_execute,
     }
 
 

matlab_proxy/util/__init__.py

@@ -11,6 +11,9 @@ import matlab_proxy
 from matlab_proxy.util import mwi, system
 from matlab_proxy.util.event_loop import *
 from matlab_proxy.util.mwi import environment_variables as mwi_env
+from matlab_proxy.util.mwi.exceptions import (
+    UIVisibleFatalError,
+)
 
 logger = mwi.logger.get()
 
@@ -181,7 +184,7 @@ def prettify(boundary_filler=" ", text_arr=[]):
     return result
 
 
-def get_child_processes(parent_process):
+def get_child_processes(parent_process, max_attempts=10, sleep_interval=1):
     """Get list of child processes from a parent process.
 
     Args:
@@ -199,7 +202,6 @@ def get_child_processes(parent_process):
     # to get hold child processes
     parent_process_psutil = psutil.Process(parent_process.pid)
 
-    max_attempts = 10
     child_processes = None
     for _ in range(max_attempts):
         try:
@@ -212,17 +214,24 @@ def get_child_processes(parent_process):
 
             if not child_processes:
                 logger.debug("Waiting for the child processes to be created...")
+                time.sleep(sleep_interval)
                 continue
 
+            else:
+                logger.debug(f"Found the child process: {child_processes[0]}")
+                break
+
         except AssertionError as err:
             raise err
 
-        if child_processes:
-            break
-        time.sleep(0.1)
-
     if not child_processes:
-        raise RuntimeError("No child processes found after multiple attempts.")
+        logger.debug(
+            f"MATLAB process was not found while searching for the child processes."
+        )
+
+        raise UIVisibleFatalError(
+            "Unable to create MATLAB process. Click Start MATLAB to try again."
+        )
 
     return child_processes
 

matlab_proxy/util/mwi/environment_variables.py

@@ -162,6 +162,11 @@ def get_env_name_process_startup_timeout():
     return "MWI_PROCESS_START_TIMEOUT"
 
 
+def get_env_name_custom_matlab_code():
+    """User specified MATLAB code that will be executed by matlab-proxy upon its start"""
+    return "MWI_MATLAB_STARTUP_SCRIPT"
+
+
 class Experimental:
     """This class houses functions which are undocumented APIs and Environment variables.
     Note: Never add any state to this class. Its only intended for use as an abstraction layer

matlab_proxy/util/mwi/validators.py

@@ -1,31 +1,30 @@
 # Copyright 2020-2024 The MathWorks, Inc.
 """This file contains validators for various runtime artifacts.
-A validator is defined as a function which verifies the input and 
-returns it unchanged if validation passes. 
+A validator is defined as a function which verifies the input and
+returns it unchanged if validation passes.
 Returning inputs allows validators to be used inline with the input.
 
-Example: 
+Example:
 Original code: if( input ):
 With validator: if (valid(input)):
 
 Exceptions are thrown to signal failure.
 """
+
 import errno
 import os
-from pathlib import Path
-import pkg_resources
 import socket
+from pathlib import Path
 from typing import List
 
-
 import matlab_proxy
 from matlab_proxy import util
-from matlab_proxy.util import system
 from matlab_proxy.constants import VERSION_INFO_FILE_NAME
+from matlab_proxy.util import system
 
 from . import environment_variables as mwi_env
 from . import logger as mwi_logger
-from .exceptions import MatlabInstallError, FatalError
+from .exceptions import FatalError, MatlabInstallError
 
 logger = mwi_logger.get()
 
@@ -213,10 +212,13 @@ def __get_configs():
         Dict: Contains all the values present in 'matlab_web_desktop_configs' entry_point from all the packages
         installed in the current environment.
     """
+    import importlib_metadata
+
+    matlab_proxy_eps = importlib_metadata.entry_points(
+        group=matlab_proxy.get_entrypoint_name()
+    )
     configs = {}
-    for entry_point in pkg_resources.iter_entry_points(
-        matlab_proxy.get_entrypoint_name()
-    ):
+    for entry_point in matlab_proxy_eps:
         configs[entry_point.name.lower()] = entry_point.load()
 
     return configs

matlab_proxy/util/windows.py

@@ -1,9 +1,12 @@
-# Copyright 2022-2023 The MathWorks, Inc.
+# Copyright 2022-2024 The MathWorks, Inc.
 import asyncio
 
 from matlab_proxy import util
 from matlab_proxy.util import mwi
 from matlab_proxy.util.mwi import environment_variables as mwi_env
+from matlab_proxy.util.mwi.exceptions import (
+    UIVisibleFatalError,
+)
 
 
 """ This file contains methods specific to non-posix / windows OS.
@@ -77,8 +80,9 @@ async def start_matlab(matlab_cmd, matlab_env):
             "MATLAB.exe" == matlab.name()
         ), "Expecting the child process name to be MATLAB.exe"
 
-    except AssertionError as err:
+    except (AssertionError, UIVisibleFatalError) as err:
         raise err
+
     except psutil.NoSuchProcess:
         # We reach here when the intermediate process launched by matlab-proxy died
         # before we can query for its child processes. Hence, to find the actual MATLAB

{matlab_proxy-0.17.0.dist-info → matlab_proxy-0.18.1.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: matlab-proxy
-Version: 0.17.0
+Version: 0.18.1
 Summary: Python® package enables you to launch MATLAB® and access it from a web browser.
 Home-page: https://github.com/mathworks/matlab-proxy/
 Author: The MathWorks, Inc.
@@ -18,8 +18,10 @@ Classifier: Programming Language :: Python :: 3.11
 Requires-Python: ~=3.8
 Description-Content-Type: text/markdown
 Requires-Dist: aiohttp >=3.7.4
-Requires-Dist: psutil
 Requires-Dist: aiohttp-session[secure]
+Requires-Dist: importlib-metadata
+Requires-Dist: importlib-resources
+Requires-Dist: psutil
 Provides-Extra: dev
 Requires-Dist: aiohttp-devtools ; extra == 'dev'
 Requires-Dist: black ; extra == 'dev'

{matlab_proxy-0.17.0.dist-info → matlab_proxy-0.18.1.dist-info}/RECORD

@@ -1,10 +1,10 @@
 matlab_proxy/__init__.py,sha256=6cwi8buKCMtw9OeWaOYUHEoqwl5MyJ_s6GxgNuqPuNg,1673
-matlab_proxy/app.py,sha256=aoKkhw_E71uCJeMzqr9VE4mrIRd_4Aqt3Uw4nrYiZZY,34386
-matlab_proxy/app_state.py,sha256=-8gduqMymI7U_NwNRtL26skrjOlnDRiM2vXqBTfMnKo,59525
-matlab_proxy/constants.py,sha256=gHL6bYgRDyzufMx1XF9tbtC9vsS_yQlfYPNommti8tA,972
+matlab_proxy/app.py,sha256=ri2Dm3G3uVmIhoEV01awazsO4t3Z92LEwin657bq8bw,34538
+matlab_proxy/app_state.py,sha256=i5AVaNroFSld4Y36BNil5lwS0PNrHnceYq7swXY5AI4,60502
+matlab_proxy/constants.py,sha256=CrbIA098b5LMsqxY7nbap0_tqA2tIrIckGAffTgIkrA,1039
 matlab_proxy/default_configuration.py,sha256=DxQaHzAivzstiPl_nDfxs8SOyP9oaK9v3RP4LtroJl4,843
 matlab_proxy/devel.py,sha256=nR6XPVBUEdQ-RZGtYvX1YHTp8gj9cuw5Hp8ahasMBc8,14310
-matlab_proxy/settings.py,sha256=Q901JN7zwcySVOs7EQ69m4Ngishmo9ihFzqbPxXajh4,24915
+matlab_proxy/settings.py,sha256=I4nvFZzACKx-JBlAFCFWHA60gg66bR4hrXj1f5awfbA,25616
 matlab_proxy/gui/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 matlab_proxy/gui/asset-manifest.json,sha256=XqmLvi3DDOGSbBxNZwjuaNJXoYjZiG2HasxvZnEzPEo,3516
 matlab_proxy/gui/favicon.ico,sha256=7w7Ki1uQP2Rgwc64dOV4-NrTu97I3WsZw8OvRSoY1A0,130876
@@ -52,28 +52,29 @@ matlab_proxy/gui/static/media/terminate.7ea1363ee0fa72344ef6.svg,sha256=LDLYNWk_
 matlab_proxy/gui/static/media/trigger-error.3f1c4ef23ab8f3e60b0e.svg,sha256=3zzT0uTrl4M_HlAjjVy_9F6fJDY9TifdQCFYX36LCOY,5017
 matlab_proxy/gui/static/media/trigger-ok.7b9c238be42f685c4fa7.svg,sha256=mD-7N9cc4ARdMBFcplnogJv6nA4Yh3jQuYbZDUi18LU,4997
 matlab_proxy/icons/matlab.svg,sha256=xh5uYebQd8I-ISvenjU9A-PkClzW_lU9wvm3doXOFKM,13366
-matlab_proxy/matlab/startup.m,sha256=YRtI8P2flDJSDcPxJ2008B2l1T9JpqiUbzhQxA0frbc,1558
-matlab_proxy/util/__init__.py,sha256=ikj07VxQdIThUWzWLOrdIsO-R1VtEhunB0mjrfnD5jE,8114
+matlab_proxy/matlab/evaluateUserMatlabCode.m,sha256=R8w6nPdGtadR4UUFJaspcrGQL7cJwUItdrfc531w3bM,2420
+matlab_proxy/matlab/startup.m,sha256=1hIvfWgBDcvM3wW__X2yaQ6cBwKjdh5eO0zycbJB78k,1555
+matlab_proxy/util/__init__.py,sha256=rhBsXJT-5v67FuJ9Rz23yDT7afYfwrS5y_oMQSTbCwg,8456
 matlab_proxy/util/event_loop.py,sha256=Zqd282jlvPHHyc4kg8IjIzlzh9zLM_SAc5xjqUOrm04,1144
 matlab_proxy/util/list_servers.py,sha256=M93coVZjyQCdIvCCxsNOU_XDWNjBSysOJ5tWXaTjP8Y,1369
 matlab_proxy/util/mw.py,sha256=dLGSdfcTZiwKR1MMZA-39o-8na13IEPZOGBqcaHmKVI,11086
 matlab_proxy/util/system.py,sha256=XoT3Rv5MwPkdfhk2oMvUwxxlzZmADMlxzi9IRQyGgbA,1692
-matlab_proxy/util/windows.py,sha256=R9-VA7f0snVanSR7IgbHz3kvSnthZuUYe2UhBd5QWMQ,3440
+matlab_proxy/util/windows.py,sha256=J5O-wihOxEex43_AzwvFylNlN4hcZdO6KD5cpLv1FX8,3538
 matlab_proxy/util/mwi/__init__.py,sha256=zI-X1lafr8H3j17PyA0oSZ0q5nINfK-WDA7VmJKmSAQ,158
 matlab_proxy/util/mwi/custom_http_headers.py,sha256=kfDjSnEXEVzoF2pZuEn76LKayeD2WKoQEDu2Y9EMOAo,7154
 matlab_proxy/util/mwi/download.py,sha256=-GJj3yOsL4vF_9baqRXkgBI-vu_OwjZMQVkJXFS8GMc,4965
-matlab_proxy/util/mwi/environment_variables.py,sha256=bIz0QFWo0pgyvSeJ_kAobUCS17V05CSmFWm3zYIOIsA,7139
+matlab_proxy/util/mwi/environment_variables.py,sha256=SC5pMCs2EVWd9NrvA8yYbCOm998SXDhQCIG1h8Ilysc,7309
 matlab_proxy/util/mwi/exceptions.py,sha256=93HrHbOq24KI4Md2el23XN01wIqVShEK29Pbt2V0Jr8,4628
 matlab_proxy/util/mwi/logger.py,sha256=e7wTPclrtJ-aX5mPk_pUJMX7-1QD_snGBW1P2ks-ETE,3311
 matlab_proxy/util/mwi/token_auth.py,sha256=UbIWqo7qADaZdijFvorLYsZbxzaB8TycGP8nk305ru0,9997
-matlab_proxy/util/mwi/validators.py,sha256=BMMOD-0tdjGIALm1MmG4yXVRoD2ZUXkrJXLWP_D5FGo,11712
+matlab_proxy/util/mwi/validators.py,sha256=QEaP0N6U8BF4MglxrkM1phK0lWNiWBK7JdJbcfFRACY,11765
 matlab_proxy/util/mwi/embedded_connector/__init__.py,sha256=SVSckEJ4zQQ2KkNPT_un8ndMAImcMOTrai7ShAbmFY4,114
 matlab_proxy/util/mwi/embedded_connector/helpers.py,sha256=p6TedefbvhlZT64IMwFjrb0panWCXf-T3XPoztDbxM0,3391
 matlab_proxy/util/mwi/embedded_connector/request.py,sha256=-6DL9K8JWjX5u5XVOEGaqBUIwQ-oCVW30-VP3qk_rzw,3730
 tests/integration/__init__.py,sha256=ttzJ8xKWGxOJZz56qOiWOn6sp5LGomkZMn_w4KJLRMU,42
 tests/integration/integration_tests_with_license/__init__.py,sha256=vVYZCur-QhmIGCxUmn-WZjIywtDQidaLDmlmrRHRlgY,37
 tests/integration/integration_tests_with_license/conftest.py,sha256=sCaIXB8d4vf05C7JWSVA7g5gnPjbpRq3dftuBpWyp1s,1599
-tests/integration/integration_tests_with_license/test_http_end_points.py,sha256=SDJIoyo-hh2Ns9uWaDeO87N0jY3svhKOn29HFFyx_jM,7485
+tests/integration/integration_tests_with_license/test_http_end_points.py,sha256=51r3foIshg80NLgvsxaQUxlnnZiKs0O6gLvdF3Y7sWk,14448
 tests/integration/integration_tests_without_license/__init__.py,sha256=vVYZCur-QhmIGCxUmn-WZjIywtDQidaLDmlmrRHRlgY,37
 tests/integration/integration_tests_without_license/conftest.py,sha256=n-oppKWxavyy1O0J6DywO3DnOHuYc7yUZRXm3Bt4szU,3526
 tests/integration/integration_tests_without_license/test_matlab_is_down_if_unlicensed.py,sha256=tkdyhfZBpfJpbnEzjURyV-GE0p43YxOa9xooJf-JoM4,1653
@@ -83,17 +84,18 @@ tests/integration/utils/licensing.py,sha256=rEBjvMXO8R3mL6KnePu2lojmOsjD4GXl9frf
 tests/unit/__init__.py,sha256=KfwQxxM5a1kMRtNbhz8tb7YfHp8e2d0tNLB55wYvDS8,37
 tests/unit/conftest.py,sha256=Hfxq3h8IZuLJkRMh5jdEFiq78CIAdKvm-6KryRDZ0FY,1918
 tests/unit/test_app.py,sha256=xiiEQu1iNK0h3Yuwn3c-hgvNhC1EXKFgTbE_7U3mSrs,37731
-tests/unit/test_app_state.py,sha256=xwXOmyzamL89eg4q2s4IpFKWDN4r2lZwsHBafqDkins,21854
+tests/unit/test_app_state.py,sha256=qD2I7qfUwME_M8lCMsg62Kmky5xdCBav3r3em39Zkt0,22906
 tests/unit/test_constants.py,sha256=ieDKc7bL8zWsd_D4dv2n8iftXr2h-bkS5p6zVan0BtQ,125
 tests/unit/test_ddux.py,sha256=a2J2iM8j_nnfJVuMI38p5AjwrRdoMj3N88gFgS2I4hg,713
 tests/unit/test_devel.py,sha256=A-1iVhSSwmywaW65QIRcUS2Fk7nJxceCcCm7CJtNdEc,7982
 tests/unit/test_non_dev_mode.py,sha256=0v27y27SLOWvw6jf_GhLLNg-RMsZS_OyGAnqoQYPpSA,5515
-tests/unit/test_settings.py,sha256=6KuYcOIqilR5RmaYxHw5mr_4CqDS3iMsouS-IrT9wGk,16644
+tests/unit/test_settings.py,sha256=eBlV-ME_O8oLoOjJqqYTDTXJs-0smnM0oIMwHZEjUbo,17727
 tests/unit/util/__init__.py,sha256=GInSQBb2SoVD5LZfmSCQa9-UZJT_UP-jNfrojkgCybU,87
 tests/unit/util/test_mw.py,sha256=YC4mjn6G6_XuHELt8uW9F6g2K0_fWtQl1R0kWFvWbAo,18565
-tests/unit/util/test_util.py,sha256=jhZOgErpD6b3JeusLBOPVvu6iZ3_ttwlEVV8uKLUvrw,5060
+tests/unit/util/test_util.py,sha256=vqTPgmaKDWhVBRnCKtCNg-OtyR5bP8jeH9DnpcbfVTk,5141
 tests/unit/util/mwi/__init__.py,sha256=pl5jqyCHEwZEviiL8OC-SHulb1rBecstQCFF6qVjL9Y,37
 tests/unit/util/mwi/test_custom_http_headers.py,sha256=UfrhclS0j6WhShtg1ki2oF1kK8JqRC29uevH4tuDqF4,11182
+tests/unit/util/mwi/test_download.py,sha256=jYwPJFYGrPKqnkIJW42XYSe1fowmzChAkOx0k0xVldo,4779
 tests/unit/util/mwi/test_logger.py,sha256=zWImNitMYKPJunXWJjEDEtCEKwBz615PC844ZLwoxIg,1845
 tests/unit/util/mwi/test_token_auth.py,sha256=-eBsaQ5JC7pyd9PXt48Rqs4cWjg6I-eOkp_gFVEwYhk,10538
 tests/unit/util/mwi/test_validators.py,sha256=YeOP0-T7SFNeiC7JIQj7cV4ja3d6PhswsTz27IEgJHQ,10852
@@ -102,9 +104,9 @@ tests/unit/util/mwi/embedded_connector/test_helpers.py,sha256=vYTWNUTuDeaygo16JG
 tests/unit/util/mwi/embedded_connector/test_request.py,sha256=PR-jddnXDEiip-lD7A_QSvRwEkwo3eQ8owZlk-r9vnk,1867
 tests/utils/__init__.py,sha256=ttzJ8xKWGxOJZz56qOiWOn6sp5LGomkZMn_w4KJLRMU,42
 tests/utils/logging_util.py,sha256=VBy_NRvwau3C_CVTBjK5RMROrQimnJYHO2U0aKSZiRw,2234
-matlab_proxy-0.17.0.dist-info/LICENSE.md,sha256=oF0h3UdSF-rlUiMGYwi086ZHqelzz7yOOk9HFDv9ELo,2344
-matlab_proxy-0.17.0.dist-info/METADATA,sha256=_UnbcVVZElb72b3PjnP85kmOmqYdzoXv1tcsEGkVD5s,10108
-matlab_proxy-0.17.0.dist-info/WHEEL,sha256=GJ7t_kWBFywbagK5eo9IoUwLW6oyOeTKmQ-9iHFVNxQ,92
-matlab_proxy-0.17.0.dist-info/entry_points.txt,sha256=DbBLYgnRt8UGiOpd0zHigRTyyMdZYhMdvCvSYP7wPN0,244
-matlab_proxy-0.17.0.dist-info/top_level.txt,sha256=9uVTjsUCAS4TwsxueTBxrBg3PdBiTSsYowAkHPv9VY0,19
-matlab_proxy-0.17.0.dist-info/RECORD,,
+matlab_proxy-0.18.1.dist-info/LICENSE.md,sha256=oF0h3UdSF-rlUiMGYwi086ZHqelzz7yOOk9HFDv9ELo,2344
+matlab_proxy-0.18.1.dist-info/METADATA,sha256=Q5A3PKIyRDzKYk96M5XLsxeh6vHUIl4mDubWPAQvock,10177
+matlab_proxy-0.18.1.dist-info/WHEEL,sha256=GJ7t_kWBFywbagK5eo9IoUwLW6oyOeTKmQ-9iHFVNxQ,92
+matlab_proxy-0.18.1.dist-info/entry_points.txt,sha256=DbBLYgnRt8UGiOpd0zHigRTyyMdZYhMdvCvSYP7wPN0,244
+matlab_proxy-0.18.1.dist-info/top_level.txt,sha256=9uVTjsUCAS4TwsxueTBxrBg3PdBiTSsYowAkHPv9VY0,19
+matlab_proxy-0.18.1.dist-info/RECORD,,

tests/integration/integration_tests_with_license/test_http_end_points.py

@@ -1,27 +1,167 @@
 # Copyright 2023-2024 The MathWorks, Inc.
 
+"""
+Contains integration tests which exercise HTTP endpoints of interest exposed by matlab-proxy-app
+"""
+
+# Imports
+from enum import Enum
 import json
 import os
-import time
-import matlab_proxy.settings as settings
-from tests.integration.utils import integration_tests_utils as utils
 import pytest
-from matlab_proxy.util import system
-import requests
 import re
+import requests
+import time
 from requests.adapters import HTTPAdapter, Retry
 from urllib.parse import urlparse, parse_qs
-from tests.utils.logging_util import create_integ_test_logger
+
+# Local module imports
+import matlab_proxy.settings as settings
 from matlab_proxy.constants import MWI_AUTH_TOKEN_NAME_FOR_HTTP
+from matlab_proxy.util import system
+from tests.integration.utils import integration_tests_utils as utils
+from tests.utils.logging_util import create_integ_test_logger
 
+# Logger Setup
 _logger = create_integ_test_logger(__name__)
 
+# Constants
+
 # Timeout for polling the matlab-proxy http endpoints
 # matlab proxy in Mac machines takes more time to be 'up'
-
 MAX_TIMEOUT = settings.get_process_startup_timeout()
 
 
+class Format(Enum):
+    """
+    An enumeration to specify different format types.
+
+    Attributes:
+        JSON (int): Represents the JSON format type.
+        TEXT (int): Represents the plain text format type.
+    """
+
+    JSON = 1
+    TEXT = 2
+
+
+# Utility Functions
+def _http_get_request(
+    uri, connection_scheme, headers, http_endpoint="", outputFormat=Format.TEXT
+):
+    """
+    Sends an HTTP GET request to a specified URI, optionally appending an endpoint to the URI.
+
+    This function uses a session with retries configured for transient network errors. It can return
+    the response in either text or JSON format, based on the outputFormat parameter.
+
+    Parameters:
+    - uri (str): The base URI for the HTTP request.
+    - connection_scheme (str): The scheme to use for the connection (e.g., 'http' or 'https').
+    - headers (dict): A dictionary of HTTP headers to include in the request.
+    - http_endpoint (str, optional): An additional endpoint to append to the base URI. Defaults to an empty string.
+    - outputFormat (format, optional): The desired format for the response content. This should be an attribute
+      of a format enumeration, supporting at least 'TEXT' and 'JSON' options. Defaults to Format.TEXT.
+
+    Returns:
+    - str or dict: The response content as a string if outputFormat is Format.TEXT, or as a dictionary
+      if outputFormat is Format.JSON.
+
+    Raises:
+    - Exception: If an invalid output format is specified.
+
+    Note:
+    - The function disables SSL certificate verification (`verify=False`). This may introduce security risks,
+      such as vulnerability to man-in-the-middle attacks. Use with caution in a production environment.
+    """
+    request_uri = uri + http_endpoint
+    with requests.Session() as s:
+        retries = Retry(total=10, backoff_factor=0.1)
+        s.mount(f"{connection_scheme}://", HTTPAdapter(max_retries=retries))
+        response = s.get(request_uri, headers=headers, verify=False)
+
+        if outputFormat == Format.TEXT:
+            return response.text
+        elif outputFormat == Format.JSON:
+            return json.loads(response.text)
+
+    raise Exception("Invalid output format specified.")
+
+
+def _check_matlab_status(matlab_proxy_app_fixture, status):
+    """
+    Check the status of a MATLAB session until a specified status is reached or a timeout occurs.
+
+    This function repeatedly sends HTTP GET requests to a MATLAB proxy application to check the current
+    status of MATLAB. It continues checking until MATLAB's status matches the specified target status or
+    until a maximum timeout is reached.
+
+    Parameters:
+    - matlab_proxy_app_fixture: An object containing configuration for connecting to the MATLAB proxy application.
+      This object must have the following attributes:
+        - url (str): The base URL of the MATLAB proxy application.
+        - connection_scheme (str): The scheme used for the connection (e.g., 'http' or 'https').
+        - headers (dict): A dictionary of HTTP headers to be sent with each request.
+    - status (str): The target status to wait for MATLAB to reach.
+
+    Returns:
+    - str: The status of MATLAB at the end of the function execution. This could be the target status if
+      it was reached within the timeout period, or the last known status of MATLAB if the timeout was reached
+      first.
+
+    Notes:
+    - The function waits for a maximum of MAX_TIMEOUT seconds, defined elsewhere, before exiting.
+    - It checks the MATLAB status every 1 second.
+    - The MATLAB status is obtained by sending a GET request to the '/get_status' endpoint of the proxy application.
+    - The response from the proxy application is expected to be in JSON format, with MATLAB's status accessible
+      via `res["matlab"]["status"]`.
+
+    Exceptions:
+    - This function may raise exceptions related to network issues or JSON parsing errors, which are not
+      explicitly handled within the function.
+    """
+    uri = matlab_proxy_app_fixture.url
+    connection_scheme = matlab_proxy_app_fixture.connection_scheme
+    headers = matlab_proxy_app_fixture.headers
+
+    matlab_status = None
+
+    start_time = time.time()
+    while matlab_status != status and (time.time() - start_time < MAX_TIMEOUT):
+        time.sleep(1)
+        res = _http_get_request(
+            uri,
+            connection_scheme,
+            headers,
+            http_endpoint="/get_status",
+            outputFormat=Format.JSON,
+        )
+        matlab_status = res["matlab"]["status"]
+
+    return matlab_status
+
+
+def _download_test_file(matlab_proxy_app_fixture, test_file):
+    """Returns result of hitting the /download endpoint for test_file.
+
+    Returns:
+        str: The contents of the test_file being downloaded through matlab-proxy.
+    """
+    uri = matlab_proxy_app_fixture.url
+    connection_scheme = matlab_proxy_app_fixture.connection_scheme
+    headers = matlab_proxy_app_fixture.headers
+
+    res = _http_get_request(
+        uri,
+        connection_scheme,
+        headers,
+        http_endpoint="/download/" + test_file,
+        outputFormat=Format.TEXT,
+    )
+    return res
+
+
+# Main Classes
 class RealMATLABServer:
     """
     Context Manager class which returns matlab proxy web server serving real MATLAB
@@ -103,40 +243,7 @@ class RealMATLABServer:
         _logger.debug("Terminated the MATLAB process.")
 
 
-def _send_http_get_request(uri, connection_scheme, headers, http_endpoint=""):
-    """Send HTTP request to matlab-proxy server.
-    Returns HTTP response JSON"""
-
-    request_uri = uri + http_endpoint
-
-    json_response = None
-    with requests.Session() as s:
-        retries = Retry(total=10, backoff_factor=0.1)
-        s.mount(f"{connection_scheme}://", HTTPAdapter(max_retries=retries))
-        response = s.get(request_uri, headers=headers, verify=False)
-        json_response = json.loads(response.text)
-
-    return json_response
-
-
-def _check_matlab_status(matlab_proxy_app_fixture, status):
-    uri = matlab_proxy_app_fixture.url
-    connection_scheme = matlab_proxy_app_fixture.connection_scheme
-    headers = matlab_proxy_app_fixture.headers
-
-    matlab_status = None
-
-    start_time = time.time()
-    while matlab_status != status and (time.time() - start_time < MAX_TIMEOUT):
-        time.sleep(1)
-        res = _send_http_get_request(
-            uri, connection_scheme, headers, http_endpoint="/get_status"
-        )
-        matlab_status = res["matlab"]["status"]
-
-    return matlab_status
-
-
+# Fixtures
 @pytest.fixture
 def matlab_proxy_app_fixture(
     loop,
@@ -159,6 +266,44 @@ def matlab_proxy_app_fixture(
         pass
 
 
+@pytest.fixture
+def test_file_contents():
+    """
+    A pytest fixture that provides a string for testing purposes.
+
+    This fixture returns a predefined string that can be used in tests to simulate
+    the contents of a file or any scenario where a constant string value is needed.
+
+    Returns:
+        str: A string containing the text "I LOVE MATLAB."
+    """
+    return "I LOVE MATLAB."
+
+
+@pytest.fixture
+def test_file(tmp_path, test_file_contents):
+    """
+    A pytest fixture that creates a temporary test file with given contents.
+
+    This fixture utilizes pytest's `tmp_path` fixture to generate a temporary directory,
+    then creates a file named "temporary_test_file.txt" within this directory,
+    and writes the provided contents to this file. It is useful for tests that require
+    reading from or writing to files without affecting the actual file system.
+
+    Parameters:
+    - tmp_path (Path): A pytest fixture that provides a temporary directory unique to the test function.
+    - test_file_contents (str): The content to be written into the temporary test file.
+
+    Returns:
+    - str: The path to the created temporary test file as a string.
+    """
+    test_file = os.path.join(tmp_path, "temporary_test_file.txt")
+    with open(test_file, "w+") as f:
+        f.write(test_file_contents)
+    return test_file
+
+
+# Test Functions
 def test_matlab_is_up(matlab_proxy_app_fixture):
     """Test that the status switches from 'starting' to 'up' within a timeout.
 
@@ -195,13 +340,13 @@ def test_stop_matlab(matlab_proxy_app_fixture):
     assert status == "down"
 
 
-# FIXME: If output has logging or extra debug info, 600 bytes might not be enough.
 async def test_print_message(matlab_proxy_app_fixture):
     """Test if the right logs are printed
 
     Args:
         matlab_proxy_app_fixture: A pytest fixture which yields a real matlab server to be used by tests.
 
+    FIXME: If output has logging or extra debug info, 600 bytes might not be enough.
     """
     # Checks if matlab proxy is in "up" state or not
     status = _check_matlab_status(matlab_proxy_app_fixture, "up")
@@ -221,3 +366,33 @@ async def test_print_message(matlab_proxy_app_fixture):
     # Close the read and write descriptors.
     os.close(read_descriptor)
     os.close(write_descriptor)
+
+
+def test_download_file_from_matlab(
+    matlab_proxy_app_fixture, test_file, test_file_contents
+):
+    """
+    Test the downloading of a file from a MATLAB proxy application.
+
+    This test function checks if the MATLAB proxy application is up and running, and then attempts to download
+    a specific test file from it. It validates both the status of the MATLAB proxy and the contents of the downloaded file.
+
+    Parameters:
+    - matlab_proxy_app_fixture (fixture): A test fixture representing the MATLAB proxy application environment.
+    - test_file (str): The name or path of the test file to be downloaded from the MATLAB proxy application.
+    - test_file_contents (str): The expected contents of the test file to validate the download operation.
+
+    Assertions:
+    - Asserts that the MATLAB proxy application is "up".
+    - Asserts that the content of the downloaded file matches the expected `test_file_contents`.
+
+    Raises:
+    - AssertionError: If any of the assertions fail, indicating either the MATLAB proxy application is not running
+      as expected or there is a mismatch in the file content.
+    """
+    status = _check_matlab_status(matlab_proxy_app_fixture, "up")
+    assert status == "up"
+
+    # Once MATLAB is up, we can then attempt to download
+    result = _download_test_file(matlab_proxy_app_fixture, test_file)
+    assert result == test_file_contents

tests/unit/test_app_state.py

@@ -7,6 +7,7 @@ from pathlib import Path
 from typing import Optional
 
 import pytest
+from matlab_proxy import settings
 
 from matlab_proxy import settings
 from matlab_proxy.app_state import AppState
@@ -14,6 +15,11 @@ from matlab_proxy.constants import MWI_AUTH_TOKEN_NAME_FOR_HTTP
 from matlab_proxy.util.mwi.exceptions import LicensingError, MatlabError
 from tests.unit.util import MockResponse
 
+from matlab_proxy.constants import (
+    CONNECTOR_SECUREPORT_FILENAME,
+    USER_CODE_OUTPUT_FILE_NAME,
+)
+
 
 @pytest.fixture
 def sample_settings_fixture(tmp_path):
@@ -35,6 +41,7 @@ def sample_settings_fixture(tmp_path):
         "mwi_logs_root_dir": Path(settings.get_mwi_config_folder(dev=True)),
         "app_port": 12345,
         "mwapikey": "asdf",
+        "has_custom_code_to_execute": False,
     }
 
 
@@ -662,3 +669,30 @@ async def test_detect_active_client_status_can_reset_active_client(app_state_fix
     assert (
         app_state_fixture.active_client == None
     ), f"Expected the active_client to be None"
+
+
+@pytest.mark.parametrize(
+    "session_file_count, has_custom_code_to_execute", [(2, True), (1, False)]
+)
+def test_create_logs_dir_for_MATLAB(
+    app_state_fixture, session_file_count, has_custom_code_to_execute
+):
+    """Test to check create_logs_dir_for_MATLAB()
+
+    Args:
+        app_state_fixture (AppState): Object of AppState class with defaults set
+    """
+    # Arrange
+    app_state_fixture.settings["has_custom_code_to_execute"] = (
+        has_custom_code_to_execute
+    )
+
+    # Act
+    app_state_fixture.create_logs_dir_for_MATLAB()
+
+    # Assert
+    for _, session_file_path in app_state_fixture.matlab_session_files.items():
+        # Check session files are present in mwi logs directory
+        assert app_state_fixture.mwi_logs_dir == Path(session_file_path).parent
+
+    assert len(app_state_fixture.matlab_session_files) == session_file_count

tests/unit/test_settings.py

@@ -458,3 +458,38 @@ def test_get_ssl_context_with_invalid_custom_ssl_files_raises_exception(
 
     with pytest.raises(Exception, match=exception_msg):
         settings._validate_ssl_files_and_get_ssl_context(mwi_certs_dir)
+
+
+@pytest.mark.parametrize(
+    "expected_value_for_has_custom_code, custom_code, has_custom_code_exception_matlab_cmd",
+    [(False, "", False), (True, "run(disp('MATLAB'))", True)],
+    ids=["No custom code to execute", "Has custom code to execute"],
+)
+def test_get_matlab_settings_custom_code(
+    monkeypatch,
+    mocker,
+    expected_value_for_has_custom_code,
+    custom_code,
+    has_custom_code_exception_matlab_cmd,
+):
+    # Arrange
+    monkeypatch.setenv(mwi_env.get_env_name_custom_matlab_code(), custom_code)
+    mocker.patch(
+        "matlab_proxy.settings.get_matlab_executable_and_root_path",
+        return_value=("matlab", None),
+    )
+
+    # Act
+    matlab_settings = settings.get_matlab_settings()
+    exception_present_in_matlab_cmd = (
+        "MATLABCustomStartupCodeError" in matlab_settings["matlab_cmd"][-1]
+    )
+    print(matlab_settings)
+
+    # Assert
+    assert (
+        matlab_settings["has_custom_code_to_execute"]
+        == expected_value_for_has_custom_code
+    )
+
+    assert exception_present_in_matlab_cmd == has_custom_code_exception_matlab_cmd

tests/unit/util/mwi/test_download.py

@@ -0,0 +1,152 @@
+# Copyright 2024 The MathWorks, Inc.
+import pytest
+
+from matlab_proxy.util.mwi.download import (
+    _get_download_payload_path,
+    get_download_url,
+    is_download_request,
+)
+
+
+# Mock the request object
+@pytest.fixture
+def mock_request_fixture(mocker):
+    mock_req = mocker.MagicMock()
+    mock_req.app = {
+        "settings": {"base_url": ""},
+        "state": mocker.MagicMock(),
+    }
+    mock_req.rel_url = mocker.MagicMock()
+    return mock_req
+
+
+def _get_expected_output_based_on_os_type(paths: list) -> str:
+    import matlab_proxy.util.system as system
+
+    return "\\".join(paths) if system.is_windows() else "/".join(paths)
+
+
+# Test for is_download_request function
+@pytest.mark.parametrize(
+    "test_base_url, path, expected",
+    [
+        ("/", "/download/something", True),
+        ("", "/download/something", True),
+        ("/base", "/base/download/something", True),
+        ("/base", "/download/something", False),
+    ],
+    ids=[
+        "/ base url and path starting with /download",
+        "empty base url and path starting with /download",
+        "non-empty base url and path starting with that base url",
+        "non-empty base url and path not starting with that base url",
+    ],
+)
+def test_is_download_request(mock_request_fixture, test_base_url, path, expected):
+    mock_request_fixture.app["settings"]["base_url"] = test_base_url
+    mock_request_fixture.rel_url.path = path
+    assert is_download_request(mock_request_fixture) == expected
+
+
+# Test for _get_download_payload_path function
+# This test is a bit tricky since it involves file system operations and OS checks.
+# We will mock system.is_windows() and test for both Windows and Posix systems.
+@pytest.mark.parametrize(
+    "is_windows, test_base_url, path, expected",
+    [
+        (
+            True,
+            "",
+            "/downloadC:\\some\\path\\to\\file.txt",
+            "C:\\some\\path\\to\\file.txt",
+        ),
+        (
+            True,
+            "/base",
+            "/base/downloadC:\\some\\path\\to\\file.txt",
+            "C:\\some\\path\\to\\file.txt",
+        ),
+        (
+            False,
+            "",
+            "/download/some/path/to/file.txt",
+            _get_expected_output_based_on_os_type(["/some", "path", "to", "file.txt"]),
+        ),
+        (
+            False,
+            "/base",
+            "/base/download/some/path/to/file.txt",
+            _get_expected_output_based_on_os_type(["/some", "path", "to", "file.txt"]),
+        ),
+    ],
+    ids=[
+        "Windows with null base url",
+        "Windows with non-null base url",
+        "Linux with null base url",
+        "Linux with non-null base url",
+    ],
+)
+def test_get_download_payload_path(
+    mock_request_fixture, mocker, is_windows, test_base_url, path, expected
+):
+    mocker.patch("matlab_proxy.util.system.is_windows", return_value=is_windows)
+    mock_request_fixture.app["settings"]["base_url"] = test_base_url
+    mock_request_fixture.rel_url.path = path
+    assert _get_download_payload_path(mock_request_fixture) == expected
+
+
+def test_get_download_payload_path_invalid_request(mock_request_fixture):
+    test_base_url = "/base"
+    path = "/download/something"
+
+    mock_request_fixture.app["settings"]["base_url"] = test_base_url
+    mock_request_fixture.rel_url.path = path
+
+    assert _get_download_payload_path(mock_request_fixture) is None
+
+
+@pytest.mark.parametrize(
+    "response_json, expected_url",
+    [
+        (
+            {
+                "messages": {
+                    "FEvalResponse": [
+                        {"isError": False, "results": ["http://download-url.com"]}
+                    ]
+                }
+            },
+            "http://download-url.com",
+        ),
+        ({"messages": {"FEvalResponse": [{"isError": True}]}}, None),
+    ],
+    ids=["connector returning correct download url", "connector returning an error"],
+)
+async def test_get_download_url(
+    mock_request_fixture, mocker, response_json, expected_url
+):
+    test_base_url = "/"
+    path = "/download/some/path/to/file.txt"
+
+    mock_request_fixture.app["state"].settings = {
+        "mwi_server_url": "http://mwi-server.com"
+    }
+    mock_request_fixture.app["settings"]["base_url"] = test_base_url
+    mock_request_fixture.rel_url.path = path
+
+    mocker.patch(
+        "matlab_proxy.util.mwi.embedded_connector.helpers.get_data_to_feval_mcode",
+        return_value={},
+    )
+    mocker.patch(
+        "matlab_proxy.util.mwi.embedded_connector.helpers.get_mvm_endpoint",
+        return_value="http://mwi-server.com",
+    )
+    mocker.patch(
+        "matlab_proxy.util.mwi.embedded_connector.send_request",
+        return_value=response_json,
+    )
+
+    download_url = await get_download_url(mock_request_fixture)
+
+    assert download_url == expected_url

tests/unit/util/test_util.py

@@ -6,6 +6,9 @@ import psutil
 
 from matlab_proxy.util import get_child_processes, system, add_signal_handlers, prettify
 from matlab_proxy.util import system
+from matlab_proxy.util.mwi.exceptions import (
+    UIVisibleFatalError,
+)
 
 
 def test_get_supported_termination_signals():
@@ -90,7 +93,7 @@ def test_get_child_processes_no_children(mocker):
     mock_parent_process_psutil.children.return_value = []
 
     # Call the function with the mocked parent process
-    with pytest.raises(RuntimeError):
+    with pytest.raises(UIVisibleFatalError):
         get_child_processes(parent_process)