machineconfig 1.97__py3-none-any.whl → 2.0__py3-none-any.whl

machineconfig/cluster/sessions_managers/zellij_local_manager.py

@@ -4,6 +4,7 @@ import json
 import uuid
 import logging
 import subprocess
+import time
 from pathlib import Path
 from typing import Optional, Dict, List, Any
 
@@ -21,11 +22,11 @@ TMP_SERIALIZATION_DIR = Path.home().joinpath("tmp_results", "session_manager", "
 
 class ZellijLocalManager:
     """Manages multiple local zellij sessions and monitors their tabs and processes."""
-    
+
     def __init__(self, session2zellij_tabs: Dict[str, Dict[str, tuple[str, str]]], session_name_prefix: str = "LocalJobMgr"):
         """
         Initialize the local zellij manager.
-        
+
         Args:
             session2zellij_tabs: Dict mapping session names to their tab configs
                 Format: {session_name: {tab_name: (cwd, command), ...}, ...}
@@ -34,14 +35,14 @@ class ZellijLocalManager:
         self.session_name_prefix = session_name_prefix
         self.session2zellij_tabs = session2zellij_tabs  # Store the original config
         self.managers: List[ZellijLayoutGenerator] = []
-        
+
         # Create a ZellijLayoutGenerator for each session
         for session_name, tab_config in session2zellij_tabs.items():
             manager = ZellijLayoutGenerator()
             full_session_name = f"{self.session_name_prefix}_{session_name}"
             manager.create_zellij_layout(tab_config=tab_config, session_name=full_session_name)
             self.managers.append(manager)
-        
+
         # Enhanced Rich logging for initialization
         console.print(f"[bold green]🔧 Initialized ZellijLocalManager[/bold green] [dim]with[/dim] [bright_green]{len(self.managers)} sessions[/bright_green]")
 
@@ -49,55 +50,73 @@ class ZellijLocalManager:
         """Get all managed session names."""
         return [manager.session_name for manager in self.managers if manager.session_name is not None]
 
-    def start_all_sessions(self) -> Dict[str, Any]:
-        """Start all zellij sessions with their layouts."""
-        results = {}
+    def start_all_sessions(self, poll_seconds: float = 5.0, poll_interval: float = 0.25) -> Dict[str, Any]:
+        """Start all zellij sessions with their layouts without blocking on the interactive TUI.
+
+        Rationale:
+            Previous implementation used subprocess.run(... timeout=30) on an "attach" command
+            which never returns (interactive) causing a timeout. We now:
+              1. Ensure any old session is deleted (best-effort, short timeout)
+              2. Launch new session in background with Popen (no wait)
+              3. Poll 'zellij list-sessions' to confirm creation
+
+        Args:
+            poll_seconds: Total seconds to wait for session to appear
+            poll_interval: Delay between polls
+        Returns:
+            Dict mapping session name to success metadata.
+        """
+        results: Dict[str, Any] = {}
         for manager in self.managers:
+            session_name = manager.session_name
             try:
-                session_name = manager.session_name
                 if session_name is None:
-                    continue  # Skip managers without a session name
-                    
+                    continue
                 layout_path = manager.layout_path
-                
                 if not layout_path:
-                    results[session_name] = {
-                        "success": False,
-                        "error": "No layout file path available"
-                    }
+                    results[session_name] = {"success": False, "error": "No layout file path available"}
+                    continue
+
+                # 1. Best-effort delete existing session
+                delete_cmd = ["zellij", "delete-session", "--force", session_name]
+                try:
+                    subprocess.run(delete_cmd, capture_output=True, text=True, timeout=5)
+                except subprocess.TimeoutExpired:
+                    logger.warning(f"Timeout deleting session {session_name}; continuing")
+                except FileNotFoundError:
+                    results[session_name] = {"success": False, "error": "'zellij' executable not found in PATH"}
                     continue
-                
-                # Delete existing session if it exists, then start with layout
-                cmd = f"zellij delete-session --force {session_name}; zellij --layout {layout_path} attach {session_name} --create"
-                
-                console.print(f"[bold cyan]🚀 Starting session[/bold cyan] [yellow]'{session_name}'[/yellow] [dim]with layout:[/dim] [blue]{layout_path}[/blue]")
-                result = subprocess.run(cmd, shell=True, capture_output=True, text=True, timeout=30)
-                
-                if result.returncode == 0:
-                    results[session_name] = {
-                        "success": True,
-                        "message": f"Session '{session_name}' started successfully"
-                    }
-                    console.print(f"[bold green]✅ Session[/bold green] [yellow]'{session_name}'[/yellow] [green]started successfully[/green]")
+
+                # 2. Launch new session. We intentionally do NOT wait for completion.
+                # Using the same pattern as before (attach --create) but detached via env var.
+                # ZELLIJ_AUTO_ATTACH=0 prevents auto-attach if compiled with that feature; harmless otherwise.
+                start_cmd = [
+                    "bash", "-lc",
+                    f"ZELLIJ_AUTO_ATTACH=0 zellij --layout {layout_path} attach {session_name} --create >/dev/null 2>&1 &"
+                ]
+                console.print(f"[bold cyan]🚀 Starting session[/bold cyan] [yellow]'{session_name}'[/yellow] with layout [blue]{layout_path}[/blue] (non-blocking)...")
+                subprocess.Popen(start_cmd)
+
+                # 3. Poll for presence
+                deadline = time.time() + poll_seconds
+                appeared = False
+                while time.time() < deadline:
+                    list_res = subprocess.run(["zellij", "list-sessions"], capture_output=True, text=True)
+                    if list_res.returncode == 0 and session_name in list_res.stdout:
+                        appeared = True
+                        break
+                    time.sleep(poll_interval)
+
+                if appeared:
+                    results[session_name] = {"success": True, "message": f"Session '{session_name}' started"}
+                    console.print(f"[bold green]✅ Session[/bold green] [yellow]'{session_name}'[/yellow] [green]is up[/green]")
                 else:
-                    results[session_name] = {
-                        "success": False,
-                        "error": result.stderr or result.stdout
-                    }
-                    console.print(f"[bold red]❌ Failed to start session[/bold red] [yellow]'{session_name}'[/yellow][red]:[/red] [dim]{result.stderr}[/dim]")
-                    
+                    results[session_name] = {"success": False, "error": "Session did not appear within poll window"}
+                    console.print(f"[bold red]❌ Session '{session_name}' did not appear after {poll_seconds:.1f}s[/bold red]")
             except Exception as e:
-                # Use a fallback key since session_name might not be defined here
-                try:
-                    key = getattr(manager, 'session_name', None) or f"manager_{self.managers.index(manager)}"
-                except Exception:
-                    key = f"manager_{self.managers.index(manager)}"
-                results[key] = {
-                    "success": False,
-                    "error": str(e)
-                }
+                key = session_name or f"manager_{self.managers.index(manager)}"
+                results[key] = {"success": False, "error": str(e)}
                 logger.error(f"❌ Exception starting session '{key}': {e}")
-        
         return results
 
     def kill_all_sessions(self) -> Dict[str, Any]:
@@ -108,17 +127,17 @@ class ZellijLocalManager:
                 session_name = manager.session_name
                 if session_name is None:
                     continue  # Skip managers without a session name
-                    
+
                 cmd = f"zellij delete-session --force {session_name}"
-                
+
                 logger.info(f"Killing session '{session_name}'")
                 result = subprocess.run(cmd, shell=True, capture_output=True, text=True, timeout=10)
-                
+
                 results[session_name] = {
                     "success": result.returncode == 0,
                     "message": "Session killed" if result.returncode == 0 else result.stderr
                 }
-                
+
             except Exception as e:
                 # Use a fallback key since session_name might not be defined here
                 key = getattr(manager, 'session_name', None) or f"manager_{self.managers.index(manager)}"
@@ -126,16 +145,16 @@ class ZellijLocalManager:
                     "success": False,
                     "error": str(e)
                 }
-                
+
         return results
 
     def attach_to_session(self, session_name: Optional[str] = None) -> str:
         """
         Generate command to attach to a specific session or list attachment commands for all.
-        
+
         Args:
             session_name: Specific session to attach to, or None for all sessions
-            
+
         Returns:
             Command string to attach to session(s)
         """
@@ -157,22 +176,22 @@ class ZellijLocalManager:
     def check_all_sessions_status(self) -> Dict[str, Dict[str, Any]]:
         """Check the status of all sessions and their commands."""
         status_report = {}
-        
+
         for manager in self.managers:
             session_name = manager.session_name
             if session_name is None:
                 continue  # Skip managers without a session name
-            
+
             # Get session status
             session_status = ZellijLayoutGenerator.check_zellij_session_status(session_name)
-            
+
             # Get commands status for this session
             commands_status = manager.check_all_commands_status()
-            
+
             # Calculate summary for this session
             running_count = sum(1 for status in commands_status.values() if status.get("running", False))
             total_count = len(commands_status)
-            
+
             status_report[session_name] = {
                 "session_status": session_status,
                 "commands_status": commands_status,
@@ -183,21 +202,21 @@ class ZellijLocalManager:
                     "session_healthy": session_status.get("session_exists", False)
                 }
             }
-        
+
         return status_report
 
     def get_global_summary(self) -> Dict[str, Any]:
         """Get a global summary across all sessions."""
         all_status = self.check_all_sessions_status()
-        
+
         total_sessions = len(all_status)
-        healthy_sessions = sum(1 for status in all_status.values() 
+        healthy_sessions = sum(1 for status in all_status.values()
                              if status["summary"]["session_healthy"])
-        total_commands = sum(status["summary"]["total_commands"] 
+        total_commands = sum(status["summary"]["total_commands"]
                            for status in all_status.values())
-        total_running = sum(status["summary"]["running_commands"] 
+        total_running = sum(status["summary"]["running_commands"]
                           for status in all_status.values())
-        
+
         return {
             "total_sessions": total_sessions,
             "healthy_sessions": healthy_sessions,
@@ -213,11 +232,11 @@ class ZellijLocalManager:
         """Print a comprehensive status report for all sessions."""
         all_status = self.check_all_sessions_status()
         global_summary = self.get_global_summary()
-        
+
         print("=" * 80)
         print("🔍 ZELLIJ LOCAL MANAGER STATUS REPORT")
         print("=" * 80)
-        
+
         # Global summary
         print("🌐 GLOBAL SUMMARY:")
         print(f"   Total sessions: {global_summary['total_sessions']}")
@@ -226,50 +245,50 @@ class ZellijLocalManager:
         print(f"   Running commands: {global_summary['running_commands']}")
         print(f"   All healthy: {'✅' if global_summary['all_sessions_healthy'] else '❌'}")
         print()
-        
+
         # Per-session details
         for session_name, status in all_status.items():
             session_status = status["session_status"]
             commands_status = status["commands_status"]
             summary = status["summary"]
-            
+
             print(f"📋 SESSION: {session_name}")
             print("-" * 60)
-            
+
             # Session health
             if session_status.get("session_exists", False):
                 print("✅ Session is running")
             else:
                 print(f"❌ Session not found: {session_status.get('error', 'Unknown error')}")
-            
+
             # Commands in this session
             print(f"   Commands ({summary['running_commands']}/{summary['total_commands']} running):")
             for tab_name, cmd_status in commands_status.items():
                 status_icon = "✅" if cmd_status.get("running", False) else "❌"
                 print(f"     {status_icon} {tab_name}: {cmd_status.get('command', 'Unknown')}")
-                
+
                 if cmd_status.get("processes"):
                     for proc in cmd_status["processes"][:2]:  # Show first 2 processes
                         print(f"        └─ PID {proc['pid']}: {proc['name']} ({proc['status']})")
             print()
-        
+
         print("=" * 80)
 
     def run_monitoring_routine(self, wait_ms: int = 30000) -> None:
         """
         Run a continuous monitoring routine that checks status periodically.
-        
+
         Args:
             wait_ms: How long to wait between checks in milliseconds (default: 30000ms = 30s)
         """
         def routine(scheduler: Scheduler):
             print(f"\n⏰ Monitoring cycle {scheduler.cycle} at {datetime.now()}")
             print("-" * 50)
-            
+
             if scheduler.cycle % 2 == 0:
                 # Detailed status check every other cycle
                 all_status = self.check_all_sessions_status()
-                
+
                 # Create DataFrame for easier viewing
                 status_data = []
                 for session_name, status in all_status.items():
@@ -281,7 +300,7 @@ class ZellijLocalManager:
                             "command": cmd_status.get("command", "Unknown")[:50] + "..." if len(cmd_status.get("command", "")) > 50 else cmd_status.get("command", ""),
                             "processes": len(cmd_status.get("processes", []))
                         })
-                
+
                 if status_data:
                     # Format data as table
                     if status_data:
@@ -294,7 +313,7 @@ class ZellijLocalManager:
                         for row in status_data:
                             values = [str(row.get(h, ""))[:15] for h in headers]
                             print(" | ".join(f"{v:<15}" for v in values))
-                    
+
                     # Check if all sessions have stopped
                     running_count = sum(1 for row in status_data if row.get("running", False))
                     if running_count == 0:
@@ -307,25 +326,25 @@ class ZellijLocalManager:
                 # Quick summary check
                 global_summary = self.get_global_summary()
                 print(f"📊 Quick Summary: {global_summary['running_commands']}/{global_summary['total_commands']} commands running across {global_summary['healthy_sessions']}/{global_summary['total_sessions']} sessions")
-        
+
         logger.info(f"Starting monitoring routine with {wait_ms}ms intervals")
-        sched = Scheduler(routine=routine, wait_ms=wait_ms)
+        sched = Scheduler(routine=routine, wait_ms=wait_ms, logger=logger)
         sched.run()
 
     def save(self, session_id: Optional[str] = None) -> str:
         """Save the manager state to disk."""
         if session_id is None:
             session_id = str(uuid.uuid4())[:8]
-        
+
         # Create session directory
         session_dir = TMP_SERIALIZATION_DIR / session_id
         session_dir.mkdir(parents=True, exist_ok=True)
-        
+
         # Save the session2zellij_tabs configuration
         config_file = session_dir / "session2zellij_tabs.json"
-        with open(config_file, 'w', encoding='utf-8') as f:
-            json.dump(self.session2zellij_tabs, f, indent=2, ensure_ascii=False)
-        
+        text = json.dumps(self.session2zellij_tabs, indent=2, ensure_ascii=False)
+        config_file.write_text(text, encoding="utf-8")
+
         # Save metadata
         metadata = {
             "session_name_prefix": self.session_name_prefix,
@@ -335,13 +354,13 @@ class ZellijLocalManager:
             "manager_type": "ZellijLocalManager"
         }
         metadata_file = session_dir / "metadata.json"
-        with open(metadata_file, 'w', encoding='utf-8') as f:
-            json.dump(metadata, f, indent=2, ensure_ascii=False)
-        
+        text = json.dumps(metadata, indent=2, ensure_ascii=False)
+        metadata_file.write_text(text, encoding="utf-8")
+
         # Save each manager's state
         managers_dir = session_dir / "managers"
         managers_dir.mkdir(exist_ok=True)
-        
+
         for i, manager in enumerate(self.managers):
             manager_data = {
                 "session_name": manager.session_name,
@@ -349,9 +368,9 @@ class ZellijLocalManager:
                 "layout_path": manager.layout_path
             }
             manager_file = managers_dir / f"manager_{i}_{manager.session_name}.json"
-            with open(manager_file, 'w', encoding='utf-8') as f:
-                json.dump(manager_data, f, indent=2, ensure_ascii=False)
-        
+            text = json.dumps(manager_data, indent=2, ensure_ascii=False)
+            manager_file.write_text(text, encoding="utf-8")
+
         logger.info(f"✅ Saved ZellijLocalManager session to: {session_dir}")
         return session_id
 
@@ -359,18 +378,18 @@ class ZellijLocalManager:
     def load(cls, session_id: str) -> 'ZellijLocalManager':
         """Load a saved manager state from disk."""
         session_dir = TMP_SERIALIZATION_DIR / session_id
-        
+
         if not session_dir.exists():
             raise FileNotFoundError(f"Session directory not found: {session_dir}")
-        
+
         # Load configuration
         config_file = session_dir / "session2zellij_tabs.json"
         if not config_file.exists():
             raise FileNotFoundError(f"Configuration file not found: {config_file}")
-        
+
         with open(config_file, 'r', encoding='utf-8') as f:
             session2zellij_tabs = json.load(f)
-        
+
         # Load metadata
         metadata_file = session_dir / "metadata.json"
         session_name_prefix = "LocalJobMgr"  # default fallback
@@ -378,32 +397,32 @@ class ZellijLocalManager:
             with open(metadata_file, 'r', encoding='utf-8') as f:
                 metadata = json.load(f)
                 session_name_prefix = metadata.get("session_name_prefix", "LocalJobMgr")
-        
+
         # Create new instance
         instance = cls(session2zellij_tabs=session2zellij_tabs, session_name_prefix=session_name_prefix)
-        
+
         # Load saved manager states
         managers_dir = session_dir / "managers"
         if managers_dir.exists():
             instance.managers = []
             manager_files = sorted(managers_dir.glob("manager_*.json"))
-            
+
             for manager_file in manager_files:
                 try:
                     with open(manager_file, 'r', encoding='utf-8') as f:
                         manager_data = json.load(f)
-                    
+
                     # Recreate the manager
                     manager = ZellijLayoutGenerator()
                     manager.session_name = manager_data["session_name"]
                     manager.tab_config = manager_data["tab_config"]
                     manager.layout_path = manager_data["layout_path"]
-                    
+
                     instance.managers.append(manager)
-                    
+
                 except Exception as e:
                     logger.warning(f"Failed to load manager from {manager_file}: {e}")
-        
+
         logger.info(f"✅ Loaded ZellijLocalManager session from: {session_dir}")
         return instance
 
@@ -412,23 +431,23 @@ class ZellijLocalManager:
         """List all saved session IDs."""
         if not TMP_SERIALIZATION_DIR.exists():
             return []
-        
+
         sessions = []
         for item in TMP_SERIALIZATION_DIR.iterdir():
             if item.is_dir() and (item / "metadata.json").exists():
                 sessions.append(item.name)
-        
+
         return sorted(sessions)
 
     @staticmethod
     def delete_session(session_id: str) -> bool:
         """Delete a saved session."""
         session_dir = TMP_SERIALIZATION_DIR / session_id
-        
+
         if not session_dir.exists():
             logger.warning(f"Session directory not found: {session_dir}")
             return False
-        
+
         try:
             import shutil
             shutil.rmtree(session_dir)
@@ -441,7 +460,7 @@ class ZellijLocalManager:
     def list_active_sessions(self) -> List[Dict[str, Any]]:
         """List currently active zellij sessions managed by this instance."""
         active_sessions = []
-        
+
         try:
             # Get all running zellij sessions
             result = subprocess.run(
@@ -450,27 +469,27 @@ class ZellijLocalManager:
                 text=True,
                 timeout=10
             )
-            
+
             if result.returncode == 0:
                 all_sessions = result.stdout.strip().split('\n') if result.stdout.strip() else []
-                
+
                 # Filter to only our managed sessions
                 for manager in self.managers:
                     session_name = manager.session_name
                     if session_name is None:
                         continue  # Skip managers without a session name
                     is_active = any(session_name in session for session in all_sessions)
-                    
+
                     active_sessions.append({
                         "session_name": session_name,
                         "is_active": is_active,
                         "tab_count": len(manager.tab_config),
                         "tabs": list(manager.tab_config.keys())
                     })
-            
+
         except Exception as e:
             logger.error(f"Error listing active sessions: {e}")
-        
+
         return active_sessions
 
 
@@ -493,41 +512,41 @@ if __name__ == "__main__":
             "📈Metrics": ("~", "k9s")
         }
     }
-    
+
     try:
         # Create the local manager
         manager = ZellijLocalManager(sample_sessions, session_name_prefix="DevEnv")
         print(f"✅ Local manager created with {len(manager.managers)} sessions")
-        
+
         # Show session names
         print(f"📋 Sessions: {manager.get_all_session_names()}")
-        
+
         # Print attachment commands (without actually starting)
         print("\n📎 Attachment commands:")
         print(manager.attach_to_session())
-        
+
         # Show current status
         print("\n🔍 Current status:")
         manager.print_status_report()
-        
+
         # Demonstrate save/load
         print("\n💾 Demonstrating save/load...")
         session_id = manager.save()
         print(f"✅ Saved session: {session_id}")
-        
+
         # List saved sessions
         saved_sessions = ZellijLocalManager.list_saved_sessions()
         print(f"📋 Saved sessions: {saved_sessions}")
-        
+
         # Load and verify
         loaded_manager = ZellijLocalManager.load(session_id)
         print(f"✅ Loaded session with {len(loaded_manager.managers)} sessions")
-        
+
         # Show how to start monitoring (commented out to prevent infinite loop in demo)
         print("\n⏰ To start monitoring, run:")
         print("manager.run_monitoring_routine(wait_ms=30000)  # 30 seconds")
-        
+
     except Exception as e:
         print(f"❌ Error: {e}")
         import traceback
-        traceback.print_exc() 
+        traceback.print_exc()