localstack-core 4.4.1.dev59__py3-none-any.whl → 4.4.1.dev65__py3-none-any.whl

localstack/services/cloudformation/engine/v2/change_set_model_describer.py

@@ -6,8 +6,11 @@ from typing import Final, Optional
 import localstack.aws.api.cloudformation as cfn_api
 from localstack.services.cloudformation.engine.v2.change_set_model import (
     NodeIntrinsicFunction,
+    NodeProperty,
     NodeResource,
+    Nothing,
     PropertiesKey,
+    is_nothing,
 )
 from localstack.services.cloudformation.engine.v2.change_set_model_preproc import (
     ChangeSetModelPreproc,
@@ -45,26 +48,36 @@ class ChangeSetModelDescriber(ChangeSetModelPreproc):
         #  artificially limit the precision of our output to match AWS's?
 
         arguments_delta = self.visit(node_intrinsic_function.arguments)
-        before_argument_list = arguments_delta.before
-        after_argument_list = arguments_delta.after
-
-        before = None
-        if before_argument_list:
-            before_logical_name_of_resource = before_argument_list[0]
-            before_attribute_name = before_argument_list[1]
+        before_argument: Optional[list[str]] = arguments_delta.before
+        if isinstance(before_argument, str):
+            before_argument = before_argument.split(".")
+        after_argument: Optional[list[str]] = arguments_delta.after
+        if isinstance(after_argument, str):
+            after_argument = after_argument.split(".")
+
+        before = Nothing
+        if not is_nothing(before_argument):
+            before_logical_name_of_resource = before_argument[0]
+            before_attribute_name = before_argument[1]
             before_node_resource = self._get_node_resource_for(
                 resource_name=before_logical_name_of_resource, node_template=self._node_template
             )
-            before_node_property = self._get_node_property_for(
+            before_node_property: Optional[NodeProperty] = self._get_node_property_for(
                 property_name=before_attribute_name, node_resource=before_node_resource
             )
-            before_property_delta = self.visit(before_node_property)
-            before = before_property_delta.before
+            if before_node_property is not None:
+                before_property_delta = self.visit(before_node_property)
+                before = before_property_delta.before
+            else:
+                before = self._before_deployed_property_value_of(
+                    resource_logical_id=before_logical_name_of_resource,
+                    property_name=before_attribute_name,
+                )
 
-        after = None
-        if after_argument_list:
-            after_logical_name_of_resource = after_argument_list[0]
-            after_attribute_name = after_argument_list[1]
+        after = Nothing
+        if not is_nothing(after_argument):
+            after_logical_name_of_resource = after_argument[0]
+            after_attribute_name = after_argument[1]
             after_node_resource = self._get_node_resource_for(
                 resource_name=after_logical_name_of_resource, node_template=self._node_template
             )
@@ -74,12 +87,18 @@ class ChangeSetModelDescriber(ChangeSetModelPreproc):
             )
             if after_node_property is not None:
                 after_property_delta = self.visit(after_node_property)
+                if after_property_delta.before == after_property_delta.after:
+                    after = after_property_delta.after
+                else:
+                    after = CHANGESET_KNOWN_AFTER_APPLY
             else:
-                after_property_delta = PreprocEntityDelta(after=CHANGESET_KNOWN_AFTER_APPLY)
-            if after_property_delta.before == after_property_delta.after:
-                after = after_property_delta.after
-            else:
-                after = CHANGESET_KNOWN_AFTER_APPLY
+                try:
+                    after = self._after_deployed_property_value_of(
+                        resource_logical_id=after_logical_name_of_resource,
+                        property_name=after_attribute_name,
+                    )
+                except RuntimeError:
+                    after = CHANGESET_KNOWN_AFTER_APPLY
 
         return PreprocEntityDelta(before=before, after=after)
 
@@ -137,7 +156,7 @@ class ChangeSetModelDescriber(ChangeSetModelPreproc):
         if before == after:
             # unchanged: nothing to do.
             return
-        if before is not None and after is not None:
+        if not is_nothing(before) and not is_nothing(after):
             # Case: change on same type.
             if before.resource_type == after.resource_type:
                 # Register a Modified if changed.
@@ -167,7 +186,7 @@ class ChangeSetModelDescriber(ChangeSetModelPreproc):
                     before_properties=None,
                     after_properties=after.properties,
                 )
-        elif before is not None:
+        elif not is_nothing(before):
             # Case: removal
             self._register_resource_change(
                 logical_id=name,
@@ -176,7 +195,7 @@ class ChangeSetModelDescriber(ChangeSetModelPreproc):
                 before_properties=before.properties,
                 after_properties=None,
             )
-        elif after is not None:
+        elif not is_nothing(after):
             # Case: addition
             self._register_resource_change(
                 logical_id=name,

localstack/services/cloudformation/engine/v2/change_set_model_executor.py

@@ -11,6 +11,7 @@ from localstack.services.cloudformation.engine.v2.change_set_model import (
     NodeOutput,
     NodeParameter,
     NodeResource,
+    is_nothing,
 )
 from localstack.services.cloudformation.engine.v2.change_set_model_preproc import (
     ChangeSetModelPreproc,
@@ -103,42 +104,46 @@ class ChangeSetModelExecutor(ChangeSetModelPreproc):
         `after` delta with the physical resource ID, if side effects resulted in an update.
         """
         delta = super().visit_node_resource(node_resource=node_resource)
-        self._execute_on_resource_change(
-            name=node_resource.name, before=delta.before, after=delta.after
-        )
-        after_resource = delta.after
-        if after_resource is not None and delta.before != delta.after:
-            after_logical_id = after_resource.logical_id
-            after_physical_id: Optional[str] = self._after_resource_physical_id(
+        before = delta.before
+        after = delta.after
+
+        if before != after:
+            # There are changes for this resource.
+            self._execute_resource_change(name=node_resource.name, before=before, after=after)
+        else:
+            # There are no updates for this resource; iff the resource was previously
+            # deployed, then the resolved details are copied in the current state for
+            # references or other downstream operations.
+            if not is_nothing(before):
+                before_logical_id = delta.before.logical_id
+                before_resource = self._before_resolved_resources.get(before_logical_id, dict())
+                self.resources[before_logical_id] = before_resource
+
+        # Update the latest version of this resource for downstream references.
+        if not is_nothing(after):
+            after_logical_id = after.logical_id
+            after_physical_id: str = self._after_resource_physical_id(
                 resource_logical_id=after_logical_id
             )
-            if after_physical_id is None:
-                raise RuntimeError(
-                    f"No PhysicalResourceId was found for resource '{after_physical_id}' post-update."
-                )
-            after_resource.physical_resource_id = after_physical_id
+            after.physical_resource_id = after_physical_id
         return delta
 
     def visit_node_output(
         self, node_output: NodeOutput
     ) -> PreprocEntityDelta[PreprocOutput, PreprocOutput]:
         delta = super().visit_node_output(node_output=node_output)
-        if delta.after is None:
-            # handling deletion so the output does not really matter
-            # TODO: are there other situations?
+        after = delta.after
+        if is_nothing(after) or (isinstance(after, PreprocOutput) and after.condition is False):
             return delta
-
         self.outputs[delta.after.name] = delta.after.value
         return delta
 
-    def _execute_on_resource_change(
+    def _execute_resource_change(
         self, name: str, before: Optional[PreprocResource], after: Optional[PreprocResource]
     ) -> None:
-        if before == after:
-            # unchanged: nothing to do.
-            return
+        # Changes are to be made about this resource.
         # TODO: this logic is a POC and should be revised.
-        if before is not None and after is not None:
+        if not is_nothing(before) and not is_nothing(after):
             # Case: change on same type.
             if before.resource_type == after.resource_type:
                 # Register a Modified if changed.
@@ -173,7 +178,7 @@ class ChangeSetModelExecutor(ChangeSetModelPreproc):
                     before_properties=None,
                     after_properties=after.properties,
                 )
-        elif before is not None:
+        elif not is_nothing(before):
             # Case: removal
             # XXX hacky, stick the previous resources' properties into the payload
             # XXX hacky, stick the previous resources' properties into the payload
@@ -186,7 +191,7 @@ class ChangeSetModelExecutor(ChangeSetModelPreproc):
                 before_properties=before_properties,
                 after_properties=None,
             )
-        elif after is not None:
+        elif not is_nothing(after):
             # Case: addition
             self._execute_resource_action(
                 action=ChangeAction.Add,
@@ -257,11 +262,34 @@ class ChangeSetModelExecutor(ChangeSetModelPreproc):
             case OperationStatus.SUCCESS:
                 # merge the resources state with the external state
                 # TODO: this is likely a duplicate of updating from extra_resource_properties
+
+                # TODO: add typing
+                # TODO: avoid the use of string literals for sampling from the object, use typed classes instead
+                # TODO: avoid sampling from resources and use tmp var reference
+                # TODO: add utils functions to abstract this logic away (resource.update(..))
+                # TODO: avoid the use of setdefault (debuggability/readability)
+                # TODO: review the use of merge
+
                 self.resources[logical_resource_id]["Properties"].update(event.resource_model)
                 self.resources[logical_resource_id].update(extra_resource_properties)
                 # XXX for legacy delete_stack compatibility
                 self.resources[logical_resource_id]["LogicalResourceId"] = logical_resource_id
                 self.resources[logical_resource_id]["Type"] = resource_type
+
+                # TODO: review why the physical id is returned as None during updates
+                # TODO: abstract this in member function of resource classes instead
+                physical_resource_id = None
+                try:
+                    physical_resource_id = self._after_resource_physical_id(logical_resource_id)
+                except RuntimeError:
+                    # The physical id is missing or is set to None, which is invalid.
+                    pass
+                if physical_resource_id is None:
+                    # The physical resource id is None after an update that didn't rewrite the resource, the previous
+                    # resource id is therefore the current physical id of this resource.
+                    physical_resource_id = self._before_resource_physical_id(logical_resource_id)
+                    self.resources[logical_resource_id]["PhysicalResourceId"] = physical_resource_id
+
             case OperationStatus.FAILED:
                 reason = event.message
                 LOG.warning(