localstack-core 4.3.1.dev35__py3-none-any.whl → 4.3.1.dev37__py3-none-any.whl

localstack/config.py

@@ -1089,11 +1089,6 @@ LAMBDA_EVENT_SOURCE_MAPPING_MAX_BACKOFF_ON_EMPTY_POLL_SEC = float(
     os.environ.get("LAMBDA_EVENT_SOURCE_MAPPING_MAX_BACKOFF_ON_EMPTY_POLL_SEC") or 10
 )
 
-# Adding Stepfunctions default port
-LOCAL_PORT_STEPFUNCTIONS = int(os.environ.get("LOCAL_PORT_STEPFUNCTIONS") or 8083)
-# Stepfunctions lambda endpoint override
-STEPFUNCTIONS_LAMBDA_ENDPOINT = os.environ.get("STEPFUNCTIONS_LAMBDA_ENDPOINT", "").strip()
-
 # path prefix for windows volume mounting
 WINDOWS_DOCKER_MOUNT_PREFIX = os.environ.get("WINDOWS_DOCKER_MOUNT_PREFIX", "/host_mnt")
 
@@ -1364,7 +1359,6 @@ CONFIG_ENV_VARS = [
     "SQS_ENDPOINT_STRATEGY",
     "SQS_DISABLE_CLOUDWATCH_METRICS",
     "SQS_CLOUDWATCH_METRICS_REPORT_INTERVAL",
-    "STEPFUNCTIONS_LAMBDA_ENDPOINT",
     "STRICT_SERVICE_LOADING",
     "TF_COMPAT_MODE",
     "USE_SSL",

localstack/deprecations.py

@@ -311,6 +311,20 @@ DEPRECATIONS = [
         " is faster, achieves great AWS parity, and fixes compatibility issues with the StepFunctions JSONata feature."
         " Please remove EVENT_RULE_ENGINE.",
     ),
+    EnvVarDeprecation(
+        "STEPFUNCTIONS_LAMBDA_ENDPOINT",
+        "4.0.0",
+        "This is only supported for the legacy provider. URL to use as the Lambda service endpoint in Step Functions. "
+        "By default this is the LocalStack Lambda endpoint. Use default to select the original AWS Lambda endpoint.",
+    ),
+    EnvVarDeprecation(
+        "LOCAL_PORT_STEPFUNCTIONS",
+        "4.0.0",
+        "This is only supported for the legacy provider."
+        "It defines the local port to which Step Functions traffic is redirected."
+        "By default, LocalStack routes Step Functions traffic to its internal runtime. "
+        "Use this variable only if you need to redirect traffic to a different local Step Functions runtime.",
+    ),
 ]
 
 

localstack/services/cloudformation/engine/entities.py

@@ -422,12 +422,17 @@ class StackChangeSet(Stack):
         return result
 
     # V2 only
-    def populate_update_graph(self, before_template: dict | None, after_template: dict | None):
+    def populate_update_graph(
+        self,
+        before_template: Optional[dict],
+        after_template: Optional[dict],
+        before_parameters: Optional[dict],
+        after_parameters: Optional[dict],
+    ) -> None:
         change_set_model = ChangeSetModel(
             before_template=before_template,
             after_template=after_template,
-            # TODO
-            before_parameters=None,
-            after_parameters=None,
+            before_parameters=before_parameters,
+            after_parameters=after_parameters,
         )
         self.update_graph = change_set_model.get_update_model()

localstack/services/cloudformation/engine/v2/change_set_model.py

@@ -7,7 +7,6 @@ from typing import Any, Final, Generator, Optional, Union, cast
 
 from typing_extensions import TypeVar
 
-from localstack.aws.api.cloudformation import ChangeAction
 from localstack.utils.strings import camel_to_snake_case
 
 T = TypeVar("T")
@@ -67,15 +66,6 @@ class ChangeType(enum.Enum):
     def __str__(self):
         return self.value
 
-    def to_action(self) -> ChangeAction | None:
-        match self:
-            case self.CREATED:
-                return ChangeAction.Add
-            case self.MODIFIED:
-                return ChangeAction.Modify
-            case self.REMOVED:
-                return ChangeAction.Remove
-
     def for_child(self, child_change_type: ChangeType) -> ChangeType:
         if child_change_type == self:
             return self
@@ -525,7 +515,7 @@ class ChangeSetModel:
 
         node_parameter = self._retrieve_parameter_if_exists(parameter_name=logical_id)
         if isinstance(node_parameter, NodeParameter):
-            return node_parameter.dynamic_value.change_type
+            return node_parameter.change_type
 
         # TODO: this should check the replacement flag for a resource update.
         node_resource = self._retrieve_or_visit_resource(resource_name=logical_id)
@@ -584,19 +574,16 @@ class ChangeSetModel:
     def _visit_array(
         self, scope: Scope, before_array: Maybe[list], after_array: Maybe[list]
     ) -> NodeArray:
-        change_type = ChangeType.UNCHANGED
         array: list[ChangeSetEntity] = list()
         for index, (before_value, after_value) in enumerate(
             zip_longest(before_array, after_array, fillvalue=Nothing)
         ):
-            # TODO: should extract this scoping logic.
             value_scope = scope.open_index(index=index)
             value = self._visit_value(
                 scope=value_scope, before_value=before_value, after_value=after_value
             )
             array.append(value)
-            if value.change_type != ChangeType.UNCHANGED:
-                change_type = ChangeType.MODIFIED
+        change_type = self._change_type_for_parent_of([value.change_type for value in array])
         return NodeArray(scope=scope, change_type=change_type, array=array)
 
     def _visit_object(
@@ -695,28 +682,12 @@ class ChangeSetModel:
         node_property = self._visited_scopes.get(scope)
         if isinstance(node_property, NodeProperty):
             return node_property
-
         value = self._visit_value(
             scope=scope, before_value=before_property, after_value=after_property
         )
-        if self._is_created(before=before_property, after=after_property):
-            node_property = NodeProperty(
-                scope=scope,
-                change_type=ChangeType.CREATED,
-                name=property_name,
-                value=value,
-            )
-        elif self._is_removed(before=before_property, after=after_property):
-            node_property = NodeProperty(
-                scope=scope,
-                change_type=ChangeType.REMOVED,
-                name=property_name,
-                value=value,
-            )
-        else:
-            node_property = NodeProperty(
-                scope=scope, change_type=value.change_type, name=property_name, value=value
-            )
+        node_property = NodeProperty(
+            scope=scope, change_type=value.change_type, name=property_name, value=value
+        )
         self._visited_scopes[scope] = node_property
         return node_property
 
@@ -748,6 +719,13 @@ class ChangeSetModel:
         self._visited_scopes[scope] = node_properties
         return node_properties
 
+    def _visit_type(self, scope: Scope, before_type: Any, after_type: Any) -> TerminalValue:
+        value = self._visit_value(scope=scope, before_value=before_type, after_value=after_type)
+        if not isinstance(value, TerminalValue):
+            # TODO: decide where template schema validation should occur.
+            raise RuntimeError()
+        return value
+
     def _visit_resource(
         self,
         scope: Scope,
@@ -766,8 +744,12 @@ class ChangeSetModel:
         else:
             change_type = ChangeType.UNCHANGED
 
-        # TODO: investigate behaviour with type changes, for now this is filler code.
-        _, type_str = self._safe_access_in(scope, TypeKey, after_resource)
+        scope_type, (before_type, after_type) = self._safe_access_in(
+            scope, TypeKey, before_resource, after_resource
+        )
+        terminal_value_type = self._visit_type(
+            scope=scope_type, before_type=before_type, after_type=after_type
+        )
 
         condition_reference = None
         scope_condition, (before_condition, after_condition) = self._safe_access_in(
@@ -792,7 +774,7 @@ class ChangeSetModel:
             scope=scope,
             change_type=change_type,
             name=resource_name,
-            type_=TerminalValueUnchanged(scope=scope, value=type_str),
+            type_=terminal_value_type,
             condition_reference=condition_reference,
             properties=properties,
         )
@@ -872,36 +854,19 @@ class ChangeSetModel:
             return node_parameter
         # TODO: add logic to compute defaults already in the graph building process?
         dynamic_value = self._visit_dynamic_parameter(parameter_name=parameter_name)
-        if self._is_created(before=before_parameter, after=after_parameter):
-            node_parameter = NodeParameter(
-                scope=scope,
-                change_type=ChangeType.CREATED,
-                name=parameter_name,
-                value=TerminalValueCreated(scope=scope, value=after_parameter),
-                dynamic_value=dynamic_value,
-            )
-        elif self._is_removed(before=before_parameter, after=after_parameter):
-            node_parameter = NodeParameter(
-                scope=scope,
-                change_type=ChangeType.REMOVED,
-                name=parameter_name,
-                value=TerminalValueRemoved(scope=scope, value=before_parameter),
-                dynamic_value=dynamic_value,
-            )
-        else:
-            value = self._visit_value(
-                scope=scope, before_value=before_parameter, after_value=after_parameter
-            )
-            change_type = self._change_type_for_parent_of(
-                change_types=[dynamic_value.change_type, value.change_type]
-            )
-            node_parameter = NodeParameter(
-                scope=scope,
-                change_type=change_type,
-                name=parameter_name,
-                value=value,
-                dynamic_value=dynamic_value,
-            )
+        value = self._visit_value(
+            scope=scope, before_value=before_parameter, after_value=after_parameter
+        )
+        change_type = self._change_type_for_parent_of(
+            change_types=[dynamic_value.change_type, value.change_type]
+        )
+        node_parameter = NodeParameter(
+            scope=scope,
+            change_type=change_type,
+            name=parameter_name,
+            value=value,
+            dynamic_value=dynamic_value,
+        )
         self._visited_scopes[scope] = node_parameter
         return node_parameter