lifx-async 4.3.5__py3-none-any.whl → 4.3.6__py3-none-any.whl

lifx/network/connection.py

@@ -22,7 +22,6 @@ from lifx.exceptions import (
     LifxConnectionError,
     LifxProtocolError,
     LifxTimeoutError,
-    LifxUnsupportedCommandError,
 )
 from lifx.network.message import create_message, parse_message
 from lifx.network.transport import UdpTransport
@@ -443,13 +442,12 @@ class DeviceConnection:
             LifxConnectionError: If connection is not open
             LifxProtocolError: If response correlation validation fails
             LifxTimeoutError: If no response after all retries
-            LifxUnsupportedCommandError: If device doesn't support command
         """
         if not self._is_open or self._transport is None:
-            raise LifxConnectionError("Connection not open")
+            raise LifxConnectionError("Connection not open")  # pragma: no cover
 
         if timeout is None:
-            timeout = self.timeout
+            timeout = self.timeout  # pragma: no cover
 
         if max_retries is None:
             max_retries = self.max_retries
@@ -597,12 +595,6 @@ class DeviceConnection:
                                 f"got {header.sequence}, max expected {max_expected}"
                             )
 
-                        # Check for StateUnhandled
-                        if header.pkt_type == _STATE_UNHANDLED_PKT_TYPE:
-                            raise LifxUnsupportedCommandError(
-                                "Request unsupported by device: received StateUnhandled"
-                            )
-
                         # Yield response (can be from any retry attempt)
                         has_yielded = True
                         last_response_time = time.monotonic()
@@ -640,7 +632,7 @@ class DeviceConnection:
         request: Any,
         timeout: float | None = None,
         max_retries: int | None = None,
-    ) -> AsyncGenerator[None, None]:
+    ) -> AsyncGenerator[bool, None]:
         """Internal implementation of request_ack_stream with retry logic.
 
         This is an async generator that sends a request requiring acknowledgement
@@ -652,18 +644,17 @@ class DeviceConnection:
             max_retries: Maximum retries
 
         Yields:
-            None (single yield on successful ack)
+            True for successful ACK, False if device returned StateUnhandled
 
         Raises:
             LifxConnectionError: If connection is not open
             LifxTimeoutError: If no ack after all retries
-            LifxUnsupportedCommandError: If device doesn't support command
         """
         if not self._is_open or self._transport is None:
-            raise LifxConnectionError("Connection not open")
+            raise LifxConnectionError("Connection not open")  # pragma: no cover
 
         if timeout is None:
-            timeout = self.timeout
+            timeout = self.timeout  # pragma: no cover
 
         if max_retries is None:
             max_retries = self.max_retries
@@ -729,14 +720,13 @@ class DeviceConnection:
                         f"{Serial.from_protocol(header.target).to_string()})"
                     )
 
-                # Check for StateUnhandled
+                # Check for StateUnhandled - return False to indicate unsupported
                 if header.pkt_type == _STATE_UNHANDLED_PKT_TYPE:
-                    raise LifxUnsupportedCommandError(
-                        "Request unsupported by device: received StateUnhandled"
-                    )
+                    yield False
+                    return
 
                 # ACK received successfully
-                yield
+                yield True
                 return
 
             except TimeoutError as e:
@@ -791,14 +781,14 @@ class DeviceConnection:
             timeout: Request timeout in seconds
 
         Yields:
-            Unpacked response packet instances
-            For SET packets: yields True once (acknowledgement)
+            Unpacked response packet instances (including StateUnhandled if device
+            doesn't support the command)
+            For SET packets: yields True (acknowledgement) or False (StateUnhandled)
 
         Raises:
             LifxTimeoutError: If request times out
             LifxProtocolError: If response invalid
             LifxConnectionError: If connection fails
-            LifxUnsupportedCommandError: If command not supported
 
         Example:
             ```python
@@ -808,11 +798,16 @@ class DeviceConnection:
                 label = state.label  # Already decoded to string
                 break
 
-            # SET request yields True (acknowledgement)
-            async for _ in conn.request_stream(
+            # SET request yields True (acknowledgement) or False (StateUnhandled)
+            async for result in conn.request_stream(
                 packets.Light.SetColor(color=hsbk, duration=1000)
             ):
-                # Acknowledgement received
+                if result:
+                    # Acknowledgement received
+                    pass
+                else:
+                    # Device doesn't support this command
+                    pass
                 break
 
             # Multi-response GET - stream all responses
@@ -875,9 +870,12 @@ class DeviceConnection:
 
         elif packet_kind == "SET":
             # Request acknowledgement
-            async for _ in self._request_ack_stream_impl(packet, timeout=timeout):
+            async for ack_result in self._request_ack_stream_impl(
+                packet, timeout=timeout
+            ):
                 # Log the request/ack cycle
                 request_values = packet.as_dict
+                reply_packet = "Acknowledgement" if ack_result else "StateUnhandled"
                 _LOGGER.debug(
                     {
                         "class": "DeviceConnection",
@@ -887,7 +885,7 @@ class DeviceConnection:
                             "values": request_values,
                         },
                         "reply": {
-                            "packet": "Acknowledgement",
+                            "packet": reply_packet,
                             "values": {},
                         },
                         "serial": self.serial,
@@ -895,7 +893,7 @@ class DeviceConnection:
                     }
                 )
 
-                yield True
+                yield ack_result
                 return
 
         else:
@@ -934,7 +932,7 @@ class DeviceConnection:
                         yield response_packet
                         return
                 else:
-                    raise LifxUnsupportedCommandError(
+                    raise LifxProtocolError(
                         f"Cannot auto-handle packet kind: {packet_kind}"
                     )
             else:
@@ -961,14 +959,14 @@ class DeviceConnection:
             timeout: Request timeout in seconds
 
         Returns:
-            Single unpacked response packet
-            True for SET acknowledgement
+            Single unpacked response packet (including StateUnhandled if device
+            doesn't support the command)
+            For SET packets: True (acknowledgement) or False (StateUnhandled)
 
         Raises:
             LifxTimeoutError: If no response within timeout
             LifxProtocolError: If response invalid
             LifxConnectionError: If connection fails
-            LifxUnsupportedCommandError: If command not supported
 
         Example:
             ```python
@@ -977,10 +975,13 @@ class DeviceConnection:
             color = HSBK.from_protocol(state.color)
             label = state.label  # Already decoded to string
 
-            # SET request returns True
+            # SET request returns True or False
             success = await conn.request(
                 packets.Light.SetColor(color=hsbk, duration=1000)
             )
+            if not success:
+                # Device doesn't support this command (returned StateUnhandled)
+                pass
             ```
         """
         async for response in self.request_stream(packet, timeout):

{lifx_async-4.3.5.dist-info → lifx_async-4.3.6.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: lifx-async
-Version: 4.3.5
+Version: 4.3.6
 Summary: A modern, type-safe, async Python library for controlling LIFX lights
 Author-email: Avi Miller <me@dje.li>
 Maintainer-email: Avi Miller <me@dje.li>

{lifx_async-4.3.5.dist-info → lifx_async-4.3.6.dist-info}/RECORD

@@ -20,7 +20,7 @@ lifx/effects/models.py,sha256=MS5D-cxD0Ar8XhqbqKAc9q2sk38IP1vPkYwd8V7jCr8,2446
 lifx/effects/pulse.py,sha256=t5eyjfFWG1xT-RXKghRqHYJ9CG_50tPu4jsDapJZ2mw,8721
 lifx/effects/state_manager.py,sha256=iDfYowiCN5IJqcR1s-pM0mQEJpe-RDsMcOOSMmtPVDE,8983
 lifx/network/__init__.py,sha256=uSyA8r8qISG7qXUHbX8uk9A2E8rvDADgCcf94QIZ9so,499
-lifx/network/connection.py,sha256=K5zzwYWKBvSBMqcP6a5Fp9JkVIiOLXJSAi1XMT4g-Go,38191
+lifx/network/connection.py,sha256=hM7BxpG4udLCMWV18trbgbV_yjPsX5e_V4boCf8eZYs,38278
 lifx/network/discovery.py,sha256=FoFoZcw3dtJs1daESiZiNXytanKQsMTdF9PjOxEgHM0,23804
 lifx/network/message.py,sha256=jCLC9v0tbBi54g5CaHLFM_nP1Izu8kJmo2tt23HHBbA,2600
 lifx/network/transport.py,sha256=8QS0YV32rdP0EDiPEwuvZXbplRWL08pmjKybd87mkZ0,11070
@@ -40,7 +40,7 @@ lifx/theme/canvas.py,sha256=4h7lgN8iu_OdchObGDgbxTqQLCb-FRKC-M-YCWef_i4,8048
 lifx/theme/generators.py,sha256=L0X6_iApLx6XDboGlYunaVsl6nvUCqMfn23VQmRkyCk,6125
 lifx/theme/library.py,sha256=tKlKZNqJp8lRGDnilWyDm_Qr1vCRGGwuvWVS82anNpQ,21326
 lifx/theme/theme.py,sha256=qMEx_8E41C0Cc6f083XHiAXEglTv4YlXW0UFsG1rQKg,5521
-lifx_async-4.3.5.dist-info/METADATA,sha256=S7yNp4EX1b3pNjZUoGGcF7GX5_YpHgpeh0qhKClN0S4,2609
-lifx_async-4.3.5.dist-info/WHEEL,sha256=qtCwoSJWgHk21S1Kb4ihdzI2rlJ1ZKaIurTj_ngOhyQ,87
-lifx_async-4.3.5.dist-info/licenses/LICENSE,sha256=eBz48GRA3gSiWn3rYZAz2Ewp35snnhV9cSqkVBq7g3k,1832
-lifx_async-4.3.5.dist-info/RECORD,,
+lifx_async-4.3.6.dist-info/METADATA,sha256=ieTQiM2W8wpfpxTTpl2GwBCdV_9BK36iaK695yKnYac,2609
+lifx_async-4.3.6.dist-info/WHEEL,sha256=qtCwoSJWgHk21S1Kb4ihdzI2rlJ1ZKaIurTj_ngOhyQ,87
+lifx_async-4.3.6.dist-info/licenses/LICENSE,sha256=eBz48GRA3gSiWn3rYZAz2Ewp35snnhV9cSqkVBq7g3k,1832
+lifx_async-4.3.6.dist-info/RECORD,,