letta-nightly 0.12.1.dev20251023104211__py3-none-any.whl → 0.13.0.dev20251024223017__py3-none-any.whl

letta/server/rest_api/routers/v1/internal_templates.py

@@ -1,6 +1,6 @@
 from typing import List, Optional
 
-from fastapi import APIRouter, Body, Depends, HTTPException, Query
+from fastapi import APIRouter, Body, Depends, Query
 from pydantic import BaseModel
 
 from letta.schemas.agent import AgentState, InternalTemplateAgentCreate
@@ -21,11 +21,8 @@ async def create_group(
     """
     Create a new multi-agent group with the specified configuration.
     """
-    try:
-        actor = await server.user_manager.get_actor_or_default_async(actor_id=headers.actor_id)
-        return await server.group_manager.create_group_async(group, actor=actor)
-    except Exception as e:
-        raise HTTPException(status_code=500, detail=str(e))
+    actor = await server.user_manager.get_actor_or_default_async(actor_id=headers.actor_id)
+    return await server.group_manager.create_group_async(group, actor=actor)
 
 
 @router.post("/agents", response_model=AgentState, operation_id="create_internal_template_agent")
@@ -37,11 +34,9 @@ async def create_agent(
     """
     Create a new agent with template-related fields.
     """
-    try:
-        actor = await server.user_manager.get_actor_or_default_async(actor_id=headers.actor_id)
-        return await server.agent_manager.create_agent_async(agent, actor=actor)
-    except Exception as e:
-        raise HTTPException(status_code=500, detail=str(e))
+    actor = await server.user_manager.get_actor_or_default_async(actor_id=headers.actor_id)
+    # Default to ignore_invalid_tools=True for template-based agent creation
+    return await server.agent_manager.create_agent_async(agent, actor=actor, ignore_invalid_tools=True)
 
 
 @router.post("/blocks", response_model=Block, operation_id="create_internal_template_block")
@@ -53,12 +48,9 @@ async def create_block(
     """
     Create a new block with template-related fields.
     """
-    try:
-        actor = await server.user_manager.get_actor_or_default_async(actor_id=headers.actor_id)
-        block_obj = Block(**block.model_dump())
-        return await server.block_manager.create_or_update_block_async(block_obj, actor=actor)
-    except Exception as e:
-        raise HTTPException(status_code=500, detail=str(e))
+    actor = await server.user_manager.get_actor_or_default_async(actor_id=headers.actor_id)
+    block_obj = Block(**block.model_dump())
+    return await server.block_manager.create_or_update_block_async(block_obj, actor=actor)
 
 
 @router.post("/blocks/batch", response_model=List[Block], operation_id="create_internal_template_blocks_batch")
@@ -70,16 +62,13 @@ async def create_blocks_batch(
     """
     Create multiple blocks with template-related fields.
     """
-    try:
-        actor = await server.user_manager.get_actor_or_default_async(actor_id=headers.actor_id)
-        created_blocks = []
-        for block in blocks:
-            block_obj = Block(**block.model_dump())
-            created_block = await server.block_manager.create_or_update_block_async(block_obj, actor=actor)
-            created_blocks.append(created_block)
-        return created_blocks
-    except Exception as e:
-        raise HTTPException(status_code=500, detail=str(e))
+    actor = await server.user_manager.get_actor_or_default_async(actor_id=headers.actor_id)
+    created_blocks = []
+    for block in blocks:
+        block_obj = Block(**block.model_dump())
+        created_block = await server.block_manager.create_or_update_block_async(block_obj, actor=actor)
+        created_blocks.append(created_block)
+    return created_blocks
 
 
 class DeploymentEntity(BaseModel):
@@ -122,132 +111,33 @@ async def list_deployment_entities(
     List all entities (blocks, agents, groups) with the specified deployment_id.
     Optionally filter by entity types.
     """
-    try:
-        actor = await server.user_manager.get_actor_or_default_async(actor_id=headers.actor_id)
-
-        entities = []
-
-        # Parse entity_types filter - support both array and comma-separated string
-        allowed_types = {"block", "agent", "group"}
-        if entity_types is None:
-            # If no filter specified, include all types
-            types_to_include = allowed_types
-        else:
-            # Handle comma-separated strings in a single item
-            if len(entity_types) == 1 and "," in entity_types[0]:
-                entity_types = [t.strip() for t in entity_types[0].split(",")]
-
-            # Validate and filter types
-            types_to_include = {t.lower() for t in entity_types if t.lower() in allowed_types}
-            if not types_to_include:
-                types_to_include = allowed_types  # Default to all if invalid types provided
-
-        # Query blocks if requested
-        if "block" in types_to_include:
-            from sqlalchemy import select
-
-            from letta.orm.block import Block as BlockModel
-            from letta.server.db import db_registry
-
-            async with db_registry.async_session() as session:
-                block_query = select(BlockModel).where(
-                    BlockModel.deployment_id == deployment_id, BlockModel.organization_id == actor.organization_id
-                )
-                result = await session.execute(block_query)
-                blocks = result.scalars().all()
-
-                for block in blocks:
-                    entities.append(
-                        DeploymentEntity(
-                            id=block.id,
-                            type="block",
-                            name=getattr(block, "template_name", None) or getattr(block, "label", None),
-                            description=block.description,
-                            entity_id=getattr(block, "entity_id", None),
-                            project_id=getattr(block, "project_id", None),
-                        )
-                    )
-
-        # Query agents if requested
-        if "agent" in types_to_include:
-            from letta.orm.agent import Agent as AgentModel
-
-            async with db_registry.async_session() as session:
-                agent_query = select(AgentModel).where(
-                    AgentModel.deployment_id == deployment_id, AgentModel.organization_id == actor.organization_id
-                )
-                result = await session.execute(agent_query)
-                agents = result.scalars().all()
-
-                for agent in agents:
-                    entities.append(
-                        DeploymentEntity(
-                            id=agent.id,
-                            type="agent",
-                            name=agent.name,
-                            description=agent.description,
-                            entity_id=getattr(agent, "entity_id", None),
-                            project_id=getattr(agent, "project_id", None),
-                        )
-                    )
-
-        # Query groups if requested
-        if "group" in types_to_include:
-            from letta.orm.group import Group as GroupModel
-
-            async with db_registry.async_session() as session:
-                group_query = select(GroupModel).where(
-                    GroupModel.deployment_id == deployment_id, GroupModel.organization_id == actor.organization_id
-                )
-                result = await session.execute(group_query)
-                groups = result.scalars().all()
-
-                for group in groups:
-                    entities.append(
-                        DeploymentEntity(
-                            id=group.id,
-                            type="group",
-                            name=None,  # Groups don't have a name field
-                            description=group.description,
-                            entity_id=getattr(group, "entity_id", None),
-                            project_id=getattr(group, "project_id", None),
-                        )
-                    )
-
-        message = f"Found {len(entities)} entities for deployment {deployment_id}"
-        if entity_types:
-            message += f" (filtered by types: {', '.join(types_to_include)})"
-
-        return ListDeploymentEntitiesResponse(entities=entities, total_count=len(entities), deployment_id=deployment_id, message=message)
-    except Exception as e:
-        raise HTTPException(status_code=500, detail=str(e))
-
-
-@router.delete("/deployment/{deployment_id}", response_model=DeleteDeploymentResponse, operation_id="delete_deployment")
-async def delete_deployment(
-    deployment_id: str,
-    server: "SyncServer" = Depends(get_letta_server),
-    headers: HeaderParams = Depends(get_headers),
-):
-    """
-    Delete all entities (blocks, agents, groups) with the specified deployment_id.
-    Deletion order: blocks -> agents -> groups to maintain referential integrity.
-    """
-    try:
-        actor = await server.user_manager.get_actor_or_default_async(actor_id=headers.actor_id)
-
-        deleted_blocks = []
-        deleted_agents = []
-        deleted_groups = []
-
-        # First delete blocks
+    actor = await server.user_manager.get_actor_or_default_async(actor_id=headers.actor_id)
+
+    entities = []
+
+    # Parse entity_types filter - support both array and comma-separated string
+    allowed_types = {"block", "agent", "group"}
+    if entity_types is None:
+        # If no filter specified, include all types
+        types_to_include = allowed_types
+    else:
+        # Handle comma-separated strings in a single item
+        if len(entity_types) == 1 and "," in entity_types[0]:
+            entity_types = [t.strip() for t in entity_types[0].split(",")]
+
+        # Validate and filter types
+        types_to_include = {t.lower() for t in entity_types if t.lower() in allowed_types}
+        if not types_to_include:
+            types_to_include = allowed_types  # Default to all if invalid types provided
+
+    # Query blocks if requested
+    if "block" in types_to_include:
         from sqlalchemy import select
 
         from letta.orm.block import Block as BlockModel
         from letta.server.db import db_registry
 
         async with db_registry.async_session() as session:
-            # Get all blocks with the deployment_id
             block_query = select(BlockModel).where(
                 BlockModel.deployment_id == deployment_id, BlockModel.organization_id == actor.organization_id
             )
@@ -255,18 +145,22 @@ async def delete_deployment(
             blocks = result.scalars().all()
 
             for block in blocks:
-                try:
-                    await server.block_manager.delete_block_async(block.id, actor)
-                    deleted_blocks.append(block.id)
-                except Exception as e:
-                    # Continue deleting other blocks even if one fails
-                    print(f"Failed to delete block {block.id}: {e}")
-
-        # Then delete agents
+                entities.append(
+                    DeploymentEntity(
+                        id=block.id,
+                        type="block",
+                        name=getattr(block, "template_name", None) or getattr(block, "label", None),
+                        description=block.description,
+                        entity_id=getattr(block, "entity_id", None),
+                        project_id=getattr(block, "project_id", None),
+                    )
+                )
+
+    # Query agents if requested
+    if "agent" in types_to_include:
         from letta.orm.agent import Agent as AgentModel
 
         async with db_registry.async_session() as session:
-            # Get all agents with the deployment_id
             agent_query = select(AgentModel).where(
                 AgentModel.deployment_id == deployment_id, AgentModel.organization_id == actor.organization_id
             )
@@ -274,18 +168,22 @@ async def delete_deployment(
             agents = result.scalars().all()
 
             for agent in agents:
-                try:
-                    await server.agent_manager.delete_agent_async(agent.id, actor)
-                    deleted_agents.append(agent.id)
-                except Exception as e:
-                    # Continue deleting other agents even if one fails
-                    print(f"Failed to delete agent {agent.id}: {e}")
-
-        # Finally delete groups
+                entities.append(
+                    DeploymentEntity(
+                        id=agent.id,
+                        type="agent",
+                        name=agent.name,
+                        description=agent.description,
+                        entity_id=getattr(agent, "entity_id", None),
+                        project_id=getattr(agent, "project_id", None),
+                    )
+                )
+
+    # Query groups if requested
+    if "group" in types_to_include:
         from letta.orm.group import Group as GroupModel
 
         async with db_registry.async_session() as session:
-            # Get all groups with the deployment_id
             group_query = select(GroupModel).where(
                 GroupModel.deployment_id == deployment_id, GroupModel.organization_id == actor.organization_id
             )
@@ -293,18 +191,103 @@ async def delete_deployment(
             groups = result.scalars().all()
 
             for group in groups:
-                try:
-                    await server.group_manager.delete_group_async(group.id, actor)
-                    deleted_groups.append(group.id)
-                except Exception as e:
-                    # Continue deleting other groups even if one fails
-                    print(f"Failed to delete group {group.id}: {e}")
-
-        total_deleted = len(deleted_blocks) + len(deleted_agents) + len(deleted_groups)
-        message = f"Successfully deleted {total_deleted} entities from deployment {deployment_id}"
-
-        return DeleteDeploymentResponse(
-            deleted_blocks=deleted_blocks, deleted_agents=deleted_agents, deleted_groups=deleted_groups, message=message
+                entities.append(
+                    DeploymentEntity(
+                        id=group.id,
+                        type="group",
+                        name=None,  # Groups don't have a name field
+                        description=group.description,
+                        entity_id=getattr(group, "entity_id", None),
+                        project_id=getattr(group, "project_id", None),
+                    )
+                )
+
+    message = f"Found {len(entities)} entities for deployment {deployment_id}"
+    if entity_types:
+        message += f" (filtered by types: {', '.join(types_to_include)})"
+
+    return ListDeploymentEntitiesResponse(entities=entities, total_count=len(entities), deployment_id=deployment_id, message=message)
+
+
+@router.delete("/deployment/{deployment_id}", response_model=DeleteDeploymentResponse, operation_id="delete_deployment")
+async def delete_deployment(
+    deployment_id: str,
+    server: "SyncServer" = Depends(get_letta_server),
+    headers: HeaderParams = Depends(get_headers),
+):
+    """
+    Delete all entities (blocks, agents, groups) with the specified deployment_id.
+    Deletion order: blocks -> agents -> groups to maintain referential integrity.
+    """
+    actor = await server.user_manager.get_actor_or_default_async(actor_id=headers.actor_id)
+
+    deleted_blocks = []
+    deleted_agents = []
+    deleted_groups = []
+
+    # First delete blocks
+    from sqlalchemy import select
+
+    from letta.orm.block import Block as BlockModel
+    from letta.server.db import db_registry
+
+    async with db_registry.async_session() as session:
+        # Get all blocks with the deployment_id
+        block_query = select(BlockModel).where(
+            BlockModel.deployment_id == deployment_id, BlockModel.organization_id == actor.organization_id
+        )
+        result = await session.execute(block_query)
+        blocks = result.scalars().all()
+
+        for block in blocks:
+            try:
+                await server.block_manager.delete_block_async(block.id, actor)
+                deleted_blocks.append(block.id)
+            except Exception as e:
+                # Continue deleting other blocks even if one fails
+                print(f"Failed to delete block {block.id}: {e}")
+
+    # Then delete agents
+    from letta.orm.agent import Agent as AgentModel
+
+    async with db_registry.async_session() as session:
+        # Get all agents with the deployment_id
+        agent_query = select(AgentModel).where(
+            AgentModel.deployment_id == deployment_id, AgentModel.organization_id == actor.organization_id
+        )
+        result = await session.execute(agent_query)
+        agents = result.scalars().all()
+
+        for agent in agents:
+            try:
+                await server.agent_manager.delete_agent_async(agent.id, actor)
+                deleted_agents.append(agent.id)
+            except Exception as e:
+                # Continue deleting other agents even if one fails
+                print(f"Failed to delete agent {agent.id}: {e}")
+
+    # Finally delete groups
+    from letta.orm.group import Group as GroupModel
+
+    async with db_registry.async_session() as session:
+        # Get all groups with the deployment_id
+        group_query = select(GroupModel).where(
+            GroupModel.deployment_id == deployment_id, GroupModel.organization_id == actor.organization_id
         )
-    except Exception as e:
-        raise HTTPException(status_code=500, detail=str(e))
+        result = await session.execute(group_query)
+        groups = result.scalars().all()
+
+        for group in groups:
+            try:
+                await server.group_manager.delete_group_async(group.id, actor)
+                deleted_groups.append(group.id)
+            except Exception as e:
+                # Continue deleting other groups even if one fails
+                print(f"Failed to delete group {group.id}: {e}")
+
+    total_deleted = len(deleted_blocks) + len(deleted_agents) + len(deleted_groups)
+    message = f"Successfully deleted {total_deleted} entities from deployment {deployment_id}"
+
+    return DeleteDeploymentResponse(
+        deleted_blocks=deleted_blocks, deleted_agents=deleted_agents, deleted_groups=deleted_groups, message=message
+    )

letta/server/rest_api/routers/v1/jobs.py

@@ -1,13 +1,14 @@
 from typing import List, Literal, Optional
 
-from fastapi import APIRouter, Depends, HTTPException, Query
+from fastapi import APIRouter, Depends, Query
 
-from letta.orm.errors import NoResultFound
+from letta.errors import LettaInvalidArgumentError
 from letta.schemas.enums import JobStatus
-from letta.schemas.job import Job
+from letta.schemas.job import Job, JobBase
 from letta.server.rest_api.dependencies import HeaderParams, get_headers, get_letta_server
 from letta.server.server import SyncServer
 from letta.settings import settings
+from letta.validators import JobId
 
 router = APIRouter(prefix="/jobs", tags=["jobs"])
 
@@ -88,7 +89,7 @@ async def list_active_jobs(
 
 @router.get("/{job_id}", response_model=Job, operation_id="retrieve_job")
 async def retrieve_job(
-    job_id: str,
+    job_id: JobId,
     headers: HeaderParams = Depends(get_headers),
     server: "SyncServer" = Depends(get_letta_server),
 ):
@@ -96,16 +97,12 @@ async def retrieve_job(
     Get the status of a job.
     """
     actor = await server.user_manager.get_actor_or_default_async(actor_id=headers.actor_id)
-
-    try:
-        return await server.job_manager.get_job_by_id_async(job_id=job_id, actor=actor)
-    except NoResultFound:
-        raise HTTPException(status_code=404, detail="Job not found")
+    return await server.job_manager.get_job_by_id_async(job_id=job_id, actor=actor)
 
 
 @router.patch("/{job_id}/cancel", response_model=Job, operation_id="cancel_job")
 async def cancel_job(
-    job_id: str,
+    job_id: JobId,
     headers: HeaderParams = Depends(get_headers),
     server: "SyncServer" = Depends(get_letta_server),
 ):
@@ -117,24 +114,20 @@ async def cancel_job(
     """
     actor = await server.user_manager.get_actor_or_default_async(actor_id=headers.actor_id)
     if not settings.track_agent_run:
-        raise HTTPException(status_code=400, detail="Agent run tracking is disabled")
-
-    try:
-        # First check if the job exists and is in a cancellable state
-        existing_job = await server.job_manager.get_job_by_id_async(job_id=job_id, actor=actor)
+        raise LettaInvalidArgumentError("Agent run tracking is disabled")
 
-        if existing_job.status.is_terminal:
-            return False
+    # First check if the job exists and is in a cancellable state
+    existing_job = await server.job_manager.get_job_by_id_async(job_id=job_id, actor=actor)
 
-        return await server.job_manager.safe_update_job_status_async(job_id=job_id, new_status=JobStatus.cancelled, actor=actor)
+    if existing_job.status.is_terminal:
+        return False
 
-    except NoResultFound:
-        raise HTTPException(status_code=404, detail="Job not found")
+    return await server.job_manager.safe_update_job_status_async(job_id=job_id, new_status=JobStatus.cancelled, actor=actor)
 
 
 @router.delete("/{job_id}", response_model=Job, operation_id="delete_job")
 async def delete_job(
-    job_id: str,
+    job_id: JobId,
     headers: HeaderParams = Depends(get_headers),
     server: "SyncServer" = Depends(get_letta_server),
 ):
@@ -142,9 +135,4 @@ async def delete_job(
     Delete a job by its job_id.
     """
     actor = await server.user_manager.get_actor_or_default_async(actor_id=headers.actor_id)
-
-    try:
-        job = await server.job_manager.delete_job_by_id_async(job_id=job_id, actor=actor)
-        return job
-    except NoResultFound:
-        raise HTTPException(status_code=404, detail="Job not found")
+    return await server.job_manager.delete_job_by_id_async(job_id=job_id, actor=actor)