learning-loop-node 0.9.2__py3-none-any.whl → 0.10.0__py3-none-any.whl

learning_loop_node/trainer/trainer_logic.py

@@ -3,405 +3,91 @@ import json
 import logging
 import os
 import shutil
-import time
 from abc import abstractmethod
-from dataclasses import asdict
 from datetime import datetime
-from glob import glob
-from time import perf_counter
-from typing import TYPE_CHECKING, Coroutine, Dict, List, Optional, Union
-from uuid import UUID, uuid4
+from typing import Coroutine, List, Optional
 
-import socketio
 from dacite import from_dict
-from fastapi.encoders import jsonable_encoder
-from tqdm import tqdm
-
-from ..data_classes import (BasicModel, Category, Context, Detections, Errors, Hyperparameter, ModelInformation,
-                            PretrainedModel, Training, TrainingData, TrainingError, TrainingState)
-from ..helpers.misc import create_image_folder
-from ..node import Node
-from . import training_syncronizer
-from .downloader import TrainingsDownloader
-from .executor import Executor
-from .io_helpers import ActiveTrainingIO
-
-if TYPE_CHECKING:
-    from .trainer_node import TrainerNode
 
-
-def is_valid_uuid4(val):
-    try:
-        _ = UUID(str(val)).version
-        return True
-    except ValueError:
-        return False
+from ..data_classes import Detections, ModelInformation, TrainerState, TrainingError
+from ..helpers.misc import create_image_folder, create_project_folder, images_for_ids, is_valid_uuid4
+from .executor import Executor
+from .trainer_logic_generic import TrainerLogicGeneric
 
 
-class TrainerLogic():
+class TrainerLogic(TrainerLogicGeneric):
 
     def __init__(self, model_format: str) -> None:
-        self.model_format: str = model_format
+        """This class is the base class for all trainers that use an executor to run training processes.
+        The executor is used to run the training process in a separate process."""
+
+        super().__init__(model_format)
+        self._detection_progress: Optional[float] = None
         self._executor: Optional[Executor] = None
-        self.start_time: Optional[float] = None
-        self.training_task: Optional[asyncio.Task] = None
         self.start_training_task: Optional[Coroutine] = None
-        self.errors = Errors()
-        self.shutdown_event: asyncio.Event = asyncio.Event()
-        self.detection_progress = 0.0
-
-        self._training: Optional[Training] = None
-        self._active_training_io: Optional[ActiveTrainingIO] = None
-        self._node: Optional[TrainerNode] = None
-        self.restart_after_training = os.environ.get('RESTART_AFTER_TRAINING', 'FALSE').lower() in ['true', '1']
-        self.keep_old_trainings = os.environ.get('KEEP_OLD_TRAININGS', 'FALSE').lower() in ['true', '1']
-        self.inference_batch_size = int(os.environ.get('INFERENCE_BATCH_SIZE', '10'))
-        logging.info(f'INFERENCE_BATCH_SIZE: {self.inference_batch_size}')
+        self.inference_batch_size = 10
 
-    @property
-    def executor(self) -> Executor:
-        assert self._executor is not None, 'executor must be set, call `run_training` first'
-        return self._executor
-
-    @property
-    def training(self) -> Training:
-        assert self._training is not None, 'training must be set, call `init` first'
-        return self._training
+    # ---------------------------------------- IMPLEMENTED ABSTRACT PROPERTIES ----------------------------------------
 
     @property
-    def active_training_io(self) -> ActiveTrainingIO:
-        assert self._active_training_io is not None, 'active_training_io must be set, call `init` first'
-        return self._active_training_io
+    def detection_progress(self) -> Optional[float]:
+        return self._detection_progress
 
-    @property
-    def node(self) -> 'TrainerNode':
-        assert self._node is not None, 'node should be set by TrainerNodes before initialization'
-        return self._node
+    # ---------------------------------------- PROPERTIES ----------------------------------------
 
     @property
-    def is_initialized(self) -> bool:
-        """_training and _active_training_io are set in 'init_new_training' or 'init_from_last_training'"""
-        return self._training is not None and self._active_training_io is not None and self._node is not None
-
-    def init_new_training(self, context: Context, details: Dict) -> None:
-        """Called on `begin_training` event from the Learning Loop.
-        Note that details needs the entries 'categories' and 'training_number'"""
+    def executor(self) -> Executor:
+        assert self._executor is not None, 'executor must be set, call `run_training` first'
+        return self._executor
 
-        try:
-            project_folder = Node.create_project_folder(context)
-            if not self.keep_old_trainings:
-                # NOTE: We delete all existing training folders because they are not needed anymore.
-                TrainerLogic.delete_all_training_folders(project_folder)
-            self._training = TrainerLogic.generate_training(project_folder, context)
-            self._training.data = TrainingData(categories=Category.from_list(details['categories']))
-            self._training.data.hyperparameter = from_dict(data_class=Hyperparameter, data=details)
-            self._training.training_number = details['training_number']
-            self._training.base_model_id = details['id']
-            self._training.training_state = TrainingState.Initialized
-            self._active_training_io = ActiveTrainingIO(self._training.training_folder)
-            logging.info(f'init training: {self._training}')
-        except Exception:
-            logging.exception('Error in init')
-
-    def init_from_last_training(self) -> None:
-        self._training = self.node.last_training_io.load()
-        assert self._training is not None and self._training.training_folder is not None, 'could not restore training folder'
-        self._active_training_io = ActiveTrainingIO(self._training.training_folder)
-
-    async def run(self) -> None:
-        """Called on `begin_training` event from the Learning Loop."""
-
-        self.start_time = time.time()
-        self.errors.reset_all()
-        try:
-            self.training_task = asyncio.get_running_loop().create_task(self._run())
-            await self.training_task  # Object is used to potentially cancel the task
-        except asyncio.CancelledError:
-            if not self.shutdown_event.is_set():
-                logging.info('training task was cancelled but not by shutdown event')
-                self.training.training_state = TrainingState.ReadyForCleanup
-                self.node.last_training_io.save(self.training)
-                await self.clear_training()
-
-        except Exception as e:
-            logging.exception(f'Error in train: {e}')
-        finally:
-            self.start_time = None
-
-    # ---------------------------------------- TRAINING STATES ----------------------------------------
-
-    async def _run(self) -> None:
-        """asyncio.CancelledError is catched in train"""
-
-        if not self.is_initialized:
-            logging.error('could not start training - trainer is not initialized')
-            return
+    # ---------------------------------------- IMPLEMENTED ABSTRACT MEHTODS ----------------------------------------
 
-        while self._training is not None:
-            tstate = self.training.training_state
-            logging.info(f'STATE LOOP: {tstate}')
-            await asyncio.sleep(0.6)  # Note: Required for pytests!
-            if tstate == TrainingState.Initialized:  # -> DataDownloading -> DataDownloaded
-                await self.prepare()
-            elif tstate == TrainingState.DataDownloaded:  # -> TrainModelDownloading -> TrainModelDownloaded
-                await self.download_model()
-            elif tstate == TrainingState.TrainModelDownloaded:  # -> TrainingRunning -> TrainingFinished
-                await self.train()
-            elif tstate == TrainingState.TrainingFinished:  # -> ConfusionMatrixSyncing -> ConfusionMatrixSynced
-                await self.ensure_confusion_matrix_synced()
-            elif tstate == TrainingState.ConfusionMatrixSynced:  # -> TrainModelUploading -> TrainModelUploaded
-                await self.upload_model()
-            elif tstate == TrainingState.TrainModelUploaded:  # -> Detecting -> Detected
-                await self.do_detections()
-            elif tstate == TrainingState.Detected:  # -> DetectionUploading -> ReadyForCleanup
-                await self.upload_detections()
-            elif tstate == TrainingState.ReadyForCleanup:  # -> RESTART or TrainingFinished
-                await self.clear_training()
-                self.may_restart()
-
-    async def prepare(self) -> None:
-        previous_state = self.training.training_state
-        self.training.training_state = TrainingState.DataDownloading
-        error_key = 'prepare'
-        try:
-            await self._prepare()
-        except asyncio.CancelledError:
-            logging.warning('CancelledError in prepare')
-            raise
-        except Exception as e:
-            logging.exception("Unknown error in 'prepare'. Exception:")
-            self.training.training_state = previous_state
-            self.errors.set(error_key, str(e))
-        else:
-            self.errors.reset(error_key)
-            self.training.training_state = TrainingState.DataDownloaded
-            self.node.last_training_io.save(self.training)
-
-    async def _prepare(self) -> None:
-        self.node.data_exchanger.set_context(self.training.context)
-        downloader = TrainingsDownloader(self.node.data_exchanger)
-        image_data, skipped_image_count = await downloader.download_training_data(self.training.images_folder)
-        assert self.training.data is not None, 'training.data must be set'
-        self.training.data.image_data = image_data
-        self.training.data.skipped_image_count = skipped_image_count
-
-    async def download_model(self) -> None:
-        logging.info('Downloading model')
-        previous_state = self.training.training_state
-        self.training.training_state = TrainingState.TrainModelDownloading
-        error_key = 'download_model'
-        try:
-            await self._download_model()
-        except asyncio.CancelledError:
-            logging.warning('CancelledError in download_model')
-            raise
-        except Exception as e:
-            logging.exception('download_model failed')
-            self.training.training_state = previous_state
-            self.errors.set(error_key, str(e))
-        else:
-            self.errors.reset(error_key)
-            logging.info('download_model_task finished')
-            self.training.training_state = TrainingState.TrainModelDownloaded
-            self.node.last_training_io.save(self.training)
-
-    async def _download_model(self) -> None:
-        model_id = self.training.base_model_id
-        assert model_id is not None, 'model_id must be set'
-        if is_valid_uuid4(
-                self.training.base_model_id):  # TODO this checks if we continue a training -> make more explicit
-            logging.info('loading model from Learning Loop')
-            logging.info(f'downloading model {model_id} as {self.model_format}')
-            await self.node.data_exchanger.download_model(self.training.training_folder, self.training.context, model_id, self.model_format)
-            shutil.move(f'{self.training.training_folder}/model.json',
-                        f'{self.training.training_folder}/base_model.json')
-        else:
-            logging.info(f'base_model_id {model_id} is not a valid uuid4, skipping download')
-
-    async def train(self) -> None:
-        logging.info('Running training')
+    async def _train(self) -> None:
+        previous_state = TrainerState.TrainModelDownloaded
         error_key = 'run_training'
-        # NOTE normally we reset errors after the step was successful. We do not want to display an old error during the whole training.
-        self.errors.reset(error_key)
-        previous_state = self.training.training_state
         self._executor = Executor(self.training.training_folder)
-        self.training.training_state = TrainingState.TrainingRunning
+        self.training.training_state = TrainerState.TrainingRunning
+
         try:
             await self._start_training()
-
             last_sync_time = datetime.now()
+
             while True:
-                if not self.executor.is_process_running():
+                await asyncio.sleep(0.1)
+                if not self.executor.is_running():
                     break
                 if (datetime.now() - last_sync_time).total_seconds() > 5:
                     last_sync_time = datetime.now()
-                    if self.get_executor_error_from_log():
+                    if self._get_executor_error_from_log():
                         break
                     self.errors.reset(error_key)
                     try:
-                        await self.sync_confusion_matrix()
+                        await self._sync_confusion_matrix()
                     except asyncio.CancelledError:
                         logging.warning('CancelledError in run_training')
                         raise
                     except Exception:
-                        pass
-                else:
-                    await asyncio.sleep(0.1)
+                        logging.error('Error in sync_confusion_matrix (this error is ignored)')
 
-            error = self.get_executor_error_from_log()
-            if error:
-                self.errors.set(error_key, error)
+            if error := self._get_executor_error_from_log():
                 raise TrainingError(cause=error)
-            # TODO check if this works:
+
+            # NOTE: This is problematic, because the return code is not 0 when executor was stoppen e.g. via self.stop()
             # if self.executor.return_code != 0:
-            #     self.errors.set(error_key, f'Executor return code was {self.executor.return_code}')
-            #     raise TrainingError(cause=f'Executor return code was {self.executor.return_code}')
+            #     raise TrainingError(cause=f'Executor returned with error code: {self.executor.return_code}')
 
-        except asyncio.CancelledError:
-            logging.warning('CancelledError in run_training')
-            raise
         except TrainingError:
-            logging.exception('Error in TrainingProcess')
-            if self.executor.is_process_running():
-                self.executor.stop()
-            self.training.training_state = previous_state
-        except Exception as e:
-            self.errors.set(error_key, f'Could not start training {str(e)}')
+            logging.exception('Exception in trainer_logic._train')
+            await self.executor.stop_and_wait()
             self.training.training_state = previous_state
-            logging.exception('Error in run_training')
-        else:
-            self.training.training_state = TrainingState.TrainingFinished
-            self.node.last_training_io.save(self.training)
-
-    async def _start_training(self):
-        self.start_training_task = None  # NOTE: this is used i.e. by tests
-        if self.can_resume():
-            self.start_training_task = self.resume()
-        else:
-            base_model_id = self.training.base_model_id
-            if not is_valid_uuid4(base_model_id):  # TODO this check was done earlier!
-                assert isinstance(base_model_id, str)
-                # TODO this could be removed here and accessed via self.training.base_model_id
-                self.start_training_task = self.start_training_from_scratch(base_model_id)
-            else:
-                self.start_training_task = self.start_training()
-        await self.start_training_task
-
-    async def ensure_confusion_matrix_synced(self):
-        logging.info('Ensure syncing confusion matrix')
-        previous_state = self.training.training_state
-        self.training.training_state = TrainingState.ConfusionMatrixSyncing
-        try:
-            await self.sync_confusion_matrix()
-        except asyncio.CancelledError:
-            logging.warning('CancelledError in run_training')
-            raise
-        except Exception:
-            logging.exception('Error in ensure_confusion_matrix_synced')
-            self.training.training_state = previous_state
-        else:
-            self.training.training_state = TrainingState.ConfusionMatrixSynced
-            self.node.last_training_io.save(self.training)
-
-    async def sync_confusion_matrix(self):
-        logging.info('Syncing confusion matrix')
-        error_key = 'sync_confusion_matrix'
-        try:
-            await training_syncronizer.try_sync_model(self, self.node.uuid, self.node.sio_client)
-        except socketio.exceptions.BadNamespaceError as e:  # type: ignore
-            logging.error('Error during confusion matrix syncronization. BadNamespaceError')
-            self.errors.set(error_key, str(e))
-            raise
-        except Exception as e:
-            logging.exception('Error during confusion matrix syncronization')
-            self.errors.set(error_key, str(e))
-            raise
-
-        self.errors.reset(error_key)
-
-    async def upload_model(self) -> None:
-        error_key = 'upload_model'
-        previous_state = self.training.training_state
-        self.training.training_state = TrainingState.TrainModelUploading
-        try:
-            new_model_id = await self._upload_model_return_new_id(self.training.context)
-            if new_model_id is None:
-                self.training.training_state = TrainingState.ReadyForCleanup
-                logging.error('could not upload model - maybe training failed.. cleaning up')
-                return
-            assert new_model_id is not None, 'uploaded_model must be set'
-            logging.info(f'successfully uploaded model and received new model id: {new_model_id}')
-            self.training.model_id_for_detecting = new_model_id
-        except asyncio.CancelledError:
-            logging.warning('CancelledError in upload_model')
             raise
-        except Exception as e:
-            logging.exception('Error in upload_model. Exception:')
-            self.errors.set(error_key, str(e))
-            self.training.training_state = previous_state  # TODO... going back is pointless here as it ends in a deadlock ?!
-            # self.training.training_state = TrainingState.ReadyForCleanup
-        else:
-            self.errors.reset(error_key)
-            self.training.training_state = TrainingState.TrainModelUploaded
-            self.node.last_training_io.save(self.training)
-
-    async def _upload_model_return_new_id(self, context: Context) -> Optional[str]:
-        """Upload model files, usually pytorch model (.pt) hyp.yaml and the converted .wts file.
-        Note that with the latest trainers the conversion to (.wts) is done by the trainer.
-        The conversion from .wts to .engine is done by the detector (needs to be done on target hardware).
-        Note that trainer may train with different classes, which is why we send an initial model.json file.
-        """
-        files = await asyncio.get_running_loop().run_in_executor(None, self.get_latest_model_files)
-
-        if files is None:
-            return None
-
-        if isinstance(files, List):
-            files = {self.model_format: files}
-        assert isinstance(files, Dict), f'can only save model as list or dict, but was {files}'
-
-        model_json_path = self.create_model_json_with_categories()
-        already_uploaded_formats = self.active_training_io.load_model_upload_progress()
-
-        new_id = None
-        for file_format in files:
-            if file_format in already_uploaded_formats:
-                continue
-            _files = files[file_format]
-            # model.json was mandatory in previous versions. Now its forbidden to provide an own model.json file.
-            assert not any(f for f in _files if 'model.json' in f), "Upload 'model.json' not allowed (added automatically)."
-            _files.append(model_json_path)
-            new_id = await self.node.data_exchanger.upload_model_for_training(context, _files, self.training.training_number, file_format)
-            if new_id is None:
-                return None
-
-            already_uploaded_formats.append(file_format)
-            self.active_training_io.save_model_upload_progress(already_uploaded_formats)
-
-        return new_id
-
-    async def do_detections(self):
-        error_key = 'detecting'
-        previous_state = self.training.training_state
-        try:
-            self.training.training_state = TrainingState.Detecting
-            await self._do_detections()
-        except asyncio.CancelledError:
-            logging.warning('CancelledError in do_detections')
-            raise
-        except Exception as e:
-            self.errors.set(error_key, str(e))
-            logging.exception('Error in do_detections - Exception:')
-            self.training.training_state = previous_state
-        else:
-            self.errors.reset(error_key)
-            self.training.training_state = TrainingState.Detected
-            self.node.last_training_io.save(self.training)
 
     async def _do_detections(self) -> None:
         context = self.training.context
-        model_id = self.training.model_id_for_detecting
-        assert model_id, 'model_id must be set'
+        model_id = self.training.model_uuid_for_detecting
+        if not model_id:
+            logging.error('model_id is not set! Cannot do detections.')
+            return
         tmp_folder = f'/tmp/model_for_auto_detections_{model_id}_{self.model_format}'
 
         shutil.rmtree(tmp_folder, ignore_errors=True)
@@ -410,111 +96,57 @@ class TrainerLogic():
 
         await self.node.data_exchanger.download_model(tmp_folder, context, model_id, self.model_format)
         with open(f'{tmp_folder}/model.json', 'r') as f:
-            content = json.load(f)
-            model_information = from_dict(data_class=ModelInformation, data=content)
+            model_information = from_dict(data_class=ModelInformation, data=json.load(f))
 
-        project_folder = Node.create_project_folder(context)
+        project_folder = create_project_folder(context)
         image_folder = create_image_folder(project_folder)
         self.node.data_exchanger.set_context(context)
         image_ids = []
         for state, p in zip(['inbox', 'annotate', 'review', 'complete'], [0.1, 0.2, 0.3, 0.4]):
-            self.detection_progress = p
+            self._detection_progress = p
             logging.info(f'fetching image ids of {state}')
-            new_ids = await self.node.data_exchanger.fetch_image_ids(query_params=f'state={state}')
+            new_ids = await self.node.data_exchanger.fetch_image_uuids(query_params=f'state={state}')
             image_ids += new_ids
             logging.info(f'downloading {len(new_ids)} images')
             await self.node.data_exchanger.download_images(new_ids, image_folder)
-        self.detection_progress = 0.42
-        await self.node.data_exchanger.delete_corrupt_images(image_folder)
+        self._detection_progress = 0.42
+        # await delete_corrupt_images(image_folder)
 
-        images = await asyncio.get_event_loop().run_in_executor(None, TrainerLogic.images_for_ids, image_ids, image_folder)
-        num_images = len(images)
-        logging.info(f'running detections on {num_images} images')
-        batch_size = 200
-        idx = 0
+        images = await asyncio.get_event_loop().run_in_executor(None, images_for_ids, image_ids, image_folder)
         if not images:
-            self.active_training_io.save_detections([], idx)
-        for i in tqdm(range(0, num_images, batch_size), position=0, leave=True):
-            self.detection_progress = 0.5 + (i/num_images)*0.5
-            batch_images = images[i:i+batch_size]
+            self.active_training_io.save_detections([], 0)
+        num_images = len(images)
+
+        for idx, i in enumerate(range(0, num_images, self.inference_batch_size)):
+            self._detection_progress = 0.5 + (i/num_images)*0.5
+            batch_images = images[i:i+self.inference_batch_size]
             batch_detections = await self._detect(model_information, batch_images, tmp_folder)
             self.active_training_io.save_detections(batch_detections, idx)
-            idx += 1
 
-        return None
+    # ---------------------------------------- METHODS ----------------------------------------
 
-    async def upload_detections(self):
-        error_key = 'upload_detections'
-        previous_state = self.training.training_state
-        self.training.training_state = TrainingState.DetectionUploading
-        await asyncio.sleep(0.1)  # NOTE needed for tests
-        try:
-            json_files = self.active_training_io.get_detection_file_names()
-            if not json_files:
-                raise Exception()
-            current_json_file_index = self.active_training_io.load_detections_upload_file_index()
-            for i in range(current_json_file_index, len(json_files)):
-                detections = self.active_training_io.load_detections(i)
-                logging.info(f'uploading detections {i}/{len(json_files)}')
-                await self._upload_detections_batched(self.training.context, detections)
-                self.active_training_io.save_detections_upload_file_index(i+1)
-        except asyncio.CancelledError:
-            logging.warning('CancelledError in upload_detections')
-            raise
-        except Exception as e:
-            self.errors.set(error_key, str(e))
-            logging.exception('Error in upload_detections')
-            self.training.training_state = previous_state
-        else:
-            self.errors.reset(error_key)
-            self.training.training_state = TrainingState.ReadyForCleanup
-            self.node.last_training_io.save(self.training)
-
-    async def _upload_detections_batched(self, context: Context, detections: List[Detections]):
-        batch_size = 10
-        skip_detections = self.active_training_io.load_detection_upload_progress()
-        for i in tqdm(range(skip_detections, len(detections), batch_size), position=0, leave=True):
-            up_progress = i+batch_size
-            batch_detections = detections[i:up_progress]
-            dict_detections = [jsonable_encoder(asdict(detection)) for detection in batch_detections]
-            logging.info(f'uploading detections. File size : {len(json.dumps(dict_detections))}')
-            await self._upload_detections(context, batch_detections, up_progress)
-            skip_detections = up_progress
-
-    async def _upload_detections(self, context: Context, batch_detections: List[Detections], up_progress: int):
-        assert self._active_training_io is not None, 'active_training must be set'
-
-        detections_json = [jsonable_encoder(asdict(detections)) for detections in batch_detections]
-        response = await self.node.loop_communicator.post(
-            f'/{context.organization}/projects/{context.project}/detections', json=detections_json)
-        if response.status_code != 200:
-            msg = f'could not upload detections. {str(response)}'
-            logging.error(msg)
-            raise Exception(msg)
+    async def _start_training(self):
+        self.start_training_task = None  # NOTE: this is used i.e. by tests
+        if self._can_resume():
+            self.start_training_task = self._resume()
         else:
-            logging.info('successfully uploaded detections')
-            if up_progress > len(batch_detections):
-                self._active_training_io.save_detection_upload_progress(0)
+            base_model_uuid_or_name = self.training.base_model_uuid_or_name
+            if not is_valid_uuid4(base_model_uuid_or_name):
+                self.start_training_task = self._start_training_from_scratch()
             else:
-                self._active_training_io.save_detection_upload_progress(up_progress)
-
-    async def clear_training(self):
-        self.active_training_io.delete_detections()
-        self.active_training_io.delete_detection_upload_progress()
-        self.active_training_io.delete_detections_upload_file_index()
-        await self.clear_training_data(self.training.training_folder)
-        self.node.last_training_io.delete()
-        # self.training.training_state = TrainingState.TrainingFinished
-        assert self._node is not None
-        await self._node.send_status()  # make sure the status is updated before we stop the training
-        self._training = None
+                self.start_training_task = self._start_training_from_base_model()
+        await self.start_training_task
+
+    # ---------------------------------------- OVERWRITTEN METHODS ----------------------------------------
 
     async def stop(self) -> None:
         """If executor is running, stop it. Else cancel training task."""
-        if not self.is_initialized:
+        print('===============> stop received in trainer_logic.', flush=True)
+
+        if not self.training_active:
             return
-        if self._executor and self._executor.is_process_running():
-            self.executor.stop()
+        if self._executor and self._executor.is_running():
+            await self.executor.stop_and_wait()
         elif self.training_task:
             logging.info('cancelling training task')
             if self.training_task.cancel():
@@ -523,175 +155,33 @@ class TrainerLogic():
                 except asyncio.CancelledError:
                     pass
                 logging.info('cancelled training task')
-                self.may_restart()
-
-    async def shutdown(self) -> None:
-        self.shutdown_event.set()
-        await self.stop()
-        await self.stop()  # NOTE first stop may only stop training.
-
-    def get_log(self) -> str:
-        return self.executor.get_log()
+                self._may_restart()
 
-    def may_restart(self) -> None:
-        if self.restart_after_training:
-            logging.info('restarting')
-            assert self._node is not None
-            self._node.restart()
-        else:
-            logging.info('not restarting')
-
-    @property
-    def general_progress(self) -> Optional[float]:
-        """Represents the progress for different states."""
-        if not self.is_initialized:
-            return None
-
-        t_state = self.training.training_state
-        if t_state == TrainingState.DataDownloading:
-            return self.node.data_exchanger.progress
-        if t_state == TrainingState.TrainingRunning:
-            return self.training_progress
-        if t_state == TrainingState.Detecting:
-            return self.detection_progress
-
-        return None
     # ---------------------------------------- ABSTRACT METHODS ----------------------------------------
 
-    @property
-    @abstractmethod
-    def training_progress(self) -> Optional[float]:
-        """Represents the training progress."""
-        raise NotImplementedError
-
-    @property
-    @abstractmethod
-    def provided_pretrained_models(self) -> List[PretrainedModel]:
-        raise NotImplementedError
-
-    @property
     @abstractmethod
-    def model_architecture(self) -> Optional[str]:
-        raise NotImplementedError
+    async def _start_training_from_base_model(self) -> None:
+        '''Should be used to start a training on executer, e.g. self.executor.start(cmd).'''
 
     @abstractmethod
-    async def start_training(self) -> None:
-        '''Should be used to start a training.'''
+    async def _start_training_from_scratch(self) -> None:
+        '''Should be used to start a training from scratch on executer, e.g. self.executor.start(cmd).
+        NOTE base_model_id is now accessible via self.training.base_model_id 
+        the id of a pretrained model provided by self.provided_pretrained_models.'''
 
     @abstractmethod
-    async def start_training_from_scratch(self, base_model_id: str) -> None:
-        '''Should be used to start a training from scratch.
-        base_model_id is the id of a pretrained model provided by self.provided_pretrained_models.'''
-
-    @abstractmethod
-    def can_resume(self) -> bool:
+    def _can_resume(self) -> bool:
         '''Override this method to return True if the trainer can resume training.'''
 
     @abstractmethod
-    async def resume(self) -> None:
+    async def _resume(self) -> None:
         '''Is called when self.can_resume() returns True.
         One may resume the training on a previously trained model stored by self.on_model_published(basic_model).'''
 
     @abstractmethod
-    def get_executor_error_from_log(self) -> Optional[str]:  # TODO we should allow other options to get the error
+    def _get_executor_error_from_log(self) -> Optional[str]:
         '''Should be used to provide error informations to the Learning Loop by extracting data from self.executor.get_log().'''
 
-    @abstractmethod
-    def get_new_model(self) -> Optional[BasicModel]:
-        '''Is called frequently in `try_sync_model` to check if a new "best" model is availabe.
-        Returns None if no new model could be found. Otherwise BasicModel(confusion_matrix, meta_information).
-        `confusion_matrix` contains a dict of all classes:
-            - The classes must be identified by their id, not their name.
-            - For each class a dict with tp, fp, fn is provided (true positives, false positives, false negatives).
-        `meta_information` can hold any data which is helpful for self.on_model_published to store weight file etc for later upload via self.get_model_files
-        '''
-
-    @abstractmethod
-    def on_model_published(self, basic_model: BasicModel) -> None:
-        '''Called after a BasicModel has been successfully send to the Learning Loop.
-        The files for this model should be stored.
-        self.get_latest_model_files is used to gather all files needed for transfering the actual data from the trainer node to the Learning Loop.
-        In the simplest implementation this method just renames the weight file (encoded in BasicModel.meta_information) into a file name like latest_published_model
-        '''
-
-    @abstractmethod
-    def get_latest_model_files(self) -> Optional[Union[List[str], Dict[str, List[str]]]]:
-        '''Called when the Learning Loop requests to backup the latest model for the training.
-        Should return a list of file paths which describe the model.
-        These files must contain all data neccessary for the trainer to resume a training (eg. weight file, hyperparameters, etc.)
-        and will be stored in the Learning Loop unter the format of this trainer.
-        Note: by convention the weightfile should be named "model.<extension>" where extension is the file format of the weightfile.
-        For example "model.pt" for pytorch or "model.weights" for darknet/yolo.
-
-        If a trainer can also generate other formats (for example for an detector),
-        a dictionary mapping format -> list of files can be returned.'''
-
     @abstractmethod
     async def _detect(self, model_information: ModelInformation, images: List[str], model_folder: str) -> List[Detections]:
         '''Called to run detections on a list of images.'''
-
-    @abstractmethod
-    async def clear_training_data(self, training_folder: str) -> None:
-        '''Called after a training has finished. Deletes all data that is not needed anymore after a training run. 
-        This can be old weightfiles or any additional files.'''
-
-    # ---------------------------------------- HELPER METHODS ----------------------------------------
-
-    @staticmethod
-    def images_for_ids(image_ids, image_folder) -> List[str]:
-        logging.info(f'### Going to get images for {len(image_ids)} images ids')
-        start = perf_counter()
-        images = [img for img in glob(f'{image_folder}/**/*.*', recursive=True)
-                  if os.path.splitext(os.path.basename(img))[0] in image_ids]
-        end = perf_counter()
-        logging.info(f'found {len(images)} images for {len(image_ids)} image ids, which took {end-start:0.2f} seconds')
-        return images
-
-    @staticmethod
-    def generate_training(project_folder: str, context: Context) -> Training:
-        training_uuid = str(uuid4())
-        return Training(
-            id=training_uuid,
-            context=context,
-            project_folder=project_folder,
-            images_folder=create_image_folder(project_folder),
-            training_folder=TrainerLogic.create_training_folder(project_folder, training_uuid)
-        )
-
-    @staticmethod
-    def delete_all_training_folders(project_folder: str):
-        if not os.path.exists(f'{project_folder}/trainings'):
-            return
-        for uuid in os.listdir(f'{project_folder}/trainings'):
-            shutil.rmtree(f'{project_folder}/trainings/{uuid}', ignore_errors=True)
-
-    @staticmethod
-    def create_training_folder(project_folder: str, trainings_id: str) -> str:
-        training_folder = f'{project_folder}/trainings/{trainings_id}'
-        os.makedirs(training_folder, exist_ok=True)
-        return training_folder
-
-    @property
-    def hyperparameters(self) -> Optional[Dict]:
-        if self._training and self._training.data and self._training.data.hyperparameter:
-            information = {}
-            information['resolution'] = self._training.data.hyperparameter.resolution
-            information['flipRl'] = self._training.data.hyperparameter.flip_rl
-            information['flipUd'] = self._training.data.hyperparameter.flip_ud
-            return information
-        return None
-
-    def create_model_json_with_categories(self) -> str:
-        """Remaining fields are filled by the Learning Loop"""
-        if self._training and self._training.data:
-            content = {
-                'categories': [asdict(c) for c in self._training.data.categories],
-            }
-        else:
-            content = None
-
-        model_json_path = '/tmp/model.json'
-        with open(model_json_path, 'w') as f:
-            json.dump(content, f)
-
-        return model_json_path