lamindb 0.76.13__py3-none-any.whl → 0.76.15__py3-none-any.whl

lamindb/_feature.py

@@ -8,10 +8,9 @@ from lamindb_setup.core._docs import doc_args
 from lnschema_core.models import Artifact, Feature
 from pandas.api.types import CategoricalDtype, is_string_dtype
 
-from lamindb._utils import attach_func_to_class_method
-from lamindb.core._settings import settings
-
 from ._query_set import RecordsList
+from ._utils import attach_func_to_class_method
+from .core._settings import settings
 from .core.schema import dict_schema_name_to_model_name
 
 if TYPE_CHECKING:

lamindb/_feature_set.py

@@ -10,10 +10,9 @@ from lamindb_setup.core.hashing import hash_set
 from lnschema_core import Feature, FeatureSet, Record, ids
 from lnschema_core.types import FieldAttr, ListLike
 
-from lamindb._utils import attach_func_to_class_method
-
 from ._feature import convert_numpy_dtype_to_lamin_feature_type
 from ._record import init_self_from_db
+from ._utils import attach_func_to_class_method
 from .core.exceptions import ValidationError
 from .core.schema import (
     dict_related_model_to_related_name,

lamindb/_from_values.py

@@ -64,11 +64,7 @@ def get_or_create_records(
             if source_record:
                 from bionty.core._add_ontology import check_source_in_db
 
-                check_source_in_db(
-                    registry=registry,
-                    source=source_record,
-                    update=True,
-                )
+                check_source_in_db(registry=registry, source=source_record)
 
                 from_source = not source_record.in_db
             elif hasattr(registry, "source_id"):

lamindb/_is_versioned.py

@@ -5,8 +5,7 @@ from lamin_utils import logger
 from lamindb_setup.core.upath import UPath
 from lnschema_core.models import IsVersioned
 
-from lamindb._utils import attach_func_to_class_method
-
+from ._utils import attach_func_to_class_method
 from .core.versioning import create_uid, get_new_path_from_uid
 
 

lamindb/_parents.py

@@ -8,13 +8,14 @@ from lamin_utils import logger
 from lnschema_core import Artifact, Collection, Record, Run, Transform
 from lnschema_core.models import HasParents, format_field_value
 
-from lamindb._utils import attach_func_to_class_method
-
 from ._record import get_name_field
+from ._utils import attach_func_to_class_method
 
 if TYPE_CHECKING:
     from lnschema_core.types import StrField
 
+    from lamindb.core import QuerySet
+
 LAMIN_GREEN_LIGHTER = "#10b981"
 LAMIN_GREEN_DARKER = "#065f46"
 GREEN_FILL = "honeydew"
@@ -22,6 +23,30 @@ TRANSFORM_EMOJIS = {"notebook": "📔", "app": "🖥️", "pipeline": "🧩"}
 is_run_from_ipython = getattr(builtins, "__IPYTHON__", False)
 
 
+# this is optimized to have fewer recursive calls
+# also len of QuerySet can be costly at times
+def _query_relatives(
+    records: QuerySet | list[Record],
+    kind: Literal["parents", "children"],
+    cls: type[HasParents],
+) -> QuerySet:
+    relatives = cls.objects.none()
+    if len(records) == 0:
+        return relatives
+    for record in records:
+        relatives = relatives.union(getattr(record, kind).all())
+    relatives = relatives.union(_query_relatives(relatives, kind, cls))
+    return relatives
+
+
+def query_parents(self) -> QuerySet:
+    return _query_relatives([self], "parents", self.__class__)
+
+
+def query_children(self) -> QuerySet:
+    return _query_relatives([self], "children", self.__class__)
+
+
 def _transform_emoji(transform: Transform):
     if transform is not None:
         return TRANSFORM_EMOJIS.get(transform.type, "💫")
@@ -474,9 +499,7 @@ def _df_edges_from_runs(df_values: list):
     return df
 
 
-METHOD_NAMES = [
-    "view_parents",
-]
+METHOD_NAMES = ["view_parents", "query_parents", "query_children"]
 
 if ln_setup._TESTING:  # type: ignore
     from inspect import signature

lamindb/_query_manager.py

@@ -7,9 +7,8 @@ from lamin_utils import logger
 from lamindb_setup.core._docs import doc_args
 from lnschema_core.models import Record
 
-from lamindb.core._settings import settings
-
 from .core._feature_manager import get_feature_set_by_slot_
+from .core._settings import settings
 
 if TYPE_CHECKING:
     from lnschema_core.types import StrField

lamindb/_query_set.py

@@ -6,7 +6,7 @@ from typing import TYPE_CHECKING, NamedTuple
 import pandas as pd
 from django.db import models
 from django.db.models import F
-from lamin_utils import logger
+from lamin_utils import colors, logger
 from lamindb_setup.core._docs import doc_args
 from lnschema_core.models import (
     Artifact,
@@ -20,7 +20,7 @@ from lnschema_core.models import (
     VisibilityChoice,
 )
 
-from lamindb.core.exceptions import DoesNotExist
+from .core.exceptions import DoesNotExist
 
 if TYPE_CHECKING:
     from collections.abc import Iterable
@@ -186,6 +186,7 @@ class QuerySet(models.QuerySet):
         if pk_column_name in df.columns:
             df = df.set_index(pk_column_name)
         if len(df) == 0:
+            logger.warning(colors.yellow("No records found"))
             return df
         if include is not None:
             if isinstance(include, str):
@@ -218,12 +219,15 @@ class QuerySet(models.QuerySet):
                             f"{related_ORM.__name__.lower()}__{lookup_str}"
                         )
                     link_df = pd.DataFrame(
-                        field.through.objects.values(
+                        field.through.objects.using(self.db).values(
                             left_side_link_model, values_expression
                         )
                     )
                     if link_df.shape[0] == 0:
-                        return df
+                        logger.warning(
+                            f"{colors.yellow(expression)} is not shown because no values are found"
+                        )
+                        continue
                     link_groupby = link_df.groupby(left_side_link_model)[
                         values_expression
                     ].apply(list)

lamindb/_record.py

@@ -7,7 +7,7 @@ import dj_database_url
 import lamindb_setup as ln_setup
 from django.db import connections, transaction
 from django.db.models import IntegerField, Manager, Q, QuerySet, Value
-from lamin_utils import logger
+from lamin_utils import colors, logger
 from lamin_utils._lookup import Lookup
 from lamindb_setup._connect_instance import (
     get_owner_name_from_identifier,
@@ -17,10 +17,11 @@ from lamindb_setup._connect_instance import (
 from lamindb_setup.core._docs import doc_args
 from lamindb_setup.core._hub_core import connect_instance_hub
 from lamindb_setup.core._settings_store import instance_settings_file
-from lnschema_core.models import IsVersioned, Record, Run, Transform
+from lnschema_core.models import Artifact, Feature, IsVersioned, Record, Run, Transform
 
-from lamindb._utils import attach_func_to_class_method
-from lamindb.core._settings import settings
+from ._utils import attach_func_to_class_method
+from .core._settings import settings
+from .core.exceptions import RecordNameChangeIntegrityError
 
 if TYPE_CHECKING:
     import pandas as pd
@@ -129,6 +130,7 @@ def __init__(record: Record, *args, **kwargs):
     else:
         # object is loaded from DB (**kwargs could be omitted below, I believe)
         super(Record, record).__init__(*args, **kwargs)
+        _store_record_old_name(record)
 
 
 @classmethod  # type:ignore
@@ -584,11 +586,15 @@ def save(self, *args, **kwargs) -> Record:
             with transaction.atomic():
                 revises._revises = None  # ensure we don't start a recursion
                 revises.save()
+                check_name_change(self)
                 super(Record, self).save(*args, **kwargs)
+                _store_record_old_name(self)
             self._revises = None
         # save unversioned record
         else:
+            check_name_change(self)
             super(Record, self).save(*args, **kwargs)
+            _store_record_old_name(self)
     # perform transfer of many-to-many fields
     # only supported for Artifact and Collection records
     if db is not None and db != "default" and using_key is None:
@@ -616,6 +622,74 @@ def save(self, *args, **kwargs) -> Record:
     return self
 
 
+def _store_record_old_name(record: Record):
+    # writes the name to the _name attribute, so we can detect renaming upon save
+    if hasattr(record, "_name_field"):
+        record._name = getattr(record, record._name_field)
+
+
+def check_name_change(record: Record):
+    """Warns if a record's name has changed."""
+    if (
+        not record.pk
+        or not hasattr(record, "_name")
+        or not hasattr(record, "_name_field")
+    ):
+        return
+
+    old_name = record._name
+    new_name = getattr(record, record._name_field)
+    registry = record.__class__.__name__
+
+    if old_name != new_name:
+        # when a label is renamed, only raise a warning if it has a feature
+        if hasattr(record, "artifacts"):
+            linked_records = (
+                record.artifacts.through.filter(
+                    label_ref_is_name=True, **{f"{registry.lower()}_id": record.pk}
+                )
+                .exclude(feature_id=None)  # must have a feature
+                .exclude(
+                    feature_ref_is_name=None
+                )  # must be linked via Curator and therefore part of a featureset
+                .distinct()
+            )
+            artifact_ids = linked_records.list("artifact__uid")
+            n = len(artifact_ids)
+            s = "s" if n > 1 else ""
+            if n > 0:
+                logger.error(
+                    f"You are trying to {colors.red('rename label')} from '{old_name}' to '{new_name}'!\n"
+                    f"   → The following {n} artifact{s} {colors.red('will no longer be validated')}: {artifact_ids}\n\n"
+                    f"{colors.bold('To rename this label')}, make it external:\n"
+                    f"   → run `artifact.labels.make_external(label)`\n\n"
+                    f"After renaming, consider re-curating the above artifact{s}:\n"
+                    f'   → in each dataset, manually modify label "{old_name}" to "{new_name}"\n'
+                    f"   → run `ln.Curator`\n"
+                )
+                raise RecordNameChangeIntegrityError
+
+        # when a feature is renamed
+        elif isinstance(record, Feature):
+            # only internal features are associated with featuresets
+            linked_artifacts = Artifact.filter(feature_sets__features=record).list(
+                "uid"
+            )
+            n = len(linked_artifacts)
+            s = "s" if n > 1 else ""
+            if n > 0:
+                logger.error(
+                    f"You are trying to {colors.red('rename feature')} from '{old_name}' to '{new_name}'!\n"
+                    f"   → The following {n} artifact{s} {colors.red('will no longer be validated')}: {linked_artifacts}\n\n"
+                    f"{colors.bold('To rename this feature')}, make it external:\n"
+                    "   → run `artifact.features.make_external(feature)`\n\n"
+                    f"After renaming, consider re-curating the above artifact{s}:\n"
+                    f"   → in each dataset, manually modify feature '{old_name}' to '{new_name}'\n"
+                    f"   → run `ln.Curator`\n"
+                )
+                raise RecordNameChangeIntegrityError
+
+
 def delete(self) -> None:
     """Delete the record."""
     # note that the logic below does not fire if a record is moved to the trash

lamindb/_save.py

@@ -15,8 +15,8 @@ from lamin_utils import logger
 from lamindb_setup.core.upath import LocalPathClasses
 from lnschema_core.models import Artifact, Record
 
-from lamindb.core._settings import settings
-from lamindb.core.storage.paths import (
+from .core._settings import settings
+from .core.storage.paths import (
     _cache_key_from_artifact_storage,
     attempt_accessing_path,
     auto_storage_key_from_artifact,

lamindb/_transform.py

@@ -6,10 +6,9 @@ from lamin_utils import logger
 from lamindb_setup.core._docs import doc_args
 from lnschema_core.models import Run, Transform
 
-from lamindb.core.exceptions import InconsistentKey
-
 from ._parents import _view_parents
 from ._run import delete_run_artifacts
+from .core.exceptions import InconsistentKey
 from .core.versioning import message_update_key_in_version_family, process_revises
 
 if TYPE_CHECKING:

lamindb/_ulabel.py

@@ -6,7 +6,7 @@ import lamindb_setup as ln_setup
 from lamindb_setup.core._docs import doc_args
 from lnschema_core import ULabel
 
-from lamindb._utils import attach_func_to_class_method
+from ._utils import attach_func_to_class_method
 
 if TYPE_CHECKING:
     from lnschema_core.types import ListLike

lamindb/core/__init__.py

@@ -60,9 +60,11 @@ Modules:
    types
    exceptions
    subsettings
+   logger
 
 """
 
+from lamin_utils import logger
 from lamin_utils._inspect import InspectResult
 from lnschema_core.models import (
     CanValidate,

lamindb/core/_data.py

@@ -26,6 +26,7 @@ from lamindb.core._settings import settings
 from ._context import context
 from ._django import get_artifact_with_related, get_related_model
 from ._feature_manager import (
+    add_label_feature_links,
     get_feature_set_links,
     get_host_id_field,
     get_label_links,
@@ -67,11 +68,17 @@ def add_transform_to_kwargs(kwargs: dict[str, Any], run: Run):
 
 def save_feature_sets(self: Artifact | Collection) -> None:
     if hasattr(self, "_feature_sets"):
+        from lamindb.core._feature_manager import get_feature_set_by_slot_
+
+        existing_feature_sets = get_feature_set_by_slot_(self)
         saved_feature_sets = {}
         for key, feature_set in self._feature_sets.items():
             if isinstance(feature_set, FeatureSet) and feature_set._state.adding:
                 feature_set.save()
                 saved_feature_sets[key] = feature_set
+            if key in existing_feature_sets:
+                # remove existing feature set on the same slot
+                self.feature_sets.remove(existing_feature_sets[key])
         if len(saved_feature_sets) > 0:
             s = "s" if len(saved_feature_sets) > 1 else ""
             display_feature_set_keys = ",".join(
@@ -305,6 +312,8 @@ def add_labels(
     feature: Feature | None = None,
     *,
     field: StrField | None = None,
+    feature_ref_is_name: bool | None = None,
+    label_ref_is_name: bool | None = None,
 ) -> None:
     """{}"""  # noqa: D415
     if self._state.adding:
@@ -373,14 +382,17 @@ def add_labels(
             if registry_name not in self.features._accessor_by_registry:
                 logger.warning(f"skipping {registry_name}")
                 continue
-            labels_accessor = getattr(
-                self, self.features._accessor_by_registry[registry_name]
+            if len(records) == 0:
+                continue
+            features_labels = {
+                registry_name: [(feature, label_record) for label_record in records]
+            }
+            add_label_feature_links(
+                self.features,
+                features_labels,
+                feature_ref_is_name=feature_ref_is_name,
+                label_ref_is_name=label_ref_is_name,
             )
-            # remove labels that are already linked as add doesn't perform update
-            linked_labels = [r for r in records if r in labels_accessor.filter()]
-            if len(linked_labels) > 0:
-                labels_accessor.remove(*linked_labels)
-            labels_accessor.add(*records, through_defaults={"feature_id": feature.id})
         links_feature_set = get_feature_set_links(self)
         feature_set_ids = [link.featureset_id for link in links_feature_set.all()]
         # get all linked features of type Feature

lamindb/core/_feature_manager.py

@@ -13,6 +13,7 @@ from django.contrib.postgres.aggregates import ArrayAgg
 from django.db import connections
 from django.db.models import Aggregate
 from lamin_utils import colors, logger
+from lamindb_setup.core.hashing import hash_set
 from lamindb_setup.core.upath import create_path
 from lnschema_core.models import (
     Artifact,
@@ -586,6 +587,48 @@ def _accessor_by_registry(self):
     return self._accessor_by_registry_
 
 
+def add_label_feature_links(
+    self,
+    features_labels,
+    *,
+    label_ref_is_name: bool | None = None,
+    feature_ref_is_name: bool | None = None,
+):
+    if list(features_labels.keys()) != ["ULabel"]:
+        related_names = dict_related_model_to_related_name(self._host.__class__)
+    else:
+        related_names = {"ULabel": "ulabels"}
+    for class_name, registry_features_labels in features_labels.items():
+        related_name = related_names[class_name]  # e.g., "ulabels"
+        LinkORM = getattr(self._host, related_name).through
+        field_name = f"{get_link_attr(LinkORM, self._host)}_id"  # e.g., ulabel_id
+        links = [
+            LinkORM(
+                **{
+                    "artifact_id": self._host.id,
+                    "feature_id": feature.id,
+                    field_name: label.id,
+                    "feature_ref_is_name": feature_ref_is_name,
+                    "label_ref_is_name": label_ref_is_name,
+                }
+            )
+            for (feature, label) in registry_features_labels
+        ]
+        # a link might already exist
+        try:
+            save(links, ignore_conflicts=False)
+        except Exception:
+            save(links, ignore_conflicts=True)
+        # now delete links that were previously saved without a feature
+        LinkORM.filter(
+            **{
+                "artifact_id": self._host.id,
+                "feature_id": None,
+                f"{field_name}__in": [l.id for _, l in registry_features_labels],
+            }
+        ).all().delete()
+
+
 def _add_values(
     self,
     values: dict[str, str | int | float | bool],
@@ -717,49 +760,9 @@ def _add_values(
             f"Here is how to create ulabels for them:\n\n{hint}"
         )
         raise ValidationError(msg)
-    # bulk add all links to ArtifactULabel
+    # bulk add all links
     if features_labels:
-        if list(features_labels.keys()) != ["ULabel"]:
-            related_names = dict_related_model_to_related_name(self._host.__class__)
-        else:
-            related_names = {"ULabel": "ulabels"}
-        for class_name, registry_features_labels in features_labels.items():
-            related_name = related_names[class_name]  # e.g., "ulabels"
-            LinkORM = getattr(self._host, related_name).through
-            field_name = f"{get_link_attr(LinkORM, self._host)}_id"  # e.g., ulabel_id
-            links = [
-                LinkORM(
-                    **{
-                        "artifact_id": self._host.id,
-                        "feature_id": feature.id,
-                        field_name: label.id,
-                    }
-                )
-                for (feature, label) in registry_features_labels
-            ]
-            # a link might already exist
-            try:
-                save(links, ignore_conflicts=False)
-            except Exception:
-                save(links, ignore_conflicts=True)
-                # now deal with links that were previously saved without a feature_id
-                links_saved = LinkORM.filter(
-                    **{
-                        "artifact_id": self._host.id,
-                        f"{field_name}__in": [
-                            l.id for _, l in registry_features_labels
-                        ],
-                    }
-                )
-                for link in links_saved.all():
-                    # TODO: also check for inconsistent features
-                    if link.feature_id is None:
-                        link.feature_id = [
-                            f.id
-                            for f, l in registry_features_labels
-                            if l.id == getattr(link, field_name)
-                        ][0]
-                        link.save()
+        add_label_feature_links(self, features_labels)
     if _feature_values:
         save(_feature_values)
         if is_param:
@@ -1006,6 +1009,36 @@ def _add_from(self, data: Artifact | Collection, transfer_logs: dict = None):
         self._host.features.add_feature_set(feature_set_self, slot)
 
 
+def make_external(self, feature: Feature) -> None:
+    """Make a feature external, aka, remove feature from feature sets.
+
+    Args:
+        feature: `Feature` A feature record.
+
+    """
+    if not isinstance(feature, Feature):
+        raise TypeError("feature must be a Feature record!")
+    feature_sets = FeatureSet.filter(features=feature).all()
+    for fs in feature_sets:
+        f = Feature.filter(uid=feature.uid).all()
+        features_updated = fs.members.difference(f)
+        if len(features_updated) > 0:
+            # re-compute the hash of feature sets based on the updated members
+            features_hash = hash_set({feature.uid for feature in features_updated})
+            fs.hash = features_hash
+            fs.n = len(features_updated)
+            fs.save()
+        # delete the link between the feature and the feature set
+        FeatureSet.features.through.objects.filter(
+            feature_id=feature.id, featureset_id=fs.id
+        ).delete()
+        # if no members are left in the featureset, delete it
+        if len(features_updated) == 0:
+            logger.warning(f"deleting empty feature set: {fs}")
+            fs.artifacts.set([])
+            fs.delete()
+
+
 FeatureManager.__init__ = __init__
 ParamManager.__init__ = __init__
 FeatureManager.__repr__ = __repr__
@@ -1022,6 +1055,7 @@ FeatureManager._add_set_from_mudata = _add_set_from_mudata
 FeatureManager._add_from = _add_from
 FeatureManager.filter = filter
 FeatureManager.get = get
+FeatureManager.make_external = make_external
 ParamManager.add_values = add_values_params
 ParamManager.get_values = get_values
 ParamManager.filter = filter

lamindb/core/_label_manager.py

@@ -263,3 +263,24 @@ class LabelManager:
                     getattr(self._host, related_name).add(
                         *labels, through_defaults={"feature_id": feature_id}
                     )
+
+    def make_external(self, label: Record):
+        """Make a label external, aka dissociate label from internal features.
+
+        Args:
+            label: Label record to make external.
+        """
+        d = dict_related_model_to_related_name(self._host)
+        registry = label.__class__
+        related_name = d.get(registry.__get_name_with_schema__())
+        link_model = getattr(self._host, related_name).through
+        link_records = link_model.filter(
+            artifact_id=self._host.id, **{f"{registry.__name__.lower()}_id": label.id}
+        )
+        features = link_records.values_list("feature__name", flat=True).distinct()
+        s = "s" if len(features) > 1 else ""
+        link_records.update(feature_id=None, feature_ref_is_name=None)
+        logger.warning(
+            f'{registry.__name__} "{getattr(label, label._name_field)}" is no longer associated with the following feature{s}:\n'
+            f"{list(features)}"
+        )

lamindb/core/_mapped_collection.py

@@ -69,7 +69,7 @@ class MappedCollection:
 
     .. note::
 
-        For a guide, see :doc:`docs:scrna5`.
+        For a guide, see :doc:`docs:scrna-mappedcollection`.
 
         For more convenient use within :class:`~lamindb.core.MappedCollection`,
         see :meth:`~lamindb.Collection.mapped`.

lamindb/core/exceptions.py

@@ -11,6 +11,7 @@
    MissingContextUID
    UpdateContext
    IntegrityError
+   RecordNameChangeIntegrityError
 
 """
 
@@ -57,6 +58,12 @@ class InconsistentKey(Exception):
     pass
 
 
+class RecordNameChangeIntegrityError(SystemExit):
+    """Custom exception for name change errors."""
+
+    pass
+
+
 # -------------------------------------------------------------------------------------
 # run context
 # -------------------------------------------------------------------------------------

lamindb/core/storage/_backed_access.py

@@ -7,11 +7,13 @@ from anndata._io.specs.registry import get_spec
 from lnschema_core import Artifact
 
 from ._anndata_accessor import AnnDataAccessor, StorageType, registry
+from ._pyarrow_dataset import _is_pyarrow_dataset, _open_pyarrow_dataset
 from ._tiledbsoma import _open_tiledbsoma
 from .paths import filepath_from_artifact
 
 if TYPE_CHECKING:
     from fsspec.core import OpenFile
+    from pyarrow.dataset import Dataset as PyArrowDataset
     from tiledbsoma import Collection as SOMACollection
     from tiledbsoma import Experiment as SOMAExperiment
     from upath import UPath
@@ -67,22 +69,28 @@ def backed_access(
     artifact_or_filepath: Artifact | UPath,
     mode: str = "r",
     using_key: str | None = None,
-) -> AnnDataAccessor | BackedAccessor | SOMACollection | SOMAExperiment:
+) -> (
+    AnnDataAccessor | BackedAccessor | SOMACollection | SOMAExperiment | PyArrowDataset
+):
     if isinstance(artifact_or_filepath, Artifact):
-        filepath, _ = filepath_from_artifact(artifact_or_filepath, using_key=using_key)
+        objectpath, _ = filepath_from_artifact(
+            artifact_or_filepath, using_key=using_key
+        )
     else:
-        filepath = artifact_or_filepath
-    name = filepath.name
-    suffix = filepath.suffix
+        objectpath = artifact_or_filepath
+    name = objectpath.name
+    suffix = objectpath.suffix
 
     if name == "soma" or suffix == ".tiledbsoma":
         if mode not in {"r", "w"}:
             raise ValueError("`mode` should be either 'r' or 'w' for tiledbsoma.")
-        return _open_tiledbsoma(filepath, mode=mode)  # type: ignore
+        return _open_tiledbsoma(objectpath, mode=mode)  # type: ignore
     elif suffix in {".h5", ".hdf5", ".h5ad"}:
-        conn, storage = registry.open("h5py", filepath, mode=mode)
+        conn, storage = registry.open("h5py", objectpath, mode=mode)
     elif suffix == ".zarr":
-        conn, storage = registry.open("zarr", filepath, mode=mode)
+        conn, storage = registry.open("zarr", objectpath, mode=mode)
+    elif _is_pyarrow_dataset(objectpath):
+        return _open_pyarrow_dataset(objectpath)
     else:
         raise ValueError(
             "object should have .h5, .hdf5, .h5ad, .zarr, .tiledbsoma suffix, not"