lamindb 0.74.1__py3-none-any.whl → 0.74.3__py3-none-any.whl

lamindb/_save.py

@@ -13,7 +13,7 @@ from django.db import IntegrityError, transaction
 from django.utils.functional import partition
 from lamin_utils import logger
 from lamindb_setup.core.upath import LocalPathClasses
-from lnschema_core.models import Artifact, Registry
+from lnschema_core.models import Artifact, Record
 
 from lamindb.core._settings import settings
 from lamindb.core.storage.paths import (
@@ -27,9 +27,7 @@ if TYPE_CHECKING:
     from lamindb_setup.core.upath import UPath
 
 
-def save(
-    records: Iterable[Registry], ignore_conflicts: bool | None = False, **kwargs
-) -> None:
+def save(records: Iterable[Record], ignore_conflicts: bool | None = False) -> None:
     """Bulk save to registries & storage.
 
     Note:
@@ -42,12 +40,11 @@ def save(
         existing records! Use ``record.save()`` for these use cases.
 
     Args:
-        records: Multiple :class:`~lamindb.core.Registry` objects.
+        records: Multiple :class:`~lamindb.core.Record` objects.
         ignore_conflicts: If ``True``, do not error if some records violate a
            unique or another constraint. However, it won't inplace update the id
            fields of records. If you need records with ids, you need to query
            them from the database.
-        **kwargs: Get kwargs related to parents.
 
     Examples:
 
@@ -69,7 +66,7 @@ def save(
         >>> transform.save()
 
     """
-    if isinstance(records, Registry):
+    if isinstance(records, Record):
         raise ValueError("Please use record.save() if saving a single record.")
 
     # previously, this was all set based,
@@ -87,27 +84,12 @@ def save(
         non_artifacts_with_parents = [
             r for r in non_artifacts_new if hasattr(r, "_parents")
         ]
-        if len(non_artifacts_with_parents) > 0 and kwargs.get("parents") is not False:
+        if len(non_artifacts_with_parents) > 0:
             # this can only happen within lnschema_bionty right now!!
             # we might extend to core lamindb later
-            import bionty as bt
-
-            if kwargs.get("parents") or (
-                kwargs.get("parents") is None and bt.settings.auto_save_parents
-            ):
-                mute = False if kwargs.get("mute") is None else kwargs.get("mute")
-                if not mute:
-                    # save the record with parents one by one
-                    logger.warning(
-                        "now recursing through parents: "
-                        "this only happens once, but is much slower than bulk saving"
-                    )
-                    logger.hint(
-                        "you can switch this off via: bt.settings.auto_save_parents ="
-                        " False"
-                    )
-                for record in non_artifacts_with_parents:
-                    record._save_ontology_parents(mute=True)
+            from lnschema_bionty.core import add_ontology
+
+            add_ontology(non_artifacts_with_parents)
 
     if artifacts:
         with transaction.atomic():
@@ -122,7 +104,7 @@ def save(
     return None
 
 
-def bulk_create(records: Iterable[Registry], ignore_conflicts: bool | None = False):
+def bulk_create(records: Iterable[Record], ignore_conflicts: bool | None = False):
     records_by_orm = defaultdict(list)
     for record in records:
         records_by_orm[record.__class__].append(record)
@@ -130,7 +112,7 @@ def bulk_create(records: Iterable[Registry], ignore_conflicts: bool | None = Fal
         orm.objects.bulk_create(records, ignore_conflicts=ignore_conflicts)
 
 
-def bulk_update(records: Iterable[Registry], ignore_conflicts: bool | None = False):
+def bulk_update(records: Iterable[Record], ignore_conflicts: bool | None = False):
     records_by_orm = defaultdict(list)
     for record in records:
         records_by_orm[record.__class__].append(record)

lamindb/_storage.py

@@ -6,7 +6,7 @@ from lnschema_core import Storage
 @property  # type: ignore
 @doc_args(Storage.path.__doc__)
 def path(self) -> UPath:
-    """{}."""
+    """{}"""  # noqa: D415
     access_token = self._access_token if hasattr(self, "_access_token") else None
     return create_path(self.root, access_token=access_token)
 

lamindb/_view.py

@@ -7,7 +7,7 @@ import inspect
 from lamin_utils import colors, logger
 from lamindb_setup import settings
 from lamindb_setup._init_instance import get_schema_module_name
-from lnschema_core import Registry
+from lnschema_core import Record
 
 is_run_from_ipython = getattr(builtins, "__IPYTHON__", False)
 
@@ -21,7 +21,7 @@ def view(
         n: Display the last `n` rows of a registry.
         schema: Schema module to view. Default's to
             `None` and displays all schema modules.
-        registries: List of Registry names. Defaults to
+        registries: List of Record names. Defaults to
             `None` and lists all registries.
 
     Examples:
@@ -44,8 +44,8 @@ def view(
             orm
             for orm in schema_module.__dict__.values()
             if inspect.isclass(orm)
-            and issubclass(orm, Registry)
-            and orm.__name__ != "Registry"
+            and issubclass(orm, Record)
+            and orm.__name__ != "Record"
         }
         if registries is not None:
             filtered_registries = {

lamindb/core/__init__.py

@@ -5,7 +5,7 @@ Registries:
 .. autosummary::
    :toctree: .
 
-   Registry
+   Record
    QuerySet
    QueryManager
    RecordsList
@@ -19,18 +19,20 @@ Registries:
    HasParents
    TracksRun
    TracksUpdates
+   ParamValue
+   FeatureValue
    InspectResult
    fields
 
-Annotators:
+Curators:
 
 .. autosummary::
    :toctree: .
 
-   DataFrameAnnotator
-   AnnDataAnnotator
-   MuDataAnnotator
-   AnnotateLookup
+   DataFrameCurator
+   AnnDataCurator
+   MuDataCurator
+   CurateLookup
 
 Other:
 
@@ -57,20 +59,22 @@ Modules:
 from lamin_utils._inspect import InspectResult
 from lnschema_core.models import (
     CanValidate,
+    FeatureValue,
     HasFeatures,
     HasParams,
     HasParents,
     IsVersioned,
-    Registry,
+    ParamValue,
+    Record,
     TracksRun,
     TracksUpdates,
 )
 
-from lamindb._annotate import (
-    AnnDataAnnotator,
-    AnnotateLookup,
-    DataFrameAnnotator,
-    MuDataAnnotator,
+from lamindb._curate import (
+    AnnDataCurator,
+    CurateLookup,
+    DataFrameCurator,
+    MuDataCurator,
 )
 from lamindb._query_manager import QueryManager
 from lamindb._query_set import QuerySet, RecordsList

lamindb/core/_data.py

@@ -11,7 +11,7 @@ from lnschema_core.models import (
     Feature,
     FeatureSet,
     HasFeatures,
-    Registry,
+    Record,
     Run,
     ULabel,
     __repr__,
@@ -20,7 +20,7 @@ from lnschema_core.models import (
 
 from lamindb._parents import view_lineage
 from lamindb._query_set import QuerySet
-from lamindb._registry import get_default_str_field
+from lamindb._record import get_default_str_field
 from lamindb.core._settings import settings
 
 from ._feature_manager import (
@@ -96,7 +96,7 @@ def save_feature_set_links(self: Artifact | Collection) -> None:
 
 @doc_args(HasFeatures.describe.__doc__)
 def describe(self: HasFeatures, print_types: bool = False):
-    """{}."""
+    """{}"""  # noqa: D415
     # prefetch all many-to-many relationships
     # doesn't work for describing using artifact
     # self = (
@@ -166,7 +166,7 @@ def describe(self: HasFeatures, print_types: bool = False):
     logger.print(msg)
 
 
-def validate_feature(feature: Feature, records: list[Registry]) -> None:
+def validate_feature(feature: Feature, records: list[Record]) -> None:
     """Validate feature record, adjust feature.dtype based on labels records."""
     if not isinstance(feature, Feature):
         raise TypeError("feature has to be of type Feature")
@@ -183,7 +183,7 @@ def get_labels(
     mute: bool = False,
     flat_names: bool = False,
 ) -> QuerySet | dict[str, QuerySet] | list:
-    """{}."""
+    """{}"""  # noqa: D415
     if not isinstance(feature, Feature):
         raise TypeError("feature has to be of type Feature")
     if feature.dtype is None or not feature.dtype.startswith("cat["):
@@ -210,7 +210,7 @@ def get_labels(
             ).all()
     if flat_names:
         # returns a flat list of names
-        from lamindb._registry import get_default_str_field
+        from lamindb._record import get_default_str_field
 
         values = []
         for v in qs_by_registry.values():
@@ -224,18 +224,18 @@ def get_labels(
 
 def add_labels(
     self,
-    records: Registry | list[Registry] | QuerySet | Iterable,
+    records: Record | list[Record] | QuerySet | Iterable,
     feature: Feature | None = None,
     *,
     field: StrField | None = None,
 ) -> None:
-    """{}."""
+    """{}"""  # noqa: D415
     if self._state.adding:
         raise ValueError("Please save the artifact/collection before adding a label!")
 
     if isinstance(records, (QuerySet, QuerySet.__base__)):  # need to have both
         records = records.list()
-    if isinstance(records, (str, Registry)):
+    if isinstance(records, (str, Record)):
         records = [records]
     if not isinstance(records, List):  # avoids warning for pd Series
         records = list(records)
@@ -260,7 +260,7 @@ def add_labels(
         # ask users to pass records
         if len(records_validated) == 0:
             raise ValueError(
-                "Please pass a record (a `Registry` object), not a string, e.g., via:"
+                "Please pass a record (a `Record` object), not a string, e.g., via:"
                 " label"
                 f" = ln.ULabel(name='{records[0]}')"  # type: ignore
             )

lamindb/core/_feature_manager.py

@@ -30,14 +30,14 @@ from lnschema_core.models import (
     ParamManagerArtifact,
     ParamManagerRun,
     ParamValue,
-    Registry,
+    Record,
     Run,
     ULabel,
 )
 
 from lamindb._feature import FEATURE_TYPES, convert_numpy_dtype_to_lamin_feature_type
 from lamindb._feature_set import DICT_KEYS_TYPE, FeatureSet
-from lamindb._registry import (
+from lamindb._record import (
     REGISTRY_UNIQUE_FIELD,
     get_default_str_field,
     transfer_fk_to_default_db_bulk,
@@ -118,7 +118,9 @@ def get_feature_set_links(host: Artifact | Collection) -> QuerySet:
 
 def get_link_attr(link: LinkORM | type[LinkORM], data: HasFeatures) -> str:
     link_model_name = link.__class__.__name__
-    if link_model_name == "ModelBase":  # we passed the type of the link
+    if (
+        link_model_name == "ModelBase" or link_model_name == "RecordMeta"
+    ):  # we passed the type of the link
         link_model_name = link.__name__
     link_attr = link_model_name.replace(data.__class__.__name__, "")
     if link_attr == "ExperimentalFactor":
@@ -162,6 +164,7 @@ def print_features(
                     labels_by_feature[link.feature_id].append(
                         getattr(link, link_attr).name
                     )
+        labels_msgs = []
         for feature_id, labels_list in labels_by_feature.items():
             feature = Feature.objects.using(self._state.db).get(id=feature_id)
             print_values = _print_values(labels_list, n=10)
@@ -170,8 +173,9 @@ def print_features(
                 dictionary[feature.name] = (
                     labels_list if len(labels_list) > 1 else labels_list[0]
                 )
-            labels_msg += f"    '{feature.name}'{type_str} = {print_values}\n"
-        if labels_msg:
+            labels_msgs.append(f"    '{feature.name}'{type_str} = {print_values}")
+        if len(labels_msgs) > 0:
+            labels_msg = "\n".join(sorted(labels_msgs)) + "\n"
             msg += labels_msg
 
     # non-categorical feature values
@@ -182,6 +186,7 @@ def print_features(
             getattr(self, f"{attr_name}_values")
             .values(f"{attr_name}__name", f"{attr_name}__dtype")
             .annotate(values=custom_aggregate("value", self._state.db))
+            .order_by(f"{attr_name}__name")
         )
         if len(feature_values) > 0:
             for fv in feature_values:
@@ -232,7 +237,7 @@ def parse_feature_sets_from_anndata(
     var_field: FieldAttr | None = None,
     obs_field: FieldAttr = Feature.name,
     mute: bool = False,
-    organism: str | Registry | None = None,
+    organism: str | Record | None = None,
 ) -> dict:
     data_parse = adata
     if not isinstance(adata, AnnData):  # is a path
@@ -322,7 +327,12 @@ def infer_feature_type_convert_json(
                         return FEATURE_TYPES["str"] + "[ULabel]", value
                     else:
                         return "list[str]", value
-    elif isinstance(value, Registry):
+                elif first_element_type == Record:
+                    return (
+                        f"cat[{first_element_type.__get_name_with_schema__()}]",
+                        value,
+                    )
+    elif isinstance(value, Record):
         return (f"cat[{value.__class__.__get_name_with_schema__()}]", value)
     if not mute:
         logger.warning(f"cannot infer feature type of: {value}, returning '?")
@@ -417,7 +427,7 @@ def _add_values(
     feature_param_field: FieldAttr,
     str_as_ulabel: bool = True,
 ) -> None:
-    """Annotate artifact with features & values.
+    """Curate artifact with features & values.
 
     Args:
         values: A dictionary of keys (features) & values (labels, numbers, booleans).
@@ -430,7 +440,7 @@ def _add_values(
     if isinstance(keys, DICT_KEYS_TYPE):
         keys = list(keys)  # type: ignore
     # deal with other cases later
-    assert all(isinstance(key, str) for key in keys)
+    assert all(isinstance(key, str) for key in keys)  # noqa: S101
     registry = feature_param_field.field.model
     is_param = registry == Param
     model = Param if is_param else Feature
@@ -483,10 +493,11 @@ def _add_values(
                     f"Value for feature '{key}' with type {feature.dtype} must be a number"
                 )
         elif feature.dtype.startswith("cat"):
-            if not (inferred_type.startswith("cat") or isinstance(value, Registry)):
-                raise TypeError(
-                    f"Value for feature '{key}' with type '{feature.dtype}' must be a string or record."
-                )
+            if inferred_type != "?":
+                if not (inferred_type.startswith("cat") or isinstance(value, Record)):
+                    raise TypeError(
+                        f"Value for feature '{key}' with type '{feature.dtype}' must be a string or record."
+                    )
         elif not inferred_type == feature.dtype:
             raise ValidationError(
                 f"Expected dtype for '{key}' is '{feature.dtype}', got '{inferred_type}'"
@@ -499,15 +510,21 @@ def _add_values(
                 feature_value = value_model(**filter_kwargs)
             feature_values.append(feature_value)
         else:
-            if isinstance(value, Registry):
-                if value._state.adding:
-                    raise ValidationError(
-                        "Please save your label record before annotation."
+            if isinstance(value, Record) or (
+                isinstance(value, Iterable) and isinstance(next(iter(value)), Record)
+            ):
+                if isinstance(value, Record):
+                    label_records = [value]
+                else:
+                    label_records = value  # type: ignore
+                for record in label_records:
+                    if record._state.adding:
+                        raise ValidationError(
+                            f"Please save {record} before annotation."
+                        )
+                    features_labels[record.__class__.__get_name_with_schema__()].append(
+                        (feature, record)
                     )
-                label_record = value
-                features_labels[
-                    label_record.__class__.__get_name_with_schema__()
-                ].append((feature, label_record))
             else:
                 if isinstance(value, str):
                     values = [value]  # type: ignore
@@ -589,7 +606,7 @@ def _add_values(
         links = [
             LinkORM(
                 **{
-                    f"{self._host.__get_name_with_schema__().lower()}_id": self._host.id,
+                    f"{self._host.__class__.__get_name_with_schema__().lower()}_id": self._host.id,
                     valuefield_id: feature_value.id,
                 }
             )
@@ -606,7 +623,7 @@ def add_values_features(
     feature_field: FieldAttr = Feature.name,
     str_as_ulabel: bool = True,
 ) -> None:
-    """Annotate artifact with features & values.
+    """Curate artifact with features & values.
 
     Args:
         values: A dictionary of keys (features) & values (labels, numbers, booleans).
@@ -621,7 +638,7 @@ def add_values_params(
     self,
     values: dict[str, str | int | float | bool],
 ) -> None:
-    """Annotate artifact with features & values.
+    """Curate artifact with features & values.
 
     Args:
         values: A dictionary of keys (features) & values (labels, numbers, booleans).
@@ -630,7 +647,7 @@ def add_values_params(
 
 
 def add_feature_set(self, feature_set: FeatureSet, slot: str) -> None:
-    """Annotate artifact with a feature set.
+    """Curate artifact with a feature set.
 
     Args:
         feature_set: `FeatureSet` A feature set record.
@@ -666,10 +683,10 @@ def _add_set_from_df(
 ):
     """Add feature set corresponding to column names of DataFrame."""
     if isinstance(self._host, Artifact):
-        assert self._host.accessor == "DataFrame"
+        assert self._host.accessor == "DataFrame"  # noqa: S101
     else:
         # Collection
-        assert self._host.artifact.accessor == "DataFrame"
+        assert self._host.artifact.accessor == "DataFrame"  # noqa: S101
 
     # parse and register features
     registry = field.field.model
@@ -693,11 +710,11 @@ def _add_set_from_anndata(
     var_field: FieldAttr,
     obs_field: FieldAttr | None = Feature.name,
     mute: bool = False,
-    organism: str | Registry | None = None,
+    organism: str | Record | None = None,
 ):
     """Add features from AnnData."""
     if isinstance(self._host, Artifact):
-        assert self._host.accessor == "AnnData"
+        assert self._host.accessor == "AnnData"  # noqa: S101
     else:
         raise NotImplementedError()
 
@@ -721,13 +738,13 @@ def _add_set_from_mudata(
     var_fields: dict[str, FieldAttr],
     obs_fields: dict[str, FieldAttr] = None,
     mute: bool = False,
-    organism: str | Registry | None = None,
+    organism: str | Record | None = None,
 ):
     """Add features from MuData."""
     if obs_fields is None:
         obs_fields = {}
     if isinstance(self._host, Artifact):
-        assert self._host.accessor == "MuData"
+        assert self._host.accessor == "MuData"  # noqa: S101
     else:
         raise NotImplementedError()
 
@@ -753,7 +770,7 @@ def _add_set_from_mudata(
     self._host.save()
 
 
-def _add_from(self, data: HasFeatures, parents: bool = True):
+def _add_from(self, data: HasFeatures):
     """Transfer features from a artifact or collection."""
     # This only covers feature sets, though.
     using_key = settings._using_key
@@ -765,23 +782,18 @@ def _add_from(self, data: HasFeatures, parents: bool = True):
         # note here the features are transferred based on an unique field
         field = REGISTRY_UNIQUE_FIELD.get(registry.__name__.lower(), "uid")
         # TODO: get a default ID field for the registry
-        if hasattr(registry, "ontology_id") and parents:
+        if hasattr(registry, "ontology_id"):
             field = "ontology_id"
         elif hasattr(registry, "ensembl_gene_id"):
             field = "ensembl_gene_id"
         elif hasattr(registry, "uniprotkb_id"):
             field = "uniprotkb_id"
-
-        if registry.__get_name_with_schema__() == "bionty.Organism":
-            parents = False
         # this will be e.g. be a list of ontology_ids or uids
         member_uids = list(members.values_list(field, flat=True))
-        # create records from ontology_id in order to populate parents
-        if field == "ontology_id" and len(member_uids) > 0 and parents:
+        # create records from ontology_id
+        if field == "ontology_id" and len(member_uids) > 0:
             # create from bionty
-            records = registry.from_values(member_uids, field=field)
-            if len(records) > 0:
-                save(records, parents=parents)
+            save(registry.from_values(member_uids, field=field))
         validated = registry.validate(member_uids, field=field, mute=True)
         new_members_uids = list(compress(member_uids, ~validated))
         new_members = members.filter(**{f"{field}__in": new_members_uids}).all()
@@ -797,7 +809,7 @@ def _add_from(self, data: HasFeatures, parents: bool = True):
                 # in the previous step transfer_fk_to_default_db_bulk
                 transfer_to_default_db(feature, using_key, mute=mute, transfer_fk=False)
             logger.info(f"saving {n_new_members} new {registry.__name__} records")
-            save(new_members, parents=parents)
+            save(new_members)
 
         # create a new feature set from feature values using the same uid
         feature_set_self = FeatureSet.from_values(

lamindb/core/_label_manager.py

@@ -8,7 +8,7 @@ from lamin_utils import colors, logger
 from lnschema_core.models import Feature
 
 from lamindb._from_values import _print_values
-from lamindb._registry import (
+from lamindb._record import (
     REGISTRY_UNIQUE_FIELD,
     get_default_str_field,
     transfer_fk_to_default_db_bulk,
@@ -20,7 +20,7 @@ from ._settings import settings
 from .schema import dict_related_model_to_related_name
 
 if TYPE_CHECKING:
-    from lnschema_core.models import Artifact, Collection, HasFeatures, Registry
+    from lnschema_core.models import Artifact, Collection, HasFeatures, Record
 
     from lamindb._query_set import QuerySet
 
@@ -66,7 +66,7 @@ def print_labels(self: HasFeatures, field: str = "name", print_types: bool = Fal
                 print_values = _print_values(labels_list, n=10)
                 type_str = f": {related_model}" if print_types else ""
                 labels_msg += f"    .{related_name}{type_str} = {print_values}\n"
-        except Exception:
+        except Exception:  # noqa: S112
             continue
     msg = ""
     if labels_msg:
@@ -76,33 +76,29 @@ def print_labels(self: HasFeatures, field: str = "name", print_types: bool = Fal
 
 
 # Alex: is this a label transfer function?
-def validate_labels(labels: QuerySet | list | dict, parents: bool = True):
+def validate_labels(labels: QuerySet | list | dict):
     def validate_labels_registry(
-        labels: QuerySet | list | dict, parents: bool = True
+        labels: QuerySet | list | dict,
     ) -> tuple[list[str], list[str]]:
         if len(labels) == 0:
             return [], []
         registry = labels[0].__class__
         field = REGISTRY_UNIQUE_FIELD.get(registry.__name__.lower(), "uid")
-        if hasattr(registry, "ontology_id") and parents:
+        if hasattr(registry, "ontology_id"):
             field = "ontology_id"
         elif hasattr(registry, "ensembl_gene_id"):
             field = "ensembl_gene_id"
         elif hasattr(registry, "uniprotkb_id"):
             field = "uniprotkb_id"
-        if registry.__get_name_with_schema__() == "bionty.Organism":
-            parents = False
         # if the field value is None, use uid field
         label_uids = np.array(
             [getattr(label, field) for label in labels if label is not None]
         )
-        # save labels from ontology_ids so that parents are populated
+        # save labels from ontology_ids
         if field == "ontology_id" and len(label_uids) > 0:
             try:
-                records = registry.from_values(label_uids, field=field)
-                if len(records) > 0:
-                    save(records, parents=parents)
-            except Exception:
+                save(registry.from_values(label_uids, field=field))
+            except Exception:  # noqa S110
                 pass
             field = "uid"
             label_uids = np.array(
@@ -117,11 +113,9 @@ def validate_labels(labels: QuerySet | list | dict, parents: bool = True):
     if isinstance(labels, Dict):
         result = {}
         for registry, labels_registry in labels.items():
-            result[registry] = validate_labels_registry(
-                labels_registry, parents=parents
-            )
+            result[registry] = validate_labels_registry(labels_registry)
     else:
-        return validate_labels_registry(labels, parents=parents)
+        return validate_labels_registry(labels)
 
 
 class LabelManager:
@@ -146,7 +140,7 @@ class LabelManager:
 
     def add(
         self,
-        records: Registry | list[Registry] | QuerySet,
+        records: Record | list[Record] | QuerySet,
         feature: Feature | None = None,
     ) -> None:
         """Add one or several labels and associate them with a feature.
@@ -176,7 +170,7 @@ class LabelManager:
 
         return get_labels(self._host, feature=feature, mute=mute, flat_names=flat_names)
 
-    def add_from(self, data: HasFeatures, parents: bool = True) -> None:
+    def add_from(self, data: HasFeatures) -> None:
         """Add labels from an artifact or collection to another artifact or collection.
 
         Examples:
@@ -202,7 +196,7 @@ class LabelManager:
                 data_name_lower = data.__class__.__name__.lower()
                 labels_by_features = defaultdict(list)
                 features = set()
-                _, new_labels = validate_labels(labels, parents=parents)
+                _, new_labels = validate_labels(labels)
                 if len(new_labels) > 0:
                     transfer_fk_to_default_db_bulk(new_labels, using_key)
                 for label in labels:
@@ -237,7 +231,7 @@ class LabelManager:
                         transfer_to_default_db(
                             feature, using_key, mute=True, transfer_fk=False
                         )
-                    save(new_features, parents=parents)
+                    save(new_features)
                 if hasattr(self._host, related_name):
                     for feature_name, labels in labels_by_features.items():
                         if feature_name is not None:

lamindb/core/_mapped_collection.py

@@ -107,7 +107,10 @@ class MappedCollection:
         parallel: bool = False,
         dtype: str | None = None,
     ):
-        assert join in {None, "inner", "outer"}
+        if join not in {None, "inner", "outer"}:  # pragma: nocover
+            raise ValueError(
+                f"join must be one of None, 'inner, or 'outer' but was {type(join)}"
+            )
 
         if layers_keys is None:
             self.layers_keys = ["X"]