karaoke-gen 0.99.3__py3-none-any.whl → 0.103.1__py3-none-any.whl

backend/tests/test_admin_job_update.py

@@ -0,0 +1,326 @@
+"""
+Unit tests for admin job update endpoint.
+
+Tests the PATCH /api/admin/jobs/{job_id} endpoint that allows admins
+to update editable job fields.
+"""
+import pytest
+from unittest.mock import Mock, patch
+from fastapi.testclient import TestClient
+from fastapi import FastAPI
+
+from backend.api.routes.admin import router
+from backend.api.dependencies import require_admin
+from backend.models.job import Job, JobStatus
+
+
+# Create a test app with the admin router
+app = FastAPI()
+app.include_router(router, prefix="/api")
+
+
+def get_mock_admin():
+    """Override for require_admin dependency."""
+    from backend.api.dependencies import AuthResult, UserType
+    return AuthResult(
+        is_valid=True,
+        user_type=UserType.ADMIN,
+        remaining_uses=999,
+        message="Admin authenticated",
+        user_email="admin@example.com",
+        is_admin=True,
+    )
+
+
+# Override the require_admin dependency
+app.dependency_overrides[require_admin] = get_mock_admin
+
+
+@pytest.fixture
+def client():
+    """Create a test client."""
+    return TestClient(app)
+
+
+@pytest.fixture
+def mock_job():
+    """Create a mock job for testing."""
+    job = Mock(spec=Job)
+    job.job_id = "test-job-123"
+    job.user_email = "user@example.com"
+    job.artist = "Original Artist"
+    job.title = "Original Title"
+    job.status = JobStatus.AWAITING_REVIEW
+    job.theme_id = "nomad"
+    job.enable_cdg = False
+    job.enable_txt = False
+    job.enable_youtube_upload = True
+    job.customer_email = None
+    job.customer_notes = None
+    job.brand_prefix = None
+    job.non_interactive = False
+    job.prep_only = False
+    job.discord_webhook_url = None
+    job.youtube_description = None
+    job.youtube_description_template = None
+    job.file_urls = {}
+    job.state_data = {}
+    job.created_at = "2026-01-09T10:00:00Z"
+    job.updated_at = "2026-01-09T10:30:00Z"
+    return job
+
+
+class TestUpdateJob:
+    """Tests for PATCH /api/admin/jobs/{job_id} endpoint."""
+
+    def test_update_artist_field(self, client, mock_job):
+        """Test updating the artist field."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm.update_job.return_value = True
+            mock_jm_class.return_value = mock_jm
+
+            response = client.patch(
+                "/api/admin/jobs/test-job-123",
+                json={"artist": "New Artist"},
+                headers={"Authorization": "Bearer admin-token"}
+            )
+
+            assert response.status_code == 200
+            data = response.json()
+            assert data["status"] == "success"
+            assert data["job_id"] == "test-job-123"
+            assert "artist" in data["updated_fields"]
+
+            # Verify update_job was called with correct args
+            mock_jm.update_job.assert_called_once()
+            call_args = mock_jm.update_job.call_args
+            assert call_args[0][0] == "test-job-123"
+            assert call_args[0][1]["artist"] == "New Artist"
+
+    def test_update_multiple_fields(self, client, mock_job):
+        """Test updating multiple fields at once."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm.update_job.return_value = True
+            mock_jm_class.return_value = mock_jm
+
+            response = client.patch(
+                "/api/admin/jobs/test-job-123",
+                json={
+                    "artist": "New Artist",
+                    "title": "New Title",
+                    "theme_id": "default",
+                    "enable_cdg": True,
+                },
+            )
+
+            assert response.status_code == 200
+            data = response.json()
+            assert len(data["updated_fields"]) == 4
+            assert "artist" in data["updated_fields"]
+            assert "title" in data["updated_fields"]
+            assert "theme_id" in data["updated_fields"]
+            assert "enable_cdg" in data["updated_fields"]
+
+    def test_update_user_email(self, client, mock_job):
+        """Test updating user_email field."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm.update_job.return_value = True
+            mock_jm_class.return_value = mock_jm
+
+            response = client.patch(
+                "/api/admin/jobs/test-job-123",
+                json={"user_email": "newuser@example.com"},
+            )
+
+            assert response.status_code == 200
+            call_args = mock_jm.update_job.call_args
+            assert call_args[0][1]["user_email"] == "newuser@example.com"
+
+    def test_update_boolean_fields(self, client, mock_job):
+        """Test updating boolean fields."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm.update_job.return_value = True
+            mock_jm_class.return_value = mock_jm
+
+            response = client.patch(
+                "/api/admin/jobs/test-job-123",
+                json={
+                    "enable_cdg": True,
+                    "enable_txt": True,
+                    "enable_youtube_upload": False,
+                    "non_interactive": True,
+                    "prep_only": True,
+                },
+            )
+
+            assert response.status_code == 200
+            call_args = mock_jm.update_job.call_args
+            assert call_args[0][1]["enable_cdg"] is True
+            assert call_args[0][1]["enable_txt"] is True
+            assert call_args[0][1]["enable_youtube_upload"] is False
+
+    def test_rejects_non_editable_job_id(self, client, mock_job):
+        """Test that job_id cannot be updated."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm_class.return_value = mock_jm
+
+            response = client.patch(
+                "/api/admin/jobs/test-job-123",
+                json={"job_id": "new-job-id"},
+            )
+
+            assert response.status_code == 400
+            assert "not editable" in response.json()["detail"].lower()
+
+    def test_rejects_non_editable_created_at(self, client, mock_job):
+        """Test that created_at cannot be updated."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm_class.return_value = mock_jm
+
+            response = client.patch(
+                "/api/admin/jobs/test-job-123",
+                json={"created_at": "2025-01-01T00:00:00Z"},
+            )
+
+            assert response.status_code == 400
+            assert "not editable" in response.json()["detail"].lower()
+
+    def test_rejects_status_update(self, client, mock_job):
+        """Test that status cannot be updated via PATCH (use reset endpoint)."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm_class.return_value = mock_jm
+
+            response = client.patch(
+                "/api/admin/jobs/test-job-123",
+                json={"status": "complete"},
+            )
+
+            assert response.status_code == 400
+            assert "not editable" in response.json()["detail"].lower()
+
+    def test_rejects_state_data_update(self, client, mock_job):
+        """Test that state_data cannot be updated directly."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm_class.return_value = mock_jm
+
+            response = client.patch(
+                "/api/admin/jobs/test-job-123",
+                json={"state_data": {"foo": "bar"}},
+            )
+
+            assert response.status_code == 400
+            assert "not editable" in response.json()["detail"].lower()
+
+    def test_returns_404_when_job_not_found(self, client):
+        """Test 404 when job doesn't exist."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = None
+            mock_jm_class.return_value = mock_jm
+
+            response = client.patch(
+                "/api/admin/jobs/nonexistent-job",
+                json={"artist": "New Artist"},
+            )
+
+            assert response.status_code == 404
+            assert "not found" in response.json()["detail"].lower()
+
+    def test_returns_400_for_empty_update(self, client, mock_job):
+        """Test 400 when no valid fields are provided."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm_class.return_value = mock_jm
+
+            response = client.patch(
+                "/api/admin/jobs/test-job-123",
+                json={},
+            )
+
+            assert response.status_code == 400
+            assert "no valid" in response.json()["detail"].lower()
+
+    def test_logs_admin_changes(self, client, mock_job):
+        """Test that admin changes are logged."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class, \
+             patch('backend.api.routes.admin.logger') as mock_logger:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm.update_job.return_value = True
+            mock_jm_class.return_value = mock_jm
+
+            response = client.patch(
+                "/api/admin/jobs/test-job-123",
+                json={"artist": "New Artist"},
+            )
+
+            assert response.status_code == 200
+            # Verify logging was called
+            mock_logger.info.assert_called()
+            log_message = mock_logger.info.call_args[0][0]
+            assert "admin@example.com" in log_message.lower() or "admin" in log_message.lower()
+
+    def test_update_customer_fields(self, client, mock_job):
+        """Test updating made-for-you customer fields."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm.update_job.return_value = True
+            mock_jm_class.return_value = mock_jm
+
+            response = client.patch(
+                "/api/admin/jobs/test-job-123",
+                json={
+                    "customer_email": "customer@example.com",
+                    "customer_notes": "Special request: add extra countdown",
+                },
+            )
+
+            assert response.status_code == 200
+            call_args = mock_jm.update_job.call_args
+            assert call_args[0][1]["customer_email"] == "customer@example.com"
+            assert call_args[0][1]["customer_notes"] == "Special request: add extra countdown"
+
+
+class TestUpdateJobAuthorization:
+    """Tests for authorization on the update endpoint."""
+
+    def test_requires_admin_access(self, client, mock_job):
+        """Test that non-admin users cannot access the endpoint."""
+        original_override = app.dependency_overrides.get(require_admin)
+
+        def get_non_admin():
+            from fastapi import HTTPException
+            raise HTTPException(status_code=403, detail="Admin access required")
+
+        app.dependency_overrides[require_admin] = get_non_admin
+
+        try:
+            response = client.patch(
+                "/api/admin/jobs/test-job-123",
+                json={"artist": "New Artist"},
+                headers={"Authorization": "Bearer user-token"}
+            )
+            assert response.status_code == 403
+        finally:
+            if original_override:
+                app.dependency_overrides[require_admin] = original_override
+            else:
+                app.dependency_overrides[require_admin] = get_mock_admin

backend/tests/test_audio_search.py

@@ -845,7 +845,8 @@ class TestAudioSearchThemeSupport:
         This is the key behavior: selecting a theme should automatically
         enable CDG and TXT output formats.
         """
-        from backend.api.routes.audio_search import AudioSearchRequest, _resolve_cdg_txt_defaults
+        from backend.api.routes.audio_search import AudioSearchRequest
+        from backend.services.job_defaults_service import resolve_cdg_txt_defaults
 
         # When theme_id is set, enable_cdg/enable_txt should default to True
         request = AudioSearchRequest(
@@ -855,7 +856,7 @@ class TestAudioSearchThemeSupport:
             # enable_cdg and enable_txt are None (not specified)
         )
 
-        resolved_cdg, resolved_txt = _resolve_cdg_txt_defaults(
+        resolved_cdg, resolved_txt = resolve_cdg_txt_defaults(
             request.theme_id, request.enable_cdg, request.enable_txt
         )
 
@@ -864,7 +865,8 @@ class TestAudioSearchThemeSupport:
 
     def test_audio_search_request_no_theme_no_cdg_txt(self):
         """Test that without theme_id, CDG/TXT defaults to disabled."""
-        from backend.api.routes.audio_search import AudioSearchRequest, _resolve_cdg_txt_defaults
+        from backend.api.routes.audio_search import AudioSearchRequest
+        from backend.services.job_defaults_service import resolve_cdg_txt_defaults
 
         request = AudioSearchRequest(
             artist="Test Artist",
@@ -872,7 +874,7 @@ class TestAudioSearchThemeSupport:
             # No theme_id, no enable_cdg, no enable_txt
         )
 
-        resolved_cdg, resolved_txt = _resolve_cdg_txt_defaults(
+        resolved_cdg, resolved_txt = resolve_cdg_txt_defaults(
             request.theme_id, request.enable_cdg, request.enable_txt
         )
 
@@ -881,7 +883,8 @@ class TestAudioSearchThemeSupport:
 
     def test_explicit_cdg_txt_overrides_theme_default(self):
         """Test that explicit enable_cdg/enable_txt values override theme defaults."""
-        from backend.api.routes.audio_search import AudioSearchRequest, _resolve_cdg_txt_defaults
+        from backend.api.routes.audio_search import AudioSearchRequest
+        from backend.services.job_defaults_service import resolve_cdg_txt_defaults
 
         # Theme set (would default to True), but explicitly disabled
         request = AudioSearchRequest(
@@ -892,7 +895,7 @@ class TestAudioSearchThemeSupport:
             enable_txt=False,
         )
 
-        resolved_cdg, resolved_txt = _resolve_cdg_txt_defaults(
+        resolved_cdg, resolved_txt = resolve_cdg_txt_defaults(
             request.theme_id, request.enable_cdg, request.enable_txt
         )
 
@@ -901,7 +904,8 @@ class TestAudioSearchThemeSupport:
 
     def test_explicit_cdg_txt_enables_without_theme(self):
         """Test that explicit True enables CDG/TXT even without theme."""
-        from backend.api.routes.audio_search import AudioSearchRequest, _resolve_cdg_txt_defaults
+        from backend.api.routes.audio_search import AudioSearchRequest
+        from backend.services.job_defaults_service import resolve_cdg_txt_defaults
 
         # No theme (would default to False), but explicitly enabled
         request = AudioSearchRequest(
@@ -911,7 +915,7 @@ class TestAudioSearchThemeSupport:
             enable_txt=True,
         )
 
-        resolved_cdg, resolved_txt = _resolve_cdg_txt_defaults(
+        resolved_cdg, resolved_txt = resolve_cdg_txt_defaults(
             request.theme_id, request.enable_cdg, request.enable_txt
         )
 

backend/tests/test_email_service.py

@@ -490,3 +490,236 @@ class TestCCFunctionality:
 
                 # Verify add_cc was called
                 mock_mail.add_cc.assert_called()
+
+
+class TestMadeForYouOrderConfirmation:
+    """Tests for send_made_for_you_order_confirmation method."""
+
+    def test_send_order_confirmation_success(self):
+        """Test successful order confirmation email."""
+        service = EmailService()
+        service.provider = Mock()
+        service.provider.send_email.return_value = True
+
+        result = service.send_made_for_you_order_confirmation(
+            to_email="customer@example.com",
+            artist="Test Artist",
+            title="Test Song",
+            job_id="test-job-123",
+        )
+
+        assert result is True
+        service.provider.send_email.assert_called_once()
+        # Verify BCC is set
+        call_kwargs = service.provider.send_email.call_args.kwargs
+        assert call_kwargs.get('bcc_emails') == ["done@nomadkaraoke.com"]
+
+    def test_send_order_confirmation_subject_format(self):
+        """Test order confirmation has correct subject format."""
+        service = EmailService()
+        service.provider = Mock()
+        service.provider.send_email.return_value = True
+
+        service.send_made_for_you_order_confirmation(
+            to_email="customer@example.com",
+            artist="Seether",
+            title="Tonight",
+            job_id="test-job-456",
+        )
+
+        call_kwargs = service.provider.send_email.call_args.kwargs
+        subject = call_kwargs.get('subject')
+        assert "Order Confirmed" in subject
+        assert "Seether" in subject
+        assert "Tonight" in subject
+
+    def test_send_order_confirmation_with_notes(self):
+        """Test order confirmation includes notes."""
+        service = EmailService()
+        service.provider = Mock()
+        service.provider.send_email.return_value = True
+
+        service.send_made_for_you_order_confirmation(
+            to_email="customer@example.com",
+            artist="Test Artist",
+            title="Test Song",
+            job_id="test-job-789",
+            notes="Wedding anniversary!",
+        )
+
+        call_kwargs = service.provider.send_email.call_args.kwargs
+        html_content = call_kwargs.get('html_content')
+        assert "Wedding anniversary!" in html_content
+
+    def test_send_order_confirmation_includes_delivery_promise(self):
+        """Test order confirmation mentions delivery timeframe."""
+        service = EmailService()
+        service.provider = Mock()
+        service.provider.send_email.return_value = True
+
+        service.send_made_for_you_order_confirmation(
+            to_email="customer@example.com",
+            artist="Test Artist",
+            title="Test Song",
+            job_id="test-job-abc",
+        )
+
+        call_kwargs = service.provider.send_email.call_args.kwargs
+        html_content = call_kwargs.get('html_content', '')
+        text_content = call_kwargs.get('text_content', '')
+        # Should mention delivery timeline
+        assert "24" in html_content or "24" in text_content
+
+    def test_send_order_confirmation_failure(self):
+        """Test handling of email send failure."""
+        service = EmailService()
+        service.provider = Mock()
+        service.provider.send_email.return_value = False
+
+        result = service.send_made_for_you_order_confirmation(
+            to_email="customer@example.com",
+            artist="Test Artist",
+            title="Test Song",
+            job_id="test-job-def",
+        )
+
+        assert result is False
+
+
+class TestMadeForYouAdminNotification:
+    """Tests for send_made_for_you_admin_notification method."""
+
+    def test_send_admin_notification_success(self):
+        """Test successful admin notification email."""
+        service = EmailService()
+        service.provider = Mock()
+        service.provider.send_email.return_value = True
+
+        result = service.send_made_for_you_admin_notification(
+            to_email="admin@nomadkaraoke.com",
+            customer_email="customer@example.com",
+            artist="Test Artist",
+            title="Test Song",
+            job_id="job-123",
+            admin_login_token="test-token-abc",
+        )
+
+        assert result is True
+        service.provider.send_email.assert_called_once()
+
+    def test_send_admin_notification_subject_format(self):
+        """Test admin notification has correct subject format."""
+        service = EmailService()
+        service.provider = Mock()
+        service.provider.send_email.return_value = True
+
+        service.send_made_for_you_admin_notification(
+            to_email="admin@nomadkaraoke.com",
+            customer_email="customer@example.com",
+            artist="Seether",
+            title="Tonight",
+            job_id="job-123",
+            admin_login_token="test-token-abc",
+        )
+
+        call_kwargs = service.provider.send_email.call_args.kwargs
+        subject = call_kwargs.get('subject')
+        # Subject format: "Karaoke Order: {artist} - {title} [ID: {job_id}]"
+        assert "Karaoke Order" in subject
+        assert "Seether" in subject
+        assert "Tonight" in subject
+
+    def test_send_admin_notification_includes_customer_email(self):
+        """Test admin notification includes customer email."""
+        service = EmailService()
+        service.provider = Mock()
+        service.provider.send_email.return_value = True
+
+        service.send_made_for_you_admin_notification(
+            to_email="admin@nomadkaraoke.com",
+            customer_email="vip@example.com",
+            artist="Test Artist",
+            title="Test Song",
+            job_id="job-123",
+            admin_login_token="test-token-abc",
+        )
+
+        call_kwargs = service.provider.send_email.call_args.kwargs
+        html_content = call_kwargs.get('html_content')
+        assert "vip@example.com" in html_content
+
+    def test_send_admin_notification_includes_job_link(self):
+        """Test admin notification includes job link."""
+        service = EmailService()
+        service.provider = Mock()
+        service.provider.send_email.return_value = True
+
+        service.send_made_for_you_admin_notification(
+            to_email="admin@nomadkaraoke.com",
+            customer_email="customer@example.com",
+            artist="Test Artist",
+            title="Test Song",
+            job_id="abc-def-123",
+            admin_login_token="test-token-abc",
+        )
+
+        call_kwargs = service.provider.send_email.call_args.kwargs
+        html_content = call_kwargs.get('html_content')
+        assert "abc-def-123" in html_content
+
+    def test_send_admin_notification_includes_audio_count(self):
+        """Test admin notification includes audio source count."""
+        service = EmailService()
+        service.provider = Mock()
+        service.provider.send_email.return_value = True
+
+        service.send_made_for_you_admin_notification(
+            to_email="admin@nomadkaraoke.com",
+            customer_email="customer@example.com",
+            artist="Test Artist",
+            title="Test Song",
+            job_id="job-123",
+            admin_login_token="test-token-abc",
+            audio_source_count=5,
+        )
+
+        call_kwargs = service.provider.send_email.call_args.kwargs
+        html_content = call_kwargs.get('html_content')
+        assert "5" in html_content
+
+    def test_send_admin_notification_includes_notes(self):
+        """Test admin notification includes customer notes."""
+        service = EmailService()
+        service.provider = Mock()
+        service.provider.send_email.return_value = True
+
+        service.send_made_for_you_admin_notification(
+            to_email="admin@nomadkaraoke.com",
+            customer_email="customer@example.com",
+            artist="Test Artist",
+            title="Test Song",
+            job_id="job-123",
+            admin_login_token="test-token-abc",
+            notes="Rush order please!",
+        )
+
+        call_kwargs = service.provider.send_email.call_args.kwargs
+        html_content = call_kwargs.get('html_content')
+        assert "Rush order please!" in html_content
+
+    def test_send_admin_notification_failure(self):
+        """Test handling of email send failure."""
+        service = EmailService()
+        service.provider = Mock()
+        service.provider.send_email.return_value = False
+
+        result = service.send_made_for_you_admin_notification(
+            to_email="admin@nomadkaraoke.com",
+            customer_email="customer@example.com",
+            artist="Test Artist",
+            title="Test Song",
+            job_id="job-123",
+            admin_login_token="test-token-abc",
+        )
+
+        assert result is False