karaoke-gen 0.99.3__py3-none-any.whl → 0.101.0__py3-none-any.whl

backend/tests/test_admin_job_reset.py

@@ -0,0 +1,384 @@
+"""
+Unit tests for admin job reset endpoint.
+
+Tests the POST /api/admin/jobs/{job_id}/reset endpoint that allows admins
+to reset a job to a specific state for re-processing.
+"""
+import pytest
+from unittest.mock import Mock, patch
+from fastapi.testclient import TestClient
+from fastapi import FastAPI
+from datetime import datetime
+
+from backend.api.routes.admin import router
+from backend.api.dependencies import require_admin
+from backend.models.job import Job, JobStatus
+
+
+# Create a test app with the admin router
+app = FastAPI()
+app.include_router(router, prefix="/api")
+
+
+def get_mock_admin():
+    """Override for require_admin dependency."""
+    from backend.api.dependencies import AuthResult, UserType
+    return AuthResult(
+        is_valid=True,
+        user_type=UserType.ADMIN,
+        remaining_uses=999,
+        message="Admin authenticated",
+        user_email="admin@example.com",
+        is_admin=True,
+    )
+
+
+# Override the require_admin dependency
+app.dependency_overrides[require_admin] = get_mock_admin
+
+
+@pytest.fixture
+def client():
+    """Create a test client."""
+    return TestClient(app)
+
+
+@pytest.fixture
+def mock_job():
+    """Create a mock job in COMPLETE status for testing."""
+    job = Mock(spec=Job)
+    job.job_id = "test-job-123"
+    job.user_email = "user@example.com"
+    job.artist = "Test Artist"
+    job.title = "Test Title"
+    job.status = JobStatus.COMPLETE
+    job.theme_id = "nomad"
+    job.file_urls = {
+        "input": "gs://bucket/input.flac",
+        "stems": {
+            "instrumental_clean": "gs://bucket/stems/clean.flac",
+        },
+        "lyrics": {
+            "corrections": "gs://bucket/lyrics/corrections.json",
+        },
+    }
+    job.state_data = {
+        "audio_search_results": [{"provider": "test"}],
+        "audio_selection": {"index": 0},
+        "review_complete": True,
+        "corrected_lyrics": {"lines": []},
+        "instrumental_selection": "clean",
+        "brand_code": "NOMAD-1234",
+    }
+    job.timeline = []
+    job.created_at = datetime(2026, 1, 9, 10, 0, 0)
+    job.updated_at = datetime(2026, 1, 9, 12, 0, 0)
+    return job
+
+
+class TestResetJobToPending:
+    """Tests for resetting job to PENDING state."""
+
+    def test_reset_to_pending_success(self, client, mock_job):
+        """Test resetting a job to PENDING state."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm.update_job.return_value = True
+            mock_jm_class.return_value = mock_jm
+
+            response = client.post(
+                "/api/admin/jobs/test-job-123/reset",
+                json={"target_state": "pending"},
+            )
+
+            assert response.status_code == 200
+            data = response.json()
+            assert data["status"] == "success"
+            assert data["job_id"] == "test-job-123"
+            assert data["new_status"] == "pending"
+            assert "pending" in data["message"].lower()
+
+    def test_reset_to_pending_clears_state_data(self, client, mock_job):
+        """Test that resetting to PENDING clears appropriate state_data keys."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm.update_job.return_value = True
+            mock_jm_class.return_value = mock_jm
+
+            response = client.post(
+                "/api/admin/jobs/test-job-123/reset",
+                json={"target_state": "pending"},
+            )
+
+            assert response.status_code == 200
+            # Verify update_job was called with cleared state_data keys
+            call_args = mock_jm.update_job.call_args
+            update_data = call_args[0][1]
+            # Verify status was set
+            assert update_data["status"] == "pending"
+
+
+class TestResetJobToAwaitingAudioSelection:
+    """Tests for resetting job to AWAITING_AUDIO_SELECTION state."""
+
+    def test_reset_to_awaiting_audio_selection(self, client, mock_job):
+        """Test resetting a job to AWAITING_AUDIO_SELECTION state."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm.update_job.return_value = True
+            mock_jm_class.return_value = mock_jm
+
+            response = client.post(
+                "/api/admin/jobs/test-job-123/reset",
+                json={"target_state": "awaiting_audio_selection"},
+            )
+
+            assert response.status_code == 200
+            data = response.json()
+            assert data["new_status"] == "awaiting_audio_selection"
+
+
+class TestResetJobToAwaitingReview:
+    """Tests for resetting job to AWAITING_REVIEW state."""
+
+    def test_reset_to_awaiting_review(self, client, mock_job):
+        """Test resetting a job to AWAITING_REVIEW state."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm.update_job.return_value = True
+            mock_jm_class.return_value = mock_jm
+
+            response = client.post(
+                "/api/admin/jobs/test-job-123/reset",
+                json={"target_state": "awaiting_review"},
+            )
+
+            assert response.status_code == 200
+            data = response.json()
+            assert data["new_status"] == "awaiting_review"
+
+
+class TestResetJobToAwaitingInstrumentalSelection:
+    """Tests for resetting job to AWAITING_INSTRUMENTAL_SELECTION state."""
+
+    def test_reset_to_awaiting_instrumental_selection(self, client, mock_job):
+        """Test resetting a job to AWAITING_INSTRUMENTAL_SELECTION state."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm.update_job.return_value = True
+            mock_jm_class.return_value = mock_jm
+
+            response = client.post(
+                "/api/admin/jobs/test-job-123/reset",
+                json={"target_state": "awaiting_instrumental_selection"},
+            )
+
+            assert response.status_code == 200
+            data = response.json()
+            assert data["new_status"] == "awaiting_instrumental_selection"
+
+
+class TestResetJobValidation:
+    """Tests for reset endpoint validation."""
+
+    def test_rejects_invalid_target_state(self, client, mock_job):
+        """Test that invalid target states are rejected."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm_class.return_value = mock_jm
+
+            response = client.post(
+                "/api/admin/jobs/test-job-123/reset",
+                json={"target_state": "encoding"},
+            )
+
+            assert response.status_code == 400
+            assert "invalid" in response.json()["detail"].lower() or "not allowed" in response.json()["detail"].lower()
+
+    def test_rejects_complete_as_target(self, client, mock_job):
+        """Test that COMPLETE is not a valid reset target."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm_class.return_value = mock_jm
+
+            response = client.post(
+                "/api/admin/jobs/test-job-123/reset",
+                json={"target_state": "complete"},
+            )
+
+            assert response.status_code == 400
+
+    def test_rejects_failed_as_target(self, client, mock_job):
+        """Test that FAILED is not a valid reset target."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm_class.return_value = mock_jm
+
+            response = client.post(
+                "/api/admin/jobs/test-job-123/reset",
+                json={"target_state": "failed"},
+            )
+
+            assert response.status_code == 400
+
+    def test_returns_404_when_job_not_found(self, client):
+        """Test 404 when job doesn't exist."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = None
+            mock_jm_class.return_value = mock_jm
+
+            response = client.post(
+                "/api/admin/jobs/nonexistent-job/reset",
+                json={"target_state": "pending"},
+            )
+
+            assert response.status_code == 404
+            assert "not found" in response.json()["detail"].lower()
+
+    def test_rejects_missing_target_state(self, client, mock_job):
+        """Test that target_state is required."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm_class.return_value = mock_jm
+
+            response = client.post(
+                "/api/admin/jobs/test-job-123/reset",
+                json={},
+            )
+
+            assert response.status_code == 422  # Validation error
+
+
+class TestResetJobLogging:
+    """Tests for logging on the reset endpoint."""
+
+    def test_logs_admin_reset_action(self, client, mock_job):
+        """Test that admin reset actions are logged."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class, \
+             patch('backend.api.routes.admin.logger') as mock_logger:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm.update_job.return_value = True
+            mock_jm_class.return_value = mock_jm
+
+            response = client.post(
+                "/api/admin/jobs/test-job-123/reset",
+                json={"target_state": "pending"},
+            )
+
+            assert response.status_code == 200
+            # Verify logging was called
+            mock_logger.info.assert_called()
+            log_message = mock_logger.info.call_args[0][0]
+            assert "admin" in log_message.lower() or "reset" in log_message.lower()
+
+
+class TestResetJobTimeline:
+    """Tests for timeline event on reset."""
+
+    def test_adds_timeline_event_on_reset(self, client, mock_job):
+        """Test that a timeline event is added when job is reset."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm.update_job.return_value = True
+            mock_jm_class.return_value = mock_jm
+
+            response = client.post(
+                "/api/admin/jobs/test-job-123/reset",
+                json={"target_state": "awaiting_review"},
+            )
+
+            assert response.status_code == 200
+            data = response.json()
+            # Timeline event should be included in response
+            assert "timeline_event" in data or data.get("message")
+
+
+class TestResetJobAuthorization:
+    """Tests for authorization on the reset endpoint."""
+
+    def test_requires_admin_access(self, client, mock_job):
+        """Test that non-admin users cannot access the endpoint."""
+        original_override = app.dependency_overrides.get(require_admin)
+
+        def get_non_admin():
+            from fastapi import HTTPException
+            raise HTTPException(status_code=403, detail="Admin access required")
+
+        app.dependency_overrides[require_admin] = get_non_admin
+
+        try:
+            response = client.post(
+                "/api/admin/jobs/test-job-123/reset",
+                json={"target_state": "pending"},
+                headers={"Authorization": "Bearer user-token"}
+            )
+            assert response.status_code == 403
+        finally:
+            if original_override:
+                app.dependency_overrides[require_admin] = original_override
+            else:
+                app.dependency_overrides[require_admin] = get_mock_admin
+
+
+class TestResetJobClearsStateData:
+    """Tests for state_data clearing based on target state."""
+
+    def test_reset_to_pending_clears_all_processing_data(self, client, mock_job):
+        """Test that resetting to PENDING clears audio search results."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm.update_job.return_value = True
+            mock_jm_class.return_value = mock_jm
+
+            response = client.post(
+                "/api/admin/jobs/test-job-123/reset",
+                json={"target_state": "pending"},
+            )
+
+            assert response.status_code == 200
+            # The cleared_data field should list what was cleared
+            data = response.json()
+            assert "cleared_data" in data or "state_data" in str(data)
+
+    def test_reset_to_awaiting_review_preserves_audio_data(self, client, mock_job):
+        """Test that resetting to AWAITING_REVIEW preserves audio stems."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm.update_job.return_value = True
+            mock_jm_class.return_value = mock_jm
+
+            response = client.post(
+                "/api/admin/jobs/test-job-123/reset",
+                json={"target_state": "awaiting_review"},
+            )
+
+            assert response.status_code == 200
+
+    def test_reset_to_instrumental_preserves_review_data(self, client, mock_job):
+        """Test that resetting to AWAITING_INSTRUMENTAL_SELECTION preserves review data."""
+        with patch('backend.api.routes.admin.JobManager') as mock_jm_class:
+            mock_jm = Mock()
+            mock_jm.get_job.return_value = mock_job
+            mock_jm.update_job.return_value = True
+            mock_jm_class.return_value = mock_jm
+
+            response = client.post(
+                "/api/admin/jobs/test-job-123/reset",
+                json={"target_state": "awaiting_instrumental_selection"},
+            )
+
+            assert response.status_code == 200