karaoke-gen 0.86.7__py3-none-any.whl → 0.96.0__py3-none-any.whl

backend/tests/test_gdrive_service.py

@@ -0,0 +1,524 @@
+"""
+Tests for gdrive_service.py - Google Drive file operations.
+
+These tests mock the Google API client and Secret Manager to verify:
+- Credential loading from Secret Manager
+- Folder creation and lookup
+- File uploads with proper MIME types
+- Public share folder structure uploads
+"""
+import json
+import os
+import pytest
+from unittest.mock import Mock, MagicMock, patch
+
+
+class TestGoogleDriveServiceInit:
+    """Test GoogleDriveService initialization."""
+    
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_init_creates_service(self, mock_get_settings):
+        """Test initialization creates service with settings."""
+        from backend.services.gdrive_service import GoogleDriveService
+        
+        mock_settings = Mock()
+        mock_get_settings.return_value = mock_settings
+        
+        service = GoogleDriveService()
+        
+        assert service.settings == mock_settings
+        assert service._service is None
+        assert service._credentials_data is None
+        assert service._loaded is False
+
+
+class TestLoadCredentials:
+    """Test _load_credentials method."""
+    
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_load_credentials_success(self, mock_get_settings):
+        """Test successful credential loading from Secret Manager."""
+        from backend.services.gdrive_service import GoogleDriveService
+        
+        mock_settings = Mock()
+        mock_settings.get_secret.return_value = json.dumps({
+            "token": "access-token",
+            "refresh_token": "refresh-token",
+            "client_id": "client-id",
+            "client_secret": "client-secret",
+        })
+        mock_get_settings.return_value = mock_settings
+        
+        service = GoogleDriveService()
+        creds = service._load_credentials()
+        
+        assert creds is not None
+        assert creds["refresh_token"] == "refresh-token"
+        mock_settings.get_secret.assert_called_once_with("gdrive-oauth-credentials")
+    
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_load_credentials_fallback_to_youtube(self, mock_get_settings):
+        """Test fallback to YouTube credentials when Drive creds not found."""
+        from backend.services.gdrive_service import GoogleDriveService
+        
+        mock_settings = Mock()
+        # First call returns None (Drive creds not found)
+        # Second call returns YouTube creds
+        mock_settings.get_secret.side_effect = [
+            None,
+            json.dumps({
+                "refresh_token": "youtube-token",
+                "client_id": "youtube-id",
+                "client_secret": "youtube-secret",
+            })
+        ]
+        mock_get_settings.return_value = mock_settings
+        
+        service = GoogleDriveService()
+        creds = service._load_credentials()
+        
+        assert creds is not None
+        assert creds["refresh_token"] == "youtube-token"
+        assert mock_settings.get_secret.call_count == 2
+    
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_load_credentials_not_found(self, mock_get_settings):
+        """Test handling when no credentials found."""
+        from backend.services.gdrive_service import GoogleDriveService
+        
+        mock_settings = Mock()
+        mock_settings.get_secret.return_value = None
+        mock_get_settings.return_value = mock_settings
+        
+        service = GoogleDriveService()
+        creds = service._load_credentials()
+        
+        assert creds is None
+        assert service._loaded is True
+    
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_load_credentials_missing_required_fields(self, mock_get_settings):
+        """Test handling when credentials missing required fields."""
+        from backend.services.gdrive_service import GoogleDriveService
+        
+        mock_settings = Mock()
+        mock_settings.get_secret.return_value = json.dumps({
+            "token": "access-token",
+            # Missing: refresh_token, client_id, client_secret
+        })
+        mock_get_settings.return_value = mock_settings
+        
+        service = GoogleDriveService()
+        creds = service._load_credentials()
+        
+        assert creds is None
+    
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_load_credentials_cached(self, mock_get_settings):
+        """Test credentials are cached after first load."""
+        from backend.services.gdrive_service import GoogleDriveService
+        
+        mock_settings = Mock()
+        mock_settings.get_secret.return_value = json.dumps({
+            "refresh_token": "token",
+            "client_id": "id",
+            "client_secret": "secret",
+        })
+        mock_get_settings.return_value = mock_settings
+        
+        service = GoogleDriveService()
+        
+        creds1 = service._load_credentials()
+        creds2 = service._load_credentials()
+        
+        assert creds1 == creds2
+        assert mock_settings.get_secret.call_count == 1
+
+
+class TestIsConfigured:
+    """Test is_configured property."""
+    
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_is_configured_true(self, mock_get_settings):
+        """Test is_configured returns True when credentials exist."""
+        from backend.services.gdrive_service import GoogleDriveService
+        
+        mock_settings = Mock()
+        mock_settings.get_secret.return_value = json.dumps({
+            "refresh_token": "token",
+            "client_id": "id",
+            "client_secret": "secret",
+        })
+        mock_get_settings.return_value = mock_settings
+        
+        service = GoogleDriveService()
+        
+        assert service.is_configured is True
+    
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_is_configured_false(self, mock_get_settings):
+        """Test is_configured returns False when no credentials."""
+        from backend.services.gdrive_service import GoogleDriveService
+        
+        mock_settings = Mock()
+        mock_settings.get_secret.return_value = None
+        mock_get_settings.return_value = mock_settings
+        
+        service = GoogleDriveService()
+        
+        assert service.is_configured is False
+
+
+class TestDriveService:
+    """Test service property."""
+    
+    @patch("googleapiclient.discovery.build")
+    @patch("google.oauth2.credentials.Credentials")
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_service_creates_drive_client(
+        self, mock_get_settings, mock_creds_class, mock_build
+    ):
+        """Test service property creates Google Drive API client."""
+        from backend.services.gdrive_service import GoogleDriveService
+        
+        mock_settings = Mock()
+        mock_settings.get_secret.return_value = json.dumps({
+            "token": "access-token",
+            "refresh_token": "refresh-token",
+            "client_id": "client-id",
+            "client_secret": "client-secret",
+        })
+        mock_get_settings.return_value = mock_settings
+        
+        mock_creds = Mock()
+        mock_creds_class.return_value = mock_creds
+        
+        mock_drive_service = Mock()
+        mock_build.return_value = mock_drive_service
+        
+        service = GoogleDriveService()
+        result = service.service
+        
+        mock_build.assert_called_once_with("drive", "v3", credentials=mock_creds)
+        assert result == mock_drive_service
+    
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_service_raises_on_missing_credentials(self, mock_get_settings):
+        """Test service raises RuntimeError when credentials missing."""
+        from backend.services.gdrive_service import GoogleDriveService
+        
+        mock_settings = Mock()
+        mock_settings.get_secret.return_value = None
+        mock_get_settings.return_value = mock_settings
+        
+        service = GoogleDriveService()
+        
+        with pytest.raises(RuntimeError) as exc_info:
+            _ = service.service
+        
+        assert "not configured" in str(exc_info.value)
+
+
+class TestGetOrCreateFolder:
+    """Test get_or_create_folder method."""
+    
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_get_existing_folder(self, mock_get_settings):
+        """Test finding an existing folder."""
+        from backend.services.gdrive_service import GoogleDriveService
+        
+        mock_settings = Mock()
+        mock_settings.get_secret.return_value = json.dumps({
+            "refresh_token": "token",
+            "client_id": "id",
+            "client_secret": "secret",
+        })
+        mock_get_settings.return_value = mock_settings
+        
+        service = GoogleDriveService()
+        
+        # Mock the Drive API
+        mock_files_api = Mock()
+        mock_list_result = Mock()
+        mock_list_result.execute.return_value = {
+            "files": [{"id": "folder-id-123", "name": "MP4"}]
+        }
+        mock_files_api.list.return_value = mock_list_result
+        
+        mock_drive = Mock()
+        mock_drive.files.return_value = mock_files_api
+        service._service = mock_drive
+        service._loaded = True
+        service._credentials_data = {"refresh_token": "token", "client_id": "id", "client_secret": "secret"}
+        
+        folder_id = service.get_or_create_folder("parent-123", "MP4")
+        
+        assert folder_id == "folder-id-123"
+    
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_create_new_folder(self, mock_get_settings):
+        """Test creating a new folder when it doesn't exist."""
+        from backend.services.gdrive_service import GoogleDriveService
+        
+        mock_settings = Mock()
+        mock_settings.get_secret.return_value = json.dumps({
+            "refresh_token": "token",
+            "client_id": "id",
+            "client_secret": "secret",
+        })
+        mock_get_settings.return_value = mock_settings
+        
+        service = GoogleDriveService()
+        
+        # Mock the Drive API
+        mock_files_api = Mock()
+        
+        # list returns empty (folder doesn't exist)
+        mock_list_result = Mock()
+        mock_list_result.execute.return_value = {"files": []}
+        mock_files_api.list.return_value = mock_list_result
+        
+        # create returns new folder
+        mock_create_result = Mock()
+        mock_create_result.execute.return_value = {"id": "new-folder-id"}
+        mock_files_api.create.return_value = mock_create_result
+        
+        mock_drive = Mock()
+        mock_drive.files.return_value = mock_files_api
+        service._service = mock_drive
+        service._loaded = True
+        service._credentials_data = {"refresh_token": "token", "client_id": "id", "client_secret": "secret"}
+        
+        folder_id = service.get_or_create_folder("parent-123", "NewFolder")
+        
+        assert folder_id == "new-folder-id"
+        mock_files_api.create.assert_called_once()
+
+
+class TestUploadFile:
+    """Test upload_file method."""
+    
+    @patch("googleapiclient.http.MediaFileUpload")
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_upload_file_success(self, mock_get_settings, mock_media, tmp_path):
+        """Test uploading a file to Drive."""
+        from backend.services.gdrive_service import GoogleDriveService
+        
+        mock_settings = Mock()
+        mock_settings.get_secret.return_value = json.dumps({
+            "refresh_token": "token",
+            "client_id": "id",
+            "client_secret": "secret",
+        })
+        mock_get_settings.return_value = mock_settings
+        
+        # Create test file
+        test_file = tmp_path / "test.mp4"
+        test_file.write_bytes(b"video content")
+        
+        service = GoogleDriveService()
+        
+        mock_files_api = Mock()
+        
+        # list returns empty (no existing file)
+        mock_list_result = Mock()
+        mock_list_result.execute.return_value = {"files": []}
+        mock_files_api.list.return_value = mock_list_result
+        
+        # create returns new file
+        mock_create_result = Mock()
+        mock_create_result.execute.return_value = {"id": "file-id-123"}
+        mock_files_api.create.return_value = mock_create_result
+        
+        mock_drive = Mock()
+        mock_drive.files.return_value = mock_files_api
+        service._service = mock_drive
+        service._loaded = True
+        service._credentials_data = {"refresh_token": "token", "client_id": "id", "client_secret": "secret"}
+        
+        file_id = service.upload_file(str(test_file), "parent-123", "video.mp4")
+        
+        assert file_id == "file-id-123"
+        mock_media.assert_called_once()
+        # Verify MIME type was set correctly
+        call_kwargs = mock_media.call_args.kwargs
+        assert call_kwargs["mimetype"] == "video/mp4"
+    
+    @patch("googleapiclient.http.MediaFileUpload")
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_upload_file_replaces_existing(self, mock_get_settings, mock_media, tmp_path):
+        """Test upload deletes existing file before upload."""
+        from backend.services.gdrive_service import GoogleDriveService
+        
+        mock_settings = Mock()
+        mock_settings.get_secret.return_value = json.dumps({
+            "refresh_token": "token",
+            "client_id": "id",
+            "client_secret": "secret",
+        })
+        mock_get_settings.return_value = mock_settings
+        
+        test_file = tmp_path / "test.mp4"
+        test_file.write_bytes(b"content")
+        
+        service = GoogleDriveService()
+        
+        mock_files_api = Mock()
+        
+        # list returns existing file
+        mock_list_result = Mock()
+        mock_list_result.execute.return_value = {
+            "files": [{"id": "existing-file-id"}]
+        }
+        mock_files_api.list.return_value = mock_list_result
+        
+        mock_delete_result = Mock()
+        mock_delete_result.execute.return_value = {}
+        mock_files_api.delete.return_value = mock_delete_result
+        
+        mock_create_result = Mock()
+        mock_create_result.execute.return_value = {"id": "new-file-id"}
+        mock_files_api.create.return_value = mock_create_result
+        
+        mock_drive = Mock()
+        mock_drive.files.return_value = mock_files_api
+        service._service = mock_drive
+        service._loaded = True
+        service._credentials_data = {"refresh_token": "token", "client_id": "id", "client_secret": "secret"}
+        
+        file_id = service.upload_file(str(test_file), "parent-123", "video.mp4")
+        
+        # Should have deleted existing file
+        mock_files_api.delete.assert_called_once_with(fileId="existing-file-id")
+        assert file_id == "new-file-id"
+
+
+class TestUploadToPublicShare:
+    """Test upload_to_public_share method."""
+    
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_upload_to_public_share(self, mock_get_settings, tmp_path):
+        """Test uploading files to public share folder structure."""
+        from backend.services.gdrive_service import GoogleDriveService
+        
+        mock_settings = Mock()
+        mock_settings.get_secret.return_value = json.dumps({
+            "refresh_token": "token",
+            "client_id": "id",
+            "client_secret": "secret",
+        })
+        mock_get_settings.return_value = mock_settings
+        
+        # Create test files
+        mp4_file = tmp_path / "output.mp4"
+        mp4_file.write_bytes(b"4k video")
+        mp4_720_file = tmp_path / "output_720p.mp4"
+        mp4_720_file.write_bytes(b"720p video")
+        cdg_file = tmp_path / "output.zip"
+        cdg_file.write_bytes(b"cdg package")
+        
+        service = GoogleDriveService()
+        
+        # Mock methods
+        with patch.object(service, "get_or_create_folder") as mock_get_folder:
+            with patch.object(service, "upload_file") as mock_upload:
+                mock_get_folder.side_effect = [
+                    "mp4-folder-id",
+                    "mp4-720-folder-id",
+                    "cdg-folder-id",
+                ]
+                mock_upload.side_effect = [
+                    "mp4-file-id",
+                    "720p-file-id",
+                    "cdg-file-id",
+                ]
+                
+                output_files = {
+                    "final_karaoke_lossy_mp4": str(mp4_file),
+                    "final_karaoke_lossy_720p_mp4": str(mp4_720_file),
+                    "final_karaoke_cdg_zip": str(cdg_file),
+                }
+                
+                result = service.upload_to_public_share(
+                    root_folder_id="root-123",
+                    brand_code="NOMAD-1163",
+                    base_name="Artist - Title",
+                    output_files=output_files,
+                )
+                
+                # Should have created/found 3 folders
+                assert mock_get_folder.call_count == 3
+                
+                # Should have uploaded 3 files
+                assert mock_upload.call_count == 3
+                
+                # Check result
+                assert result["mp4"] == "mp4-file-id"
+                assert result["mp4_720p"] == "720p-file-id"
+                assert result["cdg"] == "cdg-file-id"
+    
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_upload_to_public_share_skips_missing_files(
+        self, mock_get_settings, tmp_path
+    ):
+        """Test upload skips files that don't exist."""
+        from backend.services.gdrive_service import GoogleDriveService
+        
+        mock_settings = Mock()
+        mock_settings.get_secret.return_value = json.dumps({
+            "refresh_token": "token",
+            "client_id": "id",
+            "client_secret": "secret",
+        })
+        mock_get_settings.return_value = mock_settings
+        
+        # Only create one file
+        mp4_file = tmp_path / "output.mp4"
+        mp4_file.write_bytes(b"video")
+        
+        service = GoogleDriveService()
+        
+        with patch.object(service, "get_or_create_folder") as mock_get_folder:
+            with patch.object(service, "upload_file") as mock_upload:
+                mock_get_folder.return_value = "folder-id"
+                mock_upload.return_value = "file-id"
+                
+                output_files = {
+                    "final_karaoke_lossy_mp4": str(mp4_file),
+                    "final_karaoke_lossy_720p_mp4": "/nonexistent/file.mp4",
+                    "final_karaoke_cdg_zip": None,
+                }
+                
+                result = service.upload_to_public_share(
+                    root_folder_id="root-123",
+                    brand_code="CODE",
+                    base_name="Name",
+                    output_files=output_files,
+                )
+                
+                # Should only upload the one file that exists
+                assert mock_upload.call_count == 1
+                assert len(result) == 1
+
+
+class TestGetGdriveService:
+    """Test get_gdrive_service singleton."""
+    
+    @patch("backend.services.gdrive_service.get_settings")
+    def test_get_gdrive_service_singleton(self, mock_get_settings):
+        """Test get_gdrive_service returns singleton instance."""
+        from backend.services.gdrive_service import get_gdrive_service
+        import backend.services.gdrive_service as gdrive_module
+        
+        # Reset singleton
+        gdrive_module._gdrive_service = None
+        
+        mock_settings = Mock()
+        mock_settings.get_secret.return_value = None
+        mock_get_settings.return_value = mock_settings
+        
+        service1 = get_gdrive_service()
+        service2 = get_gdrive_service()
+        
+        assert service1 is service2
+