jleechanorg-pr-automation 0.1.0__py3-none-any.whl

jleechanorg_pr_automation/tests/test_codex_actor_matching.py

@@ -0,0 +1,137 @@
+#!/usr/bin/env python3
+"""Tests for Codex actor detection heuristics."""
+
+import unittest
+
+from jleechanorg_pr_automation.jleechanorg_pr_monitor import JleechanorgPRMonitor
+
+
+class TestCodexActorMatching(unittest.TestCase):
+    """Validate detection of Codex-authored commits."""
+
+    def setUp(self) -> None:
+        self.monitor = JleechanorgPRMonitor()
+
+    def test_detects_codex_via_actor_fields(self) -> None:
+        commit_details = {
+            "author_login": "codex-bot",
+            "author_email": "codex@example.com",
+            "author_name": "Codex Bot",
+            "committer_login": None,
+            "committer_email": None,
+            "committer_name": None,
+            "message_headline": "Refactor subsystem",
+            "message": "Refactor subsystem",
+        }
+
+        self.assertTrue(
+            self.monitor._is_head_commit_from_codex(commit_details),
+            "Expected Codex detection when actor fields include Codex token",
+        )
+
+    def test_detects_codex_via_message_marker(self) -> None:
+        commit_details = {
+            "author_login": "regular-user",
+            "author_email": "dev@example.com",
+            "author_name": "Regular User",
+            "committer_login": "regular-user",
+            "committer_email": "dev@example.com",
+            "committer_name": "Regular User",
+            "message_headline": (
+                f"Address review feedback {self.monitor.CODEX_COMMIT_MESSAGE_MARKER}"
+            ),
+            "message": "Address review feedback and add tests",
+        }
+
+        self.assertTrue(
+            self.monitor._is_head_commit_from_codex(commit_details),
+            "Expected Codex detection from commit message marker",
+        )
+
+    def test_detects_codex_via_message_body_marker_case_insensitive(self) -> None:
+        commit_details = {
+            "author_login": "regular-user",
+            "author_email": "dev@example.com",
+            "author_name": "Regular User",
+            "committer_login": "regular-user",
+            "committer_email": "dev@example.com",
+            "committer_name": "Regular User",
+            "message_headline": "Address review feedback",
+            "message": "Add docs [CODEX-AUTOMATION-COMMIT] and clean up",
+        }
+
+        self.assertTrue(
+            self.monitor._is_head_commit_from_codex(commit_details),
+            "Expected Codex detection from commit body marker",
+        )
+
+    def test_returns_false_when_no_codex_tokens_found(self) -> None:
+        commit_details = {
+            "author_login": "regular-user",
+            "author_email": "dev@example.com",
+            "author_name": "Regular User",
+            "committer_login": "reviewer",
+            "committer_email": "reviewer@example.com",
+            "committer_name": "Helpful Reviewer",
+            "message_headline": "Refactor subsystem",
+            "message": "Improve code coverage",
+        }
+
+        self.assertFalse(
+            self.monitor._is_head_commit_from_codex(commit_details),
+            "Expected no Codex detection when no markers are present",
+        )
+
+    def test_handles_non_string_actor_fields(self) -> None:
+        """Type safety: should not crash when actor fields contain non-string values"""
+        commit_details = {
+            "author_login": {"nested": "value"},  # Invalid type
+            "author_email": 12345,  # Invalid type
+            "author_name": None,
+            "committer_login": ["list", "value"],  # Invalid type
+            "committer_email": None,
+            "committer_name": None,
+            "message_headline": "Normal message",
+            "message": "Normal body",
+        }
+
+        # Should not raise TypeError and should return False
+        result = self.monitor._is_head_commit_from_codex(commit_details)
+        self.assertFalse(result, "Should handle non-string fields gracefully")
+
+    def test_handles_non_string_message_fields(self) -> None:
+        """Type safety: should not crash when message fields contain non-string values"""
+        commit_details = {
+            "author_login": "regular-user",
+            "author_email": "dev@example.com",
+            "author_name": "Regular User",
+            "committer_login": None,
+            "committer_email": None,
+            "committer_name": None,
+            "message_headline": {"nested": "object"},  # Invalid type
+            "message": 12345,  # Invalid type
+        }
+
+        # Should not raise TypeError and should return False
+        result = self.monitor._is_head_commit_from_codex(commit_details)
+        self.assertFalse(result, "Should handle non-string message fields gracefully")
+
+    def test_handles_empty_string_fields(self) -> None:
+        """Should handle empty strings correctly"""
+        commit_details = {
+            "author_login": "",
+            "author_email": "",
+            "author_name": "",
+            "committer_login": "",
+            "committer_email": "",
+            "committer_name": "",
+            "message_headline": "",
+            "message": "",
+        }
+
+        result = self.monitor._is_head_commit_from_codex(commit_details)
+        self.assertFalse(result, "Should treat empty strings as no Codex markers")
+
+
+if __name__ == "__main__":
+    unittest.main()

jleechanorg_pr_automation/tests/test_graphql_error_handling.py

@@ -0,0 +1,155 @@
+#!/usr/bin/env python3
+"""Tests for GraphQL API error handling in head commit detection."""
+
+import json
+import subprocess
+import unittest
+from unittest.mock import MagicMock, patch
+
+from jleechanorg_pr_automation.jleechanorg_pr_monitor import JleechanorgPRMonitor
+
+
+class TestGraphQLErrorHandling(unittest.TestCase):
+    """Validate robust error handling for GraphQL API failures."""
+
+    def setUp(self) -> None:
+        self.monitor = JleechanorgPRMonitor()
+
+    @patch('jleechanorg_pr_automation.automation_utils.AutomationUtils.execute_subprocess_with_timeout')
+    def test_handles_api_timeout(self, mock_exec) -> None:
+        """Should return None when GraphQL API times out"""
+        mock_exec.side_effect = subprocess.TimeoutExpired(['gh'], 30)
+
+        result = self.monitor._get_head_commit_details('org/repo', 123)
+
+        self.assertIsNone(result, "Should return None on API timeout")
+
+    @patch('jleechanorg_pr_automation.automation_utils.AutomationUtils.execute_subprocess_with_timeout')
+    def test_handles_malformed_json(self, mock_exec) -> None:
+        """Should return None when GraphQL returns invalid JSON"""
+        mock_exec.return_value = MagicMock(
+            stdout='{"invalid": json, missing quotes}'
+        )
+
+        result = self.monitor._get_head_commit_details('org/repo', 123)
+
+        self.assertIsNone(result, "Should return None on malformed JSON")
+
+    @patch('jleechanorg_pr_automation.automation_utils.AutomationUtils.execute_subprocess_with_timeout')
+    def test_handles_missing_data_field(self, mock_exec) -> None:
+        """Should handle missing 'data' field in GraphQL response"""
+        mock_exec.return_value = MagicMock(
+            stdout='{"errors": [{"message": "Field error"}]}'
+        )
+
+        result = self.monitor._get_head_commit_details('org/repo', 123)
+
+        self.assertIsNone(result, "Should return None when data field missing")
+
+    @patch('jleechanorg_pr_automation.automation_utils.AutomationUtils.execute_subprocess_with_timeout')
+    def test_handles_missing_repository_field(self, mock_exec) -> None:
+        """Should handle missing 'repository' field gracefully"""
+        mock_exec.return_value = MagicMock(
+            stdout='{"data": {}}'
+        )
+
+        result = self.monitor._get_head_commit_details('org/repo', 123)
+
+        self.assertIsNone(result, "Should return None when repository field missing")
+
+    @patch('jleechanorg_pr_automation.automation_utils.AutomationUtils.execute_subprocess_with_timeout')
+    def test_handles_missing_commits(self, mock_exec) -> None:
+        """Should handle missing commits array gracefully"""
+        response = {
+            "data": {
+                "repository": {
+                    "pullRequest": {}
+                }
+            }
+        }
+        mock_exec.return_value = MagicMock(stdout=json.dumps(response))
+
+        result = self.monitor._get_head_commit_details('org/repo', 123)
+
+        self.assertIsNone(result, "Should return None when commits missing")
+
+    @patch('jleechanorg_pr_automation.automation_utils.AutomationUtils.execute_subprocess_with_timeout')
+    def test_handles_empty_commits_array(self, mock_exec) -> None:
+        """Should handle empty commits array gracefully"""
+        response = {
+            "data": {
+                "repository": {
+                    "pullRequest": {
+                        "commits": {"nodes": []}
+                    }
+                }
+            }
+        }
+        mock_exec.return_value = MagicMock(stdout=json.dumps(response))
+
+        result = self.monitor._get_head_commit_details('org/repo', 123)
+
+        self.assertIsNone(result, "Should return None when commits array empty")
+
+    @patch('jleechanorg_pr_automation.automation_utils.AutomationUtils.execute_subprocess_with_timeout')
+    def test_handles_called_process_error(self, mock_exec) -> None:
+        """Should handle subprocess CalledProcessError gracefully"""
+        mock_exec.side_effect = subprocess.CalledProcessError(
+            returncode=1,
+            cmd=['gh', 'api'],
+            stderr='API rate limit exceeded'
+        )
+
+        result = self.monitor._get_head_commit_details('org/repo', 123)
+
+        self.assertIsNone(result, "Should return None on CalledProcessError")
+
+    @patch('jleechanorg_pr_automation.automation_utils.AutomationUtils.execute_subprocess_with_timeout')
+    def test_handles_generic_exception(self, mock_exec) -> None:
+        """Should handle unexpected exceptions gracefully"""
+        mock_exec.side_effect = RuntimeError("Unexpected error")
+
+        result = self.monitor._get_head_commit_details('org/repo', 123)
+
+        self.assertIsNone(result, "Should return None on unexpected exception")
+
+    def test_validates_invalid_repo_format(self) -> None:
+        """Should return None for invalid repository format"""
+        result = self.monitor._get_head_commit_details('invalid-no-slash', 123)
+
+        self.assertIsNone(result, "Should reject repo without slash separator")
+
+    def test_validates_empty_repo_name(self) -> None:
+        """Should return None for empty repository parts"""
+        result = self.monitor._get_head_commit_details('/repo', 123)
+
+        self.assertIsNone(result, "Should reject empty owner")
+
+    def test_validates_invalid_github_owner_name(self) -> None:
+        """Should return None for invalid GitHub owner/repo names"""
+        # GitHub names cannot start with hyphen
+        result = self.monitor._get_head_commit_details('-invalid/repo', 123)
+
+        self.assertIsNone(result, "Should reject owner starting with hyphen")
+
+    def test_validates_invalid_pr_number_string(self) -> None:
+        """Should return None for non-integer PR number"""
+        result = self.monitor._get_head_commit_details('org/repo', "not-a-number")
+
+        self.assertIsNone(result, "Should reject string PR number")
+
+    def test_validates_negative_pr_number(self) -> None:
+        """Should return None for negative PR number"""
+        result = self.monitor._get_head_commit_details('org/repo', -1)
+
+        self.assertIsNone(result, "Should reject negative PR number")
+
+    def test_validates_zero_pr_number(self) -> None:
+        """Should return None for zero PR number"""
+        result = self.monitor._get_head_commit_details('org/repo', 0)
+
+        self.assertIsNone(result, "Should reject zero PR number")
+
+
+if __name__ == "__main__":
+    unittest.main()