jac-client 0.2.11__py3-none-any.whl → 0.2.12__py3-none-any.whl

jac_client/plugin/src/impl/vite_bundler.impl.jac

@@ -426,22 +426,29 @@ impl ViteBundler.build(self: ViteBundler, entry_file: Optional[Path] = None) ->
     import sys;
     import time;
     import shutil;
-    import from jac_client.plugin.utils { ensure_bun_available }
+    import from jac_client.plugin.utils { ensure_bun_available, ensure_client_deps }
     # Ensure bun is available before proceeding
     if not ensure_bun_available() {
         raise ClientBundleError('Bun is required. Install manually: https://bun.sh') from None ;
     }
-    self.output_dir.mkdir(parents=True, exist_ok=True);
-    generated_package_json = self._get_client_dir() / 'configs' / 'package.json';
-    if not generated_package_json.exists() {
-        self.create_package_json();
-    } else {
-        # Ensure tsconfig.json exists even if package.json already exists
-        self.create_tsconfig();
+    # Ensure client npm deps are configured; prompt to install defaults if missing
+    if not ensure_client_deps(self.config_loader) {
+        raise ClientBundleError(
+            'Client dependencies not configured. Add [dependencies.npm] to jac.toml '
+            'or create a project with: jac create --use client'
+        ) from None ;
     }
+    self.output_dir.mkdir(parents=True, exist_ok=True);
+    # Always regenerate package.json to pick up any dependency changes
+    self.create_package_json();
     try {
         build_dir = self._get_client_dir();
         node_modules = build_dir / 'node_modules';
+        # Reinstall if node_modules is missing or stale (e.g. empty from a prior failed install)
+        vite_bin = node_modules / '.bin' / 'vite';
+        if node_modules.exists() and not vite_bin.exists() {
+            shutil.rmtree(node_modules);
+        }
         if not node_modules.exists() {
             # Temporarily copy package.json to client build dir for bun install
             build_package_json = build_dir / 'package.json';
@@ -455,15 +462,17 @@ impl ViteBundler.build(self: ViteBundler, entry_file: Optional[Path] = None) ->
                 print("\n  ⏳ Installing dependencies...\n", flush=True);
                 start_time = time.time();
                 result = subprocess.run(
-                    ['bun', 'install'], cwd=build_dir, check=False, text=True
+                    ['bun', 'install'],
+                    cwd=build_dir,
+                    check=False,
+                    text=True,
+                    capture_output=True
                 );
                 elapsed = time.time() - start_time;
                 if result.returncode != 0 {
-                    print(
-                        f"\n  ✖ bun install failed after {elapsed:.1f}s",
-                        file=sys.stderr
-                    );
-                    raise ClientBundleError("Failed to install dependencies") ;
+                    error_output = result.stderr or result.stdout;
+                    error_msg = f"Dependency installation failed after {elapsed:.1f}s\n\n{error_output}\nCommand: bun install";
+                    raise ClientBundleError(error_msg) from None ;
                 }
                 print(f"\n  ✔ Dependencies installed ({elapsed:.1f}s)", flush=True);
             } except FileNotFoundError {
@@ -500,13 +509,16 @@ impl ViteBundler.build(self: ViteBundler, entry_file: Optional[Path] = None) ->
         # Run vite from client build directory so it can find node_modules
         print("\n  ⏳ Building client bundle...\n", flush=True);
         start_time = time.time();
-        result = subprocess.run(command, cwd=build_dir, check=False, text=True);
+        result = subprocess.run(
+            command, cwd=build_dir, check=False, text=True, capture_output=True
+        );
         elapsed = time.time() - start_time;
         if result.returncode != 0 {
-            print(f"\n  ✖ Vite build failed after {elapsed:.1f}s", file=sys.stderr);
-            raise ClientBundleError(
-                f"Vite build failed (see output above)\nCommand: {' '.join(command)}"
-            ) from None ;
+            error_output = result.stderr or result.stdout;
+            error_msg = f"Vite build failed after {elapsed:.1f}s\n\n{error_output}\nCommand: {' '.join(
+                command
+            )}";
+            raise ClientBundleError(error_msg) from None ;
         }
         print(f"\n  ✔ Client bundle built ({elapsed:.1f}s)", flush=True);
     } finally {
@@ -615,6 +627,10 @@ export default defineConfig({{
         target: "http://localhost:{api_port}",
         changeOrigin: true,
       }},
+      "/static": {{
+        target: "http://localhost:{api_port}",
+        changeOrigin: true,
+      }},
     }},
   }},
   resolve: {{

jac_client/plugin/utils/__init__.jac

@@ -1,3 +1,4 @@
 """Utility modules for jac-client plugin."""
 
 import from .bun_installer { ensure_bun_available, prompt_install_bun }
+import from .client_deps { ensure_client_deps }

jac_client/plugin/utils/client_deps.jac

@@ -0,0 +1,14 @@
+"""Client dependency checker utility for jac-client.
+
+Provides a function to check if required npm dependencies are configured
+and prompt the user to install defaults if missing.
+"""
+
+"""Check if client npm dependencies are configured, prompt to install if missing.
+
+Takes a JacClientConfig instance, checks if dependencies and devDependencies
+are both empty, and if so prompts the user to install default jac-client deps.
+
+Returns True if deps are configured (or were just installed), False if user declined.
+"""
+def ensure_client_deps(config_loader: object) -> bool;

jac_client/plugin/utils/impl/client_deps.impl.jac

@@ -0,0 +1,73 @@
+"""Implementation of client dependency checker utility."""
+
+"""Check if client npm dependencies are configured, prompt to install if missing."""
+impl ensure_client_deps(config_loader: object) -> bool {
+    package_config = config_loader.get_package_config();
+    dependencies = package_config.get('dependencies', {});
+    dev_dependencies = package_config.get('devDependencies', {});
+    # If either deps or devDeps has entries, assume configured
+    if dependencies or dev_dependencies {
+        return True;
+    }
+    # No deps configured — prompt the user
+    return prompt_install_client_deps(config_loader);
+}
+
+"""Prompt user to install default jac-client npm dependencies."""
+def prompt_install_client_deps(config_loader: object) -> bool {
+    import sys;
+    print("\n  ⚠ Client dependencies are not configured.", file=sys.stderr);
+    print(
+        "  jac-client requires npm packages (react, vite, etc.) to build client pages.",
+        file=sys.stderr
+    );
+    print("  These will be added to your jac.toml file.\n", file=sys.stderr);
+    try {
+        response = input("  Install default client dependencies now? [Y/n]: ").strip().lower();
+    } except (EOFError, KeyboardInterrupt) {
+        print("", file=sys.stderr);
+        return False;
+    }
+    if response and response not in ('y', 'yes', '') {
+        print(
+            "\n  To configure manually, add [dependencies.npm] to your jac.toml.",
+            file=sys.stderr
+        );
+        print(
+            "  Or create a new project with: jac create --use client\n",
+            file=sys.stderr
+        );
+        return False;
+    }
+    # Default runtime dependencies
+    default_deps: dict[str, str] = {
+        'react': '^18.2.0',
+        'react-dom': '^18.2.0',
+        'react-router-dom': '^6.22.0',
+        'react-error-boundary': '^5.0.0'
+    };
+    # Default build infrastructure dependencies
+    default_dev_deps: dict[str, str] = {
+        'vite': '^6.4.1',
+        '@vitejs/plugin-react': '^4.2.1',
+        'typescript': '^5.3.3',
+        '@types/react': '^18.2.0',
+        '@types/react-dom': '^18.2.0'
+    };
+    print("\n  ⏳ Adding default client dependencies to jac.toml...", flush=True);
+    try {
+        for (name, version) in default_deps.items() {
+            config_loader.add_dependency(name, version, is_dev=False);
+        }
+        for (name, version) in default_dev_deps.items() {
+            config_loader.add_dependency(name, version, is_dev=True);
+        }
+        config_loader.save();
+        config_loader.invalidate();
+        print("  ✔ Default client dependencies added to jac.toml\n", flush=True);
+        return True;
+    } except Exception as e {
+        print(f"  ✖ Failed to add dependencies: {e}", file=sys.stderr);
+        return False;
+    }
+}

jac_client/templates/client.jacpack

@@ -33,10 +33,6 @@
     "assets",
     ".jac/client"
   ],
-  "gitignore_entries": [
-    "# Ignore all build artifacts in .jac directory",
-    "*"
-  ],
   "root_gitignore_entries": [
     "# Jac project",
     "packages/",

jac_client/templates/fullstack.jacpack

@@ -36,10 +36,6 @@
     ".jac",
     "assets"
   ],
-  "gitignore_entries": [
-    "# Ignore all build artifacts in .jac directory",
-    "*"
-  ],
   "root_gitignore_entries": [
     "# Jac build artifacts",
     ".jac/",

jac_client/tests/test_cli.py

@@ -1,9 +1,11 @@
 """Test create-jac-app command."""
 
+import contextlib
 import os
 import tempfile
 import tomllib
 from subprocess import PIPE, Popen, run
+from unittest.mock import patch
 
 
 def test_create_jac_app() -> None:
@@ -920,3 +922,69 @@ def test_create_cl_and_run_no_root_files() -> None:
 
         finally:
             os.chdir(original_cwd)
+
+
+def test_vite_build_prompts_for_missing_client_deps() -> None:
+    """Test that ViteBundler.build() prompts to install deps when jac.toml is missing.
+
+    Exercises the same code path as `jac start` → server.start() → ensure_bundle()
+    → ViteBundler.build(), which checks for npm deps before building.
+    """
+    import json
+    from pathlib import Path
+
+    from jac_client.plugin.src.vite_bundler import ViteBundler
+
+    with tempfile.TemporaryDirectory() as temp_dir:
+        project_dir = Path(temp_dir)
+        config_file = project_dir / "jac.toml"
+
+        # No jac.toml — ViteBundler.build() should prompt via ensure_client_deps
+        bundler = ViteBundler(project_dir)
+
+        # Mock input to accept, and mock bun/vite so we don't need real installs.
+        # We only care that ensure_client_deps wrote jac.toml before reaching bun.
+        with (
+            patch("builtins.input", return_value="Y"),
+            patch(
+                "jac_client.plugin.utils.bun_installer.ensure_bun_available",
+                return_value=True,
+            ),
+            patch("subprocess.run") as mock_subprocess,
+        ):
+            # bun install returns success, vite build returns failure
+            # (we don't have real vite — that's fine, we're testing the dep prompt)
+            mock_subprocess.side_effect = [
+                type("Result", (), {"returncode": 0})(),  # bun install
+                type("Result", (), {"returncode": 1})(),  # vite build
+            ]
+            with contextlib.suppress(Exception):
+                bundler.build()  # vite build failure is expected
+
+        # The key assertion: jac.toml was created with default client deps
+        assert config_file.exists(), (
+            "jac.toml should have been created after accepting the prompt"
+        )
+
+        with open(config_file, "rb") as f:
+            data = tomllib.load(f)
+
+        npm_deps = data.get("dependencies", {}).get("npm", {})
+        assert "react" in npm_deps, "react should be in dependencies.npm"
+        assert "react-dom" in npm_deps, "react-dom should be in dependencies.npm"
+
+        npm_dev = npm_deps.get("dev", {})
+        assert "vite" in npm_dev, "vite should be in dev dependencies"
+        assert "@vitejs/plugin-react" in npm_dev, (
+            "@vitejs/plugin-react should be in dev deps"
+        )
+
+        # Verify the generated package.json also picked up the deps
+        package_json = project_dir / ".jac" / "client" / "configs" / "package.json"
+        assert package_json.exists(), "package.json should have been generated"
+
+        with open(package_json) as f:
+            pkg = json.load(f)
+
+        assert pkg["dependencies"].get("react"), "package.json should have react"
+        assert pkg["devDependencies"].get("vite"), "package.json should have vite"

{jac_client-0.2.11.dist-info → jac_client-0.2.12.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: jac-client
-Version: 0.2.11
+Version: 0.2.12
 Summary: Build full-stack web applications with Jac - one language for frontend and backend.
 Author-email: Jason Mars <jason@mars.ninja>
 Maintainer-email: Jason Mars <jason@mars.ninja>
@@ -11,7 +11,7 @@ Project-URL: Documentation, https://jac-lang.org
 Keywords: jac,jaclang,jaseci,frontend,full-stack,web-development
 Requires-Python: >=3.12
 Description-Content-Type: text/markdown
-Requires-Dist: jaclang>=0.9.11
+Requires-Dist: jaclang>=0.9.12
 Provides-Extra: dev
 Requires-Dist: python-dotenv==1.0.1; extra == "dev"
 Requires-Dist: pytest==8.3.5; extra == "dev"

{jac_client-0.2.11.dist-info → jac_client-0.2.12.dist-info}/RECORD

@@ -75,7 +75,7 @@ jac_client/plugin/src/impl/desktop_config.impl.jac,sha256=mitiS3RfHjMstUqPJs2OnB
 jac_client/plugin/src/impl/import_processor.impl.jac,sha256=BMkkZXlF-6jbC-r3tuFj8PDFvDZrbfzuhnaw8qraWIQ,1214
 jac_client/plugin/src/impl/jac_to_js.impl.jac,sha256=KHblc0PloMJqsX2DRdp3tyJ0k5d39ArPxBLKXsw7mjA,1692
 jac_client/plugin/src/impl/package_installer.impl.jac,sha256=YbXlzqmrzNtNSyfDcVY3-975Pqbc9H9wxQ1LQxO6ypE,4020
-jac_client/plugin/src/impl/vite_bundler.impl.jac,sha256=KFEuPqqAAgS1IuWPBxGT5T9Rib6n0vbL3UcMX9UM-uE,28805
+jac_client/plugin/src/impl/vite_bundler.impl.jac,sha256=DqFgC2vkAw5udxPv1qN3WqOx_KiVLWCjrSibUaSnFhM,29538
 jac_client/plugin/src/targets/desktop_target.jac,sha256=TxDdpActsLAvrOZ_QpeQ1F22PehctAraz3zuo4CZ0Lk,1286
 jac_client/plugin/src/targets/register.jac,sha256=tiHmOKEgOWlYdY5DYko6M0Ktp2kZr7TZFWKq18Tmp24,835
 jac_client/plugin/src/targets/registry.jac,sha256=wl1QJEWAyI7KAfTSjIw3PdxpYgtUCpaj7D0c09jZxFM,2664
@@ -84,14 +84,16 @@ jac_client/plugin/src/targets/desktop/sidecar/main.py,sha256=PVmHvXg2Gta2UzD1O3H
 jac_client/plugin/src/targets/impl/desktop_target.impl.jac,sha256=7a-lem6Qvlghl6MPiT8_YYYw73xExsrgulir8S-t5Ls,83003
 jac_client/plugin/src/targets/impl/registry.impl.jac,sha256=2PUw_cZ9Us6PJRxO9o4aSOwYW_5_VEi6WXbIVS_6fN8,1691
 jac_client/plugin/src/targets/impl/web_target.impl.jac,sha256=fQQ1zahAnvsD4BFr8JrbF52xZxSJL_K3yE0litbJdBg,5110
-jac_client/plugin/utils/__init__.jac,sha256=1s-8qMGXIdGfhlZD4XXb2lHcN9M6pIGllTK-AyHdeH0,118
+jac_client/plugin/utils/__init__.jac,sha256=u_rH9sxR8EgLUsbaNpv0tgYmt5sLlrb41LhPRk0w0g4,166
 jac_client/plugin/utils/bun_installer.jac,sha256=irvOnt2WF6sB_aOH5v6L9Jde-NoP39JDjysXB2V0nv0,473
+jac_client/plugin/utils/client_deps.jac,sha256=BLJ7UaBi2aC-V-Vl4IsfGYfnRI75QtaO1JNYo_ut0UI,569
 jac_client/plugin/utils/impl/bun_installer.impl.jac,sha256=S6yqaxNvQ6HYgSfO7bRu8NiNsYvG8mvK8j4d1_Vf_FM,3483
-jac_client/templates/client.jacpack,sha256=7Atks2Swszn-0Amcl7LfQWXuCw4sOoGOSArMKlKzGmI,4279
-jac_client/templates/fullstack.jacpack,sha256=wVHTQw13fWI_hy8gndteWL0ht9VidygupJ8dgNpdQ1g,23201
+jac_client/plugin/utils/impl/client_deps.impl.jac,sha256=u2APi7hYTTCzDuiG2wTlsM4Dfi1QPY9FNO6xAIq_gPw,2774
+jac_client/templates/client.jacpack,sha256=o3aVPZTI1T52gvLHv5bGK0czX8cAx0GgWfMjQP5yA3w,4187
+jac_client/templates/fullstack.jacpack,sha256=qS5vlhHjpInxVFkAD8T0FftqWFVW6hAbexl9LufW0eE,23109
 jac_client/tests/__init__.py,sha256=HSr78dvKyvNmP7bLmAssfYItAn4puFwAe1oWnV8l7pA,36
 jac_client/tests/conftest.py,sha256=PU-eYPagFRXSKeXaGadES3s2LlNjzy5VSsXuUPse8_4,11136
-jac_client/tests/test_cli.py,sha256=lK2LlwqxzmZse-ewlaaMTqDkjwispMsVa9iEqCjilj4,32452
+jac_client/tests/test_cli.py,sha256=EWpvBNgUfKk7RW5TW1wkM8g6WD0vDRsF3B7mFiOdG48,35318
 jac_client/tests/test_e2e.py,sha256=MqMXiUnLl8qwsW-OQFN1GK-5hbCKKzxT2SewmVWEsow,8197
 jac_client/tests/test_helpers.py,sha256=UqXYIl0Vi_8IDJ1efsJh1BcaJPudINfpLojhwDxxtNg,1615
 jac_client/tests/test_it.py,sha256=Wy8VeBLcchXZFDHUBoMEWeU4oUXxDwvWVCnMPvxlnFQ,37825
@@ -106,8 +108,8 @@ jac_client/tests/fixtures/relative_import/button.jac,sha256=kCDNaHEcxMEFdezfnecy
 jac_client/tests/fixtures/spawn_test/app.jac,sha256=cooYrB7xhHMk9xWOZ6MIiY4I6kmodW2v-nyVnd1RR74,3863
 jac_client/tests/fixtures/test_fragments_spread/app.jac,sha256=CMzAz4Ydx_5eAV82-io8sJdy8_xy-mR7YOVc7FcozlU,1277
 jac_client/tests/fixtures/with-ts/app.jac,sha256=1j1IH_4mfgLtgPq2Xc5PrGHBvmLQl6U0ddbb2L5KwuA,981
-jac_client-0.2.11.dist-info/METADATA,sha256=OKfil5EIrTpafAYyKF_cj6Q7DSAN2jkhZ_ic35rEAcQ,5552
-jac_client-0.2.11.dist-info/WHEEL,sha256=wUyA8OaulRlbfwMtmQsvNngGrxQHAvkKcvRmdizlJi0,92
-jac_client-0.2.11.dist-info/entry_points.txt,sha256=fVrlaJKcSa2DK2hcfR6bNaQDB9mszMpZeEa6pitMdt4,154
-jac_client-0.2.11.dist-info/top_level.txt,sha256=u1VEBfiqwRrZEopKraIh-Ym55qSnDZR3Q5xdw2HinhU,11
-jac_client-0.2.11.dist-info/RECORD,,
+jac_client-0.2.12.dist-info/METADATA,sha256=odF-aHda-UyjLXi5xA460DkljU5gE98qB0PdEL1hIds,5552
+jac_client-0.2.12.dist-info/WHEEL,sha256=wUyA8OaulRlbfwMtmQsvNngGrxQHAvkKcvRmdizlJi0,92
+jac_client-0.2.12.dist-info/entry_points.txt,sha256=fVrlaJKcSa2DK2hcfR6bNaQDB9mszMpZeEa6pitMdt4,154
+jac_client-0.2.12.dist-info/top_level.txt,sha256=u1VEBfiqwRrZEopKraIh-Ym55qSnDZR3Q5xdw2HinhU,11
+jac_client-0.2.12.dist-info/RECORD,,