ipfabric_netbox 4.3.2b10__py3-none-any.whl → 4.3.2b11__py3-none-any.whl

ipfabric_netbox/tests/test_forms.py

@@ -1843,6 +1843,99 @@ class IPFabricSyncFormTestCase(TestCase):
         fieldset_names2 = [fs.name for fs in fieldsets2]
         self.assertEqual(fieldset_names1, fieldset_names2)
 
+    def test_save_method_with_filters(self):
+        """Test that filters many-to-many relationship is properly saved"""
+        # Create some filter objects
+        endpoint = IPFabricEndpoint.objects.create(
+            name="Test Endpoint",
+            endpoint="inventory/devices",
+        )
+        filter1 = IPFabricFilter.objects.create(
+            name="Filter 1",
+            filter_type="and",
+        )
+        filter1.endpoints.add(endpoint)
+
+        filter2 = IPFabricFilter.objects.create(
+            name="Filter 2",
+            filter_type="or",
+        )
+        filter2.endpoints.add(endpoint)
+
+        # Create a sync with filters
+        form = IPFabricSyncForm(
+            data={
+                "name": "Test Sync With Filters",
+                "source": self.source.pk,
+                "snapshot_data": self.snapshot.pk,
+                "filters": [filter1.pk, filter2.pk],
+            }
+        )
+
+        self.assertTrue(form.is_valid(), form.errors)
+        sync_instance = form.save()
+
+        # Verify filters were saved correctly
+        self.assertEqual(sync_instance.filters.count(), 2)
+        self.assertIn(filter1, sync_instance.filters.all())
+        self.assertIn(filter2, sync_instance.filters.all())
+
+    def test_update_method_with_filters(self):
+        """Test that filters can be updated on existing sync"""
+        # Create some filter objects
+        endpoint = IPFabricEndpoint.objects.create(
+            name="Test Endpoint Update",
+            endpoint="inventory/devices",
+        )
+        filter1 = IPFabricFilter.objects.create(
+            name="Filter Update 1",
+            filter_type="and",
+        )
+        filter1.endpoints.add(endpoint)
+
+        filter2 = IPFabricFilter.objects.create(
+            name="Filter Update 2",
+            filter_type="or",
+        )
+        filter2.endpoints.add(endpoint)
+
+        filter3 = IPFabricFilter.objects.create(
+            name="Filter Update 3",
+            filter_type="and",
+        )
+        filter3.endpoints.add(endpoint)
+
+        # Create a sync with initial filters
+        sync_instance = IPFabricSync.objects.create(
+            name="Existing Sync With Filters",
+            snapshot_data=self.snapshot,
+            parameters={},
+        )
+        sync_instance.filters.set([filter1, filter2])
+
+        # Verify initial state
+        self.assertEqual(sync_instance.filters.count(), 2)
+
+        # Update the sync with different filters
+        form = IPFabricSyncForm(
+            instance=sync_instance,
+            data={
+                "name": "Existing Sync With Filters",
+                "source": self.source.pk,
+                "snapshot_data": self.snapshot.pk,
+                "filters": [filter2.pk, filter3.pk],  # Changed filters
+            },
+        )
+
+        self.assertTrue(form.is_valid(), form.errors)
+        updated_instance = form.save()
+
+        # Verify filters were updated correctly
+        self.assertEqual(updated_instance.filters.count(), 2)
+        self.assertNotIn(filter1, updated_instance.filters.all())
+        self.assertIn(filter2, updated_instance.filters.all())
+        self.assertIn(filter3, updated_instance.filters.all())
+
 
 class IPFabricFilterFormTestCase(TestCase):
     """Test cases for IPFabricFilterForm"""

ipfabric_netbox/tests/test_views.py

@@ -1692,7 +1692,7 @@ class IPFabricTransformMapTestCase(
         self.assertHttpStatus(response, 200)
         self.assertContains(
             response,
-            "A transform map with group 'Test Group' and target model 'DCIM | site' already exists.",
+            "A transform map with group 'Test Group', target model 'DCIM | site', and source endpoint '/inventory/sites/overview' already exists.",
         )
         self.assertIn("X-Debug-HTMX-Partial", response)
 

ipfabric_netbox/utilities/endpoint.py

@@ -28,3 +28,56 @@ def get_endpoint_data() -> dict:
 
 
 # endregion Endpoint Creation
+
+# region Endpoint Updating
+
+
+class EndpointRecord:
+    """Record for endpoint creation/deletion in migrations."""
+
+    def __init__(self, name: str, description: str, endpoint: str):
+        self.name = name
+        self.description = description
+        self.endpoint = endpoint
+
+
+def do_endpoint_change(
+    apps, schema_editor, endpoints: tuple[EndpointRecord, ...], forward: bool = True
+):
+    """
+    Apply endpoint changes, `forward` determines direction.
+
+    Forward: Creates endpoints if they don't exist (idempotent using get_or_create).
+    Reverse: Deletes endpoints by endpoint path.
+
+    Args:
+        apps: Django apps registry (historical models)
+        schema_editor: Database schema editor
+        endpoints: Tuple of EndpointRecord objects to process
+        forward: True for forward migration (create), False for reverse (delete)
+    """
+    IPFabricEndpoint = apps.get_model("ipfabric_netbox", "IPFabricEndpoint")
+    db_alias = schema_editor.connection.alias
+
+    try:
+        for endpoint_record in endpoints:
+            if forward:
+                # Forward: Create endpoint if it doesn't exist (idempotent)
+                IPFabricEndpoint.objects.using(db_alias).get_or_create(
+                    endpoint=endpoint_record.endpoint,
+                    defaults={
+                        "name": endpoint_record.name,
+                        "description": endpoint_record.description,
+                    },
+                )
+            else:
+                # Reverse: Delete endpoint by endpoint path
+                IPFabricEndpoint.objects.using(db_alias).filter(
+                    endpoint=endpoint_record.endpoint
+                ).delete()
+
+    except Exception as e:
+        print(f"Error applying endpoint changes: {e}")
+
+
+# endregion