ipfabric_netbox 4.2.2b2__py3-none-any.whl → 4.2.2b4__py3-none-any.whl

ipfabric_netbox/tests/test_forms.py

@@ -808,13 +808,6 @@ class IPFabricSyncFormTestCase(TestCase):
         )
         self.assertTrue(form.is_valid(), form.errors)
 
-    def test_form_initialization_with_source_no_data(self):
-        """Test source handling without data"""
-        form = IPFabricSyncForm(initial={"source": self.source.pk})
-
-        # Verify that source_type is set when there's a source and no data
-        self.assertEqual(form.source_type, IPFabricSourceTypeChoices.LOCAL)
-
     def test_form_initialization_with_sites_no_data(self):
         """Test sites handling without data"""
         form = IPFabricSyncForm(initial={"sites": ["site1", "site2"]})
@@ -905,9 +898,6 @@ class IPFabricSyncFormTestCase(TestCase):
         # Test form initialization with existing instance but no data
         form = IPFabricSyncForm(instance=sync_instance)
 
-        # Verify that source_type is set from the instance
-        self.assertEqual(form.source_type, IPFabricSourceTypeChoices.LOCAL)
-
         # Verify that initial values are set from instance parameters
         self.assertEqual(form.initial["source"], self.source)
         self.assertEqual(form.initial["sites"], ["site1", "site2"])
@@ -932,18 +922,121 @@ class IPFabricSyncFormTestCase(TestCase):
             instance=sync_instance, initial={"name": "Override Name"}
         )
 
-        # When initial kwargs are provided, the form skips the instance initialization block
-        # This means source_type remains None as intended by the form logic
-        self.assertIsNone(form.source_type)
-
-        # initial should not be set from instance when initial kwargs are provided
-        self.assertNotIn("source", form.initial)
-        self.assertNotIn("sites", form.initial)
-        self.assertNotIn("groups", form.initial)
+        # These should be set from instance even when not in initial kwarg
+        self.assertIn("source", form.initial)
+        self.assertIn("sites", form.initial)
+        self.assertIn("groups", form.initial)
 
         # But the provided initial value should be present
         self.assertEqual(form.initial.get("name"), "Override Name")
 
+    def test_sites_initial_value_set_from_form_initial(self):
+        """Test that sites field initial is set from self.initial["sites"]"""
+        # Create an existing sync instance with sites in parameters
+        sync_instance = IPFabricSync.objects.create(
+            name="Existing Sync",
+            snapshot_data=self.snapshot,
+            parameters={
+                "sites": ["site1", "site2"],
+                "groups": [self.transform_map_group.pk],
+            },
+        )
+
+        # Initialize form with existing instance and additional initial data for sites
+        # This will trigger the else branch where self.initial["sites"] is used
+        form = IPFabricSyncForm(
+            instance=sync_instance,
+            initial={"sites": ["override_site1", "override_site2"]},
+        )
+
+        # Verify sites field initial is set from self.initial
+        self.assertEqual(
+            form.fields["sites"].initial, ["override_site1", "override_site2"]
+        )
+
+        # Also verify that self.initial contains the expected sites
+        self.assertEqual(form.initial["sites"], ["override_site1", "override_site2"])
+
+    def test_htmx_boolean_field_list_values_handled(self):
+        """Test sanitizing HTMX BooleanField list values like ['', 'on']"""
+        # Simulate HTMX request where BooleanField values become lists
+        # This happens when `source` field value is changed and form is re-drawn via HTMX
+        form = IPFabricSyncForm(
+            initial={
+                "auto_merge": ["", "on"],  # HTMX sends BooleanField as list
+                "update_custom_fields": ["", "on"],  # Another BooleanField as list
+                "ipf_site": ["", "on"],  # ipf_ prefixed field as list
+                "name": "Test Sync",  # Normal field (not affected)
+            },
+            data={
+                "name": "Test Sync HTMX",
+                "source": self.source.pk,
+                "snapshot_data": self.snapshot.pk,
+            },
+        )
+
+        # The last value from ['', 'on'] should be 'on' which evaluates to True for BooleanFields
+        self.assertEqual(form.initial["auto_merge"], "on")
+        self.assertEqual(form.initial["update_custom_fields"], "on")
+        self.assertEqual(form.initial["ipf_site"], "on")
+        self.assertEqual(form.initial["name"], "Test Sync")  # Normal field unchanged
+
+        # Verify the form is still valid and processes correctly
+        self.assertTrue(form.is_valid(), form.errors)
+
+    def test_htmx_boolean_field_single_values_unchanged(self):
+        """Test that normal single values are not affected by the HTMX list handling"""
+        # Test with normal single values (not lists)
+        form = IPFabricSyncForm(
+            initial={
+                "auto_merge": True,  # Normal boolean value
+                "update_custom_fields": False,  # Normal boolean value
+                "ipf_site": "on",  # Normal string value
+                "name": "Test Sync",  # Normal string value
+            },
+            data={
+                "name": "Test Sync Normal",
+                "source": self.source.pk,
+                "snapshot_data": self.snapshot.pk,
+            },
+        )
+
+        # Verify that single values are not processed by value sanitization
+        self.assertEqual(form.initial["auto_merge"], True)
+        self.assertEqual(form.initial["update_custom_fields"], False)
+        self.assertEqual(form.initial["ipf_site"], "on")
+        self.assertEqual(form.initial["name"], "Test Sync")
+
+        # Verify the form is still valid
+        self.assertTrue(form.is_valid(), form.errors)
+
+    def test_clean_snapshot_does_not_belong_to_source(self):
+        """Test form validation when snapshot doesn't belong to the selected source"""
+        # Create a second source
+        different_source = IPFabricSource.objects.create(
+            name="Different Source",
+            type=IPFabricSourceTypeChoices.LOCAL,
+            url="https://different.ipfabric.local",
+            status=DataSourceStatusChoices.NEW,
+        )
+
+        # Try to use self.snapshot (which belongs to self.source) with different_source
+        form = IPFabricSyncForm(
+            data={
+                "name": "Test Sync Mismatched Source",
+                "source": different_source.pk,
+                "snapshot_data": self.snapshot.pk,  # This snapshot belongs to self.source, not different_source
+            }
+        )
+
+        # Form should be invalid due to snapshot/source mismatch validation
+        self.assertFalse(form.is_valid(), form.errors)
+        self.assertIn("snapshot_data", form.errors)
+        self.assertTrue(
+            "Snapshot does not belong to the selected source"
+            in str(form.errors["snapshot_data"])
+        )
+
     def test_clean_sites_not_part_of_snapshot(self):
         """Test form validation when selected sites are not part of the snapshot"""
         form = IPFabricSyncForm(