investing-algorithm-framework 7.16.5__py3-none-any.whl → 7.16.6__py3-none-any.whl

investing_algorithm_framework/services/metrics/trades.py

@@ -298,8 +298,7 @@ def get_average_trade_gain(trades: List[Trade]) -> Tuple[float, float]:
         trades (List[Trade]): List of trades.
 
     Returns:
-        Tuple[float, float]: The average gain
-        percentage of the average loss
+        Tuple[float, float]: The average gain and average gain percentage
     """
     if trades is None or len(trades) == 0:
         raise OperationalException(
@@ -307,19 +306,26 @@ def get_average_trade_gain(trades: List[Trade]) -> Tuple[float, float]:
         )
 
     gains = [t.net_gain_absolute for t in trades if t.net_gain_absolute > 0]
-    cost = sum(t.cost for t in trades if t.net_gain_absolute > 0)
 
     if not gains:
         return 0.0, 0.0
 
     average_gain = sum(gains) / len(gains)
-    percentage = (average_gain / cost) if cost > 0 else 0.0
-    return average_gain, percentage
 
+    # Updated percentage calculation to match other functions
+    percentage_returns = [
+        (t.net_gain_absolute / t.cost) for t in trades
+        if t.net_gain_absolute > 0 and t.cost > 0
+    ]
+    average_gain_percentage = (
+        sum(percentage_returns) / len(percentage_returns)
+        if percentage_returns else 0.0
+    )
 
-def get_current_average_trade_gain(
-    trades: List[Trade]
-) -> Tuple[float, float]:
+    return average_gain, average_gain_percentage
+
+
+def get_current_average_trade_gain(trades: List[Trade]) -> Tuple[float, float]:
     """
     Calculate the average gain from a list of trades,
     including both closed and open trades.
@@ -329,8 +335,7 @@ def get_current_average_trade_gain(
     Args:
         trades (List[Trade]): List of trades.
     Returns:
-        Tuple[float, float]: The average gain
-        percentage of the average loss
+        Tuple[float, float]: The average gain and average gain percentage
     """
     if trades is None or len(trades) == 0:
         raise OperationalException(
@@ -338,14 +343,23 @@ def get_current_average_trade_gain(
         )
 
     gains = [t.net_gain_absolute for t in trades if t.net_gain_absolute > 0]
-    cost = sum(t.cost for t in trades if t.net_gain_absolute > 0)
 
     if not gains:
         return 0.0, 0.0
 
     average_gain = sum(gains) / len(gains)
-    percentage = (average_gain / cost) if cost > 0 else 0.0
-    return average_gain, percentage
+
+    # Updated percentage calculation to match other functions
+    percentage_returns = [
+        (t.net_gain_absolute / t.cost) for t in trades
+        if t.net_gain_absolute > 0 and t.cost > 0
+    ]
+    average_gain_percentage = (
+        sum(percentage_returns) / len(percentage_returns)
+        if percentage_returns else 0.0
+    )
+
+    return average_gain, average_gain_percentage
 
 
 def get_average_trade_loss(trades: List[Trade]) -> Tuple[float, float]:

{investing_algorithm_framework-7.16.5.dist-info → investing_algorithm_framework-7.16.6.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: investing-algorithm-framework
-Version: 7.16.5
+Version: 7.16.6
 Summary: A framework for creating trading bots
 Author: MDUYN
 Requires-Python: >=3.10

{investing_algorithm_framework-7.16.5.dist-info → investing_algorithm_framework-7.16.6.dist-info}/RECORD

@@ -225,7 +225,7 @@ investing_algorithm_framework/services/metrics/risk_free_rate.py,sha256=bATheWxy
 investing_algorithm_framework/services/metrics/sharpe_ratio.py,sha256=XDEiTUBoK-qpoeqmbhrcy1v-AuNagWhTWx_Myn0g8-A,5497
 investing_algorithm_framework/services/metrics/sortino_ratio.py,sha256=WA8uTkyk8RMG6uMplCvV8okAlKG_aeTP4ZAX2VyNkpA,2993
 investing_algorithm_framework/services/metrics/standard_deviation.py,sha256=oObshTljORuE3x1cS0wej8QCqmDzAwHQgOA5u_HdfbU,4533
-investing_algorithm_framework/services/metrics/trades.py,sha256=BR-9jcgVq9vXxfborngS7gYWwbDkcS2HikjYjQwnjRQ,13632
+investing_algorithm_framework/services/metrics/trades.py,sha256=SFp3Zc71xzjux06dNUm9H352OGO2XBXk8W_WrQ8-kd4,14052
 investing_algorithm_framework/services/metrics/treynor_ratio.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 investing_algorithm_framework/services/metrics/ulcer.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 investing_algorithm_framework/services/metrics/value_at_risk.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
@@ -252,8 +252,8 @@ investing_algorithm_framework/services/trade_order_evaluator/default_trade_order
 investing_algorithm_framework/services/trade_order_evaluator/trade_order_evaluator.py,sha256=pNnmgaKMR9RY6Kxq7xS0nURKoaQDe2ehrP5GfElkkcI,1328
 investing_algorithm_framework/services/trade_service/__init__.py,sha256=AcwPyJjDRdiREnl_MWMkDSc-V-ZjXtvpHD6eQT9mc1o,68
 investing_algorithm_framework/services/trade_service/trade_service.py,sha256=OtzIS5EebByGcqDvV2AFeBjXSarvrgubMXDaVKg6Rbw,41193
-investing_algorithm_framework-7.16.5.dist-info/LICENSE,sha256=wbVEDvoZiMPHufRY3sLEffvAr7GH5hOIngHF8y4HFQg,11343
-investing_algorithm_framework-7.16.5.dist-info/METADATA,sha256=PDdQOPVtpBaJR049eQ2TRI4iNvN-_76E74zrCoT1HdI,19635
-investing_algorithm_framework-7.16.5.dist-info/WHEEL,sha256=FMvqSimYX_P7y0a7UY-_Mc83r5zkBZsCYPm7Lr0Bsq4,88
-investing_algorithm_framework-7.16.5.dist-info/entry_points.txt,sha256=jrPF0YksDs27vYzEvj3tXLe3OGWU24EJA05z5xHqmq8,91
-investing_algorithm_framework-7.16.5.dist-info/RECORD,,
+investing_algorithm_framework-7.16.6.dist-info/LICENSE,sha256=wbVEDvoZiMPHufRY3sLEffvAr7GH5hOIngHF8y4HFQg,11343
+investing_algorithm_framework-7.16.6.dist-info/METADATA,sha256=w6BMuWR2lWxlgiUwyzAmdYUdOlAQUke8pdO46Dp7uWY,19635
+investing_algorithm_framework-7.16.6.dist-info/WHEEL,sha256=FMvqSimYX_P7y0a7UY-_Mc83r5zkBZsCYPm7Lr0Bsq4,88
+investing_algorithm_framework-7.16.6.dist-info/entry_points.txt,sha256=jrPF0YksDs27vYzEvj3tXLe3OGWU24EJA05z5xHqmq8,91
+investing_algorithm_framework-7.16.6.dist-info/RECORD,,