invenio-app-ils 4.5.0__py2.py3-none-any.whl → 5.0.0__py2.py3-none-any.whl

tests/api/circulation/test_loan_update.py

@@ -1,150 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test loan update."""
-import json
-from copy import deepcopy
-from datetime import date, timedelta
-
-from flask import url_for
-from invenio_circulation.api import Loan
-
-from tests.helpers import user_login, user_logout
-
-
-def _url_loan(pid_value):
-    return url_for("invenio_records_rest.loanid_item", pid_value=pid_value)
-
-
-def _post_loan_update(
-    client,
-    json_headers,
-    pid_value,
-    start_date=None,
-    end_date=None,
-    request_start_date=None,
-    request_expire_date=None,
-):
-    url = url_for(
-        "invenio_app_ils_circulation.loanid_update_dates", pid_value=pid_value
-    )
-    data = {}
-    if start_date:
-        data["start_date"] = start_date
-    if end_date:
-        data["end_date"] = end_date
-    if request_start_date:
-        data["request_start_date"] = request_start_date
-    if request_expire_date:
-        data["request_expire_date"] = request_expire_date
-    res = client.post(url, headers=json_headers, data=json.dumps(data))
-    return res
-
-
-def _load_result(res):
-    return json.loads(res.data.decode("utf-8"))
-
-
-def _today(dt=0):
-    return (date.today() + timedelta(days=dt)).strftime("%Y-%m-%d")
-
-
-def test_loan_access_permission(client, json_headers, users, testdata):
-    """
-    Test that a patron should not be able to update their loan;
-    and a fortiori, other people's.
-    """
-    loan = testdata["loans"][0]
-    user = user_login(client, "patron1", users)
-    url = _url_loan(loan["pid"])
-    res = client.get(url, headers=json_headers)
-    assert res.status_code == 200  # Can access their own loan
-    metadata = _load_result(res)["metadata"]
-    metadata["transaction_user_pid"] = str(user.id)
-    res = client.put(url, headers=json_headers, data=json.dumps(metadata))
-    assert res.status_code == 403  # Cannot modify the loan
-
-
-def test_loan_update_date(client, json_headers, users, testdata):
-    """Test the edition of the dates on a loan."""
-    pid = testdata["loans"][4]["pid"]  # Item on loan
-
-    res = _post_loan_update(client, json_headers, pid)
-    assert res.status_code == 401
-
-    # Patron cannot update loan
-    user_login(client, "patron1", users)
-    res = _post_loan_update(client, json_headers, pid)
-    assert res.status_code == 403
-    user_logout(client)
-
-    # Librarian can
-    user_login(client, "librarian", users)
-    old_loan = _load_result(client.get(_url_loan(pid), headers=json_headers))
-    res = _post_loan_update(client, json_headers, pid)
-    assert res.status_code == 202
-    new_loan = _load_result(res)
-    assert old_loan["updated"] < new_loan["updated"]  # Liveness check
-
-    # Update both values
-    start_date = "2020-01-01"
-    end_date = _today(+1)
-    res = _post_loan_update(
-        client, json_headers, pid, start_date=start_date, end_date=end_date
-    )
-    assert res.status_code == 202
-    new_loan_meta = _load_result(res)["metadata"]
-    assert new_loan_meta["start_date"] == start_date
-    assert new_loan_meta["end_date"] == end_date
-
-    # Start date after today
-    start_date = _today(+2)
-    end_date = _today(+3)
-    res = _post_loan_update(
-        client, json_headers, pid, start_date=start_date, end_date=end_date
-    )
-    assert res.status_code == 400
-
-    # No relative constraints on non-active loans
-    pid = testdata["loans"][3]["pid"]  # Pending
-    res = _post_loan_update(
-        client,
-        json_headers,
-        pid,
-        request_start_date=start_date,
-        request_expire_date=end_date,
-    )
-    assert res.status_code == 202
-    new_loan_meta = _load_result(res)["metadata"]
-    assert new_loan_meta["request_start_date"] == start_date
-    assert new_loan_meta["request_expire_date"] == end_date
-
-    # Negative date range
-    start_date = "2000-02-01"
-    end_date = "2000-01-01"
-    res = _post_loan_update(
-        client,
-        json_headers,
-        pid,
-        request_start_date=start_date,
-        request_expire_date=end_date,
-    )
-    assert res.status_code == 400
-
-    # Illegal combination of parameters
-    start_date = _today(-2)
-    end_date = _today(+2)
-    res = _post_loan_update(
-        client,
-        json_headers,
-        pid,
-        start_date=start_date,
-        end_date=end_date,
-        request_start_date=start_date,
-        request_expire_date=end_date,
-    )
-    assert res.status_code == 400

tests/api/circulation/test_notifications.py

@@ -1,221 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test email notifications on transitions."""
-
-import random
-from datetime import timedelta
-
-import arrow
-from flask import current_app, url_for
-from invenio_circulation.api import Loan
-from invenio_circulation.proxies import current_circulation
-from invenio_indexer.api import RecordIndexer
-from invenio_search import current_search
-
-from invenio_app_ils.circulation.notifications.tasks import (
-    send_expiring_loans_notification_reminder,
-    send_overdue_loans_notification_reminder,
-)
-from invenio_app_ils.documents.api import Document
-from invenio_app_ils.patrons.api import Patron
-from tests.helpers import user_login, user_logout
-
-
-def test_notifs_on_loan_checkout(client, app_with_notifs, users, testdata, loan_params):
-    """Test that an email is sent on loan checkout."""
-    loan_data = testdata["loans"][1]
-    loan = Loan.get_record_by_pid(loan_data["pid"])
-    with app_with_notifs.extensions["mail"].record_messages() as outbox:
-        user_login(client, "admin", users)
-
-        assert len(outbox) == 0
-        current_circulation.circulation.trigger(
-            loan, **dict(loan_params, trigger="checkout")
-        )
-        assert len(outbox) == 1
-        msg = outbox[0]
-
-    doc = Document.get_record_by_pid(loan_data["document_pid"])
-    expected_subject = 'InvenioILS: loan started for "{0}"'.format(doc["title"])
-    assert msg.subject == expected_subject
-
-    edition_year = " ({edition} - {year})".format(
-        edition=doc["edition"], year=doc["publication_year"]
-    )
-    full_title = "{title}, {author}{edition_year}".format(
-        title=doc["title"],
-        author=doc["authors"][0]["full_name"],
-        edition_year=edition_year,
-    )
-
-    literature_url = "{host}{path}".format(
-        host=current_app.config["SPA_HOST"],
-        path=current_app.config["SPA_PATHS"]["literature"] % {"pid": doc["pid"]},
-    )
-    profile_url = "{host}{path}".format(
-        host=current_app.config["SPA_HOST"],
-        path=current_app.config["SPA_PATHS"]["profile"],
-    )
-    expected_body_plain = """Dear Patron One,
-
-your loan for "{doc_full_title}" <{literature_url}> has started.
-
-The due date is {loan_end_date}.
-
-You can see your ongoing and past loans in your profile page <{profile_url}>.
-
-Kind regards,
-InvenioILS""".format(
-        doc_full_title=full_title,
-        literature_url=literature_url,
-        loan_end_date=loan_data["end_date"],
-        profile_url=profile_url,
-    )
-    assert msg.body == expected_body_plain
-
-
-def test_notification_on_overdue_permissions(client, testdata, json_headers, users):
-    """Test that only the backoffice can send a reminder."""
-    pid = testdata["loans"][0]["pid"]
-    url = url_for("invenio_app_ils_circulation.loanid_notification", pid_value=pid)
-    tests = [("patron1", 403), ("anonymous", 401)]
-    for username, expected_status in tests:
-        user_login(client, username, users)
-        res = client.post(url, headers=json_headers)
-        assert res.status_code == expected_status
-
-
-def test_notification_on_overdue_loans(
-    app_with_notifs, db, users, testdata, mocker, client, json_headers
-):
-    """Test that an email is sent for a loan that is overdue."""
-    mocker.patch(
-        "invenio_app_ils.patrons.api.Patron.get_patron",
-        return_value=Patron(users["patron1"].id),
-    )
-
-    def prepare_data():
-        """Prepare data."""
-        days = current_app.config[
-            "ILS_CIRCULATION_NOTIFICATION_OVERDUE_REMINDER_INTERVAL"
-        ]
-        loans = testdata["loans"]
-
-        recs = []
-        now = arrow.utcnow()
-
-        def new_end_date(loan, date):
-            loan["end_date"] = date.date().isoformat()
-            loan["state"] = "ITEM_ON_LOAN"
-            loan.commit()
-            recs.append(loan)
-
-        # overdue loans
-        date = now - timedelta(days=days)
-        new_end_date(loans[0], date)
-
-        date = now - timedelta(days=days * 2)
-        new_end_date(loans[1], date)
-
-        # not overdue
-        date = now - timedelta(days=-1)
-        new_end_date(loans[2], date)
-
-        # not overdue or overdue but not to be notified
-        remaining_not_overdue = loans[3:]
-        for loan in remaining_not_overdue:
-            days = random.choice([-1, 0, 1])
-            date = now - timedelta(days=days)
-            new_end_date(loan, date)
-        db.session.commit()
-
-        indexer = RecordIndexer()
-        for rec in recs:
-            indexer.index(rec)
-
-        current_search.flush_and_refresh(index="*")
-
-    user_login(client, "librarian", users)
-
-    # test individual overdue loan
-    prepare_data()
-    loans = testdata["loans"]
-
-    notification_url = url_for(
-        "invenio_app_ils_circulation.loanid_notification",
-        pid_value=loans[0]["pid"],
-    )
-
-    res = client.post(notification_url, headers=json_headers)
-    assert res.status_code == 202
-
-    # test individual not overdue loan
-    notification_url = url_for(
-        "invenio_app_ils_circulation.loanid_notification",
-        pid_value=loans[2]["pid"],
-    )
-
-    res = client.post(notification_url, headers=json_headers)
-    assert res.status_code == 400
-
-    user_logout(client)
-
-    # test all loans
-    with app_with_notifs.extensions["mail"].record_messages() as outbox:
-        assert len(outbox) == 0
-        send_overdue_loans_notification_reminder.apply_async()
-        assert len(outbox) == 2
-
-
-def test_notification_on_expiring_loans(app_with_notifs, db, users, testdata, mocker):
-    """Test that an email is sent for a loan that is about to expire."""
-    mocker.patch(
-        "invenio_app_ils.patrons.api.Patron.get_patron",
-        return_value=Patron(users["patron1"].id),
-    )
-
-    def prepare_data():
-        """Prepare data."""
-        max_days = current_app.config["ILS_CIRCULATION_LOAN_WILL_EXPIRE_DAYS"]
-        loans = testdata["loans"]
-
-        recs = []
-        now = arrow.utcnow()
-
-        def new_end_date(loan, date):
-            loan["end_date"] = date.date().isoformat()
-            loan["state"] = "ITEM_ON_LOAN"
-            loan.commit()
-            recs.append(loan)
-
-        # expiring loans
-        date = now + timedelta(days=max_days)
-        new_end_date(loans[0], date)
-        new_end_date(loans[1], date)
-        new_end_date(loans[2], date)
-
-        # not expiring
-        remaining_not_overdue = loans[3:]
-        for loan in remaining_not_overdue:
-            days = random.choice([-2, -1, 1, max_days + 1])
-            date = now + timedelta(days=days)
-            new_end_date(loan, date)
-        db.session.commit()
-
-        indexer = RecordIndexer()
-        for rec in recs:
-            indexer.index(rec)
-
-        current_search.flush_and_refresh(index="*")
-
-    prepare_data()
-
-    with app_with_notifs.extensions["mail"].record_messages() as outbox:
-        assert len(outbox) == 0
-        send_expiring_loans_notification_reminder.apply_async()
-        assert len(outbox) == 3

tests/api/conftest.py

@@ -1,227 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2018-2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Pytest fixtures and plugins for the API application."""
-
-import tempfile
-
-import pytest
-from invenio_app.factory import create_api
-from invenio_circulation.api import Loan
-from invenio_circulation.pidstore.pids import CIRCULATION_LOAN_PID_TYPE
-from invenio_indexer.api import RecordIndexer
-from invenio_search import current_search
-
-from invenio_app_ils.acquisition.api import ORDER_PID_TYPE, Order
-from invenio_app_ils.document_requests.api import (
-    DOCUMENT_REQUEST_PID_TYPE,
-    DocumentRequest,
-)
-from invenio_app_ils.documents.api import DOCUMENT_PID_TYPE, Document
-from invenio_app_ils.eitems.api import EITEM_PID_TYPE, EItem
-from invenio_app_ils.ill.api import BORROWING_REQUEST_PID_TYPE, BorrowingRequest
-from invenio_app_ils.internal_locations.api import (
-    INTERNAL_LOCATION_PID_TYPE,
-    InternalLocation,
-)
-from invenio_app_ils.items.api import ITEM_PID_TYPE, Item
-from invenio_app_ils.locations.api import LOCATION_PID_TYPE, Location
-from invenio_app_ils.providers.api import PROVIDER_PID_TYPE, Provider
-from invenio_app_ils.series.api import SERIES_PID_TYPE, Series
-from tests.helpers import (
-    document_ref_builder,
-    internal_location_ref_builder,
-    load_json_from_datadir,
-    mint_record_pid,
-)
-
-
-@pytest.fixture(scope="module")
-def app_config(app_config):
-    """Get app config."""
-    tests_config = {
-        "REST_CSRF_ENABLED": False,
-        "ACCOUNTS_SESSION_REDIS_URL": "",  # in-memory
-        "RATELIMIT_GUEST_USER": "1000 per minute",
-        "RATELIMIT_AUTHENTICATED_USER": "1000 per minute",
-        "CIRCULATION_TRANSACTION_USER_VALIDATOR": lambda x: True,
-        "EXTEND_LOANS_LOCATION_UPDATED": False,
-        "ILS_NOTIFICATIONS_TEMPLATES": {"footer": "footer.html"},
-    }
-    app_config.update(tests_config)
-    return app_config
-
-
-@pytest.fixture(scope="module")
-def create_app():
-    """Create test app."""
-    return create_api
-
-
-@pytest.fixture()
-def json_headers():
-    """JSON headers."""
-    return [
-        ("Content-Type", "application/json"),
-        ("Accept", "application/json"),
-    ]
-
-
-def _create_records(db, objs, cls, pid_type):
-    """Create records and index."""
-    recs = []
-    for obj in objs:
-        record = cls.create(obj)
-        mint_record_pid(pid_type, "pid", record)
-        recs.append(record)
-    db.session.commit()
-    return recs
-
-
-@pytest.fixture()
-def testdata(app, db, search_clear, users):
-    """Create, index and return test data."""
-    data = load_json_from_datadir("locations.json")
-    locations = _create_records(db, data, Location, LOCATION_PID_TYPE)
-
-    data = load_json_from_datadir("internal_locations.json")
-    int_locs = _create_records(db, data, InternalLocation, INTERNAL_LOCATION_PID_TYPE)
-
-    data = load_json_from_datadir("series.json")
-    series = _create_records(db, data, Series, SERIES_PID_TYPE)
-
-    data = load_json_from_datadir("documents.json")
-    documents = _create_records(db, data, Document, DOCUMENT_PID_TYPE)
-
-    data = load_json_from_datadir("items.json")
-    items = _create_records(db, data, Item, ITEM_PID_TYPE)
-
-    data = load_json_from_datadir("eitems.json")
-    eitems = _create_records(db, data, EItem, EITEM_PID_TYPE)
-
-    data = load_json_from_datadir("loans.json")
-    loans = _create_records(db, data, Loan, CIRCULATION_LOAN_PID_TYPE)
-
-    data = load_json_from_datadir("acq_providers.json")
-    acq_providers = _create_records(db, data, Provider, PROVIDER_PID_TYPE)
-
-    data = load_json_from_datadir("acq_orders.json")
-    acq_orders = _create_records(db, data, Order, ORDER_PID_TYPE)
-
-    data = load_json_from_datadir("ill_providers.json")
-    ill_providers = _create_records(db, data, Provider, PROVIDER_PID_TYPE)
-
-    data = load_json_from_datadir("ill_borrowing_requests.json")
-    ill_brw_reqs = _create_records(
-        db, data, BorrowingRequest, BORROWING_REQUEST_PID_TYPE
-    )
-
-    data = load_json_from_datadir("document_requests.json")
-    doc_reqs = _create_records(db, data, DocumentRequest, DOCUMENT_REQUEST_PID_TYPE)
-
-    # index
-    ri = RecordIndexer()
-    for rec in (
-        locations
-        + int_locs
-        + series
-        + documents
-        + items
-        + eitems
-        + loans
-        + doc_reqs
-        + acq_providers
-        + acq_orders
-        + ill_providers
-        + ill_brw_reqs
-    ):
-        ri.index(rec)
-
-    current_search.flush_and_refresh(index="*")
-
-    return {
-        "document_requests": doc_reqs,
-        "documents": documents,
-        "internal_locations": int_locs,
-        "items": items,
-        "eitems": eitems,
-        "loans": loans,
-        "locations": locations,
-        "series": series,
-        "acq_providers": acq_providers,
-        "acq_orders": acq_orders,
-        "ill_providers": ill_providers,
-        "ill_brw_reqs": ill_brw_reqs,
-    }
-
-
-@pytest.fixture()
-def testdata_most_loaned(db, testdata):
-    """Create, index and return test data for most loans tests."""
-    most_loaned = load_json_from_datadir("loans_most_loaned.json")
-    recs = _create_records(db, most_loaned, Loan, CIRCULATION_LOAN_PID_TYPE)
-
-    ri = RecordIndexer()
-    for rec in recs:
-        ri.index(rec)
-
-    current_search.flush_and_refresh(index="loans")
-
-    return {
-        "locations": testdata["locations"],
-        "internal_locations": testdata["internal_locations"],
-        "documents": testdata["documents"],
-        "items": testdata["items"],
-        "loans": most_loaned,
-        "series": testdata["series"],
-    }
-
-
-@pytest.fixture()
-def item_record(app):
-    """Fixture to return an Item payload."""
-    return {
-        "pid": "itemid-1",
-        "document_pid": "docid-1",
-        "document": {"$ref": document_ref_builder(app, "itemid-1")},
-        "barcode": "123456789-1",
-        "title": "Test item x",
-        "internal_location_pid": "ilocid-1",
-        "internal_location": {"$ref": internal_location_ref_builder(app, "itemid-1")},
-        "medium": "NOT_SPECIFIED",
-        "status": "CAN_CIRCULATE",
-        "circulation_restriction": "NO_RESTRICTION",
-    }
-
-
-@pytest.fixture()
-def loan_params():
-    """Params for API REST payload."""
-    return dict(
-        transaction_user_pid="4",
-        patron_pid="1",
-        document_pid="docid-1",
-        item_pid=dict(type="pitmid", value="itemid-2"),
-        transaction_location_pid="locid-1",
-        transaction_date="2018-02-01T09:30:00+02:00",
-    )
-
-
-@pytest.fixture()
-def bucket(bucket_from_dir):
-    """Create temporary bucket fixture."""
-    with tempfile.TemporaryDirectory(prefix="ils-test-") as temp_dir:
-        bucket = bucket_from_dir(temp_dir)
-        yield bucket
-
-
-@pytest.fixture()
-def with_access(app):
-    """Enable explicit permission check (`_access`)."""
-    app.config["ILS_RECORDS_EXPLICIT_PERMISSIONS_ENABLED"] = True
-    yield
-    app.config["ILS_RECORDS_EXPLICIT_PERMISSIONS_ENABLED"] = False

tests/api/document_requests/__init__.py

@@ -1,8 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Document Requests API Tests."""