invenio-app-ils 1.0.0a54__py2.py3-none-any.whl → 6.1.0__py2.py3-none-any.whl

tests/api/acquisition/test_acq_orders_permissions.py

@@ -1,104 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test acquisition orders."""
-
-import json
-
-from flask import url_for
-
-from tests.helpers import user_login
-
-_HTTP_OK = [200, 201, 204]
-ORDER_PID = "acqoid-1"
-ITEM_ENDPOINT = "invenio_records_rest.acqoid_item"
-LIST_ENDPOINT = "invenio_records_rest.acqoid_list"
-
-
-def test_acq_orders_permissions(client, testdata, json_headers, users):
-    """Test orders endpoints permissions."""
-    dummy_acquisition_order = dict(
-        status="PENDING",
-        order_date="2020-02-25",
-        provider_pid="acq-provid-1",
-        order_lines=[
-            dict(
-                copies_ordered=3,
-                document_pid="docid-1",
-                medium="paper",
-                recipient="library",
-            )
-        ],
-    )
-
-    def _test_list(expected_status):
-        """Test get list."""
-        url = url_for(LIST_ENDPOINT)
-        res = client.get(url, headers=json_headers)
-        assert res.status_code in expected_status
-
-    def _test_create(expected_status, data, user):
-        """Test record creation."""
-        url = url_for(LIST_ENDPOINT)
-        res = client.post(url, headers=json_headers, data=json.dumps(data))
-        assert res.status_code in expected_status
-
-        if res.status_code < 400:
-            ord = res.get_json()["metadata"]
-            assert ord["status"] == "PENDING"
-            expected_created_by = dict(type="user_id", value=str(user.id))
-            assert ord["created_by"] == expected_created_by
-            assert not ord.get("updated_by")
-            return ord["pid"]
-
-    def _test_update(expected_status, data, pid, user):
-        """Test record update."""
-        pid_value = pid or ORDER_PID
-        url = url_for(ITEM_ENDPOINT, pid_value=pid_value)
-        res = client.put(url, headers=json_headers, data=json.dumps(data))
-        assert res.status_code in expected_status
-        if res.status_code < 400:
-            expected_changed_by = dict(type="user_id", value=str(user.id))
-            ord = res.get_json()["metadata"]
-            assert ord["created_by"] == expected_changed_by
-            assert ord["updated_by"] == expected_changed_by
-
-    def _test_read(expected_status, pid):
-        """Test record read."""
-        pid_value = pid or ORDER_PID
-        url = url_for(ITEM_ENDPOINT, pid_value=pid_value)
-        res = client.get(url, headers=json_headers)
-        assert res.status_code in expected_status
-
-    def _test_delete(expected_status, pid):
-        """Test record delete."""
-        url = url_for(ITEM_ENDPOINT, pid_value=pid)
-        res = client.delete(url, headers=json_headers)
-        assert res.status_code in expected_status
-
-    tests = [
-        ("admin", _HTTP_OK, dummy_acquisition_order),
-        ("librarian", _HTTP_OK, dummy_acquisition_order),
-        ("patron1", [403], dummy_acquisition_order),
-        ("anonymous", [401], dummy_acquisition_order),
-    ]
-    for username, expected_status, data in tests:
-        user = user_login(client, username, users)
-        _test_list(expected_status)
-        pid = _test_create(expected_status, data, user)
-        _test_update(expected_status, data, pid, user)
-        _test_read(expected_status, pid)
-
-    tests = [
-        ("patron1", [403]),
-        ("anonymous", [401]),
-        ("librarian", [403]),
-        ("admin", [204]),
-    ]
-    for username, expected_status in tests:
-        user_login(client, username, users)
-        _test_delete(expected_status, ORDER_PID)

tests/api/acquisition/test_acq_providers_permissions.py

@@ -1,83 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test acquisition provider."""
-
-import json
-
-from flask import url_for
-
-from tests.helpers import user_login
-
-_HTTP_OK = [200, 201, 204]
-PROVIDER_PID = "acq-provid-1"
-PROVIDER_NAME = "A provider"
-PROVIDER_TYPE = "VENDOR"
-ITEM_ENDPOINT = "invenio_records_rest.provid_item"
-LIST_ENDPOINT = "invenio_records_rest.provid_list"
-
-
-def test_acq_providers_permissions(client, testdata, json_headers, users):
-    """Test providers endpoints permissions."""
-    dummy_acquisition_provider = dict(name=PROVIDER_NAME, type=PROVIDER_TYPE)
-    tests = [
-        ("admin", _HTTP_OK, dummy_acquisition_provider),
-        ("librarian", _HTTP_OK, dummy_acquisition_provider),
-        ("patron1", [403], dummy_acquisition_provider),
-        ("anonymous", [401], dummy_acquisition_provider),
-    ]
-
-    def _test_list(expected_status):
-        """Test get list."""
-        url = url_for(LIST_ENDPOINT)
-        res = client.get(url, headers=json_headers)
-        assert res.status_code in expected_status
-
-    def _test_create(expected_status, data):
-        """Test record creation."""
-        url = url_for(LIST_ENDPOINT)
-        print("DICT", json.dumps(data))
-        res = client.post(url, headers=json_headers, data=json.dumps(data))
-        assert res.status_code in expected_status
-
-        if res.status_code < 400:
-            record = res.get_json()["metadata"]
-            assert record["name"] == PROVIDER_NAME
-            assert record["type"] == PROVIDER_TYPE
-            return record["pid"]
-
-    def _test_update(expected_status, data, pid):
-        """Test record update."""
-        pid_value = pid or PROVIDER_PID
-        url = url_for(ITEM_ENDPOINT, pid_value=pid_value)
-        res = client.put(url, headers=json_headers, data=json.dumps(data))
-        assert res.status_code in expected_status
-        if res.status_code < 400:
-            record = res.get_json()["metadata"]
-            assert record["name"] == PROVIDER_NAME
-
-    def _test_read(expected_status, pid):
-        """Test record read."""
-        pid_value = pid or PROVIDER_PID
-        url = url_for(ITEM_ENDPOINT, pid_value=pid_value)
-        res = client.get(url, headers=json_headers)
-        assert res.status_code in expected_status
-
-    def _test_delete(expected_status, pid):
-        """Test record delete."""
-        pid_value = pid or PROVIDER_PID
-        url = url_for(ITEM_ENDPOINT, pid_value=pid_value)
-        res = client.delete(url, headers=json_headers)
-        assert res.status_code in expected_status
-
-    for username, expected_status, data in tests:
-        user_login(client, username, users)
-        _test_list(expected_status)
-        pid = _test_create(expected_status, data)
-        _test_update(expected_status, data, pid)
-        _test_read(expected_status, pid)
-        _test_delete(expected_status, pid)

tests/api/circulation/test_expired_loans.py

@@ -1,88 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test transitions on expiring loans."""
-
-from datetime import timedelta
-
-import arrow
-from flask import url_for
-from invenio_indexer.api import RecordIndexer
-from invenio_search import current_search
-
-from invenio_app_ils.circulation.tasks import cancel_expired_loan_requests
-from invenio_app_ils.patrons.api import SystemAgent
-from tests.helpers import user_login
-
-
-def test_cancel_expired_loans(client, json_headers, db, users, testdata):
-    """Test cancellation of loan requests after expiration date."""
-
-    user_login(client, "admin", users)
-
-    def prepare_data():
-        """Prepare data."""
-        loans = testdata["loans"]
-
-        recs = []
-        now = arrow.utcnow()
-
-        def new_expiration_date(loan, date):
-            loan["request_expire_date"] = date.date().isoformat()
-            loan["state"] = "PENDING"
-            loan.commit()
-            recs.append(loan)
-
-        # expired loans
-        date = now - timedelta(days=1)
-        new_expiration_date(loans[0], date)
-        new_expiration_date(loans[1], date)
-        date = now - timedelta(days=2)
-        new_expiration_date(loans[2], date)
-        expired_pids = [loans[0]["pid"], loans[1]["pid"], loans[2]["pid"]]
-
-        # not expired loans
-        not_expired_pids = []
-        remaining_not_expired = loans[3:]
-        n_days = 0  # today
-        for loan in remaining_not_expired:
-            date = now + timedelta(days=n_days)
-            new_expiration_date(loan, date)
-            not_expired_pids.append(loan["pid"])
-            n_days += 1
-        db.session.commit()
-
-        indexer = RecordIndexer()
-        for rec in recs:
-            indexer.index(rec)
-
-        current_search.flush_and_refresh(index="*")
-        return expired_pids, not_expired_pids
-
-    expired_pids, not_expired_pids = prepare_data()
-
-    # trigger cancel expired loan requests
-    cancel_expired_loan_requests.apply_async()
-
-    for pid_value in expired_pids:
-        res = client.get(
-            url_for("invenio_records_rest.loanid_item", pid_value=pid_value),
-            headers=json_headers,
-        )
-        loan = res.get_json()["metadata"]
-        assert loan["state"] == "CANCELLED"
-        assert "cancel_reason" in loan
-        assert loan["transaction_user_pid"] == str(SystemAgent.id)
-
-    for pid_value in not_expired_pids:
-        res = client.get(
-            url_for("invenio_records_rest.loanid_item", pid_value=pid_value),
-            headers=json_headers,
-        )
-        loan = res.get_json()["metadata"]
-        assert loan["state"] == "PENDING"
-        assert "cancel_reason" not in loan

tests/api/circulation/test_loan_checkout.py

@@ -1,216 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2018-2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test loans item permissions."""
-
-import json
-from copy import deepcopy
-from datetime import timedelta
-
-import arrow
-from flask import url_for
-from flask_principal import UserNeed
-from invenio_access.permissions import Permission
-
-from invenio_app_ils.items.api import Item
-from tests.helpers import user_login
-
-NEW_LOAN = {
-    "item_pid": "CHANGE ME IN EACH TEST",
-    "document_pid": "docid-1",
-    "patron_pid": "3",
-    "transaction_location_pid": "locid-1",
-    "pickup_location_pid": "locid-1",
-    "delivery": {"method": "PICK_UP"},
-}
-
-
-def test_anonymous_cannot_request_loan_on_item(client, json_headers, testdata):
-    """Test that anonymous users cannot request a loan on a item."""
-    url = url_for("invenio_app_ils_circulation.loan_checkout")
-    res = client.post(url, headers=json_headers, data=json.dumps(NEW_LOAN))
-    assert res.status_code == 401
-
-
-def test_librarian_can_checkout_item_for_user(
-    client, json_headers, users, testdata
-):
-    """Test that librarian can checkout a loan on a item for a patron."""
-    user_login(client, "librarian", users)
-    url = url_for("invenio_app_ils_circulation.loan_checkout")
-    params = deepcopy(NEW_LOAN)
-    params["transaction_user_pid"] = str(users["librarian"].id)
-    params["item_pid"] = dict(type="pitmid", value="itemid-60")
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-    loan = res.get_json()["metadata"]
-    assert loan["state"] == "ITEM_ON_LOAN"
-    assert loan["item_pid"] == params["item_pid"]
-    assert loan["document_pid"] == params["document_pid"]
-    assert loan["patron_pid"] == params["patron_pid"]
-
-
-def test_force_checkout_specific_permissions(
-    app, client, json_headers, users, testdata
-):
-    """Test that only allowed users can perform a force checkout."""
-    default_factory = app.config["ILS_VIEWS_PERMISSIONS_FACTORY"]
-    librarian2 = users["librarian2"]
-
-    # override default permission factory to require specific permission for
-    # force-checkout action
-    def custom_views_permissions_factory(action):
-        if action == "circulation-loan-force-checkout":
-            # fake permission for a specific user
-            return Permission(UserNeed(librarian2.id))
-        else:
-            return default_factory(action)
-
-    app.config[
-        "ILS_VIEWS_PERMISSIONS_FACTORY"
-    ] = custom_views_permissions_factory
-
-    # prepare request
-    url = url_for("invenio_app_ils_circulation.loan_checkout")
-    params = deepcopy(NEW_LOAN)
-    params["force"] = True
-    params["item_pid"] = dict(type="pitmid", value="itemid-MISSING")
-    params["transaction_user_pid"] = str(librarian2.id)
-
-    # force-checkout as librarian should fail
-    user_login(client, "librarian", users)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 403
-
-    # force-checkout as librarian2 should succeed
-    user_login(client, "librarian2", users)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-    loan = res.get_json()["metadata"]
-    assert loan["state"] == "ITEM_ON_LOAN"
-    assert loan["item_pid"] == params["item_pid"]
-    assert loan["document_pid"] == params["document_pid"]
-    assert loan["patron_pid"] == params["patron_pid"]
-
-    # restore default config
-    app.config["ILS_VIEWS_PERMISSIONS_FACTORY"] = default_factory
-
-
-def test_checkout_conditions_librarian(client, json_headers, users, testdata):
-    """Test checkout conditions user."""
-    librarian = users["librarian"]
-    user_login(client, "librarian", users)
-    url = url_for("invenio_app_ils_circulation.loan_checkout")
-
-    params = deepcopy(NEW_LOAN)
-    params["item_pid"] = dict(type="pitmid", value="itemid-61")
-    params["transaction_user_pid"] = str(librarian.id)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-
-    params = deepcopy(NEW_LOAN)
-    params["item_pid"] = dict(type="pitmid", value="itemid-MISSING")
-    params["transaction_user_pid"] = str(librarian.id)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    # missing
-    assert res.status_code == 400
-
-    params = deepcopy(NEW_LOAN)
-    params["force"] = True
-    params["item_pid"] = dict(type="pitmid", value="itemid-MISSING")
-    params["transaction_user_pid"] = str(librarian.id)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    # missing but force
-    assert res.status_code == 202
-    item = Item.get_record_by_pid(params["item_pid"]["value"])
-    assert item["status"] == "CAN_CIRCULATE"
-
-
-def test_checkout_loader_start_end_dates(
-    app, client, json_headers, users, testdata
-):
-    """Test that start and end dates request parameters."""
-    librarian = users["librarian"]
-    user_login(client, "librarian", users)
-    item_pid = dict(type="pitmid", value="itemid-61")
-    url = url_for("invenio_app_ils_circulation.loan_checkout")
-    # fake duration for first item
-    loan_duration_timedelta = app.config["CIRCULATION_POLICIES"]["checkout"][
-        "duration_default"
-    ](dict(item_pid=item_pid), dict())
-    now = arrow.utcnow()
-
-    # it should succeed when no start/end dates provided
-    start_date = now.date().isoformat()
-    end_date = (now + loan_duration_timedelta).date().isoformat()
-
-    params = deepcopy(NEW_LOAN)
-    params["item_pid"] = item_pid
-    params["transaction_user_pid"] = str(librarian.id)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-    loan = res.get_json()["metadata"]
-    assert loan["state"] == "ITEM_ON_LOAN"
-    assert loan["item_pid"] == params["item_pid"]
-    assert loan["start_date"] == start_date
-    assert loan["end_date"] == end_date
-    assert loan["transaction_date"]
-
-    # it should succeed when no end date provided
-    _start_date = now + timedelta(days=3)
-    start_date = _start_date.date().isoformat()
-    end_date = (_start_date + loan_duration_timedelta).date().isoformat()
-
-    params = deepcopy(NEW_LOAN)
-    params["item_pid"] = dict(type="pitmid", value="itemid-62")
-    params["start_date"] = start_date
-    params["transaction_user_pid"] = str(librarian.id)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-    loan = res.get_json()["metadata"]
-    assert loan["state"] == "ITEM_ON_LOAN"
-    assert loan["item_pid"] == params["item_pid"]
-    assert loan["start_date"] == start_date
-    assert loan["end_date"] == end_date
-    assert loan["transaction_date"]
-
-    start_date = (now + timedelta(days=3)).date().isoformat()
-    end_date = (now + timedelta(days=15)).date().isoformat()
-
-    # it should succeed when start/end dates provided
-    params = deepcopy(NEW_LOAN)
-    params["item_pid"] = dict(type="pitmid", value="itemid-63")
-    params["start_date"] = start_date
-    params["end_date"] = end_date
-    params["transaction_user_pid"] = str(librarian.id)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 202
-    loan = res.get_json()["metadata"]
-    assert loan["state"] == "ITEM_ON_LOAN"
-    assert loan["item_pid"] == params["item_pid"]
-    assert loan["start_date"] == start_date
-    assert loan["end_date"] == end_date
-    assert loan["transaction_date"]
-
-    # it should fail when only end date provided
-    params = deepcopy(NEW_LOAN)
-    params["item_pid"] = dict(type="pitmid", value="itemid-63")
-    params["end_date"] = end_date
-    params["transaction_user_pid"] = str(librarian.id)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 400
-
-    # it should fail when wrong date provided
-    start_date = (now + timedelta(days=3)).date().isoformat()
-    past_end_date = now - timedelta(days=30)
-    params = deepcopy(NEW_LOAN)
-    params["item_pid"] = dict(type="pitmid", value="itemid-63")
-    params["start_date"] = start_date
-    params["end_date"] = past_end_date.date().isoformat()
-    params["transaction_user_pid"] = str(librarian.id)
-    res = client.post(url, headers=json_headers, data=json.dumps(params))
-    assert res.status_code == 400

tests/api/circulation/test_loan_default_durations.py

@@ -1,57 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2020 CERN.
-#
-# invenio-app-ils is free software; you can redistribute it and/or modify it
-# under the terms of the MIT License; see LICENSE file for more details.
-
-"""Test loans default durations."""
-
-from datetime import timedelta
-
-import arrow
-
-from invenio_app_ils.ill.api import (
-    circulation_default_extension_duration,
-    circulation_default_loan_duration,
-)
-
-FAKE_LOAN_ITEM_NO_RESTRICTIONS = {
-    "item_pid": {"type": "pitmid", "value": "itemid-1"}
-}
-FAKE_LOAN_ITEM_ONE_WEEK = {"item_pid": {"type": "pitmid", "value": "itemid-2"}}
-FAKE_LOAN_ITEM_TWO_WEEKS = {
-    "item_pid": {"type": "pitmid", "value": "itemid-3"}
-}
-FAKE_LOAN_ITEM_THREE_WEEKS = {
-    "item_pid": {"type": "pitmid", "value": "itemid-4"}
-}
-
-
-def test_loans_default_durations(testdata):
-    """Test loans default durations."""
-    tomorrow = arrow.utcnow() + timedelta(days=1)
-    not_overdue_end_date = tomorrow.date().isoformat()
-    for duration_func in (
-        circulation_default_loan_duration,
-        circulation_default_extension_duration,
-    ):
-        FAKE_LOAN_ITEM_NO_RESTRICTIONS["end_date"] = not_overdue_end_date
-        assert duration_func(
-            FAKE_LOAN_ITEM_NO_RESTRICTIONS, None
-        ) == timedelta(weeks=4)
-
-        FAKE_LOAN_ITEM_ONE_WEEK["end_date"] = not_overdue_end_date
-        assert duration_func(FAKE_LOAN_ITEM_ONE_WEEK, None) == timedelta(
-            weeks=1
-        )
-
-        FAKE_LOAN_ITEM_TWO_WEEKS["end_date"] = not_overdue_end_date
-        assert duration_func(FAKE_LOAN_ITEM_TWO_WEEKS, None) == timedelta(
-            weeks=2
-        )
-
-        FAKE_LOAN_ITEM_THREE_WEEKS["end_date"] = not_overdue_end_date
-        assert duration_func(FAKE_LOAN_ITEM_THREE_WEEKS, None) == timedelta(
-            weeks=3
-        )

tests/api/circulation/test_loan_document_resolver.py

@@ -1,18 +0,0 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2019 CERN.
-#
-# Invenio-Circulation is free software; you can redistribute it and/or modify
-# it under the terms of the MIT License; see LICENSE file for more details.
-
-"""Tests for loan item resolver."""
-
-from invenio_circulation.api import Loan
-
-
-def test_loan_document_resolver(app, testdata):
-    """Test item resolving from loan."""
-    loan_pid = testdata["loans"][1]["pid"]
-    loan = Loan.get_record_by_pid(loan_pid)
-    loan = loan.replace_refs()
-    assert loan["document"]["pid"] == loan["document_pid"]