imio.smartweb.core 1.2.74__py3-none-any.whl → 1.2.76__py3-none-any.whl

imio/smartweb/core/browser/static/smartweb-view-compiled.css

@@ -1 +1 @@
-*{background-position:50%;background-size:cover}body,html{max-width:100%}body{overflow-x:hidden}.table_schedule--active{display:block!important}.card-img-top{padding-top:56.25%}.template-folder_contents table .actionmenu a.action.set-default-page{display:none}#banner{background-size:cover;grid-column-end:-1;grid-column-start:1;height:200px}.hidden-banner{height:55px!important}.pat-structure .pagination>.active>a{z-index:0}.carousel-image{padding-bottom:50%}.swiper-slide .swiper-image{padding-bottom:60%}.swiper-wrapper{padding-bottom:50px}.template-taxonomy-edit-data .taxonomy-tree{border:0 solid #fff}.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_item{border:none;font-size:1.25rem;padding:0 0 1rem;text-transform:uppercase}.template-taxonomy-edit-data .super-text{display:none}.template-taxonomy-edit-data .editable-divs{display:none!important}.template-taxonomy-edit-data div.info .super-text+.editable-divs:nth-child(2),.template-taxonomy-edit-data span .super-text+.editable-divs:nth-child(2){display:inline!important}.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_children>.info,.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_children>.tree-view>.tree-view_item{border-bottom:2px solid #555}.template-taxonomy-edit-data .info,.template-taxonomy-edit-data .tree-view_item{border-bottom:1px dashed #d2d2d2}.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_children>.info input,.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_children>.tree-view>.tree-view_item input{color:#303030;padding-top:.5rem!important;text-shadow:0 1px 0 #303030}.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_children>.tree-view>.tree-view_children>.info:before,.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_children>.tree-view>.tree-view_children>.tree-view>.tree-view_item:before{content:"⤷";float:left;font-weight:700;margin-top:.3rem}.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_children>.tree-view>.tree-view_children>.tree-view>.tree-view_children>.info:before,.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_children>.tree-view>.tree-view_children>.tree-view>.tree-view_children>.tree-view>.tree-view_item:before{content:"•";float:left;font-size:1.5rem;font-weight:700;margin-top:1px}.template-taxonomy-edit-data .taxonomy-tree .tree-view_arrow{display:none}.template-taxonomy-edit-data .taxonomy-tree .tree-view_children{margin-left:2rem}.smartweb_herobanner .section-slide,.smartweb_herobanner .section-slide .swiper-banner-image{height:100%}#portal-globalnav-collapse .nav_index_html,#subsite-navigation .nav_index_html{display:none}.block-menu-element,.list-menu-element{list-style:none}
+@import url(https://cdn.jsdelivr.net/npm/bootstrap-icons@1.10.5/font/bootstrap-icons.css);*{background-position:50%;background-size:cover}body,html{max-width:100%}body{overflow-x:hidden}.table_schedule--active{display:block!important}.card-img-top{padding-top:56.25%}.template-folder_contents table .actionmenu a.action.set-default-page{display:none}#banner{background-size:cover;grid-column-end:-1;grid-column-start:1;height:200px}.hidden-banner{height:55px!important}.pat-structure .pagination>.active>a{z-index:0}.carousel-image{padding-bottom:50%}.swiper-slide .swiper-image{padding-bottom:60%}.swiper-wrapper{padding-bottom:50px}.template-taxonomy-edit-data .taxonomy-tree{border:0 solid #fff}.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_item{border:none;font-size:1.25rem;padding:0 0 1rem;text-transform:uppercase}.template-taxonomy-edit-data .super-text{display:none}.template-taxonomy-edit-data .editable-divs{display:none!important}.template-taxonomy-edit-data div.info .super-text+.editable-divs:nth-child(2),.template-taxonomy-edit-data span .super-text+.editable-divs:nth-child(2){display:inline!important}.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_children>.info,.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_children>.tree-view>.tree-view_item{border-bottom:2px solid #555}.template-taxonomy-edit-data .info,.template-taxonomy-edit-data .tree-view_item{border-bottom:1px dashed #d2d2d2}.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_children>.info input,.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_children>.tree-view>.tree-view_item input{color:#303030;padding-top:.5rem!important;text-shadow:0 1px 0 #303030}.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_children>.tree-view>.tree-view_children>.info:before,.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_children>.tree-view>.tree-view_children>.tree-view>.tree-view_item:before{content:"⤷";float:left;font-weight:700;margin-top:.3rem}.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_children>.tree-view>.tree-view_children>.tree-view>.tree-view_children>.info:before,.template-taxonomy-edit-data .taxonomy-tree>.tree-view>.tree-view_children>.tree-view>.tree-view_children>.tree-view>.tree-view_children>.tree-view>.tree-view_item:before{content:"•";float:left;font-size:1.5rem;font-weight:700;margin-top:1px}.template-taxonomy-edit-data .taxonomy-tree .tree-view_arrow{display:none}.template-taxonomy-edit-data .taxonomy-tree .tree-view_children{margin-left:2rem}.smartweb_herobanner .section-slide,.smartweb_herobanner .section-slide .swiper-banner-image{height:100%}#portal-globalnav-collapse .nav_index_html,#subsite-navigation .nav_index_html{display:none}.block-menu-element,.list-menu-element{list-style:none}.contact_informations_social{display:flex;flex-wrap:wrap;gap:8px}.contact_informations_social .website{width:100%}

imio/smartweb/core/browser/static/src/view.less

@@ -1,18 +1,21 @@
-*{
+@import url("https://cdn.jsdelivr.net/npm/bootstrap-icons@1.10.5/font/bootstrap-icons.css");
+
+* {
   background-size: cover;
   background-position: center;
 }
-html, body {
+html,
+body {
   max-width: 100%;
 }
-body{
+body {
   overflow-x: hidden;
 }
-.table_schedule--active{
-  display: block!important;
+.table_schedule--active {
+  display: block !important;
 }
 
-.card-img-top{
+.card-img-top {
   padding-top: 56.25%;
 }
 // for edition
@@ -21,14 +24,14 @@ body{
 }
 //
 // banner
-#banner{
+#banner {
   grid-column-start: 1;
   grid-column-end: -1;
-  height:200px;
+  height: 200px;
   background-size: cover;
 }
-.hidden-banner{
-  height: 55px!important;
+.hidden-banner {
+  height: 55px !important;
 }
 
 .pat-structure .pagination > .active > a {
@@ -38,86 +41,132 @@ body{
 //// slidier
 
 .carousel-image {
-	padding-bottom: 50%;
+  padding-bottom: 50%;
 }
 
-.swiper-slide  .swiper-image{
-    padding-bottom: 60%;
+.swiper-slide .swiper-image {
+  padding-bottom: 60%;
 }
-.swiper-wrapper{
-    padding-bottom: 50px;
+.swiper-wrapper {
+  padding-bottom: 50px;
 }
 
 /* si identifiant numérique on cache l'identifiant */
-.template-taxonomy-edit-data{
+.template-taxonomy-edit-data {
   .taxonomy-tree {
-    border:0px solid white;
-  & > .tree-view > .tree-view_item {
-        font-size: 1.25rem;
-        padding: 0rem 0 1rem;
-        text-transform: uppercase;
-        border: none;
+    border: 0px solid white;
+    & > .tree-view > .tree-view_item {
+      font-size: 1.25rem;
+      padding: 0rem 0 1rem;
+      text-transform: uppercase;
+      border: none;
     }
   }
-  .super-text{
-      display:none;
+  .super-text {
+    display: none;
   }
   .editable-divs {
-      display: none !important;
+    display: none !important;
   }
-  span .super-text +.editable-divs:nth-child(2), 
-  div.info .super-text +.editable-divs:nth-child(2) {
-      display: inline !important;
+  span .super-text + .editable-divs:nth-child(2),
+  div.info .super-text + .editable-divs:nth-child(2) {
+    display: inline !important;
   }
   .taxonomy-tree > .tree-view > .tree-view_children > .info,
-  .taxonomy-tree > .tree-view > .tree-view_children > .tree-view > .tree-view_item{
-      border-bottom:2px solid #555;
+  .taxonomy-tree
+    > .tree-view
+    > .tree-view_children
+    > .tree-view
+    > .tree-view_item {
+    border-bottom: 2px solid #555;
   }
   .tree-view_item,
   .info {
-      border-bottom: 1px dashed #D2D2D2;
+    border-bottom: 1px dashed #d2d2d2;
   }
   .taxonomy-tree > .tree-view > .tree-view_children > .info input,
-  .taxonomy-tree > .tree-view > .tree-view_children > .tree-view > .tree-view_item input{
-      text-shadow: 0px 1px 0px #303030;
-      padding-top: 0.5rem !important;
-      color: #303030;
+  .taxonomy-tree
+    > .tree-view
+    > .tree-view_children
+    > .tree-view
+    > .tree-view_item
+    input {
+    text-shadow: 0px 1px 0px #303030;
+    padding-top: 0.5rem !important;
+    color: #303030;
   }
 
-  .taxonomy-tree > .tree-view > .tree-view_children > .tree-view > .tree-view_children > .info:before,
-  .taxonomy-tree > .tree-view > .tree-view_children > .tree-view > .tree-view_children > .tree-view > .tree-view_item:before{
-      content: "⤷";
-      font-weight:bold;
-      float: left;
-      margin-top: 0.3rem;
+  .taxonomy-tree
+    > .tree-view
+    > .tree-view_children
+    > .tree-view
+    > .tree-view_children
+    > .info:before,
+  .taxonomy-tree
+    > .tree-view
+    > .tree-view_children
+    > .tree-view
+    > .tree-view_children
+    > .tree-view
+    > .tree-view_item:before {
+    content: "⤷";
+    font-weight: bold;
+    float: left;
+    margin-top: 0.3rem;
   }
-  .taxonomy-tree > .tree-view > .tree-view_children > .tree-view > .tree-view_children > .tree-view > .tree-view_children > .info:before,
-  .taxonomy-tree > .tree-view > .tree-view_children > .tree-view > .tree-view_children > .tree-view > .tree-view_children > .tree-view > .tree-view_item:before{
-      font-weight:bold;
-      float: left;
-      margin-top: 1px;
-      content: "•";
-      font-size: 1.5rem;
+  .taxonomy-tree
+    > .tree-view
+    > .tree-view_children
+    > .tree-view
+    > .tree-view_children
+    > .tree-view
+    > .tree-view_children
+    > .info:before,
+  .taxonomy-tree
+    > .tree-view
+    > .tree-view_children
+    > .tree-view
+    > .tree-view_children
+    > .tree-view
+    > .tree-view_children
+    > .tree-view
+    > .tree-view_item:before {
+    font-weight: bold;
+    float: left;
+    margin-top: 1px;
+    content: "•";
+    font-size: 1.5rem;
   }
   .taxonomy-tree .tree-view_arrow {
-      display: none;
+    display: none;
   }
   .taxonomy-tree .tree-view_children {
-      margin-left: 2rem;
+    margin-left: 2rem;
   }
 }
-.smartweb_herobanner{
-  .section-slide{
+.smartweb_herobanner {
+  .section-slide {
     height: 100%;
-    .swiper-banner-image{
+    .swiper-banner-image {
       height: 100%;
     }
   }
 }
-#portal-globalnav-collapse .nav_index_html, #subsite-navigation .nav_index_html {
-	display: none;
+#portal-globalnav-collapse .nav_index_html,
+#subsite-navigation .nav_index_html {
+  display: none;
 }
 
-.block-menu-element, .list-menu-element {
+.block-menu-element,
+.list-menu-element {
   list-style: none;
-}
+}
+
+.contact_informations_social {
+  display: flex;
+  flex-wrap: wrap;
+  gap: 8px;
+  .website {
+    width: 100%;
+  }
+}

imio/smartweb/core/contents/pages/configure.zcml

@@ -15,6 +15,7 @@
       template="view.pt"
       class=".views.PagesView"
       permission="zope2.View"
+      allowed_attributes="get_page_contacts"
       layer="imio.smartweb.core.interfaces.IImioSmartwebCoreLayer"
       />
 

imio/smartweb/core/contents/pages/views.py

@@ -1,9 +1,11 @@
 # -*- coding: utf-8 -*-
 
 from Acquisition import aq_inner
+from imio.smartweb.core.config import DIRECTORY_URL
 from imio.smartweb.core.utils import get_scale_url
 from imio.smartweb.core.interfaces import IHtmxViewUtils
 from imio.smartweb.core.interfaces import IViewWithoutLeadImage
+from imio.smartweb.core.utils import get_json
 from imio.smartweb.locales import SmartwebMessageFactory as _
 from Products.CMFPlone.resources import add_bundle_on_request
 from plone import api
@@ -11,11 +13,14 @@ from plone.app.content.browser.contents.rearrange import OrderContentsBaseAction
 from plone.app.content.utils import json_loads
 from plone.app.contenttypes.browser.folder import FolderView
 from plone.app.contenttypes.browser.full_view import FullViewItem as BaseFullViewItem
+from plone.memoize.view import memoize
 from Products.CMFPlone import utils
 from Products.CMFPlone.browser.navigation import PhysicalNavigationBreadcrumbs
 from zope.component import getMultiAdapter
 from zope.interface import implementer
 
+import itertools
+
 
 @implementer(IViewWithoutLeadImage)
 @implementer(IHtmxViewUtils)
@@ -46,6 +51,45 @@ class PagesView(FolderView):
             add_bundle_on_request(self.request, "flexbin")
         return self.index()
 
+    @memoize
+    def get_page_contacts(self):
+        # TODO We need to check every tests to be sure to avoid caching that
+        # creates false positive assertions
+        sections_contacts = self.context.listFolderContents(
+            contentFilter={
+                "portal_type": [
+                    "imio.smartweb.SectionContact",
+                ]
+            }
+        )
+        if len(sections_contacts) == 0:
+            return None
+        nested_contact_list = [
+            section_contacts.related_contacts
+            for section_contacts in sections_contacts
+            if section_contacts.related_contacts is not None
+        ]
+        if nested_contact_list == []:
+            return None
+        # Make a "set" to simplifying request in url (avoid duplicate uid)
+        # Sometimes we have duplicate uid because some pages were build with contact attributes
+        # in a section and for layout issues,for the same contact, others attributes are in another section.
+        page_contacts = list(
+            set(list(itertools.chain.from_iterable(nested_contact_list)))
+        )
+        uids = "&UID=".join(page_contacts)
+        bsize = len(page_contacts)
+        url = "{}/@search?UID={}&fullobjects=1&b_size={}".format(
+            DIRECTORY_URL, uids, bsize
+        )
+        current_lang = api.portal.get_current_language()[:2]
+        if current_lang != "fr":
+            url = f"{url}&translated_in_{current_lang}=1"
+        json_data = get_json(url)
+        if json_data is None or len(json_data.get("items", [])) == 0:
+            return
+        return json_data
+
     def results(self, **kwargs):
         """
         Gets results for folder listings without taking care of friendly_types

imio/smartweb/core/contents/sections/contact/macros.pt

@@ -61,7 +61,8 @@
               i18n:translate="">Contact</h3>
 
           <span tal:replace="python:contact.vat_number"></span>
-          <ul tal:define="phones python:contact.phones;
+          <ul class="contact_informations_genral"
+              tal:define="phones python:contact.phones;
                           mails python:contact.mails;
                           urls python:contact.urls">
             <li class="phones"
@@ -78,13 +79,37 @@
               <a tal:attributes="href  python:'mailto:{}'.format(mail.get('mail_address'))"
                  tal:content="python:'{}'.format(mail.get('mail_address'))" />
             </li>
+          </ul>
+          <ul class="contact_informations_social"
+              tal:define="urls python:contact.urls">
             <li class="urls"
                 tal:repeat="url urls"
                 tal:attributes="class python:url.get('type') or ''">
               <a tal:attributes="href python:url.get('url');
                                  title python:contact.get_translated_url_type(url.get('type'))"
-                 tal:content="python:url.get('url')"
-                 target="_blank" />
+                target="_blank">
+                  <tal:condition tal:condition="python:url.get('type') == 'facebook'">
+                      <i class="bi bi-facebook"></i>
+                  </tal:condition>
+                  <tal:condition tal:condition="python:url.get('type') == 'twitter'">
+                      <i class="bi bi-twitter"></i>
+                  </tal:condition>
+                  <tal:condition tal:condition="python:url.get('type') == 'instagram'">
+                      <i class="bi bi-instagram"></i>
+                  </tal:condition>
+                  <tal:condition tal:condition="python:url.get('type') == 'youtube'">
+                    <i class="bi bi-youtube"></i>
+                  </tal:condition>
+                  <tal:condition tal:condition="python:url.get('type') == 'pinterest'">
+                      <i class="bi bi-pinterest"></i>
+                  </tal:condition>
+                  <tal:condition tal:condition="python:url.get('type') == 'linkedin'">
+                      <i class="bi bi-linkedin"></i>
+                  </tal:condition>
+
+                  <span tal:attributes="class python:'sr-only' if url.get('type') != 'website' else ''"
+                        tal:content="python:url.get('url')"/>
+              </a>
             </li>
           </ul>
         </div>

imio/smartweb/core/contents/sections/contact/view.py

@@ -4,30 +4,46 @@ from imio.smartweb.core.config import DIRECTORY_URL
 from imio.smartweb.core.contents.sections.contact.utils import ContactProperties
 from imio.smartweb.core.contents.sections.views import HashableJsonSectionView
 from imio.smartweb.core.utils import batch_results
-from imio.smartweb.core.utils import get_json
 from plone import api
+from zope.component import queryMultiAdapter
 
 
 class ContactView(HashableJsonSectionView):
     """Contact Section view"""
 
     def contacts(self):
-        if self.context.related_contacts is None:
-            return
-        related_contacts = self.context.related_contacts
-        uids = "&UID=".join(related_contacts)
+        # Firstly, try to get contact from the container view
+        container_view = queryMultiAdapter(
+            (self.context.aq_parent, self.request), name="full_view"
+        )
+        self.json_data = container_view.get_page_contacts()
+        if self.json_data is None or len(self.json_data.get("items", [])) == 0:
+            return []
+
+        container_contacts = self.json_data.get("items")
+        results_items = [
+            contact
+            for contact in container_contacts
+            if contact["UID"] in self.context.related_contacts
+        ]
+        index_map = {
+            value: index for index, value in enumerate(self.context.related_contacts)
+        }
+        results_items = sorted(results_items, key=lambda x: index_map[x["UID"]])
+
+        # construct JSON data as before WEBBDC-1265 to avoid hash differences
+        uids = "&UID=".join(self.context.related_contacts)
         url = "{}/@search?UID={}&fullobjects=1".format(DIRECTORY_URL, uids)
         current_lang = api.portal.get_current_language()[:2]
         if current_lang != "fr":
             url = f"{url}&translated_in_{current_lang}=1"
-        self.json_data = get_json(url)
+        self.json_data = {
+            "@id": url,
+            "items": results_items,
+            "items_total": len(results_items),
+        }
         self.refresh_modification_date()
-        if self.json_data is None or len(self.json_data.get("items", [])) == 0:  # NOQA
-            return
-        results = self.json_data.get("items")
-        index_map = {value: index for index, value in enumerate(related_contacts)}
-        results = sorted(results, key=lambda x: index_map[x["UID"]])
-        return batch_results(results, self.context.nb_contact_by_line)
+        return batch_results(results_items, self.context.nb_contact_by_line)
 
     def get_contact_properties(self, json_dict):
         return ContactProperties(json_dict, self.context)

imio/smartweb/core/contents/sections/events/view.py

@@ -51,7 +51,7 @@ class EventsView(CarouselOrTableSectionView, HashableJsonSectionView):
         url = "{}/@events?{}".format(EVENTS_URL, "&".join(params))
         self.json_data = get_json(url)
         self.refresh_modification_date()
-        if self.json_data is None or len(self.json_data.get("items", [])) == 0:  # NOQA
+        if self.json_data is None or len(self.json_data.get("items", [])) == 0:
             return []
         linking_view_url = self.context.linking_rest_view.to_object.absolute_url()
         image_scale = self.image_scale

imio/smartweb/core/contents/sections/news/view.py

@@ -47,7 +47,7 @@ class NewsView(CarouselOrTableSectionView, HashableJsonSectionView):
         url = "{}/@search?{}".format(NEWS_URL, "&".join(params))
         self.json_data = get_json(url)
         self.refresh_modification_date()
-        if self.json_data is None or len(self.json_data.get("items", [])) == 0:  # NOQA
+        if self.json_data is None or len(self.json_data.get("items", [])) == 0:
             return []
         linking_view_url = self.context.linking_rest_view.to_object.absolute_url()
         image_scale = self.image_scale

imio/smartweb/core/tests/test_section_contact.py

@@ -8,6 +8,7 @@ from imio.smartweb.common.contact_utils import formatted_schedule
 from imio.smartweb.common.contact_utils import get_schedule_for_today
 from imio.smartweb.core.contents.sections.contact.utils import ContactProperties
 from imio.smartweb.core.contents.sections.views import SECTION_ITEMS_HASH_KEY
+from imio.smartweb.core.tests.utils import clear_cache
 from imio.smartweb.core.testing import IMIO_SMARTWEB_CORE_FUNCTIONAL_TESTING
 from imio.smartweb.core.testing import ImioSmartwebTestCase
 from imio.smartweb.core.tests.utils import get_json
@@ -57,7 +58,8 @@ class TestSectionContact(ImioSmartwebTestCase):
         view = queryMultiAdapter((self.page, self.request), name="full_view")
         self.assertIn("My contact", view())
         contact_view = queryMultiAdapter((contact, self.request), name="view")
-        self.assertIsNone(contact_view.contacts())
+        self.assertEqual(contact_view.contacts(), [])
+
         authentic_contact_uid = "2dc381f0fb584381b8e4a19c84f53b35"
         contact.related_contacts = [authentic_contact_uid]
         contact_search_url = (
@@ -69,12 +71,13 @@ class TestSectionContact(ImioSmartwebTestCase):
             authentic_contact_uid
         )
         m.get(contact_search_url, exc=requests.exceptions.ConnectTimeout)
-        self.assertIsNone(contact_view.contacts())
+        self.assertEqual(contact_view.contacts(), [])
         m.get(contact_search_url, status_code=404)
-        self.assertIsNone(contact_view.contacts())
+        self.assertEqual(contact_view.contacts(), [])
         m.get(contact_search_url, text=json.dumps(self.json_no_contact))
-        self.assertIsNone(contact_view.contacts())
+        self.assertEqual(contact_view.contacts(), [])
         m.get(contact_search_url, text=json.dumps(self.json_contact))
+        clear_cache(self.request)
         self.assertIsNotNone(contact_view.contacts())
         json_contact = ContactProperties(self.json_contact.get("items")[0], contact)
         self.assertEqual(json_contact.contact_type_class, "contact-type-organization")
@@ -137,6 +140,18 @@ class TestSectionContact(ImioSmartwebTestCase):
         images = json_contact.images(contact.image_scale, contact.nb_results_by_batch)
         self.assertIsNone(images)
 
+    @requests_mock.Mocker()
+    def test_sorted_contacts_are_empty(self, m):
+        # TODO Separate test test_sorted_contacts_is_none /
+        # test_sorted_contacts 'cause of Memoize ??!!
+        contact = api.content.create(
+            container=self.page,
+            type="imio.smartweb.SectionContact",
+            title="My contact",
+        )
+        contact_view = queryMultiAdapter((contact, self.request), name="view")
+        self.assertEqual(contact_view.contacts(), [])
+
     @requests_mock.Mocker()
     def test_sorted_contacts(self, m):
         contact = api.content.create(
@@ -145,7 +160,6 @@ class TestSectionContact(ImioSmartwebTestCase):
             title="My contact",
         )
         contact_view = queryMultiAdapter((contact, self.request), name="view")
-        self.assertIsNone(contact_view.contacts())
         authentic_contact_uid = [
             "2dc381f0fb584381b8e4a19c84f53b35",
             "af7bd1f547034b24a2e0da16c0ba0358",
@@ -508,7 +522,9 @@ class TestSectionContact(ImioSmartwebTestCase):
             "afternoonend": "",
             "comments": "",
         }
+        clear_cache(self.request)
         m.get(contact_search_url, text=json.dumps(json_contact_empty_schedule))
+        view = queryMultiAdapter((self.page, self.request), name="full_view")
         json_contact = ContactProperties(
             json_contact_empty_schedule.get("items")[0], contact
         )
@@ -556,7 +572,6 @@ class TestSectionContact(ImioSmartwebTestCase):
 
         annotations = IAnnotations(contact)
         self.assertIsNone(annotations.get(SECTION_ITEMS_HASH_KEY))
-
         self.assertIsNotNone(contact_view.contacts())
         hash_1 = annotations.get(SECTION_ITEMS_HASH_KEY)
         self.assertIsNotNone(hash_1)
@@ -564,15 +579,25 @@ class TestSectionContact(ImioSmartwebTestCase):
 
         sleep(1)
         m.get(contact_search_url, text=json.dumps(self.json_no_contact))
-        self.assertIsNone(contact_view.contacts())
+        clear_cache(self.request)
+        contact_view = queryMultiAdapter((contact, self.request), name="view")
+        self.assertEqual(contact_view.contacts(), [])
+        # refresh_modification_date doesn't calculate when json_data is None
+        # For this section, this is the case
+        # For other sections, we get json_data with empty "items"
+        # Refactoring needed to ensure clarity ?
         next_modification = self.page.ModificationDate()
         hash_2 = annotations.get(SECTION_ITEMS_HASH_KEY)
-        self.assertNotEqual(hash_1, hash_2)
-        self.assertNotEqual(first_modification, next_modification)
+        self.assertEqual(hash_1, hash_2)
+        self.assertEqual(first_modification, next_modification)
 
         sleep(1)
-        self.assertIsNone(contact_view.contacts())
+        contact_view = queryMultiAdapter((contact, self.request), name="view")
+        self.assertEqual(contact_view.contacts(), [])
         last_modification = self.page.ModificationDate()
         hash_3 = annotations.get(SECTION_ITEMS_HASH_KEY)
         self.assertEqual(hash_2, hash_3)
         self.assertEqual(next_modification, last_modification)
+
+        # TODO we should test with various contact sections containing
+        # contacts