holmesgpt 0.13.1__py3-none-any.whl → 0.13.2__py3-none-any.whl

holmes/core/tools.py

@@ -24,12 +24,15 @@ class ToolResultStatus(str, Enum):
     SUCCESS = "success"
     ERROR = "error"
     NO_DATA = "no_data"
+    APPROVAL_REQUIRED = "approval_required"
 
     def to_color(self) -> str:
         if self == ToolResultStatus.SUCCESS:
             return "green"
         elif self == ToolResultStatus.ERROR:
             return "red"
+        elif self == ToolResultStatus.APPROVAL_REQUIRED:
+            return "yellow"
         else:
             return "white"
 
@@ -38,6 +41,8 @@ class ToolResultStatus(str, Enum):
             return "✔"
         elif self == ToolResultStatus.ERROR:
             return "❌"
+        elif self == ToolResultStatus.APPROVAL_REQUIRED:
+            return "⚠️"
         else:
             return "⚪️"
 
@@ -148,14 +153,17 @@ class Tool(ABC, BaseModel):
         )
 
     def invoke(
-        self, params: Dict, tool_number: Optional[int] = None
+        self,
+        params: Dict,
+        tool_number: Optional[int] = None,
+        user_approved: bool = False,
     ) -> StructuredToolResult:
         tool_number_str = f"#{tool_number} " if tool_number else ""
         logging.info(
             f"Running tool {tool_number_str}[bold]{self.name}[/bold]: {self.get_parameterized_one_liner(params)}"
         )
         start_time = time.time()
-        result = self._invoke(params)
+        result = self._invoke(params=params, user_approved=user_approved)
         result.icon_url = self.icon_url
         elapsed = time.time() - start_time
         output_str = (
@@ -171,7 +179,13 @@ class Tool(ABC, BaseModel):
         return result
 
     @abstractmethod
-    def _invoke(self, params: Dict) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
+        """
+        params: the tool params
+        user_approved: whether the tool call is approved by the user. Can be used to confidently execute unsafe actions.
+        """
         pass
 
     @abstractmethod
@@ -223,7 +237,9 @@ class YAMLTool(Tool, BaseModel):
             return ToolResultStatus.NO_DATA
         return ToolResultStatus.SUCCESS
 
-    def _invoke(self, params) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         if self.command is not None:
             raw_output, return_code, invocation = self.__invoke_command(params)
         else:

holmes/interactive.py

@@ -27,10 +27,11 @@ from pygments.lexers import guess_lexer
 from rich.console import Console
 from rich.markdown import Markdown, Panel
 
+from holmes.common.env_vars import ENABLE_CLI_TOOL_APPROVAL
 from holmes.core.config import config_path_dir
 from holmes.core.prompt import build_initial_ask_messages
 from holmes.core.tool_calling_llm import ToolCallingLLM, ToolCallResult
-from holmes.core.tools import pretty_print_toolset_status
+from holmes.core.tools import StructuredToolResult, pretty_print_toolset_status
 from holmes.core.tracing import DummyTracer
 from holmes.utils.colors import (
     AI_COLOR,
@@ -584,6 +585,53 @@ def prompt_for_llm_sharing(
     return None
 
 
+def handle_tool_approval(
+    command: Optional[str],
+    error_message: Optional[str],
+    style: Style,
+    console: Console,
+) -> tuple[bool, Optional[str]]:
+    """
+    Handle user approval for potentially sensitive commands.
+
+    Args:
+        command: The command that needs approval
+        error_message: The error message explaining why approval is needed
+        session: PromptSession for user input
+        style: Style for prompts
+        console: Rich console for output
+
+    Returns:
+        Tuple of (approved: bool, feedback: Optional[str])
+        - approved: True if user approves, False if denied
+        - feedback: User's optional feedback message when denying
+    """
+    console.print("\n[bold yellow]⚠️  Command Approval Required[/bold yellow]")
+    console.print(f"[yellow]Command:[/yellow] {command or 'unknown'}")
+    console.print(f"[yellow]Reason:[/yellow] {error_message or 'unknown'}")
+    console.print()
+
+    # Create a temporary session without history for approval prompts
+    temp_session = PromptSession(history=InMemoryHistory())  # type: ignore
+
+    approval_prompt = temp_session.prompt(
+        [("class:prompt", "Do you want to approve and execute this command? (y/N): ")],
+        style=style,
+    )
+
+    if approval_prompt.lower().startswith("y"):
+        return True, None
+    else:
+        # Ask for optional feedback when denying
+        feedback_prompt = temp_session.prompt(
+            [("class:prompt", "Optional feedback for the AI (press Enter to skip): ")],
+            style=style,
+        )
+
+        feedback = feedback_prompt.strip() if feedback_prompt.strip() else None
+        return False, feedback
+
+
 def handle_run_command(
     bash_command: str, session: PromptSession, style: Style, console: Console
 ) -> Optional[str]:
@@ -811,6 +859,20 @@ def run_interactive_loop(
         }
     )
 
+    # Set up approval callback for potentially sensitive commands
+    def approval_handler(
+        tool_call_result: StructuredToolResult,
+    ) -> tuple[bool, Optional[str]]:
+        return handle_tool_approval(
+            command=tool_call_result.invocation,
+            error_message=tool_call_result.error,
+            style=style,
+            console=console,
+        )
+
+    if ENABLE_CLI_TOOL_APPROVAL:
+        ai.approval_callback = approval_handler
+
     # Create merged completer with slash commands, conditional executables, show command, and smart paths
     slash_completer = SlashCommandCompleter()
     executable_completer = ConditionalExecutableCompleter()
@@ -1002,7 +1064,6 @@ def run_interactive_loop(
                     user_input,
                     include_files,
                     ai.tool_executor,
-                    ai.investigation_id,
                     runbooks,
                     system_prompt_additions,
                 )

holmes/main.py

@@ -308,7 +308,6 @@ def ask(
         prompt,  # type: ignore
         include_file,
         ai.tool_executor,
-        ai.investigation_id,
         config.get_runbook_catalog(),
         system_prompt_additions,
     )

holmes/plugins/prompts/_general_instructions.jinja2

@@ -62,10 +62,12 @@
 * Follow ALL tasks in your plan - don't skip any tasks
 * Use task management to ensure you don't miss important investigation steps
 * If you discover additional steps during investigation, add them to your task list using TodoWrite
+* When calling TodoWrite, you may ALSO call other tools in parallel to speed things up for your users and make them happy!
+* On the first TodoWrite call, mark at least one task as in_progress, and start working on it in parallel.
+* When calling TodoWrite for the first time, mark the tasks you started working on with ‘in_progress’ status.
 
 # Tool/function calls
 
 You are able to make tool calls / function calls. Recognise when a tool has already been called and reuse its result.
 If a tool call returns nothing, modify the parameters as required instead of repeating the tool call.
 When searching for resources in specific namespaces, test a cluster level tool to find the resource(s) and identify what namespace they are part of.
-You are limited in use to a maximum of 5 tool calls for each specific tool. Therefore make sure are smart about what tools you call and how you call them.

holmes/plugins/prompts/investigation_procedure.jinja2

@@ -1,8 +1,3 @@
-{% if investigation_id %}
-# Investigation ID for this session
-Investigation id: {{ investigation_id }}
-{% endif %}
-
 CLARIFICATION REQUIREMENT: Before starting ANY investigation, if the user's question is ambiguous or lacks critical details, you MUST ask for clarification first. Do NOT create TodoWrite tasks for unclear questions.
 Only proceed with TodoWrite and investigation AFTER you have clear, specific requirements.
 
@@ -16,8 +11,8 @@ MANDATORY Task Status Updates:
 - When completing a task: Call TodoWrite changing that task's status to "completed"
 
 PARALLEL EXECUTION RULES:
-- When possible, work on multiple tasks at a time. If tasks depend on one another, do them one after the other.
-- You MAY execute multiple INDEPENDENT tasks simultaneously
+- When possible, work on multiple tasks at a time. Only when tasks depend on one another, do them one after the other.
+- You SHOULD execute multiple INDEPENDENT tasks simultaneously
 - Mark multiple tasks as "in_progress" if they don't depend on each other
 - Wait for dependent tasks to complete before starting tasks that need their results
 - Always use a single TodoWrite call to update multiple task statuses
@@ -84,17 +79,12 @@ If you see ANY `[ ] pending` or `[~] in_progress` tasks, DO NOT provide final an
     {"id": "3", "content": "Check resources", "status": "pending"}
   ])
 
-
-{% if todo_list %}
-{{ todo_list }}
-{% endif %}
-
 # MANDATORY Multi-Phase Investigation Process
 
 For ANY question requiring investigation, you MUST follow this structured approach:
 
 ## Phase 1: Initial Investigation
-1. **IMMEDIATELY START with TodoWrite**: Create initial investigation task list
+1. **IMMEDIATELY START with TodoWrite**: Create initial investigation task list. Already start working on tasks. Mark the tasks you're working on as in_progress.
 2. **Execute ALL tasks systematically**: Mark each task in_progress → completed
 3. **Complete EVERY task** in the current list before proceeding
 

holmes/plugins/toolsets/__init__.py

@@ -26,6 +26,9 @@ from holmes.plugins.toolsets.datadog.toolset_datadog_traces import (
 from holmes.plugins.toolsets.datadog.toolset_datadog_rds import (
     DatadogRDSToolset,
 )
+from holmes.plugins.toolsets.datadog.toolset_datadog_general import (
+    DatadogGeneralToolset,
+)
 from holmes.plugins.toolsets.git import GitToolset
 from holmes.plugins.toolsets.grafana.toolset_grafana import GrafanaToolset
 from holmes.plugins.toolsets.grafana.toolset_grafana_loki import GrafanaLokiToolset
@@ -82,6 +85,7 @@ def load_python_toolsets(dal: Optional[SupabaseDal]) -> List[Toolset]:
         NotionToolset(),
         KafkaToolset(),
         DatadogLogsToolset(),
+        DatadogGeneralToolset(),
         DatadogMetricsToolset(),
         DatadogTracesToolset(),
         DatadogRDSToolset(),
@@ -155,7 +159,7 @@ def load_toolsets_from_config(
 
     loaded_toolsets: list[Toolset] = []
     if is_old_toolset_config(toolsets):
-        message = "Old toolset config format detected, please update to the new format: https://docs.robusta.dev/master/configuration/holmesgpt/custom_toolsets.html"
+        message = "Old toolset config format detected, please update to the new format: https://holmesgpt.dev/data-sources/custom-toolsets/"
         logging.warning(message)
         raise ValueError(message)
 

holmes/plugins/toolsets/argocd.yaml

@@ -1,7 +1,7 @@
 toolsets:
   argocd/core:
     description: "Set of tools to get argocd metadata like list of apps, repositories, projects, etc."
-    docs_url: "https://docs.robusta.dev/master/configuration/holmesgpt/toolsets/argocd.html"
+    docs_url: "https://holmesgpt.dev/data-sources/builtin-toolsets/argocd/"
     icon_url: "https://argo-cd.readthedocs.io/en/stable/assets/logo.png"
     llm_instructions: |
       You have access to a set of ArgoCD tools for debugging Kubernetes application deployments.

holmes/plugins/toolsets/atlas_mongodb/mongodb_atlas.py

@@ -118,7 +118,9 @@ class ReturnProjectAlerts(MongoDBAtlasBaseTool):
         project_id = self.toolset.config.get("project_id", "")
         return f"{toolset_name_for_one_liner(self.toolset.name)}: Get Project Alerts ({project_id})"
 
-    def _invoke(self, params: Any) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         try:
             url = "https://cloud.mongodb.com/api/atlas/v2/groups/{project_id}/alerts".format(
                 project_id=self.toolset.config.get("project_id")
@@ -143,7 +145,9 @@ class ReturnProjectProcesses(MongoDBAtlasBaseTool):
         project_id = self.toolset.config.get("project_id", "")
         return f"{toolset_name_for_one_liner(self.toolset.name)}: Get Project Processes ({project_id})"
 
-    def _invoke(self, params: Any) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         try:
             url = "https://cloud.mongodb.com/api/atlas/v2/groups/{project_id}/processes".format(
                 project_id=self.toolset.config.get("project_id")
@@ -176,7 +180,9 @@ class ReturnProjectSlowQueries(MongoDBAtlasBaseTool):
         process_id = params.get("process_id", "")
         return f"{toolset_name_for_one_liner(self.toolset.name)}: Get Slow Queries ({process_id})"
 
-    def _invoke(self, params: Any) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         try:
             url = self.url.format(
                 project_id=self.toolset.config.get("project_id"),
@@ -203,7 +209,9 @@ class ReturnEventsFromProject(MongoDBAtlasBaseTool):
         project_id = self.toolset.config.get("project_id", "")
         return f"{toolset_name_for_one_liner(self.toolset.name)}: Get Project Events ({project_id})"
 
-    def _invoke(self, params: Any) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         params.update({"itemsPerPage": 500})
         try:
             now_utc = datetime.now(timezone.utc)
@@ -260,7 +268,9 @@ class ReturnLogsForProcessInProject(MongoDBAtlasBaseTool):
         hostname = params.get("hostName", "")
         return f"{toolset_name_for_one_liner(self.toolset.name)}: Get Host Logs ({hostname})"
 
-    def _invoke(self, params: Any) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         one_hour_ago = datetime.now(timezone.utc) - timedelta(hours=1)
         try:
             url = self.url.format(
@@ -312,7 +322,9 @@ class ReturnEventTypeFromProject(MongoDBAtlasBaseTool):
         event_type = params.get("eventType", "")
         return f"{toolset_name_for_one_liner(self.toolset.name)}: Get Event Details ({event_type})"
 
-    def _invoke(self, params: Any) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         try:
             url = self.url.format(projectId=self.toolset.config.get("project_id"))
 

holmes/plugins/toolsets/aws.yaml

@@ -1,7 +1,7 @@
 toolsets:
   aws/security:
     description: "Set of tools to audit AWS security"
-    docs_url: "https://docs.robusta.dev/master/configuration/holmesgpt/toolsets/aws.html#security"
+    docs_url: "https://holmesgpt.dev/data-sources/builtin-toolsets/aws/"
     icon_url: "https://upload.wikimedia.org/wikipedia/commons/9/93/Amazon_Web_Services_Logo.svg"
     tags:
       - cli
@@ -42,8 +42,12 @@ toolsets:
 
   aws/rds:
     description: "Read access to Amazon RDS resources"
-    docs_url: "https://docs.robusta.dev/master/configuration/holmesgpt/toolsets/aws.html#rds"
+    docs_url: "https://holmesgpt.dev/data-sources/builtin-toolsets/aws/"
     icon_url: "https://upload.wikimedia.org/wikipedia/commons/9/93/Amazon_Web_Services_Logo.svg"
+    llm_instructions: |
+      You have access to information on RDS resources.
+      Use this toolset to get extra information on RDS resources on AWS.
+      When investigating RDS resources ALWAYS fetch additional information if possible.
     tags:
       - cli
     prerequisites:
@@ -56,8 +60,8 @@ toolsets:
         command: "aws rds describe-events"
 
       - name: "aws_rds_describe_instance"
-        description: "Get the configuration of a RDS instance"
-        user_description: "Get the configuration of a RDS instance"
+        description: "Get the configuration of a RDS instance, its status and availability stats. Runs 'aws rds describe-db-instances' for a specific instance."
+        user_description: "Get the configuration of an RDS instance"
         command: "aws rds describe-db-instances --db-instance-identifier '{{ db_instance_identifier }}'"
 
       - name: "aws_rds_describe_instances"
@@ -66,7 +70,7 @@ toolsets:
         command: "aws rds describe-db-instances"
 
       - name: "aws_rds_describe_logs"
-        description: "Describe all available logs for an AWS RDS instance."
+        description: "Describe all available logs for an AWS RDS instance. Runs 'aws rds describe-db-log-files' for a specific instance."
         user_description: "list available RDS logs (e.g. slow query logs)"
         command: "aws rds describe-db-log-files --db-instance-identifier '{{ db_instance_identifier }}'"
 

holmes/plugins/toolsets/azure_sql/tools/analyze_connection_failures.py

@@ -213,7 +213,9 @@ class AnalyzeConnectionFailures(BaseAzureSQLTool):
 
         return "\n".join(report_sections)
 
-    def _invoke(self, params: Dict) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         try:
             # Get configuration
             db_config = self.toolset.database_config()

holmes/plugins/toolsets/azure_sql/tools/analyze_database_connections.py

@@ -151,7 +151,9 @@ class AnalyzeDatabaseConnections(BaseAzureSQLTool):
 
         return "\n".join(report_sections)
 
-    def _invoke(self, params: Dict) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         try:
             hours_back = params.get("hours_back", 2)
 

holmes/plugins/toolsets/azure_sql/tools/analyze_database_health_status.py

@@ -131,7 +131,9 @@ class AnalyzeDatabaseHealthStatus(BaseAzureSQLTool):
 
         return "\n".join(report_sections)
 
-    def _invoke(self, params: Dict) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         try:
             db_config = self.toolset.database_config()
             client = self.toolset.api_client()

holmes/plugins/toolsets/azure_sql/tools/analyze_database_performance.py

@@ -192,7 +192,9 @@ class AnalyzeDatabasePerformance(BaseAzureSQLTool):
 
         return "\n".join(report_sections)
 
-    def _invoke(self, params: Dict) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         try:
             db_config = self.toolset.database_config()
             client = self.toolset.api_client()

holmes/plugins/toolsets/azure_sql/tools/analyze_database_storage.py

@@ -249,7 +249,9 @@ class AnalyzeDatabaseStorage(BaseAzureSQLTool):
 
         return "\n".join(report_sections)
 
-    def _invoke(self, params: Dict) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         try:
             hours_back = params.get("hours_back", 24)
             top_tables = params.get("top_tables", 20)

holmes/plugins/toolsets/azure_sql/tools/get_active_alerts.py

@@ -147,7 +147,9 @@ class GetActiveAlerts(BaseAzureSQLTool):
 
         return "\n".join(report_sections)
 
-    def _invoke(self, params: Dict) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         try:
             db_config = self.toolset.database_config()
             api_client = self.toolset.api_client()

holmes/plugins/toolsets/azure_sql/tools/get_slow_queries.py

@@ -99,7 +99,9 @@ class GetSlowQueries(BaseAzureSQLTool):
 
         return "\n".join(report_sections)
 
-    def _invoke(self, params: Dict) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         try:
             top_count = params.get("top_count", 15)
             hours_back = params.get("hours_back", 2)

holmes/plugins/toolsets/azure_sql/tools/get_top_cpu_queries.py

@@ -97,7 +97,9 @@ class GetTopCPUQueries(BaseAzureSQLTool):
 
         return "\n".join(report_sections)
 
-    def _invoke(self, params: Dict) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         try:
             top_count = params.get("top_count", 15)
             hours_back = params.get("hours_back", 2)

holmes/plugins/toolsets/azure_sql/tools/get_top_data_io_queries.py

@@ -115,7 +115,9 @@ class GetTopDataIOQueries(BaseAzureSQLTool):
 
         return "\n".join(report_sections)
 
-    def _invoke(self, params: Dict) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         try:
             top_count = params.get("top_count", 15)
             hours_back = params.get("hours_back", 2)

holmes/plugins/toolsets/azure_sql/tools/get_top_log_io_queries.py

@@ -107,7 +107,9 @@ class GetTopLogIOQueries(BaseAzureSQLTool):
 
         return "\n".join(report_sections)
 
-    def _invoke(self, params: Dict) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         try:
             top_count = params.get("top_count", 15)
             hours_back = params.get("hours_back", 2)

holmes/plugins/toolsets/bash/bash_toolset.py

@@ -9,7 +9,9 @@ from typing import Dict, Any, Optional
 import sentry_sdk
 
 
-from holmes.common.env_vars import BASH_TOOL_UNSAFE_ALLOW_ALL
+from holmes.common.env_vars import (
+    BASH_TOOL_UNSAFE_ALLOW_ALL,
+)
 from holmes.core.tools import (
     CallablePrerequisite,
     StructuredToolResult,
@@ -80,7 +82,9 @@ class KubectlRunImageCommand(BaseBashTool):
         command_str = get_param_or_raise(params, "command")
         return f"kubectl run {pod_name} --image={image} --namespace={namespace} --rm --attach --restart=Never -i -- {command_str}"
 
-    def _invoke(self, params: Dict[str, Any]) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         timeout = params.get("timeout", 60)
 
         image = get_param_or_raise(params, "image")
@@ -160,7 +164,9 @@ class RunBashCommand(BaseBashTool):
             toolset=toolset,
         )
 
-    def _invoke(self, params: Dict[str, Any]) -> StructuredToolResult:
+    def _invoke(
+        self, params: dict, user_approved: bool = False
+    ) -> StructuredToolResult:
         command_str = params.get("command")
         timeout = params.get("timeout", 60)
 
@@ -179,23 +185,28 @@ class RunBashCommand(BaseBashTool):
             )
 
         command_to_execute = command_str
-        try:
-            command_to_execute = make_command_safe(command_str, self.toolset.config)
-
-        except (argparse.ArgumentError, ValueError) as e:
-            with sentry_sdk.configure_scope() as scope:
-                scope.set_extra("command", command_str)
-                scope.set_extra("error", str(e))
-                scope.set_extra("unsafe_allow_all", BASH_TOOL_UNSAFE_ALLOW_ALL)
-                sentry_sdk.capture_exception(e)
-
-            if not BASH_TOOL_UNSAFE_ALLOW_ALL:
-                logging.info(f"Refusing LLM tool call {command_str}")
-                return StructuredToolResult(
-                    status=ToolResultStatus.ERROR,
-                    error=f"Refusing to execute bash command. Only some commands are supported and this is likely because requested command is unsupported. Error: {str(e)}",
-                    params=params,
-                )
+
+        # Only run the safety check if user has NOT approved the command
+        if not user_approved:
+            try:
+                command_to_execute = make_command_safe(command_str, self.toolset.config)
+
+            except (argparse.ArgumentError, ValueError) as e:
+                with sentry_sdk.configure_scope() as scope:
+                    scope.set_extra("command", command_str)
+                    scope.set_extra("error", str(e))
+                    scope.set_extra("unsafe_allow_all", BASH_TOOL_UNSAFE_ALLOW_ALL)
+                    sentry_sdk.capture_exception(e)
+
+                if not BASH_TOOL_UNSAFE_ALLOW_ALL:
+                    logging.info(f"Refusing LLM tool call {command_str}")
+
+                    return StructuredToolResult(
+                        status=ToolResultStatus.APPROVAL_REQUIRED,
+                        error=f"Refusing to execute bash command. {str(e)}",
+                        params=params,
+                        invocation=command_str,
+                    )
 
         return execute_bash_command(
             cmd=command_to_execute, timeout=timeout, params=params

holmes/plugins/toolsets/confluence.yaml

@@ -1,7 +1,7 @@
 toolsets:
   confluence:
     description: "Fetch confluence pages"
-    docs_url: "https://docs.robusta.dev/master/configuration/holmesgpt/toolsets/confluence.html"
+    docs_url: "https://holmesgpt.dev/data-sources/builtin-toolsets/confluence/"
     icon_url: "https://platform.robusta.dev/demos/confluence.svg"
     tags:
       - core

holmes/plugins/toolsets/coralogix/api.py

@@ -106,7 +106,9 @@ def query_logs_for_tier(
         )
         http_status = response.status_code
         if http_status == 200:
-            logs = parse_logs(raw_logs=response.text.strip())
+            logs = parse_logs(
+                raw_logs=response.text.strip(), labels_config=config.labels
+            )
             return CoralogixQueryResult(logs=logs, http_status=http_status, error=None)
         else:
             return CoralogixQueryResult(

holmes/plugins/toolsets/coralogix/toolset_coralogix_logs.py

@@ -38,14 +38,14 @@ class CoralogixLogsToolset(BasePodLoggingToolset):
         super().__init__(
             name="coralogix/logs",
             description="Toolset for interacting with Coralogix to fetch logs",
-            docs_url="https://docs.robusta.dev/master/configuration/holmesgpt/toolsets/coralogix_logs.html",
+            docs_url="https://holmesgpt.dev/data-sources/builtin-toolsets/coralogix-logs/",
             icon_url="https://avatars.githubusercontent.com/u/35295744?s=200&v=4",
             prerequisites=[CallablePrerequisite(callable=self.prerequisites_callable)],
-            tools=[
-                PodLoggingTool(self),
-            ],
+            tools=[],  # Initialize with empty tools first
             tags=[ToolsetTag.CORE],
         )
+        # Now that parent is initialized and self.name exists, create the tool
+        self.tools = [PodLoggingTool(self)]
 
     def get_example_config(self):
         example_config = CoralogixConfig(