hestia-earth-models 0.64.14__py3-none-any.whl → 0.65.0__py3-none-any.whl

tests/models/environmentalFootprintV3/test_soilQualityIndexLandTransformation.py

@@ -1,10 +1,11 @@
 import json
-from unittest.mock import patch
+from unittest.mock import Mock, patch
 
 from pytest import mark
 
-from hestia_earth.models.environmentalFootprintV3.soilQualityIndexLandTransformation import MODEL, TERM_ID, run, \
-    _should_run
+from hestia_earth.models.environmentalFootprintV3.soilQualityIndexLandTransformation import (
+    MODEL, TERM_ID, run, _should_run
+)
 from tests.utils import fixtures_path, fake_new_indicator
 
 class_path = f"hestia_earth.models.{MODEL}.{TERM_ID}"
@@ -17,55 +18,70 @@ def fake_rounded_indicator(value: float):
     return indicator
 
 
+land_cover_terms = ['cropland', 'seaOrOcean', 'forest']
 crop_land = {"@id": "cropland", "termType": "landCover"}
 sea_land_cover = {"@id": "seaOrOcean", "termType": "landCover"}
 forest = {"@id": "forest", "termType": "landCover"}
+indicator = {
+    "@id": "landTransformation20YearAverageInputsProduction",
+    "termType": "resourceUse",
+    "units": "m2 / year"
+}
 
 wrong_indicator = {"term": {"@id": "NOT_VALID_INDICATOR_ID", "termType": "resourceUse", "units": "m2 / year"},
                    "value": 0.5, "landCover": crop_land}
 
 indicator_no_land_cover = {
-    "term": {"@id": "landTransformationFromForest20YearAverageInputsProduction", "termType": "resourceUse",
-             "units": "m2 / year"},
+    "term": indicator,
+    "previousLandCover": forest,
     "value": 0.5}
 
 indicator_no_unit = {
-    "term": {"@id": "landTransformationFromForest20YearAverageInputsProduction", "termType": "resourceUse"},
-    "value": 0.5, "landCover": crop_land}
+    "term": indicator,
+    "previousLandCover": forest,
+    "value": 0.5,
+    "landCover": crop_land}
 
 indicator_wrong_unit = {
-    "term": {"@id": "landTransformationFromForest20YearAverageInputsProduction", "termType": "resourceUse",
-             "units": "ha*day"}, "value": 0.5,
+    "term": indicator,
+    "value": 0.5,
+    "previousLandCover": forest,
     "landCover": crop_land}
 
 indicator_bad_area_value = {
-    "term": {"@id": "landTransformationFromForest20YearAverageInputsProduction", "termType": "resourceUse",
-             "units": "m2 / year"}, "value": -10,
+    "term": indicator,
+    "value": -10,
+    "previousLandCover": forest,
     "landCover": crop_land}
 
 inputs_production_indicator_from_forest_to_no_cf = {
-    "term": {"@id": "landTransformationFromForest20YearAverageInputsProduction", "termType": "resourceUse",
-             "units": "m2 / year"}, "value": 0.5,
+    "term": indicator,
+    "value": 0.5,
+    "previousLandCover": forest,
     "landCover": sea_land_cover}
 
 good_inputs_production_indicator_from_forest_to_cropland = {
-    "term": {"@id": "landTransformationFromForest20YearAverageInputsProduction", "termType": "resourceUse",
-             "units": "m2 / year"}, "value": 0.5,
+    "term": indicator,
+    "value": 0.5,
+    "previousLandCover": forest,
     "landCover": crop_land}
 
 good_inputs_production_indicator_from_forest_to_forest = {
-    "term": {"@id": "landTransformationFromForest20YearAverageInputsProduction", "termType": "resourceUse",
-             "units": "m2 / year"}, "value": 0.5,
+    "term": indicator,
+    "value": 0.5,
+    "previousLandCover": forest,
     "landCover": forest}
 
 good_during_cycle_indicator_from_forest_to_cropland = {
-    "term": {"@id": "landTransformationFromForest20YearAverageDuringCycle", "termType": "resourceUse",
-             "units": "m2 / year"}, "value": 0.5,
+    "term": indicator,
+    "value": 0.5,
+    "previousLandCover": forest,
     "landCover": crop_land}
 
 good_during_cycle_indicator_from_forest_to_forest = {
-    "term": {"@id": "landTransformationFromForest20YearAverageDuringCycle", "termType": "resourceUse",
-             "units": "m2 / year"}, "value": 0.5,
+    "term": indicator,
+    "value": 0.5,
+    "previousLandCover": forest,
     "landCover": forest}
 
 
@@ -75,8 +91,6 @@ good_during_cycle_indicator_from_forest_to_forest = {
         ([], True, 0),
         ([wrong_indicator], True, 0),
         ([indicator_no_land_cover], False, 0),
-        ([indicator_no_unit], False, 0),
-        ([indicator_wrong_unit], False, 0),
         ([indicator_bad_area_value], False, 0),
         ([good_during_cycle_indicator_from_forest_to_cropland], True, 1),
         ([good_during_cycle_indicator_from_forest_to_forest], True, 1),
@@ -89,8 +103,6 @@ good_during_cycle_indicator_from_forest_to_forest = {
     ids=["No emissionsResourceUse => run, 0 dict",
          "Wrong indicator termid => run, 0 dict",
          "Indicator no landcover terms => no run",
-         "Missing unit => no run",
-         "Wrong unit => no run",
          "Bad m2 / year value => no run",
          "One good during cycle transformation => run, 1 dict",
          "One 0 during cycle transformation => run, 1 dict",
@@ -100,8 +112,7 @@ good_during_cycle_indicator_from_forest_to_forest = {
          "Multiple good indicators => run, 2 dict",
          ]
 )
-@patch(f"{class_path}.get_land_cover_terms", return_value=['cropland', 'seaOrOcean', 'forest'])
-def test_should_run(mock_download, resources, expected, num_inputs):
+def test_should_run(resources: list, expected: bool, num_inputs: int):
     with open(f"{fixtures_folder}/multipleTransformations/impact-assessment.jsonld", encoding='utf-8') as f:
         impact = json.load(f)
 
@@ -146,7 +157,7 @@ def test_run_italy(*args):
          "region-europe not in the lookup file => default to region world"]
 )
 @patch(f"{class_path}._indicator", side_effect=fake_rounded_indicator)
-def test_run_with_country_fallback(mocked_indicator, added_data):
+def test_run_with_country_fallback(mocked_indicator: Mock, added_data: dict):
     """
     When given valid sub-region or country not in the lookup file, default to country 'region-world' with value 574.56
     """

tests/models/{hyde32/test_landTransformationFromForest20YearAverageDuringCycle.py → faostat2018/test_landTransformation100YearAverageDuringCycle.py}

@@ -2,14 +2,14 @@ from unittest.mock import patch
 import json
 from tests.utils import fixtures_path, fake_new_indicator
 
-from hestia_earth.models.hyde32.landTransformationFromForest20YearAverageDuringCycle import TERM_ID, run
+from hestia_earth.models.faostat2018 import MODEL
+from hestia_earth.models.faostat2018.landTransformation100YearAverageDuringCycle import TERM_ID, run
 
-class_path = f"hestia_earth.models.hyde32.{TERM_ID}"
-fixtures_folder = f"{fixtures_path}/hyde32/{TERM_ID}"
+class_path = f"hestia_earth.models.{MODEL}.{TERM_ID}"
+fixtures_folder = f"{fixtures_path}/{MODEL}/{TERM_ID}"
 
 
-@patch('hestia_earth.models.hyde32.utils.get_land_cover_term_id', return_value='cropland')
-@patch('hestia_earth.models.hyde32.utils._new_indicator', side_effect=fake_new_indicator)
+@patch(f"hestia_earth.models.{MODEL}.utils._new_indicator", side_effect=fake_new_indicator)
 def test_run(*args):
     with open(f"{fixtures_folder}/impact-assessment.jsonld", encoding='utf-8') as f:
         cycle = json.load(f)

tests/models/{hyde32/test_landTransformationFromForest100YearAverageDuringCycle.py → faostat2018/test_landTransformation20YearAverageDuringCycle.py}

@@ -2,14 +2,14 @@ from unittest.mock import patch
 import json
 from tests.utils import fixtures_path, fake_new_indicator
 
-from hestia_earth.models.hyde32.landTransformationFromForest100YearAverageDuringCycle import TERM_ID, run
+from hestia_earth.models.faostat2018 import MODEL
+from hestia_earth.models.faostat2018.landTransformation20YearAverageDuringCycle import TERM_ID, run
 
-class_path = f"hestia_earth.models.hyde32.{TERM_ID}"
-fixtures_folder = f"{fixtures_path}/hyde32/{TERM_ID}"
+class_path = f"hestia_earth.models.{MODEL}.{TERM_ID}"
+fixtures_folder = f"{fixtures_path}/{MODEL}/{TERM_ID}"
 
 
-@patch('hestia_earth.models.hyde32.utils.get_land_cover_term_id', return_value='cropland')
-@patch('hestia_earth.models.hyde32.utils._new_indicator', side_effect=fake_new_indicator)
+@patch(f"hestia_earth.models.{MODEL}.utils._new_indicator", side_effect=fake_new_indicator)
 def test_run(*args):
     with open(f"{fixtures_folder}/impact-assessment.jsonld", encoding='utf-8') as f:
         cycle = json.load(f)

tests/models/faostat2018/test_utils.py

@@ -0,0 +1,28 @@
+from hestia_earth.models.faostat2018.utils import should_run_landTransformationFromCropland
+
+
+def test_should_run_landTransformationFromCropland():
+    impact = {}
+    term_id = 'term'
+
+    # no indicator => no run
+    should_run, *args = should_run_landTransformationFromCropland(term_id, impact)
+    assert not should_run
+
+    # with indicator value 0 => no run
+    impact['emissionsResourceUse'] = [{
+        'term': {'@id': term_id},
+        'previousLandCover': {'@id': 'cropland'},
+        'value': 0
+    }]
+    should_run, *args = should_run_landTransformationFromCropland(term_id, impact)
+    assert not should_run
+
+    # with indicator => run
+    impact['emissionsResourceUse'] = [{
+        'term': {'@id': term_id},
+        'previousLandCover': {'@id': 'cropland'},
+        'value': 10
+    }]
+    should_run, *args = should_run_landTransformationFromCropland(term_id, impact)
+    assert should_run is True

tests/models/hestia/test_landCover.py

@@ -194,7 +194,8 @@ def test_get_sums_of_crop_expansion():
         "brazil_example",
         "zimbabwe_example",
         "brazil_empty_example",
-        "gbr_example"
+        "gbr_example",
+        "malaysia"
     ]
 )
 @patch(f"{CLASS_PATH}._new_management", side_effect=fake_new_management)

tests/models/hestia/test_seed_emissions.py

@@ -0,0 +1,27 @@
+import os
+import json
+import pytest
+from unittest.mock import patch, Mock
+from tests.utils import fixtures_path, fake_new_emission
+
+from hestia_earth.models.hestia.seed_emissions import MODEL, MODEL_KEY, run
+
+class_path = f"hestia_earth.models.{MODEL}.{MODEL_KEY}"
+fixtures_folder = os.path.join(fixtures_path, MODEL, MODEL_KEY)
+
+_folders = [d for d in os.listdir(fixtures_folder) if os.path.isdir(os.path.join(fixtures_folder, d))]
+
+
+@pytest.mark.parametrize('folder', _folders)
+@patch(f"{class_path}._new_emission", side_effect=fake_new_emission)
+def test_run(mock_emission: Mock, folder: str):
+    fixture_path = os.path.join(fixtures_folder, folder)
+
+    with open(f"{fixture_path}/cycle.jsonld", encoding='utf-8') as f:
+        cycle = json.load(f)
+
+    with open(f"{fixture_path}/result.jsonld", encoding='utf-8') as f:
+        expected = json.load(f)
+
+    result = run(cycle)
+    assert result == expected, folder

tests/models/ipcc2019/test_aboveGroundBiomass.py

@@ -12,12 +12,18 @@ from tests.utils import fake_new_measurement, fixtures_path
 class_path = f"hestia_earth.models.{MODEL}.{TERM_ID}"
 utils_path = f"hestia_earth.models.{MODEL}.biomass_utils"
 term_path = "hestia_earth.models.utils.term"
-property_path = "hestia_earth.models.utils.property"
-
 fixtures_folder = f"{fixtures_path}/{MODEL}/{TERM_ID}"
 
 _ITERATIONS = 1000
 
+COVER_CROP_PROPERTY_TERM_IDS = [
+    "catchCrop",
+    "coverCrop",
+    "groundCover",
+    "longFallowCrop",
+    "shortFallowCrop"
+]
+
 
 def _load_fixture(path: str, default=None):
     if isfile(path):
@@ -40,6 +46,7 @@ PARAMS_SHOULD_RUN = [
     ("forest-to-cropland-lcc-q4", True),
     ("forest-to-gohac", False),
     ("forest-to-orchard", True),
+    ("forest-to-orchard-with-ground-cover", True),  # Closes 989
     ("forest-to-orchard-with-backup-factors", True),
     ("forest-to-orchard-with-in-category-lcc", True),
     ("historical-land-cover-mix", True),
@@ -52,7 +59,14 @@ IDS_SHOULD_RUN = [p[0] for p in PARAMS_SHOULD_RUN]
 
 
 @mark.parametrize("subfolder, should_run", PARAMS_SHOULD_RUN, ids=IDS_SHOULD_RUN)
-def test_should_run(subfolder: str, should_run: bool):
+@patch(f"{utils_path}.get_cover_crop_property_terms", return_value=COVER_CROP_PROPERTY_TERM_IDS)
+@patch(f"{term_path}.search")
+def test_should_run(
+    search_mock: MagicMock,
+    get_cover_crop_property_terms_mock: MagicMock,
+    subfolder: str,
+    should_run: bool
+):
     folder = f"{fixtures_folder}/{subfolder}"
 
     site = _load_fixture(f"{folder}/site.jsonld", {})
@@ -60,14 +74,22 @@ def test_should_run(subfolder: str, should_run: bool):
     result, *_ = _should_run(site)
     assert result == should_run
 
+    assert get_cover_crop_property_terms_mock.call_count <= 1  # assert the API call is only requested once
+    search_mock.assert_not_called()                            # assert the API call is properly mocked
 
-def test_should_run_no_data():
+
+@patch(f"{utils_path}.get_cover_crop_property_terms", return_value=COVER_CROP_PROPERTY_TERM_IDS)
+@patch(f"{term_path}.search")
+def test_should_run_no_data(search_mock: MagicMock, get_cover_crop_property_terms_mock: MagicMock,):
     SITE = {}
     EXPECTED = False
 
     result, *_ = _should_run(SITE)
     assert result == EXPECTED
 
+    assert get_cover_crop_property_terms_mock.call_count <= 1  # assert the API call is only performed once
+    search_mock.assert_not_called()                            # assert the API call is properly mocked
+
 
 PARAMS_RUN = [subfolder for subfolder, should_run in PARAMS_SHOULD_RUN if should_run]
 
@@ -76,7 +98,11 @@ PARAMS_RUN = [subfolder for subfolder, should_run in PARAMS_SHOULD_RUN if should
 @patch(f"{class_path}.calc_descriptive_stats", side_effect=_fake_calc_descriptive_stats)
 @patch(f"{class_path}._new_measurement", side_effect=fake_new_measurement)
 @patch(f"{utils_path}._get_sample_func", return_value=sample_constant)
+@patch(f"{utils_path}.get_cover_crop_property_terms", return_value=COVER_CROP_PROPERTY_TERM_IDS)
+@patch(f"{term_path}.search")
 def test_run(
+    search_mock: MagicMock,
+    get_cover_crop_property_terms_mock: MagicMock,
     _get_sample_func_mock: MagicMock,
     _new_measurement_mock: MagicMock,
     _calc_descriptive_stats_mock: MagicMock,
@@ -92,6 +118,9 @@ def test_run(
 
     assert result == expected
 
+    assert get_cover_crop_property_terms_mock.call_count <= 1  # assert the API call is only performed once
+    search_mock.assert_not_called()                            # assert the API call is properly mocked
+
 
 # subfolder
 PARAMS_RUN_WITH_STATS = [
@@ -103,7 +132,11 @@ PARAMS_RUN_WITH_STATS = [
 
 @mark.parametrize("subfolder", PARAMS_RUN_WITH_STATS)
 @patch(f"{class_path}._new_measurement", side_effect=fake_new_measurement)
+@patch(f"{utils_path}.get_cover_crop_property_terms", return_value=COVER_CROP_PROPERTY_TERM_IDS)
+@patch(f"{term_path}.search")
 def test_run_with_stats(
+    search_mock: MagicMock,
+    get_cover_crop_property_terms_mock: MagicMock,
     _new_measurement_mock: MagicMock,
     subfolder: str
 ):
@@ -117,6 +150,9 @@ def test_run_with_stats(
 
     assert result == expected
 
+    assert get_cover_crop_property_terms_mock.call_count <= 1  # assert the API call is only performed once
+    search_mock.assert_not_called()                            # assert the API call is properly mocked
+
 
 # input, expected
 PARAMS_BUILD_COLUMN_NAME = [

tests/models/ipcc2019/test_belowGroundBiomass.py

@@ -12,12 +12,18 @@ from tests.utils import fake_new_measurement, fixtures_path
 class_path = f"hestia_earth.models.{MODEL}.{TERM_ID}"
 utils_path = f"hestia_earth.models.{MODEL}.biomass_utils"
 term_path = "hestia_earth.models.utils.term"
-property_path = "hestia_earth.models.utils.property"
-
 fixtures_folder = f"{fixtures_path}/{MODEL}/{TERM_ID}"
 
 _ITERATIONS = 1000
 
+COVER_CROP_PROPERTY_TERM_IDS = [
+    "catchCrop",
+    "coverCrop",
+    "groundCover",
+    "longFallowCrop",
+    "shortFallowCrop"
+]
+
 
 def _load_fixture(path: str, default=None):
     if isfile(path):
@@ -41,6 +47,7 @@ PARAMS_SHOULD_RUN = [
     ("forest-to-cropland-lcc-q4", True),
     ("forest-to-gohac", False),
     ("forest-to-orchard", True),
+    ("forest-to-orchard-with-ground-cover", True),  # Closes 989
     ("forest-to-orchard-with-in-category-lcc", True),
     ("historical-land-cover-mix", True),
     ("historical-argentina-pasture", True),
@@ -52,7 +59,14 @@ IDS_SHOULD_RUN = [p[0] for p in PARAMS_SHOULD_RUN]
 
 
 @mark.parametrize("subfolder, should_run", PARAMS_SHOULD_RUN, ids=IDS_SHOULD_RUN)
-def test_should_run(subfolder: str, should_run: bool):
+@patch(f"{utils_path}.get_cover_crop_property_terms", return_value=COVER_CROP_PROPERTY_TERM_IDS)
+@patch(f"{term_path}.search")
+def test_should_run(
+    search_mock: MagicMock,
+    get_cover_crop_property_terms_mock: MagicMock,
+    subfolder: str,
+    should_run: bool
+):
     folder = f"{fixtures_folder}/{subfolder}"
 
     site = _load_fixture(f"{folder}/site.jsonld", {})
@@ -60,14 +74,22 @@ def test_should_run(subfolder: str, should_run: bool):
     result, *_ = _should_run(site)
     assert result == should_run
 
+    assert get_cover_crop_property_terms_mock.call_count <= 1  # assert the API call is only requested once
+    search_mock.assert_not_called()                            # assert the API call is properly mocked
 
-def test_should_run_no_data():
+
+@patch(f"{utils_path}.get_cover_crop_property_terms", return_value=COVER_CROP_PROPERTY_TERM_IDS)
+@patch(f"{term_path}.search")
+def test_should_run_no_data(search_mock: MagicMock, get_cover_crop_property_terms_mock: MagicMock):
     SITE = {}
     EXPECTED = False
 
     result, *_ = _should_run(SITE)
     assert result == EXPECTED
 
+    assert get_cover_crop_property_terms_mock.call_count <= 1  # assert the API call is only requested once
+    search_mock.assert_not_called()                            # assert the API call is properly mocked
+
 
 PARAMS_RUN = [subfolder for subfolder, should_run in PARAMS_SHOULD_RUN if should_run]
 
@@ -76,7 +98,11 @@ PARAMS_RUN = [subfolder for subfolder, should_run in PARAMS_SHOULD_RUN if should
 @patch(f"{class_path}.calc_descriptive_stats", side_effect=_fake_calc_descriptive_stats)
 @patch(f"{class_path}._new_measurement", side_effect=fake_new_measurement)
 @patch(f"{utils_path}._get_sample_func", return_value=sample_constant)
+@patch(f"{utils_path}.get_cover_crop_property_terms", return_value=COVER_CROP_PROPERTY_TERM_IDS)
+@patch(f"{term_path}.search")
 def test_run(
+    search_mock: MagicMock,
+    get_cover_crop_property_terms_mock: MagicMock,
     _get_sample_func_mock: MagicMock,
     _new_measurement_mock: MagicMock,
     _calc_descriptive_stats_mock: MagicMock,
@@ -92,6 +118,9 @@ def test_run(
 
     assert result == expected
 
+    assert get_cover_crop_property_terms_mock.call_count <= 1  # assert the API call is only requested once
+    search_mock.assert_not_called()                            # assert the API call is properly mocked
+
 
 # subfolder
 PARAMS_RUN_WITH_STATS = [
@@ -103,7 +132,11 @@ PARAMS_RUN_WITH_STATS = [
 
 @mark.parametrize("subfolder", PARAMS_RUN_WITH_STATS)
 @patch(f"{class_path}._new_measurement", side_effect=fake_new_measurement)
+@patch(f"{utils_path}.get_cover_crop_property_terms", return_value=COVER_CROP_PROPERTY_TERM_IDS)
+@patch(f"{term_path}.search")
 def test_run_with_stats(
+    search_mock: MagicMock,
+    get_cover_crop_property_terms_mock: MagicMock,
     _new_measurement_mock: MagicMock,
     subfolder: str
 ):
@@ -117,6 +150,9 @@ def test_run_with_stats(
 
     assert result == expected
 
+    assert get_cover_crop_property_terms_mock.call_count <= 1  # assert the API call is only requested once
+    search_mock.assert_not_called()                            # assert the API call is properly mocked
+
 
 # input, expected
 PARAMS_BUILD_COLUMN_NAME = [

tests/models/ipcc2019/test_co2ToAirAboveGroundBiomassStockChange.py

@@ -2,7 +2,7 @@ from functools import reduce
 import json
 from os.path import isfile
 from pytest import mark
-from unittest.mock import patch
+from unittest.mock import MagicMock, patch
 
 from hestia_earth.models.ipcc2019.co2ToAirAboveGroundBiomassStockChange import MODEL, run
 
@@ -10,8 +10,26 @@ from tests.utils import fake_new_emission, fixtures_path, order_list
 
 class_path = f"hestia_earth.models.{MODEL}.co2ToAirAboveGroundBiomassStockChange"
 utils_path = f"hestia_earth.models.{MODEL}.co2ToAirCarbonStockChange_utils"
+biomass_utils_path = f"hestia_earth.models.{MODEL}.biomass_utils"
+term_path = "hestia_earth.models.utils.term"
 fixtures_folder = f"{fixtures_path}/{MODEL}/co2ToAirAboveGroundBiomassStockChange"
 
+COVER_CROP_PROPERTY_TERM_IDS = [
+    "catchCrop",
+    "coverCrop",
+    "groundCover",
+    "longFallowCrop",
+    "shortFallowCrop"
+]
+
+
+def _load_fixture(path: str, default=None):
+    if isfile(path):
+        with open(path, encoding="utf-8") as f:
+            return json.load(f)
+    return default
+
+
 RUN_SCENARIOS = [
     ("no-overlapping-cycles", 3),
     ("overlapping-cycles", 4),
@@ -22,18 +40,12 @@ RUN_SCENARIOS = [
     ("multiple-method-classifications", 5),       # Closes issue #764
     ("non-soil-based-gohac-system", 3),           # Closes issue #848
     ("soil-based-gohac-system", 3),               # Closes issue #848
-    ("with-gapfilled-start-date-end-date", 1)     # Closes issue #972
+    ("with-gapfilled-start-date-end-date", 1),    # Closes issue #972
+    ("forest-to-orchard-with-ground-cover", 3)    # Closes issue #989
 ]
 """List of (subfolder: str, num_cycles: int)."""
 
 
-def _load_fixture(path: str, default=None):
-    if isfile(path):
-        with open(path, encoding="utf-8") as f:
-            return json.load(f)
-    return default
-
-
 RUN_PARAMS = reduce(
     lambda params, scenario: params + [(scenario[0], scenario[1], i) for i in range(scenario[1])],
     RUN_SCENARIOS,
@@ -47,8 +59,19 @@ RUN_IDS = [f"{param[0]}, cycle{param[2]}" for param in RUN_PARAMS]
 @mark.parametrize("subfolder, num_cycles, cycle_index", RUN_PARAMS, ids=RUN_IDS)
 @patch(f"{class_path}._new_emission", side_effect=fake_new_emission)
 @patch(f"{utils_path}.related_cycles")
-@patch(f"{utils_path}._get_site")  # TODO: rationalise order of patches
-def test_run(_get_site_mock, related_cycles_mock, _new_emission_mock, subfolder, num_cycles, cycle_index):
+@patch(f"{utils_path}._get_site")
+@patch(f"{biomass_utils_path}.get_cover_crop_property_terms", return_value=COVER_CROP_PROPERTY_TERM_IDS)
+@patch(f"{term_path}.search")
+def test_run(
+    search_mock: MagicMock,
+    get_cover_crop_property_terms_mock: MagicMock,
+    get_site_mock: MagicMock,
+    related_cycles_mock: MagicMock,
+    _new_emission_mock: MagicMock,
+    subfolder: str,
+    num_cycles: int,
+    cycle_index: int
+):
     """
     Test `run` function for each cycle in each scenario.
     """
@@ -60,25 +83,39 @@ def test_run(_get_site_mock, related_cycles_mock, _new_emission_mock, subfolder,
         _load_fixture(f"{fixtures_folder}/{subfolder}/cycle{i}.jsonld") for i in range(num_cycles)
     ]
 
-    _get_site_mock.return_value = site
+    get_site_mock.return_value = site
     related_cycles_mock.return_value = cycles
 
     result = run(cycle)
     assert order_list(result) == order_list(expected)
 
+    assert get_cover_crop_property_terms_mock.call_count <= 1  # assert the API call is only requested once
+    search_mock.assert_not_called()                            # assert the API call is properly mocked
+
 
 @patch(f"{class_path}._new_emission", side_effect=fake_new_emission)
 @patch(f"{utils_path}.related_cycles")
-@patch(f"{utils_path}._get_site")  # TODO: rationalise order of patches
-def test_run_empty(_get_site_mock, related_cycles_mock, _new_emission_mock):
+@patch(f"{utils_path}._get_site")
+@patch(f"{biomass_utils_path}.get_cover_crop_property_terms", return_value=COVER_CROP_PROPERTY_TERM_IDS)
+@patch(f"{term_path}.search")
+def test_run_empty(
+    search_mock: MagicMock,
+    get_cover_crop_property_terms_mock: MagicMock,
+    get_site_mock: MagicMock,
+    related_cycles_mock: MagicMock,
+    _new_emission_mock: MagicMock
+):
     """
     Test `run` function for each cycle in each scenario.
     """
     CYCLE = {}
     EXPECTED = []
 
-    _get_site_mock.return_value = {}
+    get_site_mock.return_value = {}
     related_cycles_mock.return_value = [CYCLE]
 
     result = run(CYCLE)
     assert result == EXPECTED
+
+    assert get_cover_crop_property_terms_mock.call_count <= 1  # assert the API call is only requested once
+    search_mock.assert_not_called()                            # assert the API call is properly mocked