hestia-earth-models 0.62.3__py3-none-any.whl → 0.62.4__py3-none-any.whl

hestia_earth/models/faostat2018/liveweightPerHead.py

@@ -77,7 +77,7 @@ def _run_liveAnimal(cycle: dict, product: dict, year: int, country_id: str):
     product_id = product.get('term', {}).get('@id')
     animal_product_id = get_liveAnimal_to_animalProduct_id(product_id, LOOKUPS['liveAnimal'][0], term=TERM_ID)
 
-    animal_product_term = download_hestia(animal_product_id)
+    animal_product_term = download_hestia(animal_product_id) if animal_product_id else {}
     kg_liveweight, groupingFAO = _product_value({**product, 'term': animal_product_term}, year, country_id)
 
     logRequirements(cycle, model=MODEL, term=product_id, property=TERM_ID,

hestia_earth/models/log.py

@@ -63,7 +63,7 @@ def logShouldRun(log_node: dict, model: str, term: Union[str, None], should_run:
 
 
 def debugMissingLookup(lookup_name: str, row: str, row_value: str, col: str, value, **kwargs):
-    if value is None:
+    if value is None or value == '':
         extra = (', ' + _join_args(**kwargs)) if len(kwargs.keys()) > 0 else ''
         logger.warn('Missing lookup=%s, %s=%s, column=%s' + extra, lookup_name, row, row_value, col)
 

hestia_earth/models/mocking/search-results.json

@@ -1636,6 +1636,150 @@
       }
     ]
   },
+  {
+    "name": "get_land_cover_siteTypes",
+    "query": {
+      "bool": {
+        "must": [
+          {
+            "match": {
+              "@type": "Term"
+            }
+          },
+          {
+            "match": {
+              "termType": "landCover"
+            }
+          }
+        ],
+        "should": [
+          {
+            "match": {
+              "name": "agri-food processor"
+            }
+          },
+          {
+            "match": {
+              "name": "animal housing"
+            }
+          },
+          {
+            "match": {
+              "name": "cropland"
+            }
+          },
+          {
+            "match": {
+              "name": "food retailer"
+            }
+          },
+          {
+            "match": {
+              "name": "forest"
+            }
+          },
+          {
+            "match": {
+              "name": "glass or high accessible cover"
+            }
+          },
+          {
+            "match": {
+              "name": "lake"
+            }
+          },
+          {
+            "match": {
+              "name": "other natural vegetation"
+            }
+          },
+          {
+            "match": {
+              "name": "permanent pasture"
+            }
+          },
+          {
+            "match": {
+              "name": "pond"
+            }
+          },
+          {
+            "match": {
+              "name": "river or stream"
+            }
+          },
+          {
+            "match": {
+              "name": "sea or ocean"
+            }
+          }
+        ],
+        "minimum_should_match": 1
+      }
+    },
+    "results": [
+      {
+        "@type": "Term",
+        "name": "Glass or high accessible cover",
+        "@id": "glassOrHighAccessibleCover",
+        "_score": 60.694187
+      },
+      {
+        "@type": "Term",
+        "name": "River or stream",
+        "@id": "riverOrStream",
+        "_score": 50.06671
+      },
+      {
+        "@type": "Term",
+        "name": "Other natural vegetation",
+        "@id": "otherNaturalVegetation",
+        "_score": 40.722
+      },
+      {
+        "@type": "Term",
+        "name": "Natural forest",
+        "@id": "naturalForest",
+        "_score": 31.252472
+      },
+      {
+        "@type": "Term",
+        "name": "Permanent pasture",
+        "@id": "permanentPasture",
+        "_score": 27.857792
+      },
+      {
+        "@type": "Term",
+        "name": "Animal housing",
+        "@id": "animalHousing",
+        "_score": 26.769783
+      },
+      {
+        "@type": "Term",
+        "name": "Root or tuber crop plant",
+        "@id": "rootOrTuberCropPlant",
+        "_score": 24.781918
+      },
+      {
+        "@type": "Term",
+        "name": "High intensity grazing pasture",
+        "@id": "highIntensityGrazingPasture",
+        "_score": 23.502655
+      },
+      {
+        "@type": "Term",
+        "name": "Permanent cropland",
+        "@id": "permanentCropland",
+        "_score": 20.467493
+      },
+      {
+        "@type": "Term",
+        "name": "Forest",
+        "@id": "forest",
+        "_score": 19.942879
+      }
+    ]
+  },
   {
     "name": "get_liquid_fuel_terms",
     "query": {

hestia_earth/models/site/management.py

@@ -15,16 +15,17 @@ condensed into a single node to aid readability.
 """
 from functools import reduce
 
-from hestia_earth.schema import SchemaType, TermTermType
+from hestia_earth.schema import SchemaType, TermTermType, SiteSiteType
 from hestia_earth.utils.api import download_hestia
 from hestia_earth.utils.model import filter_list_term_type, linked_node
-from hestia_earth.utils.tools import flatten, safe_parse_float
+from hestia_earth.utils.tools import safe_parse_float, flatten
 from hestia_earth.utils.blank_node import get_node_value
 
 from hestia_earth.models.log import logRequirements, logShouldRun, log_blank_nodes_id
 from hestia_earth.models.utils.term import get_lookup_value
 from hestia_earth.models.utils.blank_node import condense_nodes
 from hestia_earth.models.utils.site import related_cycles
+from hestia_earth.models.utils.site import get_land_cover_term_id as get_landCover_term_id_from_site_type
 from . import MODEL
 
 REQUIREMENTS = {
@@ -119,6 +120,9 @@ INPUT_RULES = {
         )
     )
 }
+_SKIP_LAND_COVER_SITE_TYPES = [
+    SiteSiteType.CROPLAND.value
+]
 
 
 def management(data: dict):
@@ -130,14 +134,15 @@ def _extract_node_value(node: dict) -> dict:
     return node | {'value': get_node_value(node)}
 
 
-def _include(value: dict, keys: list): return {k: v for k, v in value.items() if k in keys}
+def _include(value: dict, keys: list) -> dict: return {k: v for k, v in value.items() if k in keys}
 
 
 def _default_dates(cycle: dict, values: list):
     return [(_include(cycle, ["startDate", "endDate"]) | v) for v in values]
 
 
-def _overwrite_dates(cycle: dict, values: list) -> list:
+def _dates_from_current_cycle(cycle: dict, values: list) -> list:
+    """Always uses the dates from the cycle."""
     return [v | _include(cycle, ["startDate", "endDate"]) for v in values]
 
 
@@ -149,22 +154,21 @@ def _copy_item_if_exists(source: dict, keys: list[str] = None, dest: dict = None
 
 def _get_landCover_term_id(product: dict) -> str:
     value = get_lookup_value(product.get('term', {}), LAND_COVER_KEY, model=MODEL, model_key=LAND_COVER_KEY)
-    # TODO: what should happen when there are multiple values?
     return value.split(';')[0] if value else None
 
 
-def _get_items_with_relevant_term_type(
-        cycles: list[dict], item_name: str, relevant_values: list, date_fill: callable = _default_dates
-):
-    """Get items from the list of cycles with any of the relevant values. Also adds dates if missing."""
-    return flatten(
-        [
-            date_fill(
-                cycle=cycle,
-                values=filter_list_term_type(cycle.get(item_name, []), relevant_values)
-            ) for cycle in cycles
-        ]
-    )
+def _get_relevant_items(
+        cycles: list[dict], item_name: str, relevant_terms: list, date_fill: callable = _default_dates
+) -> list:
+    """
+    Get items from the list of cycles with any of the relevant terms.
+    Also adds dates if missing.
+    """
+    return [
+        item
+        for cycle in cycles
+        for item in date_fill(cycle=cycle, values=filter_list_term_type(cycle.get(item_name, []), relevant_terms))
+    ]
 
 
 def _get_lookup_with_debug(term: dict, column: str) -> any:
@@ -211,28 +215,25 @@ def _get_relevant_inputs(cycles: list[dict]) -> list:
     return relevant_inputs
 
 
-def _should_run(site: dict):
-    # Only get related cycles once.
-    cycles = related_cycles(site)
-
+def _should_run_all_products(cycles: list, site_type: str):
     products_land_cover = [
         _extract_node_value(
             _include(
                 value=product,
                 keys=["term", "value", "startDate", "endDate", "properties"]
             )
-        ) for product in _get_items_with_relevant_term_type(
+        ) for product in _get_relevant_items(
             cycles=cycles,
             item_name="products",
-            relevant_values=[TermTermType.LANDCOVER]
+            relevant_terms=[TermTermType.LANDCOVER]
         )
-    ]
+    ] if site_type else []
 
-    products_crop_forage = _get_items_with_relevant_term_type(
+    products_crop_forage = _get_relevant_items(
         cycles=cycles,
         item_name="products",
-        relevant_values=[TermTermType.CROP, TermTermType.FORAGE],
-        date_fill=_overwrite_dates
+        relevant_terms=[TermTermType.CROP, TermTermType.FORAGE],
+        date_fill=_dates_from_current_cycle
     )
     products_crop_forage = [
         _copy_item_if_exists(
@@ -243,9 +244,33 @@ def _should_run(site: dict):
                 "value": 100
             }
         )
-        for product in list(filter(_get_landCover_term_id, products_crop_forage))
-    ]
-    all_products = products_land_cover + products_crop_forage
+        for product in list(filter(_get_landCover_term_id, [i for i in products_crop_forage]))
+    ] if site_type else []
+    dates = sorted(list(set(
+        flatten([[cycle.get('startDate'), cycle.get('endDate')] for cycle in cycles])
+    ))) if site_type not in _SKIP_LAND_COVER_SITE_TYPES else []
+    site_type_term = download_hestia(get_landCover_term_id_from_site_type(site_type)) if all([
+        len(dates) >= 2,
+        site_type
+    ]) else None
+    products_site_type = [{
+        "term": linked_node(site_type_term),
+        "value": 100,
+        "startDate": dates[0],
+        "endDate": dates[-1]
+    }] if site_type_term else []
+
+    return products_site_type, products_crop_forage, products_land_cover
+
+
+def _should_run(site: dict):
+    cycles = related_cycles(site)
+
+    products_animal, products_crop_forage, products_land_cover = _should_run_all_products(
+        cycles=cycles,
+        site_type=site.get("siteType", "")
+    )
+    all_products = products_land_cover + products_crop_forage + products_animal
     all_products = condense_nodes(all_products)
 
     practices = [
@@ -254,10 +279,10 @@ def _should_run(site: dict):
                 value=practice,
                 keys=["term", "value", "startDate", "endDate"]
             )
-        ) for practice in _get_items_with_relevant_term_type(
+        ) for practice in _get_relevant_items(
             cycles=cycles,
             item_name="practices",
-            relevant_values=[
+            relevant_terms=[
                 TermTermType.WATERREGIME,
                 TermTermType.TILLAGE,
                 TermTermType.CROPRESIDUEMANAGEMENT,
@@ -275,6 +300,7 @@ def _should_run(site: dict):
         model_key=MODEL_KEY,
         products_crop_forage_ids=log_blank_nodes_id(products_crop_forage),
         products_land_cover_ids=log_blank_nodes_id(products_land_cover),
+        products_animal=log_blank_nodes_id(products_animal),
         practice_ids=log_blank_nodes_id(practices),
         inputs=log_blank_nodes_id(relevant_inputs)
     )

hestia_earth/models/utils/site.py

@@ -5,6 +5,7 @@ from hestia_earth.utils.tools import non_empty_list, flatten, safe_parse_date
 
 from hestia_earth.models.log import debugMissingLookup
 from . import cached_value, _load_calculated_node
+from .term import get_land_cover_siteTypes
 
 CACHE_YEARS_KEY = 'years'
 WATER_TYPES = [
@@ -120,3 +121,9 @@ def region_factor(model: str, region_id: str, term_id: str, termType: TermTermTy
     value = get_table_value(download_lookup(lookup_name), 'termid', region_id, column_name(term_id))
     debugMissingLookup(lookup_name, 'termid', region_id, term_id, value, model=model, term=term_id)
     return value
+
+
+def get_land_cover_term_id(site_type: str):
+    land_cover_terms = get_land_cover_siteTypes()
+    term = next((term for term in land_cover_terms if term["name"].lower() == site_type.lower()), {})
+    return term.get("@id", "")

hestia_earth/models/utils/term.py

@@ -1,4 +1,4 @@
-from hestia_earth.schema import SchemaType, TermTermType
+from hestia_earth.schema import SchemaType, TermTermType, SiteSiteType
 from hestia_earth.utils.lookup import download_lookup, get_table_value, column_name
 from hestia_earth.utils.api import find_node, search
 
@@ -626,3 +626,23 @@ def get_electricity_grid_mix_terms():
         }
     }, limit=LIMIT, fields=['@type', '@id', 'name', 'termType', 'units'])
     return list(map(lambda n: n["@id"], terms))
+
+
+def get_land_cover_siteTypes():
+    """
+    Find all `Land Cover` terms with siteTypes
+
+    Returns
+    -------
+        List of landCover terms with associated siteTypes.
+    """
+    return search({
+        "bool": {
+            "must": [
+                {"match": {"@type": "Term"}},
+                {"match": {"termType": "landCover"}}
+            ],
+            "should": [{"match": {"name": siteType.value}} for siteType in SiteSiteType],
+            "minimum_should_match": 1
+        },
+    })

hestia_earth/models/version.py

@@ -1 +1 @@
-VERSION = '0.62.3'
+VERSION = '0.62.4'

{hestia_earth_models-0.62.3.dist-info → hestia_earth_models-0.62.4.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: hestia-earth-models
-Version: 0.62.3
+Version: 0.62.4
 Summary: HESTIA's set of modules for filling gaps in the activity data using external datasets (e.g. populating soil properties with a geospatial dataset using provided coordinates) and internal lookups (e.g. populating machinery use from fuel use). Includes rules for when gaps should be filled versus not (e.g. never gap fill yield, gap fill crop residue if yield provided etc.).
 Home-page: https://gitlab.com/hestia-earth/hestia-engine-models
 Author: HESTIA Team

{hestia_earth_models-0.62.3.dist-info → hestia_earth_models-0.62.4.dist-info}/RECORD

@@ -1,10 +1,10 @@
 hestia_earth/__init__.py,sha256=G-d438vPx7m_ks5e9XTtM3u7LDRO5dSSukibukWmyPM,56
 hestia_earth/models/__init__.py,sha256=qEFeq3yuf3lQKVseALmL8aPM8fpCS54B_5pry00M3hk,76
 hestia_earth/models/cache_sites.py,sha256=KQp9cUKE-aIcYJoMWEtKFYS8gBFfsx5LKQhqoWpUSoM,6065
-hestia_earth/models/log.py,sha256=b63I3qyTtQs17xxbq8RI0Fv2lvZ1oDZ9k0njhxqiFFk,3459
+hestia_earth/models/log.py,sha256=DbfNcGzaC5hzkuMDxQqW6XYoNBI4Uxw4SIoOYoZA6og,3474
 hestia_earth/models/preload_requests.py,sha256=y_okcYzSbqODvmzkw-wOK2cOZEzkJq3pmRfxRsPsUw0,1012
 hestia_earth/models/requirements.py,sha256=eU4yT443fx7BnaokhrLB_PCizJI7Y6m4auyo8vQauNg,17363
-hestia_earth/models/version.py,sha256=7aQk_ZZAw1avQvecDCGEiWz0z9mUZWdHHPPAzm2Hgf0,19
+hestia_earth/models/version.py,sha256=VvAcSTPsHvm2Agla-EjyZ04Gq8k08dRvMyQy3jw2KbM,19
 hestia_earth/models/agribalyse2016/__init__.py,sha256=WvK0qCQbnYtg9oZxrACd1wGormZyXibPtpCnIQeDqbw,415
 hestia_earth/models/agribalyse2016/fuelElectricity.py,sha256=tnGxBmJdPfPFfehLUQcefEqy1lHvzsSpx_s7O8nf3Zs,4412
 hestia_earth/models/agribalyse2016/machineryInfrastructureDepreciatedAmountPerCycle.py,sha256=_Rbngu0DzHKa62JwBl58ZC_ui1zLF2que_nB7ukhOQc,3392
@@ -131,7 +131,7 @@ hestia_earth/models/faostat2018/coldCarcassWeightPerHead.py,sha256=y1ouj5FBrnGWx
 hestia_earth/models/faostat2018/coldDressedCarcassWeightPerHead.py,sha256=Aphq7r06Q5-RDer4i1CneOLifVQCKTiVPTIWE3AxLfE,3230
 hestia_earth/models/faostat2018/landTransformationFromCropland100YearAverage.py,sha256=2qVeSGMoJ15pD6-p0Fsq1yN-3mpL8SyOKkVuIiYoJMg,2655
 hestia_earth/models/faostat2018/landTransformationFromCropland20YearAverage.py,sha256=0vJHRIb4F2G_8MG9Qgz2n-7dYerG5q6r7pG-j84LKjk,2648
-hestia_earth/models/faostat2018/liveweightPerHead.py,sha256=3h8zveCVQ21ms2qtsQyAYeet-98TMkipL6QLEnyUcTU,5111
+hestia_earth/models/faostat2018/liveweightPerHead.py,sha256=flI3_TyG-7xoWp6cU6pZAFiXyHyFkfRz7Lmb7cQAffI,5140
 hestia_earth/models/faostat2018/readyToCookWeightPerHead.py,sha256=b1_GZQ3oFl88w6TY5DqLSqXNaYX6TcRBK4R9M2cWSjM,3165
 hestia_earth/models/faostat2018/seed.py,sha256=ts9PKs9UnZnJ9nPFlL7etL1Qb9uIWIES8Mz8W7FWbOw,2917
 hestia_earth/models/faostat2018/utils.py,sha256=r69UWDdMOLTYkI8_oQeEnUCOAZCnmwj_NwyrypAOb_A,3734
@@ -367,7 +367,7 @@ hestia_earth/models/linkedImpactAssessment/landTransformationFromPermanentPastur
 hestia_earth/models/linkedImpactAssessment/utils.py,sha256=dGwGc2d-8_WQElTpfyPmz5vQtL-LHQRmiZnCTuPXMDs,1876
 hestia_earth/models/mocking/__init__.py,sha256=n3Fkkrvh8zHNWiJZmnfQ7WZ91JRzAO9P6pSG1JpwtXo,687
 hestia_earth/models/mocking/mock_search.py,sha256=dBCDRfbZmbMLKP21u_VYkxyimomqs-zztjX-_ZNKuuM,2036
-hestia_earth/models/mocking/search-results.json,sha256=E-YgXbJEDOtPpC7VCv0bf1ckfQbZwkoLT-SzG_TcIh4,43349
+hestia_earth/models/mocking/search-results.json,sha256=_2VGybtuYwXO05Oj4wCr0t8HbJ7a0KZqDJnmqoITAVM,46411
 hestia_earth/models/pooreNemecek2018/__init__.py,sha256=nPboL7ULJzL5nJD5q7q9VOZt_fxbKVm8fmn1Az5YkVY,417
 hestia_earth/models/pooreNemecek2018/aboveGroundCropResidueTotal.py,sha256=Qt-mel4dkhK6N5uUOutNOinCTFjbjtGzITaaI0LvYc4,2396
 hestia_earth/models/pooreNemecek2018/belowGroundCropResidue.py,sha256=JT0RybbvWVlo01FO8K0Yj41HrEaJT3Kj1xfayr2X-xw,2315
@@ -466,7 +466,7 @@ hestia_earth/models/site/brackishWater.py,sha256=vLEhIZv5PUKwzwvIuYrWi7K---fq7ZX
 hestia_earth/models/site/cationExchangeCapacityPerKgSoil.py,sha256=0eH4A-tXJ0hvIkiYXWxlx8TfrdbIKUGYUDk97-yQJgg,3653
 hestia_earth/models/site/flowingWater.py,sha256=v3g5722GIA4zQAUQI9yGFiZvFvI1QAVZqlQrY-6_B3A,1731
 hestia_earth/models/site/freshWater.py,sha256=FXs3Vt8V4e-wn325_dwSTOKlZtn5ksNUpvYGDeLJShY,1255
-hestia_earth/models/site/management.py,sha256=iljb0YjZqQcilXNlYIffjfEqszvMaLRKJlgv0TKIe-M,9627
+hestia_earth/models/site/management.py,sha256=n980WNeTQpoXgTrH4KbwHFaaAJRdMmIqeCz_MvvSKqg,10655
 hestia_earth/models/site/netPrimaryProduction.py,sha256=UIIQkYd911qVzrWjxBLrC37e-RARIVgDwLdARY9BuLw,1849
 hestia_earth/models/site/organicCarbonPerHa.py,sha256=F2ShinHf0m9qKa1nCYBspsDkRY6jzOl0wM8mSDre22I,14916
 hestia_earth/models/site/organicCarbonPerKgSoil.py,sha256=t--wAshiAKS-JvEKhLFRadGvgSBv5NFZ68jdyms_wh4,1945
@@ -557,10 +557,10 @@ hestia_earth/models/utils/practice.py,sha256=tNadOzsrNlCEt801B815XaruJXzZ5yPASam
 hestia_earth/models/utils/product.py,sha256=H9UqJNzTqtMWXDQnbRkZlTpv_hg4s-Tya469fBk8InA,10143
 hestia_earth/models/utils/productivity.py,sha256=bUBVCZInGqHuHZvHDSYPQkjWXQxOtTjEk-1-f_BsFOo,594
 hestia_earth/models/utils/property.py,sha256=_9Wy0oZIBLsa-jOiGLokKehYLNdz-_7LfLaE4fb6SWM,5085
-hestia_earth/models/utils/site.py,sha256=yei3qk7edxb_boag9h8j713r06KGstjTBWdb1KjqMus,3602
+hestia_earth/models/utils/site.py,sha256=zEj2PtIghk-L_vVJidlXM6_ed7HTc2-ogP0sQSh49vw,3874
 hestia_earth/models/utils/source.py,sha256=Y-CcO5Y3q5Hz4A4RdX35C1EUjL9w1NKnOrzVfOWQ7nU,1748
 hestia_earth/models/utils/temperature.py,sha256=ljlG4-yCgFFb6LRZweb18cZKLrr7K2mqd4E4Hz_D1f8,476
-hestia_earth/models/utils/term.py,sha256=pGg59IUaiTWlqKiT2jgIGvfZriVXaPwsLUbxWvBPXtQ,17812
+hestia_earth/models/utils/term.py,sha256=lStzguJ0x13bPWzzNYD3cjZZVNDZ9xhl2jlAsMJHrxw,18327
 hestia_earth/models/utils/transformation.py,sha256=nyT5Mz4_VgFwhkL8JoNX9kxxow0zuxzsYl3W8xOu2p0,370
 hestia_earth/models/webbEtAl2012AndSintermannEtAl2012/__init__.py,sha256=Niv7ZFMBCwThlbCKGOwA17QdkpOUDFrqrFItGNqnZAA,434
 hestia_earth/models/webbEtAl2012AndSintermannEtAl2012/nh3ToAirOrganicFertiliser.py,sha256=TGXyusrRd9shT842iqbrI6MkQhICgw7uYdrl4jsDrg8,4193
@@ -683,7 +683,7 @@ tests/models/faostat2018/test_coldCarcassWeightPerHead.py,sha256=RImhLygwrJ2RoEH
 tests/models/faostat2018/test_coldDressedCarcassWeightPerHead.py,sha256=hZVKMtf-F5Iz7igZVahDJoqzfm2VtcIlwWBPCry7kqw,1594
 tests/models/faostat2018/test_landTransformationFromCropland100YearAverage.py,sha256=AkDXj4qNKgbu5xRbw9u_cUibnVSnAK1CN8pc4IjK9fk,1263
 tests/models/faostat2018/test_landTransformationFromCropland20YearAverage.py,sha256=L03Xh1QbbXc9yGdMoHGNmyCpu9WKANNiEE73NoBSqxk,1260
-tests/models/faostat2018/test_liveweightPerHead.py,sha256=1gnezEdoWvb8Hu-W6YCD3ffI0hAYM8giz9Sl1YxgQDM,4500
+tests/models/faostat2018/test_liveweightPerHead.py,sha256=5Z0Fw7iT3-REg8QjK8tUpWs5bUIG4fjWDM7SEOSYBcw,4799
 tests/models/faostat2018/test_readyToCookWeightPerHead.py,sha256=pMDcONs0WUvANcJ6_OPF7TBwMF45JGMxFRPNPtHLqVI,1570
 tests/models/faostat2018/test_seed.py,sha256=tUXoNVveX0m0ed9UXB4zXxIZsPxktXyUXlbWuUKG0sQ,1705
 tests/models/faostat2018/product/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
@@ -1009,7 +1009,7 @@ tests/models/site/test_brackishWater.py,sha256=YGCp4glaWudKklYBSp-50KbfvIRtp3F4Q
 tests/models/site/test_cationExchangeCapacityPerKgSoil.py,sha256=tNMhN998vcjQ15I-5mNnFh2d7mHzEBIBO6o1VSfQNUE,1075
 tests/models/site/test_flowingWater.py,sha256=t_rxvdlmUVDsFBoDF20_zDM-0iiLKkNCV7knO9l1T7o,1370
 tests/models/site/test_freshWater.py,sha256=GOeAxHhPW_2E1wQdQRX4W-r7mnb_LgmiAVLImitoApw,982
-tests/models/site/test_management.py,sha256=1ecEbbHNmzA-qSw9-d_sGi-j64FXOCxUm1WLSEmPJHU,12659
+tests/models/site/test_management.py,sha256=b6CyvJ35Qa5utjsH6d5jo5AHnrb3k3Uv-ez0P6PWask,14102
 tests/models/site/test_netPrimaryProduction.py,sha256=JCxG0MODbKVvl3hOqmKzh4FjHYn3Xs9KsVod6LvKQII,1108
 tests/models/site/test_organicCarbonPerHa.py,sha256=XtGrE7ZqthTF0x8lDxJ1slNd_GvYHEyEydcRgA46jEc,3207
 tests/models/site/test_organicCarbonPerKgSoil.py,sha256=0M-NMg_T3UXzGT_VlKOKhSxg4cZ0_zhd3FRgY5Hpj6o,1087
@@ -1088,8 +1088,8 @@ tests/models/utils/test_source.py,sha256=mv3vHZV5cjpoLA2I1109-YUkuzAiuhbRSnv_76_
 tests/models/utils/test_term.py,sha256=M5Sa26v2gzQYbZ4H_fo7DspnaCx__-WtL-MULGapCWk,3509
 tests/models/webbEtAl2012AndSintermannEtAl2012/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 tests/models/webbEtAl2012AndSintermannEtAl2012/test_nh3ToAirOrganicFertiliser.py,sha256=qi2FNXS5Af2WDtm7nq_FsprH3BfCF0XxnE0XHmC4aIY,2244
-hestia_earth_models-0.62.3.dist-info/LICENSE,sha256=AC7h7GAgCZGJK_Tzh6LUCrML9gQEfowWwecEw2w54QM,1154
-hestia_earth_models-0.62.3.dist-info/METADATA,sha256=W88V_K9ahWR2FHo76_7FbHPa6QINUx_0glKvYrO5G1c,3343
-hestia_earth_models-0.62.3.dist-info/WHEEL,sha256=eOLhNAGa2EW3wWl_TU484h7q1UNgy0JXjjoqKoxAAQc,92
-hestia_earth_models-0.62.3.dist-info/top_level.txt,sha256=1dqA9TqpOLTEgpqa-YBsmbCmmNU1y56AtfFGEceZ2A0,19
-hestia_earth_models-0.62.3.dist-info/RECORD,,
+hestia_earth_models-0.62.4.dist-info/LICENSE,sha256=AC7h7GAgCZGJK_Tzh6LUCrML9gQEfowWwecEw2w54QM,1154
+hestia_earth_models-0.62.4.dist-info/METADATA,sha256=WJCEsKRmOjSYJeIm86qjEAHu6PX_HQK_KQwrUrabBDQ,3343
+hestia_earth_models-0.62.4.dist-info/WHEEL,sha256=eOLhNAGa2EW3wWl_TU484h7q1UNgy0JXjjoqKoxAAQc,92
+hestia_earth_models-0.62.4.dist-info/top_level.txt,sha256=1dqA9TqpOLTEgpqa-YBsmbCmmNU1y56AtfFGEceZ2A0,19
+hestia_earth_models-0.62.4.dist-info/RECORD,,

tests/models/faostat2018/test_liveweightPerHead.py

@@ -123,3 +123,12 @@ def test_run_liveAnimal_sheepLamb(mock_download_hestia, *args):
     }
     value = run(cycle)
     assert value == expected
+
+
+@patch(f"{class_path}._new_property", side_effect=fake_new_property)
+def test_run_liveAninal_missing_term_id(*args):
+    with open(f"{fixtures_folder}/liveAnimal/missing-fao-term-id/cycle.jsonld", encoding='utf-8') as f:
+        cycle = json.load(f)
+
+    value = run(cycle)
+    assert value == []

tests/models/site/test_management.py

@@ -2,7 +2,7 @@ import json
 from unittest.mock import patch
 
 import pytest
-from hestia_earth.schema import TermTermType
+from hestia_earth.schema import TermTermType, SiteSiteType
 
 from hestia_earth.models.site.management import MODEL, MODEL_KEY, run, _should_run
 from hestia_earth.models.utils.blank_node import condense_nodes
@@ -17,8 +17,17 @@ TERM_BY_ID = {
     'oatPlant': {'@type': 'Term', '@id': 'oatPlant', 'termType': TermTermType.LANDCOVER.value},
     'agatiTree': {'@type': 'Term', '@id': 'agatiTree', 'termType': TermTermType.LANDCOVER.value},
     'wildGarlicPlant': {'@type': 'Term', '@id': 'wildGarlicPlant', 'termType': TermTermType.LANDCOVER.value},
+    'animalHousing': {
+        "@type": "Term",
+        "@id": "animalHousing",
+        "name": "Animal housing",
+        "termType": TermTermType.LANDCOVER.value,
+        "units": "% area"
+    }
 }
 
+LAND_COVER_TERM_BY_SITE_TYPE = {SiteSiteType.ANIMAL_HOUSING.value: "animalHousing"}
+
 
 def lookup_side_effect(*args, **kwargs):
     # Values taken from real lookups.
@@ -233,7 +242,7 @@ def test_should_run(mock_related_cycles, *args):
     should_run, *args = _should_run({})
     assert should_run is True
 
-    # with relevant product => run
+    # with relevant product, blank site_type => no run
     mock_related_cycles.return_value = [
         {
             "products": [
@@ -253,6 +262,28 @@ def test_should_run(mock_related_cycles, *args):
         }
     ]
     should_run, *args = _should_run({})
+    assert should_run is False
+
+    # with relevant product and site_type => run
+    mock_related_cycles.return_value = [
+        {
+            "products": [
+                {
+                    "term": {
+                        "termType": TermTermType.CROP.value,
+                        "@id": "genericCropProduct"
+                    },
+                    "value": [51],
+                    "startDate": "2001",
+                    "endDate": "2002",
+                    "properties": {"test": "properties"}
+                }
+            ],
+            "startDate": "2021",
+            "endDate": "2022"
+        }
+    ]
+    should_run, *args = _should_run({"siteType": "cropland"})
     assert should_run is True
     assert args[0] == [{
         'term': TERM_BY_ID['genericCropPlant'],
@@ -270,7 +301,7 @@ def test_should_run(mock_related_cycles, *args):
         ("Example 2", f"{fixtures_folder}/inputs/example2"),
         ("Example 3", f"{fixtures_folder}/inputs/example3"),
         ("Example 4", f"{fixtures_folder}/inputs/example4"),
-        ("Condense Nodes", f"{fixtures_folder}/inputs/condense_nodes")
+        ("Condense Nodes", f"{fixtures_folder}/inputs/condense_nodes"),
         # Expected:
         #   - appleTree (81) x 3 condenses 2020-03-01 to 2021-02-15
         #   - animalManureUsed (true) x 2 condenses 2001-04-01 to 2001-12-31
@@ -282,18 +313,34 @@ def test_should_run(mock_related_cycles, *args):
         #   - sassafrasTree (86) x 2 condenses 2001-01-01 to 2004-12-31
         #   - bananaPlant (87) does not condense [non-consecutive years]
         #   - durianTree (89) does not condense [dates overwritten See 808]
+        ("Site Type", f"{fixtures_folder}/inputs/site_type")
     ]
 )
-@patch(f"{CLASS_PATH}.download_hestia", side_effect=lambda id, *args: TERM_BY_ID[id])
+@patch(
+    f"{CLASS_PATH}.get_landCover_term_id_from_site_type",
+    side_effect=lambda site_type: LAND_COVER_TERM_BY_SITE_TYPE[site_type]
+)
+@patch(f"{CLASS_PATH}.download_hestia", side_effect=lambda term_id, *args: TERM_BY_ID[term_id])
 @patch(f"{CLASS_PATH}.related_cycles")
 @patch(f"{CLASS_PATH}._get_lookup_with_debug", side_effect=lookup_side_effect)
-def test_run(mock_get_lookup_with_debug, mock_related_cycles, mock_download, test_name, fixture_path):
+def test_run(
+        mock_get_lookup_with_debug,
+        mock_related_cycles,
+        mock_download,
+        mock_land_cover_lookup,
+        test_name,
+        fixture_path
+):
     with open(f"{fixture_path}/cycles.jsonld", encoding='utf-8') as f:
         cycles = json.load(f)
     mock_related_cycles.return_value = cycles
 
-    with open(f"{fixtures_folder}/site.jsonld", encoding='utf-8') as f:
-        site = json.load(f)
+    try:
+        with open(f"{fixture_path}/site.jsonld", encoding='utf-8') as f:
+            site = json.load(f)
+    except FileNotFoundError:
+        with open(f"{fixtures_folder}/site.jsonld", encoding='utf-8') as f:
+            site = json.load(f)
 
     with open(f"{fixture_path}/result.jsonld", encoding='utf-8') as f:
         expected = json.load(f)