hestia-earth-models 0.59.3__py3-none-any.whl → 0.59.5__py3-none-any.whl

tests/models/site/test_management.py

@@ -1,8 +1,10 @@
 import json
 from unittest.mock import patch
+
+import pytest
 from hestia_earth.schema import TermTermType
 
-from hestia_earth.models.site.management import MODEL, MODEL_KEY, run, should_run
+from hestia_earth.models.site.management import MODEL, MODEL_KEY, run, _should_run
 from tests.utils import fixtures_path
 
 CLASS_PATH = f"hestia_earth.models.{MODEL}.{MODEL_KEY}"
@@ -13,18 +15,28 @@ TERM_BY_ID = {
 }
 
 
+def lookup_side_effect(*args, **kwargs):
+    # Values taken from real lookups.
+    _ = kwargs
+    if args[0]["@id"] == "ureaKgN" and args[1] == "nitrogenContent":
+        return 45.5
+    if args[0]["@id"] == "compostKgMass" and args[1] == "ANIMAL_MANURE":
+        return False
+    return True
+
+
 @patch(f"{CLASS_PATH}.download_hestia", side_effect=lambda id, *args: TERM_BY_ID[id])
 @patch(f"{CLASS_PATH}.related_cycles")
 def test_should_run(mock_related_cycles, *args):
     # no cycles => do not run
     mock_related_cycles.return_value = []
-    _should_run, *args = should_run({})
-    assert _should_run is False
+    should_run, *args = _should_run({})
+    assert should_run is False
 
     # no products => do not run
     mock_related_cycles.return_value = [{"products": []}]
-    _should_run, *args = should_run({})
-    assert _should_run is False
+    should_run, *args = _should_run({})
+    assert should_run is False
 
     # with irrelevant termType => do not run
     mock_related_cycles.return_value = [
@@ -37,8 +49,8 @@ def test_should_run(mock_related_cycles, *args):
             "endDate": "2022"
         }
     ]
-    _should_run, *args = should_run({})
-    assert _should_run is False
+    should_run, *args = _should_run({})
+    assert should_run is False
 
     # products and practices but no relevant terms/termTypes => do not run
     mock_related_cycles.return_value = [
@@ -53,8 +65,8 @@ def test_should_run(mock_related_cycles, *args):
             ]
         }
     ]
-    _should_run, *args = should_run({})
-    assert _should_run is False
+    should_run, *args = _should_run({})
+    assert should_run is False
 
     # # practices with relevant termType => run
     mock_related_cycles.return_value = [
@@ -67,8 +79,8 @@ def test_should_run(mock_related_cycles, *args):
             "endDate": "2022"
         }
     ]
-    _should_run, *args = should_run({})
-    assert _should_run is True
+    should_run, *args = _should_run({})
+    assert should_run is True
 
     # with relevant product => run
     mock_related_cycles.return_value = [
@@ -89,8 +101,8 @@ def test_should_run(mock_related_cycles, *args):
             "endDate": "2022"
         }
     ]
-    _should_run, *args = should_run({})
-    assert _should_run is True
+    should_run, *args = _should_run({})
+    assert should_run is True
     assert args[0] == [{
         'term': TERM_BY_ID['genericCropPlant'],
         'value': 100,
@@ -100,17 +112,26 @@ def test_should_run(mock_related_cycles, *args):
     }]
 
 
+@pytest.mark.parametrize(
+    "test_name,fixture_path",
+    [
+        ("Example 1", f"{fixtures_folder}/inputs/example1"),
+        ("Example 2", f"{fixtures_folder}/inputs/example2"),
+        ("Example 3", f"{fixtures_folder}/inputs/example3")
+    ]
+)
 @patch(f"{CLASS_PATH}.download_hestia", side_effect=lambda id, *args: TERM_BY_ID[id])
 @patch(f"{CLASS_PATH}.related_cycles")
-def test_run(mock_related_cycles, *args):
-    with open(f"{fixtures_folder}/cycles.jsonld", encoding='utf-8') as f:
+@patch(f"{CLASS_PATH}._get_lookup_with_debug", side_effect=lookup_side_effect)
+def test_run(mock_get_lookup_with_debug, mock_related_cycles, mock_download, test_name, fixture_path):
+    with open(f"{fixture_path}/cycles.jsonld", encoding='utf-8') as f:
         cycles = json.load(f)
     mock_related_cycles.return_value = cycles
 
     with open(f"{fixtures_folder}/site.jsonld", encoding='utf-8') as f:
         site = json.load(f)
 
-    with open(f"{fixtures_folder}/result.jsonld", encoding='utf-8') as f:
+    with open(f"{fixture_path}/result.jsonld", encoding='utf-8') as f:
         expected = json.load(f)
 
     result = run(site)

tests/models/site/test_soilMeasurement.py

@@ -79,12 +79,12 @@ def test_harmonise_measurements(measurements_list, returns_dict, expected_value)
         (
             "missing dates => run",
             {
-                "measurements":
-                [
+                "measurements": [
                     {
                         "term": {"@id": "clayContent"},
                         "depthUpper": 0,
-                        "depthLower": 20
+                        "depthLower": 20,
+                        "value": [0]
                     }
                 ]
             },
@@ -93,29 +93,43 @@ def test_harmonise_measurements(measurements_list, returns_dict, expected_value)
         (
             "no depthUpper => no run",
             {
-                "measurements":
-                    [
-                        {
-                            "term": {"@id": "clayContent"},
-                            "dates": ["2022-01-02"],
-                            "depthLower": 20
-                        }
-                    ]
+                "measurements": [
+                    {
+                        "term": {"@id": "clayContent"},
+                        "dates": ["2022-01-02"],
+                        "depthLower": 20,
+                        "value": [0]
+                    }
+                ]
+            },
+            False
+        ),
+        (
+            "missing value => not run",
+            {
+                "measurements": [
+                    {
+                        "term": {"@id": "clayContent"},
+                        "dates": ["2022-01-02"],
+                        "depthUpper": 0,
+                        "depthLower": 20
+                    }
+                ]
             },
             False
         ),
         (
             "all fields => run",
             {
-                "measurements":
-                    [
-                        {
-                            "term": {"@id": "clayContent"},
-                            "dates": ["2022-01-02"],
-                            "depthUpper": 0,
-                            "depthLower": 20
-                        }
-                    ]
+                "measurements": [
+                    {
+                        "term": {"@id": "clayContent"},
+                        "dates": ["2022-01-02"],
+                        "depthUpper": 0,
+                        "depthLower": 20,
+                        "value": [0]
+                    }
+                ]
             },
             True
         )
@@ -141,7 +155,12 @@ def lookup_side_effect(*args, **kwargs):
 @pytest.mark.parametrize(
     "test_name",
     [
-        "missingDepth", "simpleSoilPh", "clayContent", "missingDepth", "nonUniqueMeasurements", "arrays"
+        "missing-depth",
+        "missing-value",
+        "simple-soilPh",
+        "clayContent",
+        "non-unique-measurements",
+        "arrays"
     ]
 )
 @patch(f"{class_path}._new_measurement", side_effect=fake_new_measurement)

tests/models/utils/test_site.py

@@ -19,7 +19,7 @@ def test_region_level_1_id():
 
 
 @patch(f"{class_path}.find_related", return_value=[CYCLE])
-@patch(f"{class_path}.download_hestia", return_value=CYCLE)
+@patch(f"{class_path}._load_calculated_node", return_value=CYCLE)
 def test_related_cycles(*args):
     assert related_cycles('id') == [CYCLE]
 

tests/models/utils/test_term.py

@@ -4,7 +4,7 @@ from hestia_earth.models.utils.term import (
     get_liquid_fuel_terms, get_irrigation_terms, get_urea_terms, get_excreta_N_terms, get_excreta_VS_terms,
     get_generic_crop, get_rice_paddy_terms, get_tillage_terms, get_crop_residue_terms, get_cover_crop_property_terms,
     get_crop_residue_incorporated_or_left_on_field_terms, get_irrigated_terms, get_residue_removed_or_burnt_terms,
-    get_upland_rice_land_cover_terms, get_upland_rice_crop_terms, get_long_fallow_land_cover_terms
+    get_upland_rice_land_cover_terms, get_upland_rice_crop_terms
 )
 
 class_path = 'hestia_earth.models.utils.term'
@@ -113,10 +113,3 @@ def test_get_upland_rice_crop_terms(mock_find_node):
     id = 'term-id'
     mock_find_node.return_value = [{'@id': id}]
     assert get_upland_rice_crop_terms() == [id]
-
-
-@patch(f"{class_path}.search")
-def test_get_long_fallow_land_cover_terms(mock_find_node):
-    id = 'term-id'
-    mock_find_node.return_value = [{'@id': id}]
-    assert get_long_fallow_land_cover_terms() == [id]