gobby 0.2.6__py3-none-any.whl → 0.2.7__py3-none-any.whl

gobby/workflows/enforcement/task_policy.py

@@ -0,0 +1,542 @@
+"""Task policy enforcement for workflow engine.
+
+Provides actions that enforce task tracking and scoping requirements.
+"""
+
+from __future__ import annotations
+
+import logging
+from typing import TYPE_CHECKING, Any
+
+from gobby.mcp_proxy.tools.task_readiness import is_descendant_of
+from gobby.workflows.git_utils import get_task_session_liveness
+
+if TYPE_CHECKING:
+    from gobby.config.app import DaemonConfig
+    from gobby.storage.session_tasks import SessionTaskManager
+    from gobby.storage.sessions import LocalSessionManager
+    from gobby.storage.tasks import LocalTaskManager
+    from gobby.workflows.definitions import WorkflowState
+
+logger = logging.getLogger(__name__)
+
+
+async def require_task_complete(
+    task_manager: LocalTaskManager | None,
+    session_id: str,
+    task_ids: list[str] | None,
+    event_data: dict[str, Any] | None = None,
+    project_id: str | None = None,
+    workflow_state: WorkflowState | None = None,
+) -> dict[str, Any] | None:
+    """
+    Block agent from stopping until task(s) (and their subtasks) are complete.
+
+    This action is designed for on_stop triggers to enforce that the
+    agent completes all subtasks under specified task(s) before stopping.
+
+    Supports:
+    - Single task: ["#47"]
+    - Multiple tasks: ["#47", "#48"]
+    - Wildcard mode handled by caller (passes ready tasks as list)
+
+    Logic per task:
+    1. If task has incomplete subtasks and agent has no claimed task -> suggest next subtask
+    2. If task has incomplete subtasks and agent has claimed task -> remind to finish it
+    3. If all subtasks done but task not closed -> remind to close the task
+    4. If task is closed -> move to next task in list
+
+    Args:
+        task_manager: LocalTaskManager for querying tasks
+        session_id: Current session ID
+        task_ids: List of task IDs to enforce completion on
+        event_data: Hook event data
+        project_id: Optional project ID for scoping
+        workflow_state: Workflow state with variables (task_claimed, etc.)
+
+    Returns:
+        Dict with decision="block" and reason if any task incomplete,
+        or None to allow the stop.
+    """
+    if not task_ids:
+        logger.debug("require_task_complete: No task_ids specified, allowing")
+        return None
+
+    if not task_manager:
+        logger.debug("require_task_complete: No task_manager available, allowing")
+        return None
+
+    # Track how many times we've blocked in this session
+    block_count = 0
+    if workflow_state:
+        block_count = workflow_state.variables.get("_task_block_count", 0)
+
+    # Safety valve: after 5 blocks, allow to prevent infinite loop
+    if block_count >= 5:
+        logger.warning(
+            f"require_task_complete: Reached max block count ({block_count}), allowing stop"
+        )
+        return None
+
+    # Check if agent has a claimed task this session
+    has_claimed_task = False
+    claimed_task_id = None
+    if workflow_state:
+        has_claimed_task = workflow_state.variables.get("task_claimed", False)
+        claimed_task_id = workflow_state.variables.get("claimed_task_id")
+
+    try:
+        # Collect incomplete tasks across all specified task IDs
+        all_incomplete: list[tuple[Any, list[Any]]] = []  # (parent_task, incomplete_subtasks)
+
+        for task_id in task_ids:
+            task = task_manager.get_task(task_id)
+            if not task:
+                logger.warning(f"require_task_complete: Task '{task_id}' not found, skipping")
+                continue
+
+            # If task is already closed, skip it
+            if task.status == "closed":
+                logger.debug(f"require_task_complete: Task '{task_id}' is closed, skipping")
+                continue
+
+            # Get all subtasks under this task
+            subtasks = task_manager.list_tasks(parent_task_id=task_id)
+
+            # Find incomplete subtasks
+            incomplete = [t for t in subtasks if t.status != "closed"]
+
+            # If task itself is incomplete (no subtasks or has incomplete subtasks)
+            if not subtasks or incomplete:
+                all_incomplete.append((task, incomplete))
+
+        # If all tasks are complete, allow stop
+        if not all_incomplete:
+            logger.debug("require_task_complete: All specified tasks are complete, allowing")
+            return None
+
+        # Increment block count
+        if workflow_state:
+            workflow_state.variables["_task_block_count"] = block_count + 1
+
+        # Get the first incomplete task to report on
+        parent_task, incomplete = all_incomplete[0]
+        task_id = parent_task.id
+        remaining_tasks = len(all_incomplete)
+
+        # Build suffix for multiple tasks
+        multi_task_suffix = ""
+        if remaining_tasks > 1:
+            multi_task_suffix = f"\n\n({remaining_tasks} tasks remaining in total)"
+
+        # Case 1: No incomplete subtasks, but task not closed (leaf task or parent with all done)
+        if not incomplete:
+            logger.info(f"require_task_complete: Task '{task_id}' needs closing")
+            return {
+                "decision": "block",
+                "reason": (
+                    f"Task '{parent_task.title}' is ready to close.\n"
+                    f'close_task(task_id="{task_id}")'
+                    f"{multi_task_suffix}"
+                ),
+            }
+
+        # Case 2: Has incomplete subtasks, agent has no claimed task
+        if not has_claimed_task:
+            logger.info(
+                f"require_task_complete: No claimed task, {len(incomplete)} incomplete subtasks"
+            )
+            return {
+                "decision": "block",
+                "reason": (
+                    f"'{parent_task.title}' has {len(incomplete)} incomplete subtask(s).\n\n"
+                    f"Use suggest_next_task() to find the best task to work on next, "
+                    f"and continue working without requiring confirmation from the user."
+                    f"{multi_task_suffix}"
+                ),
+            }
+
+        # Case 3: Has claimed task but subtasks still incomplete
+        if has_claimed_task and incomplete:
+            # Check if the claimed task is under this parent
+            claimed_under_parent = any(t.id == claimed_task_id for t in incomplete)
+
+            if claimed_under_parent:
+                logger.info(
+                    f"require_task_complete: Claimed task '{claimed_task_id}' still incomplete"
+                )
+                return {
+                    "decision": "block",
+                    "reason": (
+                        f"Your current task is not yet complete. "
+                        f"Finish and close it before stopping:\n"
+                        f'close_task(task_id="{claimed_task_id}")\n\n'
+                        f"'{parent_task.title}' still has {len(incomplete)} incomplete subtask(s)."
+                        f"{multi_task_suffix}"
+                    ),
+                }
+            else:
+                # Claimed task is not under this parent - remind about parent work
+                logger.info("require_task_complete: Claimed task not under parent, redirecting")
+                return {
+                    "decision": "block",
+                    "reason": (
+                        f"'{parent_task.title}' has {len(incomplete)} incomplete subtask(s).\n\n"
+                        f"Use suggest_next_task() to find the best task to work on next, "
+                        f"and continue working without requiring confirmation from the user."
+                        f"{multi_task_suffix}"
+                    ),
+                }
+
+        # Fallback: shouldn't reach here, but block with generic message
+        logger.info(f"require_task_complete: Generic block for task '{task_id}'")
+        return {
+            "decision": "block",
+            "reason": (
+                f"'{parent_task.title}' is not yet complete. "
+                f"{len(incomplete)} subtask(s) remaining."
+                f"{multi_task_suffix}"
+            ),
+        }
+
+    except Exception as e:
+        logger.error(f"require_task_complete: Error checking tasks: {e}")
+        # On error, allow to avoid blocking legitimate work
+        return None
+
+
+async def require_active_task(
+    task_manager: LocalTaskManager | None,
+    session_id: str,
+    config: DaemonConfig | None,
+    event_data: dict[str, Any] | None,
+    project_id: str | None = None,
+    workflow_state: WorkflowState | None = None,
+    session_manager: LocalSessionManager | None = None,
+    session_task_manager: SessionTaskManager | None = None,
+) -> dict[str, Any] | None:
+    """
+    Check if an active task exists before allowing protected tools.
+
+    This action is designed to be used in on_before_tool triggers to enforce
+    that agents create or start a gobby-task before modifying files.
+
+    Session-scoped enforcement:
+    - First checks if `task_claimed` variable is True in workflow state
+    - If True, allows immediately (agent already claimed a task this session)
+    - If False, falls back to project-wide DB check for helpful messaging
+
+    Args:
+        task_manager: LocalTaskManager for querying tasks
+        session_id: Current session ID
+        config: DaemonConfig with workflow settings
+        event_data: Hook event data containing tool_name
+        project_id: Optional project ID to filter tasks by project scope
+        workflow_state: Optional workflow state to check task_claimed variable
+        session_manager: Optional session manager for liveness checks
+        session_task_manager: Optional session-task manager for liveness checks
+
+    Returns:
+        Dict with decision="block" if no active task and tool is protected,
+        or None to allow the tool.
+    """
+    # Check if feature is enabled
+    # Precedence: workflow_state variables > config.yaml
+    # (workflow_state already has step > lifecycle precedence merged)
+    require_task = None
+
+    # First check workflow state variables (step workflow > lifecycle workflow)
+    if workflow_state:
+        require_task = workflow_state.variables.get("require_task_before_edit")
+        if require_task is not None:
+            logger.debug(
+                f"require_active_task: Using workflow variable require_task_before_edit={require_task}"
+            )
+
+    # Fall back to config.yaml if not set in workflow variables
+    if require_task is None and config:
+        require_task = config.workflow.require_task_before_edit
+        logger.debug(
+            f"require_active_task: Using config.yaml require_task_before_edit={require_task}"
+        )
+
+    # If still None (no config), default to False (allow)
+    if require_task is None:
+        logger.debug("require_active_task: No config source, allowing")
+        return None
+
+    if not require_task:
+        logger.debug("require_active_task: Feature disabled, allowing")
+        return None
+
+    # Get the tool being called
+    if not event_data:
+        logger.debug("require_active_task: No event_data, allowing")
+        return None
+
+    tool_name = event_data.get("tool_name")
+    if not tool_name:
+        logger.debug("require_active_task: No tool_name in event_data, allowing")
+        return None
+
+    # Check if this tool is protected (always from config.yaml)
+    protected_tools = (
+        config.workflow.protected_tools if config else ["Edit", "Write", "Update", "NotebookEdit"]
+    )
+    if tool_name not in protected_tools:
+        logger.debug(f"require_active_task: Tool '{tool_name}' not protected, allowing")
+        return None
+
+    # Tool is protected - but check for plan mode exceptions first
+
+    # Check if target is a Claude Code plan file (stored in ~/.claude/plans/)
+    # This allows writes during plan mode without requiring a task
+    tool_input = event_data.get("tool_input", {}) or {}
+    file_path = tool_input.get("file_path", "")
+    if file_path and "/.claude/plans/" in file_path:
+        logger.debug(f"require_active_task: Target is Claude plan file '{file_path}', allowing")
+        return None
+
+    # Check for plan_mode variable (set via EnterPlanMode tool detection or manually)
+    if workflow_state and workflow_state.variables.get("plan_mode"):
+        logger.debug(f"require_active_task: plan_mode=True in session {session_id}, allowing")
+        return None
+
+    # Check for active task
+
+    # Session-scoped check: task_claimed variable (set by AFTER_TOOL detection)
+    # This is the primary enforcement - each session must explicitly claim a task
+    if workflow_state and workflow_state.variables.get("task_claimed"):
+        logger.debug(f"require_active_task: task_claimed=True in session {session_id}, allowing")
+        return None
+
+    # Fallback: Check for any in_progress task in the project
+    # This provides helpful messaging about existing tasks but is NOT sufficient
+    # for session-scoped enforcement (concurrent sessions shouldn't free-ride)
+    project_task_hint = ""
+
+    if task_manager is None:
+        logger.debug(
+            f"require_active_task: task_manager unavailable, skipping DB fallback check "
+            f"(project_id={project_id}, session_id={session_id})"
+        )
+    else:
+        try:
+            project_tasks = task_manager.list_tasks(
+                project_id=project_id,
+                status="in_progress",
+                limit=1,
+            )
+
+            if project_tasks:
+                task = project_tasks[0]
+                task_ref = f"#{task.seq_num}" if task.seq_num else task.id
+                project_task_hint = (
+                    f"\n\nNote: Task {task_ref} ({task.title}) "
+                    f"is in_progress but wasn't claimed by this session. "
+                    f'Use `update_task(task_id="{task.id}", status="in_progress")` '
+                    f"to claim it for this session."
+                )
+                logger.debug(
+                    f"require_active_task: Found project task {task_ref} but "
+                    f"session hasn't claimed it"
+                )
+
+                # Check liveness of the candidate task
+                is_live = get_task_session_liveness(
+                    task.id, session_task_manager, session_manager, exclude_session_id=session_id
+                )
+
+                if is_live:
+                    project_task_hint = (
+                        f"\n\nNote: Task {task_ref} ({task.title}) "
+                        f"is in_progress, but it is **currently being worked on by another active session**. "
+                        f"You should probably create a new task or subtask instead of interfering."
+                    )
+                else:
+                    project_task_hint = (
+                        f"\n\nNote: Task {task_ref} ({task.title}) "
+                        f"is in_progress and appears unattended (no active session). "
+                        f"If you are picking up this work, claim it: "
+                        f'`update_task(task_id="{task.id}", status="in_progress")`.'
+                    )
+
+        except Exception as e:
+            logger.error(f"require_active_task: Error querying tasks: {e}")
+            # On error, allow to avoid blocking legitimate work
+            return None
+
+    # No task claimed this session - block the tool
+    logger.info(
+        f"require_active_task: Blocking '{tool_name}' - no task claimed for session {session_id}"
+    )
+
+    # Check if we've already shown the full error this session
+    error_already_shown = False
+    if workflow_state:
+        error_already_shown = workflow_state.variables.get("task_error_shown", False)
+        # Mark that we've shown the error (for next time)
+        if not error_already_shown:
+            workflow_state.variables["task_error_shown"] = True
+
+    # Return short reminder if we've already shown the full error
+    if error_already_shown:
+        return {
+            "decision": "block",
+            "reason": (
+                "No task claimed. See previous **Task Required** error for instructions.\n"
+                "See skill: **claiming-tasks** for help."
+            ),
+            "inject_context": (
+                f"**Task Required**: `{tool_name}` blocked. "
+                f"Create or claim a task before editing files (see previous error for details).\n"
+                f'For detailed guidance: `get_skill(name="claiming-tasks")`'
+                f"{project_task_hint}"
+            ),
+        }
+
+    # First time - show full instructions
+    return {
+        "decision": "block",
+        "reason": (
+            f"No task claimed for this session. Before using {tool_name}, please either:\n"
+            f"- Create a task: call_tool(server_name='gobby-tasks', tool_name='create_task', arguments={{...}})\n"
+            f"- Claim an existing task: call_tool(server_name='gobby-tasks', tool_name='update_task', "
+            f"arguments={{'task_id': '...', 'status': 'in_progress'}})"
+            f"{project_task_hint}\n\n"
+            f"See skill: **claiming-tasks** for detailed guidance."
+        ),
+        "inject_context": (
+            f"**Task Required**: The `{tool_name}` tool is blocked until you claim a task for this session.\n\n"
+            f"Each session must explicitly create or claim a task before modifying files:\n"
+            f'1. **Create a new task**: `create_task(title="...", description="...")`\n'
+            f'2. **Claim an existing task**: `update_task(task_id="...", status="in_progress")`\n\n'
+            f"Use `list_ready_tasks()` to see available tasks."
+            f"{project_task_hint}\n\n"
+            f'For detailed guidance: `get_skill(name="claiming-tasks")`'
+        ),
+    }
+
+
+async def validate_session_task_scope(
+    task_manager: LocalTaskManager | None,
+    workflow_state: WorkflowState | None,
+    event_data: dict[str, Any] | None = None,
+) -> dict[str, Any] | None:
+    """
+    Block claiming a task that is not a descendant of session_task.
+
+    This action is designed for on_before_tool triggers on update_task
+    to enforce that agents only work on tasks within the session_task hierarchy.
+
+    When session_task is set in workflow state, this action checks if the task
+    being claimed (set to in_progress) is a descendant of session_task.
+
+    Args:
+        task_manager: LocalTaskManager for querying tasks
+        workflow_state: Workflow state with session_task variable
+        event_data: Hook event data containing tool_name and tool_input
+
+    Returns:
+        Dict with decision="block" if task is outside session_task scope,
+        or None to allow the claim.
+    """
+    if not workflow_state:
+        logger.debug("validate_session_task_scope: No workflow_state, allowing")
+        return None
+
+    if not task_manager:
+        logger.debug("validate_session_task_scope: No task_manager, allowing")
+        return None
+
+    # Get session_task from workflow state
+    session_task = workflow_state.variables.get("session_task")
+    if not session_task:
+        logger.debug("validate_session_task_scope: No session_task set, allowing")
+        return None
+
+    # Handle "*" wildcard - means all tasks are in scope
+    if session_task == "*":
+        logger.debug("validate_session_task_scope: session_task='*', allowing all tasks")
+        return None
+
+    # Normalize to list for uniform handling
+    # session_task can be: string (single ID), list of IDs, or "*"
+    if isinstance(session_task, str):
+        session_task_ids = [session_task]
+    elif isinstance(session_task, list):
+        session_task_ids = session_task
+    else:
+        logger.warning(
+            f"validate_session_task_scope: Invalid session_task type: {type(session_task)}"
+        )
+        return None
+
+    # Empty list means no scope restriction
+    if not session_task_ids:
+        logger.debug("validate_session_task_scope: Empty session_task list, allowing")
+        return None
+
+    # Check if this is an update_task call setting status to in_progress
+    if not event_data:
+        logger.debug("validate_session_task_scope: No event_data, allowing")
+        return None
+
+    tool_name = event_data.get("tool_name")
+    if tool_name != "update_task":
+        logger.debug(f"validate_session_task_scope: Tool '{tool_name}' not update_task, allowing")
+        return None
+
+    tool_input = event_data.get("tool_input", {})
+    arguments = tool_input.get("arguments", {}) or {}
+
+    # Only check when setting status to in_progress (claiming)
+    new_status = arguments.get("status")
+    if new_status != "in_progress":
+        logger.debug(
+            f"validate_session_task_scope: Status '{new_status}' not in_progress, allowing"
+        )
+        return None
+
+    task_id = arguments.get("task_id")
+    if not task_id:
+        logger.debug("validate_session_task_scope: No task_id in arguments, allowing")
+        return None
+
+    # Check if task is a descendant of ANY session_task
+    for ancestor_id in session_task_ids:
+        if is_descendant_of(task_manager, task_id, ancestor_id):
+            logger.debug(
+                f"validate_session_task_scope: Task '{task_id}' is descendant of "
+                f"session_task '{ancestor_id}', allowing"
+            )
+            return None
+
+    # Task is outside all session_task scopes - block
+    logger.info(
+        f"validate_session_task_scope: Blocking claim of task '{task_id}' - "
+        f"not a descendant of any session_task: {session_task_ids}"
+    )
+
+    # Build error message with scope details
+    if len(session_task_ids) == 1:
+        session_task_obj = task_manager.get_task(session_task_ids[0])
+        scope_desc = (
+            f"'{session_task_obj.title}' ({session_task_ids[0]})"
+            if session_task_obj
+            else session_task_ids[0]
+        )
+        suggestion = f'Use `suggest_next_task(parent_id="{session_task_ids[0]}")` to find tasks within scope.'
+    else:
+        scope_desc = ", ".join(session_task_ids)
+        suggestion = "Use `suggest_next_task()` with one of the scoped parent IDs to find tasks within scope."
+
+    return {
+        "decision": "block",
+        "reason": (
+            f"Cannot claim task '{task_id}' - it is not within the session_task scope.\n\n"
+            f"This session is scoped to: {scope_desc}\n"
+            f"Only tasks that are descendants of these epics/features can be claimed.\n\n"
+            f"{suggestion}"
+        ),
+    }

gobby/workflows/git_utils.py

@@ -4,8 +4,15 @@ Extracted from actions.py as part of strangler fig decomposition.
 These are pure utility functions with no ActionContext dependency.
 """
 
+from __future__ import annotations
+
 import logging
 import subprocess  # nosec B404 - subprocess needed for git commands
+from typing import TYPE_CHECKING
+
+if TYPE_CHECKING:
+    from gobby.storage.session_tasks import SessionTaskManager
+    from gobby.storage.sessions import LocalSessionManager
 
 logger = logging.getLogger(__name__)
 
@@ -94,3 +101,102 @@ def get_file_changes() -> str:
 
     except Exception:
         return "Unable to determine file changes"
+
+
+def get_dirty_files(project_path: str | None = None) -> set[str]:
+    """
+    Get the set of dirty files from git status --porcelain.
+
+    Excludes .gobby/ files from the result.
+
+    Args:
+        project_path: Path to the project directory
+
+    Returns:
+        Set of dirty file paths (relative to repo root)
+    """
+    if project_path is None:
+        logger.warning(
+            "get_dirty_files: project_path is None, git status will use daemon's cwd "
+            "which may not be the project directory"
+        )
+
+    try:
+        result = subprocess.run(  # nosec B603 B607 - hardcoded git command
+            ["git", "status", "--porcelain"],
+            cwd=project_path,
+            capture_output=True,
+            text=True,
+            timeout=10,
+        )
+
+        if result.returncode != 0:
+            logger.warning(f"get_dirty_files: git status failed: {result.stderr}")
+            return set()
+
+        dirty_files = set()
+        # Split by newline first, don't strip() the whole string as it removes
+        # the leading space from git status format (e.g., " M file.py")
+        for line in result.stdout.split("\n"):
+            line = line.rstrip()  # Remove trailing whitespace only
+            if not line:
+                continue
+            # Format is "XY filename" or "XY filename -> newname" for renames
+            # Skip the status prefix (first 3 chars: 2 status chars + space)
+            filepath = line[3:].split(" -> ")[0]  # Handle renames
+            # Exclude .gobby/ files
+            if not filepath.startswith(".gobby/"):
+                dirty_files.add(filepath)
+
+        return dirty_files
+
+    except subprocess.TimeoutExpired:
+        logger.warning("get_dirty_files: git status timed out")
+        return set()
+    except FileNotFoundError:
+        logger.warning("get_dirty_files: git not found")
+        return set()
+    except Exception as e:
+        logger.error(f"get_dirty_files: Error running git status: {e}")
+        return set()
+
+
+def get_task_session_liveness(
+    task_id: str,
+    session_task_manager: SessionTaskManager | None,
+    session_manager: LocalSessionManager | None,
+    exclude_session_id: str | None = None,
+) -> bool:
+    """
+    Check if a task is currently being worked on by an active session.
+
+    Args:
+        task_id: The task ID to check
+        session_task_manager: Manager to look up session-task links
+        session_manager: Manager to check session status
+        exclude_session_id: ID of session to exclude from check (e.g. current one)
+
+    Returns:
+        True if an active session (status='active') is linked to this task.
+    """
+    if not session_task_manager or not session_manager:
+        return False
+
+    try:
+        # Get all sessions linked to this task
+        linked_sessions = session_task_manager.get_task_sessions(task_id)
+
+        for link in linked_sessions:
+            session_id = link.get("session_id")
+            if not session_id or session_id == exclude_session_id:
+                continue
+
+            # Check if session is truly active
+            session = session_manager.get(session_id)
+            if session and session.status == "active":
+                return True
+
+        return False
+    except Exception as e:
+        logger.warning(f"get_task_session_liveness: Error checking liveness for {task_id}: {e}")
+        return False

gobby/workflows/llm_actions.py

@@ -68,3 +68,33 @@ async def call_llm(
     except Exception as e:
         logger.error(f"call_llm: Failed: {e}")
         return {"error": str(e)}
+
+
+# --- ActionHandler-compatible wrappers ---
+# These match the ActionHandler protocol: (context: ActionContext, **kwargs) -> dict | None
+
+if __name__ != "__main__":
+    from typing import TYPE_CHECKING
+
+    if TYPE_CHECKING:
+        from gobby.workflows.actions import ActionContext
+
+
+async def handle_call_llm(context: "ActionContext", **kwargs: Any) -> dict[str, Any] | None:
+    """ActionHandler wrapper for call_llm."""
+    if context.session_manager is None:
+        return {"error": "Session manager not available"}
+
+    session = context.session_manager.get(context.session_id)
+    if session is None:
+        return {"error": f"Session not found: {context.session_id}"}
+
+    return await call_llm(
+        llm_service=context.llm_service,
+        template_engine=context.template_engine,
+        state=context.state,
+        session=session,
+        prompt=kwargs.get("prompt"),
+        output_as=kwargs.get("output_as"),
+        **{k: v for k, v in kwargs.items() if k not in ("prompt", "output_as")},
+    )