gammasimtools 0.6.0__py3-none-any.whl → 0.8.1__py3-none-any.whl

simtools/utils/names.py

@@ -1,473 +1,411 @@
+"""Validation of names."""
+
+import glob
 import logging
 import re
+from functools import cache
+from pathlib import Path
+
+import yaml
 
 _logger = logging.getLogger(__name__)
 
 __all__ = [
-    "camera_efficiency_log_file_name",
-    "camera_efficiency_results_file_name",
-    "camera_efficiency_simtel_file_name",
-    "convert_telescope_model_name_to_yaml",
-    "get_site_from_telescope_name",
-    "get_telescope_type",
-    "is_valid_name",
+    "generate_file_name",
+    "get_array_element_type_from_name",
+    "get_site_from_array_element_name",
     "layout_telescope_list_file_name",
-    "ray_tracing_file_name",
-    "ray_tracing_plot_file_name",
-    "ray_tracing_results_file_name",
-    "simtel_array_config_file_name",
-    "simtel_telescope_config_file_name",
-    "simtools_instrument_name",
-    "split_telescope_model_name",
-    "validate_camera_name",
-    "validate_array_layout_name",
-    "validate_model_version_name",
-    "validate_name",
-    "validate_simtel_mode_name",
+    "sanitize_name",
+    "simtel_config_file_name",
+    "simtel_single_mirror_list_file_name",
+    "validate_array_element_id_name",
+    "validate_array_element_name",
     "validate_site_name",
-    "validate_sub_system_name",
-    "validate_telescope_id_name",
-    "validate_telescope_model_name",
-    "validate_telescope_name_db",
 ]
 
-lst = "LST"
-mst = "MST"
-sct = "SCT"
-sst = "SST"
-hess = "HESS"
-magic = "MAGIC"
-veritas = "VERITAS"
-
-all_telescope_class_names = {
-    lst: ["lst"],
-    mst: ["mst"],
-    sct: ["sct"],
-    sst: ["sst"],
-    hess: ["hess"],
-    magic: ["magic"],
-    veritas: ["veritas"],
-}
-
-all_camera_names = {
-    "SST": ["sst"],
-    "ASTRI": ["astri"],
-    "GCT": ["gct", "gct-s"],
-    "1M": ["1m"],
-    "FlashCam": ["flashcam", "flash-cam"],
-    "NectarCam": ["nectarcam", "nectar-cam"],
-    "SCT": ["sct"],
-    "LST": ["lst"],
-}
-
-all_structure_names = {"Structure": ["Structure", "structure"]}
-
-all_site_names = {"South": ["paranal", "south"], "North": ["lapalma", "north"]}
-
-all_model_version_names = {
-    "2015-07-21": [""],
-    "2015-10-20-p1": [""],
-    "prod4-v0.0": [""],
-    "prod4-v0.1": [""],
-    "2018-02-16": [""],
-    "prod3_compatible": ["p3", "prod3", "prod3b"],
-    "prod4": ["p4"],
-    "post_prod3_updates": [""],
-    "2016-12-20": [""],
-    "2018-11-07": [""],
-    "2019-02-22": [""],
-    "2019-05-13": [""],
-    "2019-11-20": [""],
-    "2019-12-30": [""],
-    "2020-02-26": [""],
-    "2020-06-28": ["prod5"],
-    "prod4-prototype": [""],
-    "default": [],
-    "Released": [],
-    "Latest": [],
-}
-
-all_simtel_mode_names = {
-    "RayTracing": ["raytracing", "ray-tracing"],
-    "RayTracingSingleMirror": [
-        "raytracing-singlemirror",
-        "ray-tracing-singlemirror",
-        "ray-tracing-single-mirror",
-    ],
-    "Trigger": ["trigger"],
-}
-
-all_array_layout_names = {
-    "4LST": ["4-lst", "4lst"],
-    "1LST": ["1-lst", "1lst"],
-    "4MST": ["4-mst", "4mst"],
-    "1MST": ["1-mst", "mst"],
-    "4SST": ["4-sst", "4sst"],
-    "1SST": ["1-sst", "sst"],
-    "Prod5": ["prod5", "p5"],
-    "TestLayout": ["test-layout"],
-}
-
-corsika_to_simtools_names = {
-    "OBSLEV": "corsika_obs_level",
-}
-
-
-def validate_sub_system_name(name):
-    """
-    Validate a sub system name (optics structure or camera).
 
-    Parameters
-    ----------
-    name: str
-        Name of the subsystem.
+@cache
+def array_elements():
+    """
+    Load array elements from reference files and keep in cache.
 
     Returns
     -------
-    str
-        Validated name.
+    dict
+        Array elements.
     """
-    return validate_name(name, {**all_camera_names, **all_structure_names})
+    base_path = Path(__file__).parent
+    with open(base_path / "../schemas/array_elements.yml", encoding="utf-8") as file:
+        return yaml.safe_load(file)["data"]
 
 
-def validate_camera_name(name):
+@cache
+def site_names():
     """
-    Validate a camera name.
+    Site names from reference file.
 
-    Parameters
-    ----------
-    name: str
-        Camera name
+    The list of sites is derived from the sites listed in the model parameter
+    schema files. Return a dictionary for compatibility with the validation routines.
 
     Returns
     -------
-    str
-        Validated name.
+    dict
+        Site names.
     """
-    return validate_name(name, all_camera_names)
+    _array_elements = array_elements()
+    _sites = {entry["site"] for entry in _array_elements.values()}
+    return {site: [site.lower()] for site in _sites}
+
+
+@cache
+def load_model_parameters(class_key_list):
+    model_parameters = {}
+    schema_files = glob.glob(str(Path(__file__).parent / "../schemas/model_parameters") + "/*.yml")
+    for schema_file in schema_files:
+        with open(schema_file, encoding="utf-8") as f:
+            data = yaml.safe_load(f)
+        try:
+            if data["instrument"]["class"] in class_key_list:
+                model_parameters[data["name"]] = data
+        except KeyError:
+            pass
+    return model_parameters
+
+
+def site_parameters():
+    return load_model_parameters(class_key_list="Site")
+
+
+def telescope_parameters():
+    return load_model_parameters(class_key_list=("Structure", "Camera", "Telescope"))
 
 
-def validate_telescope_id_name(name):
+def validate_array_element_id_name(name):
     """
-    Validate a telescope ID name
+    Validate array element ID.
 
-    Valid names e.g.,
-    - D
-    - telescope ID
+    Allowed IDs are
+    - design (for design array elements or testing)
+    - array element ID (e.g., 1, 5, 15)
+    - test (for testing)
 
     Parameters
     ----------
-    name: str
-        Telescope ID name.
+    name: str or int
+        Array element ID name.
 
     Returns
     -------
     str
-        Validated name.
+        Validated array element ID (added leading zeros, e.g., 1 is converted to 01).
 
     Raises
     ------
     ValueError
         If name is not valid.
     """
+    if isinstance(name, int) or name.isdigit():
+        return f"{int(name):02d}"
+    if name.lower() in ("design", "test"):
+        return str(name).lower()
 
-    if name == "D" or name.isdigit():
-        return name
-
-    msg = f"Invalid telescope ID name {name}"
+    msg = f"Invalid array element ID name {name}"
     _logger.error(msg)
     raise ValueError(msg)
 
 
-def validate_model_version_name(name):
+def validate_site_name(name):
     """
-    Validate a model version name.
+    Validate site name.
 
     Parameters
     ----------
     name: str
-        Model version name.
+        Site name.
 
     Returns
     -------
     str
         Validated name.
     """
-    return validate_name(name, all_model_version_names)
+    return _validate_name(name, site_names())
 
 
-def validate_simtel_mode_name(name):
+def _validate_name(name, all_names):
     """
-    Validate a sim_telarray mode name.
+    Validate name given the all_names options.
+
+    For each key in all_names, a list of options is given.
+    If name is in this list, the key name is returned.
 
     Parameters
     ----------
     name: str
-        sim_telarray mode name.
+        Name to validate.
+    all_names: dict
+        Dictionary with valid names.
 
     Returns
     -------
     str
         Validated name.
-    """
-    return validate_name(name, all_simtel_mode_names)
-
 
-def validate_site_name(name):
+    Raises
+    ------
+    ValueError
+        If name is not valid.
     """
-    Validate a site name.
+    for key in all_names.keys():
+        if isinstance(all_names[key], list) and name.lower() in [
+            item.lower() for item in all_names[key]
+        ]:
+            return key
+        if name.lower() == key.lower():
+            return key
 
-    Parameters
-    ----------
-    name: str
-        Site name.
-
-    Returns
-    -------
-    str
-        Validated name.
-    """
-    return validate_name(name, all_site_names)
+    msg = f"Invalid name {name}"
+    raise ValueError(msg)
 
 
-def validate_array_layout_name(name):
+def validate_array_element_type(name):
     """
-    Validate a array layout name.
+    Validate array element type (e.g., LSTN, MSTN).
 
     Parameters
     ----------
     name: str
-        Layout array name.
+        Array element type.
 
     Returns
     -------
     str
         Validated name.
     """
-    return validate_name(name, all_array_layout_names)
+    return _validate_name(name, array_elements())
 
 
-def validate_name(name, all_names):
+def validate_array_element_name(name):
     """
-    Validate a name given the all_names options. For each key in all_names, a list of options is \
-    given. If name is in this list, the key name is returned.
+    Validate array element name (e.g., MSTN-design, MSTN-01).
 
     Parameters
     ----------
     name: str
-        Name to validate.
-    all_names: dict
-        Dictionary with valid names.
+        Array element name.
+
     Returns
     -------
     str
         Validated name.
-
-    Raises
-    ------
-    ValueError
-        If name is not valid.
     """
-
-    if not is_valid_name(name, all_names):
+    try:
+        _array_element_type, _array_element_id = name.split("-")
+    except ValueError as exc:
         msg = f"Invalid name {name}"
-        raise ValueError(msg)
-    for main_name, list_of_names in all_names.items():
-        if name.lower() in list_of_names + [main_name.lower()]:
-            if name != main_name:
-                _logger.debug(f"Correcting name {name} -> {main_name}")
-            return main_name
-    return None
+        raise ValueError(msg) from exc
+    return (
+        _validate_name(_array_element_type, array_elements())
+        + "-"
+        + validate_array_element_id_name(_array_element_id)
+    )
 
 
-def is_valid_name(name, all_names):
+def get_array_element_name_from_type_site_id(array_element_type, site, array_element_id):
     """
-    Check if name is valid.
+    Get array element name from type, site and ID.
 
     Parameters
     ----------
-    name:  str
-        Name to validated.
-    all_names: dict
-        Dictionary with valid names.
+    array_element_type: str
+        Array element type.
+    site: str
+        Site name.
+    array_element_id: str
+        Array element ID.
 
     Returns
     -------
-    bool
-        True if name is valid. Otherwise, false.
+    str
+        Array element name.
     """
+    _short_site = validate_site_name(site)[0]
+    _val_id = validate_array_element_id_name(array_element_id)
+    return f"{array_element_type}{_short_site}-{_val_id}"
 
-    if not isinstance(name, str):
-        return False
-    for main_name in all_names.keys():
-        if name.lower() in all_names[main_name] + [main_name.lower()]:
-            return True
-    return False
 
-
-def validate_telescope_model_name(name):
+def get_array_element_type_from_name(name):
     """
-    Validate a telescope model name.
+    Get array element type from name, e.g. "LSTN", "MSTN".
 
     Parameters
     ----------
     name: str
-        Telescope model name.
+        Array element name
 
     Returns
     -------
     str
-        Validated name.
+        Array element type.
     """
+    return _validate_name(name.split("-")[0], array_elements())
 
-    tel_class, tel_type = split_telescope_model_name(name)
-    tel_class = validate_name(tel_class, all_telescope_class_names)
-    if "flashcam" in tel_type:
-        tel_type = tel_type.replace("flashcam", "FlashCam")
-    if "nectarcam" in tel_type:
-        tel_type = tel_type.replace("nectarcam", "NectarCam")
-    if "1m" in tel_type:
-        tel_type = tel_type.replace("1m", "1M")
-    if "gct" in tel_type:
-        tel_type = tel_type.replace("gct", "GCT")
-    if "astri" in tel_type:
-        tel_type = tel_type.replace("astri", "ASTRI")
-    if "-d" in "-" + tel_type:
-        tel_type = tel_type.replace("d", "D")
 
-    return tel_class + "-" + tel_type
-
-
-def split_telescope_model_name(name):
+def get_list_of_array_element_types(
+    array_element_class="telescopes", site=None, observatory="CTAO"
+):
     """
-    Split a telescope name into class and type.
+    Get list of array element types.
 
     Parameters
     ----------
-    name: str
-        Telescope name.
+    array_element_class: str
+        Array element class
+    site: str
+        Site name (e.g., South or North).
 
     Returns
     -------
-    str, str
-       class (LST, MST, SST ...) and type (any complement).
+    list
+        List of array element types.
     """
-
-    name_parts = name.split("-")
-    tel_class = name_parts[0]
-    tel_type = "-".join(name_parts[1:])
-    return tel_class, tel_type
+    return [
+        key
+        for key, value in array_elements().items()
+        if value["collection"] == array_element_class
+        and (site is None or value["site"] == site)
+        and (observatory is None or value["observatory"] == observatory)
+    ]
 
 
-def get_site_from_telescope_name(name):
+def get_site_from_array_element_name(name):
     """
-    Get site name (South or North) from the (validated) telescope name.
+    Get site name from array element name.
 
     Parameters
     ----------
     name: str
-        Telescope name.
+        Array element name.
 
     Returns
     -------
     str
         Site name (South or North).
     """
-    return validate_site_name(name.split("-")[0])
+    return array_elements()[get_array_element_type_from_name(name)]["site"]
 
 
-def validate_telescope_name_db(name):
+def get_collection_name_from_array_element_name(name):
     """
-    Validate a telescope DB name.
+    Get collection name (e.g., telescopes, calibration_devices, sites) of array element from name.
 
     Parameters
     ----------
     name: str
+        Array element name.
 
     Returns
     -------
     str
-        Validated name.
+        Collection name .
     """
-    site = get_site_from_telescope_name(name)
-    tel_model_name = "-".join(name.split("-")[1:])
-
-    return f"{validate_site_name(site)}-{validate_telescope_model_name(tel_model_name)}"
+    try:
+        return array_elements()[get_array_element_type_from_name(name)]["collection"]
+    except ValueError:
+        pass
+    try:
+        validate_site_name(name)
+        return "sites"
+    except ValueError as exc:
+        raise ValueError(f"Invalid array element name {name}: {exc}") from exc
 
 
-def convert_telescope_model_name_to_yaml(name):
+def get_simulation_software_name_from_parameter_name(
+    par_name,
+    simulation_software="sim_telarray",
+    search_telescope_parameters=True,
+    search_site_parameters=True,
+):
     """
-    Get telescope name following the old convention (yaml files) from the current telescope name.
+    Get the name used in the simulation software from the model parameter name.
+
+    Name convention is expected to be defined in the schema.
+    Returns the parameter name if no simulation software name is found.
 
     Parameters
     ----------
-    name: str
-        Telescope model name.
+    par_name: str
+        Model parameter name.
+    simulation_software: str
+        Simulation software name.
+    search_telescope_parameters: bool
+        If True, telescope model parameters are included.
+    search_site_parameters: bool
+        If True, site model parameters are included.
 
     Returns
     -------
     str
-        Telescope name (old convention).
-
-    Raises
-    ------
-    ValueError
-        if name is not valid.
+        Simtel parameter name.
     """
-    tel_class, tel_type = split_telescope_model_name(name)
-    new_name = tel_class + "-" + tel_type
-    old_names = {
-        "SST-D": "SST",
-        "SST-1M": "SST-1M",
-        "SST-ASTRI": "SST-2M-ASTRI",
-        "SST-GCT": "SST-2M-GCT-S",
-        "MST-FlashCam-D": "MST-FlashCam",
-        "MST-NectarCam-D": "MST-NectarCam",
-        "SCT-D": "SCT",
-        "LST-D234": "LST",
-        "LST-1": "LST",
-    }
+    _parameter_names = {}
+    if search_telescope_parameters:
+        _parameter_names.update(telescope_parameters())
+    if search_site_parameters:
+        _parameter_names.update(site_parameters())
 
-    if new_name not in old_names:
-        raise ValueError(f"Telescope name {name} could not be converted to yml names")
+    try:
+        _parameter = _parameter_names[par_name]
+    except KeyError as err:
+        _logger.error(f"Parameter {par_name} without schema definition")
+        raise err
 
-    return old_names[new_name]
+    try:
+        for software in _parameter.get("simulation_software", []):
+            if software.get("name") == simulation_software:
+                return software.get("internal_parameter_name", par_name)
+    except TypeError:  # catches cases for which 'simulation_software' is None
+        pass
+    return None
 
 
-def simtools_instrument_name(site, telescope_class_name, sub_system_name, telescope_id_name):
+def get_parameter_name_from_simtel_name(simtel_name):
     """
-    Instrument name following simtools naming convention
+    Get the model parameter name from the simtel parameter name.
+
+    Assumes that both names are equal if not defined otherwise in names.py.
 
     Parameters
     ----------
-    site: str
-        South or North.
-    telescope_class_name: str
-        LST, MST, ...
-    sub_system_name: str
-        FlashCam, NectarCam
-    telescope_id_name: str
-        telescope ID (e.g., D, numerical value)
+    simtel_name: str
+        Simtel parameter name.
 
     Returns
     -------
-    instrument: name: str
-        Instrument name.
+    str
+        Model parameter name.
     """
+    _parameters = {**telescope_parameters(), **site_parameters()}
 
-    return (
-        validate_site_name(site)
-        + "-"
-        + validate_name(telescope_class_name, all_telescope_class_names)
-        + "-"
-        + validate_sub_system_name(sub_system_name)
-        + "-"
-        + validate_telescope_id_name(telescope_id_name)
-    )
+    for par_name, par_info in _parameters.items():
+        try:
+            for software in par_info["simulation_software"]:
+                if (
+                    software["name"] == "sim_telarray"
+                    and software["internal_parameter_name"] == simtel_name
+                ):
+                    return par_name
+        except (KeyError, TypeError):  # catches cases for which 'simulation_software' is None
+            pass
+    return simtel_name
 
 
-def simtel_telescope_config_file_name(
-    site, telescope_model_name, model_version, label, extra_label
+def simtel_config_file_name(
+    site,
+    model_version,
+    array_name=None,
+    telescope_model_name=None,
+    label=None,
+    extra_label=None,
 ):
     """
     sim_telarray config file name for a telescope.
@@ -490,39 +428,17 @@ def simtel_telescope_config_file_name(
     str
         File name.
     """
-    name = f"CTA-{site}-{telescope_model_name}-{model_version}"
+    name = "CTA"
+    name += f"-{array_name}" if array_name is not None else ""
+    name += f"-{site}"
+    name += f"-{telescope_model_name}" if telescope_model_name is not None else ""
+    name += f"-{model_version}"
     name += f"_{label}" if label is not None else ""
     name += f"_{extra_label}" if extra_label is not None else ""
     name += ".cfg"
     return name
 
 
-def simtel_array_config_file_name(array_name, site, version, label):
-    """
-    sim_telarray config file name for an array.
-
-    Parameters
-    ----------
-    array_name: str
-        Prod5, ...
-    site: str
-        South or North.
-    version: str
-        Version of the model.
-    label: str
-        Instance label.
-
-    Returns
-    -------
-    str
-        File name.
-    """
-    name = f"CTA-{array_name}-{site}-{version}"
-    name += f"_{label}" if label is not None else ""
-    name += ".cfg"
-    return name
-
-
 def simtel_single_mirror_list_file_name(
     site, telescope_model_name, model_version, mirror_number, label
 ):
@@ -576,283 +492,66 @@ def layout_telescope_list_file_name(name, label):
     return file_name
 
 
-def ray_tracing_file_name(
+def generate_file_name(
+    file_type,
+    suffix,
     site,
     telescope_model_name,
-    source_distance,
     zenith_angle,
-    off_axis_angle,
-    mirror_number,
-    label,
-    base,
+    azimuth_angle=None,
+    off_axis_angle=None,
+    source_distance=None,
+    mirror_number=None,
+    label=None,
+    extra_label=None,
 ):
     """
-    File name for files required at the RayTracing class.
+    Generate a file name for output, config, or plotting.
+
+    Used e.g., to generate camera-efficiency and ray-tracing output files.
 
     Parameters
     ----------
+    file_type: str
+        Type of file (e.g., config, output, plot)
+    suffix: str
+        File suffix
     site: str
         South or North.
     telescope_model_name: str
-        LST-1, MST-FlashCam, ...
-    source_distance: float
-        Source distance (km).
+        LSTN-01, MSTS-01, ...
     zenith_angle: float
         Zenith angle (deg).
+    azimuth_angle: float
+        Azimuth angle (deg).
     off_axis_angle: float
         Off-axis angle (deg).
-    mirror_number: int
-        Mirror number. None if not single mirror case.
-    label: str
-        Instance label.
-    base: str
-        Photons, stars or log.
-
-    Returns
-    -------
-    str
-        File name.
-    """
-    name = (
-        f"{base}-{site}-{telescope_model_name}-d{source_distance:.1f}"
-        f"-za{zenith_angle:.1f}-off{off_axis_angle:.3f}"
-    )
-    name += f"_mirror{mirror_number}" if mirror_number is not None else ""
-    name += f"_{label}" if label is not None else ""
-    name += ".log" if base == "log" else ".lis"
-    return name
-
-
-def ray_tracing_results_file_name(site, telescope_model_name, source_distance, zenith_angle, label):
-    """
-    Ray tracing results file name.
-
-    Parameters
-    ----------
-    site: str
-        South or North.
-    telescope_model_name: str
-        LST-1, MST-FlashCam, ...
     source_distance: float
         Source distance (km).
-    zenith_angle: float
-        Zenith angle (deg).
-    label: str
-        Instance label.
-
-    Returns
-    -------
-    str
-        File name.
-    """
-    name = f"ray-tracing-{site}-{telescope_model_name}-d{source_distance:.1f}-za{zenith_angle:.1f}"
-    name += f"_{label}" if label is not None else ""
-    name += ".ecsv"
-    return name
-
-
-def ray_tracing_plot_file_name(
-    key, site, telescope_model_name, source_distance, zenith_angle, label
-):
-    """
-    Ray tracing plot file name.
-
-    Parameters
-    ----------
-    key: str
-        Quantity to be plotted (d80_cm, d80_deg, eff_area or eff_flen)
-    site: str
-        South or North.
-    telescope_model_name: str
-        LST-1, MST-FlashCam, ...
-    source_distance: float
-        Source distance (km).
-    zenith_angle: float
-        Zenith angle (deg).
+    mirror_number: int
+        Mirror number.
     label: str
         Instance label.
+    extra_label: str
+        Extra label.
 
     Returns
     -------
     str
         File name.
     """
-    name = (
-        f"ray-tracing-{site}-{telescope_model_name}-{key}-"
-        f"d{source_distance:.1f}-za{zenith_angle:.1f}"
-    )
+    name = f"{file_type}-{site}-{telescope_model_name}"
+    name += f"-d{source_distance:.1f}km" if source_distance is not None else ""
+    name += f"-za{float(zenith_angle):.1f}deg"
+    name += f"-off{off_axis_angle:.3f}deg" if off_axis_angle is not None else ""
+    name += f"_azm{round(azimuth_angle):03}deg" if azimuth_angle is not None else ""
+    name += f"_mirror{mirror_number}" if mirror_number is not None else ""
     name += f"_{label}" if label is not None else ""
-    name += ".pdf"
-    return name
-
-
-def camera_efficiency_results_file_name(
-    site, telescope_model_name, zenith_angle, azimuth_angle, label
-):
-    """
-    Camera efficiency results file name.
-
-    Parameters
-    ----------
-    site: str
-        South or North.
-    telescope_model_name: str
-        LST-1, MST-FlashCam, ...
-    zenith_angle: float
-        Zenith angle (deg).
-    azimuth_angle: float
-        Azimuth angle (deg).
-    label: str
-        Instance label.
-
-    Returns
-    -------
-    str
-        File name.
-    """
-    _label = f"_{label}" if label is not None else ""
-    name = (
-        f"camera-efficiency-table-{site}-{telescope_model_name}-"
-        f"za{round(zenith_angle):03}deg_azm{round(azimuth_angle):03}deg"
-        f"{_label}.ecsv"
-    )
-    return name
-
-
-def camera_efficiency_simtel_file_name(
-    site, telescope_model_name, zenith_angle, azimuth_angle, label
-):
-    """
-    Camera efficiency simtel output file name.
-
-    Parameters
-    ----------
-    site: str
-        South or North.
-    telescope_model_name: str
-        LST-1, MST-FlashCam-D, ...
-    zenith_angle: float
-        Zenith angle (deg).
-    azimuth_angle: float
-        Azimuth angle (deg).
-    label: str
-        Instance label.
-
-    Returns
-    -------
-    str
-        File name.
-    """
-    _label = f"_{label}" if label is not None else ""
-    name = (
-        f"camera-efficiency-{site}-{telescope_model_name}-"
-        f"za{round(zenith_angle):03}deg_azm{round(azimuth_angle):03}deg"
-        f"{_label}.dat"
-    )
-    return name
-
-
-def camera_efficiency_log_file_name(site, telescope_model_name, zenith_angle, azimuth_angle, label):
-    """
-    Camera efficiency log file name.
-
-    Parameters
-    ----------
-    site: str
-        South or North.
-    telescope_model_name: str
-        LST-1, MST-FlashCam-D, ...
-    zenith_angle: float
-        Zenith angle (deg).
-    azimuth_angle: float
-        Azimuth angle (deg).
-    label: str
-        Instance label.
-
-    Returns
-    -------
-    str
-        File name.
-    """
-    _label = f"_{label}" if label is not None else ""
-    name = (
-        f"camera-efficiency-{site}-{telescope_model_name}"
-        f"-za{round(zenith_angle):03}deg_azm{round(azimuth_angle):03}deg"
-        f"{_label}.log"
-    )
+    name += f"_{extra_label}" if extra_label is not None else ""
+    name += f"{suffix}"
     return name
 
 
-def get_telescope_type(telescope_name):
-    """
-    Guess telescope type from name, e.g. "LST", "MST", ...
-
-    Parameters
-    ----------
-    telescope_name: str
-        Telescope name
-
-    Returns
-    -------
-    str
-        Telescope type.
-    """
-
-    _tel_class, _ = split_telescope_model_name(telescope_name)
-    try:
-        for _class in all_telescope_class_names:
-            if len(_class) == 3 and _tel_class[0:3] == _class:
-                return _class
-            if _tel_class == _class:
-                return _class
-    except IndexError:
-        pass
-
-    return ""
-
-
-def translate_corsika_to_simtools(corsika_par):
-    """
-    Translate the name of a CORSIKA parameter to the name used in simtools.
-
-    Parameters
-    ----------
-    corsika_par: str
-        Name of the corsika parameter to be translated.
-
-    """
-
-    try:
-        return corsika_to_simtools_names[corsika_par]
-    except KeyError:
-        msg = f"Translation not found. We will proceed with the original parameter name:\
-            {corsika_par}."
-        _logger.debug(msg)
-        return corsika_par
-
-
-def translate_simtools_to_corsika(simtools_par):
-    """
-    Translate the name of a simtools parameter to the name used in CORSIKA.
-
-    Parameters
-    ----------
-    simtools_par: str
-        Name of the simtools parameter to be translated.
-    """
-
-    simtools_to_corsika_names = {
-        new_key: new_value for new_value, new_key in corsika_to_simtools_names.items()
-    }
-    try:
-        return simtools_to_corsika_names[simtools_par]
-    except KeyError:
-        msg = f"Translation not found. We will proceed with the original parameter name:\
-            {simtools_par}."
-        _logger.debug(msg)
-        return simtools_par
-
-
 def sanitize_name(name):
     """
     Sanitize name to be a valid Python identifier.
@@ -875,9 +574,8 @@ def sanitize_name(name):
     Raises
     ------
     ValueError:
-        if the string `name` can not be sanitized.
+        if the string name can not be sanitized.
     """
-
     # Convert to lowercase
     sanitized = name.lower()
 
@@ -889,5 +587,5 @@ def sanitize_name(name):
     if not sanitized.isidentifier():
         msg = f"The string {name} could not be sanitized."
         _logger.error(msg)
-        raise ValueError
+        raise ValueError(msg)
     return sanitized