forgecommandline 0.8.0__py3-none-any.whl

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (113) hide show
  1. forgecli/__init__.py +2 -0
  2. forgecli/ads.py +322 -0
  3. forgecli/agent.py +1093 -0
  4. forgecli/art.py +574 -0
  5. forgecli/attach.py +246 -0
  6. forgecli/brief.py +215 -0
  7. forgecli/browsercheck.py +99 -0
  8. forgecli/checkpoints.py +81 -0
  9. forgecli/city.py +833 -0
  10. forgecli/cli.py +1668 -0
  11. forgecli/config.py +194 -0
  12. forgecli/courier.py +177 -0
  13. forgecli/courier_data.py +164 -0
  14. forgecli/courier_hd.py +431 -0
  15. forgecli/courier_hd_data.bin +0 -0
  16. forgecli/courier_hd_data.py +19 -0
  17. forgecli/ghlogin.py +76 -0
  18. forgecli/github.py +54 -0
  19. forgecli/guards.py +403 -0
  20. forgecli/hooks.py +50 -0
  21. forgecli/httpapi.py +434 -0
  22. forgecli/images.py +110 -0
  23. forgecli/keys.py +152 -0
  24. forgecli/keyvault.py +320 -0
  25. forgecli/mcp.py +674 -0
  26. forgecli/memory.py +42 -0
  27. forgecli/openapi.py +331 -0
  28. forgecli/parallel.py +308 -0
  29. forgecli/prices.py +72 -0
  30. forgecli/procs.py +144 -0
  31. forgecli/providers.py +758 -0
  32. forgecli/quality.py +192 -0
  33. forgecli/repomap.py +78 -0
  34. forgecli/roster.py +227 -0
  35. forgecli/safety.py +93 -0
  36. forgecli/sandbox.py +83 -0
  37. forgecli/sessions.py +97 -0
  38. forgecli/skills.py +446 -0
  39. forgecli/tools.py +1184 -0
  40. forgecli/ui.py +860 -0
  41. forgecli/worktrees.py +79 -0
  42. forgecommandline-0.8.0.data/data/skills/commit/SKILL.md +14 -0
  43. forgecommandline-0.8.0.data/data/skills/debug/SKILL.md +17 -0
  44. forgecommandline-0.8.0.data/data/skills/explain/SKILL.md +14 -0
  45. forgecommandline-0.8.0.data/data/skills/init/SKILL.md +19 -0
  46. forgecommandline-0.8.0.data/data/skills/library/LICENSES/agent-skills-MIT.txt +21 -0
  47. forgecommandline-0.8.0.data/data/skills/library/LICENSES/wondelai-MIT.txt +23 -0
  48. forgecommandline-0.8.0.data/data/skills/library/README.md +9 -0
  49. forgecommandline-0.8.0.data/data/skills/library/_references/accessibility-checklist.md +160 -0
  50. forgecommandline-0.8.0.data/data/skills/library/_references/definition-of-done.md +67 -0
  51. forgecommandline-0.8.0.data/data/skills/library/_references/observability-checklist.md +92 -0
  52. forgecommandline-0.8.0.data/data/skills/library/_references/orchestration-patterns.md +370 -0
  53. forgecommandline-0.8.0.data/data/skills/library/_references/performance-checklist.md +238 -0
  54. forgecommandline-0.8.0.data/data/skills/library/_references/security-checklist.md +248 -0
  55. forgecommandline-0.8.0.data/data/skills/library/_references/testing-patterns.md +235 -0
  56. forgecommandline-0.8.0.data/data/skills/library/api-and-interface-design/SKILL.md +367 -0
  57. forgecommandline-0.8.0.data/data/skills/library/architecture-optimization/SKILL.md +279 -0
  58. forgecommandline-0.8.0.data/data/skills/library/architecture-optimization/references/artifact-templates.md +157 -0
  59. forgecommandline-0.8.0.data/data/skills/library/architecture-optimization/references/methods.md +87 -0
  60. forgecommandline-0.8.0.data/data/skills/library/awwwards-tier-web-application/SKILL.md +877 -0
  61. forgecommandline-0.8.0.data/data/skills/library/browser-testing-with-devtools/SKILL.md +317 -0
  62. forgecommandline-0.8.0.data/data/skills/library/ci-cd-and-automation/SKILL.md +390 -0
  63. forgecommandline-0.8.0.data/data/skills/library/code-review-and-quality/SKILL.md +398 -0
  64. forgecommandline-0.8.0.data/data/skills/library/code-simplification/SKILL.md +331 -0
  65. forgecommandline-0.8.0.data/data/skills/library/constraint-driven-development/SKILL.md +311 -0
  66. forgecommandline-0.8.0.data/data/skills/library/constraint-driven-development/references/floor-guard.md +182 -0
  67. forgecommandline-0.8.0.data/data/skills/library/context-engineering/SKILL.md +353 -0
  68. forgecommandline-0.8.0.data/data/skills/library/debugging-and-error-recovery/SKILL.md +300 -0
  69. forgecommandline-0.8.0.data/data/skills/library/deprecation-and-migration/SKILL.md +247 -0
  70. forgecommandline-0.8.0.data/data/skills/library/documentation-and-adrs/SKILL.md +297 -0
  71. forgecommandline-0.8.0.data/data/skills/library/doubt-driven-development/SKILL.md +243 -0
  72. forgecommandline-0.8.0.data/data/skills/library/frontend-ui-engineering/SKILL.md +340 -0
  73. forgecommandline-0.8.0.data/data/skills/library/git-workflow-and-versioning/SKILL.md +355 -0
  74. forgecommandline-0.8.0.data/data/skills/library/idea-refine/SKILL.md +193 -0
  75. forgecommandline-0.8.0.data/data/skills/library/idea-refine/examples.md +238 -0
  76. forgecommandline-0.8.0.data/data/skills/library/idea-refine/frameworks.md +99 -0
  77. forgecommandline-0.8.0.data/data/skills/library/idea-refine/refinement-criteria.md +113 -0
  78. forgecommandline-0.8.0.data/data/skills/library/idea-refine/scripts/idea-refine.sh +15 -0
  79. forgecommandline-0.8.0.data/data/skills/library/improve-code-quality/SKILL.md +275 -0
  80. forgecommandline-0.8.0.data/data/skills/library/improve-code-quality/references/artifact-templates.md +101 -0
  81. forgecommandline-0.8.0.data/data/skills/library/incremental-implementation/SKILL.md +249 -0
  82. forgecommandline-0.8.0.data/data/skills/library/interview-me/SKILL.md +235 -0
  83. forgecommandline-0.8.0.data/data/skills/library/observability-and-instrumentation/SKILL.md +238 -0
  84. forgecommandline-0.8.0.data/data/skills/library/performance-optimization/SKILL.md +267 -0
  85. forgecommandline-0.8.0.data/data/skills/library/performance-optimization/references/optimization-patterns.md +250 -0
  86. forgecommandline-0.8.0.data/data/skills/library/planning-and-task-breakdown/SKILL.md +257 -0
  87. forgecommandline-0.8.0.data/data/skills/library/remove-technical-debt/SKILL.md +203 -0
  88. forgecommandline-0.8.0.data/data/skills/library/remove-technical-debt/references/artifact-templates.md +79 -0
  89. forgecommandline-0.8.0.data/data/skills/library/security-and-hardening/SKILL.md +216 -0
  90. forgecommandline-0.8.0.data/data/skills/library/security-and-hardening/references/hardening-patterns.md +324 -0
  91. forgecommandline-0.8.0.data/data/skills/library/shipping-and-launch/SKILL.md +336 -0
  92. forgecommandline-0.8.0.data/data/skills/library/source-driven-development/SKILL.md +216 -0
  93. forgecommandline-0.8.0.data/data/skills/library/spec-driven-development/SKILL.md +259 -0
  94. forgecommandline-0.8.0.data/data/skills/library/system-design/SKILL.md +207 -0
  95. forgecommandline-0.8.0.data/data/skills/library/system-design/references/building-blocks.md +272 -0
  96. forgecommandline-0.8.0.data/data/skills/library/system-design/references/common-designs.md +257 -0
  97. forgecommandline-0.8.0.data/data/skills/library/system-design/references/database-scaling.md +295 -0
  98. forgecommandline-0.8.0.data/data/skills/library/system-design/references/estimation-numbers.md +250 -0
  99. forgecommandline-0.8.0.data/data/skills/library/system-design/references/four-step-process.md +286 -0
  100. forgecommandline-0.8.0.data/data/skills/library/system-design/references/reliability-operations.md +373 -0
  101. forgecommandline-0.8.0.data/data/skills/library/test-driven-development/SKILL.md +398 -0
  102. forgecommandline-0.8.0.data/data/skills/library/using-agent-skills/SKILL.md +192 -0
  103. forgecommandline-0.8.0.data/data/skills/review/SKILL.md +16 -0
  104. forgecommandline-0.8.0.data/data/skills/run/SKILL.md +17 -0
  105. forgecommandline-0.8.0.data/data/skills/security-review/SKILL.md +20 -0
  106. forgecommandline-0.8.0.data/data/skills/simplify/SKILL.md +18 -0
  107. forgecommandline-0.8.0.data/data/skills/test/SKILL.md +16 -0
  108. forgecommandline-0.8.0.data/data/skills/web-build/SKILL.md +25 -0
  109. forgecommandline-0.8.0.dist-info/METADATA +357 -0
  110. forgecommandline-0.8.0.dist-info/RECORD +113 -0
  111. forgecommandline-0.8.0.dist-info/WHEEL +5 -0
  112. forgecommandline-0.8.0.dist-info/entry_points.txt +2 -0
  113. forgecommandline-0.8.0.dist-info/top_level.txt +1 -0
@@ -0,0 +1,267 @@
1
+ ---
2
+ name: performance-optimization
3
+ description: Optimizes application performance across frontend, backend, queries, and databases. Use when performance requirements exist, when you suspect performance regressions, when Core Web Vitals or load times need improvement, when N+1 query patterns need fixing, or when profiling reveals bottlenecks.
4
+ ---
5
+
6
+ # Performance Optimization
7
+
8
+ ## Overview
9
+
10
+ Measure before optimizing. Performance work without measurement is guessing — and guessing leads to premature optimization that adds complexity without improving what matters. Profile first, identify the actual bottleneck, fix it, measure again. Optimize only what measurements prove matters.
11
+
12
+ ## When to Use
13
+
14
+ - Performance requirements exist in the spec (load time budgets, response time SLAs)
15
+ - Users or monitoring report slow behavior
16
+ - Core Web Vitals scores are below thresholds
17
+ - You suspect a change introduced a regression
18
+ - Building features that handle large datasets or high traffic
19
+
20
+ **When NOT to use:** Don't optimize before you have evidence of a problem. Premature optimization adds complexity that costs more than the performance it gains.
21
+
22
+ ## Core Web Vitals Targets
23
+
24
+ | Metric | Good | Needs Improvement | Poor |
25
+ |--------|------|-------------------|------|
26
+ | **LCP** (Largest Contentful Paint) | ≤ 2.5s | ≤ 4.0s | > 4.0s |
27
+ | **INP** (Interaction to Next Paint) | ≤ 200ms | ≤ 500ms | > 500ms |
28
+ | **CLS** (Cumulative Layout Shift) | ≤ 0.1 | ≤ 0.25 | > 0.25 |
29
+
30
+ ## The Optimization Workflow
31
+
32
+ ```
33
+ 1. MEASURE → Establish baseline with real data
34
+ 2. IDENTIFY → Find the actual bottleneck (not assumed)
35
+ 3. FIX → Address the specific bottleneck
36
+ 4. VERIFY → Measure again; keep or revert
37
+ 5. GUARD → Add monitoring or tests to prevent regression
38
+ ```
39
+
40
+ ### Step 1: Measure
41
+
42
+ Two complementary approaches — use both:
43
+
44
+ - **Synthetic (Lighthouse, DevTools Performance tab):** Controlled conditions, reproducible. Best for CI regression detection and isolating specific issues.
45
+ - **RUM (web-vitals library, CrUX):** Real user data in real conditions. Required to validate that a fix actually improved user experience.
46
+
47
+ **Frontend:**
48
+ ```javascript
49
+ // Synthetic: Lighthouse in Chrome DevTools (or CI)
50
+ // Chrome DevTools → Performance tab → Record
51
+ // Chrome DevTools MCP → Performance trace
52
+
53
+ // RUM: Web Vitals library in code
54
+ import { onLCP, onINP, onCLS } from 'web-vitals';
55
+
56
+ onLCP(console.log);
57
+ onINP(console.log);
58
+ onCLS(console.log);
59
+ ```
60
+
61
+ **Backend:**
62
+ ```javascript
63
+ // Response time logging
64
+ // Application Performance Monitoring (APM)
65
+ // Database query logging with timing
66
+
67
+ // Simple timing
68
+ console.time('db-query');
69
+ const result = await db.query(...);
70
+ console.timeEnd('db-query');
71
+ ```
72
+
73
+ ### Where to Start Measuring
74
+
75
+ Use the symptom to decide what to measure first:
76
+
77
+ ```
78
+ What is slow?
79
+ ├── First page load
80
+ │ ├── Large bundle? --> Measure bundle size, check code splitting
81
+ │ ├── Slow server response? --> Measure TTFB in DevTools Network waterfall
82
+ │ │ ├── DNS long? --> Add dns-prefetch / preconnect for known origins
83
+ │ │ ├── TCP/TLS long? --> Enable HTTP/2, check edge deployment, keep-alive
84
+ │ │ └── Waiting (server) long? --> Profile backend, check queries and caching
85
+ │ └── Render-blocking resources? --> Check network waterfall for CSS/JS blocking
86
+ ├── Interaction feels sluggish
87
+ │ ├── UI freezes on click? --> Profile main thread, look for long tasks (>50ms)
88
+ │ ├── Form input lag? --> Check re-renders, controlled component overhead
89
+ │ └── Animation jank? --> Check layout thrashing, forced reflows
90
+ ├── Page after navigation
91
+ │ ├── Data loading? --> Measure API response times, check for waterfalls
92
+ │ └── Client rendering? --> Profile component render time, check for N+1 fetches
93
+ └── Backend / API
94
+ ├── Single endpoint slow? --> Profile database queries, check indexes
95
+ ├── All endpoints slow? --> Check connection pool, memory, CPU
96
+ └── Intermittent slowness? --> Check for lock contention, GC pauses, external deps
97
+ ```
98
+
99
+ ### Step 2: Identify the Bottleneck
100
+
101
+ Common bottlenecks by category:
102
+
103
+ **Frontend:**
104
+
105
+ | Symptom | Likely Cause | Investigation |
106
+ |---------|-------------|---------------|
107
+ | Slow LCP | Large images, render-blocking resources, slow server | Check network waterfall, image sizes |
108
+ | High CLS | Images without dimensions, late-loading content, font shifts | Check layout shift attribution |
109
+ | Poor INP | Heavy JavaScript on main thread, large DOM updates | Check long tasks in Performance trace |
110
+ | Slow initial load | Large bundle, many network requests | Check bundle size, code splitting |
111
+
112
+ **Backend:**
113
+
114
+ | Symptom | Likely Cause | Investigation |
115
+ |---------|-------------|---------------|
116
+ | Slow API responses | N+1 queries, missing indexes, unoptimized queries | Check database query log |
117
+ | Memory growth | Leaked references, unbounded caches, large payloads | Heap snapshot analysis |
118
+ | CPU spikes | Synchronous heavy computation, regex backtracking | CPU profiling |
119
+ | High latency | Missing caching, redundant computation, network hops | Trace requests through the stack |
120
+
121
+ ### Step 3: Fix the Bottleneck
122
+
123
+ Fix the one thing Step 2 identified, nothing else. The anti-patterns below are the usual suspects; each entry gives the rule and the signature to recognize it, and links to a worked fix in [references/optimization-patterns.md](references/optimization-patterns.md). Open the one you need when you reach that code, not before.
124
+
125
+ **Backend**
126
+
127
+ - **N+1 queries.** One query per row is the most common backend bottleneck. Fetch the relation in the same query (join/include) instead of in the loop. [Pattern](references/optimization-patterns.md#n1-queries-backend).
128
+ - **Unbounded data fetching.** Every list endpoint paginates with a limit and a stable order. [Pattern](references/optimization-patterns.md#unbounded-data-fetching).
129
+ - **Queries that ignore their index.** "Add an index" is the guess; `EXPLAIN ANALYZE` is the measurement. A `Seq Scan` where you expected an index, a `rows=` estimate off by an order of magnitude, and a `Sort` node above the scan each call for a different fix; a bad `rows=` estimate means stale statistics, so run `ANALYZE` rather than adding an index. Index for the shape of the query (equality columns first, then the range or sort column). A plain index will not help a query on a low-selectivity dominant value (a partial index serves the rare value), a leading wildcard (needs trigram or full-text), or a function applied to the column (index the expression, as in `WHERE lower(email) = ?`), and every index taxes every write. Re-run the plan afterwards; an index that did not change it is a revert. [Pattern](references/optimization-patterns.md#queries-that-ignore-their-index).
130
+ - **Connection pool exhaustion.** Signature: *every* endpoint slows at once, time is spent waiting for a connection rather than executing, and the database shows mostly idle sessions. One pool per process, sized so `instances × max` stays under the database's connection ceiling. Bigger is not faster; it relocates the queue to the database where it is harder to see. With unbounded instance counts (serverless, autoscaling), multiplex through a proxy (pgbouncer, RDS Proxy) instead of raising `max`. [Pattern](references/optimization-patterns.md#connection-pool-exhaustion).
131
+ - **Missing caching.** Cache what is expensive to produce and read far more often than it changes; caching an already-fast query adds a network hop and a staleness bug in exchange for nothing. Pick the layer deliberately (in-process, shared, CDN). Every input that changes the response belongs in the key (tenant, locale, permissions, feature flags): a key that omits the viewer is how one user's data gets served to another. Choose one invalidation strategy (TTL, event or tag based, versioned keys) and state the acceptable staleness window explicitly. Guard hot keys against the stampede: serve stale while one request recomputes, or coalesce concurrent misses behind a single in-flight promise. Never cache what must be fresh (balances, permissions, inventory at checkout). [Pattern](references/optimization-patterns.md#missing-caching-backend); request coalescing, write strategies, and negative caching in `${CLAUDE_SKILL_DIR}/../_references/performance-checklist.md`.
132
+
133
+ **Frontend**
134
+
135
+ - **Missing image optimization.** Every image declares `width` and `height` (CLS). The LCP image gets `fetchpriority="high"`, modern formats (AVIF, WebP) through `<picture>`, and `srcset`/`sizes` for resolution switching; below-the-fold images get `loading="lazy"` and `decoding="async"`. [Pattern](references/optimization-patterns.md#missing-image-optimization-frontend).
136
+ - **Unnecessary re-renders.** An object or function created in render is a new reference every time and re-renders every child that receives it. Hoist constants; reserve `React.memo` and `useMemo` for work the profile shows is expensive, since overuse is its own cost. [Pattern](references/optimization-patterns.md#unnecessary-re-renders-react).
137
+ - **Large bundle size.** Modern bundlers tree-shake ESM named imports on their own; the real gains are route-level code splitting and lazy-loading heavy, rarely-used features behind `Suspense`. Profile before changing import styles. [Pattern](references/optimization-patterns.md#large-bundle-size).
138
+
139
+ ### Step 4: Verify (Keep or Revert)
140
+
141
+ A fix is a hypothesis until you re-measure. This step decides whether it survives.
142
+
143
+ **Re-measure the way you measured the baseline:** same command, same conditions, same fixed budget (wall-clock, sample count, or request count). A baseline taken on a cold cache against a result taken on a warm one measures the cache, not your change.
144
+
145
+ **Change one thing at a time.** Three optimizations landed together produce one number, and you cannot attribute it. If they must ship together, measure each in isolation first.
146
+
147
+ **Beat the noise, not just the mean.** Repeat the measurement and compare the delta against run-to-run variance. A 3% gain inside ±5% variance is not a gain; it is a different sample.
148
+
149
+ Then decide, strictly:
150
+
151
+ | Result vs. baseline | Action |
152
+ |---|---|
153
+ | Past the threshold, tests green | **Keep.** Commit with the before/after numbers in the message. |
154
+ | Within noise (no measurable change) | **Revert.** |
155
+ | Worse | **Revert.** |
156
+ | Improved, but a test went red | **Revert.** A regression wearing a win's clothing. |
157
+
158
+ **"Neutral" is a revert, not a keep.** This is the step teams skip: the change is already written, throwing it away feels wasteful, so it lands unmeasured, and the codebase accretes complexity that never bought anything. Code you keep, you maintain forever. Make it pay for itself.
159
+
160
+ **Correctness gates the metric.** The suite stays green *and* the number moves. An "optimization" that wins by dropping work the product needed (skipping a validation, caching something that must be fresh, removing an `await` that was load-bearing) is a regression, not a win.
161
+
162
+ #### Log every attempt, including the reverted ones
163
+
164
+ Reverted work leaves no trace in git history, which is exactly why the same dead idea gets tried again next quarter. Keep a short ledger so a discarded idea stays discarded:
165
+
166
+ | Idea | Baseline → Result | Verdict | Why |
167
+ |---|---|---|---|
168
+ | Memoize the row component | INP 240ms → 235ms | reverted | Inside noise (±15ms). Rows weren't the bottleneck. |
169
+ | Virtualize the list | INP 240ms → 90ms | kept | Long tasks gone from the trace. |
170
+ | Preconnect to the API origin | LCP 2.8s → 2.8s | reverted | Already same-origin. |
171
+
172
+ A section in the PR description or a `PERF.md` in the repo both work. What matters is that the next person (or the next agent) reads it before proposing an experiment, and doesn't re-run one that already failed.
173
+
174
+ ### Step 5: Guard Against Regression
175
+
176
+ Guard the metric the user actually feels, not every available number. Use the
177
+ same LCP, INP, p95 latency, or other primary metric that justified the fix.
178
+
179
+ Use two complementary layers when the surface is user-facing:
180
+
181
+ - **Synthetic CI gate:** Catch reproducible regressions before merge with a
182
+ performance budget. Repeat noisy measurements or compare a median/trend so
183
+ normal run-to-run variance does not turn the gate into a flaky check.
184
+ - **Field monitoring:** Alert on a meaningful p75 movement in RUM data. Use
185
+ attributed `web-vitals` data to locate the cause; treat CrUX's rolling window
186
+ as confirmation rather than an immediate alert.
187
+
188
+ When either guard fires, return to Step 1 and establish a fresh baseline before
189
+ proposing another fix.
190
+
191
+ **Set budgets and enforce them:**
192
+
193
+ ```
194
+ JavaScript bundle: < 200KB gzipped (initial load)
195
+ CSS: < 50KB gzipped
196
+ Images: < 200KB per image (above the fold)
197
+ Fonts: < 100KB total
198
+ API response time: < 200ms (p95)
199
+ Time to Interactive: < 3.5s on 4G
200
+ Lighthouse Performance score: ≥ 90
201
+ ```
202
+
203
+ **Enforce in CI:**
204
+ ```bash
205
+ # Bundle size check
206
+ npx bundlesize --config bundlesize.config.json
207
+
208
+ # Lighthouse CI
209
+ npx lhci autorun
210
+ ```
211
+
212
+ ## See Also
213
+
214
+ For detailed performance checklists, optimization commands, and anti-pattern reference, see `${CLAUDE_SKILL_DIR}/../_references/performance-checklist.md`.
215
+
216
+
217
+ ## Common Rationalizations
218
+
219
+ | Rationalization | Reality |
220
+ |---|---|
221
+ | "We'll optimize later" | Performance debt compounds. Fix obvious anti-patterns now, defer micro-optimizations. |
222
+ | "It's fast on my machine" | Your machine isn't the user's. Profile on representative hardware and networks. |
223
+ | "This optimization is obvious" | If you didn't measure, you don't know. Profile first. |
224
+ | "Users won't notice 100ms" | Research shows 100ms delays impact conversion rates. Users notice more than you think. |
225
+ | "The framework handles performance" | Frameworks prevent some issues but can't fix N+1 queries or oversized bundles. |
226
+ | "The query is slow, add an index" | Read the plan first. The index may already exist and be unusable, and every index taxes writes forever. |
227
+ | "Just cache it" | Caching an already-cheap call buys nothing and adds a staleness bug. Cache what is expensive *and* re-read far more than written. |
228
+ | "Raise the pool size, we're running out of connections" | A pool bigger than the database can serve moves the queue somewhere less visible. Find what holds connections. |
229
+ | "It didn't help much, but it doesn't hurt" | Neutral changes are a revert. You pay maintenance on them forever and got nothing back. |
230
+ | "We already wrote it, may as well keep it" | Sunk cost. The measurement doesn't care how long the change took to write. |
231
+ | "The improvement is obvious, no need to re-measure" | Then re-measuring is cheap and proves it. Unmeasured wins are how neutral complexity lands. |
232
+
233
+ ## Red Flags
234
+
235
+ - Optimization without profiling data to justify it
236
+ - N+1 query patterns in data fetching
237
+ - An index added without a query plan before and after to justify it
238
+ - A cache key that omits an input the response depends on (tenant, locale, viewer)
239
+ - A cache with no stated staleness window and no invalidation strategy
240
+ - Connection pool size raised in response to exhaustion, without finding what holds connections
241
+ - List endpoints without pagination
242
+ - Images without dimensions, lazy loading, or responsive sizes
243
+ - Bundle size growing without review
244
+ - No performance monitoring in production
245
+ - `React.memo` and `useMemo` everywhere (overusing is as bad as underusing)
246
+ - Optimizations kept without a re-measurement that justifies them
247
+ - Several optimizations bundled into one measurement, so no single change can be attributed
248
+ - A "win" that required a test to be changed, skipped, or deleted
249
+ - The same failed optimization attempted more than once because nobody recorded the first attempt
250
+
251
+ ## Verification
252
+
253
+ After any performance-related change:
254
+
255
+ - [ ] Before and after measurements exist (specific numbers)
256
+ - [ ] The result was re-measured the same way as the baseline (same command, same conditions)
257
+ - [ ] The improvement exceeds run-to-run variance, not just the mean
258
+ - [ ] Changes that didn't beat the baseline were reverted, not kept as neutral
259
+ - [ ] Attempts are logged, kept and reverted alike, so a dead idea isn't re-run
260
+ - [ ] The specific bottleneck is identified and addressed
261
+ - [ ] Core Web Vitals are within "Good" thresholds
262
+ - [ ] Bundle size hasn't increased significantly
263
+ - [ ] No N+1 queries in new data fetching code
264
+ - [ ] Any new index is justified by a query plan before and after, and its write cost was considered
265
+ - [ ] Any new cache states what it keys on and how it goes stale
266
+ - [ ] The measured user-facing metric has a synthetic budget or field monitor that can detect regression
267
+ - [ ] Existing tests still pass (optimization didn't break behavior)
@@ -0,0 +1,250 @@
1
+ # Optimization Patterns
2
+
3
+ Worked fixes for the anti-patterns named in Step 3 of the `performance-optimization` skill. The skill states the rule and the signature to look for; this file shows one concrete implementation. Open the section you need after Step 2 has identified the bottleneck — it is not meant to be read top to bottom.
4
+
5
+ Checklists, measurement commands, TTFB diagnosis, and caching read/write strategies live in `../${CLAUDE_SKILL_DIR}/../_references/performance-checklist.md`.
6
+
7
+ ## N+1 Queries (Backend)
8
+
9
+ ```typescript
10
+ // BAD: N+1 — one query per task for the owner
11
+ const tasks = await db.tasks.findMany();
12
+ for (const task of tasks) {
13
+ task.owner = await db.users.findUnique({ where: { id: task.ownerId } });
14
+ }
15
+
16
+ // GOOD: Single query with join/include
17
+ const tasks = await db.tasks.findMany({
18
+ include: { owner: true },
19
+ });
20
+ ```
21
+
22
+ ## Unbounded Data Fetching
23
+
24
+ ```typescript
25
+ // BAD: Fetching all records
26
+ const allTasks = await db.tasks.findMany();
27
+
28
+ // GOOD: Paginated with limits
29
+ const tasks = await db.tasks.findMany({
30
+ take: 20,
31
+ skip: (page - 1) * 20,
32
+ orderBy: { createdAt: 'desc' },
33
+ });
34
+ ```
35
+
36
+ ## Queries That Ignore Their Index
37
+
38
+ "Add an index" is the guess. The query plan is the measurement:
39
+
40
+ ```sql
41
+ EXPLAIN ANALYZE
42
+ SELECT id, title FROM tasks
43
+ WHERE owner_id = 42 ORDER BY created_at DESC LIMIT 20;
44
+ ```
45
+
46
+ Three things in the output decide the fix:
47
+
48
+ | What you see | What it means |
49
+ |---|---|
50
+ | `Seq Scan` on a large table where you expected an index | No usable index for this predicate |
51
+ | Estimated `rows=` off from actual by an order of magnitude | Stale statistics; the planner is choosing on bad information |
52
+ | A `Sort` node above the scan | The index covers the filter but not the `ORDER BY` |
53
+
54
+ Index for the **shape of the query**, not the column in isolation. In a composite index, equality columns come first, then the range or sort column:
55
+
56
+ ```sql
57
+ CREATE INDEX idx_tasks_owner_created ON tasks (owner_id, created_at DESC);
58
+ ```
59
+
60
+ **When an index will not help:**
61
+
62
+ | Situation | Why |
63
+ |---|---|
64
+ | Low selectivity, querying the dominant value (a `status` column that is 95% `active`, filtered on `active`) | A sequential scan is genuinely cheaper; the planner will ignore the index. Filtering on the rare value is the opposite case, and a partial index serves it well |
65
+ | Leading wildcard (`LIKE '%term'`) | A B-tree cannot seek without a prefix; needs trigram or full-text |
66
+ | Function on the column (`WHERE lower(email) = ?`) | The plain column index is unusable; index the expression instead |
67
+ | Write-heavy table | Every index is a tax on every `INSERT`/`UPDATE`; measure the write cost, not just the read gain |
68
+
69
+ Re-run `EXPLAIN ANALYZE` after. An index that did not change the plan is a revert (Step 4), and it is not free: it still costs on every write.
70
+
71
+ ## Connection Pool Exhaustion
72
+
73
+ The signature is distinctive: **every** endpoint slows at once, the slow time is spent waiting for a connection rather than executing, and the database reports mostly idle sessions.
74
+
75
+ ```typescript
76
+ // BAD: a pool per request or per module — under serverless this multiplies
77
+ // by instance count and exhausts the database's connection limit
78
+ // GOOD: one pool per process, sized against the database's ceiling
79
+ const pool = new Pool({
80
+ max: 10, // instances × max must stay under max_connections
81
+ idleTimeoutMillis: 30_000,
82
+ connectionTimeoutMillis: 5_000, // fail fast instead of queueing forever
83
+ });
84
+ ```
85
+
86
+ **Bigger is not faster.** A pool larger than what the database can execute concurrently just relocates the queue from your app to the database, where it is harder to see. When instance count is unbounded (serverless, autoscaling), a proxy that multiplexes connections (pgbouncer, RDS Proxy) is the fix, not a higher `max`.
87
+
88
+ ## Missing Image Optimization (Frontend)
89
+
90
+ ```html
91
+ <!-- BAD: No dimensions, no format optimization -->
92
+ <img src="/hero.jpg" />
93
+
94
+ <!-- GOOD: Hero / LCP image — art direction + resolution switching, high priority -->
95
+ <!--
96
+ Two techniques combined:
97
+ - Art direction (media): different crop/composition per breakpoint
98
+ - Resolution switching (srcset + sizes): right file size per screen density
99
+ -->
100
+ <picture>
101
+ <!-- Mobile: portrait crop (8:10) -->
102
+ <source
103
+ media="(max-width: 767px)"
104
+ srcset="/hero-mobile-400.avif 400w, /hero-mobile-800.avif 800w"
105
+ sizes="100vw"
106
+ width="800"
107
+ height="1000"
108
+ type="image/avif"
109
+ />
110
+ <source
111
+ media="(max-width: 767px)"
112
+ srcset="/hero-mobile-400.webp 400w, /hero-mobile-800.webp 800w"
113
+ sizes="100vw"
114
+ width="800"
115
+ height="1000"
116
+ type="image/webp"
117
+ />
118
+ <!-- Desktop: landscape crop (2:1) -->
119
+ <source
120
+ srcset="/hero-800.avif 800w, /hero-1200.avif 1200w, /hero-1600.avif 1600w"
121
+ sizes="(max-width: 1200px) 100vw, 1200px"
122
+ width="1200"
123
+ height="600"
124
+ type="image/avif"
125
+ />
126
+ <source
127
+ srcset="/hero-800.webp 800w, /hero-1200.webp 1200w, /hero-1600.webp 1600w"
128
+ sizes="(max-width: 1200px) 100vw, 1200px"
129
+ width="1200"
130
+ height="600"
131
+ type="image/webp"
132
+ />
133
+ <img
134
+ src="/hero-desktop.jpg"
135
+ width="1200"
136
+ height="600"
137
+ fetchpriority="high"
138
+ alt="Hero image description"
139
+ />
140
+ </picture>
141
+
142
+ <!-- GOOD: Below-the-fold image — lazy loaded + async decoding -->
143
+ <img
144
+ src="/content.webp"
145
+ width="800"
146
+ height="400"
147
+ loading="lazy"
148
+ decoding="async"
149
+ alt="Content image description"
150
+ />
151
+ ```
152
+
153
+ ## Unnecessary Re-renders (React)
154
+
155
+ ```tsx
156
+ // BAD: Creates new object on every render, causing children to re-render
157
+ function TaskList() {
158
+ return <TaskFilters options={{ sortBy: 'date', order: 'desc' }} />;
159
+ }
160
+
161
+ // GOOD: Stable reference
162
+ const DEFAULT_OPTIONS = { sortBy: 'date', order: 'desc' } as const;
163
+ function TaskList() {
164
+ return <TaskFilters options={DEFAULT_OPTIONS} />;
165
+ }
166
+
167
+ // Use React.memo for expensive components
168
+ const TaskItem = React.memo(function TaskItem({ task }: Props) {
169
+ return <div>{/* expensive render */}</div>;
170
+ });
171
+
172
+ // Use useMemo for expensive computations
173
+ function TaskStats({ tasks }: Props) {
174
+ const stats = useMemo(() => calculateStats(tasks), [tasks]);
175
+ return <div>{stats.completed} / {stats.total}</div>;
176
+ }
177
+ ```
178
+
179
+ ## Large Bundle Size
180
+
181
+ ```typescript
182
+ // Modern bundlers (Vite, webpack 5+) handle named imports with tree-shaking automatically,
183
+ // provided the dependency ships ESM and is marked `sideEffects: false` in package.json.
184
+ // Profile before changing import styles — the real gains come from splitting and lazy loading.
185
+
186
+ // GOOD: Dynamic import for heavy, rarely-used features
187
+ const ChartLibrary = lazy(() => import('./ChartLibrary'));
188
+
189
+ // GOOD: Route-level code splitting wrapped in Suspense
190
+ const SettingsPage = lazy(() => import('./pages/Settings'));
191
+
192
+ function App() {
193
+ return (
194
+ <Suspense fallback={<Spinner />}>
195
+ <SettingsPage />
196
+ </Suspense>
197
+ );
198
+ }
199
+ ```
200
+
201
+ ## Missing Caching (Backend)
202
+
203
+ Cache what is expensive to produce and read far more often than it changes. Caching a query that was already fast adds a network hop, a staleness bug, and an eviction policy to maintain, in exchange for nothing.
204
+
205
+ **Pick the layer deliberately:**
206
+
207
+ | Layer | Visible to | Use when | Cost |
208
+ |---|---|---|---|
209
+ | In-process (`Map`, LRU) | One instance | Small, hot, per-instance staleness is acceptable | Each instance drifts independently; invalidation reaches only one |
210
+ | Shared (Redis, Memcached) | All instances | Instances must agree, or the value is expensive to recompute | A network hop, and another service to run and monitor |
211
+ | CDN / edge | Everyone, per URL | Responses are public and identical for a given key | Invalidation is the hard part; assume you cannot recall a bad response quickly |
212
+
213
+ ```typescript
214
+ // Cache frequently-read, rarely-changed data
215
+ const CACHE_TTL = 5 * 60 * 1000; // 5 minutes
216
+ let cachedConfig: AppConfig | null = null;
217
+ let cacheExpiry = 0;
218
+
219
+ async function getAppConfig(): Promise<AppConfig> {
220
+ if (cachedConfig && Date.now() < cacheExpiry) {
221
+ return cachedConfig;
222
+ }
223
+ cachedConfig = await db.config.findFirst();
224
+ cacheExpiry = Date.now() + CACHE_TTL;
225
+ return cachedConfig;
226
+ }
227
+
228
+ // HTTP caching headers for static assets
229
+ app.use('/static', express.static('public', {
230
+ maxAge: '1y', // Cache for 1 year
231
+ immutable: true, // Never revalidate (use content hashing in filenames)
232
+ }));
233
+
234
+ // Cache-Control for API responses
235
+ res.set('Cache-Control', 'public, max-age=300'); // 5 minutes
236
+ ```
237
+
238
+ **Key design decides correctness.** Every input that changes the response belongs in the key: tenant, locale, permissions, feature flags. A key that omits the viewer is how one user's data gets served to another, and that ships as a performance win.
239
+
240
+ **Choose one invalidation strategy, not three:**
241
+
242
+ | Strategy | Trade-off |
243
+ |---|---|
244
+ | TTL | Simplest. You accept staleness up to the TTL, so state the acceptable window explicitly |
245
+ | Event or tag based | Fresh on write, but writers now have to know the cache topology |
246
+ | Versioned keys (`user:42:profile:v7`) | Never invalidate, just stop reading old keys. Costs memory until eviction |
247
+
248
+ **Guard against the stampede.** A hot key expires, every concurrent request misses together, and the origin takes the full load at once, which is how a cache turns into an outage instead of preventing one. Serve stale while a single request recomputes (`stale-while-revalidate`), or coalesce concurrent misses behind one in-flight promise so N waiters cause one recompute.
249
+
250
+ **Do not cache:** anything whose staleness is a correctness bug (balances, permissions, inventory at checkout), or per-user data under a key that does not identify the user. See `../${CLAUDE_SKILL_DIR}/../_references/performance-checklist.md#caching-strategies` for request coalescing, write strategies, negative caching, and the cache checklist.