folio-migration-tools 1.9.10__py3-none-any.whl → 1.10.0b1__py3-none-any.whl

folio_migration_tools/library_configuration.py

@@ -1,7 +1,7 @@
 from enum import Enum
 from typing import Annotated
 
-from pydantic import BaseModel, Field
+from pydantic import BaseModel, Field, model_validator
 from pydantic.types import DirectoryPath
 
 
@@ -25,8 +25,7 @@ class FileDefinition(BaseModel):
         Field(
             title="File name",
             description=(
-                "Name of the file to be processed. "
-                "The location of the file depends on the context"
+                "Name of the file to be processed. The location of the file depends on the context"
             ),
         ),
     ] = ""
@@ -37,10 +36,9 @@ class FileDefinition(BaseModel):
         Field(
             title="Service point ID",
             description=(
-                "Service point to be used for "
-                "transactions created from this file (Loans-only)."
+                "Service point to be used for transactions created from this file (Loans-only)."
             ),
-        )
+        ),
     ] = ""
     statistical_code: Annotated[
         str,
@@ -51,7 +49,7 @@ class FileDefinition(BaseModel):
                 "this file (Instances, Holdings, Items). Specify multiple codes using "
                 "multi_field_delimiter."
             ),
-        )
+        ),
     ] = ""
     create_source_records: Annotated[
         bool,
@@ -85,6 +83,7 @@ class FolioRelease(str, Enum):
     ramsons = "ramsons"
     sunflower = "sunflower"
     trillium = "trillium"
+    umbrellaleaf = "umbrellaleaf"
 
 
 class LibraryConfiguration(BaseModel):
@@ -96,7 +95,6 @@ class LibraryConfiguration(BaseModel):
                 "The URL of the FOLIO API gateway instance. "
                 "You can find this in Settings > Software versions > API gateway services."
             ),
-            alias="okapi_url"
         ),
     ]
     tenant_id: Annotated[
@@ -106,7 +104,8 @@ class LibraryConfiguration(BaseModel):
             description=(
                 "The ID of the FOLIO tenant instance. "
                 "You can find this in Settings > Software versions > API gateway services. "
-                "In an ECS environment, this is the ID of the central tenant, for all configurations."
+                "In an ECS environment, this is the ID of the central tenant, for all "
+                "configurations."
             ),
         ),
     ]
@@ -128,18 +127,14 @@ class LibraryConfiguration(BaseModel):
                 "The username for the FOLIO user account performing the migration. "
                 "User should have a full admin permissions/roles in FOLIO. "
             ),
-            alias="okapi_username"
         ),
     ]
     folio_password: Annotated[
         str,
         Field(
             title="FOLIO API Gateway password",
-            description=(
-                "The password for the FOLIO user account performing the migration. "
-            ),
-            alias="okapi_password"
-        )
+            description=("The password for the FOLIO user account performing the migration. "),
+        ),
     ]
     base_folder: DirectoryPath = Field(
         description=(
@@ -153,7 +148,8 @@ class LibraryConfiguration(BaseModel):
             title="Multi field delimiter",
             description=(
                 "The delimiter used to separate multiple values in a single field. "
-                "This is used for delimited text (CSV/TSV) fields with multiple sub-delimited values."
+                "This is used for delimited text (CSV/TSV) fields with multiple sub-delimited "
+                "values."
             ),
         ),
     ] = "<delimiter>"
@@ -163,36 +159,42 @@ class LibraryConfiguration(BaseModel):
     ] = 5000
     failed_percentage_threshold: Annotated[
         int,
-        Field(
-            description=("Percentage of failed records until the process shuts down")
-        ),
+        Field(description=("Percentage of failed records until the process shuts down")),
     ] = 20
     generic_exception_threshold: Annotated[
         int,
+        Field(description=("Number of generic exceptions until the process shuts down")),
+    ] = 50
+    library_name: Annotated[str, Field(description="Name of the library being migrated")]
+    log_level_debug: Annotated[bool, Field(description="Enable debug level logging")] = False
+    folio_release: Annotated[
+        FolioRelease,
         Field(
-            description=("Number of generic exceptions until the process shuts down")
+            description=(
+                "The Flavour of the ILS you are migrating from. This choice is "
+                "maninly tied to the handling of legacy identifiers and thereby the "
+                "deterministic UUIDs generated from them."
+            )
         ),
-    ] = 50
-    library_name: str
-    log_level_debug: bool
-    folio_release: FolioRelease = Field(
-        description=(
-            "The Flavour of the ILS you are migrating from. This choice is "
-            "maninly tied to the handling of legacy identifiers and thereby the "
-            "deterministic UUIDs generated from them."
-        )
+    ]
+    iteration_identifier: Annotated[
+        str,
+        Field(
+            description="The name of the current directory under base_folder/iterations/ to be "
+            "used for this migration."
+        ),
+    ]
+    add_time_stamp_to_file_names: Annotated[bool, Field(title="Add time stamp to file names")] = (
+        False
     )
-    iteration_identifier: str
-    add_time_stamp_to_file_names: Annotated[
-        bool, Field(title="Add time stamp to file names")
-    ] = False
     use_gateway_url_for_uuids: Annotated[
         bool,
         Field(
             title="Use gateway URL for UUIDs",
             description=(
-                "If set to true, folio_uuid will use the gateway URL when generating deterministic UUIDs for FOLIO records. "
-                "If set to false (default), the UUIDs will be generated using the tenant_id (or ecs_tenant_id)."
+                "If set to true, folio_uuid will use the gateway URL when generating deterministic"
+                " UUIDs for FOLIO records. If set to false (default), the UUIDs will be generated"
+                " using the tenant_id (or ecs_tenant_id)."
             ),
         ),
     ] = False
@@ -212,8 +214,34 @@ class LibraryConfiguration(BaseModel):
         Field(
             title="ECS central iteration identifier",
             description=(
-                "The iteration_identifier value from the central tenant configuration that corresponds "
-                "to this configuration's iteration_identifier. Used to access the central instances_id_map."
+                "The iteration_identifier value from the central tenant configuration that "
+                "corresponds to this configuration's iteration_identifier. Used to access the "
+                "central instances_id_map."
             ),
         ),
     ] = ""
+
+    @model_validator(mode="before")
+    @classmethod
+    def handle_legacy_field_names(cls, values):
+        """Handle backward compatibility for legacy okapi field names."""
+        # Handle folio_password / okapi_password backward compatibility
+        if "folio_password" not in values and "okapi_password" in values:
+            values["folio_password"] = values["okapi_password"]
+        if "gateway_url" not in values and "okapi_url" in values:
+            values["gateway_url"] = values["okapi_url"]
+        if "folio_username" not in values and "okapi_username" in values:
+            values["folio_username"] = values["okapi_username"]
+        return values
+
+    @model_validator(mode="before")
+    @classmethod
+    def set_error_thresholds_for_debug(cls, values):
+        """If log_level_debug is true, set error thresholds to very high values to avoid
+        process shutdown during debugging.
+        """
+        if values.get("log_level_debug", False):
+            values["failed_records_threshold"] = 10_000_000
+            values["failed_percentage_threshold"] = 100
+            values["generic_exception_threshold"] = 10_000_000
+        return values

folio_migration_tools/mapper_base.py

@@ -6,7 +6,7 @@ import sys
 import uuid
 from datetime import datetime, timezone
 from pathlib import Path
-from typing import Dict, List, Optional, Tuple, Union
+from typing import Dict, List, Tuple
 
 import i18n
 from folio_uuid.folio_namespaces import FOLIONamespaces
@@ -38,10 +38,10 @@ class MapperBase:
         library_configuration: LibraryConfiguration,
         task_configuration: AbstractTaskConfiguration,
         folio_client: FolioClient,
-        parent_id_map: Dict[str, Tuple] = {},
+        parent_id_map: Dict[str, Tuple] | None = None,
     ):
         logging.info("MapperBase initiating")
-        self.parent_id_map: dict[str, tuple] = parent_id_map
+        self.parent_id_map: dict[str, tuple] = parent_id_map or {}
         self.extradata_writer: ExtradataWriter = ExtradataWriter(Path(""))
         self.start_datetime = datetime.now(timezone.utc)
         self.folio_client: FolioClient = folio_client
@@ -119,8 +119,8 @@ class MapperBase:
             self.migration_report.add(
                 ref_data_mapping.blurb_id,
                 (
-                    f'{" - ".join(fieldvalues)} '
-                    f'-> {right_mapping[f"folio_{ref_data_mapping.key_type}"]}'
+                    f"{' - '.join(fieldvalues)} "
+                    f"-> {right_mapping[f'folio_{ref_data_mapping.key_type}']}"
                 ),
             )
             return next(v for k, v in right_mapping.items() if k.startswith("folio_"))
@@ -129,14 +129,14 @@ class MapperBase:
             if prevent_default:
                 self.migration_report.add(
                     ref_data_mapping.blurb_id,
-                    (f"Not to be mapped. " f'(No default) -- {" - ".join(fieldvalues)} -> ""'),
+                    (f'Not to be mapped. (No default) -- {" - ".join(fieldvalues)} -> ""'),
                 )
                 return ""
             self.migration_report.add(
                 ref_data_mapping.blurb_id,
                 (
                     f"Unmapped (Default value was set) -- "
-                    f'{" - ".join(fieldvalues)} -> {ref_data_mapping.default_name}'
+                    f"{' - '.join(fieldvalues)} -> {ref_data_mapping.default_name}"
                 ),
             )
             return ref_data_mapping.default_name
@@ -192,8 +192,8 @@ class MapperBase:
             self.migration_report.add(
                 ref_data_mapping.blurb_id,
                 (
-                    f'{" - ".join(fieldvalues)} '
-                    f'-> {right_mapping[f"folio_{ref_data_mapping.key_type}"]}'
+                    f"{' - '.join(fieldvalues)} "
+                    f"-> {right_mapping[f'folio_{ref_data_mapping.key_type}']}"
                 ),
             )
             return right_mapping["folio_id"]
@@ -201,14 +201,14 @@ class MapperBase:
             if prevent_default:
                 self.migration_report.add(
                     ref_data_mapping.blurb_id,
-                    (f"Not to be mapped. " f'(No default) -- {" - ".join(fieldvalues)} -> ""'),
+                    (f'Not to be mapped. (No default) -- {" - ".join(fieldvalues)} -> ""'),
                 )
                 return ""
             self.migration_report.add(
                 ref_data_mapping.blurb_id,
                 (
                     f"Unmapped (Default value was set) -- "
-                    f'{" - ".join(fieldvalues)} -> {ref_data_mapping.default_name}'
+                    f"{' - '.join(fieldvalues)} -> {ref_data_mapping.default_name}"
                 ),
             )
             return ref_data_mapping.default_id
@@ -430,7 +430,7 @@ class MapperBase:
                     folio_holding["id"], instance_uuid
                 )
                 if bound_with_holding.get("hrid", ""):
-                    bound_with_holding["hrid"] = f'{bound_with_holding["hrid"]}_bw_{bwidx}'
+                    bound_with_holding["hrid"] = f"{bound_with_holding['hrid']}_bw_{bwidx}"
             self.migration_report.add_general_statistics(i18n.t("Bound-with holdings created"))
             yield bound_with_holding
 
@@ -443,7 +443,12 @@ class MapperBase:
             )
         )
 
-    def map_statistical_codes(self, folio_record: dict, file_def: FileDefinition, legacy_record: Optional[Union[dict, Record]] = None):
+    def map_statistical_codes(
+        self,
+        folio_record: dict,
+        file_def: FileDefinition,
+        legacy_record: dict | Record | None = None,
+    ):
         """Map statistical codes to the folio record.
 
         This method checks if the file definition contains statistical codes and
@@ -454,13 +459,15 @@ class MapperBase:
         Args:
             folio_record (dict): The FOLIO record to which the statistical codes will be added.
             file_def (FileDefinition): The file definition containing the statistical codes.
-            legacy_record (Optional[Union[dict, Record]]): The legacy record from which the statistical codes are derived.
-        """
+            legacy_record (dict | Record | None): The legacy record from which the statistical codes are derived.
+        """  # noqa: E501
         if file_def.statistical_code:
             code_strings = file_def.statistical_code.split(
                 self.library_configuration.multi_field_delimiter
             )
-            folio_record["statisticalCodeIds"] = folio_record.get("statisticalCodeIds", []) + code_strings
+            folio_record["statisticalCodeIds"] = (
+                folio_record.get("statisticalCodeIds", []) + code_strings
+            )
 
     def setup_statistical_codes_map(self, statistical_codes_map):
         if statistical_codes_map:
@@ -472,7 +479,9 @@ class MapperBase:
                 "code",
                 "StatisticalCodeMapping",
             )
-            logging.info(f"Statistical codes mapping set up {self.statistical_codes_mapping.mapped_legacy_keys}")
+            logging.info(
+                f"Statistical codes mapping set up {self.statistical_codes_mapping.mapped_legacy_keys}"  # noqa: E501
+            )
         else:
             self.statistical_codes_mapping = None
             logging.info("Statistical codes map is not set up")
@@ -492,13 +501,13 @@ class MapperBase:
         )
         return ""
 
-    def map_statistical_code_ids(
-        self, legacy_ids, folio_record: dict
-    ):
-        if stat_codes := {x: None for x in folio_record.pop("statisticalCodeIds", [])}:
+    def map_statistical_code_ids(self, legacy_ids, folio_record: dict):
+        if stat_codes := dict.fromkeys(folio_record.pop("statisticalCodeIds", [])):
             folio_code_ids = set()
             for stat_code in stat_codes:
-                if stat_code_id := self.get_statistical_code({"legacy_stat_code": stat_code}, "statisticalCodeId", legacy_ids):
+                if stat_code_id := self.get_statistical_code(
+                    {"legacy_stat_code": stat_code}, "statisticalCodeId", legacy_ids
+                ):
                     folio_code_ids.add(stat_code_id)
                 else:
                     Helper.log_data_issue(
@@ -513,7 +522,10 @@ class MapperBase:
 
     @property
     def base_string_for_folio_uuid(self):
-        if self.library_configuration.use_gateway_url_for_uuids and not self.library_configuration.is_ecs:
+        if (
+            self.library_configuration.use_gateway_url_for_uuids
+            and not self.library_configuration.is_ecs
+        ):
             return str(self.folio_client.gateway_url)
         elif self.library_configuration.ecs_tenant_id:
             return str(self.library_configuration.ecs_tenant_id)
@@ -522,8 +534,8 @@ class MapperBase:
 
     @staticmethod
     def validate_location_map(location_map: List[Dict], locations: List[Dict]) -> List[Dict]:
-        mapped_codes = [x['folio_code'] for x in location_map]
-        existing_codes = [x['code'] for x in locations]
+        mapped_codes = [x["folio_code"] for x in location_map]
+        existing_codes = [x["code"] for x in locations]
         missing_codes = set(mapped_codes) - set(existing_codes)
         if missing_codes:
             raise TransformationProcessError(
@@ -537,6 +549,7 @@ class MapperBase:
     def get_object_type() -> FOLIONamespaces:
         raise NotImplementedError("This method should be overridden in subclasses")
 
+
 def flatten(my_dict: dict, path=""):
     for k, v in iter(my_dict.items()):
         if not path:

folio_migration_tools/mapping_file_transformation/courses_mapper.py

@@ -45,7 +45,7 @@ class CoursesMapper(MappingFileMapperBase):
             None,
             FOLIONamespaces.course,
             library_configuration,
-            task_configuration
+            task_configuration,
         )
         self.course_map = course_map
         if terms_map:

folio_migration_tools/mapping_file_transformation/holdings_mapper.py

@@ -6,7 +6,10 @@ import i18n
 from folio_uuid.folio_uuid import FOLIONamespaces
 from folioclient import FolioClient
 
-from folio_migration_tools.custom_exceptions import TransformationProcessError, TransformationRecordFailedError
+from folio_migration_tools.custom_exceptions import (
+    TransformationProcessError,
+    TransformationRecordFailedError,
+)
 from folio_migration_tools.library_configuration import (
     FileDefinition,
     LibraryConfiguration,
@@ -19,6 +22,7 @@ from folio_migration_tools.mapping_file_transformation.ref_data_mapping import (
 )
 from folio_migration_tools.task_configuration import AbstractTaskConfiguration
 
+
 class HoldingsMapper(MappingFileMapperBase):
     def __init__(
         self,
@@ -40,7 +44,7 @@ class HoldingsMapper(MappingFileMapperBase):
             statistical_codes_map,
             FOLIONamespaces.holdings,
             library_configuration,
-            task_config
+            task_config,
         )
         self.holdings_map = holdings_map
 
@@ -86,7 +90,7 @@ class HoldingsMapper(MappingFileMapperBase):
         folio_record["discoverySuppress"] = file_def.discovery_suppressed
         self.migration_report.add(
             "Suppression",
-            i18n.t("Suppressed from discovery") + f' = {folio_record["discoverySuppress"]}',
+            i18n.t("Suppressed from discovery") + f" = {folio_record['discoverySuppress']}",
         )
 
     def get_prop(self, legacy_item, folio_prop_name, index_or_id, schema_default_value):

folio_migration_tools/mapping_file_transformation/item_mapper.py

@@ -2,7 +2,7 @@ import json
 import logging
 import sys
 from datetime import datetime, timezone
-from typing import Dict, List, Set, Union
+from typing import Dict, List, Set
 from uuid import uuid4
 
 import i18n
@@ -117,7 +117,9 @@ class ItemMapper(MappingFileMapperBase):
             "LocationMapping",
         )
 
-    def perform_additional_mappings(self, legacy_ids: Union[str, List[str]], folio_rec: Dict, file_def: FileDefinition):
+    def perform_additional_mappings(
+        self, legacy_ids: List[str] | str, folio_rec: Dict, file_def: FileDefinition
+    ):
         self.handle_suppression(folio_rec, file_def)
         self.map_statistical_codes(folio_rec, file_def)
         self.map_statistical_code_ids(legacy_ids, folio_rec)
@@ -126,24 +128,17 @@ class ItemMapper(MappingFileMapperBase):
         folio_record["discoverySuppress"] = file_def.discovery_suppressed
         self.migration_report.add(
             "Suppression",
-            i18n.t("Suppressed from discovery")
-            + f" = {folio_record['discoverySuppress']}",
+            i18n.t("Suppressed from discovery") + f" = {folio_record['discoverySuppress']}",
         )
 
     def setup_status_mapping(self, item_statuses_map):
-        statuses = self.item_schema["properties"]["status"]["properties"]["name"][
-            "enum"
-        ]
+        statuses = self.item_schema["properties"]["status"]["properties"]["name"]["enum"]
         for mapping in item_statuses_map:
             if "folio_name" not in mapping:
-                logging.critical(
-                    "folio_name is not a column in the status mapping file"
-                )
+                logging.critical("folio_name is not a column in the status mapping file")
                 sys.exit(1)
             elif "legacy_code" not in mapping:
-                logging.critical(
-                    "legacy_code is not a column in the status mapping file"
-                )
+                logging.critical("legacy_code is not a column in the status mapping file")
                 sys.exit(1)
             elif mapping["folio_name"] not in statuses:
                 logging.critical(
@@ -158,9 +153,7 @@ class ItemMapper(MappingFileMapperBase):
                 )
                 sys.exit(1)
             elif not all(mapping.values()):
-                logging.critical(
-                    "empty value in mapping %s. Check mapping file", mapping.values()
-                )
+                logging.critical("empty value in mapping %s. Check mapping file", mapping.values())
                 sys.exit(1)
             else:
                 self.status_mapping = {
@@ -168,7 +161,7 @@ class ItemMapper(MappingFileMapperBase):
                 }
         logging.info(json.dumps(statuses, indent=True))
 
-    def get_prop(self, legacy_item, folio_prop_name, index_or_id, schema_default_value):
+    def get_prop(self, legacy_item, folio_prop_name, index_or_id, schema_default_value):  # noqa: C901
         if folio_prop_name == "permanentLocationId":
             return self.get_mapped_ref_data_value(
                 self.location_mapping,
@@ -213,9 +206,7 @@ class ItemMapper(MappingFileMapperBase):
                 index_or_id,
                 True,
             )
-            self.migration_report.add(
-                "TemporaryLoanTypeMapping", f"{folio_prop_name} -> {ltid}"
-            )
+            self.migration_report.add("TemporaryLoanTypeMapping", f"{folio_prop_name} -> {ltid}")
             return ltid
         elif folio_prop_name == "permanentLoanTypeId":
             return self.get_mapped_ref_data_value(
@@ -232,9 +223,7 @@ class ItemMapper(MappingFileMapperBase):
             normalized_barcode = barcode.strip().lower()
             if normalized_barcode and normalized_barcode in self.unique_barcodes:
                 Helper.log_data_issue(index_or_id, "Duplicate barcode", mapped_value)
-                self.migration_report.add_general_statistics(
-                    i18n.t("Duplicate barcodes")
-                )
+                self.migration_report.add_general_statistics(i18n.t("Duplicate barcodes"))
                 return f"{barcode}-{uuid4()}"
             else:
                 if normalized_barcode:
@@ -259,9 +248,7 @@ class ItemMapper(MappingFileMapperBase):
             self.migration_report.add("UnmappedProperties", f"{folio_prop_name}")
             return ""
 
-    def get_item_level_call_number_type_id(
-        self, legacy_item, folio_prop_name: str, index_or_id
-    ):
+    def get_item_level_call_number_type_id(self, legacy_item, folio_prop_name: str, index_or_id):
         if self.call_number_mapping:
             return self.get_mapped_ref_data_value(
                 self.call_number_mapping, legacy_item, index_or_id, folio_prop_name

folio_migration_tools/mapping_file_transformation/manual_fee_fines_mapper.py

@@ -172,8 +172,7 @@ class ManualFeeFinesMapper(MappingFileMapperBase):
         except TypeError as te:
             raise TransformationProcessError(
                 "",
-                "Failed to fetch Tenant Locale Settings. "
-                "Is your library configuration correct?",
+                "Failed to fetch Tenant Locale Settings. Is your library configuration correct?",
             ) from te
         except KeyError as ke:
             raise TransformationProcessError(

folio_migration_tools/mapping_file_transformation/mapping_file_mapper_base.py

@@ -133,7 +133,7 @@ class MappingFileMapperBase(MapperBase):
                 raise TransformationProcessError(
                     "",
                     f"property legacyIdentifier not setup in map: "
-                    f"{field_map.get('legacyIdentifier', '') ({exception})}",
+                    f"{field_map.get('legacyIdentifier', '')({exception})}",
                 ) from exception
             del field_map["legacyIdentifier"]
         return field_map
@@ -213,12 +213,10 @@ class MappingFileMapperBase(MapperBase):
             }
         )
         if object_type == FOLIONamespaces.holdings and hasattr(self, "holdings_sources"):
-            folio_object['sourceId'] = self.holdings_sources.get("FOLIO")
+            folio_object["sourceId"] = self.holdings_sources.get("FOLIO")
         elif object_type == FOLIONamespaces.holdings and not hasattr(self, "holdings_sources"):
             raise TransformationProcessError(
-                index_or_id,
-                "Holdings source not set in the mapper",
-                None
+                index_or_id, "Holdings source not set in the mapper", None
             )
         return folio_object, legacy_id
 
@@ -400,7 +398,7 @@ class MappingFileMapperBase(MapperBase):
                 value = replaced_val
         if value and mapping_file_entry.get("rules", {}).get("regexGetFirstMatchOrEmpty", ""):
             my_pattern = (
-                f'{mapping_file_entry.get("rules", {}).get("regexGetFirstMatchOrEmpty")}|$'
+                f"{mapping_file_entry.get('rules', {}).get('regexGetFirstMatchOrEmpty')}|$"
             )
             value = re.findall(my_pattern, value)[0]
         if not value and mapping_file_entry.get("fallback_legacy_field", ""):
@@ -498,7 +496,7 @@ class MappingFileMapperBase(MapperBase):
             set_deep(folio_object, schema_property_name, temp_object)
             # folio_object[schema_property_name] = temp_object
 
-    def map_objects_array_props(
+    def map_objects_array_props(  # noqa: C901
         self,
         legacy_object,
         prop_name: str,
@@ -553,7 +551,9 @@ class MappingFileMapperBase(MapperBase):
                                     )
                             multi_field_props.append(sub_prop_name)
                         else:
-                            self.validate_enums(res, sub_prop, sub_prop_name, index_or_id, required)
+                            self.validate_enums(
+                                res, sub_prop, sub_prop_name, index_or_id, required
+                            )
 
                         if res or isinstance(res, bool):
                             temp_object[sub_prop_name] = res
@@ -619,8 +619,8 @@ class MappingFileMapperBase(MapperBase):
     @staticmethod
     def split_obj_by_delim(delimiter: str, folio_obj: dict, delimited_props: List[str]):
         non_split_props = [(k, v) for k, v in folio_obj.items() if k not in delimited_props]
-        delimited_props = map(lambda x: [x, *folio_obj[x].split(delimiter)], delimited_props)
-        zipped = list(zip(*delimited_props))
+        delimited_props = ([x, *folio_obj[x].split(delimiter)] for x in delimited_props)
+        zipped = list(zip(*delimited_props, strict=False))
         res = []
         for (prop_name_idx, prop_name), (value_idx, ra) in itertools.product(
             enumerate(zipped[0]), enumerate(zipped[1:])
@@ -973,4 +973,6 @@ def in_deep(dictionary, keys):
 
 
 def is_set_or_bool_or_numeric(any_value):
-    return (isinstance(any_value, str) and (any_value.strip() not in empty_vals)) or isinstance(any_value, (int, float, complex))
+    return (isinstance(any_value, str) and (any_value.strip() not in empty_vals)) or isinstance(
+        any_value, (int, float, complex)
+    )

folio_migration_tools/mapping_file_transformation/order_mapper.py

@@ -25,7 +25,6 @@ from folio_migration_tools.mapping_file_transformation.ref_data_mapping import (
 
 
 class CompositeOrderMapper(MappingFileMapperBase):
-
     def __init__(
         self,
         folio_client: FolioClient,
@@ -291,7 +290,9 @@ class CompositeOrderMapper(MappingFileMapperBase):
             ):
                 object_schema["properties"] = CompositeOrderMapper.inject_schema_by_ref(
                     submodule_path, github_headers, object_schema
-                ).get("properties", {})#TODO: Investigate new CustomFields schema and figure out how to actually handle it
+                ).get(
+                    "properties", {}
+                )  # TODO: Investigate new CustomFields schema and figure out how to actually handle it # noqa: E501
 
             for property_name_level1, property_level1 in object_schema.get(
                 "properties", {}
@@ -400,9 +401,9 @@ class CompositeOrderMapper(MappingFileMapperBase):
         return composite_order
 
     def validate_po_number(
-            self,
-            index_or_id: str,
-            po_number: str,
+        self,
+        index_or_id: str,
+        po_number: str,
     ):
         if not self.is_valid_po_number(po_number):
             self.migration_report.add(

folio_migration_tools/mapping_file_transformation/organization_mapper.py

@@ -330,9 +330,9 @@ class OrganizationMapper(MappingFileMapperBase):
                         ["username", "password", "interfaceId"],
                     )
 
-                    interface_schema["properties"][
-                        "interfaceCredential"
-                    ] = interface_credential_schema
+                    interface_schema["properties"]["interfaceCredential"] = (
+                        interface_credential_schema
+                    )
 
                     property_level1["items"] = interface_schema