folio-migration-tools 1.9.10__py3-none-any.whl → 1.10.0__py3-none-any.whl

folio_migration_tools/mapping_file_transformation/item_mapper.py

@@ -2,7 +2,7 @@ import json
 import logging
 import sys
 from datetime import datetime, timezone
-from typing import Dict, List, Set, Union
+from typing import Dict, List, Set
 from uuid import uuid4
 
 import i18n
@@ -117,7 +117,9 @@ class ItemMapper(MappingFileMapperBase):
             "LocationMapping",
         )
 
-    def perform_additional_mappings(self, legacy_ids: Union[str, List[str]], folio_rec: Dict, file_def: FileDefinition):
+    def perform_additional_mappings(
+        self, legacy_ids: List[str] | str, folio_rec: Dict, file_def: FileDefinition
+    ):
         self.handle_suppression(folio_rec, file_def)
         self.map_statistical_codes(folio_rec, file_def)
         self.map_statistical_code_ids(legacy_ids, folio_rec)
@@ -126,24 +128,17 @@ class ItemMapper(MappingFileMapperBase):
         folio_record["discoverySuppress"] = file_def.discovery_suppressed
         self.migration_report.add(
             "Suppression",
-            i18n.t("Suppressed from discovery")
-            + f" = {folio_record['discoverySuppress']}",
+            i18n.t("Suppressed from discovery") + f" = {folio_record['discoverySuppress']}",
         )
 
     def setup_status_mapping(self, item_statuses_map):
-        statuses = self.item_schema["properties"]["status"]["properties"]["name"][
-            "enum"
-        ]
+        statuses = self.item_schema["properties"]["status"]["properties"]["name"]["enum"]
         for mapping in item_statuses_map:
             if "folio_name" not in mapping:
-                logging.critical(
-                    "folio_name is not a column in the status mapping file"
-                )
+                logging.critical("folio_name is not a column in the status mapping file")
                 sys.exit(1)
             elif "legacy_code" not in mapping:
-                logging.critical(
-                    "legacy_code is not a column in the status mapping file"
-                )
+                logging.critical("legacy_code is not a column in the status mapping file")
                 sys.exit(1)
             elif mapping["folio_name"] not in statuses:
                 logging.critical(
@@ -158,9 +153,7 @@ class ItemMapper(MappingFileMapperBase):
                 )
                 sys.exit(1)
             elif not all(mapping.values()):
-                logging.critical(
-                    "empty value in mapping %s. Check mapping file", mapping.values()
-                )
+                logging.critical("empty value in mapping %s. Check mapping file", mapping.values())
                 sys.exit(1)
             else:
                 self.status_mapping = {
@@ -168,7 +161,7 @@ class ItemMapper(MappingFileMapperBase):
                 }
         logging.info(json.dumps(statuses, indent=True))
 
-    def get_prop(self, legacy_item, folio_prop_name, index_or_id, schema_default_value):
+    def get_prop(self, legacy_item, folio_prop_name, index_or_id, schema_default_value):  # noqa: C901
         if folio_prop_name == "permanentLocationId":
             return self.get_mapped_ref_data_value(
                 self.location_mapping,
@@ -213,9 +206,7 @@ class ItemMapper(MappingFileMapperBase):
                 index_or_id,
                 True,
             )
-            self.migration_report.add(
-                "TemporaryLoanTypeMapping", f"{folio_prop_name} -> {ltid}"
-            )
+            self.migration_report.add("TemporaryLoanTypeMapping", f"{folio_prop_name} -> {ltid}")
             return ltid
         elif folio_prop_name == "permanentLoanTypeId":
             return self.get_mapped_ref_data_value(
@@ -232,9 +223,7 @@ class ItemMapper(MappingFileMapperBase):
             normalized_barcode = barcode.strip().lower()
             if normalized_barcode and normalized_barcode in self.unique_barcodes:
                 Helper.log_data_issue(index_or_id, "Duplicate barcode", mapped_value)
-                self.migration_report.add_general_statistics(
-                    i18n.t("Duplicate barcodes")
-                )
+                self.migration_report.add_general_statistics(i18n.t("Duplicate barcodes"))
                 return f"{barcode}-{uuid4()}"
             else:
                 if normalized_barcode:
@@ -259,9 +248,7 @@ class ItemMapper(MappingFileMapperBase):
             self.migration_report.add("UnmappedProperties", f"{folio_prop_name}")
             return ""
 
-    def get_item_level_call_number_type_id(
-        self, legacy_item, folio_prop_name: str, index_or_id
-    ):
+    def get_item_level_call_number_type_id(self, legacy_item, folio_prop_name: str, index_or_id):
         if self.call_number_mapping:
             return self.get_mapped_ref_data_value(
                 self.call_number_mapping, legacy_item, index_or_id, folio_prop_name

folio_migration_tools/mapping_file_transformation/manual_fee_fines_mapper.py

@@ -172,8 +172,7 @@ class ManualFeeFinesMapper(MappingFileMapperBase):
         except TypeError as te:
             raise TransformationProcessError(
                 "",
-                "Failed to fetch Tenant Locale Settings. "
-                "Is your library configuration correct?",
+                "Failed to fetch Tenant Locale Settings. Is your library configuration correct?",
             ) from te
         except KeyError as ke:
             raise TransformationProcessError(

folio_migration_tools/mapping_file_transformation/mapping_file_mapper_base.py

@@ -133,7 +133,7 @@ class MappingFileMapperBase(MapperBase):
                 raise TransformationProcessError(
                     "",
                     f"property legacyIdentifier not setup in map: "
-                    f"{field_map.get('legacyIdentifier', '') ({exception})}",
+                    f"{field_map.get('legacyIdentifier', '')({exception})}",
                 ) from exception
             del field_map["legacyIdentifier"]
         return field_map
@@ -213,12 +213,10 @@ class MappingFileMapperBase(MapperBase):
             }
         )
         if object_type == FOLIONamespaces.holdings and hasattr(self, "holdings_sources"):
-            folio_object['sourceId'] = self.holdings_sources.get("FOLIO")
+            folio_object["sourceId"] = self.holdings_sources.get("FOLIO")
         elif object_type == FOLIONamespaces.holdings and not hasattr(self, "holdings_sources"):
             raise TransformationProcessError(
-                index_or_id,
-                "Holdings source not set in the mapper",
-                None
+                index_or_id, "Holdings source not set in the mapper", None
             )
         return folio_object, legacy_id
 
@@ -400,7 +398,7 @@ class MappingFileMapperBase(MapperBase):
                 value = replaced_val
         if value and mapping_file_entry.get("rules", {}).get("regexGetFirstMatchOrEmpty", ""):
             my_pattern = (
-                f'{mapping_file_entry.get("rules", {}).get("regexGetFirstMatchOrEmpty")}|$'
+                f"{mapping_file_entry.get('rules', {}).get('regexGetFirstMatchOrEmpty')}|$"
             )
             value = re.findall(my_pattern, value)[0]
         if not value and mapping_file_entry.get("fallback_legacy_field", ""):
@@ -498,7 +496,7 @@ class MappingFileMapperBase(MapperBase):
             set_deep(folio_object, schema_property_name, temp_object)
             # folio_object[schema_property_name] = temp_object
 
-    def map_objects_array_props(
+    def map_objects_array_props(  # noqa: C901
         self,
         legacy_object,
         prop_name: str,
@@ -553,7 +551,9 @@ class MappingFileMapperBase(MapperBase):
                                     )
                             multi_field_props.append(sub_prop_name)
                         else:
-                            self.validate_enums(res, sub_prop, sub_prop_name, index_or_id, required)
+                            self.validate_enums(
+                                res, sub_prop, sub_prop_name, index_or_id, required
+                            )
 
                         if res or isinstance(res, bool):
                             temp_object[sub_prop_name] = res
@@ -619,8 +619,8 @@ class MappingFileMapperBase(MapperBase):
     @staticmethod
     def split_obj_by_delim(delimiter: str, folio_obj: dict, delimited_props: List[str]):
         non_split_props = [(k, v) for k, v in folio_obj.items() if k not in delimited_props]
-        delimited_props = map(lambda x: [x, *folio_obj[x].split(delimiter)], delimited_props)
-        zipped = list(zip(*delimited_props))
+        delimited_props = ([x, *folio_obj[x].split(delimiter)] for x in delimited_props)
+        zipped = list(zip(*delimited_props, strict=False))
         res = []
         for (prop_name_idx, prop_name), (value_idx, ra) in itertools.product(
             enumerate(zipped[0]), enumerate(zipped[1:])
@@ -973,4 +973,6 @@ def in_deep(dictionary, keys):
 
 
 def is_set_or_bool_or_numeric(any_value):
-    return (isinstance(any_value, str) and (any_value.strip() not in empty_vals)) or isinstance(any_value, (int, float, complex))
+    return (isinstance(any_value, str) and (any_value.strip() not in empty_vals)) or isinstance(
+        any_value, (int, float, complex)
+    )

folio_migration_tools/mapping_file_transformation/order_mapper.py

@@ -25,7 +25,6 @@ from folio_migration_tools.mapping_file_transformation.ref_data_mapping import (
 
 
 class CompositeOrderMapper(MappingFileMapperBase):
-
     def __init__(
         self,
         folio_client: FolioClient,
@@ -291,7 +290,9 @@ class CompositeOrderMapper(MappingFileMapperBase):
             ):
                 object_schema["properties"] = CompositeOrderMapper.inject_schema_by_ref(
                     submodule_path, github_headers, object_schema
-                ).get("properties", {})#TODO: Investigate new CustomFields schema and figure out how to actually handle it
+                ).get(
+                    "properties", {}
+                )  # TODO: Investigate new CustomFields schema and figure out how to actually handle it # noqa: E501
 
             for property_name_level1, property_level1 in object_schema.get(
                 "properties", {}
@@ -400,9 +401,9 @@ class CompositeOrderMapper(MappingFileMapperBase):
         return composite_order
 
     def validate_po_number(
-            self,
-            index_or_id: str,
-            po_number: str,
+        self,
+        index_or_id: str,
+        po_number: str,
     ):
         if not self.is_valid_po_number(po_number):
             self.migration_report.add(

folio_migration_tools/mapping_file_transformation/organization_mapper.py

@@ -330,9 +330,9 @@ class OrganizationMapper(MappingFileMapperBase):
                         ["username", "password", "interfaceId"],
                     )
 
-                    interface_schema["properties"][
-                        "interfaceCredential"
-                    ] = interface_credential_schema
+                    interface_schema["properties"]["interfaceCredential"] = (
+                        interface_credential_schema
+                    )
 
                     property_level1["items"] = interface_schema
 

folio_migration_tools/mapping_file_transformation/user_mapper.py

@@ -47,7 +47,7 @@ class UserMapper(MappingFileMapperBase):
                 None,
                 FOLIONamespaces.users,
                 library_config,
-                task_config
+                task_config,
             )
             self.task_config = self.task_configuration
             self.notes_mapper: NotesMapper = NotesMapper(
@@ -115,6 +115,10 @@ class UserMapper(MappingFileMapperBase):
 
         if self.task_config.remove_request_preferences:
             del clean_folio_object["requestPreference"]
+
+        if self.task_config.remove_username:
+            del clean_folio_object["username"]
+
         self.report_folio_mapping_no_schema(clean_folio_object)
         self.report_legacy_mapping_no_schema(legacy_user)
 
@@ -157,18 +161,25 @@ class UserMapper(MappingFileMapperBase):
                     "No Departments mapping set up. Set up a departments mapping file "
                     " or remove the mapping of the Departments field",
                 )
-            if len(self.departments_mapping.mapped_legacy_keys) == 1 and self.library_configuration.multi_field_delimiter in legacy_user.get(self.departments_mapping.mapped_legacy_keys[0], ""):
-                split_departments = legacy_user.get(self.departments_mapping.mapped_legacy_keys[0], "").split(
-                    self.library_configuration.multi_field_delimiter
+            if len(
+                self.departments_mapping.mapped_legacy_keys
+            ) == 1 and self.library_configuration.multi_field_delimiter in legacy_user.get(
+                self.departments_mapping.mapped_legacy_keys[0], ""
+            ):
+                split_departments = legacy_user.get(
+                    self.departments_mapping.mapped_legacy_keys[0], ""
+                ).split(self.library_configuration.multi_field_delimiter)
+                return self.library_configuration.multi_field_delimiter.join(
+                    [
+                        self.get_mapped_name(
+                            self.departments_mapping,
+                            {self.departments_mapping.mapped_legacy_keys[0]: dept},
+                            index_or_id,
+                            True,
+                        )
+                        for dept in split_departments
+                    ]
                 )
-                return self.library_configuration.multi_field_delimiter.join([
-                    self.get_mapped_name(
-                        self.departments_mapping,
-                        {self.departments_mapping.mapped_legacy_keys[0]: dept},
-                        index_or_id,
-                        True,
-                    ) for dept in split_departments
-                ])
             else:
                 return self.get_mapped_name(
                     self.departments_mapping,
@@ -198,21 +209,29 @@ class UserMapper(MappingFileMapperBase):
             return ""
 
     def setup_groups_mapping(self, groups_map):
-        return RefDataMapping(
-            self.folio_client,
-            "/groups",
-            "usergroups",
-            groups_map,
-            "group",
-            "UserGroupMapping",
-        ) if groups_map else None
+        return (
+            RefDataMapping(
+                self.folio_client,
+                "/groups",
+                "usergroups",
+                groups_map,
+                "group",
+                "UserGroupMapping",
+            )
+            if groups_map
+            else None
+        )
 
     def setup_departments_mapping(self, departments_mapping):
-        return RefDataMapping(
-            self.folio_client,
-            "/departments",
-            "departments",
-            departments_mapping,
-            "name",
-            "DepartmentsMapping",
-        ) if departments_mapping else None
+        return (
+            RefDataMapping(
+                self.folio_client,
+                "/departments",
+                "departments",
+                departments_mapping,
+                "name",
+                "DepartmentsMapping",
+            )
+            if departments_mapping
+            else None
+        )