flyte 2.0.0b13__py3-none-any.whl → 2.0.0b30__py3-none-any.whl

flyte/remote/_action.py

@@ -20,14 +20,15 @@ from typing import (
 import grpc
 import rich.pretty
 import rich.repr
+from flyteidl2.common import identifier_pb2, list_pb2
+from flyteidl2.task import common_pb2
+from flyteidl2.workflow import run_definition_pb2, run_service_pb2
+from flyteidl2.workflow.run_service_pb2 import WatchActionDetailsResponse
 from rich.console import Console
 from rich.progress import Progress, SpinnerColumn, TextColumn, TimeElapsedColumn
 
 from flyte import types
-from flyte._initialize import ensure_client, get_client, get_common_config
-from flyte._protos.common import identifier_pb2, list_pb2
-from flyte._protos.workflow import run_definition_pb2, run_service_pb2
-from flyte._protos.workflow.run_service_pb2 import WatchActionDetailsResponse
+from flyte._initialize import ensure_client, get_client, get_init_config
 from flyte.remote._common import ToJSONMixin
 from flyte.remote._logs import Logs
 from flyte.syncify import syncify
@@ -67,14 +68,14 @@ def _action_rich_repr(action: run_definition_pb2.Action) -> rich.repr.Result:
     """
     Rich representation of the action.
     """
-    yield "run", action.id.run.name
+    yield "name", action.id.run.name
     if action.metadata.HasField("task"):
-        yield "task", action.metadata.task.id.name
+        yield "task name", action.metadata.task.id.name
         yield "type", action.metadata.task.task_type
     elif action.metadata.HasField("trace"):
         yield "trace", action.metadata.trace.name
         yield "type", "trace"
-    yield "name", action.id.name
+    yield "action name", action.id.name
     yield from _action_time_phase(action)
     yield "group", action.metadata.group
     yield "parent", action.metadata.parent
@@ -98,9 +99,10 @@ def _action_details_rich_repr(
     """
     yield "name", action.id.run.name
     yield from _action_time_phase(action)
-    yield "task", action.resolved_task_spec.task_template.id.name
-    yield "task_type", action.resolved_task_spec.task_template.type
-    yield "task_version", action.resolved_task_spec.task_template.id.version
+    if action.HasField("task"):
+        yield "task", action.task.task_template.id.name
+        yield "task_type", action.task.task_template.type
+        yield "task_version", action.task.task_template.id.version
     yield "attempts", action.attempts
     yield "error", (f"{action.error_info.kind}: {action.error_info.message}" if action.HasField("error_info") else "NA")
     yield "phase", run_definition_pb2.Phase.Name(action.status.phase)
@@ -152,7 +154,7 @@ class Action(ToJSONMixin):
             key=sort_by[0],
             direction=(list_pb2.Sort.ASCENDING if sort_by[1] == "asc" else list_pb2.Sort.DESCENDING),
         )
-        cfg = get_common_config()
+        cfg = get_init_config()
         while True:
             req = list_pb2.ListRequest(
                 limit=100,
@@ -193,7 +195,7 @@ class Action(ToJSONMixin):
         :param name: The name of the action.
         """
         ensure_client()
-        cfg = get_common_config()
+        cfg = get_init_config()
         details: ActionDetails = await ActionDetails.get_details.aio(
             identifier_pb2.ActionIdentifier(
                 run=identifier_pb2.RunIdentifier(
@@ -327,9 +329,10 @@ class Action(ToJSONMixin):
                     )
                 else:
                     details = await self.details()
+                    error_message = details.error_info.message if details.error_info else ""
                     console.print(
                         f"[bold red]Action '{self.name}' in Run '{self.run_name}'"
-                        f" exited unsuccessfully in state {self.phase} with error: {details.error_info}[/bold red]"
+                        f" exited unsuccessfully in state {self.phase} with error: {error_message}[/bold red]"
                     )
             return
 
@@ -368,13 +371,15 @@ class Action(ToJSONMixin):
                     # If the action is done, handle the final state
                     if ad.done():
                         progress.stop_task(task_id)
-                        if ad.pb2.status.phase == run_definition_pb2.PHASE_SUCCEEDED:
-                            console.print(f"[bold green]Run '{self.run_name}' completed successfully.[/bold green]")
-                        else:
-                            console.print(
-                                f"[bold red]Run '{self.run_name}' exited unsuccessfully in state {ad.phase}"
-                                f" with error: {ad.error_info}[/bold red]"
-                            )
+                        if not quiet:
+                            if ad.pb2.status.phase == run_definition_pb2.PHASE_SUCCEEDED:
+                                console.print(f"[bold green]Run '{self.run_name}' completed successfully.[/bold green]")
+                            else:
+                                error_message = ad.error_info.message if ad.error_info else ""
+                                console.print(
+                                    f"[bold red]Run '{self.run_name}' exited unsuccessfully in state {ad.phase}"
+                                    f" with error: {error_message}[/bold red]"
+                                )
                         break
         except asyncio.CancelledError:
             # Handle cancellation gracefully
@@ -455,7 +460,7 @@ class ActionDetails(ToJSONMixin):
         ensure_client()
         if not uri:
             assert name is not None and run_name is not None, "Either uri or name and run_name must be provided"
-        cfg = get_common_config()
+        cfg = get_init_config()
         return await cls.get_details.aio(
             identifier_pb2.ActionIdentifier(
                 run=identifier_pb2.RunIdentifier(
@@ -627,8 +632,11 @@ class ActionDetails(ToJSONMixin):
             )
         )
         native_iface = None
-        if self.pb2.resolved_task_spec:
-            iface = self.pb2.resolved_task_spec.task_template.interface
+        if self.pb2.HasField("task"):
+            iface = self.pb2.task.task_template.interface
+            native_iface = types.guess_interface(iface)
+        elif self.pb2.HasField("trace"):
+            iface = self.pb2.trace.interface
             native_iface = types.guess_interface(iface)
 
         if resp.inputs:
@@ -700,7 +708,7 @@ class ActionInputs(UserDict, ToJSONMixin):
     remote Union API.
     """
 
-    pb2: run_definition_pb2.Inputs
+    pb2: common_pb2.Inputs
     data: Dict[str, Any]
 
     def __repr__(self):
@@ -717,14 +725,14 @@ class ActionOutputs(tuple, ToJSONMixin):
     remote Union API.
     """
 
-    def __new__(cls, pb2: run_definition_pb2.Outputs, data: Tuple[Any, ...]):
+    def __new__(cls, pb2: common_pb2.Outputs, data: Tuple[Any, ...]):
         # Create the tuple part
         obj = super().__new__(cls, data)
         # Store extra data (you can't do this here directly since it's immutable)
         obj.pb2 = pb2
         return obj
 
-    def __init__(self, pb2: run_definition_pb2.Outputs, data: Tuple[Any, ...]):
+    def __init__(self, pb2: common_pb2.Outputs, data: Tuple[Any, ...]):
         # Normally you'd set instance attributes here,
         # but we've already set `pb2` in `__new__`
         self.pb2 = pb2

flyte/remote/_client/_protocols.py

@@ -1,13 +1,14 @@
 from typing import AsyncIterator, Protocol
 
 from flyteidl.admin import project_attributes_pb2, project_pb2, version_pb2
-from flyteidl.service import dataproxy_pb2
+from flyteidl.service import dataproxy_pb2, identity_pb2
+from flyteidl2.secret import payload_pb2
+from flyteidl2.task import task_service_pb2
+from flyteidl2.trigger import trigger_service_pb2
+from flyteidl2.workflow import run_logs_service_pb2, run_service_pb2
 from grpc.aio import UnaryStreamCall
 from grpc.aio._typing import RequestType
 
-from flyte._protos.secret import payload_pb2
-from flyte._protos.workflow import run_logs_service_pb2, run_service_pb2, task_service_pb2
-
 
 class MetadataServiceProtocol(Protocol):
     async def GetVersion(self, request: version_pb2.GetVersionRequest) -> version_pb2.GetVersionResponse: ...
@@ -131,3 +132,37 @@ class SecretService(Protocol):
     async def ListSecrets(self, request: payload_pb2.ListSecretsRequest) -> payload_pb2.ListSecretsResponse: ...
 
     async def DeleteSecret(self, request: payload_pb2.DeleteSecretRequest) -> payload_pb2.DeleteSecretResponse: ...
+
+
+class IdentityService(Protocol):
+    async def UserInfo(self, request: identity_pb2.UserInfoRequest) -> identity_pb2.UserInfoResponse: ...
+
+
+class TriggerService(Protocol):
+    async def DeployTrigger(
+        self, request: trigger_service_pb2.DeployTriggerRequest
+    ) -> trigger_service_pb2.DeployTriggerResponse: ...
+
+    async def GetTriggerDetails(
+        self, request: trigger_service_pb2.GetTriggerDetailsRequest
+    ) -> trigger_service_pb2.GetTriggerDetailsResponse: ...
+
+    async def GetTriggerRevisionDetails(
+        self, request: trigger_service_pb2.GetTriggerRevisionDetailsRequest
+    ) -> trigger_service_pb2.GetTriggerRevisionDetailsResponse: ...
+
+    async def ListTriggers(
+        self, request: trigger_service_pb2.ListTriggersRequest
+    ) -> trigger_service_pb2.ListTriggersResponse: ...
+
+    async def GetTriggerRevisionHistory(
+        self, request: trigger_service_pb2.GetTriggerRevisionHistoryRequest
+    ) -> trigger_service_pb2.GetTriggerRevisionHistoryResponse: ...
+
+    async def UpdateTriggers(
+        self, request: trigger_service_pb2.UpdateTriggersRequest
+    ) -> trigger_service_pb2.UpdateTriggersResponse: ...
+
+    async def DeleteTriggers(
+        self, request: trigger_service_pb2.DeleteTriggersRequest
+    ) -> trigger_service_pb2.DeleteTriggersResponse: ...

flyte/remote/_client/auth/_authenticators/device_code.py

@@ -1,4 +1,4 @@
-import click
+from rich import print as rich_print
 
 from flyte._logging import logger
 from flyte.remote._client.auth import _token_client as token_client
@@ -81,7 +81,7 @@ class DeviceCodeAuthenticator(Authenticator):
                     for_endpoint=self._endpoint,
                 )
             except (AuthenticationError, AuthenticationPending):
-                logger.warning("Failed to refresh token. Kicking off a full authorization flow.")
+                logger.warning("Logging in...")
 
         """Fall back to device flow"""
         resp = await token_client.get_device_code(
@@ -94,10 +94,9 @@ class DeviceCodeAuthenticator(Authenticator):
 
         full_uri = f"{resp.verification_uri}?user_code={resp.user_code}"
         text = (
-            f"To Authenticate, navigate in a browser to the following URL: "
-            f"{click.style(full_uri, fg='blue', underline=True)}"
+            f"To Authenticate, navigate in a browser to the following URL: [blue link={full_uri}]{full_uri}[/blue link]"
         )
-        click.secho(text)
+        rich_print(text)
         try:
             token, refresh_token, expires_in = await token_client.poll_token_endpoint(
                 resp,

flyte/remote/_client/auth/_authenticators/pkce.py

@@ -123,7 +123,7 @@ class PKCEAuthenticator(Authenticator):
             try:
                 return await self._auth_client.refresh_access_token(self._creds)
             except AccessTokenNotFoundError:
-                logger.warning("Failed to refresh token. Kicking off a full authorization flow.")
+                logger.warning("Logging in...")
 
         return await self._auth_client.get_creds_from_remote()
 

flyte/remote/_client/auth/_channel.py

@@ -7,6 +7,7 @@ import httpx
 from grpc.experimental.aio import init_grpc_aio
 
 from flyte._logging import logger
+from flyte._utils.org_discovery import hostname_from_url
 
 from ._authenticators.base import get_async_session
 from ._authenticators.factory import (
@@ -30,16 +31,19 @@ def bootstrap_ssl_from_server(endpoint: str) -> grpc.ChannelCredentials:
     :param endpoint: The endpoint URL to retrieve the SSL certificate from, may include port number
     :return: gRPC channel credentials created from the retrieved certificate
     """
+    hostname = hostname_from_url(endpoint)
+
     # Get port from endpoint or use 443
-    endpoint_parts = endpoint.rsplit(":", 1)
+    endpoint_parts = hostname.rsplit(":", 1)
     if len(endpoint_parts) == 2 and endpoint_parts[1].isdigit():
         server_address = (endpoint_parts[0], int(endpoint_parts[1]))
     else:
-        logger.warning(f"Unrecognized port in endpoint [{endpoint}], defaulting to 443.")
-        server_address = (endpoint, 443)
+        logger.warning(f"Unrecognized port in endpoint [{hostname}], defaulting to 443.")
+        server_address = (hostname, 443)
 
-    # Run the blocking SSL certificate retrieval in a thread pool
-    cert = ssl.get_server_certificate(server_address)
+    # Run the blocking SSL certificate retrieval with a timeout
+    logger.debug(f"Retrieving SSL certificate from {server_address}")
+    cert = ssl.get_server_certificate(server_address, timeout=10)
     return grpc.ssl_channel_credentials(str.encode(cert))
 
 
@@ -112,7 +116,7 @@ async def create_channel(
     if api_key:
         from flyte.remote._client.auth._auth_utils import decode_api_key
 
-        endpoint, client_id, client_secret, org = decode_api_key(api_key)
+        endpoint, client_id, client_secret, _org = decode_api_key(api_key)
         kwargs["auth_type"] = "ClientSecret"
         kwargs["client_id"] = client_id
         kwargs["client_secret"] = client_secret

flyte/remote/_client/controlplane.py

@@ -15,19 +15,22 @@ if "GRPC_VERBOSITY" not in os.environ:
 #### Has to be before grpc
 
 import grpc
-from flyteidl.service import admin_pb2_grpc, dataproxy_pb2_grpc
-
-from flyte._protos.secret import secret_pb2_grpc
-from flyte._protos.workflow import run_logs_service_pb2_grpc, run_service_pb2_grpc, task_service_pb2_grpc
+from flyteidl.service import admin_pb2_grpc, dataproxy_pb2_grpc, identity_pb2_grpc
+from flyteidl2.secret import secret_pb2_grpc
+from flyteidl2.task import task_service_pb2_grpc
+from flyteidl2.trigger import trigger_service_pb2_grpc
+from flyteidl2.workflow import run_logs_service_pb2_grpc, run_service_pb2_grpc
 
 from ._protocols import (
     DataProxyService,
+    IdentityService,
     MetadataServiceProtocol,
     ProjectDomainService,
     RunLogsService,
     RunService,
     SecretService,
     TaskService,
+    TriggerService,
 )
 from .auth import create_channel
 
@@ -38,7 +41,6 @@ class ClientSet:
         channel: grpc.aio.Channel,
         endpoint: str,
         insecure: bool = False,
-        data_proxy_channel: grpc.aio.Channel | None = None,
         **kwargs,
     ):
         self.endpoint = endpoint
@@ -50,6 +52,8 @@ class ClientSet:
         self._dataproxy = dataproxy_pb2_grpc.DataProxyServiceStub(channel=channel)
         self._log_service = run_logs_service_pb2_grpc.RunLogsServiceStub(channel=channel)
         self._secrets_service = secret_pb2_grpc.SecretServiceStub(channel=channel)
+        self._identity_service = identity_pb2_grpc.IdentityServiceStub(channel=channel)
+        self._trigger_service = trigger_service_pb2_grpc.TriggerServiceStub(channel=channel)
 
     @classmethod
     async def for_endpoint(cls, endpoint: str, *, insecure: bool = False, **kwargs) -> ClientSet:
@@ -105,5 +109,13 @@ class ClientSet:
     def secrets_service(self) -> SecretService:
         return self._secrets_service
 
+    @property
+    def identity_service(self) -> IdentityService:
+        return self._identity_service
+
+    @property
+    def trigger_service(self) -> TriggerService:
+        return self._trigger_service
+
     async def close(self, grace: float | None = None):
         return await self._channel.close(grace=grace)

flyte/remote/_console.py

@@ -9,8 +9,9 @@ def _get_http_domain(endpoint: str, insecure: bool) -> str:
     else:
         domain = parsed.netloc or parsed.path
     # TODO: make console url configurable
-    if domain.split(":")[0] == "localhost":
-        domain = "localhost:8080"
+    domain_split = domain.split(":")
+    if domain_split[0] == "localhost":
+        domain = domain if len(domain_split) > 1 else f"{domain}:8080"
     return f"{scheme}://{domain}"
 
 

flyte/remote/_data.py

@@ -15,8 +15,7 @@ import httpx
 from flyteidl.service import dataproxy_pb2
 from google.protobuf import duration_pb2
 
-from flyte._initialize import CommonInit, ensure_client, get_client, get_common_config
-from flyte._logging import make_hyperlink
+from flyte._initialize import CommonInit, ensure_client, get_client, get_init_config, require_project_and_domain
 from flyte.errors import InitializationError, RuntimeSystemError
 from flyte.syncify import syncify
 
@@ -55,6 +54,7 @@ def hash_file(file_path: typing.Union[os.PathLike, str]) -> Tuple[bytes, str, in
     return h.digest(), h.hexdigest(), size
 
 
+@require_project_and_domain
 async def _upload_single_file(
     cfg: CommonInit, fp: Path, verify: bool = True, basedir: str | None = None
 ) -> Tuple[str, str]:
@@ -91,7 +91,7 @@ async def _upload_single_file(
             raise RuntimeSystemError(e.code().value, f"Failed to get signed url for {fp}: {e.details()}")
     except Exception as e:
         raise RuntimeSystemError(type(e).__name__, f"Failed to get signed url for {fp}.") from e
-    logger.debug(f"Uploading to {make_hyperlink('signed url', resp.signed_url)} for {fp}")
+    logger.debug(f"Uploading to [link={resp.signed_url}]signed url[/link] for [link=file://{fp}]{fp}[/link]")
     extra_headers = get_extra_headers_for_protocol(resp.native_url)
     extra_headers.update(resp.headers)
     encoded_md5 = b64encode(md5_bytes)
@@ -101,7 +101,7 @@ async def _upload_single_file(
         extra_headers.update({"Content-Length": str(content_length), "Content-MD5": encoded_md5.decode("utf-8")})
         async with httpx.AsyncClient(verify=verify) as aclient:
             put_resp = await aclient.put(resp.signed_url, headers=extra_headers, content=file)
-            if put_resp.status_code != 200:
+            if put_resp.status_code not in [200, 201, 204]:
                 raise RuntimeSystemError(
                     "UploadFailed",
                     f"Failed to upload {fp} to {resp.signed_url}, status code: {put_resp.status_code}, "
@@ -125,7 +125,7 @@ async def upload_file(fp: Path, verify: bool = True) -> Tuple[str, str]:
     """
     # This is a placeholder implementation. Replace with actual upload logic.
     ensure_client()
-    cfg = get_common_config()
+    cfg = get_init_config()
     if not fp.is_file():
         raise ValueError(f"{fp} is not a single file, upload arg must be a single file.")
     return await _upload_single_file(cfg, fp, verify=verify)
@@ -141,7 +141,7 @@ async def upload_dir(dir_path: Path, verify: bool = True) -> str:
     """
     # This is a placeholder implementation. Replace with actual upload logic.
     ensure_client()
-    cfg = get_common_config()
+    cfg = get_init_config()
     if not dir_path.is_dir():
         raise ValueError(f"{dir_path} is not a directory, upload arg must be a directory.")
 

flyte/remote/_logs.py

@@ -4,6 +4,9 @@ from dataclasses import dataclass
 from typing import AsyncGenerator, AsyncIterator
 
 import grpc
+from flyteidl2.common import identifier_pb2
+from flyteidl2.logs.dataplane import payload_pb2
+from flyteidl2.workflow import run_logs_service_pb2
 from rich.console import Console
 from rich.live import Live
 from rich.panel import Panel
@@ -11,9 +14,6 @@ from rich.text import Text
 
 from flyte._initialize import ensure_client, get_client
 from flyte._logging import logger
-from flyte._protos.common import identifier_pb2
-from flyte._protos.logs.dataplane import payload_pb2
-from flyte._protos.workflow import run_logs_service_pb2
 from flyte._tools import ipython_check, ipywidgets_check
 from flyte.errors import LogsNotYetAvailableError
 from flyte.syncify import syncify

flyte/remote/_run.py

@@ -5,10 +5,11 @@ from typing import AsyncGenerator, AsyncIterator, Literal, Tuple
 
 import grpc
 import rich.repr
+from flyteidl2.common import identifier_pb2, list_pb2
+from flyteidl2.workflow import run_definition_pb2, run_service_pb2
 
-from flyte._initialize import ensure_client, get_client, get_common_config
-from flyte._protos.common import identifier_pb2, list_pb2
-from flyte._protos.workflow import run_definition_pb2, run_service_pb2
+from flyte._initialize import ensure_client, get_client, get_init_config
+from flyte._logging import logger
 from flyte.syncify import syncify
 
 from . import Action, ActionDetails, ActionInputs, ActionOutputs
@@ -16,6 +17,11 @@ from ._action import _action_details_rich_repr, _action_rich_repr
 from ._common import ToJSONMixin
 from ._console import get_run_url
 
+# @kumare3 is sadpanda, because we have to create a mirror of phase types here, because protobuf phases are ghastly
+Phase = Literal[
+    "queued", "waiting_for_resources", "initializing", "running", "succeeded", "failed", "aborted", "timed_out"
+]
+
 
 @dataclass
 class Run(ToJSONMixin):
@@ -40,14 +46,16 @@ class Run(ToJSONMixin):
     @classmethod
     async def listall(
         cls,
-        filters: str | None = None,
+        in_phase: Tuple[Phase] | None = None,
+        created_by_subject: str | None = None,
         sort_by: Tuple[str, Literal["asc", "desc"]] | None = None,
         limit: int = 100,
     ) -> AsyncIterator[Run]:
         """
         Get all runs for the current project and domain.
 
-        :param filters: The filters to apply to the project list.
+        :param in_phase: Filter runs by one or more phases.
+        :param created_by_subject: Filter runs by the subject that created them. (this is not username, but the subject)
         :param sort_by: The sorting criteria for the project list, in the format (field, order).
         :param limit: The maximum number of runs to return.
         :return: An iterator of runs.
@@ -59,13 +67,44 @@ class Run(ToJSONMixin):
             key=sort_by[0],
             direction=(list_pb2.Sort.ASCENDING if sort_by[1] == "asc" else list_pb2.Sort.DESCENDING),
         )
-        cfg = get_common_config()
+        filters = []
+        if in_phase:
+            phases = [str(run_definition_pb2.Phase.Value(f"PHASE_{p.upper()}")) for p in in_phase]
+            logger.debug(f"Fetching run phases: {phases}")
+            if len(phases) > 1:
+                filters.append(
+                    list_pb2.Filter(
+                        function=list_pb2.Filter.Function.VALUE_IN,
+                        field="phase",
+                        values=phases,
+                    ),
+                )
+            else:
+                filters.append(
+                    list_pb2.Filter(
+                        function=list_pb2.Filter.Function.EQUAL,
+                        field="phase",
+                        values=phases[0],
+                    ),
+                )
+        if created_by_subject:
+            logger.debug(f"Fetching runs created by: {created_by_subject}")
+            filters.append(
+                list_pb2.Filter(
+                    function=list_pb2.Filter.Function.EQUAL,
+                    field="created_by",
+                    values=[created_by_subject],
+                ),
+            )
+
+        cfg = get_init_config()
         i = 0
         while True:
             req = list_pb2.ListRequest(
                 limit=min(100, limit),
                 token=token,
                 sort_by=sort_pb2,
+                filters=filters,
             )
             resp = await get_client().run_service.ListRuns(
                 run_service_pb2.ListRunsRequest(
@@ -157,10 +196,26 @@ class Run(ToJSONMixin):
         """
         Get the details of the run. This is a placeholder for getting the run details.
         """
-        if self._details is None:
+        if self._details is None or not self._details.done():
             self._details = await RunDetails.get_details.aio(self.pb2.action.id.run)
         return self._details
 
+    @syncify
+    async def inputs(self) -> ActionInputs:
+        """
+        Get the inputs of the run. This is a placeholder for getting the run inputs.
+        """
+        details = await self.details.aio()
+        return await details.inputs()
+
+    @syncify
+    async def outputs(self) -> ActionOutputs:
+        """
+        Get the outputs of the run. This is a placeholder for getting the run outputs.
+        """
+        details = await self.details.aio()
+        return await details.outputs()
+
     @property
     def url(self) -> str:
         """
@@ -209,6 +264,7 @@ class Run(ToJSONMixin):
         """
         Rich representation of the Run object.
         """
+        yield "url", f"[blue bold][link={self.url}]link[/link][/blue bold]"
         yield from _action_rich_repr(self.pb2.action)
 
     def __repr__(self) -> str:
@@ -260,7 +316,7 @@ class RunDetails(ToJSONMixin):
         :param name: The name of the run.
         """
         ensure_client()
-        cfg = get_common_config()
+        cfg = get_init_config()
         return await RunDetails.get_details.aio(
             run_id=identifier_pb2.RunIdentifier(
                 org=cfg.org,

flyte/remote/_secret.py

@@ -4,9 +4,9 @@ from dataclasses import dataclass
 from typing import AsyncIterator, Literal, Union
 
 import rich.repr
+from flyteidl2.secret import definition_pb2, payload_pb2
 
-from flyte._initialize import ensure_client, get_client, get_common_config
-from flyte._protos.secret import definition_pb2, payload_pb2
+from flyte._initialize import ensure_client, get_client, get_init_config
 from flyte.remote._common import ToJSONMixin
 from flyte.syncify import syncify
 
@@ -21,12 +21,19 @@ class Secret(ToJSONMixin):
     @classmethod
     async def create(cls, name: str, value: Union[str, bytes], type: SecretTypes = "regular"):
         ensure_client()
-        cfg = get_common_config()
-        secret_type = (
-            definition_pb2.SecretType.SECRET_TYPE_GENERIC
-            if type == "regular"
-            else definition_pb2.SecretType.SECRET_TYPE_IMAGE_PULL_SECRET
-        )
+        cfg = get_init_config()
+        project = cfg.project
+        domain = cfg.domain
+
+        if type == "regular":
+            secret_type = definition_pb2.SecretType.SECRET_TYPE_GENERIC
+
+        else:
+            secret_type = definition_pb2.SecretType.SECRET_TYPE_IMAGE_PULL_SECRET
+            if project or domain:
+                raise ValueError(
+                    f"Project `{project}` or domain `{domain}` should not be set when creating the image pull secret."
+                )
 
         if isinstance(value, str):
             secret = definition_pb2.SecretSpec(
@@ -42,8 +49,8 @@ class Secret(ToJSONMixin):
             request=payload_pb2.CreateSecretRequest(
                 id=definition_pb2.SecretIdentifier(
                     organization=cfg.org,
-                    project=cfg.project,
-                    domain=cfg.domain,
+                    project=project,
+                    domain=domain,
                     name=name,
                 ),
                 secret_spec=secret,
@@ -54,7 +61,7 @@ class Secret(ToJSONMixin):
     @classmethod
     async def get(cls, name: str) -> Secret:
         ensure_client()
-        cfg = get_common_config()
+        cfg = get_init_config()
         resp = await get_client().secrets_service.GetSecret(
             request=payload_pb2.GetSecretRequest(
                 id=definition_pb2.SecretIdentifier(
@@ -71,29 +78,31 @@ class Secret(ToJSONMixin):
     @classmethod
     async def listall(cls, limit: int = 100) -> AsyncIterator[Secret]:
         ensure_client()
-        cfg = get_common_config()
-        token = None
+        cfg = get_init_config()
+        per_cluster_tokens = None
         while True:
             resp = await get_client().secrets_service.ListSecrets(  # type: ignore
                 request=payload_pb2.ListSecretsRequest(
                     organization=cfg.org,
                     project=cfg.project,
                     domain=cfg.domain,
-                    token=token,
+                    per_cluster_tokens=per_cluster_tokens,
                     limit=limit,
                 ),
             )
-            token = resp.token
+            per_cluster_tokens = resp.per_cluster_tokens
+            round_items = [v for _, v in per_cluster_tokens.items() if v]
+            has_next = any(round_items)
             for r in resp.secrets:
                 yield cls(r)
-            if not token:
+            if not has_next:
                 break
 
     @syncify
     @classmethod
     async def delete(cls, name):
         ensure_client()
-        cfg = get_common_config()
+        cfg = get_init_config()
         await get_client().secrets_service.DeleteSecret(  # type: ignore
             request=payload_pb2.DeleteSecretRequest(
                 id=definition_pb2.SecretIdentifier(