flwr-nightly 1.19.0.dev20250616__py3-none-any.whl → 1.20.0.dev20250618__py3-none-any.whl

flwr/superexec/exec_grpc.py

@@ -27,8 +27,8 @@ from flwr.common.grpc import generic_create_grpc_server
 from flwr.common.logger import log
 from flwr.common.typing import UserConfig
 from flwr.proto.exec_pb2_grpc import add_ExecServicer_to_server
-from flwr.server.superlink.ffs.ffs_factory import FfsFactory
 from flwr.server.superlink.linkstate import LinkStateFactory
+from flwr.supercore.ffs import FfsFactory
 from flwr.supercore.object_store import ObjectStoreFactory
 from flwr.superexec.exec_event_log_interceptor import ExecEventLogInterceptor
 from flwr.superexec.exec_user_auth_interceptor import ExecUserAuthInterceptor

flwr/superexec/exec_servicer.py

@@ -52,8 +52,8 @@ from flwr.proto.exec_pb2 import (  # pylint: disable=E0611
     StreamLogsRequest,
     StreamLogsResponse,
 )
-from flwr.server.superlink.ffs.ffs_factory import FfsFactory
 from flwr.server.superlink.linkstate import LinkState, LinkStateFactory
+from flwr.supercore.ffs import FfsFactory
 from flwr.supercore.object_store import ObjectStore, ObjectStoreFactory
 
 from .exec_user_auth_interceptor import shared_account_info

flwr/superexec/executor.py

@@ -22,8 +22,8 @@ from typing import Optional
 
 from flwr.common import ConfigRecord
 from flwr.common.typing import UserConfig
-from flwr.server.superlink.ffs.ffs_factory import FfsFactory
 from flwr.server.superlink.linkstate import LinkStateFactory
+from flwr.supercore.ffs import FfsFactory
 
 
 @dataclass

flwr/superexec/simulation.py

@@ -25,9 +25,8 @@ from flwr.cli.config_utils import get_fab_metadata
 from flwr.common import ConfigRecord, Context, RecordDict
 from flwr.common.logger import log
 from flwr.common.typing import Fab, UserConfig
-from flwr.server.superlink.ffs import Ffs
-from flwr.server.superlink.ffs.ffs_factory import FfsFactory
 from flwr.server.superlink.linkstate import LinkState, LinkStateFactory
+from flwr.supercore.ffs import Ffs, FfsFactory
 
 from .executor import Executor
 

flwr/supernode/cli/flwr_clientapp.py

@@ -44,7 +44,7 @@ def flwr_clientapp() -> None:
     )
     run_clientapp(
         clientappio_api_address=args.clientappio_api_address,
-        run_once=(args.token is not None),
+        run_once=(args.token is not None) or args.run_once,
         token=args.token,
         flwr_dir=args.flwr_dir,
         certificates=None,
@@ -66,7 +66,7 @@ def _parse_args_run_flwr_clientapp() -> argparse.ArgumentParser:
     )
     parser.add_argument(
         "--token",
-        type=int,
+        type=str,
         required=False,
         help="Unique token generated by SuperNode for each ClientApp execution",
     )
@@ -77,5 +77,11 @@ def _parse_args_run_flwr_clientapp() -> argparse.ArgumentParser:
         help="The PID of the parent process. When set, the process will terminate "
         "when the parent process exits.",
     )
+    parser.add_argument(
+        "--run-once",
+        action="store_true",
+        help="When set, this process will start a single ClientApp for a pending "
+        "message. If there is no pending message, the process will exit.",
+    )
     add_args_flwr_app_common(parser=parser)
     return parser

flwr/supernode/nodestate/in_memory_nodestate.py

@@ -51,8 +51,9 @@ class InMemoryNodeState(NodeState):  # pylint: disable=too-many-instance-attribu
         # Store run ID to Context mapping
         self.ctx_store: dict[int, Context] = {}
         self.lock_ctx_store = Lock()
-        # Store run ID to token mapping
+        # Store run ID to token mapping and token to run ID mapping
         self.token_store: dict[int, str] = {}
+        self.token_to_run_id: dict[str, int] = {}
         self.lock_token_store = Lock()
 
     def set_node_id(self, node_id: Optional[int]) -> None:
@@ -177,6 +178,7 @@ class InMemoryNodeState(NodeState):  # pylint: disable=too-many-instance-attribu
             if run_id in self.token_store:
                 raise ValueError("Token already created for this run ID")
             self.token_store[run_id] = token
+            self.token_to_run_id[token] = run_id
         return token
 
     def verify_token(self, run_id: int, token: str) -> bool:
@@ -187,4 +189,11 @@ class InMemoryNodeState(NodeState):  # pylint: disable=too-many-instance-attribu
     def delete_token(self, run_id: int) -> None:
         """Delete the token for the given run ID."""
         with self.lock_token_store:
-            self.token_store.pop(run_id, None)
+            token = self.token_store.pop(run_id, None)
+            if token is not None:
+                self.token_to_run_id.pop(token, None)
+
+    def get_run_id_by_token(self, token: str) -> Optional[int]:
+        """Get the run ID associated with a given token."""
+        with self.lock_token_store:
+            return self.token_to_run_id.get(token)

flwr/supernode/nodestate/nodestate.py

@@ -210,3 +210,18 @@ class NodeState(ABC):
         run_id : int
             The ID of the run for which to delete the token.
         """
+
+    @abstractmethod
+    def get_run_id_by_token(self, token: str) -> Optional[int]:
+        """Get the run ID associated with a given token.
+
+        Parameters
+        ----------
+        token : str
+            The token to look up.
+
+        Returns
+        -------
+        Optional[int]
+            The run ID if the token is valid, otherwise None.
+        """

flwr/supernode/runtime/run_clientapp.py

@@ -46,12 +46,14 @@ from flwr.common.typing import Fab, Run
 
 # pylint: disable=E0611
 from flwr.proto.clientappio_pb2 import (
-    GetTokenRequest,
-    GetTokenResponse,
+    GetRunIdsWithPendingMessagesRequest,
+    GetRunIdsWithPendingMessagesResponse,
     PullClientAppInputsRequest,
     PullClientAppInputsResponse,
     PushClientAppOutputsRequest,
     PushClientAppOutputsResponse,
+    RequestTokenRequest,
+    RequestTokenResponse,
 )
 from flwr.proto.clientappio_pb2_grpc import ClientAppIoStub
 
@@ -59,7 +61,7 @@ from flwr.proto.clientappio_pb2_grpc import ClientAppIoStub
 def run_clientapp(  # pylint: disable=R0913, R0914, R0917
     clientappio_api_address: str,
     run_once: bool,
-    token: Optional[int] = None,
+    token: Optional[str] = None,
     flwr_dir: Optional[str] = None,
     certificates: Optional[bytes] = None,
     parent_pid: Optional[int] = None,
@@ -84,9 +86,8 @@ def run_clientapp(  # pylint: disable=R0913, R0914, R0917
 
         while True:
             # If token is not set, loop until token is received from SuperNode
-            while token is None:
+            if token is None:
                 token = get_token(stub)
-                time.sleep(1)
 
             # Pull Message, Context, Run and (optional) FAB from SuperNode
             message, context, run, fab = pull_clientappinputs(stub=stub, token=token)
@@ -172,23 +173,26 @@ def start_parent_process_monitor(
     threading.Thread(target=monitor, daemon=True).start()
 
 
-def get_token(stub: grpc.Channel) -> Optional[int]:
+def get_token(stub: ClientAppIoStub) -> str:
     """Get a token from SuperNode."""
     log(DEBUG, "[flwr-clientapp] Request token")
-    try:
-        res: GetTokenResponse = stub.GetToken(GetTokenRequest())
-        log(DEBUG, "[GetToken] Received token: %s", res.token)
-        return res.token
-    except grpc.RpcError as e:
-        if e.code() == grpc.StatusCode.FAILED_PRECONDITION:  # pylint: disable=no-member
-            log(DEBUG, "[GetToken] No token available yet")
-        else:
-            log(ERROR, "[GetToken] gRPC error occurred: %s", str(e))
-        return None
+    while True:
+        res: GetRunIdsWithPendingMessagesResponse = stub.GetRunIdsWithPendingMessages(
+            GetRunIdsWithPendingMessagesRequest()
+        )
+
+        for run_id in res.run_ids:
+            tk_res: RequestTokenResponse = stub.RequestToken(
+                RequestTokenRequest(run_id=run_id)
+            )
+            if tk_res.token:
+                return tk_res.token
+
+        time.sleep(1)  # Wait before retrying to get run IDs
 
 
 def pull_clientappinputs(
-    stub: grpc.Channel, token: int
+    stub: ClientAppIoStub, token: str
 ) -> tuple[Message, Context, Run, Optional[Fab]]:
     """Pull ClientAppInputs from SuperNode."""
     log(INFO, "[flwr-clientapp] Pull `ClientAppInputs` for token %s", token)
@@ -207,7 +211,7 @@ def pull_clientappinputs(
 
 
 def push_clientappoutputs(
-    stub: grpc.Channel, token: int, message: Message, context: Context
+    stub: ClientAppIoStub, token: str, message: Message, context: Context
 ) -> PushClientAppOutputsResponse:
     """Push ClientAppOutputs to SuperNode."""
     log(INFO, "[flwr-clientapp] Push `ClientAppOutputs` for token %s", token)

flwr/supernode/servicer/clientappio/clientappio_servicer.py

@@ -37,13 +37,20 @@ from flwr.common.typing import Fab, Run
 # pylint: disable=E0611
 from flwr.proto import clientappio_pb2_grpc
 from flwr.proto.clientappio_pb2 import (  # pylint: disable=E0401
+    GetRunIdsWithPendingMessagesRequest,
+    GetRunIdsWithPendingMessagesResponse,
     GetTokenRequest,
     GetTokenResponse,
     PullClientAppInputsRequest,
     PullClientAppInputsResponse,
     PushClientAppOutputsRequest,
     PushClientAppOutputsResponse,
+    RequestTokenRequest,
+    RequestTokenResponse,
 )
+from flwr.supercore.ffs import FfsFactory
+from flwr.supercore.object_store import ObjectStoreFactory
+from flwr.supernode.nodestate import NodeStateFactory
 
 
 @dataclass
@@ -54,7 +61,6 @@ class ClientAppInputs:
     context: Context
     run: Run
     fab: Optional[Fab]
-    token: int
 
 
 @dataclass
@@ -69,11 +75,56 @@ class ClientAppOutputs:
 class ClientAppIoServicer(clientappio_pb2_grpc.ClientAppIoServicer):
     """ClientAppIo API servicer."""
 
-    def __init__(self) -> None:
+    def __init__(
+        self,
+        state_factory: NodeStateFactory,
+        ffs_factory: FfsFactory,
+        objectstore_factory: ObjectStoreFactory,
+    ) -> None:
+        self.state_factory = state_factory
+        self.ffs_factory = ffs_factory
+        self.objectstore_factory = objectstore_factory
+
         self.clientapp_input: Optional[ClientAppInputs] = None
         self.clientapp_output: Optional[ClientAppOutputs] = None
         self.token_returned: bool = False
-        self.inputs_returned: bool = False
+
+    def GetRunIdsWithPendingMessages(
+        self,
+        request: GetRunIdsWithPendingMessagesRequest,
+        context: grpc.ServicerContext,
+    ) -> GetRunIdsWithPendingMessagesResponse:
+        """Get run IDs with pending messages."""
+        log(DEBUG, "ClientAppIo.GetRunIdsWithPendingMessages")
+
+        # Initialize state connection
+        state = self.state_factory.state()
+
+        # Get run IDs with pending messages
+        run_ids = state.get_run_ids_with_pending_messages()
+
+        # Return run IDs
+        return GetRunIdsWithPendingMessagesResponse(run_ids=run_ids)
+
+    def RequestToken(
+        self, request: RequestTokenRequest, context: grpc.ServicerContext
+    ) -> RequestTokenResponse:
+        """Request token."""
+        log(DEBUG, "ClientAppIo.RequestToken")
+
+        # Initialize state connection
+        state = self.state_factory.state()
+
+        # Attempt to create a token for the provided run ID
+        try:
+            token = state.create_token(request.run_id)
+        except ValueError:
+            # Return an empty token if A token already exists for this run ID,
+            # indicating the run is in progress
+            return RequestTokenResponse(token="")
+
+        # Return the token
+        return RequestTokenResponse(token=token)
 
     def GetToken(
         self, request: GetTokenRequest, context: grpc.ServicerContext
@@ -87,7 +138,6 @@ class ClientAppIoServicer(clientappio_pb2_grpc.ClientAppIoServicer):
                 grpc.StatusCode.FAILED_PRECONDITION,
                 "No inputs available.",
             )
-        clientapp_input = cast(ClientAppInputs, self.clientapp_input)
 
         # Fail if token was already returned in a previous call
         if self.token_returned:
@@ -101,7 +151,7 @@ class ClientAppIoServicer(clientappio_pb2_grpc.ClientAppIoServicer):
         # - token hasn't been returned before,
         # return token
         self.token_returned = True
-        return GetTokenResponse(token=clientapp_input.token)
+        return GetTokenResponse(token=123)  # To be deleted
 
     def PullClientAppInputs(
         self, request: PullClientAppInputsRequest, context: grpc.ServicerContext
@@ -109,36 +159,30 @@ class ClientAppIoServicer(clientappio_pb2_grpc.ClientAppIoServicer):
         """Pull Message, Context, and Run."""
         log(DEBUG, "ClientAppIo.PullClientAppInputs")
 
-        # Fail if no ClientAppInputs are available
-        if self.clientapp_input is None:
-            context.abort(
-                grpc.StatusCode.FAILED_PRECONDITION,
-                "No inputs available.",
-            )
-        clientapp_input = cast(ClientAppInputs, self.clientapp_input)
+        # Initialize state and ffs connection
+        state = self.state_factory.state()
+        ffs = self.ffs_factory.ffs()
 
-        # Fail if token wasn't returned in a previous call
-        if not self.token_returned:
+        # Validate the token
+        run_id = state.get_run_id_by_token(request.token)
+        if run_id is None or not state.verify_token(run_id, request.token):
             context.abort(
-                grpc.StatusCode.FAILED_PRECONDITION,
-                "Token hasn't been returned."
-                "Token must be returned before can be returned only once.",
+                grpc.StatusCode.PERMISSION_DENIED,
+                "Invalid token.",
             )
+            raise RuntimeError("This line should never be reached.")
 
-        # Fail if token isn't matching
-        if request.token != clientapp_input.token:
-            context.abort(
-                grpc.StatusCode.INVALID_ARGUMENT,
-                "Mismatch between ClientApp and SuperNode token",
-            )
+        # Retrieve message, context, run and fab for this run
+        message = state.get_messages(run_ids=[run_id], is_reply=False)[0]
+        context = cast(Context, state.get_context(run_id))
+        run = cast(Run, state.get_run(run_id))
+        fab = Fab(run.fab_hash, ffs.get(run.fab_hash)[0])  # type: ignore
 
-        # Success
-        self.inputs_returned = True
         return PullClientAppInputsResponse(
-            message=message_to_proto(clientapp_input.message),
-            context=context_to_proto(clientapp_input.context),
-            run=run_to_proto(clientapp_input.run),
-            fab=fab_to_proto(clientapp_input.fab) if clientapp_input.fab else None,
+            message=message_to_proto(message),
+            context=context_to_proto(context),
+            run=run_to_proto(run),
+            fab=fab_to_proto(fab),
         )
 
     def PushClientAppOutputs(
@@ -147,36 +191,20 @@ class ClientAppIoServicer(clientappio_pb2_grpc.ClientAppIoServicer):
         """Push Message and Context."""
         log(DEBUG, "ClientAppIo.PushClientAppOutputs")
 
-        # Fail if no ClientAppInputs are available
-        if not self.clientapp_input:
-            context.abort(
-                grpc.StatusCode.FAILED_PRECONDITION,
-                "No inputs available.",
-            )
-        clientapp_input = cast(ClientAppInputs, self.clientapp_input)
+        # Initialize state connection
+        state = self.state_factory.state()
 
-        # Fail if token wasn't returned in a previous call
-        if not self.token_returned:
+        # Validate the token
+        run_id = state.get_run_id_by_token(request.token)
+        if run_id is None or not state.verify_token(run_id, request.token):
             context.abort(
-                grpc.StatusCode.FAILED_PRECONDITION,
-                "Token hasn't been returned."
-                "Token must be returned before can be returned only once.",
+                grpc.StatusCode.PERMISSION_DENIED,
+                "Invalid token.",
             )
+            raise RuntimeError("This line should never be reached.")
 
-        # Fail if inputs weren't delivered in a previous call
-        if not self.inputs_returned:
-            context.abort(
-                grpc.StatusCode.FAILED_PRECONDITION,
-                "Inputs haven't been delivered."
-                "Inputs must be delivered before can be returned only once.",
-            )
-
-        # Fail if token isn't matching
-        if request.token != clientapp_input.token:
-            context.abort(
-                grpc.StatusCode.INVALID_ARGUMENT,
-                "Mismatch between ClientApp and SuperNode token",
-            )
+        # Delete the token
+        state.delete_token(run_id)
 
         # Preconditions met
         try:
@@ -198,33 +226,6 @@ class ClientAppIoServicer(clientappio_pb2_grpc.ClientAppIoServicer):
         proto_status = clientappstatus_to_proto(status=status)
         return PushClientAppOutputsResponse(status=proto_status)
 
-    def set_inputs(
-        self, clientapp_input: ClientAppInputs, token_returned: bool
-    ) -> None:
-        """Set ClientApp inputs.
-
-        Parameters
-        ----------
-        clientapp_input : ClientAppInputs
-            The inputs to the ClientApp.
-        token_returned : bool
-            A boolean indicating if the token has been returned.
-            Set to `True` when passing the token to `flwr-clientap`
-            and `False` otherwise.
-        """
-        if (
-            self.clientapp_input is not None
-            or self.clientapp_output is not None
-            or self.token_returned
-        ):
-            raise ValueError(
-                "ClientAppInputs and ClientAppOutputs must not be set before "
-                "calling `set_inputs`."
-            )
-        log(DEBUG, "ClientAppInputs set (token: %s)", clientapp_input.token)
-        self.clientapp_input = clientapp_input
-        self.token_returned = token_returned
-
     def has_outputs(self) -> bool:
         """Check if ClientAppOutputs are available."""
         return self.clientapp_output is not None
@@ -236,9 +237,6 @@ class ClientAppIoServicer(clientappio_pb2_grpc.ClientAppIoServicer):
 
         # Set outputs to a local variable and clear state
         output: ClientAppOutputs = self.clientapp_output
-        self.clientapp_input = None
         self.clientapp_output = None
-        self.token_returned = False
-        self.inputs_returned = False
 
         return output

flwr/supernode/start_client_internal.py

@@ -21,9 +21,8 @@ import time
 from collections.abc import Iterator
 from contextlib import contextmanager
 from logging import INFO, WARN
-from os import urandom
 from pathlib import Path
-from typing import Callable, Optional, Union, cast
+from typing import Callable, Optional, Union
 
 import grpc
 from cryptography.hazmat.primitives.asymmetric import ec
@@ -39,7 +38,6 @@ from flwr.common.constant import (
     CLIENTAPPIO_API_DEFAULT_SERVER_ADDRESS,
     ISOLATION_MODE_SUBPROCESS,
     MAX_RETRY_DELAY,
-    RUN_ID_NUM_BYTES,
     SERVER_OCTET,
     TRANSPORT_TYPE_GRPC_ADAPTER,
     TRANSPORT_TYPE_GRPC_RERE,
@@ -52,10 +50,10 @@ from flwr.common.logger import log
 from flwr.common.retry_invoker import RetryInvoker, RetryState, exponential
 from flwr.common.typing import Fab, Run, RunNotRunningException, UserConfig
 from flwr.proto.clientappio_pb2_grpc import add_ClientAppIoServicer_to_server
-from flwr.server.superlink.ffs import Ffs, FfsFactory
+from flwr.supercore.ffs import Ffs, FfsFactory
 from flwr.supercore.object_store import ObjectStore, ObjectStoreFactory
 from flwr.supernode.nodestate import NodeState, NodeStateFactory
-from flwr.supernode.servicer.clientappio import ClientAppInputs, ClientAppIoServicer
+from flwr.supernode.servicer.clientappio import ClientAppIoServicer
 
 DEFAULT_FFS_DIR = get_flwr_dir() / "supernode" / "ffs"
 
@@ -132,16 +130,20 @@ def start_client_internal(
     if insecure is None:
         insecure = root_certificates is None
 
-    _clientappio_grpc_server, clientappio_servicer = run_clientappio_api_grpc(
-        address=clientappio_api_address,
-        certificates=None,
-    )
-
     # Initialize factories
     state_factory = NodeStateFactory()
     ffs_factory = FfsFactory(get_flwr_dir(flwr_path) / "supernode" / "ffs")  # type: ignore
     object_store_factory = ObjectStoreFactory()
 
+    # Launch ClientAppIo API server
+    _clientappio_grpc_server, clientappio_servicer = run_clientappio_api_grpc(
+        address=clientappio_api_address,
+        state_factory=state_factory,
+        ffs_factory=ffs_factory,
+        objectstore_factory=object_store_factory,
+        certificates=None,
+    )
+
     # Initialize NodeState, Ffs, and ObjectStore
     state = state_factory.state()
     ffs = ffs_factory.ffs()
@@ -183,12 +185,6 @@ def start_client_internal(
                 continue
 
             try:
-                # Retrieve message, context, run and fab for this run
-                message = state.get_messages(run_ids=[run_id], is_reply=False)[0]
-                context = cast(Context, state.get_context(run_id))
-                run = cast(Run, state.get_run(run_id))
-                fab = Fab(run.fab_hash, ffs.get(run.fab_hash)[0])  # type: ignore
-
                 # Two isolation modes:
                 # 1. `subprocess`: SuperNode is starting the ClientApp
                 #    process as a subprocess.
@@ -196,24 +192,9 @@ def start_client_internal(
                 #    (via `flwr-clientapp`), for example, in a separate
                 #    Docker container.
 
-                # Generate SuperNode token
-                token = int.from_bytes(urandom(RUN_ID_NUM_BYTES), "little")
-
                 # Mode 1: SuperNode starts ClientApp as subprocess
                 start_subprocess = isolation == ISOLATION_MODE_SUBPROCESS
 
-                # Share Message and Context with servicer
-                clientappio_servicer.set_inputs(
-                    clientapp_input=ClientAppInputs(
-                        message=message,
-                        context=context,
-                        run=run,
-                        fab=fab,
-                        token=token,
-                    ),
-                    token_returned=start_subprocess,
-                )
-
                 if start_subprocess:
                     _octet, _colon, _port = clientappio_api_address.rpartition(":")
                     io_address = (
@@ -226,11 +207,10 @@ def start_client_internal(
                         "flwr-clientapp",
                         "--clientappio-api-address",
                         io_address,
-                        "--token",
-                        str(token),
                         "--parent-pid",
                         str(os.getpid()),
                         "--insecure",
+                        "--run-once",
                     ]
                     subprocess.run(command, check=False)
                 else:
@@ -250,8 +230,8 @@ def start_client_internal(
                 # Delete messages from the state
                 state.delete_messages(
                     message_ids=[
-                        message.metadata.message_id,
-                        message.metadata.reply_to_message_id,
+                        reply_message.metadata.message_id,
+                        reply_message.metadata.reply_to_message_id,
                     ]
                 )
 
@@ -472,10 +452,17 @@ def _make_fleet_connection_retry_invoker(
 
 def run_clientappio_api_grpc(
     address: str,
+    state_factory: NodeStateFactory,
+    ffs_factory: FfsFactory,
+    objectstore_factory: ObjectStoreFactory,
     certificates: Optional[tuple[bytes, bytes, bytes]],
 ) -> tuple[grpc.Server, ClientAppIoServicer]:
     """Run ClientAppIo API gRPC server."""
-    clientappio_servicer: grpc.Server = ClientAppIoServicer()
+    clientappio_servicer: grpc.Server = ClientAppIoServicer(
+        state_factory=state_factory,
+        ffs_factory=ffs_factory,
+        objectstore_factory=objectstore_factory,
+    )
     clientappio_add_servicer_to_server_fn = add_ClientAppIoServicer_to_server
     clientappio_grpc_server = generic_create_grpc_server(
         servicer_and_add_fn=(

{flwr_nightly-1.19.0.dev20250616.dist-info → flwr_nightly-1.20.0.dev20250618.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.3
 Name: flwr-nightly
-Version: 1.19.0.dev20250616
+Version: 1.20.0.dev20250618
 Summary: Flower: A Friendly Federated AI Framework
 License: Apache-2.0
 Keywords: Artificial Intelligence,Federated AI,Federated Analytics,Federated Evaluation,Federated Learning,Flower,Machine Learning