flixopt 2.2.0rc2__py3-none-any.whl → 3.0.0__py3-none-any.whl

flixopt/features.py

@@ -3,1054 +3,482 @@ This module contains the features of the flixopt framework.
 Features extend the functionality of Elements.
 """
 
+from __future__ import annotations
+
 import logging
-from typing import Dict, List, Optional, Tuple, Union
+from typing import TYPE_CHECKING
 
 import linopy
 import numpy as np
 
-from . import utils
-from .config import CONFIG
-from .core import NumericData, Scalar, TimeSeries
-from .interface import InvestParameters, OnOffParameters, Piece, Piecewise
-from .structure import Model, SystemModel
+from .modeling import BoundingPatterns, ModelingPrimitives, ModelingUtilities
+from .structure import FlowSystemModel, Submodel
+
+if TYPE_CHECKING:
+    from .core import FlowSystemDimensions, Scalar, TemporalData
+    from .interface import InvestParameters, OnOffParameters, Piecewise
 
 logger = logging.getLogger('flixopt')
 
 
-class InvestmentModel(Model):
-    """Class for modeling an investment"""
+class InvestmentModel(Submodel):
+    """
+    This feature model is used to model the investment of a variable.
+    It applies the corresponding bounds to the variable and the on/off state of the variable.
+
+    Args:
+        model: The optimization model instance
+        label_of_element: The label of the parent (Element). Used to construct the full label of the model.
+        parameters: The parameters of the feature model.
+        label_of_model: The label of the model. This is needed to construct the full label of the model.
+
+    """
+
+    parameters: InvestParameters
 
     def __init__(
         self,
-        model: SystemModel,
+        model: FlowSystemModel,
         label_of_element: str,
         parameters: InvestParameters,
-        defining_variable: [linopy.Variable],
-        relative_bounds_of_defining_variable: Tuple[NumericData, NumericData],
-        label: Optional[str] = None,
-        on_variable: Optional[linopy.Variable] = None,
+        label_of_model: str | None = None,
     ):
-        super().__init__(model, label_of_element, label)
-        self.size: Optional[Union[Scalar, linopy.Variable]] = None
-        self.is_invested: Optional[linopy.Variable] = None
+        self.piecewise_effects: PiecewiseEffectsModel | None = None
+        self.parameters = parameters
+        super().__init__(model, label_of_element=label_of_element, label_of_model=label_of_model)
 
-        self.piecewise_effects: Optional[PiecewiseEffectsModel] = None
+    def _do_modeling(self):
+        super()._do_modeling()
+        self._create_variables_and_constraints()
+        self._add_effects()
 
-        self._on_variable = on_variable
-        self._defining_variable = defining_variable
-        self._relative_bounds_of_defining_variable = relative_bounds_of_defining_variable
-        self.parameters = parameters
+    def _create_variables_and_constraints(self):
+        size_min, size_max = (self.parameters.minimum_or_fixed_size, self.parameters.maximum_or_fixed_size)
+        if self.parameters.linked_periods is not None:
+            # Mask size bounds: linked_periods is a binary DataArray that zeros out non-linked periods
+            size_min = size_min * self.parameters.linked_periods
+            size_max = size_max * self.parameters.linked_periods
 
-    def do_modeling(self):
-        if self.parameters.fixed_size and not self.parameters.optional:
-            self.size = self.add(
-                self._model.add_variables(
-                    lower=self.parameters.fixed_size, upper=self.parameters.fixed_size, name=f'{self.label_full}|size'
-                ),
-                'size',
+        self.add_variables(
+            short_name='size',
+            lower=size_min if self.parameters.mandatory else 0,
+            upper=size_max,
+            coords=self._model.get_coords(['period', 'scenario']),
+        )
+
+        if not self.parameters.mandatory:
+            self.add_variables(
+                binary=True,
+                coords=self._model.get_coords(['period', 'scenario']),
+                short_name='invested',
             )
-        else:
-            self.size = self.add(
-                self._model.add_variables(
-                    lower=0 if self.parameters.optional else self.parameters.minimum_size,
-                    upper=self.parameters.maximum_size,
-                    name=f'{self.label_full}|size',
-                ),
-                'size',
+            BoundingPatterns.bounds_with_state(
+                self,
+                variable=self.size,
+                variable_state=self._variables['invested'],
+                bounds=(self.parameters.minimum_or_fixed_size, self.parameters.maximum_or_fixed_size),
             )
 
-        # Optional
-        if self.parameters.optional:
-            self.is_invested = self.add(
-                self._model.add_variables(binary=True, name=f'{self.label_full}|is_invested'), 'is_invested'
+        if self.parameters.linked_periods is not None:
+            masked_size = self.size.where(self.parameters.linked_periods, drop=True)
+            self.add_constraints(
+                masked_size.isel(period=slice(None, -1)) == masked_size.isel(period=slice(1, None)),
+                short_name='linked_periods',
             )
 
-            self._create_bounds_for_optional_investment()
-
-        # Bounds for defining variable
-        self._create_bounds_for_defining_variable()
-
-        self._create_shares()
-
-    def _create_shares(self):
-        # fix_effects:
-        fix_effects = self.parameters.fix_effects
-        if fix_effects != {}:
+    def _add_effects(self):
+        """Add investment effects"""
+        if self.parameters.effects_of_investment:
             self._model.effects.add_share_to_effects(
                 name=self.label_of_element,
                 expressions={
-                    effect: self.is_invested * factor if self.is_invested is not None else factor
-                    for effect, factor in fix_effects.items()
+                    effect: self.invested * factor if self.invested is not None else factor
+                    for effect, factor in self.parameters.effects_of_investment.items()
                 },
-                target='invest',
+                target='periodic',
             )
 
-        if self.parameters.divest_effects != {} and self.parameters.optional:
-            # share: divest_effects - isInvested * divest_effects
+        if self.parameters.effects_of_retirement and not self.parameters.mandatory:
             self._model.effects.add_share_to_effects(
                 name=self.label_of_element,
                 expressions={
-                    effect: -self.is_invested * factor + factor
-                    for effect, factor in self.parameters.divest_effects.items()
+                    effect: -self.invested * factor + factor
+                    for effect, factor in self.parameters.effects_of_retirement.items()
                 },
-                target='invest',
+                target='periodic',
             )
 
-        if self.parameters.specific_effects != {}:
+        if self.parameters.effects_of_investment_per_size:
             self._model.effects.add_share_to_effects(
                 name=self.label_of_element,
-                expressions={effect: self.size * factor for effect, factor in self.parameters.specific_effects.items()},
-                target='invest',
+                expressions={
+                    effect: self.size * factor
+                    for effect, factor in self.parameters.effects_of_investment_per_size.items()
+                },
+                target='periodic',
             )
 
-        if self.parameters.piecewise_effects:
-            self.piecewise_effects = self.add(
+        if self.parameters.piecewise_effects_of_investment:
+            self.piecewise_effects = self.add_submodels(
                 PiecewiseEffectsModel(
                     model=self._model,
                     label_of_element=self.label_of_element,
-                    piecewise_origin=(self.size.name, self.parameters.piecewise_effects.piecewise_origin),
-                    piecewise_shares=self.parameters.piecewise_effects.piecewise_shares,
-                    zero_point=self.is_invested,
-                ),
-                'segments',
-            )
-            self.piecewise_effects.do_modeling()
-
-    def _create_bounds_for_optional_investment(self):
-        if self.parameters.fixed_size:
-            # eq: investment_size = isInvested * fixed_size
-            self.add(
-                self._model.add_constraints(
-                    self.size == self.is_invested * self.parameters.fixed_size, name=f'{self.label_full}|is_invested'
-                ),
-                'is_invested',
-            )
-
-        else:
-            # eq1: P_invest <= isInvested * investSize_max
-            self.add(
-                self._model.add_constraints(
-                    self.size <= self.is_invested * self.parameters.maximum_size,
-                    name=f'{self.label_full}|is_invested_ub',
-                ),
-                'is_invested_ub',
-            )
-
-            # eq2: P_invest >= isInvested * max(epsilon, investSize_min)
-            self.add(
-                self._model.add_constraints(
-                    self.size >= self.is_invested * np.maximum(CONFIG.modeling.EPSILON, self.parameters.minimum_size),
-                    name=f'{self.label_full}|is_invested_lb',
-                ),
-                'is_invested_lb',
-            )
-
-    def _create_bounds_for_defining_variable(self):
-        variable = self._defining_variable
-        lb_relative, ub_relative = self._relative_bounds_of_defining_variable
-        if np.all(lb_relative == ub_relative):
-            self.add(
-                self._model.add_constraints(
-                    variable == self.size * ub_relative, name=f'{self.label_full}|fix_{variable.name}'
-                ),
-                f'fix_{variable.name}',
-            )
-            if self._on_variable is not None:
-                raise ValueError(
-                    f'Flow {self.label_full} has a fixed relative flow rate and an on_variable.'
-                    f'This combination is currently not supported.'
-                )
-            return
-
-        # eq: defining_variable(t)  <= size * upper_bound(t)
-        self.add(
-            self._model.add_constraints(
-                variable <= self.size * ub_relative, name=f'{self.label_full}|ub_{variable.name}'
-            ),
-            f'ub_{variable.name}',
-        )
-
-        if self._on_variable is None:
-            # eq: defining_variable(t) >= investment_size * relative_minimum(t)
-            self.add(
-                self._model.add_constraints(
-                    variable >= self.size * lb_relative, name=f'{self.label_full}|lb_{variable.name}'
-                ),
-                f'lb_{variable.name}',
-            )
-        else:
-            ## 2. Gleichung: Minimum durch Investmentgröße und On
-            # eq: defining_variable(t) >= mega * (On(t)-1) + size * relative_minimum(t)
-            #     ... mit mega = relative_maximum * maximum_size
-            # äquivalent zu:.
-            # eq: - defining_variable(t) + mega * On(t) + size * relative_minimum(t) <= + mega
-            mega = lb_relative * self.parameters.maximum_size
-            on = self._on_variable
-            self.add(
-                self._model.add_constraints(
-                    variable >= mega * (on - 1) + self.size * lb_relative, name=f'{self.label_full}|lb_{variable.name}'
-                ),
-                f'lb_{variable.name}',
-            )
-            # anmerkung: Glg bei Spezialfall relative_minimum = 0 redundant zu OnOff ??
-
-
-class StateModel(Model):
-    """
-    Handles basic on/off binary states for defining variables
-    """
-
-    def __init__(
-        self,
-        model: SystemModel,
-        label_of_element: str,
-        defining_variables: List[linopy.Variable],
-        defining_bounds: List[Tuple[NumericData, NumericData]],
-        previous_values: List[Optional[NumericData]] = None,
-        use_off: bool = True,
-        on_hours_total_min: Optional[NumericData] = 0,
-        on_hours_total_max: Optional[NumericData] = None,
-        effects_per_running_hour: Dict[str, NumericData] = None,
-        label: Optional[str] = None,
-    ):
-        """
-        Models binary state variables based on a continous variable.
-
-        Args:
-            model: The SystemModel that is used to create the model.
-            label_of_element: The label of the parent (Element). Used to construct the full label of the model.
-            defining_variables: List of Variables that are used to define the state
-            defining_bounds: List of Tuples, defining the absolute bounds of each defining variable
-            previous_values: List of previous values of the defining variables
-            use_off: Whether to use the off state or not
-            on_hours_total_min: min. overall sum of operating hours.
-            on_hours_total_max: max. overall sum of operating hours.
-            effects_per_running_hour: Costs per operating hours
-            label: Label of the OnOffModel
-        """
-        super().__init__(model, label_of_element, label)
-        assert len(defining_variables) == len(defining_bounds), 'Every defining Variable needs bounds to Model OnOff'
-        self._defining_variables = defining_variables
-        self._defining_bounds = defining_bounds
-        self._previous_values = previous_values or []
-        self._on_hours_total_min = on_hours_total_min if on_hours_total_min is not None else 0
-        self._on_hours_total_max = on_hours_total_max if on_hours_total_max is not None else np.inf
-        self._use_off = use_off
-        self._effects_per_running_hour = effects_per_running_hour or {}
-
-        self.on = None
-        self.total_on_hours: Optional[linopy.Variable] = None
-        self.off = None
-
-    def do_modeling(self):
-        self.on = self.add(
-            self._model.add_variables(
-                name=f'{self.label_full}|on',
-                binary=True,
-                coords=self._model.coords,
-            ),
-            'on',
-        )
-
-        self.total_on_hours = self.add(
-            self._model.add_variables(
-                lower=self._on_hours_total_min,
-                upper=self._on_hours_total_max,
-                coords=None,
-                name=f'{self.label_full}|on_hours_total',
-            ),
-            'on_hours_total',
-        )
-
-        self.add(
-            self._model.add_constraints(
-                self.total_on_hours == (self.on * self._model.hours_per_step).sum(),
-                name=f'{self.label_full}|on_hours_total',
-            ),
-            'on_hours_total',
-        )
-
-        # Add defining constraints for each variable
-        self._add_defining_constraints()
-
-        if self._use_off:
-            self.off = self.add(
-                self._model.add_variables(
-                    name=f'{self.label_full}|off',
-                    binary=True,
-                    coords=self._model.coords,
-                ),
-                'off',
-            )
-
-            # Constraint: on + off = 1
-            self.add(self._model.add_constraints(self.on + self.off == 1, name=f'{self.label_full}|off'), 'off')
-
-        return self
-
-    def _add_defining_constraints(self):
-        """Add constraints that link defining variables to the on state"""
-        nr_of_def_vars = len(self._defining_variables)
-
-        if nr_of_def_vars == 1:
-            # Case for a single defining variable
-            def_var = self._defining_variables[0]
-            lb, ub = self._defining_bounds[0]
-
-            # Constraint: on * lower_bound <= def_var
-            self.add(
-                self._model.add_constraints(
-                    self.on * np.maximum(CONFIG.modeling.EPSILON, lb) <= def_var, name=f'{self.label_full}|on_con1'
-                ),
-                'on_con1',
-            )
-
-            # Constraint: on * upper_bound >= def_var
-            self.add(self._model.add_constraints(self.on * ub >= def_var, name=f'{self.label_full}|on_con2'), 'on_con2')
-        else:
-            # Case for multiple defining variables
-            ub = sum(bound[1] for bound in self._defining_bounds) / nr_of_def_vars
-            lb = CONFIG.modeling.EPSILON  # TODO: Can this be a bigger value? (maybe the smallest bound?)
-
-            # Constraint: on * epsilon <= sum(all_defining_variables)
-            self.add(
-                self._model.add_constraints(
-                    self.on * lb <= sum(self._defining_variables), name=f'{self.label_full}|on_con1'
-                ),
-                'on_con1',
-            )
-
-            # Constraint to ensure all variables are zero when off.
-            # Divide by nr_of_def_vars to improve numerical stability (smaller factors)
-            self.add(
-                self._model.add_constraints(
-                    self.on * ub >= sum([def_var / nr_of_def_vars for def_var in self._defining_variables]),
-                    name=f'{self.label_full}|on_con2',
+                    label_of_model=f'{self.label_of_element}|PiecewiseEffects',
+                    piecewise_origin=(self.size.name, self.parameters.piecewise_effects_of_investment.piecewise_origin),
+                    piecewise_shares=self.parameters.piecewise_effects_of_investment.piecewise_shares,
+                    zero_point=self.invested,
                 ),
-                'on_con2',
+                short_name='segments',
             )
 
     @property
-    def previous_states(self) -> np.ndarray:
-        """Computes the previous states {0, 1} of defining variables as a binary array from their previous values."""
-        return StateModel.compute_previous_states(self._previous_values, epsilon=CONFIG.modeling.EPSILON)
+    def size(self) -> linopy.Variable:
+        """Investment size variable"""
+        return self._variables['size']
 
     @property
-    def previous_on_states(self) -> np.ndarray:
-        return self.previous_states
-
-    @property
-    def previous_off_states(self):
-        return 1 - self.previous_states
-
-    @staticmethod
-    def compute_previous_states(previous_values: List[NumericData], epsilon: float = 1e-5) -> np.ndarray:
-        """Computes the previous states {0, 1} of defining variables as a binary array from their previous values."""
-        if not previous_values or all([val is None for val in previous_values]):
-            return np.array([0])
-
-        # Convert to 2D-array and compute binary on/off states
-        previous_values = np.array([values for values in previous_values if values is not None])  # Filter out None
-        if previous_values.ndim > 1:
-            return np.any(~np.isclose(previous_values, 0, atol=epsilon), axis=0).astype(int)
-
-        return (~np.isclose(previous_values, 0, atol=epsilon)).astype(int)
-
-
-class SwitchStateModel(Model):
-    """
-    Handles switch on/off transitions
-    """
-
-    def __init__(
-        self,
-        model: SystemModel,
-        label_of_element: str,
-        state_variable: linopy.Variable,
-        previous_state=0,
-        switch_on_max: Optional[Scalar] = None,
-        label: Optional[str] = None,
-    ):
-        super().__init__(model, label_of_element, label)
-        self._state_variable = state_variable
-        self.previous_state = previous_state
-        self._switch_on_max = switch_on_max if switch_on_max is not None else np.inf
-
-        self.switch_on = None
-        self.switch_off = None
-        self.switch_on_nr = None
-
-    def do_modeling(self):
-        """Create switch variables and constraints"""
-
-        # Create switch variables
-        self.switch_on = self.add(
-            self._model.add_variables(binary=True, name=f'{self.label_full}|switch_on', coords=self._model.coords),
-            'switch_on',
-        )
+    def invested(self) -> linopy.Variable | None:
+        """Binary investment decision variable"""
+        if 'invested' not in self._variables:
+            return None
+        return self._variables['invested']
 
-        self.switch_off = self.add(
-            self._model.add_variables(binary=True, name=f'{self.label_full}|switch_off', coords=self._model.coords),
-            'switch_off',
-        )
-
-        # Create count variable for number of switches
-        self.switch_on_nr = self.add(
-            self._model.add_variables(
-                upper=self._switch_on_max,
-                lower=0,
-                name=f'{self.label_full}|switch_on_nr',
-            ),
-            'switch_on_nr',
-        )
-
-        # Add switch constraints for all entries after the first timestep
-        self.add(
-            self._model.add_constraints(
-                self.switch_on.isel(time=slice(1, None)) - self.switch_off.isel(time=slice(1, None))
-                == self._state_variable.isel(time=slice(1, None)) - self._state_variable.isel(time=slice(None, -1)),
-                name=f'{self.label_full}|switch_con',
-            ),
-            'switch_con',
-        )
-
-        # Initial switch constraint
-        self.add(
-            self._model.add_constraints(
-                self.switch_on.isel(time=0) - self.switch_off.isel(time=0)
-                == self._state_variable.isel(time=0) - self.previous_state,
-                name=f'{self.label_full}|initial_switch_con',
-            ),
-            'initial_switch_con',
-        )
 
-        # Mutual exclusivity constraint
-        self.add(
-            self._model.add_constraints(
-                self.switch_on + self.switch_off <= 1.1, name=f'{self.label_full}|switch_on_or_off'
-            ),
-            'switch_on_or_off',
-        )
-
-        # Total switch-on count constraint
-        self.add(
-            self._model.add_constraints(
-                self.switch_on_nr == self.switch_on.sum('time'), name=f'{self.label_full}|switch_on_nr'
-            ),
-            'switch_on_nr',
-        )
-
-        return self
-
-
-class ConsecutiveStateModel(Model):
-    """
-    Handles tracking consecutive durations in a state
-    """
+class OnOffModel(Submodel):
+    """OnOff model using factory patterns"""
 
     def __init__(
         self,
-        model: SystemModel,
+        model: FlowSystemModel,
         label_of_element: str,
-        state_variable: linopy.Variable,
-        minimum_duration: Optional[NumericData] = None,
-        maximum_duration: Optional[NumericData] = None,
-        previous_states: Optional[NumericData] = None,
-        label: Optional[str] = None,
+        parameters: OnOffParameters,
+        on_variable: linopy.Variable,
+        previous_states: TemporalData | None,
+        label_of_model: str | None = None,
     ):
         """
-        Model and constraint the consecutive duration of a state variable.
+        This feature model is used to model the on/off state of flow_rate(s). It does not matter of the flow_rates are
+        bounded by a size variable or by a hard bound. THe used bound here is the absolute highest/lowest bound!
 
         Args:
-            model: The SystemModel that is used to create the model.
+            model: The optimization model instance
             label_of_element: The label of the parent (Element). Used to construct the full label of the model.
-            state_variable: The state variable that is used to model the duration. state = {0, 1}
-            minimum_duration: The minimum duration of the state variable.
-            maximum_duration: The maximum duration of the state variable.
-            previous_states: The previous states of the state variable.
-            label: The label of the model. Used to construct the full label of the model.
+            parameters: The parameters of the feature model.
+            on_variable: The variable that determines the on state
+            previous_states: The previous flow_rates
+            label_of_model: The label of the model. This is needed to construct the full label of the model.
         """
-        super().__init__(model, label_of_element, label)
-        self._state_variable = state_variable
+        self.on = on_variable
         self._previous_states = previous_states
-        self._minimum_duration = minimum_duration
-        self._maximum_duration = maximum_duration
-
-        if isinstance(self._minimum_duration, TimeSeries):
-            self._minimum_duration = self._minimum_duration.active_data
-        if isinstance(self._maximum_duration, TimeSeries):
-            self._maximum_duration = self._maximum_duration.active_data
-
-        self.duration = None
-
-    def do_modeling(self):
-        """Create consecutive duration variables and constraints"""
-        # Get the hours per step
-        hours_per_step = self._model.hours_per_step
-        mega = hours_per_step.sum('time') + self.previous_duration
-
-        # Create the duration variable
-        self.duration = self.add(
-            self._model.add_variables(
-                lower=0,
-                upper=self._maximum_duration if self._maximum_duration is not None else mega,
-                coords=self._model.coords,
-                name=f'{self.label_full}|hours',
-            ),
-            'hours',
-        )
-
-        # Add constraints
-
-        # Upper bound constraint
-        self.add(
-            self._model.add_constraints(self.duration <= self._state_variable * mega, name=f'{self.label_full}|con1'),
-            'con1',
-        )
-
-        # Forward constraint
-        self.add(
-            self._model.add_constraints(
-                self.duration.isel(time=slice(1, None))
-                <= self.duration.isel(time=slice(None, -1)) + hours_per_step.isel(time=slice(None, -1)),
-                name=f'{self.label_full}|con2a',
-            ),
-            'con2a',
-        )
-
-        # Backward constraint
-        self.add(
-            self._model.add_constraints(
-                self.duration.isel(time=slice(1, None))
-                >= self.duration.isel(time=slice(None, -1))
-                + hours_per_step.isel(time=slice(None, -1))
-                + (self._state_variable.isel(time=slice(1, None)) - 1) * mega,
-                name=f'{self.label_full}|con2b',
-            ),
-            'con2b',
-        )
-
-        # Add minimum duration constraints if specified
-        if self._minimum_duration is not None:
-            self.add(
-                self._model.add_constraints(
-                    self.duration
-                    >= (
-                        self._state_variable.isel(time=slice(None, -1)) - self._state_variable.isel(time=slice(1, None))
-                    )
-                    * self._minimum_duration.isel(time=slice(None, -1)),
-                    name=f'{self.label_full}|minimum',
-                ),
-                'minimum',
-            )
-
-            # Handle initial condition
-            if 0 < self.previous_duration < self._minimum_duration.isel(time=0):
-                self.add(
-                    self._model.add_constraints(
-                        self._state_variable.isel(time=0) == 1, name=f'{self.label_full}|initial_minimum'
-                    ),
-                    'initial_minimum',
-                )
-
-        # Set initial value
-        self.add(
-            self._model.add_constraints(
-                self.duration.isel(time=0)
-                == (hours_per_step.isel(time=0) + self.previous_duration) * self._state_variable.isel(time=0),
-                name=f'{self.label_full}|initial',
-            ),
-            'initial',
-        )
-
-        return self
-
-    @property
-    def previous_duration(self) -> Scalar:
-        """Computes the previous duration of the state variable"""
-        # TODO: Allow for other/dynamic timestep resolutions
-        return ConsecutiveStateModel.compute_consecutive_hours_in_state(
-            self._previous_states, self._model.hours_per_step.isel(time=0).item()
-        )
-
-    @staticmethod
-    def compute_consecutive_hours_in_state(
-        binary_values: NumericData, hours_per_timestep: Union[int, float, np.ndarray]
-    ) -> Scalar:
-        """
-        Computes the final consecutive duration in state 'on' (=1) in hours, from a binary array.
-
-        Args:
-            binary_values: An int or 1D binary array containing only `0`s and `1`s.
-            hours_per_timestep: The duration of each timestep in hours.
-                If a scalar is provided, it is used for all timesteps.
-                If an array is provided, it must be as long as the last consecutive duration in binary_values.
-
-        Returns:
-            The duration of the binary variable in hours.
-
-        Raises
-        ------
-        TypeError
-            If the length of binary_values and dt_in_hours is not equal, but None is a scalar.
-        """
-        if np.isscalar(binary_values) and np.isscalar(hours_per_timestep):
-            return binary_values * hours_per_timestep
-        elif np.isscalar(binary_values) and not np.isscalar(hours_per_timestep):
-            return binary_values * hours_per_timestep[-1]
-
-        if np.isclose(binary_values[-1], 0, atol=CONFIG.modeling.EPSILON):
-            return 0
-
-        if np.isscalar(hours_per_timestep):
-            hours_per_timestep = np.ones(len(binary_values)) * hours_per_timestep
-        hours_per_timestep: np.ndarray
-
-        indexes_with_zero_values = np.where(np.isclose(binary_values, 0, atol=CONFIG.modeling.EPSILON))[0]
-        if len(indexes_with_zero_values) == 0:
-            nr_of_indexes_with_consecutive_ones = len(binary_values)
-        else:
-            nr_of_indexes_with_consecutive_ones = len(binary_values) - indexes_with_zero_values[-1] - 1
-
-        if len(hours_per_timestep) < nr_of_indexes_with_consecutive_ones:
-            raise ValueError(
-                f'When trying to calculate the consecutive duration, the length of the last duration '
-                f'({len(nr_of_indexes_with_consecutive_ones)}) is longer than the provided hours_per_timestep ({len(hours_per_timestep)}), '
-                f'as {binary_values=}'
-            )
-
-        return np.sum(
-            binary_values[-nr_of_indexes_with_consecutive_ones:]
-            * hours_per_timestep[-nr_of_indexes_with_consecutive_ones:]
-        )
-
+        self.parameters = parameters
+        super().__init__(model, label_of_element, label_of_model=label_of_model)
 
-class OnOffModel(Model):
-    """
-    Class for modeling the on and off state of a variable
-    Uses component models to create a modular implementation
-    """
+    def _do_modeling(self):
+        super()._do_modeling()
 
-    def __init__(
-        self,
-        model: SystemModel,
-        on_off_parameters: OnOffParameters,
-        label_of_element: str,
-        defining_variables: List[linopy.Variable],
-        defining_bounds: List[Tuple[NumericData, NumericData]],
-        previous_values: List[Optional[NumericData]],
-        label: Optional[str] = None,
-    ):
-        """
-        Constructor for OnOffModel
+        if self.parameters.use_off:
+            off = self.add_variables(binary=True, short_name='off', coords=self._model.get_coords())
+            self.add_constraints(self.on + off == 1, short_name='complementary')
 
-        Args:
-            model: Reference to the SystemModel
-            on_off_parameters: Parameters for the OnOffModel
-            label_of_element: Label of the Parent
-            defining_variables: List of Variables that are used to define the OnOffModel
-            defining_bounds: List of Tuples, defining the absolute bounds of each defining variable
-            previous_values: List of previous values of the defining variables
-            label: Label of the OnOffModel
-        """
-        super().__init__(model, label_of_element, label)
-        self.parameters = on_off_parameters
-        self._defining_variables = defining_variables
-        self._defining_bounds = defining_bounds
-        self._previous_values = previous_values
-
-        self.state_model = None
-        self.switch_state_model = None
-        self.consecutive_on_model = None
-        self.consecutive_off_model = None
-
-    def do_modeling(self):
-        """Create all variables and constraints for the OnOffModel"""
-
-        # Create binary state component
-        self.state_model = StateModel(
-            model=self._model,
-            label_of_element=self.label_of_element,
-            defining_variables=self._defining_variables,
-            defining_bounds=self._defining_bounds,
-            previous_values=self._previous_values,
-            use_off=self.parameters.use_off,
-            on_hours_total_min=self.parameters.on_hours_total_min,
-            on_hours_total_max=self.parameters.on_hours_total_max,
-            effects_per_running_hour=self.parameters.effects_per_running_hour,
+        # 3. Total duration tracking using existing pattern
+        ModelingPrimitives.expression_tracking_variable(
+            self,
+            tracked_expression=(self.on * self._model.hours_per_step).sum('time'),
+            bounds=(
+                self.parameters.on_hours_total_min if self.parameters.on_hours_total_min is not None else 0,
+                self.parameters.on_hours_total_max if self.parameters.on_hours_total_max is not None else np.inf,
+            ),  # TODO: self._model.hours_per_step.sum('time').item() + self._get_previous_on_duration())
+            short_name='on_hours_total',
+            coords=['period', 'scenario'],
         )
-        self.add(self.state_model)
-        self.state_model.do_modeling()
 
-        # Create switch component if needed
+        # 4. Switch tracking using existing pattern
         if self.parameters.use_switch_on:
-            self.switch_state_model = SwitchStateModel(
-                model=self._model,
-                label_of_element=self.label_of_element,
-                state_variable=self.state_model.on,
-                previous_state=self.state_model.previous_on_states[-1],
-                switch_on_max=self.parameters.switch_on_total_max,
-            )
-            self.add(self.switch_state_model)
-            self.switch_state_model.do_modeling()
+            self.add_variables(binary=True, short_name='switch|on', coords=self.get_coords())
+            self.add_variables(binary=True, short_name='switch|off', coords=self.get_coords())
+
+            BoundingPatterns.state_transition_bounds(
+                self,
+                state_variable=self.on,
+                switch_on=self.switch_on,
+                switch_off=self.switch_off,
+                name=f'{self.label_of_model}|switch',
+                previous_state=self._previous_states.isel(time=-1) if self._previous_states is not None else 0,
+                coord='time',
+            )
+
+            if self.parameters.switch_on_total_max is not None:
+                count = self.add_variables(
+                    lower=0,
+                    upper=self.parameters.switch_on_total_max,
+                    coords=self._model.get_coords(('period', 'scenario')),
+                    short_name='switch|count',
+                )
+                self.add_constraints(count == self.switch_on.sum('time'), short_name='switch|count')
 
-        # Create consecutive on hours component if needed
+        # 5. Consecutive on duration using existing pattern
         if self.parameters.use_consecutive_on_hours:
-            self.consecutive_on_model = ConsecutiveStateModel(
-                model=self._model,
-                label_of_element=self.label_of_element,
-                state_variable=self.state_model.on,
+            ModelingPrimitives.consecutive_duration_tracking(
+                self,
+                state_variable=self.on,
+                short_name='consecutive_on_hours',
                 minimum_duration=self.parameters.consecutive_on_hours_min,
                 maximum_duration=self.parameters.consecutive_on_hours_max,
-                previous_states=self.state_model.previous_on_states,
-                label='ConsecutiveOn',
+                duration_per_step=self.hours_per_step,
+                duration_dim='time',
+                previous_duration=self._get_previous_on_duration(),
             )
-            self.add(self.consecutive_on_model)
-            self.consecutive_on_model.do_modeling()
 
-        # Create consecutive off hours component if needed
+        # 6. Consecutive off duration using existing pattern
         if self.parameters.use_consecutive_off_hours:
-            self.consecutive_off_model = ConsecutiveStateModel(
-                model=self._model,
-                label_of_element=self.label_of_element,
-                state_variable=self.state_model.off,
+            ModelingPrimitives.consecutive_duration_tracking(
+                self,
+                state_variable=self.off,
+                short_name='consecutive_off_hours',
                 minimum_duration=self.parameters.consecutive_off_hours_min,
                 maximum_duration=self.parameters.consecutive_off_hours_max,
-                previous_states=self.state_model.previous_off_states,
-                label='ConsecutiveOff',
+                duration_per_step=self.hours_per_step,
+                duration_dim='time',
+                previous_duration=self._get_previous_off_duration(),
             )
-            self.add(self.consecutive_off_model)
-            self.consecutive_off_model.do_modeling()
+            # TODO:
 
-        self._create_shares()
+        self._add_effects()
 
-    def _create_shares(self):
+    def _add_effects(self):
+        """Add operational effects"""
         if self.parameters.effects_per_running_hour:
             self._model.effects.add_share_to_effects(
                 name=self.label_of_element,
                 expressions={
-                    effect: self.state_model.on * factor * self._model.hours_per_step
+                    effect: self.on * factor * self._model.hours_per_step
                     for effect, factor in self.parameters.effects_per_running_hour.items()
                 },
-                target='operation',
+                target='temporal',
             )
 
         if self.parameters.effects_per_switch_on:
             self._model.effects.add_share_to_effects(
                 name=self.label_of_element,
                 expressions={
-                    effect: self.switch_state_model.switch_on * factor
-                    for effect, factor in self.parameters.effects_per_switch_on.items()
+                    effect: self.switch_on * factor for effect, factor in self.parameters.effects_per_switch_on.items()
                 },
-                target='operation',
+                target='temporal',
             )
 
+    # Properties access variables from Submodel's tracking system
+
     @property
-    def on(self):
-        return self.state_model.on
+    def on_hours_total(self) -> linopy.Variable:
+        """Total on hours variable"""
+        return self['on_hours_total']
 
     @property
-    def off(self):
-        return self.state_model.off
+    def off(self) -> linopy.Variable | None:
+        """Binary off state variable"""
+        return self.get('off')
 
     @property
-    def switch_on(self):
-        return self.switch_state_model.switch_on
+    def switch_on(self) -> linopy.Variable | None:
+        """Switch on variable"""
+        return self.get('switch|on')
 
     @property
-    def switch_off(self):
-        return self.switch_state_model.switch_off
+    def switch_off(self) -> linopy.Variable | None:
+        """Switch off variable"""
+        return self.get('switch|off')
 
     @property
-    def switch_on_nr(self):
-        return self.switch_state_model.switch_on_nr
+    def switch_on_nr(self) -> linopy.Variable | None:
+        """Number of switch-ons variable"""
+        return self.get('switch|count')
 
     @property
-    def consecutive_on_hours(self):
-        return self.consecutive_on_model.duration
+    def consecutive_on_hours(self) -> linopy.Variable | None:
+        """Consecutive on hours variable"""
+        return self.get('consecutive_on_hours')
 
     @property
-    def consecutive_off_hours(self):
-        return self.consecutive_off_model.duration
+    def consecutive_off_hours(self) -> linopy.Variable | None:
+        """Consecutive off hours variable"""
+        return self.get('consecutive_off_hours')
+
+    def _get_previous_on_duration(self):
+        """Get previous on duration. Previously OFF by default, for one timestep"""
+        hours_per_step = self._model.hours_per_step.isel(time=0).min().item()
+        if self._previous_states is None:
+            return 0
+        else:
+            return ModelingUtilities.compute_consecutive_hours_in_state(self._previous_states, hours_per_step)
+
+    def _get_previous_off_duration(self):
+        """Get previous off duration. Previously OFF by default, for one timestep"""
+        hours_per_step = self._model.hours_per_step.isel(time=0).min().item()
+        if self._previous_states is None:
+            return hours_per_step
+        else:
+            return ModelingUtilities.compute_consecutive_hours_in_state(self._previous_states * -1 + 1, hours_per_step)
 
 
-class PieceModel(Model):
+class PieceModel(Submodel):
     """Class for modeling a linear piece of one or more variables in parallel"""
 
     def __init__(
         self,
-        model: SystemModel,
+        model: FlowSystemModel,
         label_of_element: str,
-        label: str,
-        as_time_series: bool = True,
+        label_of_model: str,
+        dims: FlowSystemDimensions | None,
     ):
-        super().__init__(model, label_of_element, label)
-        self.inside_piece: Optional[linopy.Variable] = None
-        self.lambda0: Optional[linopy.Variable] = None
-        self.lambda1: Optional[linopy.Variable] = None
-        self._as_time_series = as_time_series
-
-    def do_modeling(self):
-        self.inside_piece = self.add(
-            self._model.add_variables(
-                binary=True,
-                name=f'{self.label_full}|inside_piece',
-                coords=self._model.coords if self._as_time_series else None,
-            ),
-            'inside_piece',
-        )
+        self.inside_piece: linopy.Variable | None = None
+        self.lambda0: linopy.Variable | None = None
+        self.lambda1: linopy.Variable | None = None
+        self.dims = dims
 
-        self.lambda0 = self.add(
-            self._model.add_variables(
-                lower=0,
-                upper=1,
-                name=f'{self.label_full}|lambda0',
-                coords=self._model.coords if self._as_time_series else None,
-            ),
-            'lambda0',
+        super().__init__(model, label_of_element, label_of_model)
+
+    def _do_modeling(self):
+        super()._do_modeling()
+        self.inside_piece = self.add_variables(
+            binary=True,
+            short_name='inside_piece',
+            coords=self._model.get_coords(dims=self.dims),
+        )
+        self.lambda0 = self.add_variables(
+            lower=0,
+            upper=1,
+            short_name='lambda0',
+            coords=self._model.get_coords(dims=self.dims),
         )
 
-        self.lambda1 = self.add(
-            self._model.add_variables(
-                lower=0,
-                upper=1,
-                name=f'{self.label_full}|lambda1',
-                coords=self._model.coords if self._as_time_series else None,
-            ),
-            'lambda1',
+        self.lambda1 = self.add_variables(
+            lower=0,
+            upper=1,
+            short_name='lambda1',
+            coords=self._model.get_coords(dims=self.dims),
         )
 
         # eq:  lambda0(t) + lambda1(t) = inside_piece(t)
-        self.add(
-            self._model.add_constraints(
-                self.inside_piece == self.lambda0 + self.lambda1, name=f'{self.label_full}|inside_piece'
-            ),
-            'inside_piece',
-        )
+        self.add_constraints(self.inside_piece == self.lambda0 + self.lambda1, short_name='inside_piece')
 
 
-class PiecewiseModel(Model):
+class PiecewiseModel(Submodel):
     def __init__(
         self,
-        model: SystemModel,
+        model: FlowSystemModel,
         label_of_element: str,
-        piecewise_variables: Dict[str, Piecewise],
-        zero_point: Optional[Union[bool, linopy.Variable]],
-        as_time_series: bool,
-        label: str = '',
+        label_of_model: str,
+        piecewise_variables: dict[str, Piecewise],
+        zero_point: bool | linopy.Variable | None,
+        dims: FlowSystemDimensions | None,
     ):
         """
-        Modeling a Piecewise relation between multiple variables.
+        Modeling a Piecewise relation between miultiple variables.
         The relation is defined by a list of Pieces, which are assigned to the variables.
         Each Piece is a tuple of (start, end).
 
         Args:
-            model: The SystemModel that is used to create the model.
+            model: The FlowSystemModel that is used to create the model.
             label_of_element: The label of the parent (Element). Used to construct the full label of the model.
-            label: The label of the model. Used to construct the full label of the model.
+            label_of_model: The label of the model. Used to construct the full label of the model.
             piecewise_variables: The variables to which the Pieces are assigned.
-            zero_point: A variable that can be used to define a zero point for the Piecewise relation.
-                If None or False, no zero point is defined. THis leads to 0 not being possible,
-                unless its its contained in a Piece.
-            as_time_series: Whether the Piecewise relation is defined for a TimeSeries or a single variable.
+            zero_point: A variable that can be used to define a zero point for the Piecewise relation. If None or False, no zero point is defined.
+            dims: The dimensions used for variable creation. If None, all dimensions are used.
         """
-        super().__init__(model, label_of_element, label)
         self._piecewise_variables = piecewise_variables
         self._zero_point = zero_point
-        self._as_time_series = as_time_series
+        self.dims = dims
+
+        self.pieces: list[PieceModel] = []
+        self.zero_point: linopy.Variable | None = None
+        super().__init__(model, label_of_element=label_of_element, label_of_model=label_of_model)
 
-        self.pieces: List[PieceModel] = []
-        self.zero_point: Optional[linopy.Variable] = None
+    def _do_modeling(self):
+        super()._do_modeling()
+        # Validate all piecewise variables have the same number of segments
+        segment_counts = [len(pw) for pw in self._piecewise_variables.values()]
+        if not all(count == segment_counts[0] for count in segment_counts):
+            raise ValueError(f'All piecewises must have the same number of pieces, got {segment_counts}')
 
-    def do_modeling(self):
         for i in range(len(list(self._piecewise_variables.values())[0])):
-            new_piece = self.add(
+            new_piece = self.add_submodels(
                 PieceModel(
                     model=self._model,
                     label_of_element=self.label_of_element,
-                    label=f'Piece_{i}',
-                    as_time_series=self._as_time_series,
-                )
+                    label_of_model=f'{self.label_of_element}|Piece_{i}',
+                    dims=self.dims,
+                ),
+                short_name=f'Piece_{i}',
             )
             self.pieces.append(new_piece)
-            new_piece.do_modeling()
 
         for var_name in self._piecewise_variables:
             variable = self._model.variables[var_name]
-            self.add(
-                self._model.add_constraints(
-                    variable
-                    == sum(
-                        [
-                            piece_model.lambda0 * piece_bounds.start + piece_model.lambda1 * piece_bounds.end
-                            for piece_model, piece_bounds in zip(
-                                self.pieces, self._piecewise_variables[var_name], strict=False
-                            )
-                        ]
-                    ),
-                    name=f'{self.label_full}|{var_name}|lambda',
+            self.add_constraints(
+                variable
+                == sum(
+                    [
+                        piece_model.lambda0 * piece_bounds.start + piece_model.lambda1 * piece_bounds.end
+                        for piece_model, piece_bounds in zip(
+                            self.pieces, self._piecewise_variables[var_name], strict=False
+                        )
+                    ]
                 ),
-                f'{var_name}|lambda',
+                name=f'{self.label_full}|{var_name}|lambda',
+                short_name=f'{var_name}|lambda',
             )
 
             # a) eq: Segment1.onSeg(t) + Segment2.onSeg(t) + ... = 1                Aufenthalt nur in Segmenten erlaubt
             # b) eq: -On(t) + Segment1.onSeg(t) + Segment2.onSeg(t) + ... = 0       zusätzlich kann alles auch Null sein
             if isinstance(self._zero_point, linopy.Variable):
                 self.zero_point = self._zero_point
-                sign, rhs = '<=', self.zero_point
+                rhs = self.zero_point
             elif self._zero_point is True:
-                self.zero_point = self.add(
-                    self._model.add_variables(
-                        coords=self._model.coords, binary=True, name=f'{self.label_full}|zero_point'
-                    ),
-                    'zero_point',
+                self.zero_point = self.add_variables(
+                    coords=self._model.get_coords(self.dims),
+                    binary=True,
+                    short_name='zero_point',
                 )
-                sign, rhs = '<=', self.zero_point
+                rhs = self.zero_point
             else:
-                sign, rhs = '=', 1
-
-            self.add(
-                self._model.add_constraints(
-                    sum([piece.inside_piece for piece in self.pieces]),
-                    sign,
-                    rhs,
-                    name=f'{self.label_full}|{variable.name}|single_segment',
-                ),
-                f'{var_name}|single_segment',
-            )
+                rhs = 1
 
-
-class ShareAllocationModel(Model):
-    def __init__(
-        self,
-        model: SystemModel,
-        shares_are_time_series: bool,
-        label_of_element: Optional[str] = None,
-        label: Optional[str] = None,
-        label_full: Optional[str] = None,
-        total_max: Optional[Scalar] = None,
-        total_min: Optional[Scalar] = None,
-        max_per_hour: Optional[NumericData] = None,
-        min_per_hour: Optional[NumericData] = None,
-    ):
-        super().__init__(model, label_of_element=label_of_element, label=label, label_full=label_full)
-        if not shares_are_time_series:  # If the condition is True
-            assert max_per_hour is None and min_per_hour is None, (
-                'Both max_per_hour and min_per_hour cannot be used when shares_are_time_series is False'
-            )
-        self.total_per_timestep: Optional[linopy.Variable] = None
-        self.total: Optional[linopy.Variable] = None
-        self.shares: Dict[str, linopy.Variable] = {}
-        self.share_constraints: Dict[str, linopy.Constraint] = {}
-
-        self._eq_total_per_timestep: Optional[linopy.Constraint] = None
-        self._eq_total: Optional[linopy.Constraint] = None
-
-        # Parameters
-        self._shares_are_time_series = shares_are_time_series
-        self._total_max = total_max if total_min is not None else np.inf
-        self._total_min = total_min if total_min is not None else -np.inf
-        self._max_per_hour = max_per_hour if max_per_hour is not None else np.inf
-        self._min_per_hour = min_per_hour if min_per_hour is not None else -np.inf
-
-    def do_modeling(self):
-        self.total = self.add(
-            self._model.add_variables(
-                lower=self._total_min, upper=self._total_max, coords=None, name=f'{self.label_full}|total'
-            ),
-            'total',
-        )
-        # eq: sum = sum(share_i) # skalar
-        self._eq_total = self.add(
-            self._model.add_constraints(self.total == 0, name=f'{self.label_full}|total'), 'total'
-        )
-
-        if self._shares_are_time_series:
-            self.total_per_timestep = self.add(
-                self._model.add_variables(
-                    lower=-np.inf
-                    if (self._min_per_hour is None)
-                    else np.multiply(self._min_per_hour, self._model.hours_per_step),
-                    upper=np.inf
-                    if (self._max_per_hour is None)
-                    else np.multiply(self._max_per_hour, self._model.hours_per_step),
-                    coords=self._model.coords,
-                    name=f'{self.label_full}|total_per_timestep',
-                ),
-                'total_per_timestep',
-            )
-
-            self._eq_total_per_timestep = self.add(
-                self._model.add_constraints(self.total_per_timestep == 0, name=f'{self.label_full}|total_per_timestep'),
-                'total_per_timestep',
-            )
-
-            # Add it to the total
-            self._eq_total.lhs -= self.total_per_timestep.sum()
-
-    def add_share(
-        self,
-        name: str,
-        expression: linopy.LinearExpression,
-    ):
-        """
-        Add a share to the share allocation model. If the share already exists, the expression is added to the existing share.
-        The expression is added to the right hand side (rhs) of the constraint.
-        The variable representing the total share is on the left hand side (lhs) of the constraint.
-        var_total = sum(expressions)
-
-        Args:
-            name: The name of the share.
-            expression: The expression of the share. Added to the right hand side of the constraint.
-        """
-        if name in self.shares:
-            self.share_constraints[name].lhs -= expression
-        else:
-            self.shares[name] = self.add(
-                self._model.add_variables(
-                    coords=None
-                    if isinstance(expression, linopy.LinearExpression)
-                    and expression.ndim == 0
-                    or not isinstance(expression, linopy.LinearExpression)
-                    else self._model.coords,
-                    name=f'{name}->{self.label_full}',
-                ),
-                name,
-            )
-            self.share_constraints[name] = self.add(
-                self._model.add_constraints(self.shares[name] == expression, name=f'{name}->{self.label_full}'), name
+            self.add_constraints(
+                sum([piece.inside_piece for piece in self.pieces]) <= rhs,
+                name=f'{self.label_full}|{variable.name}|single_segment',
+                short_name=f'{var_name}|single_segment',
             )
-            if self.shares[name].ndim == 0:
-                self._eq_total.lhs -= self.shares[name]
-            else:
-                self._eq_total_per_timestep.lhs -= self.shares[name]
 
 
-class PiecewiseEffectsModel(Model):
+class PiecewiseEffectsModel(Submodel):
     def __init__(
         self,
-        model: SystemModel,
+        model: FlowSystemModel,
         label_of_element: str,
-        piecewise_origin: Tuple[str, Piecewise],
-        piecewise_shares: Dict[str, Piecewise],
-        zero_point: Optional[Union[bool, linopy.Variable]],
-        label: str = 'PiecewiseEffects',
+        label_of_model: str,
+        piecewise_origin: tuple[str, Piecewise],
+        piecewise_shares: dict[str, Piecewise],
+        zero_point: bool | linopy.Variable | None,
     ):
-        super().__init__(model, label_of_element, label)
-        assert len(piecewise_origin[1]) == len(list(piecewise_shares.values())[0]), (
-            'Piece length of variable_segments and share_segments must be equal'
-        )
+        origin_count = len(piecewise_origin[1])
+        share_counts = [len(pw) for pw in piecewise_shares.values()]
+        if not all(count == origin_count for count in share_counts):
+            raise ValueError(
+                f'Piece count mismatch: piecewise_origin has {origin_count} segments, '
+                f'but piecewise_shares have {share_counts}'
+            )
         self._zero_point = zero_point
         self._piecewise_origin = piecewise_origin
         self._piecewise_shares = piecewise_shares
-        self.shares: Dict[str, linopy.Variable] = {}
+        self.shares: dict[str, linopy.Variable] = {}
+
+        self.piecewise_model: PiecewiseModel | None = None
 
-        self.piecewise_model: Optional[PiecewiseModel] = None
+        super().__init__(model, label_of_element=label_of_element, label_of_model=label_of_model)
 
-    def do_modeling(self):
+    def _do_modeling(self):
         self.shares = {
-            effect: self.add(self._model.add_variables(coords=None, name=f'{self.label_full}|{effect}'), f'{effect}')
+            effect: self.add_variables(coords=self._model.get_coords(['period', 'scenario']), short_name=effect)
             for effect in self._piecewise_shares
         }
 
@@ -1062,124 +490,124 @@ class PiecewiseEffectsModel(Model):
             },
         }
 
-        self.piecewise_model = self.add(
+        self.piecewise_model = self.add_submodels(
             PiecewiseModel(
                 model=self._model,
                 label_of_element=self.label_of_element,
                 piecewise_variables=piecewise_variables,
                 zero_point=self._zero_point,
-                as_time_series=False,
-                label='PiecewiseEffects',
-            )
+                dims=('period', 'scenario'),
+                label_of_model=f'{self.label_of_element}|PiecewiseEffects',
+            ),
+            short_name='PiecewiseEffects',
         )
 
-        self.piecewise_model.do_modeling()
-
         # Shares
         self._model.effects.add_share_to_effects(
             name=self.label_of_element,
             expressions={effect: variable * 1 for effect, variable in self.shares.items()},
-            target='invest',
+            target='periodic',
         )
 
 
-class PiecewiseEffectsPerFlowHourModel(Model):
+class ShareAllocationModel(Submodel):
     def __init__(
         self,
-        model: SystemModel,
-        label_of_element: str,
-        piecewise_origin: Tuple[str, Piecewise],
-        piecewise_shares: Dict[str, Piecewise],
-        zero_point: Optional[Union[bool, linopy.Variable]],
-        label: str = 'PiecewiseEffectsPerFlowHour',
+        model: FlowSystemModel,
+        dims: list[FlowSystemDimensions],
+        label_of_element: str | None = None,
+        label_of_model: str | None = None,
+        total_max: Scalar | None = None,
+        total_min: Scalar | None = None,
+        max_per_hour: TemporalData | None = None,
+        min_per_hour: TemporalData | None = None,
     ):
-        super().__init__(model, label_of_element, label)
-        assert len(piecewise_origin[1]) == len(list(piecewise_shares.values())[0]), (
-            'Piece length of variable_segments and share_segments must be equal'
-        )
-        self._zero_point = zero_point
-        self._piecewise_origin = piecewise_origin
-        self._piecewise_shares = piecewise_shares
+        if 'time' not in dims and (max_per_hour is not None or min_per_hour is not None):
+            raise ValueError('Both max_per_hour and min_per_hour cannot be used when has_time_dim is False')
 
-        self.shares: Dict[str, linopy.Variable] = {}
+        self._dims = dims
+        self.total_per_timestep: linopy.Variable | None = None
+        self.total: linopy.Variable | None = None
+        self.shares: dict[str, linopy.Variable] = {}
+        self.share_constraints: dict[str, linopy.Constraint] = {}
 
-        self.piecewise_model: Optional[PiecewiseModel] = None
+        self._eq_total_per_timestep: linopy.Constraint | None = None
+        self._eq_total: linopy.Constraint | None = None
 
-    def do_modeling(self):
-        self.shares = {
-            effect: self.add(
-                self._model.add_variables(coords=self._model.coords, name=f'{self.label_full}|{effect}'), f'{effect}'
-            )
-            for effect in self._piecewise_shares
-        }
+        # Parameters
+        self._total_max = total_max if total_max is not None else np.inf
+        self._total_min = total_min if total_min is not None else -np.inf
+        self._max_per_hour = max_per_hour if max_per_hour is not None else np.inf
+        self._min_per_hour = min_per_hour if min_per_hour is not None else -np.inf
 
-        piecewise_variables = {
-            self._piecewise_origin[0]: self._piecewise_origin[1],
-            **{
-                self.shares[effect_label].name: self._piecewise_shares[effect_label]
-                for effect_label in self._piecewise_shares
-            },
-        }
+        super().__init__(model, label_of_element=label_of_element, label_of_model=label_of_model)
 
-        self.piecewise_model = self.add(
-            PiecewiseModel(
-                model=self._model,
-                label_of_element=self.label_of_element,
-                piecewise_variables=piecewise_variables,
-                zero_point=self._zero_point,
-                as_time_series=True,
-                label='PiecewiseEffectsPerFlowHour',
-            )
+    def _do_modeling(self):
+        super()._do_modeling()
+        self.total = self.add_variables(
+            lower=self._total_min,
+            upper=self._total_max,
+            coords=self._model.get_coords([dim for dim in self._dims if dim != 'time']),
+            name=self.label_full,
+            short_name='total',
         )
+        # eq: sum = sum(share_i) # skalar
+        self._eq_total = self.add_constraints(self.total == 0, name=self.label_full)
 
-        self.piecewise_model.do_modeling()
-
-        # Shares
-        self._model.effects.add_share_to_effects(
-            name=self.label_of_element,
-            expressions={effect: variable * self._model.hours_per_step for effect, variable in self.shares.items()},
-            target='operation',
-        )
+        if 'time' in self._dims:
+            self.total_per_timestep = self.add_variables(
+                lower=-np.inf if (self._min_per_hour is None) else self._min_per_hour * self._model.hours_per_step,
+                upper=np.inf if (self._max_per_hour is None) else self._max_per_hour * self._model.hours_per_step,
+                coords=self._model.get_coords(self._dims),
+                short_name='per_timestep',
+            )
 
+            self._eq_total_per_timestep = self.add_constraints(self.total_per_timestep == 0, short_name='per_timestep')
 
-class PreventSimultaneousUsageModel(Model):
-    """
-    Prevents multiple Multiple Binary variables from being 1 at the same time
+            # Add it to the total
+            self._eq_total.lhs -= self.total_per_timestep.sum(dim='time')
 
-    Only 'classic type is modeled for now (# "classic" -> alle Flows brauchen Binärvariable:)
-    In 'new', the binary Variables need to be forced beforehand, which is not that straight forward... --> TODO maybe
+    def add_share(
+        self,
+        name: str,
+        expression: linopy.LinearExpression,
+        dims: list[FlowSystemDimensions] | None = None,
+    ):
+        """
+        Add a share to the share allocation model. If the share already exists, the expression is added to the existing share.
+        The expression is added to the right hand side (rhs) of the constraint.
+        The variable representing the total share is on the left hand side (lhs) of the constraint.
+        var_total = sum(expressions)
 
+        Args:
+            name: The name of the share.
+            expression: The expression of the share. Added to the right hand side of the constraint.
+            dims: The dimensions of the share. Defaults to all dimensions. Dims are ordered automatically
+        """
+        if dims is None:
+            dims = self._dims
+        else:
+            if 'time' in dims and 'time' not in self._dims:
+                raise ValueError('Cannot add share with time-dim to a model without time-dim')
+            if 'period' in dims and 'period' not in self._dims:
+                raise ValueError('Cannot add share with period-dim to a model without period-dim')
+            if 'scenario' in dims and 'scenario' not in self._dims:
+                raise ValueError('Cannot add share with scenario-dim to a model without scenario-dim')
 
-    # "new":
-    # eq: flow_1.on(t) + flow_2.on(t) + .. + flow_i.val(t)/flow_i.max <= 1 (1 Flow ohne Binärvariable!)
+        if name in self.shares:
+            self.share_constraints[name].lhs -= expression
+        else:
+            self.shares[name] = self.add_variables(
+                coords=self._model.get_coords(dims),
+                name=f'{name}->{self.label_full}',
+                short_name=name,
+            )
 
-    # Anmerkung: Patrick Schönfeld (oemof, custom/link.py) macht bei 2 Flows ohne Binärvariable dies:
-    # 1)	bin + flow1/flow1_max <= 1
-    # 2)	bin - flow2/flow2_max >= 0
-    # 3)    geht nur, wenn alle flow.min >= 0
-    # --> könnte man auch umsetzen (statt force_on_variable() für die Flows, aber sollte aufs selbe wie "new" kommen)
-    """
+            self.share_constraints[name] = self.add_constraints(
+                self.shares[name] == expression, name=f'{name}->{self.label_full}'
+            )
 
-    def __init__(
-        self,
-        model: SystemModel,
-        variables: List[linopy.Variable],
-        label_of_element: str,
-        label: str = 'PreventSimultaneousUsage',
-    ):
-        super().__init__(model, label_of_element, label)
-        self._simultanious_use_variables = variables
-        assert len(self._simultanious_use_variables) >= 2, (
-            f'Model {self.__class__.__name__} must get at least two variables'
-        )
-        for variable in self._simultanious_use_variables:  # classic
-            assert variable.attrs['binary'], f'Variable {variable} must be binary for use in {self.__class__.__name__}'
-
-    def do_modeling(self):
-        # eq: sum(flow_i.on(t)) <= 1.1 (1 wird etwas größer gewählt wg. Binärvariablengenauigkeit)
-        self.add(
-            self._model.add_constraints(
-                sum(self._simultanious_use_variables) <= 1.1, name=f'{self.label_full}|prevent_simultaneous_use'
-            ),
-            'prevent_simultaneous_use',
-        )
+            if 'time' not in dims:
+                self._eq_total.lhs -= self.shares[name]
+            else:
+                self._eq_total_per_timestep.lhs -= self.shares[name]