firefighter-incident 0.0.24__py3-none-any.whl → 0.0.26__py3-none-any.whl

firefighter/_version.py

@@ -28,7 +28,7 @@ version_tuple: VERSION_TUPLE
 commit_id: COMMIT_ID
 __commit_id__: COMMIT_ID
 
-__version__ = version = '0.0.24'
-__version_tuple__ = version_tuple = (0, 0, 24)
+__version__ = version = '0.0.26'
+__version_tuple__ = version_tuple = (0, 0, 26)
 
 __commit_id__ = commit_id = None

firefighter/incidents/models/impact.py

@@ -40,29 +40,29 @@ class LevelChoices(models.TextChoices):
     @property
     def priority(self) -> int:
         """Send level choice priority ."""
-        priority_mapping = {
-            self.HIGHEST: 1,
-            self.HIGH: 2,
-            self.MEDIUM: 3,
-            self.LOW: 4,
-            self.LOWEST: 5,
-            self.NONE: 6,
+        priority_mapping: dict[str, int] = {
+            LevelChoices.HIGHEST: 1,
+            LevelChoices.HIGH: 2,
+            LevelChoices.MEDIUM: 3,
+            LevelChoices.LOW: 4,
+            LevelChoices.LOWEST: 5,
+            LevelChoices.NONE: 6,
         }
-        return priority_mapping.get(self, 6)  # type: ignore[call-overload]
+        return priority_mapping.get(self.value, 6)
 
     @property
     def emoji(self) -> str:
         """Send emoji un function of priority."""
         none_emoji = ""
-        emoji_mapping = {
-            self.HIGHEST: "⏫",
-            self.HIGH: "🔼",
-            self.MEDIUM: "➡️",
-            self.LOW: "🔽",
-            self.LOWEST: "⏬",
-            self.NONE: none_emoji,
+        emoji_mapping: dict[str, str] = {
+            LevelChoices.HIGHEST: "⏫",
+            LevelChoices.HIGH: "🔼",
+            LevelChoices.MEDIUM: "➡️",
+            LevelChoices.LOW: "🔽",
+            LevelChoices.LOWEST: "⏬",
+            LevelChoices.NONE: none_emoji,
         }
-        return emoji_mapping.get(self, none_emoji)  # type: ignore[call-overload]
+        return emoji_mapping.get(self.value, none_emoji)
 
 
 class ImpactLevel(models.Model):

firefighter/jira_app/service_postmortem.py

@@ -229,7 +229,7 @@ class JiraPostMortemService:
         - Zoho desk ticket (customfield_10896)
         - Zendesk ticket (customfield_10895)
         - Seller Contract ID (customfield_10908)
-        - Platform (customfield_10201)
+        - Platforms (customfield_10201) - first platform from list
         - Business Impact (customfield_10936)
 
         Args:
@@ -264,9 +264,10 @@ class JiraPostMortemService:
             fields["customfield_10908"] = str(seller_contract_id)
 
         # Platform - customfield_10201 (option field)
-        platform = custom_fields.get("platform")
-        if platform:
-            # Remove "platform-" prefix if present
+        platforms = custom_fields.get("platforms", [])
+        if platforms:
+            # Extract first platform and remove "platform-" prefix if present
+            platform = platforms[0] if isinstance(platforms, list) else platforms
             platform_value = platform.replace("platform-", "") if isinstance(platform, str) else platform
             fields["customfield_10201"] = {"value": platform_value}
 

firefighter/pagerduty/models.py

@@ -331,13 +331,13 @@ class PagerDutySchedule(models.Model):
     pagerduty_url = models.URLField(max_length=256, null=True, blank=True)
     # TODO: Add more fields
 
-    escalation_policies = models.ManyToManyField(
+    escalation_policies: models.ManyToManyField[PagerDutyEscalationPolicy, PagerDutyEscalationPolicy] = models.ManyToManyField(
         PagerDutyEscalationPolicy, related_name="pagerduty_schedule_set", blank=True
     )
-    users = models.ManyToManyField(
+    users: models.ManyToManyField[PagerDutyUser, PagerDutyUser] = models.ManyToManyField(
         PagerDutyUser, related_name="pagerduty_schedule_set", blank=True
     )
-    teams = models.ManyToManyField(
+    teams: models.ManyToManyField[PagerDutyTeam, PagerDutyTeam] = models.ManyToManyField(
         PagerDutyTeam, related_name="pagerduty_schedule_set", blank=True
     )
 

firefighter/raid/service.py

@@ -24,6 +24,10 @@ error_jira_ticket_creation = "Could not create Jira ticket"
 
 
 def check_issue_id(issue: JiraObject, title: str, reporter: str) -> int | str:
+    """Check and return the issue ID from a JiraObject.
+
+    Raises JiraAPIError if the issue ID is missing or invalid.
+    """
     issue_id = issue.get("id")
     if issue_id is None:
         logger.error(

firefighter/raid/types.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from typing import TypedDict
+from typing import NotRequired, TypedDict
 
 _JiraId = int | str
 _Key = str
@@ -12,8 +12,8 @@ _BusinessImpact = str
 
 
 class JiraObject(TypedDict):
-    id: _JiraId
-    key: _Key
+    id: NotRequired[_JiraId]
+    key: NotRequired[_Key]
     assignee_id: _AssigneeId
     reporter_id: _ReporterId
     description: _Description

firefighter/slack/views/modals/closure_reason.py

@@ -115,20 +115,25 @@ class ClosureReasonModal(IncidentSelectableModalMixin, SlackModal):
         self, ack: Ack, body: dict[str, Any], incident: Incident, user: User
     ) -> bool | None:
         """Handle the closure reason modal submission."""
-        # Early validation: Check if incident can be closed BEFORE calling ack()
-        # This validation happens BEFORE ack() so we can display errors in the modal
-        can_close, reasons = incident.can_be_closed
-        if not can_close:
-            # Build error message from reasons
-            error_messages = [reason[1] for reason in reasons]
-            error_text = "\n".join([f"• {msg}" for msg in error_messages])
-            ack(
-                response_action="errors",
-                errors={
-                    "closure_message": f"Cannot close this incident:\n{error_text}"
-                }
-            )
-            return False
+        # For early closure (OPEN/INVESTIGATING), we bypass normal workflow checks
+        # For normal closure (MITIGATED/POST_MORTEM), we must validate key events
+        current_status = incident.status
+        is_early_closure = current_status.value in {IncidentStatus.OPEN, IncidentStatus.INVESTIGATING}
+
+        if not is_early_closure:
+            # Normal closure path - validate that incident can be closed
+            can_close, reasons = incident.can_be_closed
+            if not can_close:
+                # Build error message from reasons
+                error_messages = [reason[1] for reason in reasons]
+                error_text = "\n".join([f"• {msg}" for msg in error_messages])
+                ack(
+                    response_action="errors",
+                    errors={
+                        "closure_message": f"Cannot close this incident:\n{error_text}"
+                    }
+                )
+                return False
 
         # Clear ALL modals in the stack (not just this one)
         # This ensures the underlying "Update Status" modal is also closed

{firefighter_incident-0.0.24.dist-info → firefighter_incident-0.0.26.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: firefighter-incident
-Version: 0.0.24
+Version: 0.0.26
 Summary: Incident Management tool made for Slack using Django
 Project-URL: Repository, https://github.com/ManoManoTech/firefighter-incident
 Project-URL: Documentation, https://manomanotech.github.io/firefighter-incident/latest/

{firefighter_incident-0.0.24.dist-info → firefighter_incident-0.0.26.dist-info}/RECORD

@@ -6,7 +6,7 @@ gunicorn.conf.py,sha256=vHsTGjaKOr8FDMp6fTKYTX4AtokmPgYvvt5Mr0Q6APc,273
 main.py,sha256=CsbprHoOYhjCLpTJmq9Z_aRYFoFgWxoz2pDLuwm8Eqg,1558
 manage.py,sha256=5ivHGD13C6nJ8QvltKsJ9T9akA5he8da70HLWaEP3k8,689
 firefighter/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-firefighter/_version.py,sha256=XrY1zhka91SvYFuoqczo63946VCS-B_2e6wTaL8sPYQ,706
+firefighter/_version.py,sha256=Fnf259POysYSI-aH6DhnxuHUxCVOFWsQLs4I5Ur_KMA,706
 firefighter/api/__init__.py,sha256=JQW0Bv6xwGqy7ioxx3h6UGMzkkJ4DntDpbvV1Ncgi8k,136
 firefighter/api/admin.py,sha256=x9Ysy-GiYjb0rynmFdS9g56e6n24fkN0ouGy5QD9Yrc,4629
 firefighter/api/apps.py,sha256=P5uU1_gMrDfzurdMbfqw1Bnb2uNKKcMq17WBPg2sLhc,204
@@ -180,7 +180,7 @@ firefighter/incidents/migrations/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRk
 firefighter/incidents/models/__init__.py,sha256=FLVyBwIdyxLdgSvXRAKC3fry9YwwqlqhitTIuG0vWrk,877
 firefighter/incidents/models/environment.py,sha256=51txwua3dCrWZ1iSG3ZA8rbDn9c00pyMAZujl9gwE5c,827
 firefighter/incidents/models/group.py,sha256=VrVL315VFUvKW69AZuRUBg1h0jZJvn8zWeMxMOWec1Y,700
-firefighter/incidents/models/impact.py,sha256=bzTTW79FmclLcAKN0wmk739cXBiYIY_YHpkkASGn5Rw,4776
+firefighter/incidents/models/impact.py,sha256=D9NngMtg4XdDWnMgdVYaWCoUZ-fMXTvfL0eTEk9sc7M,4854
 firefighter/incidents/models/incident.py,sha256=UdL9bc-3Ou-OS8P-nHO4YF6-Hk0mDkGNq1zjOq-TNFk,28022
 firefighter/incidents/models/incident_category.py,sha256=g4OHv_XQhWcH6dvkqkyCgjlruo_1eih_CdtAPgPhaW4,7744
 firefighter/incidents/models/incident_cost.py,sha256=juwOfJKRaNQpOHkRUCHShDDba0FU98YjRPkU4I0ofAU,1346
@@ -273,7 +273,7 @@ firefighter/jira_app/admin.py,sha256=ZHAAbhy0hm_DcklK59KMmid_ZiPn8n5V6g7cZCSNrpc
 firefighter/jira_app/apps.py,sha256=T6vHrQuMZHJoTth-xjy3CbNfPv6DyXgcR3PSMju2JS4,504
 firefighter/jira_app/client.py,sha256=qpMqNTjJUq5OqAxmwvVOE20uJe7kp737HSdsiqUu1G4,21982
 firefighter/jira_app/models.py,sha256=2zKy5VaKkhiHYA8Dukz8g0NTG82Qy5UHAHY9eMv67NE,3097
-firefighter/jira_app/service_postmortem.py,sha256=b76f1uv-zUo4jUWXTul4nv8UnaqQXHzuoTYEDrEpcMA,10620
+firefighter/jira_app/service_postmortem.py,sha256=7VQwtVGCVZaVGfRxQXL19IM4hHrgHmItUbrsyy2gZlM,10764
 firefighter/jira_app/types.py,sha256=Ukak1U1EhcH2jQPN-UoEL6AMZ-kzPsQ8c7FUr7GmahE,956
 firefighter/jira_app/utils.py,sha256=3xuzr8viZCBm6j2J9oFzA4bUvVW8TN1DOdlpbruJ_TE,3443
 firefighter/jira_app/management/__init__.py,sha256=wy4qMZb7_K-INwwGGEhMtEeI0XTLqgUw4P8_-VEnrEw,40
@@ -298,7 +298,7 @@ firefighter/pagerduty/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3h
 firefighter/pagerduty/admin.py,sha256=PmC227877OM-dq86953aQppu8TMWPnCZy4xJw5NST6E,3216
 firefighter/pagerduty/apps.py,sha256=l9cVqMhntdtvWBhM6vRTJPUhYB6p1YNQaAvssVBQsdY,451
 firefighter/pagerduty/client.py,sha256=wdS_rDBrMkuuQs_2bEOoz2OmjMBJLjMrBAMdoPK4rHE,2205
-firefighter/pagerduty/models.py,sha256=wIAT2-BELi30blhYQKOlAxO5qV4kFv3ILVI7i0PKaJk,19448
+firefighter/pagerduty/models.py,sha256=zlTaIr65qME3ZFJL7iMxhFq5O2ILKLbteolrARIRAew,19634
 firefighter/pagerduty/service.py,sha256=kZDBkTe2NZ8bZw8_9nKSvzaM3fv9k4iekpkWV-62fhw,2943
 firefighter/pagerduty/urls.py,sha256=2eOf-fZnXg3uW4pH68yE-0xJpSGLCXbKCrdShfbJHvM,455
 firefighter/pagerduty/forms/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
@@ -329,8 +329,8 @@ firefighter/raid/messages.py,sha256=e75kwi0hCe5ChwU4t-_6Q3Rcy22MLLdVSsYyjvG2SCM,
 firefighter/raid/models.py,sha256=29Smci739K1ZdcMu7uXYvoVEhgDpwLQoCzBbc5wvwhs,2211
 firefighter/raid/resources.py,sha256=39GhITs3OAWA1eSPZme-rLd818kuz7gwYzdN38zNz8Y,436
 firefighter/raid/serializers.py,sha256=4U6UFUNVR68lBYDzjYp8j1JzmfSftASOp1nQifCRXYQ,11941
-firefighter/raid/service.py,sha256=rxRjEpA5wg4JRe4UrGW-y8C8quHvGlJzQ0U8rdy-DyM,8490
-firefighter/raid/types.py,sha256=0lFy_Wl3Ekyy_sxTHPRxMn3kjEJVWCTPjmefDlrPqMQ,438
+firefighter/raid/service.py,sha256=Njk8mXSTzrSdDyvFcPWqcWqJoA2lsSRIWjK8bgIAYpA,8618
+firefighter/raid/types.py,sha256=E0ZUjBCMwCgr0eSX3CfRTpmq0n-jMans1WxoYSnj7xg,477
 firefighter/raid/urls.py,sha256=oESkDY2tfZcnPGUgULqixvbV3Z7YsZfeI10RX3A5tZY,924
 firefighter/raid/utils.py,sha256=OhsuFb46lokVxjyfeBFLMcMIGzjkTrrdd6DCXUJym0E,1111
 firefighter/raid/migrations/0001_initial_oss.py,sha256=oZQ44dHboLeHbvVyziHX_hhdis8H_Buv2W3jHiDzQhA,6259
@@ -411,7 +411,7 @@ firefighter/slack/views/events/message_deleted.py,sha256=tyA1-sAlG9ImcKIhqSn6Egu
 firefighter/slack/views/events/reaction_added.py,sha256=AipwBnrU5B35D97YIZCXdSW8W7-9QTIIQqUcrLTLQ5c,4241
 firefighter/slack/views/modals/__init__.py,sha256=U9PapAIlpuYqBonOUmBGWT8_HjQa35ilMQJXGaFLgd0,1945
 firefighter/slack/views/modals/close.py,sha256=4j5iA-lmIFuCz7B9pgDmjxrqmfWFysqWEn1YIsE75zc,12161
-firefighter/slack/views/modals/closure_reason.py,sha256=3ot1cb4Wzvwe-TAuR16ZopnWGInUmoeDUaKzOQ838kw,7600
+firefighter/slack/views/modals/closure_reason.py,sha256=N-gp0E6W8Z1d4aH1-8BxizNTlZ4syNIF4l5B9WZHFFA,7898
 firefighter/slack/views/modals/downgrade_workflow.py,sha256=cRWsm3DmKRRI1-Jpjprb5xeY2U7HvRo6eZlUbGuzr1A,3192
 firefighter/slack/views/modals/edit.py,sha256=1N0OBSxsDuN6lJoH-djbEljy7f0LcDEpJF-U5YoEFXA,5895
 firefighter/slack/views/modals/key_event_message.py,sha256=C6yhQLQ6jBuhIr-YAoAyt-qZKu0V6nJMGZ_t3DLtUbo,5943
@@ -482,7 +482,7 @@ firefighter_tests/test_jira_app/test_incident_key_events_sync.py,sha256=ytXHzlwc
 firefighter_tests/test_jira_app/test_jira_client_watchers.py,sha256=IBrFjwhOP0rfm58BBq339CySxjdJkPYjGmISC4oQhZc,4803
 firefighter_tests/test_jira_app/test_models.py,sha256=QfMLrJVXSWqu29XEbJO6xXpOkugcdWti5_bmCEX2m3Y,4626
 firefighter_tests/test_jira_app/test_postmortem_issue_link.py,sha256=CF0UDmHOY08Oj3MYtDKNtkVDq_nbQ0nesvFWF8Rv944,7750
-firefighter_tests/test_jira_app/test_postmortem_service.py,sha256=DAlQxlPlB_Fd038hLeSu0PCO-Izo0z1dBgLXv4twvTE,15114
+firefighter_tests/test_jira_app/test_postmortem_service.py,sha256=gUimkgf3NNIxHFDeZ5GNNzLHdaPKQCZDrTPdHmbyqDc,15120
 firefighter_tests/test_jira_app/test_timeline_template.py,sha256=_PtFnIib2HfjyylNRQXcjvdhrsoAJICOKauIDsYFQRk,4902
 firefighter_tests/test_raid/conftest.py,sha256=i_TOquYIMLDyVQ97uqxTqPJszVz4qq7L_Q7YJxTuS1o,4090
 firefighter_tests/test_raid/test_raid_alert_p4_p5.py,sha256=rz9orbt1E1vJ5POQyVZ6-SEPvqB55-xhwIWHicdfgDg,9356
@@ -518,8 +518,8 @@ firefighter_tests/test_slack/views/modals/test_send_sos.py,sha256=_rE6jD-gOzcGyh
 firefighter_tests/test_slack/views/modals/test_status.py,sha256=oQzPfwdg2tkbo9nfkO1GfS3WydxqSC6vy1AZjZDKT30,2226
 firefighter_tests/test_slack/views/modals/test_update_status.py,sha256=3ARHZPs22FTx7IjgOldzEpVxxWeHqEbe4kQphUuSp34,55928
 firefighter_tests/test_slack/views/modals/test_utils.py,sha256=DJd2n9q6fFu8UuCRdiq9U_Cn19MdnC5c-ydLLrk6rkc,5218
-firefighter_incident-0.0.24.dist-info/METADATA,sha256=w-Gv8lFlwRJYusYzUdvM8oWJR5k--NyHgGNtPqmaMgQ,5570
-firefighter_incident-0.0.24.dist-info/WHEEL,sha256=WLgqFyCfm_KASv4WHyYy0P3pM_m7J5L9k2skdKLirC8,87
-firefighter_incident-0.0.24.dist-info/entry_points.txt,sha256=c13meJbv7YNmYz7MipMOQwzQ5IeFOPXUBYAJ44XMQsM,61
-firefighter_incident-0.0.24.dist-info/licenses/LICENSE,sha256=krRiGp-a9-1nH1bWpBEdxyTKLhjLmn6DMVVoIb0zF90,1087
-firefighter_incident-0.0.24.dist-info/RECORD,,
+firefighter_incident-0.0.26.dist-info/METADATA,sha256=6maVl16hOTcZXnEYTy1PhaP4ligQTcK5QVZesD6C5a0,5570
+firefighter_incident-0.0.26.dist-info/WHEEL,sha256=WLgqFyCfm_KASv4WHyYy0P3pM_m7J5L9k2skdKLirC8,87
+firefighter_incident-0.0.26.dist-info/entry_points.txt,sha256=c13meJbv7YNmYz7MipMOQwzQ5IeFOPXUBYAJ44XMQsM,61
+firefighter_incident-0.0.26.dist-info/licenses/LICENSE,sha256=krRiGp-a9-1nH1bWpBEdxyTKLhjLmn6DMVVoIb0zF90,1087
+firefighter_incident-0.0.26.dist-info/RECORD,,

firefighter_tests/test_jira_app/test_postmortem_service.py

@@ -261,7 +261,7 @@ class TestJiraPostMortemService:
                 "zendesk_ticket_id": "12345",
                 "zoho_desk_ticket_id": "67890",
                 "seller_contract_id": "98765",
-                "platform": "platform-FR",
+                "platforms": ["platform-FR"],
                 "environments": ["PRD", "STG"],
             },
         )
@@ -404,7 +404,7 @@ class TestJiraPostMortemService:
             _status=IncidentStatus.POST_MORTEM,
             created_by=user,
             custom_fields={
-                "platform": "platform-DE",
+                "platforms": ["platform-DE"],
             },
         )