firefighter-incident 0.0.14__py3-none-any.whl → 0.0.15__py3-none-any.whl

firefighter_tests/test_raid/test_raid_forms.py

@@ -7,7 +7,6 @@ from django.test import TestCase
 from slack_sdk.errors import SlackApiError
 
 from firefighter.incidents.factories import (
-    IncidentCategoryFactory,
     IncidentFactory,
     PriorityFactory,
     UserFactory,
@@ -16,12 +15,7 @@ from firefighter.incidents.models.priority import Priority
 from firefighter.jira_app.client import JiraAPIError, JiraUserNotFoundError
 from firefighter.jira_app.models import JiraUser
 from firefighter.raid.forms import (
-    CreateNormalCustomerIncidentForm,
-    CreateRaidDocumentationRequestIncidentForm,
-    CreateRaidFeatureRequestIncidentForm,
-    CreateRaidInternalIncidentForm,
     PlatformChoices,
-    RaidCreateIncidentSellerForm,
     alert_slack_comment_ticket,
     alert_slack_new_jira_ticket,
     alert_slack_update_ticket,
@@ -33,7 +27,7 @@ from firefighter.raid.forms import (
     send_message_to_watchers,
     set_jira_ticket_watchers_raid,
 )
-from firefighter.raid.models import FeatureTeam, JiraTicket
+from firefighter.raid.models import JiraTicket
 from firefighter.slack.models.conversation import Conversation
 from firefighter.slack.models.user import SlackUser
 
@@ -70,252 +64,15 @@ class TestInitialPriority:
         assert result == default_priority
 
 
-@pytest.mark.django_db
-class TestCreateNormalCustomerIncidentForm:
-    """Test CreateNormalCustomerIncidentForm functionality."""
-
-    def setup_method(self):
-        """Set up test data."""
-        Priority.objects.all().delete()  # Clear existing priorities
-        self.user = UserFactory()
-        self.jira_user = JiraUser.objects.create(id="jira-123", user=self.user)
-        self.priority = PriorityFactory(value=1)
-        self.incident_category = IncidentCategoryFactory()
-        self.feature_team = FeatureTeam.objects.create(
-            name="Test Team", jira_project_key="TEST"
-        )
-
-    @patch("firefighter.raid.forms.process_jira_issue")
-    @patch("firefighter.raid.forms.create_issue_customer")
-    @patch("firefighter.raid.forms.get_jira_user_from_user")
-    @patch("firefighter.raid.forms.get_business_impact")
-    def test_trigger_incident_workflow(
-        self, mock_get_business_impact, mock_get_jira_user, mock_create_issue, mock_process_jira_issue
-    ):
-        """Test trigger_incident_workflow method."""
-        # Given
-        mock_get_jira_user.return_value = self.jira_user
-        mock_create_issue.return_value = {"id": "10001", "key": "TEST-123"}
-        mock_get_business_impact.return_value = "High"
-        mock_process_jira_issue.return_value = None
-
-        form_data = {
-            "incident_category": self.incident_category,
-            "platform": "platform-FR",
-            "title": "Test incident title",
-            "description": "Test incident description",
-            "priority": self.priority,
-            "suggested_team_routing": self.feature_team,
-            "zendesk_ticket_id": "12345",
-        }
-
-        form = CreateNormalCustomerIncidentForm()
-        form.cleaned_data = form_data
-
-        # When
-        form.trigger_incident_workflow(self.user, {})
-
-        # Then
-        mock_get_jira_user.assert_called_once_with(self.user)
-        mock_create_issue.assert_called_once()
-        mock_process_jira_issue.assert_called_once()
-
-
-@pytest.mark.django_db
-class TestCreateRaidDocumentationRequestIncidentForm:
-    """Test CreateRaidDocumentationRequestIncidentForm functionality."""
-
-    def setup_method(self):
-        """Set up test data."""
-        Priority.objects.all().delete()  # Clear existing priorities
-        self.user = UserFactory()
-        self.jira_user = JiraUser.objects.create(id="jira-doc-123", user=self.user)
-        self.priority = PriorityFactory(value=20)
-        self.incident_category = IncidentCategoryFactory()
-        self.feature_team = FeatureTeam.objects.create(
-            name="Documentation Team", jira_project_key="DOC"
-        )
-
-    @patch("firefighter.raid.forms.process_jira_issue")
-    @patch("firefighter.raid.forms.create_issue_documentation_request")
-    @patch("firefighter.raid.forms.get_jira_user_from_user")
-    def test_trigger_incident_workflow(
-        self, mock_get_jira_user, mock_create_issue, mock_process_jira_issue
-    ):
-        """Test trigger_incident_workflow method."""
-        # Given
-        mock_get_jira_user.return_value = self.jira_user
-        mock_create_issue.return_value = {"id": "10002", "key": "TEST-124"}
-        mock_process_jira_issue.return_value = None
-
-        form_data = {
-            "incident_category": self.incident_category,
-            "platform": "platform-DE",
-            "title": "Documentation request title",
-            "description": "Documentation request description",
-            "priority": self.priority,
-            "suggested_team_routing": self.feature_team,
-        }
-
-        form = CreateRaidDocumentationRequestIncidentForm()
-        form.cleaned_data = form_data
-
-        # When
-        form.trigger_incident_workflow(self.user, {})
-
-        # Then
-        mock_get_jira_user.assert_called_once_with(self.user)
-        mock_create_issue.assert_called_once()
-        mock_process_jira_issue.assert_called_once()
-
-
-@pytest.mark.django_db
-class TestCreateRaidFeatureRequestIncidentForm:
-    """Test CreateRaidFeatureRequestIncidentForm functionality."""
-
-    def setup_method(self):
-        """Set up test data."""
-        self.user = UserFactory()
-        self.jira_user = JiraUser.objects.create(id="jira-feat-123", user=self.user)
-        self.priority = PriorityFactory(value=30)
-        self.incident_category = IncidentCategoryFactory()
-        self.feature_team = FeatureTeam.objects.create(
-            name="Feature Team", jira_project_key="FEAT"
-        )
-
-    @patch("firefighter.raid.forms.process_jira_issue")
-    @patch("firefighter.raid.forms.create_issue_feature_request")
-    @patch("firefighter.raid.forms.get_jira_user_from_user")
-    def test_trigger_incident_workflow(
-        self, mock_get_jira_user, mock_create_issue, mock_process_jira_issue
-    ):
-        """Test trigger_incident_workflow method."""
-        # Given
-        mock_get_jira_user.return_value = self.jira_user
-        mock_create_issue.return_value = {"id": "10003", "key": "TEST-125"}
-        mock_process_jira_issue.return_value = None
-
-        form_data = {
-            "incident_category": self.incident_category,
-            "platform": "platform-IT",
-            "title": "Feature request title",
-            "description": "Feature request description",
-            "priority": self.priority,
-            "suggested_team_routing": self.feature_team,
-        }
-
-        form = CreateRaidFeatureRequestIncidentForm()
-        form.cleaned_data = form_data
-
-        # When
-        form.trigger_incident_workflow(self.user, {})
-
-        # Then
-        mock_get_jira_user.assert_called_once_with(self.user)
-        mock_create_issue.assert_called_once()
-        mock_process_jira_issue.assert_called_once()
-
-
-@pytest.mark.django_db
-class TestCreateRaidInternalIncidentForm:
-    """Test CreateRaidInternalIncidentForm functionality."""
-
-    def setup_method(self):
-        """Set up test data."""
-        self.user = UserFactory()
-        self.jira_user = JiraUser.objects.create(id="jira-int-123", user=self.user)
-        self.priority = PriorityFactory(value=40)
-        self.incident_category = IncidentCategoryFactory()
-        self.feature_team = FeatureTeam.objects.create(
-            name="Internal Team", jira_project_key="INT"
-        )
-
-    @patch("firefighter.raid.forms.process_jira_issue")
-    @patch("firefighter.raid.forms.create_issue_internal")
-    @patch("firefighter.raid.forms.get_jira_user_from_user")
-    @patch("firefighter.raid.forms.get_business_impact")
-    def test_trigger_incident_workflow(
-        self, mock_get_business_impact, mock_get_jira_user, mock_create_issue, mock_process_jira_issue
-    ):
-        """Test trigger_incident_workflow method."""
-        # Given
-        mock_get_jira_user.return_value = self.jira_user
-        mock_create_issue.return_value = {"id": "10004", "key": "TEST-126"}
-        mock_get_business_impact.return_value = "Medium"
-        mock_process_jira_issue.return_value = None
-
-        form_data = {
-            "incident_category": self.incident_category,
-            "platform": "platform-ES",
-            "title": "Internal incident title",
-            "description": "Internal incident description",
-            "priority": self.priority,
-            "suggested_team_routing": self.feature_team,
-        }
-
-        form = CreateRaidInternalIncidentForm()
-        form.cleaned_data = form_data
-
-        # When
-        form.trigger_incident_workflow(self.user, {})
-
-        # Then
-        mock_get_jira_user.assert_called_once_with(self.user)
-        mock_create_issue.assert_called_once()
-        mock_process_jira_issue.assert_called_once()
-
-
-@pytest.mark.django_db
-class TestRaidCreateIncidentSellerForm:
-    """Test RaidCreateIncidentSellerForm functionality."""
-
-    def setup_method(self):
-        """Set up test data."""
-        self.user = UserFactory()
-        self.jira_user = JiraUser.objects.create(id="jira-sell-123", user=self.user)
-        self.priority = PriorityFactory(value=50)
-        self.incident_category = IncidentCategoryFactory()
-        self.feature_team = FeatureTeam.objects.create(
-            name="Seller Team", jira_project_key="SELL"
-        )
-
-    @patch("firefighter.raid.forms.process_jira_issue")
-    @patch("firefighter.raid.forms.create_issue_seller")
-    @patch("firefighter.raid.forms.get_jira_user_from_user")
-    @patch("firefighter.raid.forms.get_business_impact")
-    def test_trigger_incident_workflow(
-        self, mock_get_business_impact, mock_get_jira_user, mock_create_issue, mock_process_jira_issue
-    ):
-        """Test trigger_incident_workflow method."""
-        # Given
-        mock_get_jira_user.return_value = self.jira_user
-        mock_create_issue.return_value = {"id": "10005", "key": "TEST-127"}
-        mock_get_business_impact.return_value = "Low"
-        mock_process_jira_issue.return_value = None
-
-        form_data = {
-            "incident_category": self.incident_category,
-            "platform": "platform-UK",
-            "title": "Seller incident title",
-            "description": "Seller incident description",
-            "priority": self.priority,
-            "suggested_team_routing": self.feature_team,
-            "seller_contract_id": "SELLER123",
-            "is_key_account": True,
-            "is_seller_in_golden_list": False,
-            "zoho_desk_ticket_id": "ZOHO456",
-        }
-
-        form = RaidCreateIncidentSellerForm()
-        form.cleaned_data = form_data
-
-        # When
-        form.trigger_incident_workflow(self.user, {})
-
-        # Then
-        mock_get_jira_user.assert_called_once_with(self.user)
-        mock_create_issue.assert_called_once()
-        mock_process_jira_issue.assert_called_once()
+# NOTE: Form class tests (TestCreateNormalCustomerIncidentForm,
+# TestCreateRaidDocumentationRequestIncidentForm, TestCreateRaidFeatureRequestIncidentForm,
+# TestCreateRaidInternalIncidentForm, TestRaidCreateIncidentSellerForm) have been removed.
+#
+# These forms have been replaced by the unified incident form:
+# firefighter.incidents.forms.unified_incident.UnifiedIncidentForm
+#
+# Tests for the unified form should be added in a new file:
+# tests/test_incidents/test_forms/test_unified_incident.py
 
 
 @pytest.mark.django_db

firefighter_tests/test_raid/test_raid_signals.py

@@ -0,0 +1,187 @@
+"""Tests for RAID signal handlers."""
+
+from __future__ import annotations
+
+from unittest.mock import Mock, patch
+
+import pytest
+
+from firefighter.incidents.enums import IncidentStatus
+from firefighter.incidents.models.incident_update import IncidentUpdate
+from firefighter.raid.signals.incident_updated import (
+    incident_updated_close_ticket_when_mitigated_or_postmortem,
+)
+
+
+@pytest.mark.django_db
+class TestIncidentUpdatedCloseJiraTicket:
+    """Test that Jira tickets are closed when incidents reach terminal statuses."""
+
+    @patch("firefighter.raid.signals.incident_updated.client.close_issue")
+    def test_close_jira_ticket_when_status_changes_to_mitigated(
+        self, mock_close_issue: Mock, incident_factory, user_factory, jira_ticket_factory
+    ) -> None:
+        """Test that Jira ticket is closed when incident status changes to MITIGATED."""
+        user = user_factory()
+        incident = incident_factory(created_by=user)
+        jira_ticket = jira_ticket_factory(incident=incident)
+        incident.jira_ticket = jira_ticket
+
+        incident_update = IncidentUpdate(
+            incident=incident,
+            status=IncidentStatus.MITIGATED,
+            created_by=user,
+        )
+
+        # Call the signal handler
+        incident_updated_close_ticket_when_mitigated_or_postmortem(
+            sender="update_status",
+            incident=incident,
+            incident_update=incident_update,
+            updated_fields=["_status"],
+        )
+
+        # Verify close_issue was called
+        mock_close_issue.assert_called_once_with(issue_id=jira_ticket.id)
+
+    @patch("firefighter.raid.signals.incident_updated.client.close_issue")
+    def test_close_jira_ticket_when_status_changes_to_postmortem(
+        self, mock_close_issue: Mock, incident_factory, user_factory, jira_ticket_factory
+    ) -> None:
+        """Test that Jira ticket is closed when incident status changes to POST_MORTEM."""
+        user = user_factory()
+        incident = incident_factory(created_by=user)
+        jira_ticket = jira_ticket_factory(incident=incident)
+        incident.jira_ticket = jira_ticket
+
+        incident_update = IncidentUpdate(
+            incident=incident,
+            status=IncidentStatus.POST_MORTEM,
+            created_by=user,
+        )
+
+        # Call the signal handler
+        incident_updated_close_ticket_when_mitigated_or_postmortem(
+            sender="update_status",
+            incident=incident,
+            incident_update=incident_update,
+            updated_fields=["_status"],
+        )
+
+        # Verify close_issue was called
+        mock_close_issue.assert_called_once_with(issue_id=jira_ticket.id)
+
+    @patch("firefighter.raid.signals.incident_updated.client.close_issue")
+    def test_close_jira_ticket_when_status_changes_to_closed(
+        self, mock_close_issue: Mock, incident_factory, user_factory, jira_ticket_factory
+    ) -> None:
+        """Test that Jira ticket is closed when incident status changes to CLOSED (direct close)."""
+        user = user_factory()
+        incident = incident_factory(created_by=user)
+        jira_ticket = jira_ticket_factory(incident=incident)
+        incident.jira_ticket = jira_ticket
+
+        incident_update = IncidentUpdate(
+            incident=incident,
+            status=IncidentStatus.CLOSED,
+            created_by=user,
+        )
+
+        # Call the signal handler
+        incident_updated_close_ticket_when_mitigated_or_postmortem(
+            sender="update_status",
+            incident=incident,
+            incident_update=incident_update,
+            updated_fields=["_status"],
+        )
+
+        # Verify close_issue was called
+        mock_close_issue.assert_called_once_with(issue_id=jira_ticket.id)
+
+    @patch("firefighter.raid.signals.incident_updated.client.close_issue")
+    def test_do_not_close_jira_ticket_when_status_not_terminal(
+        self, mock_close_issue: Mock, incident_factory, user_factory, jira_ticket_factory
+    ) -> None:
+        """Test that Jira ticket is NOT closed for non-terminal statuses."""
+        user = user_factory()
+        incident = incident_factory(created_by=user)
+        jira_ticket = jira_ticket_factory(incident=incident)
+        incident.jira_ticket = jira_ticket
+
+        incident_update = IncidentUpdate(
+            incident=incident,
+            status=IncidentStatus.INVESTIGATING,
+            created_by=user,
+        )
+
+        # Call the signal handler
+        incident_updated_close_ticket_when_mitigated_or_postmortem(
+            sender="update_status",
+            incident=incident,
+            incident_update=incident_update,
+            updated_fields=["_status"],
+        )
+
+        # Verify close_issue was NOT called
+        mock_close_issue.assert_not_called()
+
+    @patch("firefighter.raid.signals.incident_updated.client.close_issue")
+    def test_do_not_close_jira_ticket_when_status_not_updated(
+        self, mock_close_issue: Mock, incident_factory, user_factory, jira_ticket_factory
+    ) -> None:
+        """Test that Jira ticket is NOT closed when _status is not in updated_fields."""
+        user = user_factory()
+        incident = incident_factory(created_by=user)
+        jira_ticket = jira_ticket_factory(incident=incident)
+        incident.jira_ticket = jira_ticket
+
+        incident_update = IncidentUpdate(
+            incident=incident,
+            status=IncidentStatus.CLOSED,
+            created_by=user,
+        )
+
+        # Call the signal handler with updated_fields that don't include _status
+        incident_updated_close_ticket_when_mitigated_or_postmortem(
+            sender="update_status",
+            incident=incident,
+            incident_update=incident_update,
+            updated_fields=["priority_id"],  # Not _status
+        )
+
+        # Verify close_issue was NOT called
+        mock_close_issue.assert_not_called()
+
+    @patch("firefighter.raid.signals.incident_updated.client.close_issue")
+    @patch("firefighter.raid.signals.incident_updated.logger")
+    def test_do_not_crash_when_jira_ticket_missing(
+        self,
+        mock_logger: Mock,
+        mock_close_issue: Mock,
+        incident_factory,
+        user_factory,
+    ) -> None:
+        """Test that signal handler handles gracefully when Jira ticket is missing."""
+        user = user_factory()
+        incident = incident_factory(created_by=user)
+        # No jira_ticket attached to incident
+
+        incident_update = IncidentUpdate(
+            incident=incident,
+            status=IncidentStatus.CLOSED,
+            created_by=user,
+        )
+
+        # Call the signal handler - should not crash
+        incident_updated_close_ticket_when_mitigated_or_postmortem(
+            sender="update_status",
+            incident=incident,
+            incident_update=incident_update,
+            updated_fields=["_status"],
+        )
+
+        # Verify close_issue was NOT called
+        mock_close_issue.assert_not_called()
+
+        # Verify a warning was logged
+        mock_logger.warning.assert_called_once()