firefighter-incident 0.0.13__py3-none-any.whl → 0.0.15__py3-none-any.whl

firefighter_tests/test_slack/views/modals/test_open.py

@@ -6,8 +6,10 @@ from unittest.mock import MagicMock, Mock, patch
 import pytest
 from slack_sdk.models.blocks.blocks import (
     ContextBlock,
+    SectionBlock,
 )
 
+from firefighter.incidents.factories import IncidentCategoryFactory
 from firefighter.incidents.forms.create_incident import CreateIncidentFormBase
 from firefighter.incidents.models.user import User
 from firefighter.slack.views.modals.open import OpeningData, OpenModal
@@ -64,6 +66,7 @@ def test_validate_details_form_valid() -> None:
     details_form_modal_class = MagicMock(spec=SetIncidentDetails)
     details_form_class = MagicMock(spec=CreateIncidentFormBase)
     details_form_data = {"key": "value"}
+    open_incident_context = build_opening_data()
 
     details_form_modal_class.form_class = details_form_class
 
@@ -72,7 +75,7 @@ def test_validate_details_form_valid() -> None:
     details_form_class.return_value = details_form_instance
 
     is_valid, returned_form_class, returned_form = OpenModal._validate_details_form(
-        details_form_modal_class, details_form_data
+        details_form_modal_class, details_form_data, open_incident_context
     )
 
     assert is_valid is True
@@ -84,6 +87,7 @@ def test_validate_details_form_invalid() -> None:
     details_form_modal_class = MagicMock(spec=SetIncidentDetails)
     details_form_class = MagicMock(spec=CreateIncidentFormBase)
     details_form_data = {"key": "value"}
+    open_incident_context = build_opening_data()
 
     details_form_modal_class.form_class = details_form_class
 
@@ -92,7 +96,7 @@ def test_validate_details_form_invalid() -> None:
     details_form_class.return_value = details_form_instance
 
     is_valid, returned_form_class, returned_form = OpenModal._validate_details_form(
-        details_form_modal_class, details_form_data
+        details_form_modal_class, details_form_data, open_incident_context
     )
 
     assert is_valid is False
@@ -139,3 +143,143 @@ def test_build_modal_fn_empty(user: User) -> None:
 
     # View should not have a submit button
     assert view.submit is None
+
+
+@pytest.mark.django_db
+def test_get_done_review_blocks_with_custom_fields(
+    user: User, priority_factory, environment_factory
+) -> None:
+    """Test that get_done_review_blocks doesn't crash when form has custom fields."""
+    # Use factories to create DB objects
+    priority = priority_factory(value=1, default=True)
+    environment = environment_factory(value="PRD", default=True)
+    category = IncidentCategoryFactory()
+
+    # Create a mock form with cleaned_data containing custom fields
+    mock_form = MagicMock(spec=CreateIncidentFormBase)
+    mock_form.cleaned_data = {
+        "title": "Test incident with custom fields",
+        "description": "Testing custom fields handling",
+        "priority": priority,
+        "incident_category": category,
+        "environment": [environment],
+        "platform": ["platform-FR"],
+        # Custom fields that should be removed before creating Incident
+        "zendesk_ticket_id": "ZD-12345",
+        "seller_contract_id": "SELLER-789",
+        "zoho_desk_ticket_id": "ZOHO-456",
+        "is_key_account": True,
+        "is_seller_in_golden_list": False,
+        "suggested_team_routing": None,
+    }
+
+    open_incident_context = build_opening_data(response_type="critical")
+
+    # Should not raise TypeError about unexpected keyword arguments
+    blocks = OpenModal.get_done_review_blocks(
+        open_incident_context,
+        user,
+        details_form_done=True,
+        details_form_class=type(mock_form),
+        details_form=mock_form,
+        can_submit=True,
+    )
+
+    # Should return blocks (at least the divider and tada block)
+    assert len(blocks) >= 2
+
+
+@pytest.mark.django_db
+def test_get_done_review_blocks_critical_includes_slack_and_jira_messages(
+    user: User, priority_factory, environment_factory
+) -> None:
+    """Test that critical incidents show both Slack channel and Jira ticket messages."""
+    # Use factories to create DB objects
+    priority = priority_factory(value=1, default=True)
+    environment = environment_factory(value="PRD", default=True)
+    category = IncidentCategoryFactory()
+
+    # Create a mock form with cleaned_data
+    mock_form = MagicMock(spec=CreateIncidentFormBase)
+    mock_form.cleaned_data = {
+        "title": "Test critical incident",
+        "description": "Testing Slack and Jira messages",
+        "priority": priority,
+        "incident_category": category,
+        "environment": [environment],
+    }
+
+    open_incident_context = build_opening_data(response_type="critical")
+
+    blocks = OpenModal.get_done_review_blocks(
+        open_incident_context,
+        user,
+        details_form_done=True,
+        details_form_class=type(mock_form),
+        details_form=mock_form,
+        can_submit=True,
+    )
+
+    # Find the SectionBlock containing the message
+    section_blocks = [block for block in blocks if isinstance(block, SectionBlock)]
+    assert len(section_blocks) >= 1
+
+    # Get the last SectionBlock which should contain the Slack + Jira message
+    message_block = section_blocks[-1].text
+    # Extract text string - it could be a string or a MarkdownTextObject
+    assert message_block is not None, "SectionBlock text should not be None"
+    message_text = message_block.text if hasattr(message_block, "text") else str(message_block)
+
+    # Verify both Slack and Jira messages are present
+    assert ":slack:" in message_text, "Slack channel message should be present for critical incidents"
+    assert "A dedicated Slack channel will be created" in message_text
+    assert ":jira_new:" in message_text
+    assert "An associated Jira ticket will also be created" in message_text
+
+
+@pytest.mark.django_db
+def test_get_done_review_blocks_normal_includes_only_jira_message(
+    user: User, priority_factory, environment_factory
+) -> None:
+    """Test that normal incidents show only Jira ticket message (no Slack channel)."""
+    # Use factories to create DB objects
+    priority = priority_factory(value=4, default=False)
+    environment = environment_factory(value="PRD", default=True)
+    category = IncidentCategoryFactory()
+
+    # Create a mock form with cleaned_data
+    mock_form = MagicMock(spec=CreateIncidentFormBase)
+    mock_form.cleaned_data = {
+        "title": "Test normal incident",
+        "description": "Testing Jira-only message",
+        "priority": priority,
+        "incident_category": category,
+        "environment": [environment],
+    }
+
+    open_incident_context = build_opening_data(response_type="normal")
+
+    blocks = OpenModal.get_done_review_blocks(
+        open_incident_context,
+        user,
+        details_form_done=True,
+        details_form_class=type(mock_form),
+        details_form=mock_form,
+        can_submit=True,
+    )
+
+    # Find the SectionBlock containing the message
+    section_blocks = [block for block in blocks if isinstance(block, SectionBlock)]
+    assert len(section_blocks) >= 1
+
+    # Get the last SectionBlock which should contain only the Jira message
+    message_block = section_blocks[-1].text
+    # Extract text string - it could be a string or a MarkdownTextObject
+    assert message_block is not None, "SectionBlock text should not be None"
+    message_text = message_block.text if hasattr(message_block, "text") else str(message_block)
+
+    # Verify only Jira message is present (no Slack channel mention)
+    assert ":slack:" not in message_text, "Slack channel message should NOT be present for normal incidents"
+    assert "Slack channel" not in message_text
+    assert ":jira_new:" in message_text
+    assert "A Jira ticket will be created" in message_text

firefighter_tests/test_slack/views/modals/test_opening_unified.py

@@ -0,0 +1,421 @@
+"""Tests for unified incident opening modal."""
+from __future__ import annotations
+
+import json
+
+import pytest
+
+from firefighter.incidents.models.impact import LevelChoices
+from firefighter.slack.views.modals.base_modal.form_utils import SlackForm
+from firefighter.slack.views.modals.opening.details.unified import (
+    OpeningUnifiedModal,
+    UnifiedIncidentFormSlack,
+)
+
+
+@pytest.mark.django_db
+class TestUnifiedIncidentFormSlack:
+    """Test Slack-specific version of unified form."""
+
+    def test_form_initializes_with_impacts_and_response_type(
+        self, priority_factory, impact_level_factory
+    ):
+        """Form should properly receive impacts_data and response_type."""
+        priority_factory(value=1, default=True)
+        customer_impact = impact_level_factory(value=LevelChoices.HIGH, impact__name="Customers")
+
+        impacts_data = {"customers_impact": customer_impact}
+
+        form = UnifiedIncidentFormSlack(
+            impacts_data=impacts_data,
+            response_type="critical",
+        )
+
+        # Should configure field visibility
+        assert "zendesk_ticket_id" in form.fields
+        assert "suggested_team_routing" not in form.fields
+
+    def test_slack_blocks_generation_with_multiple_choice_fields(
+        self, priority_factory, environment_factory
+    ):
+        """Slack blocks should generate correctly with multiple choice fields."""
+        priority_factory(value=1, default=True)
+        environment_factory(value="PRD", default=True)
+        environment_factory(value="STG", default=False)
+
+        # Use SlackForm wrapper to generate blocks
+        slack_form = SlackForm(UnifiedIncidentFormSlack)(
+            impacts_data={},
+            response_type="critical",
+        )
+
+        # Should generate blocks without errors
+        blocks = slack_form.slack_blocks()
+        assert len(blocks) > 0
+
+        # Find environment block (multi-select)
+        env_blocks = [b for b in blocks if hasattr(b, "block_id") and b.block_id == "environment"]
+        assert len(env_blocks) == 1
+
+        env_block = env_blocks[0]
+        assert env_block.element.type == "multi_static_select"
+
+    def test_priority_field_is_hidden(self, priority_factory):
+        """Priority field should not appear in Slack blocks."""
+        priority_factory(value=1, default=True)
+
+        # Use SlackForm wrapper to generate blocks
+        slack_form = SlackForm(UnifiedIncidentFormSlack)(
+            impacts_data={},
+            response_type="critical",
+        )
+
+        blocks = slack_form.slack_blocks()
+
+        # Priority field should not generate a block (it's hidden)
+        priority_blocks = [
+            b for b in blocks if hasattr(b, "block_id") and b.block_id == "priority"
+        ]
+        assert len(priority_blocks) == 0
+
+
+@pytest.mark.django_db
+class TestOpeningUnifiedModal:
+    """Test the unified opening modal."""
+
+    def test_build_modal_fn_passes_context_to_form(
+        self, priority_factory, impact_level_factory
+    ):
+        """build_modal_fn should pass impacts and response_type to form."""
+        priority_factory(value=1, default=True)
+        customer_impact = impact_level_factory(value=LevelChoices.HIGH, impact__name="Customers")
+
+        modal = OpeningUnifiedModal()
+
+        open_incident_context = {
+            "response_type": "critical",
+            "impact_form_data": {"customers_impact": customer_impact},
+            "details_form_data": {},
+        }
+
+        view = modal.build_modal_fn(open_incident_context=open_incident_context)
+
+        # Should build view without errors
+        assert view is not None
+        assert view.type == "modal"
+        assert len(view.blocks) > 0
+
+        # Check private_metadata contains our context
+        metadata = json.loads(view.private_metadata)
+        assert metadata["response_type"] == "critical"
+        assert "impact_form_data" in metadata
+
+    def test_build_modal_fn_critical_incident_hides_feature_team(
+        self, priority_factory
+    ):
+        """Critical incident should not show feature team field."""
+        priority_factory(value=1, default=True)
+
+        modal = OpeningUnifiedModal()
+
+        open_incident_context = {
+            "response_type": "critical",
+            "impact_form_data": {},
+            "details_form_data": {},
+        }
+
+        view = modal.build_modal_fn(open_incident_context=open_incident_context)
+
+        # Check that feature team field is not in blocks
+        feature_team_blocks = [
+            b
+            for b in view.blocks
+            if hasattr(b, "block_id") and b.block_id == "suggested_team_routing"
+        ]
+        assert len(feature_team_blocks) == 0
+
+    def test_build_modal_fn_normal_incident_shows_feature_team(
+        self, priority_factory
+    ):
+        """Normal incident (P4-P5) should show feature team field."""
+        priority_factory(value=4, default=True)
+
+        modal = OpeningUnifiedModal()
+
+        open_incident_context = {
+            "response_type": "normal",
+            "impact_form_data": {},
+            "details_form_data": {},
+        }
+
+        view = modal.build_modal_fn(open_incident_context=open_incident_context)
+
+        # Check that feature team field IS in blocks
+        feature_team_blocks = [
+            b
+            for b in view.blocks
+            if hasattr(b, "block_id") and b.block_id == "suggested_team_routing"
+        ]
+        assert len(feature_team_blocks) == 1
+
+    def test_build_modal_fn_customer_impact_shows_zendesk(
+        self, priority_factory, impact_level_factory
+    ):
+        """Customer impact should show Zendesk field."""
+        priority_factory(value=1, default=True)
+        customer_impact = impact_level_factory(value=LevelChoices.HIGH, impact__name="Customers")
+
+        modal = OpeningUnifiedModal()
+
+        open_incident_context = {
+            "response_type": "critical",
+            "impact_form_data": {"customers_impact": customer_impact},
+            "details_form_data": {},
+        }
+
+        view = modal.build_modal_fn(open_incident_context=open_incident_context)
+
+        # Check that zendesk field IS in blocks
+        zendesk_blocks = [
+            b
+            for b in view.blocks
+            if hasattr(b, "block_id") and b.block_id == "zendesk_ticket_id"
+        ]
+        assert len(zendesk_blocks) == 1
+
+    def test_build_modal_fn_seller_impact_shows_seller_fields(
+        self, priority_factory, impact_level_factory
+    ):
+        """Seller impact should show seller-specific fields."""
+        priority_factory(value=1, default=True)
+        seller_impact = impact_level_factory(value=LevelChoices.LOW, impact__name="Sellers")
+
+        modal = OpeningUnifiedModal()
+
+        open_incident_context = {
+            "response_type": "critical",
+            "impact_form_data": {"sellers_impact": seller_impact},
+            "details_form_data": {},
+        }
+
+        view = modal.build_modal_fn(open_incident_context=open_incident_context)
+
+        # Check seller fields are in blocks
+        seller_contract_blocks = [
+            b
+            for b in view.blocks
+            if hasattr(b, "block_id") and b.block_id == "seller_contract_id"
+        ]
+        assert len(seller_contract_blocks) == 1
+
+        zoho_blocks = [
+            b
+            for b in view.blocks
+            if hasattr(b, "block_id") and b.block_id == "zoho_desk_ticket_id"
+        ]
+        assert len(zoho_blocks) == 1
+
+    def test_build_modal_fn_business_impact_only_hides_customer_seller_fields(
+        self, priority_factory, impact_level_factory
+    ):
+        """Business impact only should not show customer/seller fields."""
+        priority_factory(value=1, default=True)
+        business_impact = impact_level_factory(value=LevelChoices.HIGH, impact__name="Business")
+
+        modal = OpeningUnifiedModal()
+
+        open_incident_context = {
+            "response_type": "critical",
+            "impact_form_data": {"business_impact": business_impact},
+            "details_form_data": {},
+        }
+
+        view = modal.build_modal_fn(open_incident_context=open_incident_context)
+
+        # Should NOT show customer or seller fields
+        zendesk_blocks = [
+            b
+            for b in view.blocks
+            if hasattr(b, "block_id") and b.block_id == "zendesk_ticket_id"
+        ]
+        assert len(zendesk_blocks) == 0
+
+        seller_blocks = [
+            b
+            for b in view.blocks
+            if hasattr(b, "block_id") and b.block_id == "seller_contract_id"
+        ]
+        assert len(seller_blocks) == 0
+
+    def test_build_modal_fn_employee_impact_only_hides_customer_seller_fields(
+        self, priority_factory, impact_level_factory
+    ):
+        """Employee impact only should not show customer/seller fields."""
+        priority_factory(value=1, default=True)
+        employee_impact = impact_level_factory(value=LevelChoices.HIGH, impact__name="Employees")
+
+        modal = OpeningUnifiedModal()
+
+        open_incident_context = {
+            "response_type": "critical",
+            "impact_form_data": {"employees_impact": employee_impact},
+            "details_form_data": {},
+        }
+
+        view = modal.build_modal_fn(open_incident_context=open_incident_context)
+
+        # Should NOT show customer or seller fields
+        zendesk_blocks = [
+            b
+            for b in view.blocks
+            if hasattr(b, "block_id") and b.block_id == "zendesk_ticket_id"
+        ]
+        assert len(zendesk_blocks) == 0
+
+        seller_blocks = [
+            b
+            for b in view.blocks
+            if hasattr(b, "block_id") and b.block_id == "seller_contract_id"
+        ]
+        assert len(seller_blocks) == 0
+
+    def test_build_modal_fn_all_impacts_shows_all_fields(
+        self, priority_factory, impact_level_factory
+    ):
+        """All impact types should show all specific fields."""
+        priority_factory(value=1, default=True)
+        customer_impact = impact_level_factory(value=LevelChoices.LOW, impact__name="Customers")
+        seller_impact = impact_level_factory(value=LevelChoices.LOW, impact__name="Sellers")
+        employee_impact = impact_level_factory(value=LevelChoices.HIGH, impact__name="Employees")
+        business_impact = impact_level_factory(value=LevelChoices.HIGH, impact__name="Business")
+
+        modal = OpeningUnifiedModal()
+
+        open_incident_context = {
+            "response_type": "critical",
+            "impact_form_data": {
+                "customers_impact": customer_impact,
+                "sellers_impact": seller_impact,
+                "employees_impact": employee_impact,
+                "business_impact": business_impact,
+            },
+            "details_form_data": {},
+        }
+
+        view = modal.build_modal_fn(open_incident_context=open_incident_context)
+
+        # Should show both customer and seller fields
+        zendesk_blocks = [
+            b
+            for b in view.blocks
+            if hasattr(b, "block_id") and b.block_id == "zendesk_ticket_id"
+        ]
+        assert len(zendesk_blocks) == 1
+
+        seller_blocks = [
+            b
+            for b in view.blocks
+            if hasattr(b, "block_id") and b.block_id == "seller_contract_id"
+        ]
+        assert len(seller_blocks) == 1
+
+    def test_build_modal_fn_none_impacts_hides_all_fields(
+        self, priority_factory, impact_level_factory
+    ):
+        """All impacts at NONE level should not show any specific fields."""
+        priority_factory(value=1, default=True)
+        customer_impact = impact_level_factory(value=LevelChoices.NONE, impact__name="Customers")
+        seller_impact = impact_level_factory(value=LevelChoices.NONE, impact__name="Sellers")
+
+        modal = OpeningUnifiedModal()
+
+        open_incident_context = {
+            "response_type": "critical",
+            "impact_form_data": {
+                "customers_impact": customer_impact,
+                "sellers_impact": seller_impact,
+            },
+            "details_form_data": {},
+        }
+
+        view = modal.build_modal_fn(open_incident_context=open_incident_context)
+
+        # Should NOT show any specific fields
+        zendesk_blocks = [
+            b
+            for b in view.blocks
+            if hasattr(b, "block_id") and b.block_id == "zendesk_ticket_id"
+        ]
+        assert len(zendesk_blocks) == 0
+
+        seller_blocks = [
+            b
+            for b in view.blocks
+            if hasattr(b, "block_id") and b.block_id == "seller_contract_id"
+        ]
+        assert len(seller_blocks) == 0
+
+    def test_build_modal_fn_normal_with_customer_shows_team_and_zendesk(
+        self, priority_factory, impact_level_factory
+    ):
+        """P4-P5 with customer impact should show both feature team and Zendesk."""
+        priority_factory(value=4, default=True)
+        customer_impact = impact_level_factory(value=LevelChoices.HIGH, impact__name="Customers")
+
+        modal = OpeningUnifiedModal()
+
+        open_incident_context = {
+            "response_type": "normal",
+            "impact_form_data": {"customers_impact": customer_impact},
+            "details_form_data": {},
+        }
+
+        view = modal.build_modal_fn(open_incident_context=open_incident_context)
+
+        # Should show both fields
+        team_blocks = [
+            b
+            for b in view.blocks
+            if hasattr(b, "block_id") and b.block_id == "suggested_team_routing"
+        ]
+        assert len(team_blocks) == 1
+
+        zendesk_blocks = [
+            b
+            for b in view.blocks
+            if hasattr(b, "block_id") and b.block_id == "zendesk_ticket_id"
+        ]
+        assert len(zendesk_blocks) == 1
+
+    def test_handle_modal_fn_preserves_custom_fields_in_validation(
+        self, priority_factory, impact_level_factory
+    ):
+        """Form validation during submission should preserve custom fields based on impact context."""
+        # Setup
+        priority = priority_factory(value=1, default=True)
+        customer_impact = impact_level_factory(value=LevelChoices.HIGH, impact__name="Customers")
+
+        modal = OpeningUnifiedModal()
+
+        # Simulate private_metadata as it would be in the modal submission
+        private_metadata = {
+            "response_type": "critical",
+            "impact_form_data": {"customers_impact": str(customer_impact.id)},
+            "details_form_data": {"priority": str(priority.id)},
+        }
+
+        # This is what handle_modal_fn now does (with our fix)
+        # It passes open_incident_context to the form initialization
+        slack_form = modal.get_form_class()(
+            data={},  # Empty data for this test - we just want to verify field visibility
+            open_incident_context=private_metadata,
+        )
+
+        form = slack_form.form
+
+        # Verify that zendesk_ticket_id field exists in the form
+        # This proves the context was passed correctly and field visibility was configured
+        assert "zendesk_ticket_id" in form.fields, "zendesk_ticket_id should be present in form fields when customer impact is selected"
+
+        # Verify that suggested_team_routing is NOT in the form (critical incident)
+        assert "suggested_team_routing" not in form.fields, "suggested_team_routing should not be present for critical incidents"