emrt.necd.content 2.5.49__zip → 2.5.51__zip

{emrt.necd.content-2.5.49 → emrt.necd.content-2.5.51}/docs/HISTORY.txt

@@ -1,6 +1,16 @@
 Changelog
 =========
 
+2.5.51 (2024-05-23)
+
+- Bug #270288 - Fix observation not reindexing after new comments
+
+2.5.50 (2024-04-30)
+
+- Task #260973 - Add formatting
+- Task #260971 - Review if flags need updating/ all are still relevant
+- Bug #269439 - Error when editing conclusion text
+
 2.5.49 (2024-04-25)
 
 - Task #260971 - Add "Description flags" to carryover

{emrt.necd.content-2.5.49 → emrt.necd.content-2.5.51}/emrt/necd/content/conclusions.py

@@ -1,5 +1,3 @@
-import datetime
-from copy import copy
 from logging import getLogger
 from AccessControl import getSecurityManager
 from Acquisition import aq_base
@@ -12,9 +10,7 @@ from emrt.necd.content import MessageFactory as _
 from emrt.necd.content.utils import hidden
 from emrt.necd.content.utils import get_vocabulary_value
 from plone import api
-import plone.z3cform.templates
 from plone.app.dexterity.behaviors.discussion import IAllowDiscussion
-from plone.app.textfield import RichText
 from plone.dexterity.browser import add
 from plone.dexterity.browser import edit
 from plone.dexterity.content import Container
@@ -70,7 +66,7 @@ class IConclusions(form.Schema, IImageScaleTraversable):
         required=True,
     )
 
-    text = RichText(
+    text = schema.Text(
         title=_(u'Text'),
         required=True,
         default=u'',
@@ -244,6 +240,7 @@ class PseudoConclusion(object):
     text = u''
     closing_reason = ''
     highlight = ''
+    highlight_vocabulary = ''
 
     def __init__(self, context):
         self.context = context
@@ -258,6 +255,7 @@ class PseudoConclusion(object):
 
     def __call__(self, container):
         self.highlight = container.highlight
+        self.highlight_vocabulary = container.highlight_vocabulary
         # [refs #102793] needed by vocabularies
         self.type = container.type  # inventory/projection
         return self

{emrt.necd.content-2.5.49 → emrt.necd.content-2.5.51}/emrt/necd/content/configure.zcml

@@ -193,6 +193,12 @@
     handler="emrt.necd.content.notifications.observation_finalisation_request.notification_lr"
     />
 
+  <!-- New comment, reindex number of replies -->
+  <subscriber
+    for="plone.app.discussion.interfaces.IComment zope.lifecycleevent.IObjectAddedEvent"
+    handler="emrt.necd.content.subscribers.new_discussion_comment"
+    />
+
   <!-- Crons view -->
   <browser:page
       name="cron_update_vocabularies"

{emrt.necd.content-2.5.49 → emrt.necd.content-2.5.51}/emrt/necd/content/profiles/default/metadata.xml

@@ -1,5 +1,5 @@
 <metadata>
-  <version>2.5.49</version>
+  <version>2.5.51</version>
     <dependencies>
         <dependency>profile-plone.app.dexterity:default</dependency>
         <dependency>profile-plone.app.ldap:ldap</dependency>

{emrt.necd.content-2.5.49 → emrt.necd.content-2.5.51}/emrt/necd/content/reviewfolder.py

@@ -1,3 +1,4 @@
+from collections import namedtuple
 import itertools
 import time
 from StringIO import StringIO
@@ -133,14 +134,17 @@ def get_finalisation_reasons(reviewfolder):
     return reasons
 
 
+MissingHighlight = namedtuple("MissingHighlight", ["title"])
+
 def translate_highlights(vocab, keys):
-    return tuple(vocab.getTerm(x).title for x in keys)
+    return tuple(
+        vocab.by_token.get(x, MissingHighlight(x)).title for x in keys)
 
 
-def get_highlight_vocabs(context):
+def get_highlight_vocabs(context, voc_name=None):
     vocab_highlight = getUtility(
         IVocabularyFactory,
-        name='emrt.necd.content.highlight')(context)
+        name='emrt.necd.content.highlight')(context, voc_name)
 
     vocab_highlight_values = tuple([
         term.value for term in vocab_highlight
@@ -159,6 +163,28 @@ def get_highlight_vocabs(context):
 
     return vocab_description_flags, vocab_conclusion_flags, vocab_highlight
 
+def classify_unknown_highlights(context, unknown_highlights):
+    result = {
+        "description_flags": set(),
+        "conclusion_flags": set()
+    }
+    if context.type == 'inventory':
+        other_highlight_vocabularies = [
+            x for x in HIGHLIGHT_VOCABULARY_TYPES.by_value
+            if x and x != context.highlight_vocabulary 
+            and not x.endswith('projection')
+        ]
+        for voc_name in other_highlight_vocabularies:
+            vocab_description_flags, vocab_conclusion_flags, vocab_highlight = (
+                get_highlight_vocabs(context, voc_name)
+            )
+            highlights = translate_highlights(vocab_highlight, unknown_highlights)
+            description_flags = get_common(highlights, vocab_description_flags)
+            conclusion_flags = get_common(highlights, vocab_conclusion_flags)
+            result["conclusion_flags"].update(conclusion_flags)
+            result["description_flags"].update(description_flags)
+
+    return result
 
 def filter_for_ms(brains, context):
     if api.user.is_anonymous():
@@ -654,6 +680,14 @@ class ExportReviewFolderForm(form.Form, ReviewFolderMixin):
             row = [observation.getId]
             highlights = translate_highlights(
                 vocab_highlight, observation['get_highlight'] or [])
+            description_flags = get_common(highlights, vocab_description_flags)
+            conclusion_flags = get_common(highlights, vocab_conclusion_flags)
+            unknown_flags = classify_unknown_highlights(
+                self.context, 
+                set(highlights).difference(
+                    itertools.chain(description_flags, conclusion_flags)
+                )
+            )
 
             for key in fields_to_export:
                 if key == 'observation_is_potential_technical_correction':
@@ -664,11 +698,11 @@ class ExportReviewFolderForm(form.Form, ReviewFolderMixin):
                     row.append(yes_no_bool(IS_FIELD_MAP[key] in highlights))
                 elif key == 'get_description_flags':
                     row.append(', '.join(
-                        get_common(highlights, vocab_description_flags)
+                        list(itertools.chain(description_flags, unknown_flags["description_flags"]))
                     ))
                 elif key == 'get_conclusion_flags':
                     row.append(', '.join(
-                        get_common(highlights, vocab_conclusion_flags)
+                        list(itertools.chain(conclusion_flags, unknown_flags["conclusion_flags"]))
                     ))
                 elif key == 'get_is_ms_key_category':
                     row.append(
@@ -784,7 +818,7 @@ class ExportReviewFolderForm(form.Form, ReviewFolderMixin):
 
             try:
                 comment_html = comment.text.output_relative_to(context)
-                output_text = html2text.html2text(comment_html)
+                output_text = html2text.html2text(comment_html, bodywidth=0)
             except AttributeError:
                 output_text = comment.text
 

{emrt.necd.content-2.5.49 → emrt.necd.content-2.5.51}/emrt/necd/content/subscribers.py

@@ -3,6 +3,9 @@ from DateTime import DateTime
 from plone import api
 from Products.CMFCore.utils import getToolByName
 
+from emrt.necd.content.observation import IObservation
+from emrt.necd.content.utils import find_parent_with_interface
+
 
 def question_transition(question, event):
     if event.action in ['approve-question']:
@@ -158,3 +161,9 @@ def observation_transition(observation, event):
 
 
     observation.reindexObject()
+
+
+def new_discussion_comment(comment, event):
+    with api.env.adopt_roles(roles=['Manager']):
+        observation = find_parent_with_interface(IObservation, comment)
+        observation.reindexObject()

{emrt.necd.content-2.5.49 → emrt.necd.content-2.5.51}/emrt/necd/content/upgrades/configure.zcml

@@ -810,5 +810,30 @@
 
   </genericsetup:upgradeSteps>
 
+  <genericsetup:upgradeSteps
+    source="2.5.48"
+    destination="2.5.50"
+    profile="emrt.necd.content:default">
+
+    <genericsetup:upgradeStep
+      title="Roll-back formatting for conclusion text."
+      description="[refs #260973] Add formatting."
+      handler=".evolve2550.run"
+      />
+
+  </genericsetup:upgradeSteps>
+
+  <genericsetup:upgradeSteps
+    source="2.5.50"
+    destination="2.5.51"
+    profile="emrt.necd.content:default">
+
+    <genericsetup:upgradeStep
+      title="Reindex observation discussion counts"
+      description="[refs #270288] observation not reindexed when new discussion comments are added."
+      handler=".evolve2551.run"
+      />
+
+  </genericsetup:upgradeSteps>
 
 </configure>

emrt.necd.content-2.5.51/emrt/necd/content/upgrades/evolve2550.py

@@ -0,0 +1,56 @@
+from logging import getLogger
+
+import transaction
+from DateTime import DateTime
+
+from zope.component import getMultiAdapter
+from zope.globalrequest import getRequest
+
+from plone.app.textfield.value import RichTextValue
+
+import plone.api as api
+
+import html2text
+
+
+LOGGER = getLogger(__name__)
+
+
+def filter_is_carried_over(obs):
+    return hasattr(obs, "carryover_from")
+
+
+def filter_has_comments(obs):
+    return (
+        getattr(obs, "closing_comments", None)
+        or getattr(obs, "closing_deny_comments", None)
+    )
+
+def run(_):
+    catalog = api.portal.get_tool("portal_catalog")
+    brains = catalog(portal_type="Conclusions", modified={"range": "min", "query": DateTime("2024/02/19")})
+    brains_len = len(brains)
+    a_tenth = brains_len / 10
+    conclusions = (brain.getObject() for brain in brains)
+    LOGGER.info("Found %s brains. Selecting some...", brains_len)
+    valid_conclusions = (
+        obj
+        for obj in conclusions
+        if isinstance(obj.text, RichTextValue)
+    )
+    for idx, conclusion in enumerate(valid_conclusions, start=1):
+        LOGGER.info(conclusion.absolute_url(1))
+
+        try:
+            conclusion_html = conclusion.text.output_relative_to(conclusion)
+            conclusion.text = html2text.html2text(conclusion_html, bodywidth=0)
+        except Exception:
+            LOGGER.exception("Could not update conclusion text!")
+
+        conclusion.aq_parent.reindexObject()
+        conclusion.reindexObject()
+
+        # log progress
+        if a_tenth and idx % a_tenth == 0:
+            transaction.savepoint(optimistic=True)
+            LOGGER.info("Done %s/%s.", idx, brains_len)

emrt.necd.content-2.5.51/emrt/necd/content/upgrades/evolve2551.py

@@ -0,0 +1,31 @@
+from logging import getLogger
+
+import transaction
+from DateTime import DateTime
+
+import plone.api as api
+
+
+LOGGER = getLogger(__name__)
+
+
+def run(_):
+    catalog = api.portal.get_tool("portal_catalog")
+    brains = catalog(portal_type="Observation", modified={"range": "min", "query": DateTime("2024/02/19")})
+
+    brains_len = len(brains)
+    a_tenth = brains_len / 10
+
+    LOGGER.info("Found %s brains...", brains_len)
+
+    observations = (b.getObject() for b in brains)
+
+    for idx, observation in enumerate(observations, start=1):
+        LOGGER.info(observation.absolute_url(1))
+
+        observation.reindexObject()
+
+        # log progress
+        if a_tenth and idx % a_tenth == 0:
+            transaction.savepoint(optimistic=True)
+            LOGGER.info("Done %s/%s.", idx, brains_len)

{emrt.necd.content-2.5.49 → emrt.necd.content-2.5.51}/emrt/necd/content/utils.py

@@ -143,7 +143,7 @@ def render_rich_text_value(context, obj):
 
 def richtext2text(value, context):
     html_value = value.output_relative_to(context)
-    output_text = html2text.html2text(html_value)
+    output_text = html2text.html2text(html_value, bodywidth=0)
     return safe_unicode(output_text)
 
 

{emrt.necd.content-2.5.49 → emrt.necd.content-2.5.51}/emrt/necd/content/vocabularies.py

@@ -199,16 +199,17 @@ class Fuel(object):
 @implementer(IVocabularyFactory)
 class Highlight(object):
 
-    def __call__(self, context):
+    def __call__(self, context, voc_name=None):
         pvoc = api.portal.get_tool('portal_vocabularies')
 
-        if context.highlight_vocabulary:
-            voc_name = context.highlight_vocabulary
-        else:
-            voc_name = (
-                'highlight' if context.type == 'inventory'
-                else 'highlight_projection'
-            )
+        if voc_name is None:
+            if context.highlight_vocabulary:
+                voc_name = context.highlight_vocabulary
+            else:
+                voc_name = (
+                    'highlight' if context.type == 'inventory'
+                    else 'highlight_projection'
+                )
 
         voc = pvoc.getVocabularyByName(voc_name)
         if voc is None: