dtSpark 1.1.0a3__py3-none-any.whl → 1.1.0a7__py3-none-any.whl

dtSpark/tools/builtin.py

@@ -16,6 +16,23 @@ from datetime import datetime
 from typing import Dict, List, Any, Optional
 from zoneinfo import ZoneInfo, available_timezones
 
+# Common error/description string constants (SonarCloud S1192)
+_ERR_FS_NOT_CONFIGURED = "Filesystem tools not configured"
+_ERR_FILE_PATH_REQUIRED = "File path is required"
+_ERR_DOC_NOT_CONFIGURED = "Document tools not configured"
+_ERR_DOC_NOT_ENABLED = "Document tools are not enabled"
+_ERR_WRITE_MODE_REQUIRED = "Write operations require access_mode: read_write"
+_ERR_OUTPUT_PATH_REQUIRED = "Output file path is required"
+_ERR_ARCHIVE_NOT_CONFIGURED = "Archive tools not configured"
+_ERR_ARCHIVE_NOT_ENABLED = "Archive tools are not enabled"
+_ERR_ARCHIVE_PATH_REQUIRED = "Archive path is required"
+_DESC_ARCHIVE_PATH = "Path to the archive file"
+_TAR_GZ = 'tar.gz'
+_TAR_BZ2 = 'tar.bz2'
+_TAR_BZ2_MODE = 'r:bz2'
+_TAR_OPEN_MODES = {_TAR_GZ: 'r:gz', _TAR_BZ2: _TAR_BZ2_MODE}
+
+
 
 def get_builtin_tools(config: Optional[Dict[str, Any]] = None) -> List[Dict[str, Any]]:
     """
@@ -459,7 +476,7 @@ def _execute_list_files_recursive(tool_input: Dict[str, Any],
         Dictionary with success status and file listing
     """
     if not config.get('embedded_tools'):
-        return {"success": False, "error": "Filesystem tools not configured"}
+        return {"success": False, "error": _ERR_FS_NOT_CONFIGURED}
 
     fs_config = config.get('embedded_tools', {}).get('filesystem', {})
     allowed_path = fs_config.get('allowed_path', '.')
@@ -539,7 +556,7 @@ def _execute_search_files(tool_input: Dict[str, Any],
         Dictionary with success status and search results
     """
     if not config.get('embedded_tools'):
-        return {"success": False, "error": "Filesystem tools not configured"}
+        return {"success": False, "error": _ERR_FS_NOT_CONFIGURED}
 
     fs_config = config.get('embedded_tools', {}).get('filesystem', {})
     allowed_path = fs_config.get('allowed_path', '.')
@@ -609,7 +626,7 @@ def _execute_read_file_text(tool_input: Dict[str, Any],
         Dictionary with success status and file content
     """
     if not config.get('embedded_tools'):
-        return {"success": False, "error": "Filesystem tools not configured"}
+        return {"success": False, "error": _ERR_FS_NOT_CONFIGURED}
 
     fs_config = config.get('embedded_tools', {}).get('filesystem', {})
     allowed_path = fs_config.get('allowed_path', '.')
@@ -618,7 +635,7 @@ def _execute_read_file_text(tool_input: Dict[str, Any],
     file_path = tool_input.get('path')
 
     if not file_path:
-        return {"success": False, "error": "File path is required"}
+        return {"success": False, "error": _ERR_FILE_PATH_REQUIRED}
 
     # Validate path
     validation = _validate_path(file_path, allowed_path)
@@ -673,7 +690,7 @@ def _execute_read_file_binary(tool_input: Dict[str, Any],
         Dictionary with success status and base64-encoded content
     """
     if not config.get('embedded_tools'):
-        return {"success": False, "error": "Filesystem tools not configured"}
+        return {"success": False, "error": _ERR_FS_NOT_CONFIGURED}
 
     fs_config = config.get('embedded_tools', {}).get('filesystem', {})
     allowed_path = fs_config.get('allowed_path', '.')
@@ -683,7 +700,7 @@ def _execute_read_file_binary(tool_input: Dict[str, Any],
     max_size_mb = tool_input.get('max_size_mb', 10)
 
     if not file_path:
-        return {"success": False, "error": "File path is required"}
+        return {"success": False, "error": _ERR_FILE_PATH_REQUIRED}
 
     # Validate path
     validation = _validate_path(file_path, allowed_path)
@@ -748,7 +765,7 @@ def _execute_write_file(tool_input: Dict[str, Any],
 
     if not config.get('embedded_tools'):
         logging.warning("write_file failed: embedded_tools not in config")
-        return {"success": False, "error": "Filesystem tools not configured"}
+        return {"success": False, "error": _ERR_FS_NOT_CONFIGURED}
 
     fs_config = config.get('embedded_tools', {}).get('filesystem', {})
     allowed_path = fs_config.get('allowed_path', '.')
@@ -773,7 +790,7 @@ def _execute_write_file(tool_input: Dict[str, Any],
 
     if not file_path:
         logging.warning("write_file failed: no file path provided")
-        return {"success": False, "error": "File path is required"}
+        return {"success": False, "error": _ERR_FILE_PATH_REQUIRED}
 
     if content is None:
         logging.warning("write_file failed: no content provided")
@@ -830,7 +847,7 @@ def _execute_create_directories(tool_input: Dict[str, Any],
         Dictionary with success status
     """
     if not config.get('embedded_tools'):
-        return {"success": False, "error": "Filesystem tools not configured"}
+        return {"success": False, "error": _ERR_FS_NOT_CONFIGURED}
 
     fs_config = config.get('embedded_tools', {}).get('filesystem', {})
     allowed_path = fs_config.get('allowed_path', '.')
@@ -1145,17 +1162,17 @@ def _execute_get_file_info(tool_input: Dict[str, Any],
                            config: Optional[Dict[str, Any]]) -> Dict[str, Any]:
     """Execute the get_file_info tool."""
     if not config.get('embedded_tools'):
-        return {"success": False, "error": "Document tools not configured"}
+        return {"success": False, "error": _ERR_DOC_NOT_CONFIGURED}
 
     doc_config = config.get('embedded_tools', {}).get('documents', {})
     if not doc_config.get('enabled', False):
-        return {"success": False, "error": "Document tools are not enabled"}
+        return {"success": False, "error": _ERR_DOC_NOT_ENABLED}
 
     allowed_path = doc_config.get('allowed_path', '.')
     file_path = tool_input.get('path')
 
     if not file_path:
-        return {"success": False, "error": "File path is required"}
+        return {"success": False, "error": _ERR_FILE_PATH_REQUIRED}
 
     validation = _validate_path(file_path, allowed_path)
     if not validation['valid']:
@@ -1220,11 +1237,11 @@ def _execute_read_word_document(tool_input: Dict[str, Any],
                                 config: Optional[Dict[str, Any]]) -> Dict[str, Any]:
     """Execute the read_word_document tool."""
     if not config.get('embedded_tools'):
-        return {"success": False, "error": "Document tools not configured"}
+        return {"success": False, "error": _ERR_DOC_NOT_CONFIGURED}
 
     doc_config = config.get('embedded_tools', {}).get('documents', {})
     if not doc_config.get('enabled', False):
-        return {"success": False, "error": "Document tools are not enabled"}
+        return {"success": False, "error": _ERR_DOC_NOT_ENABLED}
 
     allowed_path = doc_config.get('allowed_path', '.')
     max_size_mb = doc_config.get('max_file_size_mb', 50)
@@ -1234,7 +1251,7 @@ def _execute_read_word_document(tool_input: Dict[str, Any],
     include_headers_footers = tool_input.get('include_headers_footers', False)
 
     if not file_path:
-        return {"success": False, "error": "File path is required"}
+        return {"success": False, "error": _ERR_FILE_PATH_REQUIRED}
 
     validation = _validate_path(file_path, allowed_path)
     if not validation['valid']:
@@ -1307,11 +1324,11 @@ def _execute_read_excel_document(tool_input: Dict[str, Any],
                                  config: Optional[Dict[str, Any]]) -> Dict[str, Any]:
     """Execute the read_excel_document tool."""
     if not config.get('embedded_tools'):
-        return {"success": False, "error": "Document tools not configured"}
+        return {"success": False, "error": _ERR_DOC_NOT_CONFIGURED}
 
     doc_config = config.get('embedded_tools', {}).get('documents', {})
     if not doc_config.get('enabled', False):
-        return {"success": False, "error": "Document tools are not enabled"}
+        return {"success": False, "error": _ERR_DOC_NOT_ENABLED}
 
     allowed_path = doc_config.get('allowed_path', '.')
     max_size_mb = doc_config.get('max_file_size_mb', 50)
@@ -1323,7 +1340,7 @@ def _execute_read_excel_document(tool_input: Dict[str, Any],
     max_rows = tool_input.get('max_rows', 0) or default_max_rows
 
     if not file_path:
-        return {"success": False, "error": "File path is required"}
+        return {"success": False, "error": _ERR_FILE_PATH_REQUIRED}
 
     validation = _validate_path(file_path, allowed_path)
     if not validation['valid']:
@@ -1395,11 +1412,11 @@ def _execute_read_powerpoint_document(tool_input: Dict[str, Any],
                                       config: Optional[Dict[str, Any]]) -> Dict[str, Any]:
     """Execute the read_powerpoint_document tool."""
     if not config.get('embedded_tools'):
-        return {"success": False, "error": "Document tools not configured"}
+        return {"success": False, "error": _ERR_DOC_NOT_CONFIGURED}
 
     doc_config = config.get('embedded_tools', {}).get('documents', {})
     if not doc_config.get('enabled', False):
-        return {"success": False, "error": "Document tools are not enabled"}
+        return {"success": False, "error": _ERR_DOC_NOT_ENABLED}
 
     allowed_path = doc_config.get('allowed_path', '.')
     max_size_mb = doc_config.get('max_file_size_mb', 50)
@@ -1408,7 +1425,7 @@ def _execute_read_powerpoint_document(tool_input: Dict[str, Any],
     include_notes = tool_input.get('include_notes', True)
 
     if not file_path:
-        return {"success": False, "error": "File path is required"}
+        return {"success": False, "error": _ERR_FILE_PATH_REQUIRED}
 
     validation = _validate_path(file_path, allowed_path)
     if not validation['valid']:
@@ -1478,11 +1495,11 @@ def _execute_read_pdf_document(tool_input: Dict[str, Any],
                                config: Optional[Dict[str, Any]]) -> Dict[str, Any]:
     """Execute the read_pdf_document tool."""
     if not config.get('embedded_tools'):
-        return {"success": False, "error": "Document tools not configured"}
+        return {"success": False, "error": _ERR_DOC_NOT_CONFIGURED}
 
     doc_config = config.get('embedded_tools', {}).get('documents', {})
     if not doc_config.get('enabled', False):
-        return {"success": False, "error": "Document tools are not enabled"}
+        return {"success": False, "error": _ERR_DOC_NOT_ENABLED}
 
     allowed_path = doc_config.get('allowed_path', '.')
     max_size_mb = doc_config.get('max_file_size_mb', 50)
@@ -1493,7 +1510,7 @@ def _execute_read_pdf_document(tool_input: Dict[str, Any],
     include_metadata = tool_input.get('include_metadata', True)
 
     if not file_path:
-        return {"success": False, "error": "File path is required"}
+        return {"success": False, "error": _ERR_FILE_PATH_REQUIRED}
 
     validation = _validate_path(file_path, allowed_path)
     if not validation['valid']:
@@ -1560,14 +1577,14 @@ def _execute_create_word_document(tool_input: Dict[str, Any],
                                   config: Optional[Dict[str, Any]]) -> Dict[str, Any]:
     """Execute the create_word_document tool."""
     if not config.get('embedded_tools'):
-        return {"success": False, "error": "Document tools not configured"}
+        return {"success": False, "error": _ERR_DOC_NOT_CONFIGURED}
 
     doc_config = config.get('embedded_tools', {}).get('documents', {})
     if not doc_config.get('enabled', False):
-        return {"success": False, "error": "Document tools are not enabled"}
+        return {"success": False, "error": _ERR_DOC_NOT_ENABLED}
 
     if doc_config.get('access_mode', 'read') != 'read_write':
-        return {"success": False, "error": "Write operations require access_mode: read_write"}
+        return {"success": False, "error": _ERR_WRITE_MODE_REQUIRED}
 
     allowed_path = doc_config.get('allowed_path', '.')
     templates_path = doc_config.get('creation', {}).get('templates_path')
@@ -1578,7 +1595,7 @@ def _execute_create_word_document(tool_input: Dict[str, Any],
     placeholders = tool_input.get('placeholders', {})
 
     if not file_path:
-        return {"success": False, "error": "Output file path is required"}
+        return {"success": False, "error": _ERR_OUTPUT_PATH_REQUIRED}
 
     validation = _validate_path(file_path, allowed_path)
     if not validation['valid']:
@@ -1680,14 +1697,14 @@ def _execute_create_excel_document(tool_input: Dict[str, Any],
                                    config: Optional[Dict[str, Any]]) -> Dict[str, Any]:
     """Execute the create_excel_document tool."""
     if not config.get('embedded_tools'):
-        return {"success": False, "error": "Document tools not configured"}
+        return {"success": False, "error": _ERR_DOC_NOT_CONFIGURED}
 
     doc_config = config.get('embedded_tools', {}).get('documents', {})
     if not doc_config.get('enabled', False):
-        return {"success": False, "error": "Document tools are not enabled"}
+        return {"success": False, "error": _ERR_DOC_NOT_ENABLED}
 
     if doc_config.get('access_mode', 'read') != 'read_write':
-        return {"success": False, "error": "Write operations require access_mode: read_write"}
+        return {"success": False, "error": _ERR_WRITE_MODE_REQUIRED}
 
     allowed_path = doc_config.get('allowed_path', '.')
 
@@ -1695,7 +1712,7 @@ def _execute_create_excel_document(tool_input: Dict[str, Any],
     sheets = tool_input.get('sheets', [])
 
     if not file_path:
-        return {"success": False, "error": "Output file path is required"}
+        return {"success": False, "error": _ERR_OUTPUT_PATH_REQUIRED}
 
     if not sheets:
         return {"success": False, "error": "At least one sheet is required"}
@@ -1758,14 +1775,14 @@ def _execute_create_powerpoint_document(tool_input: Dict[str, Any],
                                         config: Optional[Dict[str, Any]]) -> Dict[str, Any]:
     """Execute the create_powerpoint_document tool."""
     if not config.get('embedded_tools'):
-        return {"success": False, "error": "Document tools not configured"}
+        return {"success": False, "error": _ERR_DOC_NOT_CONFIGURED}
 
     doc_config = config.get('embedded_tools', {}).get('documents', {})
     if not doc_config.get('enabled', False):
-        return {"success": False, "error": "Document tools are not enabled"}
+        return {"success": False, "error": _ERR_DOC_NOT_ENABLED}
 
     if doc_config.get('access_mode', 'read') != 'read_write':
-        return {"success": False, "error": "Write operations require access_mode: read_write"}
+        return {"success": False, "error": _ERR_WRITE_MODE_REQUIRED}
 
     allowed_path = doc_config.get('allowed_path', '.')
     templates_path = doc_config.get('creation', {}).get('templates_path')
@@ -1776,7 +1793,7 @@ def _execute_create_powerpoint_document(tool_input: Dict[str, Any],
     placeholders = tool_input.get('placeholders', {})
 
     if not file_path:
-        return {"success": False, "error": "Output file path is required"}
+        return {"success": False, "error": _ERR_OUTPUT_PATH_REQUIRED}
 
     if not slides_data and not template_path:
         return {"success": False, "error": "Either slides or template_path is required"}
@@ -1914,7 +1931,7 @@ def _get_archive_tools(archive_config: Dict[str, Any]) -> List[Dict[str, Any]]:
                 "properties": {
                     "path": {
                         "type": "string",
-                        "description": "Path to the archive file"
+                        "description": _DESC_ARCHIVE_PATH
                     }
                 },
                 "required": ["path"]
@@ -1929,7 +1946,7 @@ def _get_archive_tools(archive_config: Dict[str, Any]) -> List[Dict[str, Any]]:
                 "properties": {
                     "archive_path": {
                         "type": "string",
-                        "description": "Path to the archive file"
+                        "description": _DESC_ARCHIVE_PATH
                     },
                     "file_path": {
                         "type": "string",
@@ -1963,7 +1980,7 @@ def _get_archive_tools(archive_config: Dict[str, Any]) -> List[Dict[str, Any]]:
                 "properties": {
                     "archive_path": {
                         "type": "string",
-                        "description": "Path to the archive file"
+                        "description": _DESC_ARCHIVE_PATH
                     },
                     "destination": {
                         "type": "string",
@@ -1997,9 +2014,9 @@ def _get_archive_type(file_path: Path) -> Optional[str]:
     elif suffix == '.tar':
         return 'tar'
     elif name.endswith('.tar.gz') or suffix == '.tgz':
-        return 'tar.gz'
+        return _TAR_GZ
     elif name.endswith('.tar.bz2'):
-        return 'tar.bz2'
+        return _TAR_BZ2
     return None
 
 
@@ -2010,11 +2027,11 @@ def _execute_list_archive_contents(tool_input: Dict[str, Any],
     import tarfile
 
     if not config.get('embedded_tools'):
-        return {"success": False, "error": "Archive tools not configured"}
+        return {"success": False, "error": _ERR_ARCHIVE_NOT_CONFIGURED}
 
     archive_config = config.get('embedded_tools', {}).get('archives', {})
     if not archive_config.get('enabled', False):
-        return {"success": False, "error": "Archive tools are not enabled"}
+        return {"success": False, "error": _ERR_ARCHIVE_NOT_ENABLED}
 
     allowed_path = archive_config.get('allowed_path', '.')
     max_size_mb = archive_config.get('max_file_size_mb', 100)
@@ -2023,7 +2040,7 @@ def _execute_list_archive_contents(tool_input: Dict[str, Any],
     file_path = tool_input.get('path')
 
     if not file_path:
-        return {"success": False, "error": "Archive path is required"}
+        return {"success": False, "error": _ERR_ARCHIVE_PATH_REQUIRED}
 
     validation = _validate_path(file_path, allowed_path)
     if not validation['valid']:
@@ -2055,7 +2072,7 @@ def _execute_list_archive_contents(tool_input: Dict[str, Any],
                         "modified": datetime(*info.date_time).isoformat() if info.date_time else None
                     })
         else:
-            mode = 'r:gz' if archive_type == 'tar.gz' else 'r:bz2' if archive_type == 'tar.bz2' else 'r'
+            mode = _TAR_OPEN_MODES.get(archive_type, 'r')
             with tarfile.open(str(full_path), mode) as tf:
                 count = 0
                 for member in tf:
@@ -2093,11 +2110,11 @@ def _execute_read_archive_file(tool_input: Dict[str, Any],
     import tarfile
 
     if not config.get('embedded_tools'):
-        return {"success": False, "error": "Archive tools not configured"}
+        return {"success": False, "error": _ERR_ARCHIVE_NOT_CONFIGURED}
 
     archive_config = config.get('embedded_tools', {}).get('archives', {})
     if not archive_config.get('enabled', False):
-        return {"success": False, "error": "Archive tools are not enabled"}
+        return {"success": False, "error": _ERR_ARCHIVE_NOT_ENABLED}
 
     allowed_path = archive_config.get('allowed_path', '.')
     max_size_mb = archive_config.get('max_file_size_mb', 100)
@@ -2108,7 +2125,7 @@ def _execute_read_archive_file(tool_input: Dict[str, Any],
     as_binary = tool_input.get('as_binary', False)
 
     if not archive_path:
-        return {"success": False, "error": "Archive path is required"}
+        return {"success": False, "error": _ERR_ARCHIVE_PATH_REQUIRED}
 
     if not file_path:
         return {"success": False, "error": "File path within archive is required"}
@@ -2138,7 +2155,7 @@ def _execute_read_archive_file(tool_input: Dict[str, Any],
                     return {"success": False, "error": f"File not found in archive: {file_path}"}
                 content = zf.read(file_path)
         else:
-            mode = 'r:gz' if archive_type == 'tar.gz' else 'r:bz2' if archive_type == 'tar.bz2' else 'r'
+            mode = _TAR_OPEN_MODES.get(archive_type, 'r')
             with tarfile.open(str(full_path), mode) as tf:
                 try:
                     member = tf.getmember(file_path)
@@ -2195,11 +2212,11 @@ def _execute_extract_archive(tool_input: Dict[str, Any],
     import tarfile
 
     if not config.get('embedded_tools'):
-        return {"success": False, "error": "Archive tools not configured"}
+        return {"success": False, "error": _ERR_ARCHIVE_NOT_CONFIGURED}
 
     archive_config = config.get('embedded_tools', {}).get('archives', {})
     if not archive_config.get('enabled', False):
-        return {"success": False, "error": "Archive tools are not enabled"}
+        return {"success": False, "error": _ERR_ARCHIVE_NOT_ENABLED}
 
     if archive_config.get('access_mode', 'read') != 'read_write':
         return {"success": False, "error": "Extract operations require access_mode: read_write"}
@@ -2213,7 +2230,7 @@ def _execute_extract_archive(tool_input: Dict[str, Any],
     overwrite = tool_input.get('overwrite', False)
 
     if not archive_path:
-        return {"success": False, "error": "Archive path is required"}
+        return {"success": False, "error": _ERR_ARCHIVE_PATH_REQUIRED}
 
     if not destination:
         return {"success": False, "error": "Destination directory is required"}
@@ -2259,7 +2276,7 @@ def _execute_extract_archive(tool_input: Dict[str, Any],
                         zf.extract(member, str(full_dest_path))
                         extracted_files.append(member)
         else:
-            mode = 'r:gz' if archive_type == 'tar.gz' else 'r:bz2' if archive_type == 'tar.bz2' else 'r'
+            mode = _TAR_OPEN_MODES.get(archive_type, 'r')
             with tarfile.open(str(full_archive_path), mode) as tf:
                 if files_to_extract:
                     members = [tf.getmember(f) for f in files_to_extract if f in tf.getnames()]

dtSpark/web/endpoints/autonomous_actions.py

@@ -20,6 +20,9 @@ from pydantic import BaseModel, Field
 
 from ..dependencies import get_current_session
 
+# Error message constants
+_ERR_ACTION_NOT_FOUND = "Action not found"
+
 
 logger = logging.getLogger(__name__)
 
@@ -35,10 +38,10 @@ def parse_datetime(dt_value):
     if isinstance(dt_value, str):
         try:
             return datetime.fromisoformat(dt_value.replace('Z', '+00:00'))
-        except:
+        except (ValueError, TypeError):
             try:
                 return datetime.strptime(dt_value, '%Y-%m-%d %H:%M:%S.%f')
-            except:
+            except (ValueError, TypeError):
                 return None
     return None
 
@@ -213,7 +216,7 @@ async def get_action(
 
         action = database.get_action(action_id)
         if not action:
-            raise HTTPException(status_code=404, detail="Action not found")
+            raise HTTPException(status_code=404, detail=_ERR_ACTION_NOT_FOUND)
 
         tool_permissions = database.get_action_tool_permissions(action_id)
 
@@ -326,7 +329,7 @@ async def update_action(
 
         action = database.get_action(action_id)
         if not action:
-            raise HTTPException(status_code=404, detail="Action not found")
+            raise HTTPException(status_code=404, detail=_ERR_ACTION_NOT_FOUND)
 
         # Build updates dict
         updates = {}
@@ -390,7 +393,7 @@ async def delete_action(
 
         action = database.get_action(action_id)
         if not action:
-            raise HTTPException(status_code=404, detail="Action not found")
+            raise HTTPException(status_code=404, detail=_ERR_ACTION_NOT_FOUND)
 
         # Unschedule the action
         if hasattr(app_instance, 'action_scheduler') and app_instance.action_scheduler:
@@ -432,7 +435,7 @@ async def enable_action(
 
         action = database.get_action(action_id)
         if not action:
-            raise HTTPException(status_code=404, detail="Action not found")
+            raise HTTPException(status_code=404, detail=_ERR_ACTION_NOT_FOUND)
 
         database.enable_action(action_id)
 
@@ -479,7 +482,7 @@ async def disable_action(
 
         action = database.get_action(action_id)
         if not action:
-            raise HTTPException(status_code=404, detail="Action not found")
+            raise HTTPException(status_code=404, detail=_ERR_ACTION_NOT_FOUND)
 
         database.disable_action(action_id)
 
@@ -520,7 +523,7 @@ async def run_action_now(
 
         action = database.get_action(action_id)
         if not action:
-            raise HTTPException(status_code=404, detail="Action not found")
+            raise HTTPException(status_code=404, detail=_ERR_ACTION_NOT_FOUND)
 
         # Check if action is currently locked by another process (e.g., daemon)
         from dtSpark.database.autonomous_actions import get_action_lock_info
@@ -583,7 +586,7 @@ async def list_action_runs(
 
         action = database.get_action(action_id)
         if not action:
-            raise HTTPException(status_code=404, detail="Action not found")
+            raise HTTPException(status_code=404, detail=_ERR_ACTION_NOT_FOUND)
 
         runs = database.get_action_runs(action_id, limit=limit, offset=offset)
 

dtSpark/web/endpoints/chat.py

@@ -10,9 +10,11 @@ Provides REST API for chat operations:
 
 """
 
+import asyncio
 import logging
 import tempfile
 import os
+from pathlib import Path
 from typing import Optional, List
 from datetime import datetime
 
@@ -319,15 +321,15 @@ async def command_attach(
                 # Create temporary file
                 suffix = os.path.splitext(upload_file.filename)[1]
                 temp_fd, temp_path = tempfile.mkstemp(suffix=suffix)
+                os.close(temp_fd)
 
-                # Write uploaded content to temp file
-                with os.fdopen(temp_fd, 'wb') as f:
-                    content = await upload_file.read()
-                    f.write(content)
+                # Write uploaded content to temp file asynchronously
+                content = await upload_file.read()
+                await asyncio.to_thread(Path(temp_path).write_bytes, content)
 
                 temp_files.append(temp_path)
                 attached_filenames.append(upload_file.filename)
-                logger.info(f"Saved uploaded file {upload_file.filename} to {temp_path}")
+                logger.info("Saved uploaded file to %s", temp_path)
 
             # Attach files using conversation manager
             if temp_files:
@@ -366,7 +368,7 @@ async def command_attach(
                 try:
                     if os.path.exists(temp_path):
                         os.unlink(temp_path)
-                except:
+                except OSError:
                     pass
 
     except Exception as e:

dtSpark/web/endpoints/conversations.py

@@ -10,9 +10,11 @@ Provides REST API for conversation operations:
 
 """
 
+import asyncio
 import logging
 import tempfile
 import os
+from pathlib import Path
 from typing import Optional, List
 from datetime import datetime
 
@@ -37,7 +39,7 @@ def parse_datetime(dt_value):
         # SQLite returns timestamps as strings
         try:
             return datetime.fromisoformat(dt_value.replace('Z', '+00:00'))
-        except:
+        except (ValueError, TypeError):
             return datetime.strptime(dt_value, '%Y-%m-%d %H:%M:%S.%f')
     return None
 
@@ -175,6 +177,13 @@ async def create_conversation(
         ConversationDetail for the created conversation
     """
     try:
+        # Check if new conversations are allowed
+        if not getattr(request.app.state, 'new_conversations_allowed', True):
+            raise HTTPException(
+                status_code=403,
+                detail="Creating new conversations is disabled by configuration"
+            )
+
         app_instance = request.app.state.app_instance
         database = app_instance.database
         conversation_manager = app_instance.conversation_manager
@@ -220,7 +229,7 @@ async def create_conversation(
                     suffix = os.path.splitext(upload_file.filename)[1]
                     if not suffix:
                         upload_errors.append(f"File '{upload_file.filename}' has no file extension")
-                        logger.warning(f"File '{upload_file.filename}' uploaded without extension")
+                        logger.warning("File uploaded without extension")
                         continue
 
                     # Check if extension is supported (using FileManager's validation)
@@ -230,19 +239,19 @@ async def create_conversation(
                                              FileManager.SUPPORTED_DOCUMENT_FILES |
                                              FileManager.SUPPORTED_IMAGE_FILES):
                         upload_errors.append(f"File type '{suffix}' is not supported for '{upload_file.filename}'")
-                        logger.warning(f"Unsupported file type '{suffix}' for file '{upload_file.filename}'")
+                        logger.warning("Unsupported file type uploaded")
                         continue
 
                     # Create temporary file with proper extension
                     temp_fd, temp_path = tempfile.mkstemp(suffix=suffix)
+                    os.close(temp_fd)
 
-                    # Write uploaded content to temp file
-                    with os.fdopen(temp_fd, 'wb') as f:
-                        content = await upload_file.read()
-                        f.write(content)
+                    # Write uploaded content to temp file asynchronously
+                    content = await upload_file.read()
+                    await asyncio.to_thread(Path(temp_path).write_bytes, content)
 
                     temp_files.append(temp_path)
-                    logger.info(f"Saved uploaded file {upload_file.filename} to {temp_path}")
+                    logger.info("Saved uploaded file to %s", temp_path)
 
                 # Attach files using conversation manager
                 if temp_files:
@@ -265,7 +274,7 @@ async def create_conversation(
                     try:
                         if os.path.exists(temp_path):
                             os.unlink(temp_path)
-                    except:
+                    except OSError:
                         pass
 
         # Get the created conversation details