dstack 0.19.26__py3-none-any.whl → 0.19.28__py3-none-any.whl

dstack/_internal/cli/services/configurators/volume.py

@@ -1,6 +1,5 @@
 import argparse
 import time
-from typing import List
 
 from rich.table import Table
 
@@ -26,7 +25,7 @@ from dstack.api._public import Client
 
 
 class VolumeConfigurator(BaseApplyConfigurator[VolumeConfiguration]):
-    TYPE: ApplyConfigurationType = ApplyConfigurationType.VOLUME
+    TYPE = ApplyConfigurationType.VOLUME
 
     def apply_configuration(
         self,
@@ -34,9 +33,8 @@ class VolumeConfigurator(BaseApplyConfigurator[VolumeConfiguration]):
         configuration_path: str,
         command_args: argparse.Namespace,
         configurator_args: argparse.Namespace,
-        unknown_args: List[str],
     ):
-        self.apply_args(conf, configurator_args, unknown_args)
+        self.apply_args(conf, configurator_args)
         spec = VolumeSpec(
             configuration=conf,
             configuration_path=configuration_path,
@@ -167,7 +165,7 @@ class VolumeConfigurator(BaseApplyConfigurator[VolumeConfiguration]):
             help="The volume name",
         )
 
-    def apply_args(self, conf: VolumeConfiguration, args: argparse.Namespace, unknown: List[str]):
+    def apply_args(self, conf: VolumeConfiguration, args: argparse.Namespace):
         if args.name:
             conf.name = args.name
 

dstack/_internal/cli/services/repos.py

@@ -1,5 +1,5 @@
 import argparse
-from typing import Literal, Optional, Union, overload
+from typing import Literal, Union, overload
 
 import git
 
@@ -8,7 +8,6 @@ from dstack._internal.core.errors import CLIError
 from dstack._internal.core.models.repos.local import LocalRepo
 from dstack._internal.core.models.repos.remote import GitRepoURL, RemoteRepo, RepoError
 from dstack._internal.core.models.repos.virtual import VirtualRepo
-from dstack._internal.core.services.repos import get_default_branch
 from dstack._internal.utils.path import PathLike
 from dstack.api._public import Client
 
@@ -43,22 +42,6 @@ def init_default_virtual_repo(api: Client) -> VirtualRepo:
     return repo
 
 
-def get_repo_from_url(
-    repo_url: str, repo_branch: Optional[str] = None, repo_hash: Optional[str] = None
-) -> RemoteRepo:
-    if repo_branch is None and repo_hash is None:
-        repo_branch = get_default_branch(repo_url)
-        if repo_branch is None:
-            raise CLIError(
-                "Failed to automatically detect remote repo branch. Specify branch or hash."
-            )
-    return RemoteRepo.from_url(
-        repo_url=repo_url,
-        repo_branch=repo_branch,
-        repo_hash=repo_hash,
-    )
-
-
 @overload
 def get_repo_from_dir(repo_dir: PathLike, local: Literal[False] = False) -> RemoteRepo: ...
 

dstack/_internal/core/backends/amddevcloud/__init__.py

@@ -0,0 +1 @@
+# This package contains the implementation for the AMDDevCloud backend.

dstack/_internal/core/backends/amddevcloud/backend.py

@@ -0,0 +1,16 @@
+from dstack._internal.core.backends.amddevcloud.compute import AMDDevCloudCompute
+from dstack._internal.core.backends.digitalocean_base.backend import BaseDigitalOceanBackend
+from dstack._internal.core.backends.digitalocean_base.models import BaseDigitalOceanConfig
+from dstack._internal.core.models.backends.base import BackendType
+
+
+class AMDDevCloudBackend(BaseDigitalOceanBackend):
+    TYPE = BackendType.AMDDEVCLOUD
+    COMPUTE_CLASS = AMDDevCloudCompute
+
+    def __init__(self, config: BaseDigitalOceanConfig, api_url: str):
+        self.config = config
+        self._compute = AMDDevCloudCompute(self.config, api_url=api_url, type=self.TYPE)
+
+    def compute(self) -> AMDDevCloudCompute:
+        return self._compute

dstack/_internal/core/backends/amddevcloud/compute.py

@@ -0,0 +1,5 @@
+from dstack._internal.core.backends.digitalocean_base.compute import BaseDigitalOceanCompute
+
+
+class AMDDevCloudCompute(BaseDigitalOceanCompute):
+    pass

dstack/_internal/core/backends/amddevcloud/configurator.py

@@ -0,0 +1,29 @@
+from typing import Optional
+
+from dstack._internal.core.backends.amddevcloud.backend import AMDDevCloudBackend
+from dstack._internal.core.backends.base.configurator import BackendRecord
+from dstack._internal.core.backends.digitalocean_base.api_client import DigitalOceanAPIClient
+from dstack._internal.core.backends.digitalocean_base.backend import BaseDigitalOceanBackend
+from dstack._internal.core.backends.digitalocean_base.configurator import (
+    BaseDigitalOceanConfigurator,
+)
+from dstack._internal.core.backends.digitalocean_base.models import AnyBaseDigitalOceanCreds
+from dstack._internal.core.models.backends.base import (
+    BackendType,
+)
+
+
+class AMDDevCloudConfigurator(BaseDigitalOceanConfigurator):
+    TYPE = BackendType.AMDDEVCLOUD
+    BACKEND_CLASS = AMDDevCloudBackend
+    API_URL = "https://api-amd.digitalocean.com"
+
+    def get_backend(self, record: BackendRecord) -> BaseDigitalOceanBackend:
+        config = self._get_config(record)
+        return AMDDevCloudBackend(config=config, api_url=self.API_URL)
+
+    def _validate_creds(self, creds: AnyBaseDigitalOceanCreds, project_name: Optional[str] = None):
+        api_client = DigitalOceanAPIClient(creds.api_key, self.API_URL)
+        api_client.validate_api_key()
+        if project_name:
+            api_client.validate_project_name(project_name)

dstack/_internal/core/backends/aws/compute.py

@@ -292,7 +292,12 @@ class AWSCompute(
                         image_id=image_id,
                         instance_type=instance_offer.instance.name,
                         iam_instance_profile=self.config.iam_instance_profile,
-                        user_data=get_user_data(authorized_keys=instance_config.get_public_keys()),
+                        user_data=get_user_data(
+                            authorized_keys=instance_config.get_public_keys(),
+                            # Custom OS images may lack ufw, so don't attempt to set up the firewall.
+                            # Rely on security groups and the image's built-in firewall rules instead.
+                            skip_firewall_setup=self.config.os_images is not None,
+                        ),
                         tags=aws_resources.make_tags(tags),
                         security_group_id=security_group_id,
                         spot=instance_offer.instance.resources.spot,

dstack/_internal/core/backends/base/compute.py

@@ -4,6 +4,7 @@ import re
 import string
 import threading
 from abc import ABC, abstractmethod
+from collections.abc import Iterable
 from functools import lru_cache
 from pathlib import Path
 from typing import Dict, List, Literal, Optional
@@ -19,7 +20,7 @@ from dstack._internal.core.consts import (
     DSTACK_RUNNER_SSH_PORT,
     DSTACK_SHIM_HTTP_PORT,
 )
-from dstack._internal.core.models.configurations import DEFAULT_REPO_DIR
+from dstack._internal.core.models.configurations import LEGACY_REPO_DIR
 from dstack._internal.core.models.gateways import (
     GatewayComputeConfiguration,
     GatewayProvisioningData,
@@ -45,6 +46,7 @@ logger = get_logger(__name__)
 
 DSTACK_SHIM_BINARY_NAME = "dstack-shim"
 DSTACK_RUNNER_BINARY_NAME = "dstack-runner"
+DEFAULT_PRIVATE_SUBNETS = ("10.0.0.0/8", "172.16.0.0/12", "192.168.0.0/16")
 
 GoArchType = Literal["amd64", "arm64"]
 
@@ -507,12 +509,16 @@ def get_user_data(
     base_path: Optional[PathLike] = None,
     bin_path: Optional[PathLike] = None,
     backend_shim_env: Optional[Dict[str, str]] = None,
+    skip_firewall_setup: bool = False,
+    firewall_allow_from_subnets: Iterable[str] = DEFAULT_PRIVATE_SUBNETS,
 ) -> str:
     shim_commands = get_shim_commands(
         authorized_keys=authorized_keys,
         base_path=base_path,
         bin_path=bin_path,
         backend_shim_env=backend_shim_env,
+        skip_firewall_setup=skip_firewall_setup,
+        firewall_allow_from_subnets=firewall_allow_from_subnets,
     )
     commands = (backend_specific_commands or []) + shim_commands
     return get_cloud_config(
@@ -554,8 +560,13 @@ def get_shim_commands(
     bin_path: Optional[PathLike] = None,
     backend_shim_env: Optional[Dict[str, str]] = None,
     arch: Optional[str] = None,
+    skip_firewall_setup: bool = False,
+    firewall_allow_from_subnets: Iterable[str] = DEFAULT_PRIVATE_SUBNETS,
 ) -> List[str]:
-    commands = get_setup_cloud_instance_commands()
+    commands = get_setup_cloud_instance_commands(
+        skip_firewall_setup=skip_firewall_setup,
+        firewall_allow_from_subnets=firewall_allow_from_subnets,
+    )
     commands += get_shim_pre_start_commands(
         base_path=base_path,
         bin_path=bin_path,
@@ -638,8 +649,11 @@ def get_dstack_shim_download_url(arch: Optional[str] = None) -> str:
     return url_template.format(version=version, arch=arch)
 
 
-def get_setup_cloud_instance_commands() -> list[str]:
-    return [
+def get_setup_cloud_instance_commands(
+    skip_firewall_setup: bool,
+    firewall_allow_from_subnets: Iterable[str],
+) -> list[str]:
+    commands = [
         # Workaround for https://github.com/NVIDIA/nvidia-container-toolkit/issues/48
         # Attempts to patch /etc/docker/daemon.json while keeping any custom settings it may have.
         (
@@ -653,6 +667,19 @@ def get_setup_cloud_instance_commands() -> list[str]:
             "'"
         ),
     ]
+    if not skip_firewall_setup:
+        commands += [
+            "ufw --force reset",  # Some OS images have default rules like `allow 80`. Delete them
+            "ufw default deny incoming",
+            "ufw default allow outgoing",
+            "ufw allow ssh",
+        ]
+        for subnet in firewall_allow_from_subnets:
+            commands.append(f"ufw allow from {subnet}")
+        commands += [
+            "ufw --force enable",
+        ]
+    return commands
 
 
 def get_shim_pre_start_commands(
@@ -773,7 +800,8 @@ def get_docker_commands(
             f" --ssh-port {DSTACK_RUNNER_SSH_PORT}"
             " --temp-dir /tmp/runner"
             " --home-dir /root"
-            f" --working-dir {DEFAULT_REPO_DIR}"
+            # TODO: Not used, left for compatibility with old runners. Remove eventually.
+            f" --working-dir {LEGACY_REPO_DIR}"
         ),
     ]
 

dstack/_internal/core/backends/base/offers.py

@@ -34,6 +34,8 @@ def get_catalog_offers(
     provider = backend.value
     if backend == BackendType.LAMBDA:
         provider = "lambdalabs"
+    if backend == BackendType.AMDDEVCLOUD:
+        provider = "digitalocean"
     q = requirements_to_query_filter(requirements)
     q.provider = [provider]
     offers = []

dstack/_internal/core/backends/configurators.py

@@ -5,6 +5,12 @@ from dstack._internal.core.models.backends.base import BackendType
 
 _CONFIGURATOR_CLASSES: List[Type[Configurator]] = []
 
+try:
+    from dstack._internal.core.backends.amddevcloud.configurator import AMDDevCloudConfigurator
+
+    _CONFIGURATOR_CLASSES.append(AMDDevCloudConfigurator)
+except ImportError:
+    pass
 
 try:
     from dstack._internal.core.backends.aws.configurator import AWSConfigurator
@@ -47,6 +53,15 @@ try:
 except ImportError:
     pass
 
+try:
+    from dstack._internal.core.backends.digitalocean.configurator import (
+        DigitalOceanConfigurator,
+    )
+
+    _CONFIGURATOR_CLASSES.append(DigitalOceanConfigurator)
+except ImportError:
+    pass
+
 try:
     from dstack._internal.core.backends.gcp.configurator import GCPConfigurator
 

dstack/_internal/core/backends/digitalocean/__init__.py

@@ -0,0 +1 @@
+# DigitalOcean backend for dstack

dstack/_internal/core/backends/digitalocean/backend.py

@@ -0,0 +1,16 @@
+from dstack._internal.core.backends.digitalocean.compute import DigitalOceanCompute
+from dstack._internal.core.backends.digitalocean_base.backend import BaseDigitalOceanBackend
+from dstack._internal.core.backends.digitalocean_base.models import BaseDigitalOceanConfig
+from dstack._internal.core.models.backends.base import BackendType
+
+
+class DigitalOceanBackend(BaseDigitalOceanBackend):
+    TYPE = BackendType.DIGITALOCEAN
+    COMPUTE_CLASS = DigitalOceanCompute
+
+    def __init__(self, config: BaseDigitalOceanConfig, api_url: str):
+        self.config = config
+        self._compute = DigitalOceanCompute(self.config, api_url=api_url, type=self.TYPE)
+
+    def compute(self) -> DigitalOceanCompute:
+        return self._compute

dstack/_internal/core/backends/digitalocean/compute.py

@@ -0,0 +1,5 @@
+from ..digitalocean_base.compute import BaseDigitalOceanCompute
+
+
+class DigitalOceanCompute(BaseDigitalOceanCompute):
+    pass

dstack/_internal/core/backends/digitalocean/configurator.py

@@ -0,0 +1,31 @@
+from typing import Optional
+
+from dstack._internal.core.backends.base.configurator import BackendRecord
+from dstack._internal.core.backends.digitalocean.backend import DigitalOceanBackend
+from dstack._internal.core.backends.digitalocean_base.api_client import DigitalOceanAPIClient
+from dstack._internal.core.backends.digitalocean_base.backend import BaseDigitalOceanBackend
+from dstack._internal.core.backends.digitalocean_base.configurator import (
+    BaseDigitalOceanConfigurator,
+)
+from dstack._internal.core.backends.digitalocean_base.models import (
+    AnyBaseDigitalOceanCreds,
+)
+from dstack._internal.core.models.backends.base import (
+    BackendType,
+)
+
+
+class DigitalOceanConfigurator(BaseDigitalOceanConfigurator):
+    TYPE = BackendType.DIGITALOCEAN
+    BACKEND_CLASS = DigitalOceanBackend
+    API_URL = "https://api.digitalocean.com"
+
+    def get_backend(self, record: BackendRecord) -> BaseDigitalOceanBackend:
+        config = self._get_config(record)
+        return DigitalOceanBackend(config=config, api_url=self.API_URL)
+
+    def _validate_creds(self, creds: AnyBaseDigitalOceanCreds, project_name: Optional[str] = None):
+        api_client = DigitalOceanAPIClient(creds.api_key, self.API_URL)
+        api_client.validate_api_key()
+        if project_name:
+            api_client.validate_project_name(project_name)

dstack/_internal/core/backends/digitalocean_base/__init__.py

@@ -0,0 +1 @@
+# This package contains the base classes for DigitalOcean and AMDDevCloud backends.

dstack/_internal/core/backends/digitalocean_base/api_client.py

@@ -0,0 +1,104 @@
+from typing import Any, Dict, List, Optional
+
+import requests
+
+from dstack._internal.core.backends.base.configurator import raise_invalid_credentials_error
+from dstack._internal.core.errors import NoCapacityError
+from dstack._internal.utils.logging import get_logger
+
+logger = get_logger(__name__)
+
+
+class DigitalOceanAPIClient:
+    def __init__(self, api_key: str, api_url: str):
+        self.api_key = api_key
+        self.base_url = api_url
+
+    def validate_api_key(self) -> bool:
+        try:
+            response = self._make_request("GET", "/v2/account")
+            response.raise_for_status()
+            return True
+        except requests.HTTPError as e:
+            status = e.response.status_code
+            if status == 401:
+                raise_invalid_credentials_error(
+                    fields=[["creds", "api_key"]], details="Invaild API key"
+                )
+            raise e
+
+    def validate_project_name(self, project_name: str) -> bool:
+        if self.get_project_id(project_name) is None:
+            raise_invalid_credentials_error(
+                fields=[["project_name"]],
+                details=f"Project with name '{project_name}' does not exist",
+            )
+        return True
+
+    def list_ssh_keys(self) -> List[Dict[str, Any]]:
+        response = self._make_request("GET", "/v2/account/keys")
+        response.raise_for_status()
+        return response.json()["ssh_keys"]
+
+    def list_projects(self) -> List[Dict[str, Any]]:
+        response = self._make_request("GET", "/v2/projects")
+        response.raise_for_status()
+        return response.json()["projects"]
+
+    def get_project_id(self, project_name: str) -> Optional[str]:
+        projects = self.list_projects()
+        for project in projects:
+            if project["name"] == project_name:
+                return project["id"]
+        return None
+
+    def create_ssh_key(self, name: str, public_key: str) -> Dict[str, Any]:
+        payload = {"name": name, "public_key": public_key}
+        response = self._make_request("POST", "/v2/account/keys", json=payload)
+        response.raise_for_status()
+        return response.json()["ssh_key"]
+
+    def get_or_create_ssh_key(self, name: str, public_key: str) -> int:
+        ssh_keys = self.list_ssh_keys()
+        for ssh_key in ssh_keys:
+            if ssh_key["public_key"].strip() == public_key.strip():
+                return ssh_key["id"]
+
+        ssh_key = self.create_ssh_key(name, public_key)
+        return ssh_key["id"]
+
+    def create_droplet(self, droplet_config: Dict[str, Any]) -> Dict[str, Any]:
+        response = self._make_request("POST", "/v2/droplets", json=droplet_config)
+        if response.status_code == 422:
+            raise NoCapacityError(response.json()["message"])
+        response.raise_for_status()
+        return response.json()["droplet"]
+
+    def get_droplet(self, droplet_id: str) -> Dict[str, Any]:
+        response = self._make_request("GET", f"/v2/droplets/{droplet_id}")
+        response.raise_for_status()
+        return response.json()["droplet"]
+
+    def delete_droplet(self, droplet_id: str) -> None:
+        response = self._make_request("DELETE", f"/v2/droplets/{droplet_id}")
+        if response.status_code == 404:
+            logger.debug("DigitalOcean droplet %s not found", droplet_id)
+            return
+        response.raise_for_status()
+
+    def _make_request(
+        self, method: str, endpoint: str, json: Optional[Dict[str, Any]] = None, timeout: int = 30
+    ) -> requests.Response:
+        url = f"{self.base_url}{endpoint}"
+        headers = {
+            "Authorization": f"Bearer {self.api_key}",
+        }
+
+        response = requests.request(
+            method=method,
+            url=url,
+            headers=headers,
+            json=json,
+            timeout=timeout,
+        )
+        return response

dstack/_internal/core/backends/digitalocean_base/backend.py

@@ -0,0 +1,5 @@
+from dstack._internal.core.backends.base.backend import Backend
+
+
+class BaseDigitalOceanBackend(Backend):
+    pass

dstack/_internal/core/backends/digitalocean_base/compute.py

@@ -0,0 +1,173 @@
+from typing import List, Optional
+
+import gpuhunt
+from gpuhunt.providers.digitalocean import DigitalOceanProvider
+
+from dstack._internal.core.backends.base.backend import Compute
+from dstack._internal.core.backends.base.compute import (
+    ComputeWithCreateInstanceSupport,
+    generate_unique_instance_name,
+    get_user_data,
+)
+from dstack._internal.core.backends.base.offers import get_catalog_offers
+from dstack._internal.core.backends.digitalocean_base.api_client import DigitalOceanAPIClient
+from dstack._internal.core.backends.digitalocean_base.models import BaseDigitalOceanConfig
+from dstack._internal.core.errors import BackendError
+from dstack._internal.core.models.backends.base import BackendType
+from dstack._internal.core.models.instances import (
+    InstanceAvailability,
+    InstanceConfiguration,
+    InstanceOfferWithAvailability,
+)
+from dstack._internal.core.models.placement import PlacementGroup
+from dstack._internal.core.models.runs import JobProvisioningData, Requirements
+from dstack._internal.utils.logging import get_logger
+
+logger = get_logger(__name__)
+
+MAX_INSTANCE_NAME_LEN = 60
+DOCKER_INSTALL_COMMANDS = [
+    "export DEBIAN_FRONTEND=noninteractive",
+    "mkdir -p /etc/apt/keyrings",
+    "curl --max-time 60 -fsSL https://download.docker.com/linux/ubuntu/gpg | gpg --dearmor -o /etc/apt/keyrings/docker.gpg",
+    'echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | tee /etc/apt/sources.list.d/docker.list > /dev/null',
+    "apt-get update",
+    "apt-get --assume-yes install docker-ce docker-ce-cli containerd.io docker-compose-plugin",
+]
+
+
+class BaseDigitalOceanCompute(
+    ComputeWithCreateInstanceSupport,
+    Compute,
+):
+    def __init__(self, config: BaseDigitalOceanConfig, api_url: str, type: BackendType):
+        super().__init__()
+        self.config = config
+        self.api_client = DigitalOceanAPIClient(config.creds.api_key, api_url)
+        self.catalog = gpuhunt.Catalog(balance_resources=False, auto_reload=False)
+        self.BACKEND_TYPE = type
+        self.catalog.add_provider(
+            DigitalOceanProvider(api_key=config.creds.api_key, api_url=api_url)
+        )
+
+    def get_offers(
+        self, requirements: Optional[Requirements] = None
+    ) -> List[InstanceOfferWithAvailability]:
+        offers = get_catalog_offers(
+            backend=self.BACKEND_TYPE,
+            locations=self.config.regions,
+            requirements=requirements,
+            catalog=self.catalog,
+        )
+        return [
+            InstanceOfferWithAvailability(
+                **offer.dict(),
+                availability=InstanceAvailability.AVAILABLE,
+            )
+            for offer in offers
+        ]
+
+    def create_instance(
+        self,
+        instance_offer: InstanceOfferWithAvailability,
+        instance_config: InstanceConfiguration,
+        placement_group: Optional[PlacementGroup],
+    ) -> JobProvisioningData:
+        instance_name = generate_unique_instance_name(
+            instance_config, max_length=MAX_INSTANCE_NAME_LEN
+        )
+
+        project_ssh_key = instance_config.ssh_keys[0]
+        ssh_key_id = self.api_client.get_or_create_ssh_key(
+            name=f"dstack-{instance_config.project_name}",
+            public_key=project_ssh_key.public,
+        )
+        size_slug = instance_offer.instance.name
+
+        if not instance_offer.instance.resources.gpus:
+            backend_specific_commands = DOCKER_INSTALL_COMMANDS
+        else:
+            backend_specific_commands = None
+
+        project_id = None
+        if self.config.project_name:
+            project_id = self.api_client.get_project_id(self.config.project_name)
+            if project_id is None:
+                raise BackendError(f"Project {self.config.project_name} does not exist")
+        droplet_config = {
+            "name": instance_name,
+            "region": instance_offer.region,
+            "size": size_slug,
+            "image": self._get_image_for_instance(instance_offer),
+            "ssh_keys": [ssh_key_id],
+            "backups": False,
+            "ipv6": False,
+            "monitoring": False,
+            "tags": [],
+            "user_data": get_user_data(
+                authorized_keys=instance_config.get_public_keys(),
+                backend_specific_commands=backend_specific_commands,
+            ),
+            **({"project_id": project_id} if project_id is not None else {}),
+        }
+
+        droplet = self.api_client.create_droplet(droplet_config)
+
+        return JobProvisioningData(
+            backend=instance_offer.backend,
+            instance_type=instance_offer.instance,
+            instance_id=str(droplet["id"]),
+            hostname=None,
+            internal_ip=None,
+            region=instance_offer.region,
+            price=instance_offer.price,
+            username="root",
+            ssh_port=22,
+            dockerized=True,
+            ssh_proxy=None,
+            backend_data=None,
+        )
+
+    def update_provisioning_data(
+        self,
+        provisioning_data: JobProvisioningData,
+        project_ssh_public_key: str,
+        project_ssh_private_key: str,
+    ):
+        droplet = self.api_client.get_droplet(provisioning_data.instance_id)
+        if droplet["status"] == "active":
+            for network in droplet["networks"]["v4"]:
+                if network["type"] == "public":
+                    provisioning_data.hostname = network["ip_address"]
+                    break
+
+    def terminate_instance(
+        self, instance_id: str, region: str, backend_data: Optional[str] = None
+    ):
+        self.api_client.delete_droplet(instance_id)
+
+    def _get_image_for_instance(self, instance_offer: InstanceOfferWithAvailability) -> str:
+        if not instance_offer.instance.resources.gpus:
+            # No GPUs, use CPU image
+            return "ubuntu-24-04-x64"
+
+        gpu_count = len(instance_offer.instance.resources.gpus)
+        gpu_vendor = instance_offer.instance.resources.gpus[0].vendor
+
+        if gpu_vendor == gpuhunt.AcceleratorVendor.AMD:
+            # AMD GPU
+            return "digitaloceanai-rocmjupyter"
+        else:
+            # NVIDIA GPUs - DO only supports 1 and 8 GPU configurations.
+            # DO says for single GPU plans using GPUs other than H100s use "gpu-h100x1-base". DO does not provide guidance for x8 GPUs so assuming the same applies.
+            # See (https://docs.digitalocean.com/products/droplets/getting-started/recommended-gpu-setup/#aiml-ready-image)
+            if gpu_count == 8:
+                return "gpu-h100x8-base"
+            elif gpu_count == 1:
+                return "gpu-h100x1-base"
+            else:
+                # For Unsupported GPU count - use single GPU image and log warning
+                logger.warning(
+                    f"Unsupported NVIDIA GPU count: {gpu_count}, using single GPU image"
+                )
+                return "gpu-h100x1-base"