ds-caselaw-marklogic-api-client 29.0.0__py3-none-any.whl → 29.0.1__py3-none-any.whl

caselawclient/models/identifiers/__init__.py

@@ -177,6 +177,6 @@ class Identifiers(dict[str, Identifier]):
 
         :return: Return the highest scoring identifier of the given type (or of any type, if none is specified). Returns `None` if no identifier is available.
         """
-        if len(self) == 0:
+        if len(self.by_score(type)) == 0:
             return None
         return self.by_score(type)[0]

caselawclient/models/identifiers/unpacker.py

@@ -1,4 +1,5 @@
 from typing import Optional
+from warnings import warn
 
 from lxml import etree
 
@@ -19,12 +20,13 @@ def unpack_all_identifiers_from_etree(identifiers_etree: Optional[etree._Element
         return identifiers
     for identifier_etree in identifiers_etree.findall("identifier"):
         identifier = unpack_an_identifier_from_etree(identifier_etree)
-        identifiers.add(identifier)
+        if identifier:
+            identifiers.add(identifier)
     return identifiers
 
 
-def unpack_an_identifier_from_etree(identifier_xml: etree._Element) -> Identifier:
-    """Given an etree representation of a single identifier, unpack it into an appropriate instance of an Identifier."""
+def unpack_an_identifier_from_etree(identifier_xml: etree._Element) -> Optional[Identifier]:
+    """Given an etree representation of a single identifier, unpack it into an appropriate instance of an Identifier if the type is known (otherwise return `None`)."""
 
     namespace_element = identifier_xml.find("namespace")
 
@@ -33,6 +35,11 @@ def unpack_an_identifier_from_etree(identifier_xml: etree._Element) -> Identifie
             "Identifer XML representation is not valid: namespace not present or empty"
         )
 
+    # If the identifier namespace isn't known, fail out
+    if namespace_element.text not in IDENTIFIER_NAMESPACE_MAP:
+        warn(f"Identifier type {namespace_element.text} is not known.")
+        return None
+
     kwargs: dict[str, str] = {}
 
     for attribute in IDENTIFIER_UNPACKABLE_ATTRIBUTES:

{ds_caselaw_marklogic_api_client-29.0.0.dist-info → ds_caselaw_marklogic_api_client-29.0.1.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.1
 Name: ds-caselaw-marklogic-api-client
-Version: 29.0.0
+Version: 29.0.1
 Summary: An API client for interacting with the underlying data in Find Caselaw.
 Home-page: https://github.com/nationalarchives/ds-caselaw-custom-api-client
 Keywords: national archives,caselaw

{ds_caselaw_marklogic_api_client-29.0.0.dist-info → ds_caselaw_marklogic_api_client-29.0.1.dist-info}/RECORD

@@ -13,10 +13,10 @@ caselawclient/models/documents/exceptions.py,sha256=rw1xId16vBKvBImgFmFUpeFgKqU7
 caselawclient/models/documents/statuses.py,sha256=Cp4dTQmJOtsU41EJcxy5dV1841pGD2PNWH0VrkDEv4Q,579
 caselawclient/models/documents/transforms/html.xsl,sha256=oSSO-IBX4qLiSWexQYmWJfGNevF09aCBx4D1NYqXxpo,38322
 caselawclient/models/documents/xml.py,sha256=HlmPb63lLMnySSOLP4iexcAyQiLByKBZtTd25f8sY8M,1268
-caselawclient/models/identifiers/__init__.py,sha256=4D_ssfNK7gj7Z4XMHqCzn-EwsPM4a6IofYkU1JjnRF4,6449
+caselawclient/models/identifiers/__init__.py,sha256=9DtWdBQYrdiQC_LPyG-nnEj22vNJyuy9KSBTwSlN8EI,6464
 caselawclient/models/identifiers/fclid.py,sha256=pTO586ra0sr4DbjHSxuI8UlxfNXLm9nDNVoDUIxiUrE,1354
 caselawclient/models/identifiers/neutral_citation.py,sha256=3Jw1_-NmGfGmrWGFSzLdTHBYHIHq4tPkF8U7Jba-jGo,1848
-caselawclient/models/identifiers/unpacker.py,sha256=01gWWlOd_2PxT1GJzOIXbp0G4iGGIxHaTaJMBOQ1TDs,1834
+caselawclient/models/identifiers/unpacker.py,sha256=xvp480QESbN36NEc6qeo-orqOBq6WchnLI7thY7A1qs,2156
 caselawclient/models/judgments.py,sha256=xFjfOspa9ZL29gvvGVNq11JC7h-LKebFMrQYvVIIoEI,1868
 caselawclient/models/neutral_citation_mixin.py,sha256=LDaxNndLcTKsjJCyEKO1kGTJ6YD6h-6SzQVE0-gwPSI,2208
 caselawclient/models/press_summaries.py,sha256=bEqJxu-7eBLhwulOsDXYDl2ptIp3RkkMpOcdVvWB5ds,1836
@@ -77,7 +77,7 @@ caselawclient/xquery/validate_document.xqy,sha256=PgaDcnqCRJPIVqfmWsNlXmCLNKd21q
 caselawclient/xquery/xslt.xqy,sha256=w57wNijH3dkwHkpKeAxqjlghVflQwo8cq6jS_sm-erM,199
 caselawclient/xquery/xslt_transform.xqy,sha256=smyFFxqmtkuOzBd2l7uw6K2oAsYctudrP8omdv_XNAM,2463
 caselawclient/xquery_type_dicts.py,sha256=kybL-YzwK34Fr6MeWfqVOJHYrs0ZNeDWXDsp8o2Yb1U,6114
-ds_caselaw_marklogic_api_client-29.0.0.dist-info/LICENSE.md,sha256=fGMzyyLuQW-IAXUeDSCrRdsYW536aEWThdbpCjo6ZKg,1108
-ds_caselaw_marklogic_api_client-29.0.0.dist-info/METADATA,sha256=x0GZ0GgA91sa_O9Eq2aal3FONl6Vs2lknsPdrPUmlzE,4272
-ds_caselaw_marklogic_api_client-29.0.0.dist-info/WHEEL,sha256=7Z8_27uaHI_UZAc4Uox4PpBhQ9Y5_modZXWMxtUi4NU,88
-ds_caselaw_marklogic_api_client-29.0.0.dist-info/RECORD,,
+ds_caselaw_marklogic_api_client-29.0.1.dist-info/LICENSE.md,sha256=fGMzyyLuQW-IAXUeDSCrRdsYW536aEWThdbpCjo6ZKg,1108
+ds_caselaw_marklogic_api_client-29.0.1.dist-info/METADATA,sha256=6r95tWetaoYKAZq0gj8l44h_iTSuXpSkIDCFWzQxLX8,4272
+ds_caselaw_marklogic_api_client-29.0.1.dist-info/WHEEL,sha256=7Z8_27uaHI_UZAc4Uox4PpBhQ9Y5_modZXWMxtUi4NU,88
+ds_caselaw_marklogic_api_client-29.0.1.dist-info/RECORD,,