dls-dodal 1.66.0__py3-none-any.whl → 1.68.0__py3-none-any.whl

dodal/beamlines/i09_2.py

@@ -1,18 +1,39 @@
+from pathlib import Path
+
+from daq_config_server.client import ConfigServer
+
 from dodal.common.beamlines.beamline_utils import (
     device_factory,
 )
 from dodal.common.beamlines.beamline_utils import set_beamline as set_utils_beamline
-from dodal.devices.apple2_undulator import (
+from dodal.devices.i09.enums import Grating
+from dodal.devices.i09_2_shared.i09_apple2 import (
+    J09_GAP_POLY_DEG_COLUMNS,
+    J09_PHASE_POLY_DEG_COLUMNS,
+)
+from dodal.devices.insertion_device import (
     Apple2,
+    Apple2EnforceLHMoveController,
+    BeamEnergy,
+    InsertionDeviceEnergy,
+    InsertionDevicePolarisation,
     UndulatorGap,
     UndulatorPhaseAxes,
 )
-from dodal.devices.i09.enums import Grating
+from dodal.devices.insertion_device.energy_motor_lookup import (
+    ConfigServerEnergyMotorLookup,
+)
+from dodal.devices.insertion_device.lookup_table_models import LookupTableColumnConfig
 from dodal.devices.pgm import PlaneGratingMonochromator
 from dodal.devices.synchrotron import Synchrotron
 from dodal.log import set_beamline as set_log_beamline
 from dodal.utils import BeamlinePrefix, get_beamline_name
 
+J09_CONF_CLIENT = ConfigServer(url="https://daq-config.diamond.ac.uk")
+LOOK_UPTABLE_DIR = "/dls_sw/i09-2/software/gda/workspace_git/gda-diamond.git/configurations/i09-2-shared/lookupTables/"
+GAP_LOOKUP_FILE_NAME = "JIDEnergy2GapCalibrations.csv"
+PHASE_LOOKUP_FILE_NAME = "JIDEnergy2PhaseCalibrations.csv"
+
 BL = get_beamline_name("i09-2")
 PREFIX = BeamlinePrefix(BL, suffix="J")
 set_log_beamline(BL)
@@ -55,3 +76,38 @@ def jid() -> Apple2:
         id_gap=jid_gap(),
         id_phase=jid_phase(),
     )
+
+
+@device_factory()
+def jid_controller() -> Apple2EnforceLHMoveController:
+    """J09 insertion device controller."""
+    return Apple2EnforceLHMoveController(
+        apple2=jid(),
+        gap_energy_motor_lut=ConfigServerEnergyMotorLookup(
+            lut_config=LookupTableColumnConfig(poly_deg=J09_GAP_POLY_DEG_COLUMNS),
+            config_client=J09_CONF_CLIENT,
+            path=Path(LOOK_UPTABLE_DIR, GAP_LOOKUP_FILE_NAME),
+        ),
+        phase_energy_motor_lut=ConfigServerEnergyMotorLookup(
+            lut_config=LookupTableColumnConfig(poly_deg=J09_PHASE_POLY_DEG_COLUMNS),
+            config_client=J09_CONF_CLIENT,
+            path=Path(LOOK_UPTABLE_DIR, PHASE_LOOKUP_FILE_NAME),
+        ),
+        units="keV",
+    )
+
+
+@device_factory()
+def jid_energy() -> InsertionDeviceEnergy:
+    return InsertionDeviceEnergy(id_controller=jid_controller())
+
+
+@device_factory()
+def jid_polarisation() -> InsertionDevicePolarisation:
+    return InsertionDevicePolarisation(id_controller=jid_controller())
+
+
+@device_factory()
+def energy_jid() -> BeamEnergy:
+    """Beam energy."""
+    return BeamEnergy(id_energy=jid_energy(), mono=pgm().energy)

dodal/beamlines/i10_optics.py

@@ -12,14 +12,6 @@ from daq_config_server.client import ConfigServer
 
 from dodal.common.beamlines.beamline_utils import device_factory
 from dodal.common.beamlines.beamline_utils import set_beamline as set_utils_beamline
-from dodal.devices.apple2_undulator import (
-    BeamEnergy,
-    InsertionDeviceEnergy,
-    InsertionDevicePolarisation,
-    UndulatorGap,
-    UndulatorJawPhase,
-    UndulatorPhaseAxes,
-)
 from dodal.devices.i10 import (
     I10SharedDiagnostic,
     I10SharedSlits,
@@ -34,14 +26,25 @@ from dodal.devices.i10.i10_apple2 import (
 
 # Imports taken from i10 while we work out how to deal with split end stations
 from dodal.devices.i10.i10_setting_data import I10Grating
-from dodal.devices.pgm import PlaneGratingMonochromator
-from dodal.devices.synchrotron import Synchrotron
-from dodal.devices.util.lookup_tables_apple2 import (
+from dodal.devices.insertion_device import (
+    BeamEnergy,
+    InsertionDeviceEnergy,
+    InsertionDevicePolarisation,
+    UndulatorGap,
+    UndulatorJawPhase,
+    UndulatorPhaseAxes,
+)
+from dodal.devices.insertion_device.energy_motor_lookup import (
+    ConfigServerEnergyMotorLookup,
+)
+from dodal.devices.insertion_device.lookup_table_models import (
     DEFAULT_GAP_FILE,
     DEFAULT_PHASE_FILE,
-    EnergyMotorLookup,
-    LookupTableConfig,
+    LookupTableColumnConfig,
+    Source,
 )
+from dodal.devices.pgm import PlaneGratingMonochromator
+from dodal.devices.synchrotron import Synchrotron
 from dodal.log import set_beamline as set_log_beamline
 from dodal.utils import BeamlinePrefix, get_beamline_name
 
@@ -50,8 +53,6 @@ set_log_beamline(BL)
 set_utils_beamline(BL)
 PREFIX = BeamlinePrefix(BL)
 
-LOOK_UPTABLE_DIR = "/dls_sw/i10/software/blueapi/scratch/i10-config/lookupTables/"
-
 
 @device_factory()
 def synchrotron() -> Synchrotron:
@@ -123,13 +124,22 @@ def idd() -> I10Apple2:
 @device_factory()
 def idd_controller() -> I10Apple2Controller:
     """I10 downstream insertion device controller."""
-    idd_energy_motor_lut = EnergyMotorLookup(
+    source = Source(column="Source", value="idd")
+    idd_gap_energy_motor_lut = ConfigServerEnergyMotorLookup(
         config_client=I10_CONF_CLIENT,
-        lut_config=LookupTableConfig(source=("Source", "idd")),
-        gap_path=Path(LOOK_UPTABLE_DIR, DEFAULT_GAP_FILE),
-        phase_path=Path(LOOK_UPTABLE_DIR, DEFAULT_PHASE_FILE),
+        lut_config=LookupTableColumnConfig(source=source),
+        path=Path(LOOK_UPTABLE_DIR, DEFAULT_GAP_FILE),
+    )
+    idd_phase_energy_motor_lut = ConfigServerEnergyMotorLookup(
+        config_client=I10_CONF_CLIENT,
+        lut_config=LookupTableColumnConfig(source=source),
+        path=Path(LOOK_UPTABLE_DIR, DEFAULT_PHASE_FILE),
+    )
+    return I10Apple2Controller(
+        apple2=idd(),
+        gap_energy_motor_lut=idd_gap_energy_motor_lut,
+        phase_energy_motor_lut=idd_phase_energy_motor_lut,
     )
-    return I10Apple2Controller(apple2=idd(), energy_motor_lut=idd_energy_motor_lut)
 
 
 @device_factory()
@@ -188,13 +198,22 @@ def idu() -> I10Apple2:
 @device_factory()
 def idu_controller() -> I10Apple2Controller:
     """I10 upstream insertion device controller."""
-    idu_energy_motor_lut = EnergyMotorLookup(
+    source = Source(column="Source", value="idu")
+    idu_gap_energy_motor_lut = ConfigServerEnergyMotorLookup(
         config_client=I10_CONF_CLIENT,
-        lut_config=LookupTableConfig(source=("Source", "idu")),
-        gap_path=Path(LOOK_UPTABLE_DIR, DEFAULT_GAP_FILE),
-        phase_path=Path(LOOK_UPTABLE_DIR, DEFAULT_PHASE_FILE),
+        lut_config=LookupTableColumnConfig(source=source),
+        path=Path(LOOK_UPTABLE_DIR, DEFAULT_GAP_FILE),
+    )
+    idu_phase_energy_motor_lut = ConfigServerEnergyMotorLookup(
+        config_client=I10_CONF_CLIENT,
+        lut_config=LookupTableColumnConfig(source=source),
+        path=Path(LOOK_UPTABLE_DIR, DEFAULT_PHASE_FILE),
+    )
+    return I10Apple2Controller(
+        apple2=idd(),
+        gap_energy_motor_lut=idu_gap_energy_motor_lut,
+        phase_energy_motor_lut=idu_phase_energy_motor_lut,
     )
-    return I10Apple2Controller(apple2=idd(), energy_motor_lut=idu_energy_motor_lut)
 
 
 @device_factory()

dodal/beamlines/i16.py

@@ -0,0 +1,23 @@
+from dodal.common.beamlines.beamline_utils import set_beamline as set_utils_beamline
+from dodal.device_manager import DeviceManager
+from dodal.devices.undulator import UndulatorInMm, UndulatorOrder
+from dodal.log import set_beamline as set_log_beamline
+from dodal.utils import BeamlinePrefix, get_beamline_name
+
+BL = get_beamline_name("i16")
+set_log_beamline(BL)
+set_utils_beamline(BL)
+PREFIX = BeamlinePrefix(BL)
+
+
+devices = DeviceManager()
+
+
+@devices.factory()
+def id() -> UndulatorInMm:
+    return UndulatorInMm(prefix=f"{PREFIX.insertion_prefix}-MO-SERVC-01:")
+
+
+@devices.factory()
+def harmonic() -> UndulatorOrder:
+    return UndulatorOrder()

dodal/beamlines/i17.py

@@ -7,7 +7,8 @@ from dodal.common.beamlines.beamline_utils import (
     device_factory,
 )
 from dodal.common.beamlines.beamline_utils import set_beamline as set_utils_beamline
-from dodal.devices.apple2_undulator import (
+from dodal.devices.i17.i17_apple2 import I17Apple2Controller
+from dodal.devices.insertion_device import (
     Apple2,
     Apple2Controller,
     BeamEnergy,
@@ -16,7 +17,8 @@ from dodal.devices.apple2_undulator import (
     UndulatorGap,
     UndulatorPhaseAxes,
 )
-from dodal.devices.i17.i17_apple2 import I17Apple2Controller
+from dodal.devices.insertion_device.energy_motor_lookup import EnergyMotorLookup
+from dodal.devices.insertion_device.lookup_table_models import LookupTable
 from dodal.devices.pgm import PlaneGratingMonochromator
 from dodal.devices.synchrotron import Synchrotron
 from dodal.log import set_beamline as set_log_beamline
@@ -76,7 +78,9 @@ def id() -> Apple2:
 def id_controller() -> Apple2Controller:
     """I17 insertion device controller with dummy energy to motor_converter."""
     return I17Apple2Controller(
-        apple2=id(), energy_to_motor_converter=lambda energy, pol: (0.0, 0.0)
+        apple2=id(),
+        gap_energy_motor_lut=EnergyMotorLookup(lut=LookupTable()),
+        phase_energy_motor_lut=EnergyMotorLookup(lut=LookupTable()),
     )
 
 

dodal/beamlines/i19_1.py

@@ -4,6 +4,9 @@ from dodal.common.beamlines.beamline_utils import (
 from dodal.common.beamlines.beamline_utils import (
     set_beamline as set_utils_beamline,
 )
+from dodal.devices.i19.access_controlled.attenuator_motor_squad import (
+    AttenuatorMotorSquad,
+)
 from dodal.devices.i19.access_controlled.blueapi_device import HutchState
 from dodal.devices.i19.access_controlled.shutter import (
     AccessControlledShutter,
@@ -29,6 +32,8 @@ set_log_beamline(BL)
 set_utils_beamline(BL)
 
 
+I19_1_COMMISSIONING_INSTR_SESSION: str = "cm40638-5"
+
 I19_1_ZEBRA_MAPPING = ZebraMapping(
     outputs=ZebraTTLOutputs(TTL_PILATUS=1),
     sources=ZebraSources(),
@@ -40,6 +45,13 @@ ZOOM_PARAMS_FILE = (
 DISPLAY_CONFIG = "/dls_sw/i19-1/software/daq_configuration/domain/display.configuration"
 
 
+@device_factory()
+def attenuator_motor_squad() -> AttenuatorMotorSquad:
+    return AttenuatorMotorSquad(
+        hutch=HutchState.EH1, instrument_session=I19_1_COMMISSIONING_INSTR_SESSION
+    )
+
+
 # Needs to wait until enum is fixed on the beamline
 # See https://github.com/DiamondLightSource/dodal/issues/1150
 @device_factory()
@@ -58,19 +70,6 @@ def oav() -> OAVBeamCentreFile:
     )
 
 
-# NOTE EH1 uses the Zebra 2 box. While a Zebra 1 box exists and is connected
-# on the beamline, it is currently not in use
-@device_factory()
-def zebra() -> Zebra:
-    """Get the i19-1 zebra device, instantiate it if it hasn't already been.
-    If this is called when already instantiated in i19-1, it will return the existing object.
-    """
-    return Zebra(
-        mapping=I19_1_ZEBRA_MAPPING,
-        prefix=f"{PREFIX.beamline_prefix}-EA-ZEBRA-02:",
-    )
-
-
 @device_factory()
 def shutter() -> AccessControlledShutter:
     """Get the i19-1 hutch shutter device, instantiate it if it hasn't already been.
@@ -79,7 +78,7 @@ def shutter() -> AccessControlledShutter:
     return AccessControlledShutter(
         prefix=f"{PREFIX.beamline_prefix}-PS-SHTR-01:",
         hutch=HutchState.EH1,
-        instrument_session="cm40638-4",
+        instrument_session=I19_1_COMMISSIONING_INSTR_SESSION,
     )
 
 
@@ -89,3 +88,16 @@ def synchrotron() -> Synchrotron:
     If this is called when already instantiated in i19-1, it will return the existing object.
     """
     return Synchrotron()
+
+
+# NOTE EH1 uses the Zebra 2 box. While a Zebra 1 box exists and is connected
+# on the beamline, it is currently not in use
+@device_factory()
+def zebra() -> Zebra:
+    """Get the i19-1 zebra device, instantiate it if it hasn't already been.
+    If this is called when already instantiated in i19-1, it will return the existing object.
+    """
+    return Zebra(
+        mapping=I19_1_ZEBRA_MAPPING,
+        prefix=f"{PREFIX.beamline_prefix}-EA-ZEBRA-02:",
+    )

dodal/beamlines/i19_2.py

@@ -12,6 +12,9 @@ from dodal.common.beamlines.beamline_utils import (
     set_beamline as set_utils_beamline,
 )
 from dodal.common.visit import StaticVisitPathProvider
+from dodal.devices.i19.access_controlled.attenuator_motor_squad import (
+    AttenuatorMotorSquad,
+)
 from dodal.devices.i19.access_controlled.blueapi_device import HutchState
 from dodal.devices.i19.access_controlled.shutter import AccessControlledShutter
 from dodal.devices.i19.backlight import BacklightPosition
@@ -43,6 +46,7 @@ set_path_provider(
     )
 )
 
+I19_2_COMMISSIONING_INSTR_SESSION: str = "cm40639-5"
 
 I19_2_ZEBRA_MAPPING = ZebraMapping(
     outputs=ZebraTTLOutputs(),
@@ -51,8 +55,18 @@ I19_2_ZEBRA_MAPPING = ZebraMapping(
 
 
 @device_factory()
-def diffractometer() -> FourCircleDiffractometer:
-    return FourCircleDiffractometer(prefix=PREFIX.beamline_prefix)
+def attenuator_motor_squad() -> AttenuatorMotorSquad:
+    return AttenuatorMotorSquad(
+        hutch=HutchState.EH2, instrument_session=I19_2_COMMISSIONING_INSTR_SESSION
+    )
+
+
+@device_factory()
+def backlight() -> BacklightPosition:
+    """Get the i19-2 backlight device, instantiate it if it hasn't already been.
+    If this is called when already instantiated in i19-2, it will return the existing object.
+    """
+    return BacklightPosition(prefix=f"{PREFIX.beamline_prefix}-EA-IOC-12:")
 
 
 @device_factory()
@@ -64,34 +78,26 @@ def beamstop() -> BeamStop:
 
 
 @device_factory()
-def zebra() -> Zebra:
-    """Get the i19-2 zebra device, instantiate it if it hasn't already been.
-    If this is called when already instantiated in i19-2, it will return the existing object.
-    """
-    return Zebra(
-        mapping=I19_2_ZEBRA_MAPPING,
-        prefix=f"{PREFIX.beamline_prefix}-EA-ZEBRA-03:",
-    )
+def diffractometer() -> FourCircleDiffractometer:
+    return FourCircleDiffractometer(prefix=PREFIX.beamline_prefix)
 
 
 @device_factory()
-def shutter() -> AccessControlledShutter:
-    """Get the i19-2 hutch shutter device, instantiate it if it hasn't already been.
-    If this is called when already instantiated, it will return the existing object.
-    """
-    return AccessControlledShutter(
-        prefix=f"{PREFIX.beamline_prefix}-PS-SHTR-01:",
-        hutch=HutchState.EH2,
-        instrument_session="cm40639-4",
+def eiger() -> EigerDetector:
+    return EigerDetector(
+        prefix=PREFIX.beamline_prefix,
+        path_provider=get_path_provider(),
+        drv_suffix="-EA-EIGER-01:",
+        hdf_suffix="-EA-EIGER-01:OD:",
     )
 
 
 @device_factory()
-def synchrotron() -> Synchrotron:
-    """Get the i19-2 synchrotron device, instantiate it if it hasn't already been.
-    If this is called when already instantiated in i19-2, it will return the existing object.
-    """
-    return Synchrotron()
+def panda() -> HDFPanda:
+    return HDFPanda(
+        prefix=f"{PREFIX.beamline_prefix}-EA-PANDA-01:",
+        path_provider=get_path_provider(),
+    )
 
 
 @device_factory()
@@ -104,26 +110,31 @@ def pinhole_and_collimator() -> PinholeCollimatorControl:
 
 
 @device_factory()
-def backlight() -> BacklightPosition:
-    """Get the i19-2 backlight device, instantiate it if it hasn't already been.
-    If this is called when already instantiated in i19-2, it will return the existing object.
+def shutter() -> AccessControlledShutter:
+    """Get the i19-2 hutch shutter device, instantiate it if it hasn't already been.
+    If this is called when already instantiated, it will return the existing object.
     """
-    return BacklightPosition(prefix=f"{PREFIX.beamline_prefix}-EA-IOC-12:")
+    return AccessControlledShutter(
+        prefix=f"{PREFIX.beamline_prefix}-PS-SHTR-01:",
+        hutch=HutchState.EH2,
+        instrument_session=I19_2_COMMISSIONING_INSTR_SESSION,
+    )
 
 
 @device_factory()
-def panda() -> HDFPanda:
-    return HDFPanda(
-        prefix=f"{PREFIX.beamline_prefix}-EA-PANDA-01:",
-        path_provider=get_path_provider(),
-    )
+def synchrotron() -> Synchrotron:
+    """Get the i19-2 synchrotron device, instantiate it if it hasn't already been.
+    If this is called when already instantiated in i19-2, it will return the existing object.
+    """
+    return Synchrotron()
 
 
 @device_factory()
-def eiger() -> EigerDetector:
-    return EigerDetector(
-        prefix=PREFIX.beamline_prefix,
-        path_provider=get_path_provider(),
-        drv_suffix="-EA-EIGER-01:",
-        hdf_suffix="-EA-EIGER-01:OD:",
+def zebra() -> Zebra:
+    """Get the i19-2 zebra device, instantiate it if it hasn't already been.
+    If this is called when already instantiated in i19-2, it will return the existing object.
+    """
+    return Zebra(
+        mapping=I19_2_ZEBRA_MAPPING,
+        prefix=f"{PREFIX.beamline_prefix}-EA-ZEBRA-03:",
     )

dodal/beamlines/i21.py

@@ -1,13 +1,27 @@
+from pathlib import Path
+
+from daq_config_server.client import ConfigServer
+
 from dodal.common.beamlines.beamline_utils import (
     device_factory,
 )
 from dodal.common.beamlines.beamline_utils import set_beamline as set_utils_beamline
-from dodal.devices.apple2_undulator import (
+from dodal.devices.i21 import (
+    Grating,
+)
+from dodal.devices.insertion_device import (
     Apple2,
+    Apple2EnforceLHMoveController,
+    BeamEnergy,
+    InsertionDeviceEnergy,
+    InsertionDevicePolarisation,
     UndulatorGap,
     UndulatorPhaseAxes,
 )
-from dodal.devices.i21 import Grating
+from dodal.devices.insertion_device.energy_motor_lookup import (
+    ConfigServerEnergyMotorLookup,
+)
+from dodal.devices.insertion_device.lookup_table_models import LookupTableColumnConfig
 from dodal.devices.pgm import PlaneGratingMonochromator
 from dodal.devices.synchrotron import Synchrotron
 from dodal.log import set_beamline as set_log_beamline
@@ -18,6 +32,14 @@ PREFIX = BeamlinePrefix(BL)
 set_log_beamline(BL)
 set_utils_beamline(BL)
 
+I21_PHASE_POLY_DEG_COLUMNS = ["b"]
+I21_GRATING_COLUMNS = "Grating"
+
+I21_CONF_CLIENT = ConfigServer(url="https://daq-config.diamond.ac.uk")
+LOOK_UPTABLE_DIR = "/dls_sw/i21/software/gda/workspace_git/gda-diamond.git/configurations/i21-config/lookupTables/"
+GAP_LOOKUP_FILE_NAME = "IDEnergy2GapCalibrations.csv"
+PHASE_LOOKUP_FILE_NAME = "IDEnergy2PhaseCalibrations.csv"
+
 
 @device_factory()
 def synchrotron() -> Synchrotron:
@@ -55,3 +77,40 @@ def id() -> Apple2:
         id_gap=id_gap(),
         id_phase=id_phase(),
     )
+
+
+@device_factory()
+def id_controller() -> Apple2EnforceLHMoveController:
+    """i21 insertion device controller."""
+    return Apple2EnforceLHMoveController(
+        apple2=id(),
+        gap_energy_motor_lut=ConfigServerEnergyMotorLookup(
+            lut_config=LookupTableColumnConfig(grating=I21_GRATING_COLUMNS),
+            config_client=I21_CONF_CLIENT,
+            path=Path(LOOK_UPTABLE_DIR, GAP_LOOKUP_FILE_NAME),
+        ),
+        phase_energy_motor_lut=ConfigServerEnergyMotorLookup(
+            lut_config=LookupTableColumnConfig(
+                grating=I21_GRATING_COLUMNS, poly_deg=I21_PHASE_POLY_DEG_COLUMNS
+            ),
+            config_client=I21_CONF_CLIENT,
+            path=Path(LOOK_UPTABLE_DIR, GAP_LOOKUP_FILE_NAME),
+        ),
+        units="eV",
+    )
+
+
+@device_factory()
+def id_energy() -> InsertionDeviceEnergy:
+    return InsertionDeviceEnergy(id_controller=id_controller())
+
+
+@device_factory()
+def id_polarisation() -> InsertionDevicePolarisation:
+    return InsertionDevicePolarisation(id_controller=id_controller())
+
+
+@device_factory()
+def energy_jid() -> BeamEnergy:
+    """Beam energy."""
+    return BeamEnergy(id_energy=id_energy(), mono=pgm().energy)

dodal/beamlines/i22.py

@@ -19,7 +19,7 @@ from dodal.devices.i22.dcm import DCM
 from dodal.devices.i22.fswitch import FSwitch
 from dodal.devices.i22.nxsas import NXSasMetadataHolder, NXSasOAV, NXSasPilatus
 from dodal.devices.linkam3 import Linkam3
-from dodal.devices.motors import XYPitchStage
+from dodal.devices.motors import XYPitchStage, XYRollStage, XYStage
 from dodal.devices.slits import Slits
 from dodal.devices.synchrotron import Synchrotron
 from dodal.devices.tetramm import TetrammDetector
@@ -274,3 +274,18 @@ def ppump() -> WatsonMarlow323Pump:
 @device_factory()
 def base() -> XYPitchStage:
     return XYPitchStage(f"{PREFIX.beamline_prefix}-MO-STABL-01:")
+
+
+@device_factory()
+def bs1() -> XYStage:
+    return XYStage(f"{PREFIX.beamline_prefix}-MO-SAXSP-01:BS1:")
+
+
+@device_factory()
+def bs2() -> XYStage:
+    return XYStage(f"{PREFIX.beamline_prefix}-MO-SAXSP-01:BS2:")
+
+
+@device_factory()
+def bs3() -> XYRollStage:
+    return XYRollStage(f"{PREFIX.beamline_prefix}-MO-SAXSP-01:BS3:")

dodal/beamlines/p60.py

@@ -2,7 +2,7 @@ from dodal.common.beamlines.beamline_utils import (
     device_factory,
 )
 from dodal.common.beamlines.beamline_utils import set_beamline as set_utils_beamline
-from dodal.devices.electron_analyser import DualEnergySource
+from dodal.devices.electron_analyser.base import DualEnergySource
 from dodal.devices.electron_analyser.vgscienta import VGScientaDetector
 from dodal.devices.p60 import (
     LabXraySource,

dodal/beamlines/training_rig.py

@@ -1,19 +1,12 @@
-from pathlib import Path
-
 from ophyd_async.epics.adaravis import AravisDetector
 from ophyd_async.fastcs.panda import HDFPanda
 
 from dodal.common.beamlines.beamline_utils import (
     device_factory,
     get_path_provider,
-    set_path_provider,
 )
 from dodal.common.beamlines.beamline_utils import set_beamline as set_utils_beamline
 from dodal.common.beamlines.device_helpers import DET_SUFFIX, HDF5_SUFFIX
-from dodal.common.visit import (
-    LocalDirectoryServiceClient,
-    StaticVisitPathProvider,
-)
 from dodal.devices.motors import XThetaStage
 from dodal.log import set_beamline as set_log_beamline
 from dodal.utils import BeamlinePrefix, get_beamline_name
@@ -35,15 +28,6 @@ set_log_beamline(BL)
 set_utils_beamline(BL)
 
 
-set_path_provider(
-    StaticVisitPathProvider(
-        BL,
-        Path("/exports/mybeamline/data/2025"),
-        client=LocalDirectoryServiceClient(),
-    )
-)
-
-
 @device_factory()
 def sample_stage() -> XThetaStage:
     return XThetaStage(f"{PREFIX.beamline_prefix}-MO-MAP-01:STAGE:")