dkist-processing-visp 5.1.2rc2__py3-none-any.whl → 5.2.0rc1__py3-none-any.whl

dkist_processing_visp/tests/test_wavelength_calibration.py

@@ -0,0 +1,297 @@
+import json
+
+import astropy.units as u
+import numpy as np
+import pytest
+from astropy.stats import gaussian_fwhm_to_sigma
+from astropy.units import Quantity
+from dkist_processing_common._util.scratch import WorkflowFileSystem
+from dkist_processing_common.codecs.fits import fits_array_encoder
+from dkist_processing_common.codecs.json import json_decoder
+from dkist_processing_common.models.metric_code import MetricCode
+from scipy.ndimage import gaussian_filter
+from solar_wavelength_calibration import Atlas
+
+from dkist_processing_visp.models.tags import VispTag
+from dkist_processing_visp.tasks.wavelength_calibration import WavelengthCalibration
+from dkist_processing_visp.tasks.wavelength_calibration import compute_initial_dispersion
+from dkist_processing_visp.tasks.wavelength_calibration import compute_input_wavelength_vector
+from dkist_processing_visp.tasks.wavelength_calibration import compute_order
+from dkist_processing_visp.tests.conftest import VispConstantsDb
+from dkist_processing_visp.tests.conftest import VispInputDatasetParameterValues
+
+
+@pytest.fixture(scope="session")
+def opacity_factor() -> float:
+    return 0.8
+
+
+@pytest.fixture(scope="session")
+def continuum_level() -> float:
+    return 1.1
+
+
+@pytest.fixture(scope="session")
+def straylight_fraction() -> float:
+    return 0.7
+
+
+@pytest.fixture(scope="session")
+def offset_factor() -> Quantity:
+    # Given the wavelength we're using, a negative value here lets us have a larger offset. Positive offsets of a similar
+    # magnitude at the same wavelength range push us into a tough-to-fit region of the spectrum.
+    return 0.15 * u.nm
+
+
+@pytest.fixture(scope="session")
+def num_wave_pix() -> int:
+    return 1000
+
+
+@pytest.fixture(scope="session")
+def wavelength() -> u.Quantity:
+    return 589.23 * u.nm
+
+
+@pytest.fixture(scope="session")
+def grating_constant() -> u.Quantity:
+    return 316.0 / u.mm
+
+
+@pytest.fixture(scope="session")
+def order() -> int:
+    return 10
+
+
+@pytest.fixture(scope="session")
+def incident_light_angle() -> u.Quantity:
+    return 73.22 * u.deg
+
+
+@pytest.fixture(scope="session")
+def reflected_light_angle() -> u.Quantity:
+    return 64.91983 * u.deg
+
+
+@pytest.fixture(scope="session")
+def pixel_pitch() -> u.Quantity:
+    return 6.5 * u.micron / u.pix
+
+
+@pytest.fixture(scope="session")
+def lens_parameters_no_units() -> list[float]:
+    return [0.9512, 2.141e-4, -1.014e-7]
+
+
+@pytest.fixture(scope="session")
+def lens_parameters(lens_parameters_no_units) -> list[u.Quantity]:
+    return [
+        lens_parameters_no_units[0] * u.m,
+        lens_parameters_no_units[1] * u.m / u.nm,
+        lens_parameters_no_units[2] * u.m / u.nm**2,
+    ]
+
+
+@pytest.fixture(scope="session")
+def dispersion(
+    wavelength, incident_light_angle, reflected_light_angle, lens_parameters, pixel_pitch
+) -> u.Quantity:
+    return compute_initial_dispersion(
+        central_wavelength=wavelength,
+        incident_light_angle=incident_light_angle,
+        reflected_light_angle=reflected_light_angle,
+        lens_parameters=lens_parameters,
+        pixel_pitch=pixel_pitch,
+    )
+
+
+@pytest.fixture(scope="session")
+def resolving_power() -> int:
+    return int(1.15e5)
+
+
+@pytest.fixture(scope="session")
+def solar_atlas() -> Atlas:
+    return Atlas()
+
+
+@pytest.fixture(scope="function")
+def visp_wavelength_correction_task(
+    tmp_path,
+    recipe_run_id,
+    assign_input_dataset_doc_to_task,
+    init_visp_constants_db,
+    wavelength,
+    solar_atlas,
+    dispersion,
+    num_wave_pix,
+    resolving_power,
+    incident_light_angle,
+    reflected_light_angle,
+    grating_constant,
+    order,
+    offset_factor,
+    opacity_factor,
+    continuum_level,
+    straylight_fraction,
+    num_start_nans,
+):
+    num_beams = 2
+    char_spec_shape = (num_wave_pix, 2560)
+    arm_id = 2
+
+    constants_db = VispConstantsDb(
+        NUM_BEAMS=num_beams,
+        INCIDENT_LIGHT_ANGLE_DEG=incident_light_angle.value,
+        GRATING_CONSTANT_INVERSE_MM=grating_constant.value,
+        ARM_ID=arm_id,
+        REFLECTED_LIGHT_ANGLE_DEG=reflected_light_angle.value,
+        WAVELENGTH=wavelength.value,
+    )
+    init_visp_constants_db(recipe_run_id, constants_db)
+    with WavelengthCalibration(
+        recipe_run_id=recipe_run_id,
+        workflow_name="wavelength_correction",
+        workflow_version="VX.Y",
+    ) as task:
+        try:  # This try... block is here to make sure the dbs get cleaned up if there's a failure in the fixture
+
+            # Create a realistic spectra
+            wave_vec = compute_input_wavelength_vector(
+                central_wavelength=wavelength,
+                dispersion=dispersion,
+                grating_constant=grating_constant,
+                order=order,
+                incident_light_angle=incident_light_angle,
+                num_spec_px=num_wave_pix,
+            )
+
+            # Simulate a "realistic" input spectra with errors that need to be corrected
+            solar_signal = np.interp(
+                wave_vec,
+                solar_atlas.solar_atlas_wavelength + offset_factor,
+                solar_atlas.solar_atlas_transmission,
+            )
+            telluric_signal = np.interp(
+                wave_vec,
+                solar_atlas.telluric_atlas_wavelength + offset_factor,
+                solar_atlas.telluric_atlas_transmission,
+            )
+
+            combined_spec_1d = solar_signal * telluric_signal
+            combined_spec_1d_with_error = (
+                combined_spec_1d**opacity_factor * continuum_level + straylight_fraction
+            )
+
+            sigma_wavelength = (
+                wavelength.to_value(u.nm) / resolving_power
+            ) * gaussian_fwhm_to_sigma
+            sigma_pix = sigma_wavelength / np.abs(dispersion.to_value(u.nm / u.pix))
+            spec_1d = gaussian_filter(combined_spec_1d_with_error, np.abs(sigma_pix))
+
+            spec_1d[:num_start_nans] = np.nan
+
+            spec = np.ones(char_spec_shape) * spec_1d[:, None]
+
+            task.scratch = WorkflowFileSystem(
+                scratch_base_path=tmp_path, recipe_run_id=recipe_run_id
+            )
+            params = VispInputDatasetParameterValues()
+            assign_input_dataset_doc_to_task(task, params)
+
+            # Create fake solar charcteristic spectra for one beam
+            task.write(
+                data=spec,
+                tags=[
+                    VispTag.intermediate_frame(beam=1),
+                    VispTag.task_characteristic_spectra(),
+                ],
+                encoder=fits_array_encoder,
+            )
+
+            yield task
+        except:
+            raise
+        finally:
+            task._purge()
+
+
+@pytest.mark.parametrize(
+    "num_start_nans", [pytest.param(17, id="with_nans"), pytest.param(0, id="no_nans")]
+)
+def test_wavelength_correction(
+    visp_wavelength_correction_task,
+    mocker,
+    fake_gql_client,
+    wavelength,
+    dispersion,
+    offset_factor,
+    incident_light_angle,
+    num_wave_pix,
+    num_start_nans,
+):
+    """
+    Given: A `WavelengthCalibration` task with all the data needed to run
+    When: Running the task
+    Then: The correct output files are produced and the wavelength solution is close to what's expected
+    """
+    mocker.patch(
+        "dkist_processing_common.tasks.mixin.metadata_store.GraphQLClient", new=fake_gql_client
+    )
+
+    task = visp_wavelength_correction_task
+    task()
+    tags = [
+        VispTag.task_wavelength_calibration(),
+        VispTag.intermediate(),
+    ]
+    fit_result = next(task.read(tags=tags, decoder=json_decoder))
+
+    expected_crval = wavelength - offset_factor
+
+    wavelength_solution_header_files = list(
+        task.read(tags=[VispTag.intermediate(), VispTag.task_wavelength_calibration()])
+    )
+    assert len(wavelength_solution_header_files) == 1
+    with open(wavelength_solution_header_files[0], "r") as f:
+        wavecal_header_dict = json.load(f)
+
+    # `num_wave_pix - num_start_nans` is the length of the input spectrum that the wavecal library sees
+    assert fit_result["CRPIX2"] == (num_wave_pix - num_start_nans) // 2 + 1 + num_start_nans
+    np.testing.assert_allclose(fit_result["CDELT2"], dispersion.value, rtol=1e-2)
+    np.testing.assert_allclose(
+        wavecal_header_dict["CRVAL2"], expected_crval.to_value(u.nm), rtol=1e-5
+    )
+    assert wavecal_header_dict["PV2_0"] == task.constants.grating_constant_inverse_mm.to_value(
+        1 / u.m
+    )
+    assert wavecal_header_dict["PV2_1"] == compute_order(
+        central_wavelength=wavelength,
+        incident_light_angle=incident_light_angle,
+        reflected_light_angle=task.constants.reflected_light_angle_deg,
+        grating_constant=task.constants.grating_constant_inverse_mm,
+    )
+
+    np.testing.assert_allclose(
+        wavecal_header_dict["PV2_2"], incident_light_angle.to_value(u.deg), rtol=1e-2
+    )
+
+    for primary_key in filter(lambda k: not k.endswith("A"), wavecal_header_dict.keys()):
+        assert (
+            wavecal_header_dict[primary_key] == wavecal_header_dict[f"{primary_key}A"]
+        ), f"{primary_key} does not match {primary_key}A"
+
+    quality_files = list(task.read(tags=[VispTag.quality(MetricCode.wavecal_fit)]))
+    assert len(quality_files) == 1
+    with open(quality_files[0]) as f:
+        quality_dict = json.load(f)
+        assert sorted(
+            [
+                "input_wavelength_nm",
+                "input_spectrum",
+                "best_fit_wavelength_nm",
+                "best_fit_atlas",
+                "normalized_residuals",
+                "weights",
+            ]
+        ) == sorted(list(quality_dict.keys()))

dkist_processing_visp/tests/test_write_l1.py

@@ -48,9 +48,7 @@ def write_l1_task(
         workflow_name="workflow_name",
         workflow_version="workflow_version",
     ) as task:
-
         yield task
-
         task._purge()
 
 

dkist_processing_visp/workflows/l0_processing.py

@@ -22,6 +22,7 @@ from dkist_processing_visp.tasks import VispAssembleQualityData
 from dkist_processing_visp.tasks import VispL0QualityMetrics
 from dkist_processing_visp.tasks import VispL1QualityMetrics
 from dkist_processing_visp.tasks import VispWriteL1Frame
+from dkist_processing_visp.tasks.wavelength_calibration import WavelengthCalibration
 
 l0_pipeline = Workflow(
     category="visp",
@@ -41,12 +42,14 @@ l0_pipeline.add_node(
     task=SolarCalibration,
     upstreams=[LampCalibration, GeometricCalibration, BackgroundLightCalibration],
 )
+l0_pipeline.add_node(task=WavelengthCalibration, upstreams=SolarCalibration)
 l0_pipeline.add_node(
     task=InstrumentPolarizationCalibration,
     upstreams=[BackgroundLightCalibration, GeometricCalibration],
 )
 l0_pipeline.add_node(
-    task=ScienceCalibration, upstreams=[SolarCalibration, InstrumentPolarizationCalibration]
+    task=ScienceCalibration,
+    upstreams=[SolarCalibration, InstrumentPolarizationCalibration, WavelengthCalibration],
 )
 l0_pipeline.add_node(task=VispWriteL1Frame, upstreams=ScienceCalibration)
 

dkist_processing_visp/workflows/trial_workflows.py

@@ -23,6 +23,7 @@ from dkist_processing_visp.tasks import VispAssembleQualityData
 from dkist_processing_visp.tasks import VispL0QualityMetrics
 from dkist_processing_visp.tasks import VispL1QualityMetrics
 from dkist_processing_visp.tasks import VispWriteL1Frame
+from dkist_processing_visp.tasks.wavelength_calibration import WavelengthCalibration
 
 full_trial_pipeline = Workflow(
     category="visp",
@@ -43,12 +44,14 @@ full_trial_pipeline.add_node(
     task=SolarCalibration,
     upstreams=[LampCalibration, GeometricCalibration, BackgroundLightCalibration],
 )
+full_trial_pipeline.add_node(task=WavelengthCalibration, upstreams=SolarCalibration)
 full_trial_pipeline.add_node(
     task=InstrumentPolarizationCalibration,
     upstreams=[BackgroundLightCalibration, GeometricCalibration],
 )
 full_trial_pipeline.add_node(
-    task=ScienceCalibration, upstreams=[SolarCalibration, InstrumentPolarizationCalibration]
+    task=ScienceCalibration,
+    upstreams=[SolarCalibration, InstrumentPolarizationCalibration, WavelengthCalibration],
 )
 full_trial_pipeline.add_node(task=VispWriteL1Frame, upstreams=ScienceCalibration)
 

{dkist_processing_visp-5.1.2rc2.dist-info → dkist_processing_visp-5.2.0rc1.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: dkist-processing-visp
-Version: 5.1.2rc2
+Version: 5.2.0rc1
 Summary: Science processing code for the ViSP instrument on DKIST
 Author-email: NSO / AURA <dkistdc@nso.edu>
 License: BSD-3-Clause
@@ -13,7 +13,7 @@ Classifier: Programming Language :: Python :: 3
 Classifier: Programming Language :: Python :: 3.12
 Requires-Python: >=3.12
 Description-Content-Type: text/x-rst
-Requires-Dist: dkist-processing-common==11.9.1rc2
+Requires-Dist: dkist-processing-common==11.9.1
 Requires-Dist: dkist-processing-math==2.2.1
 Requires-Dist: dkist-processing-pac==3.1.1
 Requires-Dist: dkist-header-validator==5.2.1
@@ -30,6 +30,7 @@ Requires-Dist: scikit-learn==1.6.1
 Requires-Dist: peakutils==1.3.5
 Requires-Dist: Pillow==10.4.0
 Requires-Dist: moviepy==2.1.2
+Requires-Dist: solar-wavelength-calibration==2.0.0
 Provides-Extra: test
 Requires-Dist: pytest; extra == "test"
 Requires-Dist: pytest-cov; extra == "test"
@@ -125,8 +126,8 @@ Requires-Dist: attrs==25.4.0; extra == "frozen"
 Requires-Dist: babel==2.17.0; extra == "frozen"
 Requires-Dist: billiard==4.2.4; extra == "frozen"
 Requires-Dist: blinker==1.9.0; extra == "frozen"
-Requires-Dist: boto3==1.42.5; extra == "frozen"
-Requires-Dist: botocore==1.42.5; extra == "frozen"
+Requires-Dist: boto3==1.42.8; extra == "frozen"
+Requires-Dist: botocore==1.42.8; extra == "frozen"
 Requires-Dist: cachelib==0.13.0; extra == "frozen"
 Requires-Dist: celery==5.6.0; extra == "frozen"
 Requires-Dist: certifi==2025.11.12; extra == "frozen"
@@ -149,11 +150,11 @@ Requires-Dist: dacite==1.9.2; extra == "frozen"
 Requires-Dist: decorator==5.2.1; extra == "frozen"
 Requires-Dist: dill==0.4.0; extra == "frozen"
 Requires-Dist: dkist-header-validator==5.2.1; extra == "frozen"
-Requires-Dist: dkist-processing-common==11.9.1rc2; extra == "frozen"
+Requires-Dist: dkist-processing-common==11.9.1; extra == "frozen"
 Requires-Dist: dkist-processing-core==6.0.1; extra == "frozen"
 Requires-Dist: dkist-processing-math==2.2.1; extra == "frozen"
 Requires-Dist: dkist-processing-pac==3.1.1; extra == "frozen"
-Requires-Dist: dkist-processing-visp==5.1.2rc2; extra == "frozen"
+Requires-Dist: dkist-processing-visp==5.2.0rc1; extra == "frozen"
 Requires-Dist: dkist-service-configuration==4.1.13; extra == "frozen"
 Requires-Dist: dkist-spectral-lines==3.0.0; extra == "frozen"
 Requires-Dist: dkist_fits_specifications==4.17.0; extra == "frozen"
@@ -169,7 +170,6 @@ Requires-Dist: globus-sdk==4.2.0; extra == "frozen"
 Requires-Dist: google-re2==1.1.20251105; extra == "frozen"
 Requires-Dist: googleapis-common-protos==1.72.0; extra == "frozen"
 Requires-Dist: gqlclient==1.2.3; extra == "frozen"
-Requires-Dist: greenlet==3.3.0; extra == "frozen"
 Requires-Dist: grpcio==1.76.0; extra == "frozen"
 Requires-Dist: gunicorn==23.0.0; extra == "frozen"
 Requires-Dist: h11==0.16.0; extra == "frozen"
@@ -199,7 +199,7 @@ Requires-Dist: markdown-it-py==4.0.0; extra == "frozen"
 Requires-Dist: marshmallow==3.26.1; extra == "frozen"
 Requires-Dist: marshmallow-oneofschema==3.2.0; extra == "frozen"
 Requires-Dist: marshmallow-sqlalchemy==0.28.2; extra == "frozen"
-Requires-Dist: matplotlib==3.10.7; extra == "frozen"
+Requires-Dist: matplotlib==3.10.8; extra == "frozen"
 Requires-Dist: mdit-py-plugins==0.5.0; extra == "frozen"
 Requires-Dist: mdurl==0.1.2; extra == "frozen"
 Requires-Dist: methodtools==0.4.7; extra == "frozen"
@@ -210,30 +210,30 @@ Requires-Dist: nbformat==5.10.4; extra == "frozen"
 Requires-Dist: networkx==3.6.1; extra == "frozen"
 Requires-Dist: numpy==2.2.5; extra == "frozen"
 Requires-Dist: object-clerk==1.0.0; extra == "frozen"
-Requires-Dist: opentelemetry-api==1.39.0; extra == "frozen"
-Requires-Dist: opentelemetry-exporter-otlp==1.39.0; extra == "frozen"
-Requires-Dist: opentelemetry-exporter-otlp-proto-common==1.39.0; extra == "frozen"
-Requires-Dist: opentelemetry-exporter-otlp-proto-grpc==1.39.0; extra == "frozen"
-Requires-Dist: opentelemetry-exporter-otlp-proto-http==1.39.0; extra == "frozen"
-Requires-Dist: opentelemetry-instrumentation==0.60b0; extra == "frozen"
-Requires-Dist: opentelemetry-instrumentation-aiohttp-client==0.60b0; extra == "frozen"
-Requires-Dist: opentelemetry-instrumentation-asgi==0.60b0; extra == "frozen"
-Requires-Dist: opentelemetry-instrumentation-botocore==0.60b0; extra == "frozen"
-Requires-Dist: opentelemetry-instrumentation-celery==0.60b0; extra == "frozen"
-Requires-Dist: opentelemetry-instrumentation-dbapi==0.60b0; extra == "frozen"
-Requires-Dist: opentelemetry-instrumentation-fastapi==0.60b0; extra == "frozen"
-Requires-Dist: opentelemetry-instrumentation-pika==0.60b0; extra == "frozen"
-Requires-Dist: opentelemetry-instrumentation-psycopg2==0.60b0; extra == "frozen"
-Requires-Dist: opentelemetry-instrumentation-pymongo==0.60b0; extra == "frozen"
-Requires-Dist: opentelemetry-instrumentation-redis==0.60b0; extra == "frozen"
-Requires-Dist: opentelemetry-instrumentation-requests==0.60b0; extra == "frozen"
-Requires-Dist: opentelemetry-instrumentation-sqlalchemy==0.60b0; extra == "frozen"
-Requires-Dist: opentelemetry-instrumentation-system-metrics==0.60b0; extra == "frozen"
+Requires-Dist: opentelemetry-api==1.39.1; extra == "frozen"
+Requires-Dist: opentelemetry-exporter-otlp==1.39.1; extra == "frozen"
+Requires-Dist: opentelemetry-exporter-otlp-proto-common==1.39.1; extra == "frozen"
+Requires-Dist: opentelemetry-exporter-otlp-proto-grpc==1.39.1; extra == "frozen"
+Requires-Dist: opentelemetry-exporter-otlp-proto-http==1.39.1; extra == "frozen"
+Requires-Dist: opentelemetry-instrumentation==0.60b1; extra == "frozen"
+Requires-Dist: opentelemetry-instrumentation-aiohttp-client==0.60b1; extra == "frozen"
+Requires-Dist: opentelemetry-instrumentation-asgi==0.60b1; extra == "frozen"
+Requires-Dist: opentelemetry-instrumentation-botocore==0.60b1; extra == "frozen"
+Requires-Dist: opentelemetry-instrumentation-celery==0.60b1; extra == "frozen"
+Requires-Dist: opentelemetry-instrumentation-dbapi==0.60b1; extra == "frozen"
+Requires-Dist: opentelemetry-instrumentation-fastapi==0.60b1; extra == "frozen"
+Requires-Dist: opentelemetry-instrumentation-pika==0.60b1; extra == "frozen"
+Requires-Dist: opentelemetry-instrumentation-psycopg2==0.60b1; extra == "frozen"
+Requires-Dist: opentelemetry-instrumentation-pymongo==0.60b1; extra == "frozen"
+Requires-Dist: opentelemetry-instrumentation-redis==0.60b1; extra == "frozen"
+Requires-Dist: opentelemetry-instrumentation-requests==0.60b1; extra == "frozen"
+Requires-Dist: opentelemetry-instrumentation-sqlalchemy==0.60b1; extra == "frozen"
+Requires-Dist: opentelemetry-instrumentation-system-metrics==0.60b1; extra == "frozen"
 Requires-Dist: opentelemetry-propagator-aws-xray==1.0.2; extra == "frozen"
-Requires-Dist: opentelemetry-proto==1.39.0; extra == "frozen"
-Requires-Dist: opentelemetry-sdk==1.39.0; extra == "frozen"
-Requires-Dist: opentelemetry-semantic-conventions==0.60b0; extra == "frozen"
-Requires-Dist: opentelemetry-util-http==0.60b0; extra == "frozen"
+Requires-Dist: opentelemetry-proto==1.39.1; extra == "frozen"
+Requires-Dist: opentelemetry-sdk==1.39.1; extra == "frozen"
+Requires-Dist: opentelemetry-semantic-conventions==0.60b1; extra == "frozen"
+Requires-Dist: opentelemetry-util-http==0.60b1; extra == "frozen"
 Requires-Dist: ordered-set==4.1.0; extra == "frozen"
 Requires-Dist: packaging==25.0; extra == "frozen"
 Requires-Dist: pandas==2.3.3; extra == "frozen"
@@ -293,7 +293,7 @@ Requires-Dist: termcolor==3.2.0; extra == "frozen"
 Requires-Dist: text-unidecode==1.3; extra == "frozen"
 Requires-Dist: threadpoolctl==3.6.0; extra == "frozen"
 Requires-Dist: tifffile==2025.10.16; extra == "frozen"
-Requires-Dist: tornado==6.5.2; extra == "frozen"
+Requires-Dist: tornado==6.5.3; extra == "frozen"
 Requires-Dist: tqdm==4.67.1; extra == "frozen"
 Requires-Dist: traitlets==5.14.3; extra == "frozen"
 Requires-Dist: typing-inspection==0.4.2; extra == "frozen"
@@ -303,7 +303,7 @@ Requires-Dist: tzlocal==5.3.1; extra == "frozen"
 Requires-Dist: uc-micro-py==1.0.3; extra == "frozen"
 Requires-Dist: uncertainties==3.2.3; extra == "frozen"
 Requires-Dist: universal_pathlib==0.3.7; extra == "frozen"
-Requires-Dist: urllib3==2.6.1; extra == "frozen"
+Requires-Dist: urllib3==2.6.2; extra == "frozen"
 Requires-Dist: vine==5.1.0; extra == "frozen"
 Requires-Dist: voluptuous==0.15.2; extra == "frozen"
 Requires-Dist: wcwidth==0.2.14; extra == "frozen"

{dkist_processing_visp-5.1.2rc2.dist-info → dkist_processing_visp-5.2.0rc1.dist-info}/RECORD

@@ -1,5 +1,9 @@
 changelog/.gitempty,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-changelog/251.feature.rst,sha256=WgNcGXrBibEDR5mWraG5OXDx9o63aDqY5qzYHrJzSko,125
+changelog/234.bugfix.rst,sha256=Our6to0s222qmuFeRSUEP2lqqidIkJkmsGjekWWr3oU,171
+changelog/234.doc.rst,sha256=aZLFLpEb6zlmFFiSKuoe2RrbS-7jwLt4aSE3Rw2lN4s,66
+changelog/234.feature.rst,sha256=fsavvoebhLLVbMopyVl-byq6HRKTQ8FAHSsidP6pieU,114
+changelog/234.science.rst,sha256=qB0ul0avWEbGfHaqAZxTkVVi3G-OIQlrQxKnNokwgWA,139
+changelog/253.misc.rst,sha256=Iozax0yAtER5ey6nm2I50b_TY0m4WUHTeRqk6Mss0dM,114
 dkist_processing_visp/__init__.py,sha256=LC8o31oTIro4F7IgwoWalX1W3KcPU27yJhlDUeGqcwA,351
 dkist_processing_visp/config.py,sha256=GMr0CreW4qavbueTtsH_Gx5P52v4yZd2PNKyPmxBKQE,478
 dkist_processing_visp/fonts/Lato-Regular.ttf,sha256=1jbkaDIx-THtoiLViOlE0IK_0726AvkovuRhwPGFslE,656568
@@ -7,9 +11,9 @@ dkist_processing_visp/models/__init__.py,sha256=z2nFVvvIzirxklQ9i5-F1nR-WOgcDttY
 dkist_processing_visp/models/constants.py,sha256=TP9ZefMdJxu-JWePICMZ6riC4bH1Mz4NJY0hAcWAPQ0,6749
 dkist_processing_visp/models/fits_access.py,sha256=8uKaUgtapyED-WgJCeswrIqEGy4Ob6ekBmiyBqF6yIE,573
 dkist_processing_visp/models/metric_code.py,sha256=L_VJ-l5RXsYgcEIOO6hsez1a5oL5FqTnoVKZ0z7NKng,266
-dkist_processing_visp/models/parameters.py,sha256=ynPzU9Clv15tuI_h7OFH4bgngeGP-WJ0I3814lnaKMw,15070
-dkist_processing_visp/models/tags.py,sha256=RKtDlNA9O3LMinUP7BJ3tXWn6CWAARaKhXIVB1EHtg0,3055
-dkist_processing_visp/models/task_name.py,sha256=ykLXcmCBWYguopdBlg_G0X_u-0o_Ugh2117XrCqdbFk,187
+dkist_processing_visp/models/parameters.py,sha256=kiYzvXjsQo1EFEGHJUdeYj170tq_CeVqrrtD01E1fmQ,16967
+dkist_processing_visp/models/tags.py,sha256=Pdc-E2wNlaqRzAJgQF_KHUe_xzqDrUfp1IB0mpgRNN4,3514
+dkist_processing_visp/models/task_name.py,sha256=6iZ5j8_beOI8DMoEemxG3dra63a93q0vbjcypb_H9wE,281
 dkist_processing_visp/parsers/__init__.py,sha256=z2nFVvvIzirxklQ9i5-F1nR-WOgcDttYtog_jx4yN5I,12
 dkist_processing_visp/parsers/map_repeats.py,sha256=YuO1VROQLuE-Hn9hSzityjNhIDe-EgQ4kjZV6l9xF2Q,5468
 dkist_processing_visp/parsers/modulator_states.py,sha256=dHAZZaG3i_UUT5FjTg1oJdCBiOKCqkrx1jiQnzp2t2o,3006
@@ -23,25 +27,26 @@ dkist_processing_visp/tasks/__init__.py,sha256=qlPlahiM9_sCsaIj_wzQpzWkMITJ1dPdT
 dkist_processing_visp/tasks/assemble_movie.py,sha256=8UujniXlV_sSGeuISud8wMHihLy6Gc5fKZpwkXLUQB8,3330
 dkist_processing_visp/tasks/background_light.py,sha256=qQ3r1LR5qaOz2qNHnO5_QK8l1zbVP0GaCS3aLqJfNYY,16201
 dkist_processing_visp/tasks/dark.py,sha256=VVitrat08U7e5L1-NVnNNJI_KIx791_DvKEJokvCqXE,4334
-dkist_processing_visp/tasks/geometric.py,sha256=FL9LVnI9XvAQeDFXnD1nwj67ExosuZjBSW2M3CrlCB4,48893
+dkist_processing_visp/tasks/geometric.py,sha256=n2Wiy7QovA8V0gkORnQ9LX8lgb-amqE-M_mKr1u4HNY,48934
 dkist_processing_visp/tasks/instrument_polarization.py,sha256=uj7iyzM3CiJcbQeF4eKpk_KCoheXaM4FpDI83GYDld4,25854
 dkist_processing_visp/tasks/l1_output_data.py,sha256=vl_c52noozeu4N-BbfpsIHFc5q6JATQ9r4iLa3MDtDI,8347
 dkist_processing_visp/tasks/lamp.py,sha256=HTBob-4Am1ps5ucmX8nSzxV3BqX2ytMcHZ5iyDrljq0,5132
 dkist_processing_visp/tasks/make_movie_frames.py,sha256=fw25ksKiJJNS57XV5a7rHpYGcSkYxS2Qf13Fb1UGNpE,7544
 dkist_processing_visp/tasks/parse.py,sha256=Fe_2svvMSKBup--Ulxbu0uaNW3dzPxQreafMEw0CY6E,7897
 dkist_processing_visp/tasks/quality_metrics.py,sha256=Pw55-PXW0cl39FuNkEQCGGhvI_zMDimwmh-swVPVBD4,8133
-dkist_processing_visp/tasks/science.py,sha256=eQZ5MDJhOD8hhp2huksOkl8Btm8EL15no-LX3o6zBXE,34550
-dkist_processing_visp/tasks/solar.py,sha256=YJFHmpmdV-FSIrjFKMH3eLXZ8KTdZWcZo-_XFf-u9Gs,47624
+dkist_processing_visp/tasks/science.py,sha256=fm-LLWxmLEjea0a8fhmN3x1v3n1Od4BJ3BioyjPuih8,38318
+dkist_processing_visp/tasks/solar.py,sha256=-OnpKKkUG0EwYK8S4QsMD5UWU6cIHc837nEDc_3OLl4,41156
 dkist_processing_visp/tasks/visp_base.py,sha256=-yC-PVP9AqFeZJshJ_nqZpSyRsZyHWUlugWvkeWkPKA,1412
-dkist_processing_visp/tasks/write_l1.py,sha256=bsDZ0BwoqpTtS_f_rAzUn7Ra8UvYb-kINQhX6BwwFQw,8796
+dkist_processing_visp/tasks/wavelength_calibration.py,sha256=N-pYBRL6Iyb_Q8VrZBQXBWvVBty3LrdhyDVxgxk3n9g,17039
+dkist_processing_visp/tasks/write_l1.py,sha256=UbugV6ilmeYdq-bC9WUiJxkFjn9VzJIkZXtoA7cs71k,8798
 dkist_processing_visp/tasks/mixin/__init__.py,sha256=z2nFVvvIzirxklQ9i5-F1nR-WOgcDttYtog_jx4yN5I,12
 dkist_processing_visp/tasks/mixin/beam_access.py,sha256=1VSJkH6yMxCiZWdWOp_RJ37fX5ULMYmB_0_ulT7YJpI,870
 dkist_processing_visp/tasks/mixin/corrections.py,sha256=FhLFgD9ZYLZd3SaC3PFF-szrcs-zmdrUYNDUEK-h7JA,7145
 dkist_processing_visp/tasks/mixin/downsample.py,sha256=SvKzY6HJRn-FeyG7O6HPvyOS5dmMu6uPoWkfnpPXpVw,1344
 dkist_processing_visp/tests/README.rst,sha256=rnedwwg25c0lB9Me7cT7QNZA17FYlqCu9ZnjQxR5hi0,12502
 dkist_processing_visp/tests/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-dkist_processing_visp/tests/conftest.py,sha256=h5K8OyKFKmV6emjDywrS_ZTeWburIyBnZw_3L8uJmnY,18652
-dkist_processing_visp/tests/header_models.py,sha256=80IZgVsEoGbWOG8kvh7BjC2gHqZq9QSEDcjcmW5B4gA,21126
+dkist_processing_visp/tests/conftest.py,sha256=poJPxGK8RZlDYEoGkwaIyX08WDgf2aF566uJJbZsldk,19049
+dkist_processing_visp/tests/header_models.py,sha256=gD1FUo5TtY_EMSnpWvkrJIOsckkgRAD-e1mthPCdiOw,21687
 dkist_processing_visp/tests/test_assemble_movie.py,sha256=T5EZzdB3sNY4HcSkN2W1ZBDaI4a68ZUNqPB-JpANSQ0,2247
 dkist_processing_visp/tests/test_assemble_quality.py,sha256=i2INzb73BM14A6VKD70eb5vaAv5_QjPy3VVVb4lonkc,4314
 dkist_processing_visp/tests/test_background_light.py,sha256=Zvm8s38qx_ybviEhnKqPI4s36VFBJKtsNrp31-o8lEQ,17553
@@ -53,32 +58,33 @@ dkist_processing_visp/tests/test_instrument_polarization.py,sha256=ZsYSyXUKfs0dv
 dkist_processing_visp/tests/test_lamp.py,sha256=19mRN8drAg0tqQGwSbSUDlpryqYjMvmfv1DCsttxuXk,5124
 dkist_processing_visp/tests/test_make_movie_frames.py,sha256=huQ5n0YneHByKumM_Ye9tekqKeh-F-e6MQoudOP3S-g,2628
 dkist_processing_visp/tests/test_map_repeats.py,sha256=9g3NnvSfn1OqxxYYxTFoOIi1UsCOa6mZjiuGkbxUvTg,7611
-dkist_processing_visp/tests/test_parameters.py,sha256=MBSddKsFmRC4zDZEgpA3y3_sRKriETiPEIhcVoSchTo,8053
+dkist_processing_visp/tests/test_parameters.py,sha256=kIwOak4PURFc6yNT9R1rLxfb4x5FbqSlfi3FF-krrGo,8314
 dkist_processing_visp/tests/test_parse.py,sha256=XyH8oCk5C0CWl4ndNIyVjgXLoMg0679s4dj1MGlJs0c,23363
 dkist_processing_visp/tests/test_quality.py,sha256=YW24VjEHoILseFIXZBp4-o7egT26mfT1lafzajVjXu8,6905
-dkist_processing_visp/tests/test_science.py,sha256=KpOYvL86xhSnTCOcVDveE-enDxcj_G4IrUw_wa375tI,23893
-dkist_processing_visp/tests/test_solar.py,sha256=xuKeUrnAeTQoWbL6pUTiRr09jw0O4jYL6-MSCmyF_k4,16789
+dkist_processing_visp/tests/test_science.py,sha256=B8bbtVTxJIXiPssIbJchPLbzVTPCAzpLAgn5DhpYCn0,26106
+dkist_processing_visp/tests/test_solar.py,sha256=xtw8cbunonOG_6dRJHF9GIiQ5Q-KTBCdo1FZWkiA7_c,16761
 dkist_processing_visp/tests/test_trial_create_quality_report.py,sha256=5LSvLiInp_ce_jObtBGNHQgVAkvJr9bYgY7IzIKrEuU,2799
 dkist_processing_visp/tests/test_visp_constants.py,sha256=y2x42Y-dK2lrCPufLAV1KHpu2fQ-FRpe8tSIhfHJEw8,3134
+dkist_processing_visp/tests/test_wavelength_calibration.py,sha256=usOCDd4yjmigpCjc5enQn14JJKojm8laxVJVDtV5PuU,9550
 dkist_processing_visp/tests/test_workflows.py,sha256=qyWxagIDv-MmVN0u3KFswa5HdaHC6uGeJpvgxvPE30E,287
-dkist_processing_visp/tests/test_write_l1.py,sha256=ORNKUvF4RPjXc24HgOzyVsP0BCQ9izi54EqXpjLzHXQ,6574
+dkist_processing_visp/tests/test_write_l1.py,sha256=ZrAWhfx_HZi7dOBRc5YowvkKtMS8TBE_iud_KPjFI8g,6572
 dkist_processing_visp/tests/local_trial_workflows/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
-dkist_processing_visp/tests/local_trial_workflows/l0_cals_only.py,sha256=1TmvdAn80WKW-2DsuSg9iK6yQ3Urwm9yt5HlVv1dGWE,10649
-dkist_processing_visp/tests/local_trial_workflows/l0_polcals_as_science.py,sha256=geU6Q8ULfIq4Jmj6ORq8mgXYlF8SYrvgZP-0u-4Uz24,17567
-dkist_processing_visp/tests/local_trial_workflows/l0_solar_gain_as_science.py,sha256=cRrLklazesLBHPPbGzVjBXbEQKaCxQfgy1_AgWyZRyo,15820
-dkist_processing_visp/tests/local_trial_workflows/l0_to_l1.py,sha256=cwEdvUGqqSpp4htrxlmyRN2sZBBvVOjomd66DEqTmTA,15191
-dkist_processing_visp/tests/local_trial_workflows/local_trial_helpers.py,sha256=UYGDwvCqzyCzyp44T-vys_JdKuMVRVS7bpWG9gvwnSE,28250
+dkist_processing_visp/tests/local_trial_workflows/l0_cals_only.py,sha256=iqwT8QDA4dvGzBkhs-UXXzMTZtxsa794EOzl1vgGNXA,11559
+dkist_processing_visp/tests/local_trial_workflows/l0_polcals_as_science.py,sha256=SJZp24OZvXnx-t0DNDkNWEvLInZKormWMilbDUOMcKg,18477
+dkist_processing_visp/tests/local_trial_workflows/l0_solar_gain_as_science.py,sha256=bU2kz3n6RdDDAIDXVtiitnAwpLAL60kOuN4HGI6OP3k,16729
+dkist_processing_visp/tests/local_trial_workflows/l0_to_l1.py,sha256=q_rS8PVm6pA5EjayBhj2SfGSRnpsd_jY2IlIfiVpPC4,16101
+dkist_processing_visp/tests/local_trial_workflows/local_trial_helpers.py,sha256=R7NZNEv0VQwwZoBwPa6RYY94_VBnM4JQJ1AQdQaCrGQ,29078
 dkist_processing_visp/workflows/__init__.py,sha256=1-GP9tOzjCxLJtyq0ry_x4dPdArfSso8Hxu65ydPpXQ,103
-dkist_processing_visp/workflows/l0_processing.py,sha256=Af4pDYwuWqXGqapCsOwWhDKrjsu4Pdn4II0YYe_pUL4,3339
+dkist_processing_visp/workflows/l0_processing.py,sha256=XW7tbQLlH06ecEZ3QAt982gK9T_y3eN2U9KtUUq1R_0,3529
 dkist_processing_visp/workflows/single_task_workflows.py,sha256=LK4dsshM0-lwy79WaMoTplyCxUyINnP9RU74MG_dhyc,33
-dkist_processing_visp/workflows/trial_workflows.py,sha256=l3WY9NDqRMCxgadIFRD1UTV99EpA7sD_NXApFXJ2UNY,3824
+dkist_processing_visp/workflows/trial_workflows.py,sha256=IYdjVVZ6mCKGMQiy-_cqKLptHws3WzxrPZLjFccaZr0,4022
 docs/Makefile,sha256=qnlVz6PuBqE39NfHWuUnHhNEA-EFgT2-WJNNNy9ttfk,4598
 docs/background_light.rst,sha256=FWj8KH7H51BtoqPCJ1A_VIWJkjaXD8-dwM9RdY1rkIc,5147
 docs/changelog.rst,sha256=ZpZPJIyl4nI0Eicku6uSrLdiinNOF2GcZwrvTEsb-Zs,346
 docs/conf.py,sha256=qgWzWK98wj5QHHnNW52fzjCyfibFM_g1DkjB8m2WMAk,2151
-docs/gain_correction.rst,sha256=rQA51C2ZwUAk1lwCbSUpjs1SjhE2HpT-ik1C5UO9XrU,7148
+docs/gain_correction.rst,sha256=zC2nnSoch5sdAF3C16eQ8BgUi2J6d_dt7JBRLKfst-w,7176
 docs/geometric.rst,sha256=VsAWefgJ1j64Uo1TQ-ltAQ6INgsdS7-_FSvOtm0i17s,7301
-docs/index.rst,sha256=pl8VhwISd-kb1IQi2h7gOySfOhQQl2C71pjTatShGNI,319
+docs/index.rst,sha256=At3fL3E9lLaoY7wBGtEJra5HTUYCAo6wcdzQJBzmTNs,346
 docs/l0_to_l1_visp.rst,sha256=wE1TT7DD93r3kByaFAaT2HO907pjV4YrJ_fzvJFTchw,623
 docs/l0_to_l1_visp_full-trial.rst,sha256=Y6YLkRA5b0tgui5l_WdthCx2wrXjLD8U97XKZHXVVBk,558
 docs/landing_page.rst,sha256=tdxWtmGjO7OUPYvRjgBAI461nubEE61HrtBwPdBeawI,1052
@@ -88,8 +94,9 @@ docs/requirements.txt,sha256=Kbl_X4c7RQZw035YTeNB63We6I7pvXFU4T0Uflp2yDY,29
 docs/requirements_table.rst,sha256=_HIbwFpDooM5n0JjiDAbFozGfJuX13smtcoujLFN4Gk,292
 docs/science_calibration.rst,sha256=VN_g7xSjN-nbXhlBaFnPCbNcsc_Qu0207jEUfRAjnBE,2939
 docs/scientific_changelog.rst,sha256=01AWBSHg8zElnodCgAq-hMxhk9CkX5rtEENx4iz0sjI,300
+docs/wavelength_calibration.rst,sha256=OSGYAeR8Acns2ZUectHzRj2xcAsuNEMLejcYfPYu-vw,3674
 licenses/LICENSE.rst,sha256=piZaQplkzOMmH1NXg6QIdo9wwo9pPCoHkvm2-DmH76E,1462
-dkist_processing_visp-5.1.2rc2.dist-info/METADATA,sha256=iNUcMX9Czyn4qzmNC0lRqB7GFvh-A_yFjXGyq1A_xBM,29981
-dkist_processing_visp-5.1.2rc2.dist-info/WHEEL,sha256=_zCd3N1l69ArxyTb8rzEoP9TpbYXkqRFSNOD5OuxnTs,91
-dkist_processing_visp-5.1.2rc2.dist-info/top_level.txt,sha256=9GHSn-ZMGQxaRNGrPP3HNc5ZkE7ftzluO74Jz5vUSTE,46
-dkist_processing_visp-5.1.2rc2.dist-info/RECORD,,
+dkist_processing_visp-5.2.0rc1.dist-info/METADATA,sha256=-y76Qbu7VZMF58aOpfdlAY-86o0lWeqmiyITzrgYctg,29976
+dkist_processing_visp-5.2.0rc1.dist-info/WHEEL,sha256=_zCd3N1l69ArxyTb8rzEoP9TpbYXkqRFSNOD5OuxnTs,91
+dkist_processing_visp-5.2.0rc1.dist-info/top_level.txt,sha256=9GHSn-ZMGQxaRNGrPP3HNc5ZkE7ftzluO74Jz5vUSTE,46
+dkist_processing_visp-5.2.0rc1.dist-info/RECORD,,

docs/gain_correction.rst

@@ -83,6 +83,9 @@ vignette signal varies with spatial and spectral position across the chip. We fi
 to compute a fully 2D estimate of the true vignette signal. The order of this polynomial fit is set by the
 ``solar_vignette_spectral_poly_fit_order`` parameter.
 
+
+.. _charspec-description:
+
 Compute Characteristic Spectra
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 

docs/index.rst

@@ -11,6 +11,7 @@
     background_light
     geometric
     gain_correction
+    wavelength_calibration
     polarization_calibration
     science_calibration
     autoapi/index