dkist-processing-common 11.2.1rc3__py3-none-any.whl → 11.3.1rc1__py3-none-any.whl

dkist_processing_common/tasks/write_l1.py

@@ -1,4 +1,5 @@
 """Task(s) for writing level 1 data as 214 compliant fits files."""
+
 import importlib
 import logging
 import uuid
@@ -213,11 +214,6 @@ class WriteL1Frame(WorkflowTaskBase, MetadataStoreMixin, ABC):
         header["OBS_HDU"] = 1
         header["FILENAME"] = self.l1_filename(header=header, stokes=stokes)
         header["STOKES"] = stokes
-        # Cadence keywords
-        header["CADENCE"] = self.constants.average_cadence
-        header["CADMIN"] = self.constants.minimum_cadence
-        header["CADMAX"] = self.constants.maximum_cadence
-        header["CADVAR"] = self.constants.variance_cadence
         # Keywords to support reprocessing
         if parameters := self.metadata_store_input_dataset_parameters:
             header["IDSPARID"] = parameters.inputDatasetPartId
@@ -232,6 +228,19 @@ class WriteL1Frame(WorkflowTaskBase, MetadataStoreMixin, ABC):
         header["PRODUCT"] = self.compute_product_id(header["IDSOBSID"], header["PROCTYPE"])
         return header
 
+    def add_timing_headers(self, header: fits.Header) -> fits.Header:
+        """
+        Add timing headers to the FITS header.
+
+        This method adds or updates headers related to frame timings.
+        """
+        # Cadence keywords
+        header["CADENCE"] = self.constants.average_cadence
+        header["CADMIN"] = self.constants.minimum_cadence
+        header["CADMAX"] = self.constants.maximum_cadence
+        header["CADVAR"] = self.constants.variance_cadence
+        return header
+
     def add_spectral_line_headers(
         self,
         header: fits.Header,
@@ -370,6 +379,8 @@ class WriteL1Frame(WorkflowTaskBase, MetadataStoreMixin, ABC):
         header = self.add_doc_headers(header=header)
         # Add the dataset headers (abstract - implement in instrument task)
         header = self.add_dataset_headers(header=header, stokes=stokes_param)
+        # Add the timing headers
+        header = self.add_timing_headers(header=header)
         # Add the spectral line headers
         header = self.add_spectral_line_headers(header=header)
         # Remove any headers not contained in spec 214
@@ -414,9 +425,9 @@ class WriteL1Frame(WorkflowTaskBase, MetadataStoreMixin, ABC):
         inst_name = self.constants.instrument.lower()
         calvers = self.version_from_module_name()
         header["CALVERS"] = calvers
-        header[
-            "CAL_URL"
-        ] = f"{self.docs_base_url}/projects/{inst_name}/en/v{calvers}/{self.workflow_name}.html"
+        header["CAL_URL"] = (
+            f"{self.docs_base_url}/projects/{inst_name}/en/v{calvers}/{self.workflow_name}.html"
+        )
         return header
 
     def version_from_module_name(self) -> str:

dkist_processing_common/tests/conftest.py

@@ -1,6 +1,7 @@
 """
 Global test fixtures
 """
+
 import json
 from collections import defaultdict
 from copy import deepcopy

dkist_processing_common/tests/mock_metadata_store.py

@@ -1,6 +1,7 @@
 """
 Support functions and constants for customized FakeGQLClient
 """
+
 import json
 from abc import ABC
 from abc import abstractmethod
@@ -22,7 +23,6 @@ from dkist_processing_common.models.graphql import RecipeRunProvenanceResponse
 from dkist_processing_common.models.graphql import RecipeRunResponse
 from dkist_processing_common.models.graphql import RecipeRunStatusResponse
 
-
 TILE_SIZE = 64
 
 default_observe_frames_doc = [
@@ -223,8 +223,7 @@ def fake_gql_client_factory(response_mapping_override: ResponseMapping | None =
             raise ValueError(f"Mocked response not found for {query_base=}, {query_response_cls=}")
 
         @staticmethod
-        def execute_gql_mutation(**kwargs):
-            ...
+        def execute_gql_mutation(**kwargs): ...
 
     return FakeGQLClientClass
 

dkist_processing_common/tests/test_assemble_movie.py

@@ -60,7 +60,6 @@ def assemble_task_with_tagged_movie_frames(
         task.constants._update(
             {
                 BudName.num_dsps_repeats.value: num_dsps_repeats,
-                BudName.recipe_run_id.value: recipe_run_id,
             }
         )
         for d in range(num_dsps_repeats):

dkist_processing_common/tests/test_codecs.py

@@ -20,8 +20,8 @@ from astropy.io.fits import HDUList
 from astropy.io.fits import Header
 from astropy.io.fits import PrimaryHDU
 from pydantic import BaseModel
-from pydantic import create_model
 from pydantic import Field
+from pydantic import create_model
 
 from dkist_processing_common.codecs.asdf import asdf_decoder
 from dkist_processing_common.codecs.asdf import asdf_encoder
@@ -39,10 +39,10 @@ from dkist_processing_common.codecs.iobase import iobase_decoder
 from dkist_processing_common.codecs.iobase import iobase_encoder
 from dkist_processing_common.codecs.json import json_decoder
 from dkist_processing_common.codecs.json import json_encoder
+from dkist_processing_common.codecs.quality import QualityDataEncoder
 from dkist_processing_common.codecs.quality import quality_data_decoder
 from dkist_processing_common.codecs.quality import quality_data_encoder
 from dkist_processing_common.codecs.quality import quality_data_hook
-from dkist_processing_common.codecs.quality import QualityDataEncoder
 from dkist_processing_common.codecs.str import str_decoder
 from dkist_processing_common.codecs.str import str_encoder
 from dkist_processing_common.models.fits_access import FitsAccessBase

dkist_processing_common/tests/test_constants.py

@@ -40,6 +40,21 @@ class ConstantsFinal(ConstantsBase):
         return self._db_dict["KEY 1"] ** 2  # Just to show that you can do whatever you want
 
 
+def test_bud_names_in_constant_base():
+    """
+    Given: a set of constants in the BudNames sting enumeration
+    When: ConstantBase class defines a set of properties
+    Then: the sets are the same (except for constants that are not in the redis database)
+    """
+    all_bud_names = {b.name for b in BudName}
+    all_properties_in_constants_base = {
+        k for k, v in ConstantsBase.__dict__.items() if isinstance(v, property)
+    }
+    constants_not_in_redis = {"dataset_id", "stokes_params"}
+    all_buds_defined_in_constant_base = all_properties_in_constants_base - constants_not_in_redis
+    assert all_bud_names == all_buds_defined_in_constant_base
+
+
 def test_constants_db_as_dict(test_constants_db, test_dict):
     """
     Given: a ConstantsDb object and a python dictionary

dkist_processing_common/tests/test_fits_access.py

@@ -1,8 +1,12 @@
+from enum import StrEnum
+
 import numpy as np
 import pytest
 from astropy.io import fits
 
+from dkist_processing_common.models.fits_access import NOT_FOUND_MESSAGE
 from dkist_processing_common.models.fits_access import FitsAccessBase
+from dkist_processing_common.models.fits_access import MetadataKey
 from dkist_processing_common.parsers.l0_fits_access import L0FitsAccess
 from dkist_processing_common.parsers.l1_fits_access import L1FitsAccess
 
@@ -93,17 +97,32 @@ def hdu_with_no_data(complete_common_header):
 
 
 @pytest.fixture()
-def hdu_with_incomplete_common_header(tmp_path):
+def hdu_with_incomplete_common_header(complete_common_header):
     """
     An HDU with data and a header missing one of the expected common by-frame keywords
     """
+    incomplete_header = complete_common_header
+    incomplete_header.pop("ELEV_ANG")
+    incomplete_header.pop("TAZIMUTH")
     data = np.arange(9).reshape(3, 3)
-    hdu = fits.PrimaryHDU(data)
-    hdu.header["TELEVATN"] = 6.28
-    hdu.header["TAZIMUTH"] = 3.14
+    hdu = fits.PrimaryHDU(data, header=incomplete_header)
     return hdu
 
 
+class MetadataKeyWithOptionalKeys(StrEnum):
+    optional1 = "ELEV_ANG"
+    optional2 = "TAZIMUTH"
+
+
+class FitsAccessWithOptionalKeys(FitsAccessBase):
+    def __init__(self, hdu, name):
+        super().__init__(hdu, name)
+        self._set_metadata_key_value(MetadataKeyWithOptionalKeys.optional1, optional=True)
+        self._set_metadata_key_value(
+            MetadataKeyWithOptionalKeys.optional2, optional=True, default="SO_RAD"
+        )
+
+
 @pytest.fixture()
 def fits_file_path(tmp_path, complete_common_header):
     file_path = tmp_path / "foo.fits"
@@ -127,12 +146,37 @@ def fits_file_path_with_data_in_imagehdu(tmp_path, complete_common_header):
     return file_path
 
 
+class MetadataKeyWithNaxisKeys(StrEnum):
+    naxis = "NAXIS"
+    naxis1 = "NAXIS1"
+    naxis2 = "NAXIS2"
+
+
 class FitsAccessWithNaxisKeys(FitsAccessBase):
     def __init__(self, hdu, name):
         super().__init__(hdu, name)
-        self.naxis = self.header["NAXIS"]
-        self.naxis1 = self.header["NAXIS1"]
-        self.naxis2 = self.header["NAXIS2"]
+        self._set_metadata_key_value(MetadataKeyWithNaxisKeys.naxis)
+        self._set_metadata_key_value(MetadataKeyWithNaxisKeys.naxis1)
+        self._set_metadata_key_value(MetadataKeyWithNaxisKeys.naxis2)
+
+
+def test_metadata_keys_in_access_bases(hdu_with_no_data):
+    """
+    Given: a set of metadata key names in the MetadataKey sting enumeration
+    When: the FITS access classes define a set of attributes/properties
+    Then: the sets are the same
+    """
+    all_metadata_key_names = {mk.name for mk in MetadataKey}
+    hdu = hdu_with_no_data
+    l1_properties = {k for k, v in L1FitsAccess.__dict__.items() if isinstance(v, property)}
+    l0_properties = {k for k, v in L0FitsAccess.__dict__.items() if isinstance(v, property)}
+    all_fits_access_properties = l1_properties | l0_properties
+    l1_dict_keys = {k for k, v in L1FitsAccess(hdu=hdu).__dict__.items()}
+    l0_dict_keys = {k for k, v in L0FitsAccess(hdu=hdu).__dict__.items()}
+    all_fits_access_dict_keys = l1_dict_keys | l0_dict_keys
+    instance_dict_keys = {"_hdu", "name", "auto_squeeze"}
+    keys_defined_in_fits_access = all_fits_access_dict_keys | all_fits_access_properties
+    assert all_metadata_key_names == keys_defined_in_fits_access - instance_dict_keys
 
 
 def test_from_single_hdu(hdu_with_complete_common_header):
@@ -211,6 +255,17 @@ def test_no_header_value(hdu_with_incomplete_common_header):
         _ = L0FitsAccess(hdu_with_incomplete_common_header)
 
 
+def test_default_header_values(hdu_with_incomplete_common_header):
+    """
+    Given: an HDU with a header with missing common by-frame keywords
+    When: processing the HDU with a FITS access class that sets these keywords as optional
+    Then: the correct default values are set
+    """
+    fits_obj = FitsAccessWithOptionalKeys(hdu_with_incomplete_common_header, name="foo")
+    assert fits_obj.optional1 == MetadataKeyWithOptionalKeys.optional1 + NOT_FOUND_MESSAGE
+    assert fits_obj.optional2 == "SO_RAD"
+
+
 def test_as_subclass(hdu_with_complete_common_header):
     """
     Given: an instrument-specific fits_obj class that subclasses L0FitsAccess

dkist_processing_common/tests/test_interservice_bus.py

@@ -1,4 +1,5 @@
 """Tests for the interservice bus mixin for a WorkflowDataTaskBase subclass"""
+
 from typing import Type
 from uuid import uuid4
 

dkist_processing_common/tests/test_interservice_bus_mixin.py

@@ -1,4 +1,5 @@
 """Tests for the interservice bus mixin for a WorkflowDataTaskBase subclass"""
+
 import logging
 from typing import Dict
 from typing import Type

dkist_processing_common/tests/test_manual_processing.py

@@ -7,8 +7,7 @@ from dkist_processing_common.tasks import WorkflowTaskBase
 class ProvenanceTask(WorkflowTaskBase):
     record_provenance = True
 
-    def run(self):
-        ...
+    def run(self): ...
 
 
 @pytest.fixture(scope="function")

dkist_processing_common/tests/test_output_data_base.py

@@ -10,8 +10,7 @@ from dkist_processing_common.tasks.output_data_base import TransferDataBase
 
 
 class OutputDataBaseTask(OutputDataBase):
-    def run(self) -> None:
-        ...
+    def run(self) -> None: ...
 
 
 @pytest.fixture

dkist_processing_common/tests/test_parameters.py

@@ -7,6 +7,7 @@ HOW TO WRITE TESTS FOR NEW PARAMETER SUBCLASSES :
 4. Add a `pytest.param` with this helper function to `test_parameters` to make sure none of the default stuff broke
 5. Write a new test that only uses the helper function to test the new functionality.
 """
+
 import json
 from datetime import datetime
 from datetime import timedelta
@@ -27,7 +28,6 @@ from dkist_processing_common.models.tags import Tag
 from dkist_processing_common.tasks import WorkflowTaskBase
 from dkist_processing_common.tests.test_input_dataset import input_dataset_frames_part_factory
 
-
 FITS_FILE = "fits.dat"
 NP_FILE = "np.npy"
 

dkist_processing_common/tests/test_parse_l0_input_data.py

@@ -1,4 +1,7 @@
 """Tests for the parse L0 input data task"""
+
+from enum import StrEnum
+
 import numpy as np
 import pytest
 from astropy.io import fits
@@ -19,6 +22,7 @@ from dkist_processing_common.parsers.single_value_single_key_flower import (
 )
 from dkist_processing_common.parsers.unique_bud import UniqueBud
 from dkist_processing_common.tasks.parse_l0_input_data import ParseL0InputDataBase
+from dkist_processing_common.tasks.parse_l0_input_data import default_constant_bud_factory
 
 
 class VispHeaders(Spec122Dataset):
@@ -84,25 +88,33 @@ class VispHeaders(Spec122Dataset):
         return self.index % self.num_mod
 
 
+class ViSPMetadataKey(StrEnum):
+    num_mod = "VISP_010"
+    modstate = "VISP_011"
+    ip_task_type = "DKIST004"
+
+
 class ViSPFitsAccess(FitsAccessBase):
     def __init__(self, hdu, name, auto_squeeze=False):
         super().__init__(hdu, name, auto_squeeze=auto_squeeze)
-        self.num_mod: int = self.header["VISP_010"]
-        self.modstate: int = self.header["VISP_011"]
-        self.ip_task_type: str = self.header["DKIST004"]
+        self._set_metadata_key_value(ViSPMetadataKey.num_mod)
+        self._set_metadata_key_value(ViSPMetadataKey.modstate)
+        self._set_metadata_key_value(ViSPMetadataKey.ip_task_type)
         self.name = name
 
 
 @pytest.fixture(scope="function")
 def visp_flowers():
     return [
-        SingleValueSingleKeyFlower(tag_stem_name=StemName.modstate.value, metadata_key="modstate")
+        SingleValueSingleKeyFlower(
+            tag_stem_name=StemName.modstate, metadata_key=ViSPMetadataKey.modstate
+        )
     ]
 
 
 @pytest.fixture(scope="function")
 def visp_buds():
-    return [UniqueBud(constant_name=BudName.num_modstates.value, metadata_key="num_mod")]
+    return [UniqueBud(constant_name=BudName.num_modstates, metadata_key=ViSPMetadataKey.num_mod)]
 
 
 @pytest.fixture(scope="function")
@@ -232,9 +244,9 @@ def test_make_flowerpots(parse_inputs_task):
 
     assert len(tag_pot.stems) == 2
     assert len(constant_pot.stems) == 3
-    assert tag_pot.stems[0].stem_name == StemName.modstate.value
+    assert tag_pot.stems[0].stem_name == StemName.modstate
     assert tag_pot.stems[1].stem_name == "EMPTY_FLOWER"
-    assert constant_pot.stems[0].stem_name == BudName.num_modstates.value
+    assert constant_pot.stems[0].stem_name == BudName.num_modstates
     assert constant_pot.stems[1].stem_name == "EMPTY_BUD"
     assert constant_pot.stems[2].stem_name == "PICKY_BUD"
 
@@ -249,23 +261,10 @@ def test_subclass_flowers(visp_parse_inputs_task, max_cs_step_time_sec):
 
     assert len(tag_pot.stems) == 1
     assert len(constant_pot.stems) == 12
-    assert sorted([f.stem_name for f in tag_pot.stems]) == sorted([StemName.modstate.value])
-    assert sorted([f.stem_name for f in constant_pot.stems]) == sorted(
-        [
-            BudName.instrument.value,
-            BudName.num_modstates.value,
-            BudName.proposal_id.value,
-            BudName.contributing_proposal_ids.value,
-            BudName.average_cadence.value,
-            BudName.maximum_cadence.value,
-            BudName.minimum_cadence.value,
-            BudName.variance_cadence.value,
-            BudName.dark_exposure_times.value,
-            BudName.dark_readout_exp_times.value,
-            BudName.experiment_id.value,
-            BudName.contributing_experiment_ids.value,
-        ]
-    )
+    all_flower_names = [StemName.modstate]
+    assert sorted([f.stem_name for f in tag_pot.stems]) == sorted(all_flower_names)
+    all_bud_names = [b.stem_name for b in default_constant_bud_factory()] + [BudName.num_modstates]
+    assert sorted([f.stem_name for f in constant_pot.stems]) == sorted(all_bud_names)
 
 
 def test_constants_correct(parse_inputs_task):

dkist_processing_common/tests/test_quality.py

@@ -1,4 +1,5 @@
 """Tests for the quality tasks."""
+
 import json
 from typing import Iterable
 

dkist_processing_common/tests/test_scratch.py

@@ -1,14 +1,15 @@
 """
 Tests for the workflow file system wrapper
 """
+
 from pathlib import Path
 from typing import Callable
 from uuid import uuid4
 
 import pytest
 
-from dkist_processing_common._util.scratch import _flatten_list
 from dkist_processing_common._util.scratch import WorkflowFileSystem
+from dkist_processing_common._util.scratch import _flatten_list
 
 
 @pytest.fixture(

dkist_processing_common/tests/test_stems.py

@@ -1,3 +1,4 @@
+from enum import StrEnum
 from itertools import chain
 
 import pytest
@@ -21,9 +22,9 @@ from dkist_processing_common.parsers.retarder import RetarderNameBud
 from dkist_processing_common.parsers.single_value_single_key_flower import (
     SingleValueSingleKeyFlower,
 )
-from dkist_processing_common.parsers.task import parse_header_ip_task_with_gains
 from dkist_processing_common.parsers.task import PolcalTaskFlower
 from dkist_processing_common.parsers.task import TaskTypeFlower
+from dkist_processing_common.parsers.task import parse_header_ip_task_with_gains
 from dkist_processing_common.parsers.time import AverageCadenceBud
 from dkist_processing_common.parsers.time import ExposureTimeFlower
 from dkist_processing_common.parsers.time import MaximumCadenceBud
@@ -39,30 +40,38 @@ from dkist_processing_common.parsers.unique_bud import UniqueBud
 from dkist_processing_common.parsers.wavelength import ObserveWavelengthBud
 
 
+class FitsReaderMetadataKey(StrEnum):
+    thing_id = "id_key"
+    constant_thing = "constant"
+    near_thing = "near"
+    proposal_id = "ID___013"
+    experiment_id = "ID___012"
+    ip_task_type = "DKIST004"
+    ip_start_time = "DKIST011"
+    fpa_exposure_time_ms = "XPOSURE"
+    sensor_readout_exposure_time_ms = "TEXPOSUR"
+    num_raw_frames_per_fpa = "NSUMEXP"
+    num_dsps_repeats = "DSPSREPS"
+    current_dsps_repeat = "DSPSNUM"
+    time_obs = "DATE-OBS"
+    gos_level3_status = "GOSLVL3"
+    gos_level3_lamp_status = "GOSLAMP"
+    gos_level0_status = "GOSLVL0"
+    gos_retarder_status = "GOSRET"
+    gos_polarizer_status = "GOSPOL"
+    wavelength = "LINEWAV"
+    roundable_time = "RTIME"
+
+
 class FitsReader(FitsAccessBase):
     def __init__(self, hdu, name):
         super().__init__(hdu, name)
-        self.thing_id: int = self.header.get("id_key")
-        self.constant_thing: float = self.header.get("constant")
-        self.near_thing: float = self.header.get("near")
+        for key in FitsReaderMetadataKey:
+            self._set_metadata_key_value(key=key, optional=True)
+        self._set_metadata_key_value(
+            FitsReaderMetadataKey.roundable_time, optional=True, default=0.0
+        )
         self.name = name
-        self.proposal_id: str = self.header.get("ID___013")
-        self.experiment_id: str = self.header.get("ID___012")
-        self.ip_task_type: str = self.header.get("DKIST004")
-        self.ip_start_time: str = self.header.get("DKIST011")
-        self.fpa_exposure_time_ms: float = self.header.get("XPOSURE")
-        self.sensor_readout_exposure_time_ms: float = self.header.get("TEXPOSUR")
-        self.num_raw_frames_per_fpa: int = self.header.get("NSUMEXP")
-        self.num_dsps_repeats: int = self.header.get("DSPSREPS")
-        self.current_dsps_repeat: int = self.header.get("DSPSNUM")
-        self.time_obs: str = self.header.get("DATE-OBS")
-        self.gos_level3_status: str = self.header.get("GOSLVL3")
-        self.gos_level3_lamp_status: str = self.header.get("GOSLAMP")
-        self.gos_level0_status: str = self.header.get("GOSLVL0")
-        self.gos_retarder_status: str = self.header.get("GOSRET")
-        self.gos_polarizer_status: str = self.header.get("GOSPOL")
-        self.wavelength: str = self.header.get("LINEWAV")
-        self.roundable_time: float = self.header.get("RTIME", 0.0)
 
 
 @pytest.fixture()
@@ -926,4 +935,4 @@ def test_retarder_name_bud_error(bad_polcal_header_objs):
         _ = bud.bud
 
 
-# TODO: test new stems that have been added to parse_l0_input_data
+# TODO: test new stem types that have been added to parse_l0_input_data

dkist_processing_common/tests/test_tags.py

@@ -1,6 +1,7 @@
 """
 Tests for the tag cloud manager
 """
+
 import random
 from typing import Callable
 from uuid import uuid4

dkist_processing_common/tests/test_task_parsing.py

@@ -1,3 +1,5 @@
+from enum import StrEnum
+
 import pytest
 from astropy.io import fits
 
@@ -9,6 +11,15 @@ from dkist_processing_common.parsers.task import parse_polcal_task_type
 from dkist_processing_common.parsers.task import passthrough_header_ip_task
 
 
+class DummyMetadataKey(StrEnum):
+    ip_task_type = "IPTASK"
+    gos_level3_status = "GOSLVL3"
+    gos_level3_lamp_status = "GOSLAMP"
+    gos_level0_status = "GOSLVL0"
+    gos_retarder_status = "GOSRET"
+    gos_polarizer_status = "GOSPOL"
+
+
 class DummyFitsAccess(FitsAccessBase):
     def __init__(
         self,
@@ -17,13 +28,12 @@ class DummyFitsAccess(FitsAccessBase):
         auto_squeeze: bool = False,  # Because L1 data should always have the right form, right?
     ):
         super().__init__(hdu=hdu, name=name, auto_squeeze=auto_squeeze)
-
-        self.ip_task_type: str = self.header["IPTASK"]
-        self.gos_level3_status: str = self.header["GOSLVL3"]
-        self.gos_level3_lamp_status: str = self.header["GOSLAMP"]
-        self.gos_level0_status: str = self.header["GOSLVL0"]
-        self.gos_retarder_status: str = self.header["GOSRET"]
-        self.gos_polarizer_status: str = self.header["GOSPOL"]
+        self._set_metadata_key_value(DummyMetadataKey.ip_task_type)
+        self._set_metadata_key_value(DummyMetadataKey.gos_level3_status)
+        self._set_metadata_key_value(DummyMetadataKey.gos_level3_lamp_status)
+        self._set_metadata_key_value(DummyMetadataKey.gos_level0_status)
+        self._set_metadata_key_value(DummyMetadataKey.gos_retarder_status)
+        self._set_metadata_key_value(DummyMetadataKey.gos_polarizer_status)
 
 
 @pytest.fixture

dkist_processing_common/tests/test_teardown.py

@@ -7,9 +7,9 @@ from dkist_processing_common._util.scratch import WorkflowFileSystem
 from dkist_processing_common.codecs.str import str_encoder
 from dkist_processing_common.models.tags import Tag
 from dkist_processing_common.tasks.teardown import Teardown
+from dkist_processing_common.tests.mock_metadata_store import RecipeRunResponseMapping
 from dkist_processing_common.tests.mock_metadata_store import fake_gql_client_factory
 from dkist_processing_common.tests.mock_metadata_store import make_default_recipe_run_response
-from dkist_processing_common.tests.mock_metadata_store import RecipeRunResponseMapping
 
 
 class TeardownTest(Teardown):

dkist_processing_common/tests/test_transfer_input_data.py

@@ -10,11 +10,11 @@ from dkist_processing_common.models.input_dataset import InputDatasetPartDocumen
 from dkist_processing_common.models.tags import Tag
 from dkist_processing_common.tasks import WorkflowTaskBase
 from dkist_processing_common.tasks.transfer_input_data import TransferL0Data
+from dkist_processing_common.tests.mock_metadata_store import InputDatasetRecipeRunResponseMapping
 from dkist_processing_common.tests.mock_metadata_store import default_calibration_frames_doc
 from dkist_processing_common.tests.mock_metadata_store import default_observe_frames_doc
 from dkist_processing_common.tests.mock_metadata_store import default_parameters_doc
 from dkist_processing_common.tests.mock_metadata_store import fake_gql_client_factory
-from dkist_processing_common.tests.mock_metadata_store import InputDatasetRecipeRunResponseMapping
 from dkist_processing_common.tests.mock_metadata_store import (
     make_default_input_dataset_recipe_run_response,
 )
@@ -60,8 +60,7 @@ def create_input_frames(
 
 
 class TransferL0DataTask(TransferL0Data):
-    def run(self) -> None:
-        ...
+    def run(self) -> None: ...
 
 
 @pytest.fixture

dkist_processing_common/tests/test_trial_catalog.py

@@ -1,4 +1,5 @@
 """Tests for the tasks.trial_catalog module."""
+
 from pathlib import Path
 from string import ascii_uppercase
 from uuid import uuid4

dkist_processing_common/tests/test_trial_output_data.py

@@ -10,9 +10,9 @@ from dkist_processing_common.models.graphql import RecipeRunConfiguration
 from dkist_processing_common.models.tags import Tag
 from dkist_processing_common.tasks.mixin.globus import GlobusTransferItem
 from dkist_processing_common.tasks.trial_output_data import TransferTrialData
+from dkist_processing_common.tests.mock_metadata_store import RecipeRunResponseMapping
 from dkist_processing_common.tests.mock_metadata_store import fake_gql_client_factory
 from dkist_processing_common.tests.mock_metadata_store import make_default_recipe_run_response
-from dkist_processing_common.tests.mock_metadata_store import RecipeRunResponseMapping
 
 
 @pytest.fixture

dkist_processing_common/tests/test_workflow_task_base.py

@@ -190,8 +190,7 @@ def test_dataset_id(workflow_data_task):
 class ProvenanceTask(WorkflowTaskBase):
     record_provenance = True
 
-    def run(self):
-        ...
+    def run(self): ...
 
     # Because I couldn't figure out how to mock the mixin
     def metadata_store_record_provenance(self, is_task_manual: bool, library_versions: str):

dkist_processing_common/tests/test_write_l1.py

@@ -21,14 +21,14 @@ from dkist_processing_common.models.graphql import RecipeRunProvenanceResponse
 from dkist_processing_common.models.tags import Tag
 from dkist_processing_common.models.wavelength import WavelengthRange
 from dkist_processing_common.tasks.write_l1 import WriteL1Frame
-from dkist_processing_common.tests.mock_metadata_store import fake_gql_client_factory
+from dkist_processing_common.tests.mock_metadata_store import TILE_SIZE
 from dkist_processing_common.tests.mock_metadata_store import InputDatasetRecipeRunResponseMapping
+from dkist_processing_common.tests.mock_metadata_store import RecipeRunResponseMapping
+from dkist_processing_common.tests.mock_metadata_store import fake_gql_client_factory
 from dkist_processing_common.tests.mock_metadata_store import (
     make_default_input_dataset_recipe_run_response,
 )
 from dkist_processing_common.tests.mock_metadata_store import make_default_recipe_run_response
-from dkist_processing_common.tests.mock_metadata_store import RecipeRunResponseMapping
-from dkist_processing_common.tests.mock_metadata_store import TILE_SIZE
 
 
 @pytest.fixture
@@ -273,13 +273,11 @@ def write_l1_task_with_empty_waveband(recipe_run_id, tmp_path, request):
     ],
 )
 def write_l1_task_no_data(request, recipe_run_id, tmp_path, complete_common_header):
-    with (
-        CompleteWriteL1Frame(
-            recipe_run_id=recipe_run_id,
-            workflow_name="workflow_name",
-            workflow_version="workflow_version",
-        ) as task
-    ):
+    with CompleteWriteL1Frame(
+        recipe_run_id=recipe_run_id,
+        workflow_name="workflow_name",
+        workflow_version="workflow_version",
+    ) as task:
         task.scratch = WorkflowFileSystem(recipe_run_id=recipe_run_id, scratch_base_path=tmp_path)
         header = complete_common_header
         header.pop("AO_LOCK", None)