django-spire 0.23.6__py3-none-any.whl → 0.23.8__py3-none-any.whl

django_spire/knowledge/entry/version/tests/test_converters/test_docx_converter.py

@@ -7,14 +7,13 @@ from unittest.mock import MagicMock, patch
 from django_spire.core.tests.test_cases import BaseTestCase
 from django_spire.knowledge.entry.version.consts import MARKDOWN_AI_CHUNK_SIZE
 from django_spire.knowledge.entry.version.converters.docx_converter import DocxConverter
-
-from django_spire.knowledge.entry.version.tests.factories import \
-    create_test_entry_version
+from django_spire.knowledge.entry.version.tests.factories import create_test_entry_version
 
 
 class DocxConverterTests(BaseTestCase):
     def setUp(self):
         super().setUp()
+
         self.test_entry_version = create_test_entry_version()
 
     @patch(
@@ -22,8 +21,8 @@ class DocxConverterTests(BaseTestCase):
         'MarkdownFormatLlmBot.process'
     )
     def test_improve_markdown_structure_concurrent_execution(
-            self,
-            mock_process_method: MagicMock
+        self,
+        mock_process_method: MagicMock
     ):
         def slow_process(markdown_content: str):
             time.sleep(0.1)
@@ -40,6 +39,55 @@ class DocxConverterTests(BaseTestCase):
             markdown_content=''.join(mock_chunks)
         )
         end_time = time.time()
-        self.assertLess(end_time - start_time, 0.3)
-        self.assertEqual(mock_process_method.call_count, 3)
-        self.assertEqual(improved_markdown, ''.join(mock_chunks))
+        assert end_time - start_time < 0.3
+        assert mock_process_method.call_count == 3
+        assert improved_markdown == ''.join(mock_chunks)
+
+    @patch(
+        'django_spire.knowledge.entry.version.converters.docx_converter.'
+        'MarkdownFormatLlmBot.process'
+    )
+    def test_improve_markdown_structure_returns_content(
+        self,
+        mock_process_method: MagicMock
+    ):
+        mock_process_method.side_effect = lambda x: x
+        docx_converter = DocxConverter(entry_version=self.test_entry_version)
+
+        markdown = 'a' * MARKDOWN_AI_CHUNK_SIZE + 'b' * MARKDOWN_AI_CHUNK_SIZE
+        result = docx_converter.improve_markdown_structure(markdown_content=markdown)
+
+        assert len(result) == len(markdown)
+        assert mock_process_method.call_count == 2
+
+    @patch(
+        'django_spire.knowledge.entry.version.converters.docx_converter.'
+        'MarkdownFormatLlmBot.process'
+    )
+    def test_improve_markdown_structure_handles_exception(
+        self,
+        mock_process_method: MagicMock
+    ):
+        original_chunk = 'x' * MARKDOWN_AI_CHUNK_SIZE
+        mock_process_method.side_effect = Exception('Test error')
+        docx_converter = DocxConverter(entry_version=self.test_entry_version)
+
+        result = docx_converter.improve_markdown_structure(markdown_content=original_chunk)
+        assert result == original_chunk
+
+    @patch(
+        'django_spire.knowledge.entry.version.converters.docx_converter.'
+        'MarkdownFormatLlmBot.process'
+    )
+    def test_improve_markdown_structure_single_chunk(
+        self,
+        mock_process_method: MagicMock
+    ):
+        mock_process_method.side_effect = lambda x: x
+        docx_converter = DocxConverter(entry_version=self.test_entry_version)
+
+        short_content = 'short content'
+        result = docx_converter.improve_markdown_structure(markdown_content=short_content)
+
+        assert result == short_content
+        assert mock_process_method.call_count == 1

django_spire/knowledge/entry/version/tests/test_converters/test_markdown_converter.py

@@ -0,0 +1,78 @@
+from __future__ import annotations
+
+from django_spire.core.tests.test_cases import BaseTestCase
+from django_spire.knowledge.entry.version.block.choices import BlockTypeChoices
+from django_spire.knowledge.entry.version.converters.markdown_converter import MarkdownConverter
+from django_spire.knowledge.entry.version.tests.factories import create_test_entry_version
+
+
+class MarkdownConverterTests(BaseTestCase):
+    def setUp(self):
+        super().setUp()
+
+        self.entry_version = create_test_entry_version()
+        self.converter = MarkdownConverter(entry_version=self.entry_version)
+
+    def test_convert_markdown_to_blocks_paragraph(self):
+        markdown = 'This is a paragraph.'
+        blocks = self.converter.convert_markdown_to_blocks(markdown)
+        assert len(blocks) == 1
+        assert blocks[0].type == BlockTypeChoices.TEXT
+
+    def test_convert_markdown_to_blocks_heading(self):
+        markdown = '# Heading 1'
+        blocks = self.converter.convert_markdown_to_blocks(markdown)
+        assert len(blocks) == 1
+        assert blocks[0].type == BlockTypeChoices.HEADING
+
+    def test_convert_markdown_to_blocks_multiple_headings(self):
+        markdown = '# H1\n\n## H2\n\n### H3'
+        blocks = self.converter.convert_markdown_to_blocks(markdown)
+        heading_blocks = [b for b in blocks if b.type == BlockTypeChoices.HEADING]
+        assert len(heading_blocks) == 3
+
+    def test_convert_markdown_to_blocks_unordered_list(self):
+        markdown = '- Item 1\n- Item 2\n- Item 3'
+        blocks = self.converter.convert_markdown_to_blocks(markdown)
+        list_blocks = [b for b in blocks if b.type == BlockTypeChoices.LIST]
+        assert len(list_blocks) == 1
+
+    def test_convert_markdown_to_blocks_ordered_list(self):
+        markdown = '1. First\n2. Second\n3. Third'
+        blocks = self.converter.convert_markdown_to_blocks(markdown)
+        list_blocks = [b for b in blocks if b.type == BlockTypeChoices.LIST]
+        assert len(list_blocks) == 1
+
+    def test_convert_markdown_to_blocks_mixed_content(self):
+        markdown = '# Title\n\nSome text.\n\n- List item'
+        blocks = self.converter.convert_markdown_to_blocks(markdown)
+        assert len(blocks) >= 3
+
+    def test_convert_markdown_to_blocks_blank_lines(self):
+        markdown = 'Para 1\n\n\n\nPara 2'
+        blocks = self.converter.convert_markdown_to_blocks(markdown)
+        assert len(blocks) >= 2
+
+    def test_html_to_markdown(self):
+        html = '<p>Hello <b>World</b></p>'
+        result = MarkdownConverter.html_to_markdown(html)
+        assert 'Hello' in result
+        assert 'World' in result
+
+    def test_convert_markdown_to_blocks_checklist(self):
+        markdown = '- [ ] Todo\n- [x] Done'
+        blocks = self.converter.convert_markdown_to_blocks(markdown)
+        list_blocks = [b for b in blocks if b.type == BlockTypeChoices.LIST]
+        assert len(list_blocks) == 1
+
+    def test_convert_markdown_to_blocks_nested_list(self):
+        markdown = '- Parent\n  - Child'
+        blocks = self.converter.convert_markdown_to_blocks(markdown)
+        list_blocks = [b for b in blocks if b.type == BlockTypeChoices.LIST]
+        assert len(list_blocks) == 1
+
+    def test_block_ordering(self):
+        markdown = '# H1\n\nParagraph\n\n- List'
+        blocks = self.converter.convert_markdown_to_blocks(markdown)
+        for i, block in enumerate(blocks):
+            assert block.order == i

django_spire/knowledge/entry/version/tests/test_maps.py

@@ -0,0 +1,58 @@
+from __future__ import annotations
+
+from django_spire.core.tests.test_cases import BaseTestCase
+from django_spire.knowledge.entry.version.block.data.list.choices import OrderedListCounterType
+from django_spire.knowledge.entry.version.block.data.list.meta import (
+    ChecklistItemMeta,
+    OrderedListItemMeta,
+)
+
+
+class ChecklistItemMetaTests(BaseTestCase):
+    def test_default_unchecked(self):
+        meta = ChecklistItemMeta()
+        assert meta.checked is False
+
+    def test_checked_true(self):
+        meta = ChecklistItemMeta(checked=True)
+        assert meta.checked is True
+
+    def test_checked_false(self):
+        meta = ChecklistItemMeta(checked=False)
+        assert meta.checked is False
+
+
+class OrderedListItemMetaTests(BaseTestCase):
+    def test_default_values(self):
+        meta = OrderedListItemMeta()
+        assert meta.start is None
+        assert meta.counterType is None
+
+    def test_with_start(self):
+        meta = OrderedListItemMeta(start=5)
+        assert meta.start == 5
+
+    def test_with_counter_type_numeric(self):
+        meta = OrderedListItemMeta(counterType=OrderedListCounterType.NUMERIC)
+        assert meta.counterType == OrderedListCounterType.NUMERIC
+
+    def test_with_counter_type_upper_roman(self):
+        meta = OrderedListItemMeta(counterType=OrderedListCounterType.UPPER_ROMAN)
+        assert meta.counterType == OrderedListCounterType.UPPER_ROMAN
+
+    def test_with_counter_type_lower_roman(self):
+        meta = OrderedListItemMeta(counterType=OrderedListCounterType.LOWER_ROMAN)
+        assert meta.counterType == OrderedListCounterType.LOWER_ROMAN
+
+    def test_with_counter_type_upper_alpha(self):
+        meta = OrderedListItemMeta(counterType=OrderedListCounterType.UPPER_ALPHA)
+        assert meta.counterType == OrderedListCounterType.UPPER_ALPHA
+
+    def test_with_counter_type_lower_alpha(self):
+        meta = OrderedListItemMeta(counterType=OrderedListCounterType.LOWER_ALPHA)
+        assert meta.counterType == OrderedListCounterType.LOWER_ALPHA
+
+    def test_with_all_values(self):
+        meta = OrderedListItemMeta(start=10, counterType=OrderedListCounterType.NUMERIC)
+        assert meta.start == 10
+        assert meta.counterType == OrderedListCounterType.NUMERIC

django_spire/knowledge/entry/version/tests/test_models.py

@@ -0,0 +1,23 @@
+from __future__ import annotations
+
+from django_spire.core.tests.test_cases import BaseTestCase
+from django_spire.knowledge.entry.version.choices import EntryVersionStatusChoices
+from django_spire.knowledge.entry.version.tests.factories import create_test_entry_version
+
+
+class EntryVersionModelTests(BaseTestCase):
+    def setUp(self):
+        super().setUp()
+        self.entry_version = create_test_entry_version()
+
+    def test_is_published_false_when_draft(self):
+        self.entry_version.status = EntryVersionStatusChoices.DRAFT
+        assert self.entry_version.is_published() is False
+
+    def test_is_published_true_when_published(self):
+        self.entry_version.status = EntryVersionStatusChoices.PUBLISHED
+        assert self.entry_version.is_published() is True
+
+    def test_is_published_false_when_archived(self):
+        self.entry_version.status = EntryVersionStatusChoices.ARCHIVED
+        assert self.entry_version.is_published() is False

django_spire/knowledge/entry/version/tests/test_querysets.py

@@ -0,0 +1,26 @@
+from __future__ import annotations
+
+from django_spire.core.tests.test_cases import BaseTestCase
+from django_spire.knowledge.entry.version.models import EntryVersion
+from django_spire.knowledge.entry.version.tests.factories import create_test_entry_version
+from django_spire.knowledge.entry.version.block.tests.factories import create_test_version_block
+
+
+class EntryVersionQuerySetTests(BaseTestCase):
+    def setUp(self):
+        super().setUp()
+        self.entry_version = create_test_entry_version()
+
+    def test_prefetch_blocks(self):
+        create_test_version_block(version=self.entry_version)
+        result = EntryVersion.objects.prefetch_blocks().get(pk=self.entry_version.pk)
+        assert result.blocks.count() == 1
+
+    def test_prefetch_blocks_ordering(self):
+        create_test_version_block(version=self.entry_version, order=2)
+        create_test_version_block(version=self.entry_version, order=1)
+
+        result = EntryVersion.objects.prefetch_blocks().get(pk=self.entry_version.pk)
+        blocks = list(result.blocks.all())
+
+        assert blocks[0].order < blocks[1].order

django_spire/knowledge/entry/version/tests/test_services.py

@@ -0,0 +1,62 @@
+from __future__ import annotations
+
+from django_spire.core.tests.test_cases import BaseTestCase
+from django_spire.knowledge.entry.version.choices import EntryVersionStatusChoices
+from django_spire.knowledge.entry.version.block.models import EntryVersionBlock
+from django_spire.knowledge.entry.version.block.tests.factories import (
+    create_test_block_form_data,
+    create_test_version_block,
+)
+from django_spire.knowledge.entry.version.tests.factories import create_test_entry_version
+
+
+class EntryVersionProcessorServiceTests(BaseTestCase):
+    def setUp(self):
+        super().setUp()
+        self.entry_version = create_test_entry_version()
+
+    def test_publish(self):
+        self.entry_version.services.processor.publish()
+        self.entry_version.refresh_from_db()
+        assert self.entry_version.status == EntryVersionStatusChoices.PUBLISHED
+        assert self.entry_version.published_datetime is not None
+
+    def test_add_update_delete_blocks_add_new(self):
+        block_data = create_test_block_form_data(id='new_block_123')
+        self.entry_version.services.processor.add_update_delete_blocks([block_data])
+        assert EntryVersionBlock.objects.filter(version=self.entry_version).count() == 1
+
+    def test_add_update_delete_blocks_update_existing(self):
+        existing_block = create_test_version_block(version=self.entry_version)
+        block_data = create_test_block_form_data(
+            id=existing_block.id,
+            data={'text': 'updated text'}
+        )
+        self.entry_version.services.processor.add_update_delete_blocks([block_data])
+
+        existing_block.refresh_from_db()
+        assert existing_block._block_data['text'] == 'updated text'
+
+    def test_add_update_delete_blocks_delete_missing(self):
+        existing_block = create_test_version_block(version=self.entry_version)
+        self.entry_version.services.processor.add_update_delete_blocks([])
+        assert not EntryVersionBlock.objects.filter(pk=existing_block.pk).exists()
+
+    def test_add_update_delete_blocks_mixed_operations(self):
+        existing_block = create_test_version_block(version=self.entry_version)
+        block_to_delete = create_test_version_block(version=self.entry_version, order=2)
+
+        block_data_update = create_test_block_form_data(
+            id=existing_block.id,
+            order=0,
+            data={'text': 'updated'}
+        )
+        block_data_new = create_test_block_form_data(id='new_block', order=1)
+
+        self.entry_version.services.processor.add_update_delete_blocks([
+            block_data_update,
+            block_data_new
+        ])
+
+        assert EntryVersionBlock.objects.filter(version=self.entry_version).count() == 2
+        assert not EntryVersionBlock.objects.filter(pk=block_to_delete.pk).exists()

django_spire/knowledge/entry/version/tests/test_urls/test_json_urls.py

@@ -5,23 +5,22 @@ import json
 from django.urls import reverse
 
 from django_spire.core.tests.test_cases import BaseTestCase
+from django_spire.knowledge.collection.tests.factories import create_test_collection
 from django_spire.knowledge.entry.tests.factories import create_test_entry
-from django_spire.knowledge.entry.version.block.tests.factories import \
-    create_test_block_form_data
-from django_spire.knowledge.entry.version.tests.factories import \
-    create_test_entry_version
+from django_spire.knowledge.entry.version.block.tests.factories import create_test_block_form_data
+from django_spire.knowledge.entry.version.tests.factories import create_test_entry_version
 
 
 class EntryVersionJsonUrlsTests(BaseTestCase):
     def setUp(self):
         super().setUp()
-
-        self.test_entry = create_test_entry()
+        self.collection = create_test_collection()
+        self.test_entry = create_test_entry(collection=self.collection)
         self.test_entry_version = create_test_entry_version(entry=self.test_entry)
         self.test_entry.current_version = self.test_entry_version
         self.test_entry.save()
 
-    def test_save_version_blocks_view(self):
+    def test_update_blocks_view(self):
         response = self.client.post(
             reverse(
                 'django_spire:knowledge:entry:version:json:update_blocks',
@@ -30,5 +29,25 @@ class EntryVersionJsonUrlsTests(BaseTestCase):
             data=json.dumps([create_test_block_form_data()]),
             content_type='application/json'
         )
+        assert response.status_code == 200
 
-        self.assertEqual(response.status_code, 200)
+    def test_update_blocks_view_empty_list(self):
+        response = self.client.post(
+            reverse(
+                'django_spire:knowledge:entry:version:json:update_blocks',
+                kwargs={'pk': self.test_entry_version.pk}
+            ),
+            data=json.dumps([]),
+            content_type='application/json'
+        )
+        assert response.status_code == 200
+
+    def test_update_entry_from_version_view(self):
+        response = self.client.post(
+            reverse(
+                'django_spire:knowledge:entry:version:json:update_entry_from_version',
+                kwargs={'pk': self.test_entry_version.pk}
+            ),
+            content_type='application/json'
+        )
+        assert response.status_code == 200

django_spire/knowledge/entry/version/tests/test_urls/test_page_urls.py

@@ -3,28 +3,35 @@ from __future__ import annotations
 from django.urls import reverse
 
 from django_spire.core.tests.test_cases import BaseTestCase
+from django_spire.knowledge.collection.tests.factories import create_test_collection
 from django_spire.knowledge.entry.tests.factories import create_test_entry
-from django_spire.knowledge.entry.version.tests.factories import \
-    create_test_entry_version
+from django_spire.knowledge.entry.version.tests.factories import create_test_entry_version
 
 
 class EntryVersionPageUrlsTests(BaseTestCase):
     def setUp(self):
         super().setUp()
 
-        self.test_entry = create_test_entry()
-        self.test_entry_version = create_test_entry_version(
-            entry=self.test_entry
-        )
+        self.collection = create_test_collection()
+        self.test_entry = create_test_entry(collection=self.collection)
+        self.test_entry_version = create_test_entry_version(entry=self.test_entry)
         self.test_entry.current_version = self.test_entry_version
         self.test_entry.save()
 
-    def test_detail_view_url_path(self):
+    def test_editor_view_url_path(self):
         response = self.client.get(
             reverse(
                 'django_spire:knowledge:entry:version:page:editor',
                 kwargs={'pk': self.test_entry_version.pk}
             )
         )
+        assert response.status_code == 200
 
-        self.assertEqual(response.status_code, 200)
+    def test_editor_view_with_edit_mode(self):
+        response = self.client.get(
+            reverse(
+                'django_spire:knowledge:entry:version:page:editor',
+                kwargs={'pk': self.test_entry_version.pk}
+            ) + '?view_mode=edit'
+        )
+        assert response.status_code == 200

django_spire/knowledge/entry/version/tests/test_urls/test_redirect_urls.py

@@ -0,0 +1,38 @@
+from __future__ import annotations
+
+from django.urls import reverse
+
+from django_spire.core.tests.test_cases import BaseTestCase
+from django_spire.knowledge.collection.tests.factories import create_test_collection
+from django_spire.knowledge.entry.tests.factories import create_test_entry
+from django_spire.knowledge.entry.version.choices import EntryVersionStatusChoices
+from django_spire.knowledge.entry.version.tests.factories import create_test_entry_version
+
+
+class EntryVersionRedirectUrlsTests(BaseTestCase):
+    def setUp(self):
+        super().setUp()
+        self.collection = create_test_collection()
+        self.test_entry = create_test_entry(collection=self.collection)
+        self.test_entry_version = create_test_entry_version(entry=self.test_entry)
+        self.test_entry.current_version = self.test_entry_version
+        self.test_entry.save()
+
+    def test_publish_view_redirects(self):
+        response = self.client.post(
+            reverse(
+                'django_spire:knowledge:entry:version:redirect:publish',
+                kwargs={'pk': self.test_entry_version.pk}
+            )
+        )
+        assert response.status_code == 302
+
+    def test_publish_view_updates_status(self):
+        self.client.post(
+            reverse(
+                'django_spire:knowledge:entry:version:redirect:publish',
+                kwargs={'pk': self.test_entry_version.pk}
+            )
+        )
+        self.test_entry_version.refresh_from_db()
+        assert self.test_entry_version.status == EntryVersionStatusChoices.PUBLISHED

django_spire/knowledge/entry/version/urls/__init__.py

@@ -1,5 +1,8 @@
+from __future__ import annotations
+
 from django.urls import include, path
 
+
 app_name = 'version'
 
 urlpatterns = [

django_spire/knowledge/entry/version/urls/json_urls.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from django.urls import path
 
 from django_spire.knowledge.entry.version.views import json_views
@@ -5,7 +7,6 @@ from django_spire.knowledge.entry.version.views import json_views
 
 app_name = 'json'
 
-
 urlpatterns = [
     path(
         '<int:pk>/update_blocks/',

django_spire/knowledge/entry/version/urls/page_urls.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from django.urls import path
 
 from django_spire.knowledge.entry.version.views import page_views

django_spire/knowledge/entry/version/urls/redirect_urls.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from django.urls import path
 
 from django_spire.knowledge.entry.version.views import redirect_views

django_spire/knowledge/entry/version/views/json_views.py

@@ -2,7 +2,8 @@ from __future__ import annotations
 
 import json
 
-from django.core.handlers.wsgi import WSGIRequest
+from typing import TYPE_CHECKING
+
 from django.http import JsonResponse
 from django.shortcuts import get_object_or_404
 
@@ -10,6 +11,9 @@ from django_spire.auth.controller.controller import AppAuthController
 from django_spire.core.decorators import valid_ajax_request_required
 from django_spire.knowledge.entry.version.models import EntryVersion
 
+if TYPE_CHECKING:
+    from django.core.handlers.wsgi import WSGIRequest
+
 
 @valid_ajax_request_required
 @AppAuthController('knowledge').permission_required('can_change')

django_spire/knowledge/entry/version/views/page_views.py

@@ -2,9 +2,9 @@ from __future__ import annotations
 
 import json
 
-from django.core.handlers.wsgi import WSGIRequest
+from typing import TYPE_CHECKING
+
 from django.shortcuts import get_object_or_404
-from django.template.response import TemplateResponse
 from django.urls import reverse
 
 from django_spire.auth.controller.controller import AppAuthController
@@ -12,6 +12,12 @@ from django_spire.contrib.generic_views import portal_views
 from django_spire.knowledge.collection.models import Collection
 from django_spire.knowledge.entry.version.models import EntryVersion
 
+if TYPE_CHECKING:
+    from django.core.handlers.wsgi import WSGIRequest
+    from django.template.response import TemplateResponse
+
+    from django_spire.contrib.breadcrumb.breadcrumbs import Breadcrumbs
+
 
 @AppAuthController('knowledge').permission_required('can_view')
 def editor_view(request: WSGIRequest, pk: int) -> TemplateResponse:
@@ -21,11 +27,12 @@ def editor_view(request: WSGIRequest, pk: int) -> TemplateResponse:
     top_level_collection = entry.top_level_collection
     version_blocks = entry_version.blocks.format_for_editor()
 
-    def breadcrumbs_func(breadcrumbs):
+    def breadcrumbs_func(breadcrumbs: Breadcrumbs):
         breadcrumbs.add_breadcrumb(
             name='Knowledge',
             href=reverse('django_spire:knowledge:page:home')
         )
+
         breadcrumbs.add_base_breadcrumb(entry)
 
     return portal_views.detail_view(

django_spire/knowledge/entry/version/views/redirect_views.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
-from django.core.handlers.wsgi import WSGIRequest
+from typing import TYPE_CHECKING
+
 from django.http import HttpResponseRedirect
 from django.shortcuts import get_object_or_404
 from django.urls import reverse
@@ -8,6 +9,9 @@ from django.urls import reverse
 from django_spire.auth.controller.controller import AppAuthController
 from django_spire.knowledge.entry.version.models import EntryVersion
 
+if TYPE_CHECKING:
+    from django.core.handlers.wsgi import WSGIRequest
+
 
 @AppAuthController('knowledge').permission_required('can_change')
 def publish_view(request: WSGIRequest, pk: int) -> HttpResponseRedirect:

django_spire/knowledge/entry/views/form_views.py

@@ -1,8 +1,10 @@
+from __future__ import annotations
+
 import django_glue as dg
 
-from django.core.handlers.wsgi import WSGIRequest
+from typing import TYPE_CHECKING
+
 from django.http import HttpResponseRedirect
-from django.template.response import TemplateResponse
 from django.urls import reverse
 
 from django_spire.auth.controller.controller import AppAuthController
@@ -16,12 +18,16 @@ from django_spire.knowledge.entry.models import Entry
 from django_spire.knowledge.entry.forms import EntryForm, EntryFilesForm
 from django_spire.knowledge.entry.version.maps import FILE_TYPE_CONVERTER_MAP
 
+if TYPE_CHECKING:
+    from django.core.handlers.wsgi import WSGIRequest
+    from django.template.response import TemplateResponse
+
 
 @AppAuthController('knowledge').permission_required('can_add')
 def form_view(
-        request: WSGIRequest,
-        collection_pk: int,
-        pk: int = 0,
+    request: WSGIRequest,
+    collection_pk: int,
+    pk: int = 0
 ) -> TemplateResponse | HttpResponseRedirect:
     entry = get_object_or_null_obj(Entry, pk=pk)
     collection = Collection.objects.get(pk=collection_pk)
@@ -70,8 +76,8 @@ def form_view(
 
 @AppAuthController('knowledge').permission_required('can_add')
 def import_form_view(
-        request: WSGIRequest,
-        collection_pk: int
+    request: WSGIRequest,
+    collection_pk: int
 ) -> TemplateResponse | HttpResponseRedirect:
     dg.glue_query_set(
         request,
@@ -88,13 +94,15 @@ def import_form_view(
                 related_field=None,
                 app_name='knowledge'
             )
+
             file_objects = file_uploader.upload(request.FILES.getlist('import_files'))
 
-            _ = Entry.services.factory.create_from_files(
+            Entry.services.factory.create_from_files(
                 author=request.user,
                 collection=Collection.objects.get(pk=collection_pk),
                 files=file_objects
             )
+
             return HttpResponseRedirect(
                 reverse(
                     'django_spire:knowledge:entry:template:file_list',

django_spire/knowledge/entry/views/json_views.py

@@ -1,13 +1,15 @@
 from __future__ import annotations
 
 import json
+
 from typing import TYPE_CHECKING
 
+from django.http import JsonResponse
+
 from django_spire.core.shortcuts import get_object_or_null_obj
 from django_spire.core.decorators import valid_ajax_request_required
 from django_spire.knowledge.collection.models import Collection
 from django_spire.knowledge.entry.models import Entry
-from django.http import JsonResponse
 
 if TYPE_CHECKING:
     from django.core.handlers.wsgi import WSGIRequest