disdrodb 0.1.3__py3-none-any.whl → 0.1.5__py3-none-any.whl

disdrodb/l1/processing.py

@@ -19,8 +19,8 @@
 import xarray as xr
 
 from disdrodb.constants import DIAMETER_DIMENSION, VELOCITY_DIMENSION
-from disdrodb.l1.fall_velocity import get_raindrop_fall_velocity
-from disdrodb.l1.filters import define_spectrum_mask, filter_diameter_bins, filter_velocity_bins
+from disdrodb.l1.fall_velocity import get_raindrop_fall_velocity_from_ds
+from disdrodb.l1.filters import define_raindrop_spectrum_mask, filter_diameter_bins, filter_velocity_bins
 from disdrodb.l1.resampling import add_sample_interval
 from disdrodb.l1_env.routines import load_env_dataset
 from disdrodb.l2.empirical_dsd import (  # TODO: maybe move out of L2
@@ -34,7 +34,7 @@ from disdrodb.utils.writer import finalize_product
 def generate_l1(
     ds,
     # Fall velocity option
-    fall_velocity_method="Beard1976",
+    fall_velocity_model="Beard1976",
     # Diameter-Velocity Filtering Options
     minimum_diameter=0,
     maximum_diameter=10,
@@ -54,7 +54,7 @@ def generate_l1(
     ----------
     ds : xarray.Dataset
         DISDRODB L0C dataset.
-    fall_velocity_method : str, optional
+    fall_velocity_model : str, optional
         Method to compute fall velocity.
         The default method is ``"Beard1976"``.
     minimum_diameter : float, optional
@@ -83,7 +83,7 @@ def generate_l1(
     Returns
     -------
     xarray.Dataset
-        DISRODB L1 dataset.
+        DISDRODB L1 dataset.
     """
     # Retrieve source attributes
     attrs = ds.attrs.copy()
@@ -106,7 +106,9 @@ def generate_l1(
 
     # ---------------------------------------------------------------------------
     # Retrieve ENV dataset or take defaults
-    # --> Used only for Beard fall velocity currently !
+    # - Used only for Beard fall velocity currently !
+    # - It checks and includes default geolocation if missing
+    # - For mobile disdrometer, infill missing geolocation with backward and forward filling
     ds_env = load_env_dataset(ds)
 
     # ---------------------------------------------------------------------------
@@ -120,7 +122,7 @@ def generate_l1(
     ds_l1 = add_sample_interval(ds_l1, sample_interval=sample_interval)
 
     # Add L0C coordinates that might got lost
-    if "time_qc" in ds_l1:
+    if "time_qc" in ds:
         ds_l1 = ds_l1.assign_coords({"time_qc": ds["time_qc"]})
 
     # -------------------------------------------------------------------------------------------
@@ -128,7 +130,7 @@ def generate_l1(
     if sensor_name in ["PARSIVEL", "PARSIVEL2"]:
         # - Remove first two bins because never reports data !
         # - If not removed, can alter e.g. L2M model fitting
-        ds_l1 = filter_diameter_bins(ds=ds_l1, minimum_diameter=0.312)  # it includes the 0.2495-0.3745 bin
+        ds_l1 = filter_diameter_bins(ds=ds_l1, minimum_diameter=0.2495)  # it includes the 0.2495-0.3745 bin
 
     # - Filter diameter bins
     ds_l1 = filter_diameter_bins(ds=ds_l1, minimum_diameter=minimum_diameter, maximum_diameter=maximum_diameter)
@@ -138,16 +140,12 @@ def generate_l1(
 
     # -------------------------------------------------------------------------------------------
     # Compute fall velocity
-    ds_l1["fall_velocity"] = get_raindrop_fall_velocity(
-        diameter=ds_l1["diameter_bin_center"],
-        method=fall_velocity_method,
-        ds_env=ds_env,  # mm
-    )
+    ds_l1["fall_velocity"] = get_raindrop_fall_velocity_from_ds(ds=ds_l1, ds_env=ds_env, model=fall_velocity_model)
 
     # -------------------------------------------------------------------------------------------
     # Define filtering mask according to fall velocity
     if has_velocity_dimension:
-        mask = define_spectrum_mask(
+        mask = define_raindrop_spectrum_mask(
             drop_number=ds_l1["raw_drop_number"],
             fall_velocity=ds_l1["fall_velocity"],
             above_velocity_fraction=above_velocity_fraction,

disdrodb/l1_env/routines.py

@@ -15,39 +15,68 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 # -----------------------------------------------------------------------------.
 """Core functions for DISDRODB ENV production."""
+import numpy as np
 import xarray as xr
 
 from disdrodb.constants import GEOLOCATION_COORDS
+from disdrodb.l0.l0b_processing import ensure_valid_geolocation
+from disdrodb.utils.logger import log_warning
+
+DEFAULT_GEOLOCATION = {
+    "latitude": 46.159346,
+    "longitude": 8.774586,
+    "altitude": 0,
+}
 
 
 def get_default_environment_dataset():
     """Define defaults values for the ENV dataset."""
     ds_env = xr.Dataset()
-    ds_env["sea_level_air_pressure"] = 101_325
-    ds_env["gas_constant_dry_air"] = 287.04
-    ds_env["lapse_rate"] = 0.0065
-    ds_env["relative_humidity"] = 0.95  # Value between 0 and 1 !
-    ds_env["temperature"] = 20 + 273.15
+    ds_env["sea_level_air_pressure"] = 101_325  # Pa
+    ds_env["gas_constant_dry_air"] = 287.04  # J kg⁻¹ K⁻¹
+    ds_env["lapse_rate"] = 0.0065  # K m⁻¹
+    ds_env["relative_humidity"] = 0.95  # 0-1 !
+    ds_env["temperature"] = 20 + 273.15  # K
+    ds_env["water_density"] = 1000  # kg m⁻³   (T == 10 --> 999.7, T == 20 --> 998.2)
+    # get_water_density(temperature=temperature, air_pressure=air_pressure
     return ds_env
 
 
-def _assign_geolocation(ds_src, dst_dst):
+def _assign_geolocation(ds_src, dst_dst, logger=None):
+    dict_coords = {}
+    for coord in GEOLOCATION_COORDS:
+        if coord in ds_src:
+            # Check geolocation validity
+            ds_src = ensure_valid_geolocation(ds_src, coord=coord, errors="coerce")
+            # Assign valid geolocation (or default one if invalid)
+            if "time" not in ds_src[coord].dims:
+                dict_coords[coord] = ds_src[coord] if not np.isnan(ds_src[coord]) else DEFAULT_GEOLOCATION[coord]
+            else:  # If coordinates varies over time, infill NaN over time with forward and backward filling
+                dict_coords[coord] = ds_src[coord].ffill(dim="time").bfill(dim="time")
+        else:
+            dict_coords[coord] = DEFAULT_GEOLOCATION[coord]
+            log_warning(
+                logger=logger,
+                msg=f"{coord} not available. Setting {coord}={DEFAULT_GEOLOCATION[coord]}",
+                verbose=False,
+            )
 
-    dict_coords = {coord: ds_src[coord] for coord in GEOLOCATION_COORDS if coord in ds_src}
+    # Assign geolocation
     dst_dst = dst_dst.assign_coords(dict_coords)
     return dst_dst
 
 
-def load_env_dataset(ds):
+def load_env_dataset(ds=None, logger=None):
     """Load the ENV dataset."""
-    # TODO: Retrieve relative_humidity and temperature from L1-ENV
+    # TODO: Retrieve relative_humidity, lapse_rate and temperature from DISDRODB-ENV product
+
+    # Load default environment dataset
     ds_env = get_default_environment_dataset()
-    # Compute water density
-    # get_water_density(
-    # temperature=temperature,
-    # air_pressure=air_pressure,
-    # )
-    # -->  (T == 10 --> 999.7, T == 20 --> 998.2
-    ds_env["water_density"] = 1000  # kg / m3 # TODO as function of ENV (temperature, ...) ?
-    ds_env = _assign_geolocation(ds_src=ds, dst_dst=ds_env)
+
+    # Assign geolocation if input dataset provided
+    if ds is not None:
+        ds_env = _assign_geolocation(ds_src=ds, dst_dst=ds_env, logger=logger)
+    # Otherwise add default geolocation
+    else:
+        ds_env = ds_env.assign_coords(DEFAULT_GEOLOCATION)
     return ds_env

disdrodb/l2/empirical_dsd.py

@@ -236,6 +236,12 @@ def get_effective_sampling_area(sensor_name, diameter):
     if sensor_name == "RD80":
         sampling_area = 0.005  # m2
         return sampling_area
+    if sensor_name == "SWS250":  # TODO: L * (B - diameter / 2) ?
+        # Table 29 of the manual that the sample volume is 400cm3, path length?
+        # Distance between the end of the hood heaters is 291 mm.
+        # Adding a factor of 1.5 for better representation of the Tx-Rx distance: L= 436 mm.
+        sampling_area = 0.0091  # m2
+        return sampling_area
     raise NotImplementedError(f"Effective sampling area for {sensor_name} must yet to be specified in the software.")
 
 

disdrodb/l2/processing.py

@@ -219,7 +219,7 @@ def generate_l2e(
     Returns
     -------
     xarray.Dataset
-        DISRODB L2E dataset.
+        DISDRODB L2E dataset.
     """
     # Check and prepapre input dataset
     ds = check_l2e_input_dataset(ds)
@@ -441,7 +441,7 @@ def generate_l2m(
     diameter_spacing=0.05,
     # Processing options
     ds_env=None,
-    fall_velocity_method="Beard1976",
+    fall_velocity_model="Beard1976",
     # Filtering options
     minimum_ndrops=1,
     minimum_nbins=3,
@@ -548,7 +548,7 @@ def generate_l2m(
     drop_number_concentration = psd(diameter)
 
     # Retrieve fall velocity for each new diameter bin
-    velocity = get_raindrop_fall_velocity(diameter=diameter, method=fall_velocity_method, ds_env=ds_env)  # mm
+    velocity = get_raindrop_fall_velocity(diameter=diameter, model=fall_velocity_model, ds_env=ds_env)  # mm
 
     # Compute integral parameters
     ds_params = compute_integral_parameters(

disdrodb/metadata/checks.py

@@ -137,8 +137,6 @@ def _check_metadata_measurement_interval(metadata):
     """Check metadata ``measurement_interval``."""
     from disdrodb.api.checks import check_measurement_intervals
 
-    if "measurement_interval" not in metadata:
-        raise ValueError("The metadata file does not contain the 'measurement_interval' key.")
     measurement_intervals = metadata["measurement_interval"]
     _ = check_measurement_intervals(measurement_intervals)
 
@@ -150,28 +148,8 @@ def _check_metadata_sensor_name(metadata):
     check_sensor_name(sensor_name)
 
 
-def check_station_metadata(data_source, campaign_name, station_name, metadata_archive_dir=None):
-    """Check DISDRODB metadata compliance."""
-    from disdrodb.l0.l0_reader import check_metadata_reader
-
-    metadata = read_station_metadata(
-        data_source=data_source,
-        campaign_name=campaign_name,
-        station_name=station_name,
-        metadata_archive_dir=metadata_archive_dir,
-    )
-    _check_metadata_keys(metadata)
-    _check_metadata_values(metadata)
-    _check_metadata_campaign_name(metadata, expected_name=campaign_name)
-    _check_metadata_data_source(metadata, expected_name=data_source)
-    _check_metadata_station_name(metadata, expected_name=station_name)
-    _check_metadata_sensor_name(metadata)
-    _check_metadata_measurement_interval(metadata)
-    check_metadata_reader(metadata)
-
-
 #### --------------------------------------------------------------------------.
-#### Metadata Archive Missing Information
+#### Geolocation Checks
 
 
 def _check_lonlat_type(longitude, latitude):
@@ -185,16 +163,18 @@ def _check_lonlat_type(longitude, latitude):
         raise ValueError("Unspecified longitude and latitude coordinates.")
 
 
-def _check_lonlat_validity(longitude, latitude):
+def _check_lonlat_validity(longitude, latitude, raise_error_if_unknown=True):
     if longitude == -9999 or latitude == -9999:
-        raise ValueError("Missing lat lon coordinates (-9999).")
+        if raise_error_if_unknown:
+            raise ValueError("Missing lat lon coordinates (-9999).")
+        return
     if longitude > 180 or longitude < -180:
         raise ValueError("Invalid longitude (outside [-180, 180])")
     if latitude > 90 or latitude < -90:
         raise ValueError("Invalid latitude (outside [-90, 90])")
 
 
-def check_station_metadata_geolocation(metadata) -> None:
+def check_station_metadata_geolocation(metadata, raise_error_if_unknown=True) -> None:
     """Identify metadata with missing or wrong geolocation."""
     # Get longitude, latitude and platform type
     longitude = metadata.get("longitude")
@@ -209,54 +189,11 @@ def check_station_metadata_geolocation(metadata) -> None:
             raise ValueError("For mobile platform_type, specify latitude and longitude -9999")
     # - If fixed platform
     else:
-        _check_lonlat_validity(longitude=longitude, latitude=latitude)
-
-
-def identify_missing_metadata_coords(metadata_filepaths: str) -> None:
-    """Identify missing coordinates.
-
-    Parameters
-    ----------
-    metadata_filepaths : str
-        Input YAML file path.
-
-    Raises
-    ------
-    TypeError
-        Error if ``latitude`` or ``longitude`` coordinates are not present or are wrongly formatted.
-
-    """
-    for filepath in metadata_filepaths:
-        metadata = read_yaml(filepath)
-        check_station_metadata_geolocation(metadata)
-
-
-def identify_empty_metadata_keys(metadata_filepaths: list, keys: Union[str, list]) -> None:
-    """Identify empty metadata keys.
-
-    Parameters
-    ----------
-    metadata_filepaths : str
-        Input YAML file path.
-    keys : Union[str,list]
-        Attributes to verify the presence.
-    """
-    if isinstance(keys, str):
-        keys = [keys]
-
-    for filepath in metadata_filepaths:
-        for key in keys:
-            metadata = read_yaml(filepath)
-            if len(str(metadata.get(key, ""))) == 0:  # ensure is string to avoid error
-                print(f"Empty {key} at: ", filepath)
-
-
-#### --------------------------------------------------------------------------.
-#### Check Metadata Archive
+        _check_lonlat_validity(longitude=longitude, latitude=latitude, raise_error_if_unknown=raise_error_if_unknown)
 
 
-def check_metadata_archive_keys(metadata_archive_dir: Optional[str] = None) -> bool:
-    """Check that all metadata files have valid keys.
+def check_metadata_archive_geolocation(metadata_archive_dir: Optional[str] = None, raise_error_if_unknown=True):
+    """Check the metadata files have missing or wrong geolocation..
 
     Parameters
     ----------
@@ -293,17 +230,39 @@ def check_metadata_archive_keys(metadata_archive_dir: Optional[str] = None) -> b
             station_name=station_name,
         )
         try:
-            _check_metadata_keys(metadata)
+            check_station_metadata_geolocation(metadata, raise_error_if_unknown=raise_error_if_unknown)
         except Exception as e:
-            print(f"Error for {data_source} {campaign_name} {station_name}.")
-            print(f"The error is: {e}.")
             is_valid = False
-
+            print(f"Missing information for {data_source} {campaign_name} {station_name}.")
+            print(f"The error is: {e}.")
     return is_valid
 
 
-def check_metadata_archive_campaign_name(metadata_archive_dir: Optional[str] = None) -> bool:
-    """Check metadata ``campaign_name``.
+####------------------------------------------------------------------------------------------------------------.
+#### Metadata Station and Archive Checking Routines
+def check_station_metadata(data_source, campaign_name, station_name, metadata_archive_dir=None):
+    """Check DISDRODB metadata compliance."""
+    from disdrodb.l0.l0_reader import check_metadata_reader
+
+    metadata = read_station_metadata(
+        data_source=data_source,
+        campaign_name=campaign_name,
+        station_name=station_name,
+        metadata_archive_dir=metadata_archive_dir,
+    )
+    _check_metadata_keys(metadata)
+    _check_metadata_values(metadata)
+    _check_metadata_campaign_name(metadata, expected_name=campaign_name)
+    _check_metadata_data_source(metadata, expected_name=data_source)
+    _check_metadata_station_name(metadata, expected_name=station_name)
+    _check_metadata_sensor_name(metadata)
+    _check_metadata_measurement_interval(metadata)
+    check_station_metadata_geolocation(metadata, raise_error_if_unknown=False)
+    check_metadata_reader(metadata)
+
+
+def check_metadata_archive(metadata_archive_dir: Optional[str] = None, raise_error=False):
+    """Check the archive metadata compliance.
 
     Parameters
     ----------
@@ -312,6 +271,9 @@ def check_metadata_archive_campaign_name(metadata_archive_dir: Optional[str] = N
         The directory path must end with ``<...>/DISDRODB``.
         If ``None``, it uses the ``metadata_archive_dir`` path specified
         in the DISDRODB active configuration.
+    raise_error: bool (optional)
+        Whether to raise an error and interrupt the archive check if a
+        metadata is not compliant. The default value is ``False``.
 
     Returns
     -------
@@ -332,24 +294,74 @@ def check_metadata_archive_campaign_name(metadata_archive_dir: Optional[str] = N
         data_source = infer_data_source_from_path(filepath)
         campaign_name = infer_campaign_name_from_path(filepath)
         station_name = os.path.basename(filepath).replace(".yml", "")
-
-        metadata = read_station_metadata(
-            metadata_archive_dir=metadata_archive_dir,
-            data_source=data_source,
-            campaign_name=campaign_name,
-            station_name=station_name,
-        )
+        # Check compliance
         try:
-            _check_metadata_campaign_name(metadata, expected_name=campaign_name)
+            check_station_metadata(
+                metadata_archive_dir=metadata_archive_dir,
+                data_source=data_source,
+                campaign_name=campaign_name,
+                station_name=station_name,
+            )
         except Exception as e:
             is_valid = False
-            print(f"Error for {data_source} {campaign_name} {station_name}.")
-            print(f"The error is: {e}.")
+            msg = f"Error for {data_source} {campaign_name} {station_name}."
+            msg = msg + f"The error is: {e}."
+            if raise_error:
+                raise ValueError(msg)
+            print(msg)
+
     return is_valid
 
 
-def check_metadata_archive_data_source(metadata_archive_dir: Optional[str] = None) -> bool:
-    """Check metadata ``data_source``.
+####-----------------------------------------------------------------------------------------------.
+#### Utilities
+
+
+def identify_missing_metadata_coords(metadata_filepaths: str) -> None:
+    """Identify missing coordinates.
+
+    Parameters
+    ----------
+    metadata_filepaths : str
+        Input YAML file path.
+
+    Raises
+    ------
+    TypeError
+        Error if ``latitude`` or ``longitude`` coordinates are not present or are wrongly formatted.
+
+    """
+    for filepath in metadata_filepaths:
+        metadata = read_yaml(filepath)
+        check_station_metadata_geolocation(metadata)
+
+
+def identify_empty_metadata_keys(metadata_filepaths: list, keys: Union[str, list]) -> None:
+    """Identify empty metadata keys.
+
+    Parameters
+    ----------
+    metadata_filepaths : str
+        Input YAML file path.
+    keys : Union[str,list]
+        Attributes to verify the presence.
+    """
+    if isinstance(keys, str):
+        keys = [keys]
+
+    for filepath in metadata_filepaths:
+        for key in keys:
+            metadata = read_yaml(filepath)
+            if len(str(metadata.get(key, ""))) == 0:  # ensure is string to avoid error
+                print(f"Empty {key} at: ", filepath)
+
+
+#### --------------------------------------------------------------------------.
+#### Metadata Archive Utilities
+
+
+def check_metadata_archive_keys(metadata_archive_dir: Optional[str] = None) -> bool:
+    """Check that all metadata files have valid keys.
 
     Parameters
     ----------
@@ -386,16 +398,17 @@ def check_metadata_archive_data_source(metadata_archive_dir: Optional[str] = Non
             station_name=station_name,
         )
         try:
-            _check_metadata_data_source(metadata, expected_name=data_source)
+            _check_metadata_keys(metadata)
         except Exception as e:
-            is_valid = False
             print(f"Error for {data_source} {campaign_name} {station_name}.")
             print(f"The error is: {e}.")
+            is_valid = False
+
     return is_valid
 
 
-def check_metadata_archive_sensor_name(metadata_archive_dir: Optional[str] = None) -> bool:
-    """Check metadata ``sensor_name``.
+def check_metadata_archive_campaign_name(metadata_archive_dir: Optional[str] = None) -> bool:
+    """Check metadata ``campaign_name``.
 
     Parameters
     ----------
@@ -432,7 +445,7 @@ def check_metadata_archive_sensor_name(metadata_archive_dir: Optional[str] = Non
             station_name=station_name,
         )
         try:
-            _check_metadata_sensor_name(metadata)
+            _check_metadata_campaign_name(metadata, expected_name=campaign_name)
         except Exception as e:
             is_valid = False
             print(f"Error for {data_source} {campaign_name} {station_name}.")
@@ -440,8 +453,8 @@ def check_metadata_archive_sensor_name(metadata_archive_dir: Optional[str] = Non
     return is_valid
 
 
-def check_metadata_archive_station_name(metadata_archive_dir: Optional[str] = None) -> bool:
-    """Check metadata ``station_name``.
+def check_metadata_archive_data_source(metadata_archive_dir: Optional[str] = None) -> bool:
+    """Check metadata ``data_source``.
 
     Parameters
     ----------
@@ -478,7 +491,7 @@ def check_metadata_archive_station_name(metadata_archive_dir: Optional[str] = No
             station_name=station_name,
         )
         try:
-            _check_metadata_station_name(metadata, expected_name=station_name)
+            _check_metadata_data_source(metadata, expected_name=data_source)
         except Exception as e:
             is_valid = False
             print(f"Error for {data_source} {campaign_name} {station_name}.")
@@ -486,8 +499,8 @@ def check_metadata_archive_station_name(metadata_archive_dir: Optional[str] = No
     return is_valid
 
 
-def check_metadata_archive_reader(metadata_archive_dir: Optional[str] = None) -> bool:
-    """Check if the ``reader`` key is available and there is the associated reader.
+def check_metadata_archive_sensor_name(metadata_archive_dir: Optional[str] = None) -> bool:
+    """Check metadata ``sensor_name``.
 
     Parameters
     ----------
@@ -502,8 +515,6 @@ def check_metadata_archive_reader(metadata_archive_dir: Optional[str] = None) ->
     bool
         If the check succeeds, the result is ``True``, otherwise ``False``.
     """
-    from disdrodb.l0.l0_reader import check_metadata_reader
-
     is_valid = True
     metadata_archive_dir = get_metadata_archive_dir(metadata_archive_dir)
     list_metadata_paths = get_list_metadata(
@@ -526,7 +537,7 @@ def check_metadata_archive_reader(metadata_archive_dir: Optional[str] = None) ->
             station_name=station_name,
         )
         try:
-            check_metadata_reader(metadata)
+            _check_metadata_sensor_name(metadata)
         except Exception as e:
             is_valid = False
             print(f"Error for {data_source} {campaign_name} {station_name}.")
@@ -534,8 +545,8 @@ def check_metadata_archive_reader(metadata_archive_dir: Optional[str] = None) ->
     return is_valid
 
 
-def check_metadata_archive(metadata_archive_dir: Optional[str] = None, raise_error=False):
-    """Check the archive metadata compliance.
+def check_metadata_archive_station_name(metadata_archive_dir: Optional[str] = None) -> bool:
+    """Check metadata ``station_name``.
 
     Parameters
     ----------
@@ -544,9 +555,6 @@ def check_metadata_archive(metadata_archive_dir: Optional[str] = None, raise_err
         The directory path must end with ``<...>/DISDRODB``.
         If ``None``, it uses the ``metadata_archive_dir`` path specified
         in the DISDRODB active configuration.
-    raise_error: bool (optional)
-        Whether to raise an error and interrupt the archive check if a
-        metadata is not compliant. The default value is ``False``.
 
     Returns
     -------
@@ -567,27 +575,24 @@ def check_metadata_archive(metadata_archive_dir: Optional[str] = None, raise_err
         data_source = infer_data_source_from_path(filepath)
         campaign_name = infer_campaign_name_from_path(filepath)
         station_name = os.path.basename(filepath).replace(".yml", "")
-        # Check compliance
+
+        metadata = read_station_metadata(
+            metadata_archive_dir=metadata_archive_dir,
+            data_source=data_source,
+            campaign_name=campaign_name,
+            station_name=station_name,
+        )
         try:
-            check_station_metadata(
-                metadata_archive_dir=metadata_archive_dir,
-                data_source=data_source,
-                campaign_name=campaign_name,
-                station_name=station_name,
-            )
+            _check_metadata_station_name(metadata, expected_name=station_name)
         except Exception as e:
             is_valid = False
-            msg = f"Error for {data_source} {campaign_name} {station_name}."
-            msg = msg + f"The error is: {e}."
-            if raise_error:
-                raise ValueError(msg)
-            print(msg)
-
+            print(f"Error for {data_source} {campaign_name} {station_name}.")
+            print(f"The error is: {e}.")
     return is_valid
 
 
-def check_metadata_archive_geolocation(metadata_archive_dir: Optional[str] = None):
-    """Check the metadata files have missing or wrong geolocation..
+def check_metadata_archive_reader(metadata_archive_dir: Optional[str] = None) -> bool:
+    """Check if the ``reader`` key is available and there is the associated reader.
 
     Parameters
     ----------
@@ -602,6 +607,8 @@ def check_metadata_archive_geolocation(metadata_archive_dir: Optional[str] = Non
     bool
         If the check succeeds, the result is ``True``, otherwise ``False``.
     """
+    from disdrodb.l0.l0_reader import check_metadata_reader
+
     is_valid = True
     metadata_archive_dir = get_metadata_archive_dir(metadata_archive_dir)
     list_metadata_paths = get_list_metadata(
@@ -624,9 +631,9 @@ def check_metadata_archive_geolocation(metadata_archive_dir: Optional[str] = Non
             station_name=station_name,
         )
         try:
-            check_station_metadata_geolocation(metadata)
+            check_metadata_reader(metadata)
         except Exception as e:
             is_valid = False
-            print(f"Missing information for {data_source} {campaign_name} {station_name}.")
+            print(f"Error for {data_source} {campaign_name} {station_name}.")
             print(f"The error is: {e}.")
     return is_valid

disdrodb/metadata/geolocation.py

@@ -60,8 +60,6 @@ def infer_altitude(latitude, longitude, dem="aster30m"):
     ----------
     https://www.opentopodata.org/api/
     """
-    import requests
-
     url = f"https://api.opentopodata.org/v1/{dem}?locations={latitude},{longitude}"
     r = requests.get(url)