devflow-engine 1.2.1__py3-none-any.whl → 1.2.3__py3-none-any.whl

devflow_engine/errors/error_solver_dag.py

@@ -151,6 +151,34 @@ def _proof_candidate(verification: dict[str, Any] | None) -> dict[str, Any]:
     return {}
 
 
+def _observation_fix_proof(context: dict[str, Any]) -> dict[str, Any]:
+    build_observability = context.get("BuildObservability")
+    if not isinstance(build_observability, dict):
+        return {}
+    output = build_observability.get("output")
+    if not isinstance(output, dict):
+        return {}
+    observation = output.get("observation")
+    if not isinstance(observation, dict):
+        return {}
+    proof = observation.get("fix_proof")
+    return proof if isinstance(proof, dict) else {}
+
+
+def _verification_with_observed_fix_proof(
+    verification: dict[str, Any] | None,
+    context: dict[str, Any],
+) -> dict[str, Any] | None:
+    if _proof_candidate(verification):
+        return verification
+    observed_proof = _observation_fix_proof(context)
+    if not observed_proof:
+        return verification
+    merged = dict(verification or {})
+    merged["fix_proof"] = observed_proof
+    return merged
+
+
 def _resolve_artifact_path(repo_root: Path, artifact_path: Any) -> Path | None:
     raw = str(artifact_path or "").strip()
     if not raw:
@@ -216,7 +244,23 @@ def _validate_ui_fix_proof(
     return True, normalized, None
 
 
-def _validate_ui_observability_repro(observation: dict[str, Any]) -> tuple[bool, str | None]:
+def _artifact_under_observability_sandbox(artifact: str, *, error_task_id: str) -> bool:
+    normalized = artifact.replace("\\", "/").strip()
+    allowed_prefixes = (
+        f".devflow/observability/{error_task_id}/",
+        ".devflow/observability/<id>/",
+    )
+    if any(normalized.startswith(prefix) for prefix in allowed_prefixes):
+        return True
+    marker = f"/.devflow/observability/{error_task_id}/"
+    return marker in normalized
+
+
+def _validate_ui_observability_repro(
+    observation: dict[str, Any],
+    *,
+    error_task_id: str,
+) -> tuple[bool, str | None]:
     artifact = str(observation.get("repro_artifact_path") or "").strip()
     command = str(observation.get("repro_run_command") or "").strip()
     output = str(observation.get("repro_output") or "").strip()
@@ -228,6 +272,8 @@ def _validate_ui_observability_repro(observation: dict[str, Any]) -> tuple[bool,
         return False, "ui_observability_missing_playwright_repro_artifact"
     if "playwright" not in command.lower():
         return False, "ui_observability_requires_playwright_repro_command"
+    if not _artifact_under_observability_sandbox(artifact, error_task_id=error_task_id):
+        return False, "ui_observability_repro_artifact_outside_sandbox"
     if not output:
         return False, "ui_observability_missing_repro_output"
     if not isinstance(oracles, list) or not any(str(o or "").strip() for o in oracles):
@@ -848,7 +894,10 @@ class BuildObservabilityNode(Node):
                     else {}
                 )
                 if observed_flag and _ui_proof_required({"runtimeContext": user_report_context_for_ui}):
-                    ui_repro_ok, ui_repro_failure_reason = _validate_ui_observability_repro(observation)
+                    ui_repro_ok, ui_repro_failure_reason = _validate_ui_observability_repro(
+                        observation,
+                        error_task_id=error_task_id,
+                    )
 
                 # Split deferred questions via LLM classifier (v1.1.22).
                 # An injectable hook is used when present so tests can
@@ -1138,6 +1187,10 @@ class ResolveNode(Node):
         error_task_id = task_context.event.error_task_id
 
         verification = task_context.metadata.get("verification")
+        effective_verification = _verification_with_observed_fix_proof(
+            verification if isinstance(verification, dict) else None,
+            context,
+        )
         # Red-before-fix invariant: ResolveNode refuses to mark resolved
         # unless BuildObservability persisted observable=True at intake.
         # Closes the "already-green-at-intake" leak — a green-gate True with
@@ -1147,14 +1200,14 @@ class ResolveNode(Node):
         if isinstance(bo, dict):
             bo_out = bo.get("output") if isinstance(bo.get("output"), dict) else {}
             observation_was_red = bool(bo_out.get("observable"))
-        green_gate = bool((verification or {}).get("green_gate"))
+        green_gate = bool((effective_verification or {}).get("green_gate"))
         proof_verified = True
         fix_proof: dict[str, Any] | None = None
         proof_failure_reason: str | None = None
         if _ui_proof_required(context):
             proof_verified, fix_proof, proof_failure_reason = _validate_ui_fix_proof(
                 repo_root=persistor.repo_root,
-                verification=verification if isinstance(verification, dict) else None,
+                verification=effective_verification if isinstance(effective_verification, dict) else None,
             )
         verified = green_gate and observation_was_red and proof_verified
         runtime_context = context.get("runtimeContext") if isinstance(context.get("runtimeContext"), dict) else None
@@ -1165,13 +1218,13 @@ class ResolveNode(Node):
             fingerprint = runtime_context.get("fingerprint") or current_record.get("fingerprint")
         title = context.get("metadata", {}).get("title") if isinstance(context.get("metadata"), dict) else None
 
-        resolve_output: dict[str, Any] = {"verification": verification, "verified": verified}
+        resolve_output: dict[str, Any] = {"verification": effective_verification, "verified": verified}
         if proof_failure_reason:
             resolve_output["proof_failure_reason"] = proof_failure_reason
         if fix_proof:
             resolve_output["fix_proof"] = fix_proof
         persistor.persist(context=context, node_name="Resolve", output=resolve_output)
-        self.save_output(ResolveNode.OutputType(verified=verified, verification=verification))
+        self.save_output(ResolveNode.OutputType(verified=verified, verification=effective_verification))
 
         if verified:
             if fix_proof:
@@ -1185,7 +1238,7 @@ class ResolveNode(Node):
                 persistor.repo_root,
                 error_task_id=error_task_id,
                 title=str(title) if title is not None else None,
-                verification=verification,
+                verification=effective_verification if isinstance(effective_verification, dict) else None,
             )
             task_context.metadata["commit_result"] = commit_result
             # v1.1.19: persist resolution_commit_sha + portal_token so the
@@ -1228,7 +1281,7 @@ class ResolveNode(Node):
             outcome=str(task_context.metadata.get("outcome") or "in_progress"),
             title=str(title) if title is not None else None,
             fingerprint=str(fingerprint) if fingerprint is not None else None,
-            verification=verification,
+            verification=effective_verification if isinstance(effective_verification, dict) else None,
             reason=str(task_context.metadata.get("reason")) if task_context.metadata.get("reason") else None,
             context_path=persistor.context_path,
             runtime_context=runtime_context,

{devflow_engine-1.2.1.dist-info → devflow_engine-1.2.3.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: devflow-engine
-Version: 1.2.1
+Version: 1.2.3
 Summary: DevFlow v2 CLI-first engine (projects, stories, execution store, review packets)
 Author: DevFlow
 License: Proprietary

{devflow_engine-1.2.1.dist-info → devflow_engine-1.2.3.dist-info}/RECORD

@@ -32,7 +32,7 @@ devflow_engine/devin2/agent_definition.py,sha256=pCp915tojwPlepRpvjlU1DoPuT_anxR
 devflow_engine/devin2/pi_runner.py,sha256=xRl-qA3RgMFgiR5fnG6fTwwL95PMk6zVdRdFa-fXy2E,7466
 devflow_engine/error/__init__.py,sha256=47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU,0
 devflow_engine/error/remediation.py,sha256=Z4LJQzZPzb7_6tea_XtasDvFYQiEdpkFlyxoCEO1I2k,548
-devflow_engine/errors/error_solver_dag.py,sha256=9SQT74F485gJvN0h0fXojd6kGU4YJxt2g4tsio9LKCQ,58180
+devflow_engine/errors/error_solver_dag.py,sha256=GZXVqssgqUgoqRqA5r7_fnz7noZVKD-g3NS5r0ShBms,60195
 devflow_engine/errors/question_classifier.py,sha256=oBJ29hszG--TUna62BQHnNmi6hPwf-wEE8eGLmgS624,9729
 devflow_engine/errors/repo_quality_judge.py,sha256=LVBaXN6AsID-x8qb-IriQKYY1c9AMMRNo-tWMeiuMaA,9962
 devflow_engine/errors/runtime_observability.py,sha256=Do93Ah3vxLEocYtC0JpnRIRQN6uNAOkYjBz0pmOqg5g,29719
@@ -382,7 +382,7 @@ devflow_engine/prompts/source_doc_mutation/source_doc_enrichment_coherence/promp
 devflow_engine/prompts/source_doc_mutation/user_workflows/prompt.md,sha256=2Bv-EkZwzxtPSsDGdw9YuuuzT1c_2R9c6HPSMdP-MD0,406
 devflow_engine/prompts/source_scope/doctrine/prompt.md,sha256=AJk1gfePTdaBSw5DHvCr7Sigsk2orGaRVNZ3Dj3NdcQ,837
 devflow_engine/prompts/ui_grounding/doctrine/prompt.md,sha256=0L5y-QjjquPABqxAHZNPkcjyHMZQSDRVncNDQa2app0,409
-devflow_engine-1.2.1.dist-info/METADATA,sha256=y30DsM64igxG19kjixCV0h-RN0NbLptfTWThXz4AbXQ,7755
-devflow_engine-1.2.1.dist-info/WHEEL,sha256=mffPy8wBnZQn2VnJUU5jE99KsxaSfiyMHV9Yt0aLVxs,87
-devflow_engine-1.2.1.dist-info/entry_points.txt,sha256=U5Pw4y4v4u4xcRS5DbXfemBg0RKp74kMxcnEoL0MACY,99
-devflow_engine-1.2.1.dist-info/RECORD,,
+devflow_engine-1.2.3.dist-info/METADATA,sha256=spmTNfOipkpqYWkJx_uOVJjLtfYG_ZZ9PBs6aOWSjDM,7755
+devflow_engine-1.2.3.dist-info/WHEEL,sha256=lCkmxWfQsSc9CfIClYeavTdQeEX2toPqufh9gI35EQA,87
+devflow_engine-1.2.3.dist-info/entry_points.txt,sha256=U5Pw4y4v4u4xcRS5DbXfemBg0RKp74kMxcnEoL0MACY,99
+devflow_engine-1.2.3.dist-info/RECORD,,

{devflow_engine-1.2.1.dist-info → devflow_engine-1.2.3.dist-info}/WHEEL

@@ -1,4 +1,4 @@
 Wheel-Version: 1.0
-Generator: hatchling 1.30.1
+Generator: hatchling 1.31.0
 Root-Is-Purelib: true
 Tag: py3-none-any