deltacat 1.1.8__py3-none-any.whl → 1.1.10__py3-none-any.whl

deltacat/tests/compute/test_compact_partition_rebase.py

@@ -0,0 +1,289 @@
+import ray
+import os
+from moto import mock_s3
+import pytest
+import boto3
+from boto3.resources.base import ServiceResource
+import pyarrow as pa
+from deltacat.io.ray_plasma_object_store import RayPlasmaObjectStore
+from pytest_benchmark.fixture import BenchmarkFixture
+
+from deltacat.tests.compute.test_util_constant import (
+    TEST_S3_RCF_BUCKET_NAME,
+    DEFAULT_NUM_WORKERS,
+    DEFAULT_WORKER_INSTANCE_CPUS,
+)
+from deltacat.compute.compactor.model.compactor_version import CompactorVersion
+from deltacat.tests.compute.test_util_common import (
+    get_compacted_delta_locator_from_rcf,
+)
+from deltacat.tests.compute.test_util_create_table_deltas_repo import (
+    create_src_w_deltas_destination_rebase_w_deltas_strategy,
+)
+from deltacat.tests.compute.compact_partition_rebase_test_cases import (
+    REBASE_TEST_CASES,
+)
+from typing import Any, Callable, Dict, List, Optional, Set
+from deltacat.types.media import StorageType
+from deltacat.storage import (
+    DeltaLocator,
+    Partition,
+)
+from deltacat.types.media import ContentType
+from deltacat.compute.compactor.model.compact_partition_params import (
+    CompactPartitionParams,
+)
+from deltacat.utils.placement import (
+    PlacementGroupManager,
+)
+
+DATABASE_FILE_PATH_KEY, DATABASE_FILE_PATH_VALUE = (
+    "db_file_path",
+    "deltacat/tests/local_deltacat_storage/db_test.sqlite",
+)
+
+
+"""
+MODULE scoped fixtures
+"""
+
+
+@pytest.fixture(autouse=True, scope="module")
+def setup_ray_cluster():
+    ray.init(local_mode=True, ignore_reinit_error=True)
+    yield
+    ray.shutdown()
+
+
+@pytest.fixture(autouse=True, scope="module")
+def mock_aws_credential():
+    os.environ["AWS_ACCESS_KEY_ID"] = "testing"
+    os.environ["AWS_SECRET_ACCESS_ID"] = "testing"
+    os.environ["AWS_SECURITY_TOKEN"] = "testing"
+    os.environ["AWS_SESSION_TOKEN"] = "testing"
+    os.environ["AWS_DEFAULT_REGION"] = "us-east-1"
+    yield
+
+
+@pytest.fixture(autouse=True, scope="module")
+def cleanup_the_database_file_after_all_compaction_session_package_tests_complete():
+    # make sure the database file is deleted after all the compactor package tests are completed
+    if os.path.exists(DATABASE_FILE_PATH_VALUE):
+        os.remove(DATABASE_FILE_PATH_VALUE)
+
+
+@pytest.fixture(scope="module")
+def s3_resource(mock_aws_credential):
+    with mock_s3():
+        yield boto3.resource("s3")
+
+
+@pytest.fixture(autouse=True, scope="module")
+def setup_compaction_artifacts_s3_bucket(s3_resource: ServiceResource):
+    s3_resource.create_bucket(
+        ACL="authenticated-read",
+        Bucket=TEST_S3_RCF_BUCKET_NAME,
+    )
+    yield
+
+
+"""
+FUNCTION scoped fixtures
+"""
+
+
+@pytest.fixture(scope="function")
+def local_deltacat_storage_kwargs(request: pytest.FixtureRequest):
+    # see deltacat/tests/local_deltacat_storage/README.md for documentation
+    kwargs_for_local_deltacat_storage: Dict[str, Any] = {
+        DATABASE_FILE_PATH_KEY: DATABASE_FILE_PATH_VALUE,
+    }
+    yield kwargs_for_local_deltacat_storage
+    if os.path.exists(DATABASE_FILE_PATH_VALUE):
+        os.remove(DATABASE_FILE_PATH_VALUE)
+
+
+@pytest.mark.parametrize(
+    [
+        "test_name",
+        "primary_keys",
+        "sort_keys",
+        "partition_keys_param",
+        "partition_values_param",
+        "input_deltas_param",
+        "input_deltas_delta_type",
+        "expected_terminal_compact_partition_result",
+        "expected_terminal_exception",
+        "expected_terminal_exception_message",
+        "create_placement_group_param",
+        "records_per_compacted_file_param",
+        "hash_bucket_count_param",
+        "read_kwargs_provider_param",
+        "drop_duplicates_param",
+        "skip_enabled_compact_partition_drivers",
+        "rebase_expected_compact_partition_result",
+        "compact_partition_func",
+    ],
+    [
+        (
+            test_name,
+            primary_keys,
+            sort_keys,
+            partition_keys_param,
+            partition_values_param,
+            input_deltas,
+            input_deltas_delta_type,
+            expected_terminal_compact_partition_result,
+            expected_terminal_exception,
+            expected_terminal_exception_message,
+            create_placement_group_param,
+            records_per_compacted_file_param,
+            hash_bucket_count_param,
+            drop_duplicates_param,
+            read_kwargs_provider,
+            skip_enabled_compact_partition_drivers,
+            rebase_expected_compact_partition_result,
+            compact_partition_func,
+        )
+        for test_name, (
+            primary_keys,
+            sort_keys,
+            partition_keys_param,
+            partition_values_param,
+            input_deltas,
+            input_deltas_delta_type,
+            expected_terminal_compact_partition_result,
+            expected_terminal_exception,
+            expected_terminal_exception_message,
+            create_placement_group_param,
+            records_per_compacted_file_param,
+            hash_bucket_count_param,
+            drop_duplicates_param,
+            read_kwargs_provider,
+            skip_enabled_compact_partition_drivers,
+            rebase_expected_compact_partition_result,
+            compact_partition_func,
+        ) in REBASE_TEST_CASES.items()
+    ],
+    ids=[test_name for test_name in REBASE_TEST_CASES],
+)
+def test_compact_partition_rebase_same_source_and_destination(
+    mocker,
+    s3_resource: ServiceResource,
+    local_deltacat_storage_kwargs: Dict[str, Any],
+    test_name: str,
+    primary_keys: Set[str],
+    sort_keys: List[Optional[Any]],
+    partition_keys_param: Optional[List[Any]],
+    partition_values_param: List[Optional[str]],
+    input_deltas_param: List[pa.Array],
+    input_deltas_delta_type: str,
+    expected_terminal_compact_partition_result: pa.Table,
+    expected_terminal_exception: BaseException,
+    expected_terminal_exception_message: Optional[str],
+    create_placement_group_param: bool,
+    records_per_compacted_file_param: int,
+    hash_bucket_count_param: int,
+    drop_duplicates_param: bool,
+    read_kwargs_provider_param: Any,
+    rebase_expected_compact_partition_result: pa.Table,
+    skip_enabled_compact_partition_drivers: List[CompactorVersion],
+    compact_partition_func: Callable,
+    benchmark: BenchmarkFixture,
+):
+    import deltacat.tests.local_deltacat_storage as ds
+
+    ds_mock_kwargs = local_deltacat_storage_kwargs
+    """
+    This test tests the scenario where source partition locator == destination partition locator,
+    but rebase source partition locator is different.
+    This scenario could occur when hash bucket count changes.
+    """
+    partition_keys = partition_keys_param
+    (
+        source_table_stream,
+        _,
+        rebased_table_stream,
+    ) = create_src_w_deltas_destination_rebase_w_deltas_strategy(
+        primary_keys,
+        sort_keys,
+        partition_keys,
+        input_deltas_param,
+        input_deltas_delta_type,
+        partition_values_param,
+        ds_mock_kwargs,
+    )
+    source_partition: Partition = ds.get_partition(
+        source_table_stream.locator,
+        partition_values_param,
+        **ds_mock_kwargs,
+    )
+    rebased_partition: Partition = ds.get_partition(
+        rebased_table_stream.locator,
+        partition_values_param,
+        **ds_mock_kwargs,
+    )
+    num_workers, worker_instance_cpu = DEFAULT_NUM_WORKERS, DEFAULT_WORKER_INSTANCE_CPUS
+    total_cpus = num_workers * worker_instance_cpu
+    pgm = None
+    create_placement_group_param = False
+    if create_placement_group_param:
+        pgm = PlacementGroupManager(
+            1, total_cpus, worker_instance_cpu, memory_per_bundle=4000000
+        ).pgs[0]
+    compact_partition_params = CompactPartitionParams.of(
+        {
+            "compaction_artifact_s3_bucket": TEST_S3_RCF_BUCKET_NAME,
+            "compacted_file_content_type": ContentType.PARQUET,
+            "dd_max_parallelism_ratio": 1.0,
+            "deltacat_storage": ds,
+            "deltacat_storage_kwargs": ds_mock_kwargs,
+            "destination_partition_locator": rebased_partition.locator,
+            "hash_bucket_count": hash_bucket_count_param,
+            "last_stream_position_to_compact": source_partition.stream_position,
+            "list_deltas_kwargs": {**ds_mock_kwargs, **{"equivalent_table_types": []}},
+            "object_store": RayPlasmaObjectStore(),
+            "pg_config": pgm,
+            "primary_keys": primary_keys,
+            "read_kwargs_provider": read_kwargs_provider_param,
+            "rebase_source_partition_locator": source_partition.locator,
+            "records_per_compacted_file": records_per_compacted_file_param,
+            "s3_client_kwargs": {},
+            "source_partition_locator": rebased_partition.locator,
+            "sort_keys": sort_keys if sort_keys else None,
+        }
+    )
+
+    from deltacat.compute.compactor_v2.model.evaluate_compaction_result import (
+        ExecutionCompactionResult,
+    )
+
+    execute_compaction_result_spy = mocker.spy(ExecutionCompactionResult, "__init__")
+
+    # execute
+    rcf_file_s3_uri = compact_partition_func(compact_partition_params)
+
+    # Assert not in-place compacted
+    assert (
+        execute_compaction_result_spy.call_args.args[-1] is False
+    ), "Table version erroneously marked as in-place compacted!"
+    compacted_delta_locator: DeltaLocator = get_compacted_delta_locator_from_rcf(
+        s3_resource, rcf_file_s3_uri
+    )
+    tables = ds.download_delta(
+        compacted_delta_locator, storage_type=StorageType.LOCAL, **ds_mock_kwargs
+    )
+    actual_rebase_compacted_table = pa.concat_tables(tables)
+    # if no primary key is specified then sort by sort_key for consistent assertion
+    sorting_cols: List[Any] = (
+        [(val, "ascending") for val in primary_keys] if primary_keys else sort_keys
+    )
+    rebase_expected_compact_partition_result = (
+        rebase_expected_compact_partition_result.combine_chunks().sort_by(sorting_cols)
+    )
+    actual_rebase_compacted_table = (
+        actual_rebase_compacted_table.combine_chunks().sort_by(sorting_cols)
+    )
+    assert actual_rebase_compacted_table.equals(
+        rebase_expected_compact_partition_result
+    ), f"{actual_rebase_compacted_table} does not match {rebase_expected_compact_partition_result}"

deltacat/tests/compute/test_util_common.py

@@ -24,6 +24,12 @@ from deltacat.compute.compactor import (
     RoundCompletionInfo,
 )
 
+from deltacat.storage.model.partition import PartitionLocator
+from deltacat.storage.model.stream import StreamLocator
+from deltacat.storage.model.table_version import TableVersionLocator
+from deltacat.storage.model.table import TableLocator
+from deltacat.storage.model.namespace import NamespaceLocator
+
 
 class PartitionKeyType(str, Enum):
     INT = "int"
@@ -51,6 +57,18 @@ UTILS
 """
 
 
+def get_test_partition_locator(partition_id):
+    tv_locator = TableVersionLocator.of(
+        TableLocator.of(NamespaceLocator.of("default"), "test_table"), "1"
+    )
+    stream_locator = StreamLocator.of(tv_locator, "test_stream_id", "local")
+    partition_locator = PartitionLocator.of(
+        stream_locator, partition_id=partition_id, partition_values=[]
+    )
+
+    return partition_locator
+
+
 def _create_table(
     namespace: str,
     table_name: str,
@@ -140,7 +158,7 @@ def create_rebase_table(
 def get_rcf(s3_resource, rcf_file_s3_uri: str) -> RoundCompletionInfo:
     from deltacat.tests.test_utils.utils import read_s3_contents
 
-    _, rcf_object_key = rcf_file_s3_uri.rsplit("/", 1)
+    _, rcf_object_key = rcf_file_s3_uri.strip("s3://").split("/", 1)
     rcf_file_output: Dict[str, Any] = read_s3_contents(
         s3_resource, TEST_S3_RCF_BUCKET_NAME, rcf_object_key
     )
@@ -151,9 +169,6 @@ def get_compacted_delta_locator_from_rcf(
     s3_resource: ServiceResource, rcf_file_s3_uri: str
 ):
     from deltacat.storage import DeltaLocator
-    from deltacat.compute.compactor import (
-        RoundCompletionInfo,
-    )
 
     round_completion_info: RoundCompletionInfo = get_rcf(s3_resource, rcf_file_s3_uri)
 

deltacat/tests/compute/test_util_create_table_deltas_repo.py

@@ -251,6 +251,7 @@ def create_src_w_deltas_destination_rebase_w_deltas_strategy(
     ds.commit_partition(staged_partition, **ds_mock_kwargs)
 
     # get streams
+    # TODO: Add deltas to destination stream
     destination_table_stream: Stream = ds.get_stream(
         namespace=destination_table_namespace,
         table_name=destination_table_name,

deltacat/tests/io/test_memcached_object_store.py

@@ -1,6 +1,9 @@
 import unittest
 import numpy as np
 from unittest import mock
+from deltacat.exceptions import (
+    PymemcachedPutObjectError,
+)
 
 
 class MockPyMemcacheClient:
@@ -86,7 +89,7 @@ class TestMemcachedObjectStore(unittest.TestCase):
         mock_retrying_client.return_value = mock_client.return_value
         mock_client.return_value.set_many.return_value = ["abcd"]
 
-        with self.assertRaises(RuntimeError):
+        with self.assertRaises(PymemcachedPutObjectError):
             self.object_store.put_many(["a", "b"])
 
         self.assertEqual(1, mock_client.return_value.set_many.call_count)
@@ -169,7 +172,7 @@ class TestMemcachedObjectStore(unittest.TestCase):
         mock_client.return_value.set.return_value = False
         mock_retrying_client.return_value = mock_client.return_value
 
-        with self.assertRaises(RuntimeError):
+        with self.assertRaises(PymemcachedPutObjectError):
             self.object_store.put("test_ip")
 
         self.assertEqual(1, mock_client.return_value.set.call_count)