dataface 0.3.1.dev22__py3-none-any.whl → 0.3.1.dev42__py3-none-any.whl

dataface/ai/llm.py

@@ -326,7 +326,11 @@ class OpenAIClient:
             "stream": True,
         }
         if _supports_reasoning_summaries(self.model):
-            kwargs["reasoning"] = {"summary": "auto"}
+            # Effort must be explicit. Left to its default, gpt-5.x emits no
+            # reasoning items at all, and "summary" then has nothing to
+            # summarize — the UI is stuck on a generic "Thinking...". Medium is
+            # the lowest level that actually produces summaries.
+            kwargs["reasoning"] = {"effort": "medium", "summary": "auto"}
 
         logger.info("llm_stream_begin model=%s", self.model)
         started = time.monotonic()

dataface/ai/skills/analyst-runbook/SKILL.md

@@ -35,6 +35,13 @@ whenever one fits — and say which you reused.{{/if_tool}}
 2. **Clarify only what blocks you.** If the metric, grain, time window, or filters
    are ambiguous *and* the choice changes the answer, ask one focused question.
    Otherwise state the assumption and proceed.
+3. **Open with the plan.** One or two sentences naming the deliverable and the
+   data you are about to go look at ("I'll pull ticket volume and resolution
+   time by priority and put them side by side"), written before you start the
+   work. Hosts collapse tool activity behind a single row, so without this the
+   reader watches a spinner with nothing to read. Write it once, then work —
+   this is not a play-by-play of each tool call, and it does not replace the
+   read in step 4.
 
 ## 2. Do the analysis
 

dataface/core/defaults/themes/_base.yaml

@@ -60,16 +60,18 @@ style:
     card_gap: 8.0
 
   font:
-    # Body floor 11px. Anchored — referenced by style.text.font.size,
-    # style.title.subtitle.font.size, style.variables.font.size below.
+    # Chrome floor 11px. Anchored — referenced by style.title.subtitle.font.size
+    # and style.variables.font.size below. Body prose is NOT one of them; it has
+    # its own size at style.text.font.size.
     size:   &size_body 11
     weight: '400'
     style: normal
     decoration: none
     case: none
     emoji: monochrome
-    # Body leading. Cascades to all text roles via Style.font InheritSlot.
-    # Title overrides tighter (1.1) in its font patch below.
+    # Chrome leading. Cascades to text roles that do not declare their own.
+    # Body prose (style.text.font) and title both declare one - prose looser at
+    # 1.4 for reading, title tighter at 1.1 for display.
     line_height: 1.25
 
   border:
@@ -855,7 +857,16 @@ style:
 
   text:
     font:
-      size:   *size_body
+      # Body prose is sized and led independently of `style.font.*` (the 11-unit
+      # dashboard-chrome floor that subtitles and variable controls share).
+      # Sustained reading wants more than a label size; 14 matches the existing
+      # series-label and H3/H4 rungs rather than introducing a new value.
+      size:   14
+      # Root 1.25 is label leading — right for axis ticks and legend entries,
+      # too tight for prose, and tighter still while the measure is uncapped and
+      # lines run the full board. Title keeps its own 1.1 for the same reason in
+      # the other direction.
+      line_height: 1.4
     align: left
     # Block margin values (in line-height units).
     # paragraph_spacing = font_size × line_height × paragraph.margin_bottom

dataface/core/render/sizing.py

@@ -491,6 +491,7 @@ def get_compact_style(
     heading_font_weight: int | str | None = None,
     font_family: str | None = None,
     h1_size: float | None = None,
+    heading_margin_scale: Literal["prose", "chrome"] = "prose",
 ) -> Any:
     """Get a compact mdsvg Style with reduced heading margins (theme-derived colors).
 
@@ -501,7 +502,12 @@ def get_compact_style(
 
     return Style(
         **compact_style_kwargs(
-            resolved_style, text_align, heading_font_weight, font_family, h1_size
+            resolved_style,
+            text_align,
+            heading_font_weight,
+            font_family,
+            h1_size,
+            heading_margin_scale,
         )
     )
 
@@ -512,6 +518,7 @@ def compact_style_kwargs(
     heading_font_weight: int | str | None = None,
     font_family: str | None = None,
     h1_size: float | None = None,
+    heading_margin_scale: Literal["prose", "chrome"] = "prose",
 ) -> dict[str, Any]:
     """Build the ``mdsvg.Style`` kwargs from the resolved theme — the dft→mdsvg mapper.
 
@@ -550,12 +557,31 @@ def compact_style_kwargs(
 
     _text_font_size = _rs.text.font.size
     assert _text_font_size is not None, "style.text.font.size must be configured"
+    # Heading margins are in line-height units, so they need a font size to resolve
+    # against. "prose" is right for a markdown heading inside a text block — the gap
+    # under it should equal one line of the prose it introduces. "chrome" is right for
+    # a face title, which labels a card that may hold a chart, a table, or nothing
+    # textual at all: its spacing must not move when prose is resized. Chart card
+    # titles already work this way (size varies by width tier, gap does not).
+    _chrome_font_size = _rs.font.size
+    assert _chrome_font_size is not None, "style.font.size must be configured"
+    _chrome_line_height = _rs.font.line_height
+    assert _chrome_line_height is not None, "style.font.line_height must be configured"
     _text_font_weight = _rs.text.font.weight
     assert _text_font_weight is not None, "style.text.font.weight must be configured"
     _text_line_height = _rs.text.font.line_height
     assert (
         _text_line_height is not None
     ), "style.text.font.line_height must be configured"
+    # One line of the chosen scale, in px. A heading margin of 1.5 means "one and a
+    # half lines of the text this heading belongs to", so size and leading must come
+    # from the same scale — mixing prose size with chrome leading (or vice versa)
+    # silently produces a unit that matches neither.
+    _heading_margin_unit = (
+        float(_text_font_size) * float(_text_line_height)
+        if heading_margin_scale == "prose"
+        else float(_chrome_font_size) * float(_chrome_line_height)
+    )
     _title_line_height = _rs.title.font.line_height
     assert (
         _title_line_height is not None
@@ -599,11 +625,9 @@ def compact_style_kwargs(
         # mdsvg ≥ 1.0 skips paragraph_spacing on heading-adjacent transitions and
         # collapses H↔H margins to max — so heading_margin_*_px are the literal
         # visible space above / below a heading.
-        "heading_margin_top_px": float(_text_font_size)
-        * float(_text_line_height)
+        "heading_margin_top_px": _heading_margin_unit
         * float(_rs.text.heading.margin_top),
-        "heading_margin_bottom_px": float(_text_font_size)
-        * float(_text_line_height)
+        "heading_margin_bottom_px": _heading_margin_unit
         * float(_rs.text.heading.margin_bottom),
         "paragraph_spacing": float(_text_font_size)
         * float(_text_line_height)
@@ -938,6 +962,9 @@ def get_title_height(
             h1_size=h1_size,
             heading_font_weight=heading_weight,
             font_family=font_family if prose else None,
+            # Must match render_title exactly — this is the measure half of the same
+            # title block; a mismatch desyncs reserved height from drawn height.
+            heading_margin_scale="chrome",
         ),
         font_path=font_path,
         mono_font_path=str(get_mono_font_path()),

dataface/core/render/svg_utils.py

@@ -224,6 +224,8 @@ def render_title(
         h1_size=h1_size,
         heading_font_weight=heading_weight,
         font_family=font_family,
+        # Title spacing is chrome: it must not grow when body prose is resized.
+        heading_margin_scale="chrome",
     )
     font_path = get_font_path(font_path_family)
     return render_markdown(

{dataface-0.3.1.dev22.dist-info → dataface-0.3.1.dev42.dist-info}/METADATA

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: dataface
-Version: 0.3.1.dev22
+Version: 0.3.1.dev42
 Summary: Dataface - dbt-native dashboard and visualization layer
 Author: Fivetran, Inc.
 License-Expression: Apache-2.0

{dataface-0.3.1.dev22.dist-info → dataface-0.3.1.dev42.dist-info}/RECORD

@@ -35,7 +35,7 @@ dataface/ai/agent.py,sha256=6dmJg0rhoDQJx8jga26gdHTsr-ilQTKe2bMk_w1YFHY,13306
 dataface/ai/context.py,sha256=iTHYvPUm5HLR4vj7bBzXw5O6kU4yklPkp1fnqb_Qouc,1680
 dataface/ai/events.py,sha256=A76iTl8oj-iwNgDNystNyAJ6iP3NmWoDMYS0xC34c9M,1661
 dataface/ai/generate_sql.py,sha256=YLPaiZM41yva13SDBTHEuXyz9Ybh4ZeKBW74vdKMf0g,2291
-dataface/ai/llm.py,sha256=U0XXGhVHV_7w9s6o094P6ivPEqXuQjJQjM7WUyeSusU,15794
+dataface/ai/llm.py,sha256=dXuAkoaH7AU94k7_-yQqw2GjyQZ-DgUOTD0Ce-2u498,16110
 dataface/ai/messages.py,sha256=o0OTnxC_rcILCcyNsWr_oGvZIPWQyzuwXVHP6WzAAF0,3040
 dataface/ai/prompts.py,sha256=-ppxAR-GMqePMtSREUBuRfoGVzpTN0DFPB3Wsoflzpg,15067
 dataface/ai/tool_schemas.py,sha256=rHfbl42qaP4O5NWzlJmYKwk4JrtxjEO3Tm6ddOr6b9g,6030
@@ -318,7 +318,7 @@ dataface/core/defaults/palettes/tone/info.yml,sha256=pdy148P5_dCs3Bl9oyYETmEL2z-
 dataface/core/defaults/palettes/tone/negative.yml,sha256=dPls8ppZRRVFg7oTjnILaskjSM3vEbP_6_RI5_vp3HI,1375
 dataface/core/defaults/palettes/tone/positive.yml,sha256=jpT23QtxzH2KtjgR8rDQgSArPM4KMfFMzGOsratlhR0,877
 dataface/core/defaults/palettes/tone/warning.yml,sha256=Cmv_c1i0Xqzqk_QWuLu9yQmtoOySazqwTxtKVX9-QdM,890
-dataface/core/defaults/themes/_base.yaml,sha256=OhsGjOAnByiH_6ImCH2YnztNfW026MnGFVqNpBVvDXA,32978
+dataface/core/defaults/themes/_base.yaml,sha256=wFcKxYonsTzPf8XPnSDyf-gVC16yi-_cIqSDk7Tcvsk,33717
 dataface/core/defaults/themes/cream.yaml,sha256=3w1b9iGMVIZ2i0uzvNobnrjA1w5Uc-WQcxhuti2WXeY,5086
 dataface/core/defaults/themes/diagnostics-title-angle-extreme.yaml,sha256=VZxgj_MVYHlB_SJeUJKPV6MQe2e1MDj6nTKpNY0-3Lc,132
 dataface/core/defaults/themes/diagnostics-title-baseline-extreme.yaml,sha256=kt2TfoVrdKbzkYqzBzxWdOJ2albSjwemxTfehqhnyaY,141
@@ -470,9 +470,9 @@ dataface/core/render/render_result.py,sha256=0q2SQCsIGqk0FtrXBOm8GoZe-VpRQxq4Ker
 dataface/core/render/renderer.py,sha256=f-8-Ak8H-DYMjOGV0n9BLJUM9Wyhy8J4Aa-k0NLSEUI,25672
 dataface/core/render/script_embedding.py,sha256=sCx7aV4QUSczJj6mVZTZvmzX0CNwlo7s3w-cSWJk_Dw,716
 dataface/core/render/shared_y_datasets.py,sha256=BH_TgzCWdLMEVPWObG03KnH_DZSZZNCrX9izbEi97cI,1175
-dataface/core/render/sizing.py,sha256=Xaq-iFrgJUbodvp33THQf81c5RrCWeYR-rOYtaMZoUI,90881
+dataface/core/render/sizing.py,sha256=LgSRBIWE_KfVz8Lalb4crfzM8CDeFKxuDFatWIN2pgI,92491
 dataface/core/render/stable_domain.py,sha256=eaeqXmIuKJ8nymG5tVmcIuQpsM3CJbugH0qfvwR0Xzw,17767
-dataface/core/render/svg_utils.py,sha256=oyFrJ9ghNfBeNDg0JnpeBgnh2HsRQqIxVcHNKLF2EtM,7906
+dataface/core/render/svg_utils.py,sha256=JZuJjdt062reQSpKck3Jz3l55GueA-_UAyyW1ztp51g,8025
 dataface/core/render/template_loader.py,sha256=f9BgEDKLCkyhOn3cMeIBAIxt9xawWXN6CQ7HdsmOCQ4,2424
 dataface/core/render/terminal.py,sha256=6pzBo33QtskxRMo2MAhutnYnHy0kXvBwrYxrD3OAKcU,10432
 dataface/core/render/terminal_charts.py,sha256=s7zHhn7jDLgqtklFply9y-Nec33ZskW2HC0CmtfDWCc,20092
@@ -631,7 +631,7 @@ dataface/agent_api/_init_templates/meta.yaml,sha256=9I8jwiVKGCu-g3vmMtwNo6ZKBJLt
 dataface/ai/prompts/sql-guidance.md,sha256=2hwS-vR6qtdohBmf2IQlGduLwRqjkHZG7A6-TJ9bLsQ,1637
 dataface/ai/prompts/sql-system.md,sha256=L1F_Mh2BewpZU9x3UryUVHdWg1kZDC80Su_iD0x2xXk,299
 dataface/ai/prompts/system.md,sha256=ruqScPJ2UgYtnAviM6FFbeqaIQmogCbGCjl7gW48Wok,294
-dataface/ai/skills/analyst-runbook/SKILL.md,sha256=fvjr5b3ptRKOXo2mzucmcxeG6d_prEIhwsW8W7TCx9A,5089
+dataface/ai/skills/analyst-runbook/SKILL.md,sha256=p_Ob8LRF28g-dWx-vZfkJPAy05_yfd0HBuogRDa83zk,5577
 dataface/ai/skills/before-after-comparison/SKILL.md,sha256=sVUPTTlU1WdDStBELhing_XQcQpzvKFco29DceFvmPU,3276
 dataface/ai/skills/before-after-comparison/examples/before-after-comparison.yml,sha256=dybhZtXI6S8d3wRIYTyQ3sNBX7GcworjRqqL2t3QsqQ,726
 dataface/ai/skills/dashboard-build/SKILL.md,sha256=roii3eKWloflz0uiIJYrNnpbX0zVRW7xQ5dxDSgZOV4,19105
@@ -673,7 +673,7 @@ d3_format/spec.py,sha256=3We0MbSav4Mm-7pvfcZ8S7hfn7hT1vacFzBti8Y3He0,4448
 mdsvg/__init__.py,sha256=AKn9ZNNSS2w-1ROtaW3f-R6zDob4jq08HdIsKd_J5ng,3597
 mdsvg/fonts.py,sha256=jOpchxyZTl8l5qsCmGz35xBGUkInrtKBSWDpMjR5XZs,20525
 mdsvg/highlight.py,sha256=QpGEJ1nbnh7dqesOyLXCIRIaF9V19WEAPz_XdZGoEoU,3858
-mdsvg/images.py,sha256=SEANlTUSXzitU0CArb7UPa8PvH2tOmoaXK4V_V2zeH0,8908
+mdsvg/images.py,sha256=lEsNBNxIEp89ZTTb612_YbJ5i12GAAAoThNDZL-Z6Zw,13647
 mdsvg/parser.py,sha256=baXDGY1R2bOEiOOSN7kcdoUfk-aYRHFUzd0y3ljRiBw,20722
 mdsvg/playground.py,sha256=5_VtVDAvCAoHvOTUAxeEkJTZXlQG600V5SShXGzXEM0,9719
 mdsvg/py.typed,sha256=JylgQapwARdMCQ670FrdEAaUuRXogmCrwnREf9g2qyQ,64
@@ -681,8 +681,8 @@ mdsvg/renderer.py,sha256=sGALb7S5tTNfQOQ1lfnSYCo3yWi-3d2HkG9BsP4ll7k,73919
 mdsvg/style.py,sha256=A3M1Nz4gaI-UJGOJvmiRdUn4s7VhFe60MQKHcqpnyl0,18837
 mdsvg/types.py,sha256=MQlqsUP5y78D8kX0brD-82DkBvaUYdbmkq1U95TnyWA,5093
 mdsvg/utils.py,sha256=CIqFACFaJiM0A_dl-hJXYhRqH-T7ayazP62wgfWGMjw,1866
-dataface-0.3.1.dev22.dist-info/METADATA,sha256=nD77aZrCMn4zZHF6N7xGA3_CpKIH1Cf_0Yv1eEe52cY,11417
-dataface-0.3.1.dev22.dist-info/WHEEL,sha256=lCkmxWfQsSc9CfIClYeavTdQeEX2toPqufh9gI35EQA,87
-dataface-0.3.1.dev22.dist-info/entry_points.txt,sha256=imfZRsAzmIbDRHW7jqhn0nT6EbYWAyOiuHisxmfVgXs,46
-dataface-0.3.1.dev22.dist-info/licenses/LICENSE,sha256=Iy9gBB2gC8WGQEwHxJd4-huwUvxB6OMOoT3no6emeaQ,11345
-dataface-0.3.1.dev22.dist-info/RECORD,,
+dataface-0.3.1.dev42.dist-info/METADATA,sha256=2tPMv98KBZKw9tzxY9cGt_k-YG1O36Fp_8tYpKwMzao,11417
+dataface-0.3.1.dev42.dist-info/WHEEL,sha256=lCkmxWfQsSc9CfIClYeavTdQeEX2toPqufh9gI35EQA,87
+dataface-0.3.1.dev42.dist-info/entry_points.txt,sha256=imfZRsAzmIbDRHW7jqhn0nT6EbYWAyOiuHisxmfVgXs,46
+dataface-0.3.1.dev42.dist-info/licenses/LICENSE,sha256=Iy9gBB2gC8WGQEwHxJd4-huwUvxB6OMOoT3no6emeaQ,11345
+dataface-0.3.1.dev42.dist-info/RECORD,,

mdsvg/images.py

@@ -2,11 +2,15 @@
 
 from __future__ import annotations
 
+import base64
+import binascii
+import re
 import struct
 from dataclasses import dataclass
 from pathlib import Path
 from typing import Callable, Dict, Optional
-from urllib.parse import urlparse
+from urllib.parse import unquote_to_bytes, urlparse
+from xml.etree import ElementTree
 
 # Type alias for URL mapping functions
 ImageUrlMapper = Callable[[str], str]
@@ -47,6 +51,12 @@ def get_image_size(
     Returns:
         ImageSize with width and height, or None if dimensions couldn't be determined.
 
+    Raises:
+        ValueError: For a structurally corrupt `data:` URI (no ',' separator,
+            invalid base64, or an `image/svg+xml` payload that is not XML).
+            A payload that is merely unmeasurable returns None like any other
+            source.
+
     Example:
         >>> size = get_image_size("/path/to/image.png")
         >>> if size:
@@ -56,6 +66,11 @@ def get_image_size(
     """
     parsed = urlparse(url)
 
+    # Inline payload — must not reach the filesystem, where a long base64 body
+    # trips ENAMETOOLONG instead of reporting a missing file.
+    if parsed.scheme == "data":
+        return _get_data_uri_image_size(url)
+
     # Check if it's a remote URL
     if parsed.scheme in ("http", "https"):
         return _get_remote_image_size(url, timeout)
@@ -64,6 +79,111 @@ def get_image_size(
     return _get_local_image_size(url, base_path)
 
 
+def _get_data_uri_image_size(url: str) -> Optional[ImageSize]:
+    """
+    Get dimensions from a `data:` URI by decoding its own payload.
+
+    Corrupt input raises: the author wrote bytes that cannot be an image, and
+    guessing would hide it. But a payload that is intact and simply not
+    measurable — a format the header parser doesn't know, or an SVG with no
+    intrinsic size — returns None, exactly as the local and remote branches do
+    for the same bytes. Measuring is best-effort here; the renderer owns the
+    fallback via `image_fallback_aspect_ratio`.
+    """
+    header, separator, payload = url[len("data:") :].partition(",")
+    if not separator:
+        raise ValueError("Malformed data: URI — no ',' separating header from payload")
+
+    # Media types and the base64 token are case-insensitive (RFC 2045), and a
+    # space after the ';' is common enough that browsers accept it.
+    parameters = [parameter.strip().lower() for parameter in header.split(";")]
+    media_type = parameters[0]
+
+    if "base64" in parameters[1:]:
+        # The URL spec's data: processor uses forgiving-base64, so browsers
+        # render an unpadded payload; b64decode would reject it as corrupt.
+        try:
+            data = base64.b64decode(payload + "=" * (-len(payload) % 4), validate=True)
+        except binascii.Error as e:
+            raise ValueError(
+                f"Malformed base64 payload in data:{media_type} URI: {e}"
+            ) from e
+    else:
+        data = unquote_to_bytes(payload)
+
+    if media_type == "image/svg+xml":
+        return _parse_svg_dimensions(data)
+    return _parse_image_dimensions(data)
+
+
+# SVG lengths only have a pixel size when unitless or in px; %, em, etc. do not.
+_SVG_PIXEL_LENGTH = re.compile(r"\s*([0-9]*\.?[0-9]+)(px)?\s*\Z")
+
+
+def _parse_svg_dimensions(data: bytes) -> Optional[ImageSize]:
+    """
+    Parse the intrinsic size of an SVG document: width/height, else viewBox.
+
+    None when the document genuinely has no intrinsic size — `width="100%"`
+    with no viewBox is the common case, and the consumer is meant to supply
+    one. Raises only when the payload is not XML at all.
+    """
+    # Decline to measure entity-declaring payloads rather than hand them to
+    # expat, which only caps entity amplification from 2.6 on and this package
+    # supports Pythons that may link an older one. Unmeasured, not corrupt:
+    # such a document is often perfectly valid, so it takes the fallback.
+    if b"<!ENTITY" in data:
+        return None
+
+    try:
+        root = ElementTree.fromstring(data)
+    except ElementTree.ParseError as e:
+        raise ValueError(f"Malformed XML in data:image/svg+xml URI: {e}") from e
+
+    size = _svg_image_size(
+        _parse_svg_length(root.get("width")), _parse_svg_length(root.get("height"))
+    )
+    return size if size is not None else _parse_svg_view_box(root.get("viewBox"))
+
+
+def _svg_image_size(
+    width: Optional[float], height: Optional[float]
+) -> Optional[ImageSize]:
+    """
+    Build an ImageSize from SVG lengths, or None if either has no pixel size.
+
+    The "no size" test has to run on the rounded value, not the parsed float:
+    a legal `width="0.4"` is positive but rounds to a zero-width ImageSize,
+    whose aspect_ratio is 0.0 and divides by zero in the renderer.
+    """
+    if width is None or height is None:
+        return None
+    size = ImageSize(width=round(width), height=round(height))
+    if size.width < 1 or size.height < 1:
+        return None
+    return size
+
+
+def _parse_svg_length(value: Optional[str]) -> Optional[float]:
+    """Parse an SVG length in pixels, or None if it has no pixel size."""
+    if value is None:
+        return None
+    match = _SVG_PIXEL_LENGTH.match(value)
+    return float(match.group(1)) if match else None
+
+
+def _parse_svg_view_box(value: Optional[str]) -> Optional[ImageSize]:
+    """Parse the width and height out of a `viewBox="min-x min-y width height"`."""
+    if value is None:
+        return None
+
+    parts = value.replace(",", " ").split()
+    if len(parts) != 4:
+        return None
+
+    return _svg_image_size(_parse_svg_length(parts[2]), _parse_svg_length(parts[3]))
+
+
 def _get_local_image_size(
     path: str,
     base_path: Optional[str] = None,